)]}'
{"openstack_dashboard/api/keystone.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"87f5364136ea5c58f7c9adec15728cf011875518","unresolved":false,"context_lines":[{"line_number":800,"context_line":"def mapping_create(request, mapping_id, rules):"},{"line_number":801,"context_line":"    manager \u003d keystoneclient(request, admin\u003dTrue).federation.mappings"},{"line_number":802,"context_line":"    return manager.create(mapping_id\u003dmapping_id,"},{"line_number":803,"context_line":"                          rules\u003drules)"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":""},{"line_number":806,"context_line":"def mapping_get(request, mapping_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_2a0585c1","line":803,"updated":"2015-11-24 20:20:06.000000000","message":"can go on previous line","commit_id":"062ac3d90cdeb90be4507c0f0b763bc505a96967"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"87f5364136ea5c58f7c9adec15728cf011875518","unresolved":false,"context_lines":[{"line_number":811,"context_line":"def mapping_update(request, mapping_id, rules):"},{"line_number":812,"context_line":"    manager \u003d keystoneclient(request, admin\u003dTrue).federation.mappings"},{"line_number":813,"context_line":"    return manager.update(mapping_id,"},{"line_number":814,"context_line":"                          rules\u003drules)"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":""},{"line_number":817,"context_line":"def mapping_delete(request, mapping_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_ca6f1991","line":814,"updated":"2015-11-24 20:20:06.000000000","message":"can go on previous line","commit_id":"062ac3d90cdeb90be4507c0f0b763bc505a96967"}],"openstack_dashboard/dashboards/identity/mappings/forms.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"6a6d5ee50b82a69c965bd897b7417675c6e35185","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            msg \u003d _(\u0027Mapping ID \"%s\" is already used.\u0027) % data[\"id\"]"},{"line_number":49,"context_line":"            messages.error(request, msg)"},{"line_number":50,"context_line":"        except (TypeError, ValueError):"},{"line_number":51,"context_line":"            msg \u003d _(\"Unable to create mapping. Rules has malformed JSON data.\")"},{"line_number":52,"context_line":"            messages.error(request, msg)"},{"line_number":53,"context_line":"        except Exception:"},{"line_number":54,"context_line":"            exceptions.handle(request,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a8ffd7b_5e88b022","line":51,"updated":"2015-11-25 01:36:15.000000000","message":"nice touch","commit_id":"719058ae728c59669d52d59999d2f5b9cc2452d2"}],"openstack_dashboard/dashboards/identity/mappings/panel.py":[{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"b27413ddc774b4d41f045274f1e1659a5c29595a","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @staticmethod"},{"line_number":28,"context_line":"    def can_register():"},{"line_number":29,"context_line":"        return (keystone.VERSIONS.active \u003e\u003d 3 and"},{"line_number":30,"context_line":"                keystone.is_federation_enabled())"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_345e0dea","line":29,"updated":"2015-11-23 12:29:32.000000000","message":"don\u0027t use magic numbers. a variable with meaningful name would be better.","commit_id":"803ba0820e1656cd32d4d649c62bb4804272edbf"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"f77b8f8879008dc67414a1d6bbc26696e3078393","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @staticmethod"},{"line_number":28,"context_line":"    def can_register():"},{"line_number":29,"context_line":"        return (keystone.VERSIONS.active \u003e\u003d 3 and"},{"line_number":30,"context_line":"                keystone.is_federation_enabled())"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_4f4bf72b","line":29,"in_reply_to":"ba8a016a_345e0dea","updated":"2015-11-23 15:40:21.000000000","message":"This matches exactly other uses in the Horizon code. I don\u0027t think we should block the patch on this.\n\nMarek: does python-keystoneclient provide constants for doing this sort of version comparison? If not convinced they are needed, but if we wanted to use such constants I\u0027d expect them to originate there.","commit_id":"803ba0820e1656cd32d4d649c62bb4804272edbf"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"a1f0350e75fc56b6b54bd917c86efc25e9597fc9","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @staticmethod"},{"line_number":28,"context_line":"    def can_register():"},{"line_number":29,"context_line":"        return (keystone.VERSIONS.active \u003e\u003d 3 and"},{"line_number":30,"context_line":"                keystone.is_federation_enabled())"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_9898996c","line":29,"in_reply_to":"ba8a016a_4f4bf72b","updated":"2015-11-24 11:57:07.000000000","message":"I agree about not using constants here.\n\nI like to tackle that as follow-up patch, as other part of the code needs to be cleaned up too.","commit_id":"803ba0820e1656cd32d4d649c62bb4804272edbf"}],"openstack_dashboard/dashboards/identity/mappings/tables.py":[{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"b27413ddc774b4d41f045274f1e1659a5c29595a","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            u\"Deleted Mappings\","},{"line_number":58,"context_line":"            count"},{"line_number":59,"context_line":"        )"},{"line_number":60,"context_line":"    policy_rules \u003d ((\"identity\", \"identity:delete_mapping\"),)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def delete(self, request, obj_id):"},{"line_number":63,"context_line":"        api.keystone.mapping_delete(request, obj_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_342ccd49","line":60,"updated":"2015-11-23 12:29:32.000000000","message":"is there any reason why this is placed here, between the method definitions?","commit_id":"803ba0820e1656cd32d4d649c62bb4804272edbf"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"f77b8f8879008dc67414a1d6bbc26696e3078393","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            u\"Deleted Mappings\","},{"line_number":58,"context_line":"            count"},{"line_number":59,"context_line":"        )"},{"line_number":60,"context_line":"    policy_rules \u003d ((\"identity\", \"identity:delete_mapping\"),)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def delete(self, request, obj_id):"},{"line_number":63,"context_line":"        api.keystone.mapping_delete(request, obj_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_f5cf15b1","line":60,"in_reply_to":"ba8a016a_342ccd49","updated":"2015-11-23 15:40:21.000000000","message":"Marek, we\u0027ve generally followed the the convention of putting statics first (though I don\u0027t recall any specific discussion or enforcement of this). Are you aware of other conventions that would suggest a different order?","commit_id":"803ba0820e1656cd32d4d649c62bb4804272edbf"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"a1f0350e75fc56b6b54bd917c86efc25e9597fc9","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            u\"Deleted Mappings\","},{"line_number":58,"context_line":"            count"},{"line_number":59,"context_line":"        )"},{"line_number":60,"context_line":"    policy_rules \u003d ((\"identity\", \"identity:delete_mapping\"),)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def delete(self, request, obj_id):"},{"line_number":63,"context_line":"        api.keystone.mapping_delete(request, obj_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_b8b47dd1","line":60,"in_reply_to":"ba8a016a_f5cf15b1","updated":"2015-11-24 11:57:07.000000000","message":"now that you mentioned it, yeah it does look weird that this comes after the method definitions.","commit_id":"803ba0820e1656cd32d4d649c62bb4804272edbf"}],"openstack_dashboard/dashboards/identity/mappings/templates/mappings/_create.html":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"87f5364136ea5c58f7c9adec15728cf011875518","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% block modal-body-right %}"},{"line_number":5,"context_line":"  \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"},{"line_number":6,"context_line":"  \u003cp\u003e{% trans \"Create a mapping.\" %}\u003c/p\u003e"},{"line_number":7,"context_line":"  \u003cp\u003e{% trans \"A mapping is a set of rules to map federation protocol attributes to Identity API objects. An identity provider can have a single mapping specified per protocol. A mapping is simply a list of rules. The only Identity API objects that will support mapping are: group.\" %}\u003c/p\u003e"},{"line_number":8,"context_line":"  \u003cp\u003e{% trans \"A rule contains a remote attribute description and the destination local attribute.\" %}\u003c/p\u003e"},{"line_number":9,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":5,"id":"9a8ffd7b_9487e660","line":7,"updated":"2015-11-24 20:20:06.000000000","message":"user and group*","commit_id":"062ac3d90cdeb90be4507c0f0b763bc505a96967"}]}
