)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14151,"name":"ziyu032","email":"chen.qiaomin@99cloud.net","username":"ziyu032"},"change_message_id":"a87858b75e9f1b75d2447f86ee319893b29a5907","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rob Cresswell \u003crobert.cresswell@outlook.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-17 15:09:09 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updates horizon\u0027s copy of the cinder policy file"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7b83f0d97c330c9fe996fb752f6de57561295bde"},{"line_number":10,"context_line":"Closes-Bug: 1582725"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bab6814e_cd627e16","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":7},"updated":"2016-05-18 08:08:17.000000000","message":"Update","commit_id":"7e2d7584f785ce657826bc3c447322aaad1613ff"}],"openstack_dashboard/conf/cinder_policy.json":[{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"6bf3b7b1d6d96c0ff2173273792f67bbd8080961","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    \"volume:update_volume_admin_metadata\": \"rule:admin_api\","},{"line_number":17,"context_line":"    \"volume:get_snapshot\": \"rule:admin_or_owner\","},{"line_number":18,"context_line":"    \"volume:get_all_snapshots\": \"rule:admin_or_owner\","},{"line_number":19,"context_line":"    \"volume:delete_snapshot\": \"rule:admin_or_owner\","},{"line_number":20,"context_line":"    \"volume:update_snapshot\": \"rule:admin_or_owner\","},{"line_number":21,"context_line":"    \"volume:extend\": \"rule:admin_or_owner\","},{"line_number":22,"context_line":"    \"volume:update_readonly_flag\": \"rule:admin_or_owner\","}],"source_content_type":"application/json","patch_set":2,"id":"7a5de9d1_ebddc1e0","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":4},"updated":"2016-01-29 13:57:05.000000000","message":"you are missing  \"volume:create_snapshot\": \"rule:admin_or_owner\", here","commit_id":"be7ba6e2c6c236ba1cc823bbd09e741ba516c840"},{"author":{"_account_id":6162,"name":"Dan Nguyen","email":"dan.nguyens.mail@gmail.com","username":"daniel-a-nguyen"},"change_message_id":"af68565ef5482795169cf512009be4b2f09748a0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    \"volume:update_volume_admin_metadata\": \"rule:admin_api\","},{"line_number":17,"context_line":"    \"volume:get_snapshot\": \"rule:admin_or_owner\","},{"line_number":18,"context_line":"    \"volume:get_all_snapshots\": \"rule:admin_or_owner\","},{"line_number":19,"context_line":"    \"volume:delete_snapshot\": \"rule:admin_or_owner\","},{"line_number":20,"context_line":"    \"volume:update_snapshot\": \"rule:admin_or_owner\","},{"line_number":21,"context_line":"    \"volume:extend\": \"rule:admin_or_owner\","},{"line_number":22,"context_line":"    \"volume:update_readonly_flag\": \"rule:admin_or_owner\","}],"source_content_type":"application/json","patch_set":2,"id":"7a5de9d1_c3f0d0ff","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":4},"in_reply_to":"7a5de9d1_ebddc1e0","updated":"2016-01-30 01:45:06.000000000","message":"thx for catching that!","commit_id":"be7ba6e2c6c236ba1cc823bbd09e741ba516c840"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"6bf3b7b1d6d96c0ff2173273792f67bbd8080961","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"volume_extension:volume_image_metadata\": \"rule:admin_or_owner\","},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    \"volume_extension:quotas:show\": \"\","},{"line_number":38,"context_line":"    \"volume_extension:quotas:update\": \"rule:admin_api\","},{"line_number":39,"context_line":"    \"volume_extension:quota_classes\": \"rule:admin_api\","},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    \"volume_extension:volume_admin_actions:reset_status\": \"rule:admin_api\","}],"source_content_type":"application/json","patch_set":2,"id":"7a5de9d1_2b6bd9f2","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":5},"updated":"2016-01-29 13:57:05.000000000","message":"you are missing  \"volume:create_snapshot\": \"rule:admin_or_owner\", here.  This policy file should match the policy file in https://github.com/openstack/cinder/blob/master/etc/cinder/policy.json","commit_id":"be7ba6e2c6c236ba1cc823bbd09e741ba516c840"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"90aebdbe4d9a0b778234ceff9a01004110e19ea4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"volume_extension:volume_image_metadata\": \"rule:admin_or_owner\","},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    \"volume_extension:quotas:show\": \"\","},{"line_number":38,"context_line":"    \"volume_extension:quotas:update\": \"rule:admin_api\","},{"line_number":39,"context_line":"    \"volume_extension:quota_classes\": \"rule:admin_api\","},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    \"volume_extension:volume_admin_actions:reset_status\": \"rule:admin_api\","}],"source_content_type":"application/json","patch_set":2,"id":"7a5de9d1_b6e5ed38","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":5},"in_reply_to":"7a5de9d1_2b6bd9f2","updated":"2016-01-29 14:56:18.000000000","message":"Sorry for the cut and paste error. The action missing is  \"volume_extension:quotas:delete\": \"rule:admin_api\",\nfrom the cinder policy.json file.","commit_id":"be7ba6e2c6c236ba1cc823bbd09e741ba516c840"},{"author":{"_account_id":6162,"name":"Dan Nguyen","email":"dan.nguyens.mail@gmail.com","username":"daniel-a-nguyen"},"change_message_id":"af68565ef5482795169cf512009be4b2f09748a0","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"volume_extension:volume_image_metadata\": \"rule:admin_or_owner\","},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    \"volume_extension:quotas:show\": \"\","},{"line_number":38,"context_line":"    \"volume_extension:quotas:update\": \"rule:admin_api\","},{"line_number":39,"context_line":"    \"volume_extension:quota_classes\": \"rule:admin_api\","},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    \"volume_extension:volume_admin_actions:reset_status\": \"rule:admin_api\","}],"source_content_type":"application/json","patch_set":2,"id":"7a5de9d1_43e5c035","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":5},"in_reply_to":"7a5de9d1_b6e5ed38","updated":"2016-01-30 01:45:06.000000000","message":"thx again.  will update soon after addressing other comments.","commit_id":"be7ba6e2c6c236ba1cc823bbd09e741ba516c840"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"39a0ddf20c032654cfc831a5532b6c7b6b28af70","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    \"volume:get_all_snapshots\": [],"},{"line_number":21,"context_line":"    \"volume:extend\": [],"},{"line_number":22,"context_line":"    \"volume:retype\": [],"},{"line_number":23,"context_line":"    \"volume:upload_to_image\": [],"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    \"volume_extension:types_manage\": [[\"rule:admin_api\"]],"},{"line_number":26,"context_line":"    \"volume_extension:types_extra_specs\": [[\"rule:admin_api\"]],"}],"source_content_type":"application/json","patch_set":6,"id":"dab17558_15283885","side":"PARENT","line":23,"range":{"start_line":23,"start_character":12,"end_line":23,"end_character":27},"updated":"2016-05-17 13:45:39.000000000","message":"The Horizon code uses this action and it is not the same action in the cinder policy.json file.  Until bug https://bugs.launchpad.net/horizon/+bug/1582725 is addressed the Horizon file will need this line","commit_id":"1e618e45047dd8e728b78364f860ed503dc39247"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"7151449620a93cbdcf4bb2fc120f3e6dc002f667","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    \"volume:get_all_snapshots\": [],"},{"line_number":21,"context_line":"    \"volume:extend\": [],"},{"line_number":22,"context_line":"    \"volume:retype\": [],"},{"line_number":23,"context_line":"    \"volume:upload_to_image\": [],"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    \"volume_extension:types_manage\": [[\"rule:admin_api\"]],"},{"line_number":26,"context_line":"    \"volume_extension:types_extra_specs\": [[\"rule:admin_api\"]],"}],"source_content_type":"application/json","patch_set":6,"id":"dab17558_d504f018","side":"PARENT","line":23,"range":{"start_line":23,"start_character":12,"end_line":23,"end_character":27},"in_reply_to":"dab17558_15283885","updated":"2016-05-17 14:05:11.000000000","message":"I\u0027ll fix that as part of this patch. Seems the most sensible way to do it.","commit_id":"1e618e45047dd8e728b78364f860ed503dc39247"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"0be2039ed14bcbd274c17ed07b2a4a20b57eb261","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    \"volume_extension:volume_admin_actions:migrate_volume\": \"rule:admin_api\","},{"line_number":53,"context_line":"    \"volume_extension:volume_admin_actions:migrate_volume_completion\": \"rule:admin_api\","},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    \"volume_extension:volume_actions:upload_public\": \"rule:admin_api\","},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    \"volume_extension:volume_host_attribute\": \"rule:admin_api\","},{"line_number":58,"context_line":"    \"volume_extension:volume_tenant_attribute\": \"rule:admin_or_owner\","}],"source_content_type":"application/json","patch_set":8,"id":"bab6814e_c5b6a789","line":55,"updated":"2016-05-18 19:55:09.000000000","message":"missing https://github.com/openstack/cinder/blob/master/etc/cinder/policy.json#L59","commit_id":"d650847b31b7eb421b2a3a81352bbee5fd08eb84"}],"openstack_dashboard/dashboards/project/volumes/volumes/tables.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"0feae02589a7361b23b8ca2728e14ee2a702fc58","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    url \u003d \"horizon:project:volumes:volumes:upload_to_image\""},{"line_number":218,"context_line":"    classes \u003d (\"ajax-modal\",)"},{"line_number":219,"context_line":"    icon \u003d \"cloud-upload\""},{"line_number":220,"context_line":"    policy_rules \u003d ((\"volume\", \"volume:upload_to_image\"),)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def allowed(self, request, volume\u003dNone):"},{"line_number":223,"context_line":"        has_image_service_perm \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_e53dc78e","side":"PARENT","line":220,"updated":"2015-12-03 08:17:31.000000000","message":"removing this will break backward compatibility.\n\nI suggest keeping it as is, or updating the policy rule to do an  \u003cold rule\u003e OR \u003cnew rule\u003e","commit_id":"ab7d5c3ec5317dea2495b958c9f82b2716ba4b5a"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"90aebdbe4d9a0b778234ceff9a01004110e19ea4","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    url \u003d \"horizon:project:volumes:volumes:upload_to_image\""},{"line_number":218,"context_line":"    classes \u003d (\"ajax-modal\",)"},{"line_number":219,"context_line":"    icon \u003d \"cloud-upload\""},{"line_number":220,"context_line":"    policy_rules \u003d ((\"volume\", \"volume:upload_to_image\"),)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def allowed(self, request, volume\u003dNone):"},{"line_number":223,"context_line":"        has_image_service_perm \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_76be9566","side":"PARENT","line":220,"in_reply_to":"7a5de9d1_9d51f438","updated":"2016-01-29 14:56:18.000000000","message":"Cinder code uses policy action volume_action:upload_image, see https://github.com/openstack/cinder/blob/master/cinder/api/contrib/volume_actions.py \nline 35 action \u003d \u0027volume_actions:%s\u0027 % action_name\nline 272 authorize(context, \"upload_image\")\n\nThis is a bug in the Cinder, to update the policy.json file since it is missing action volume_action:upload_image. I will submit a Bug to fix this in Cinder. In the bug I will ask to see if the action should be volume_actions:upload_image or volume:upload_image.\n\nAt this time I would not change this code until Cinder updates it policy.json for this action.","commit_id":"ab7d5c3ec5317dea2495b958c9f82b2716ba4b5a"},{"author":{"_account_id":17887,"name":"Doug Schveninger","email":"ds6901@att.com","username":"Doug.Schveninger"},"change_message_id":"6bf3b7b1d6d96c0ff2173273792f67bbd8080961","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    url \u003d \"horizon:project:volumes:volumes:upload_to_image\""},{"line_number":218,"context_line":"    classes \u003d (\"ajax-modal\",)"},{"line_number":219,"context_line":"    icon \u003d \"cloud-upload\""},{"line_number":220,"context_line":"    policy_rules \u003d ((\"volume\", \"volume:upload_to_image\"),)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def allowed(self, request, volume\u003dNone):"},{"line_number":223,"context_line":"        has_image_service_perm \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_9d51f438","side":"PARENT","line":220,"in_reply_to":"7a740942_2ead9c88","updated":"2016-01-29 13:57:05.000000000","message":"upload_to_image is a glance policy.son file action.  I am looking into this some more and repost if I find anything","commit_id":"ab7d5c3ec5317dea2495b958c9f82b2716ba4b5a"},{"author":{"_account_id":6162,"name":"Dan Nguyen","email":"dan.nguyens.mail@gmail.com","username":"daniel-a-nguyen"},"change_message_id":"dad5d0143276bd844c20c8cd6fda1abb3e5a8a47","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    url \u003d \"horizon:project:volumes:volumes:upload_to_image\""},{"line_number":218,"context_line":"    classes \u003d (\"ajax-modal\",)"},{"line_number":219,"context_line":"    icon \u003d \"cloud-upload\""},{"line_number":220,"context_line":"    policy_rules \u003d ((\"volume\", \"volume:upload_to_image\"),)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def allowed(self, request, volume\u003dNone):"},{"line_number":223,"context_line":"        has_image_service_perm \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_2ead9c88","side":"PARENT","line":220,"in_reply_to":"9a8ffd7b_e53dc78e","updated":"2015-12-03 17:27:37.000000000","message":"Yeah, that\u0027s a good point actually.  Let me test again.  I thought that the policy check in horizon would ignore rules that are not found and just rely on the API to validate.  I\u0027ll take a look and see if that\u0027s true.\n\nThx!","commit_id":"ab7d5c3ec5317dea2495b958c9f82b2716ba4b5a"},{"author":{"_account_id":6162,"name":"Dan Nguyen","email":"dan.nguyens.mail@gmail.com","username":"daniel-a-nguyen"},"change_message_id":"d848f0bdf72e90f172c6c2eaa9c8fd9eae08ea18","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    url \u003d \"horizon:project:volumes:volumes:upload_to_image\""},{"line_number":218,"context_line":"    classes \u003d (\"ajax-modal\",)"},{"line_number":219,"context_line":"    icon \u003d \"cloud-upload\""},{"line_number":220,"context_line":"    policy_rules \u003d ((\"volume\", \"volume:update\"),)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def allowed(self, request, volume\u003dNone):"},{"line_number":223,"context_line":"        has_image_service_perm \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_41d02bc9","line":220,"updated":"2015-12-14 21:55:39.000000000","message":"I tested this locally with the previous cinder policy file and it seems to be working ok.","commit_id":"be7ba6e2c6c236ba1cc823bbd09e741ba516c840"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"091a291d5c9bd2f0b51db7112f16471987219288","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    url \u003d \"horizon:project:volumes:volumes:upload_to_image\""},{"line_number":218,"context_line":"    classes \u003d (\"ajax-modal\",)"},{"line_number":219,"context_line":"    icon \u003d \"cloud-upload\""},{"line_number":220,"context_line":"    policy_rules \u003d ((\"volume\", \"volume:update\"),)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def allowed(self, request, volume\u003dNone):"},{"line_number":223,"context_line":"        has_image_service_perm \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_beb556ed","line":220,"in_reply_to":"7a740942_41d02bc9","updated":"2016-01-15 18:53:51.000000000","message":"in the old policy file upload_to_image and update both uses the default policy so the behavior is the same.\n\n\nI am thinking of the case when the operator change the rule for upload_to_image to be different from volume_update, this update will break it for them.\n\n\nI will for now, we can change the policy to upload_to_image OR update, then mark the  upload_to_image deprecated and to be removed in two cycles.","commit_id":"be7ba6e2c6c236ba1cc823bbd09e741ba516c840"},{"author":{"_account_id":14151,"name":"ziyu032","email":"chen.qiaomin@99cloud.net","username":"ziyu032"},"change_message_id":"a87858b75e9f1b75d2447f86ee319893b29a5907","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    url \u003d \"horizon:project:volumes:volumes:upload_to_image\""},{"line_number":243,"context_line":"    classes \u003d (\"ajax-modal\",)"},{"line_number":244,"context_line":"    icon \u003d \"cloud-upload\""},{"line_number":245,"context_line":"    policy_rules \u003d ((\"volume\", \"volume_extension:volume_actions:upload_public\"),)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    def allowed(self, request, volume\u003dNone):"},{"line_number":248,"context_line":"        has_image_service_perm \u003d \\"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_b0782d91","line":245,"range":{"start_line":245,"start_character":4,"end_line":245,"end_character":81},"updated":"2016-05-18 08:08:17.000000000","message":"more than 79 characters, so pep8 error","commit_id":"7e2d7584f785ce657826bc3c447322aaad1613ff"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"0be2039ed14bcbd274c17ed07b2a4a20b57eb261","unresolved":false,"context_lines":[{"line_number":243,"context_line":"    classes \u003d (\"ajax-modal\",)"},{"line_number":244,"context_line":"    icon \u003d \"cloud-upload\""},{"line_number":245,"context_line":"    policy_rules \u003d ((\"volume\","},{"line_number":246,"context_line":"                     \"volume_extension:volume_actions:upload_public\"),)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def allowed(self, request, volume\u003dNone):"},{"line_number":249,"context_line":"        has_image_service_perm \u003d \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_c59fc701","line":246,"updated":"2016-05-18 19:55:09.000000000","message":"should this be  \"volume_extension:volume_actions:upload_image\" instead?\n\nhttps://github.com/openstack/cinder/blob/master/etc/cinder/policy.json#L59","commit_id":"d650847b31b7eb421b2a3a81352bbee5fd08eb84"}]}
