)]}'
{"openstack_dashboard/dashboards/project/access_and_security/security_groups/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"58475e65a572e869aa8b0b1c13589e0ecb8a8fdd","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    icmp_type \u003d forms.IntegerField(label\u003d_(\"Type\"),"},{"line_number":181,"context_line":"                                   required\u003dFalse,"},{"line_number":182,"context_line":"                                   help_text\u003d_(\"Enter a value for ICMP type \""},{"line_number":183,"context_line":"                                               \"in the range (0: 255)\"),"},{"line_number":184,"context_line":"                                   widget\u003dforms.TextInput(attrs\u003d{"},{"line_number":185,"context_line":"                                       \u0027class\u0027: \u0027switched\u0027,"},{"line_number":186,"context_line":"                                       \u0027data-switch-on\u0027: \u0027rule_menu\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_bbe88911","line":183,"updated":"2015-11-26 04:54:18.000000000","message":"IIRC -1 means ANY. How can we specify ANY? Does a blank mean ANY?\nIf so, you need to add a description. In Nova security group, -1 means ANY. In Neutron security group, None means ANY. Could you check both cases?","commit_id":"8e55c4732c1a6a8c471eda9dd9109d8d7b7b1228"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6cd6393447013bd29101add1297f04d5249456d4","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    icmp_type \u003d forms.IntegerField(label\u003d_(\"Type\"),"},{"line_number":181,"context_line":"                                   required\u003dFalse,"},{"line_number":182,"context_line":"                                   help_text\u003d_(\"Enter a value for ICMP type \""},{"line_number":183,"context_line":"                                               \"in the range (0: 255)\"),"},{"line_number":184,"context_line":"                                   widget\u003dforms.TextInput(attrs\u003d{"},{"line_number":185,"context_line":"                                       \u0027class\u0027: \u0027switched\u0027,"},{"line_number":186,"context_line":"                                       \u0027data-switch-on\u0027: \u0027rule_menu\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_d9708774","line":183,"in_reply_to":"9a8ffd7b_af828392","updated":"2015-11-29 08:27:03.000000000","message":"Why do we need to prevent users from specifying \"ANY\" for ICMP type or code in \"Custom ICMP Rule\"? Nova and Neutron SG API allows us to specify a rule with a specific ICMP type and ANY for ICMP code (or vice versa). I don\u0027t think we need to apply extra constraints in Horizon. In the original design, we would like to support all combinations of rule specifications in \"Custom XXX rule\". Other menus are just to provide a shortcut.","commit_id":"8e55c4732c1a6a8c471eda9dd9109d8d7b7b1228"},{"author":{"_account_id":18930,"name":"Suraj Deshmukh","email":"surajssd009005@gmail.com","username":"suraj.deshmukh"},"change_message_id":"c60be16197b2c5b36d285c6ecdb23d1f374ddd2a","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    icmp_type \u003d forms.IntegerField(label\u003d_(\"Type\"),"},{"line_number":181,"context_line":"                                   required\u003dFalse,"},{"line_number":182,"context_line":"                                   help_text\u003d_(\"Enter a value for ICMP type \""},{"line_number":183,"context_line":"                                               \"in the range (0: 255)\"),"},{"line_number":184,"context_line":"                                   widget\u003dforms.TextInput(attrs\u003d{"},{"line_number":185,"context_line":"                                       \u0027class\u0027: \u0027switched\u0027,"},{"line_number":186,"context_line":"                                       \u0027data-switch-on\u0027: \u0027rule_menu\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_af828392","line":183,"in_reply_to":"9a8ffd7b_bbe88911","updated":"2015-11-26 06:46:44.000000000","message":"In its current implementation, while adding a new rule if \"Custom ICMP Rule\" is selected it is mandatory to provide \u0027ICMP type\u0027 and \u0027ICMP code\u0027 fields. If you want to allow \u0027any\u0027 ICMP then the newer \"All ICMP\" rule must be selected.","commit_id":"8e55c4732c1a6a8c471eda9dd9109d8d7b7b1228"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"e1cb6fb38b70524d2f06c946772bc9ae6833e7e8","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    icmp_type \u003d forms.IntegerField(label\u003d_(\"Type\"),"},{"line_number":181,"context_line":"                                   required\u003dFalse,"},{"line_number":182,"context_line":"                                   help_text\u003d_(\"Enter a value for ICMP type \""},{"line_number":183,"context_line":"                                               \"in the range (0: 255)\"),"},{"line_number":184,"context_line":"                                   widget\u003dforms.TextInput(attrs\u003d{"},{"line_number":185,"context_line":"                                       \u0027class\u0027: \u0027switched\u0027,"},{"line_number":186,"context_line":"                                       \u0027data-switch-on\u0027: \u0027rule_menu\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_7a84090a","line":183,"in_reply_to":"9a8ffd7b_d9708774","updated":"2015-12-21 10:03:51.000000000","message":"I would vote for being consistent here and agreed on doing ONE thing for both Nova and Neutron, at least on the user-facing part.\n\nIf Any is empty, lets do empty for both. If any is -1 lets do it for both. We can afterwards do the logic on our side, but we can try to make life easier for the operators and patch the inconsistency in nova vs neutron from our side.\n\nI would vote for -1 for both nova and neutron.","commit_id":"8e55c4732c1a6a8c471eda9dd9109d8d7b7b1228"},{"author":{"_account_id":18930,"name":"Suraj Deshmukh","email":"surajssd009005@gmail.com","username":"suraj.deshmukh"},"change_message_id":"c60be16197b2c5b36d285c6ecdb23d1f374ddd2a","unresolved":false,"context_lines":[{"line_number":187,"context_line":"                                       \u0027data-rule_menu-icmp\u0027: _(\u0027Type\u0027)}),"},{"line_number":188,"context_line":"                                   validators\u003d["},{"line_number":189,"context_line":"                                       utils_validators."},{"line_number":190,"context_line":"                                       validate_icmp_type_range])"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    icmp_code \u003d forms.IntegerField(label\u003d_(\"Code\"),"},{"line_number":193,"context_line":"                                   required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_caf8154c","line":190,"updated":"2015-11-26 06:46:44.000000000","message":"When a validator is raising any exception here, this field is set to None as well as that error shows up in the field just below the field on the form.","commit_id":"8e55c4732c1a6a8c471eda9dd9109d8d7b7b1228"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"58475e65a572e869aa8b0b1c13589e0ecb8a8fdd","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    icmp_code \u003d forms.IntegerField(label\u003d_(\"Code\"),"},{"line_number":193,"context_line":"                                   required\u003dFalse,"},{"line_number":194,"context_line":"                                   help_text\u003d_(\"Enter a value for ICMP code \""},{"line_number":195,"context_line":"                                               \"in the range (0: 255)\"),"},{"line_number":196,"context_line":"                                   widget\u003dforms.TextInput(attrs\u003d{"},{"line_number":197,"context_line":"                                       \u0027class\u0027: \u0027switched\u0027,"},{"line_number":198,"context_line":"                                       \u0027data-switch-on\u0027: \u0027rule_menu\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_bb5649d0","line":195,"updated":"2015-11-26 04:54:18.000000000","message":"Same as the above.","commit_id":"8e55c4732c1a6a8c471eda9dd9109d8d7b7b1228"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"eae1f4e72e47fc68a1a66b8709896d6ae2f86ed4","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        icmp_code \u003d cleaned_data.get(\"icmp_code\", None)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        self._update_and_pop_error(cleaned_data, \u0027ip_protocol\u0027, rule_menu)"},{"line_number":295,"context_line":"        if self.errors.get(\u0027icmp_type\u0027):"},{"line_number":296,"context_line":"            msg \u003d _(\u0027The ICMP type not in range (0, 255)\u0027)"},{"line_number":297,"context_line":"            raise ValidationError(msg)"},{"line_number":298,"context_line":"        if self.errors.get(\u0027icmp_code\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_b0c69647","line":295,"updated":"2015-11-25 11:47:05.000000000","message":"the error already present in the field. but again you are raising a validation error here. i feel it is not required.","commit_id":"8e55c4732c1a6a8c471eda9dd9109d8d7b7b1228"},{"author":{"_account_id":18930,"name":"Suraj Deshmukh","email":"surajssd009005@gmail.com","username":"suraj.deshmukh"},"change_message_id":"c60be16197b2c5b36d285c6ecdb23d1f374ddd2a","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        icmp_code \u003d cleaned_data.get(\"icmp_code\", None)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        self._update_and_pop_error(cleaned_data, \u0027ip_protocol\u0027, rule_menu)"},{"line_number":295,"context_line":"        if self.errors.get(\u0027icmp_type\u0027):"},{"line_number":296,"context_line":"            msg \u003d _(\u0027The ICMP type not in range (0, 255)\u0027)"},{"line_number":297,"context_line":"            raise ValidationError(msg)"},{"line_number":298,"context_line":"        if self.errors.get(\u0027icmp_code\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_4aa3c54f","line":295,"in_reply_to":"9a8ffd7b_293c53e1","updated":"2015-11-26 06:46:44.000000000","message":"IMHO I feel this is consistent with previous implementation and implementations in other places in the same file. For this I have commented on the source in the same file in function \u0027_clean_rule_tcp_udp\u0027 below.\n\nAlso the exception that is raised here is shown as an error on top on the form, while the errors in respective fields are shown below that field, as commented above.\n\nSo in all at least two errors are shown on the form, one on top of form and one below the field that has caused this error.\n\nCorrect me if I am wrong though.","commit_id":"8e55c4732c1a6a8c471eda9dd9109d8d7b7b1228"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"58475e65a572e869aa8b0b1c13589e0ecb8a8fdd","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        icmp_code \u003d cleaned_data.get(\"icmp_code\", None)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        self._update_and_pop_error(cleaned_data, \u0027ip_protocol\u0027, rule_menu)"},{"line_number":295,"context_line":"        if self.errors.get(\u0027icmp_type\u0027):"},{"line_number":296,"context_line":"            msg \u003d _(\u0027The ICMP type not in range (0, 255)\u0027)"},{"line_number":297,"context_line":"            raise ValidationError(msg)"},{"line_number":298,"context_line":"        if self.errors.get(\u0027icmp_code\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_293c53e1","line":295,"in_reply_to":"9a8ffd7b_3ca59db4","updated":"2015-11-26 04:54:18.000000000","message":"agree.","commit_id":"8e55c4732c1a6a8c471eda9dd9109d8d7b7b1228"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6cd6393447013bd29101add1297f04d5249456d4","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        icmp_code \u003d cleaned_data.get(\"icmp_code\", None)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        self._update_and_pop_error(cleaned_data, \u0027ip_protocol\u0027, rule_menu)"},{"line_number":295,"context_line":"        if self.errors.get(\u0027icmp_type\u0027):"},{"line_number":296,"context_line":"            msg \u003d _(\u0027The ICMP type not in range (0, 255)\u0027)"},{"line_number":297,"context_line":"            raise ValidationError(msg)"},{"line_number":298,"context_line":"        if self.errors.get(\u0027icmp_code\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_593257a8","line":295,"in_reply_to":"9a8ffd7b_4aa3c54f","updated":"2015-11-29 08:27:03.000000000","message":"As I commented below in the TCP/UDP method, I am okay with changing the place where an error pop-up is displayed.","commit_id":"8e55c4732c1a6a8c471eda9dd9109d8d7b7b1228"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"9dd01480c6e01d9cee2f32bd9c245e1957f5eb25","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        icmp_code \u003d cleaned_data.get(\"icmp_code\", None)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        self._update_and_pop_error(cleaned_data, \u0027ip_protocol\u0027, rule_menu)"},{"line_number":295,"context_line":"        if self.errors.get(\u0027icmp_type\u0027):"},{"line_number":296,"context_line":"            msg \u003d _(\u0027The ICMP type not in range (0, 255)\u0027)"},{"line_number":297,"context_line":"            raise ValidationError(msg)"},{"line_number":298,"context_line":"        if self.errors.get(\u0027icmp_code\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_3ca59db4","line":295,"in_reply_to":"9a8ffd7b_b0c69647","updated":"2015-11-25 12:38:59.000000000","message":"agree, we have raised ValidationError in utils","commit_id":"8e55c4732c1a6a8c471eda9dd9109d8d7b7b1228"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"eae1f4e72e47fc68a1a66b8709896d6ae2f86ed4","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        if self.errors.get(\u0027icmp_type\u0027):"},{"line_number":296,"context_line":"            msg \u003d _(\u0027The ICMP type not in range (0, 255)\u0027)"},{"line_number":297,"context_line":"            raise ValidationError(msg)"},{"line_number":298,"context_line":"        if self.errors.get(\u0027icmp_code\u0027):"},{"line_number":299,"context_line":"            msg \u003d _(\u0027The ICMP code not in range (0, 255)\u0027)"},{"line_number":300,"context_line":"            raise ValidationError(msg)"},{"line_number":301,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_70c02e2b","line":298,"updated":"2015-11-25 11:47:05.000000000","message":"dito","commit_id":"8e55c4732c1a6a8c471eda9dd9109d8d7b7b1228"},{"author":{"_account_id":18930,"name":"Suraj Deshmukh","email":"surajssd009005@gmail.com","username":"suraj.deshmukh"},"change_message_id":"c60be16197b2c5b36d285c6ecdb23d1f374ddd2a","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        self._update_and_pop_error(cleaned_data, \u0027icmp_type\u0027, None)"},{"line_number":315,"context_line":"        if port_or_range \u003d\u003d \"port\":"},{"line_number":316,"context_line":"            self._update_and_pop_error(cleaned_data, \u0027from_port\u0027, port)"},{"line_number":317,"context_line":"            self._update_and_pop_error(cleaned_data, \u0027to_port\u0027, port)"},{"line_number":318,"context_line":"            if port is None:"},{"line_number":319,"context_line":"                msg \u003d _(\u0027The specified port is invalid.\u0027)"},{"line_number":320,"context_line":"                raise ValidationError(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_5e2706b6","line":317,"updated":"2015-11-26 06:46:44.000000000","message":"I have made changes consistent with this method, here you can see that exception is raised again even if validator is raising the exception before. This is how I have implemented above.\n\nIn this form everywhere this is how it is implemented. Two errors at least are shown one in top of form and one below the error causing field.","commit_id":"8e55c4732c1a6a8c471eda9dd9109d8d7b7b1228"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6cd6393447013bd29101add1297f04d5249456d4","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        self._update_and_pop_error(cleaned_data, \u0027icmp_type\u0027, None)"},{"line_number":315,"context_line":"        if port_or_range \u003d\u003d \"port\":"},{"line_number":316,"context_line":"            self._update_and_pop_error(cleaned_data, \u0027from_port\u0027, port)"},{"line_number":317,"context_line":"            self._update_and_pop_error(cleaned_data, \u0027to_port\u0027, port)"},{"line_number":318,"context_line":"            if port is None:"},{"line_number":319,"context_line":"                msg \u003d _(\u0027The specified port is invalid.\u0027)"},{"line_number":320,"context_line":"                raise ValidationError(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_19284f32","line":317,"in_reply_to":"9a8ffd7b_5e2706b6","updated":"2015-11-29 08:27:03.000000000","message":"I am okay you change the place where an error message is displayed. IMHO an error message next to a form is easier to understand. I am okay that you make the change either in this patch or in a follow-up patch.","commit_id":"8e55c4732c1a6a8c471eda9dd9109d8d7b7b1228"},{"author":{"_account_id":18930,"name":"Suraj Deshmukh","email":"surajssd009005@gmail.com","username":"suraj.deshmukh"},"change_message_id":"991bd7e6c80a697cd62877b41382e9519be6c99e","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        icmp_code \u003d cleaned_data.get(\"icmp_code\", None)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        self._update_and_pop_error(cleaned_data, \u0027ip_protocol\u0027, rule_menu)"},{"line_number":295,"context_line":"        if icmp_type \u003d\u003d -1 and icmp_code !\u003d -1:"},{"line_number":296,"context_line":"            msg \u003d _(\u0027ICMP code is provided but ICMP type is missing.\u0027)"},{"line_number":297,"context_line":"            raise ValidationError(msg)"},{"line_number":298,"context_line":"        if self.errors.get(\u0027icmp_type\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_6f2171b4","line":295,"updated":"2015-11-30 13:21:07.000000000","message":"Nova and Neutron SG API allows us to specify a rule with a specific ICMP type and ANY for ICMP code but vice-a-versa is not possible. When ICMP type is put to -1 and ICMP code is given some number say 100, it gives following error: \n\n$ nova secgroup-add-rule default icmp -1 100 0.0.0.0/0\nERROR (BadRequest): ICMP code (port-range-max) 100 is provided but ICMP type (port-range-min) is missing.\n\nBut you can always specify both to be -1, which also means allow any ICMP packet, whatever be its type and code.","commit_id":"d50cbd69524d758cf6730d1fe45e0b3b1499d461"}],"openstack_dashboard/dashboards/project/access_and_security/security_groups/tests.py":[{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"2c73b66dcf8b20df14d8099be981014aecfc8976","unresolved":false,"context_lines":[{"line_number":485,"context_line":"            api.network.security_group_list("},{"line_number":486,"context_line":"                IsA(http.HttpRequest)).AndReturn(sec_group_list)"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"        if django.VERSION \u003e\u003d (1, 9):"},{"line_number":489,"context_line":"            for i in range(4):"},{"line_number":490,"context_line":"                api.network.security_group_backend("},{"line_number":491,"context_line":"                    IsA(http.HttpRequest)).AndReturn(self.secgroup_backend)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_8d406437","side":"PARENT","line":488,"updated":"2016-06-09 17:30:51.000000000","message":"Forgot to change this, so jenkins fails on  the django\u003e\u003d1.9 environment :)","commit_id":"377da87e3cab513cbd238e5231a68ea56e2d791f"},{"author":{"_account_id":8674,"name":"Yves-Gwenael Bourhis","email":"ygbourhis@gmail.com","username":"yves"},"change_message_id":"830852169dc1e44f862fb69c55dffafd4df00543","unresolved":false,"context_lines":[{"line_number":485,"context_line":"            api.network.security_group_list("},{"line_number":486,"context_line":"                IsA(http.HttpRequest)).AndReturn(sec_group_list)"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"        if django.VERSION \u003e\u003d (1, 9):"},{"line_number":489,"context_line":"            for i in range(4):"},{"line_number":490,"context_line":"                api.network.security_group_backend("},{"line_number":491,"context_line":"                    IsA(http.HttpRequest)).AndReturn(self.secgroup_backend)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_6641b639","side":"PARENT","line":488,"in_reply_to":"7aa08908_8d406437","updated":"2016-06-10 08:55:34.000000000","message":"Thanks a lot :-)\n\nI was stuck on the first traceback (which still shows up when the tests succeed with py27dj19)\n\nThis Traceback really is confusing during tests...\n\nI didn\u0027t even read the logs \"further\" when I saw this Traceback and this erroneously led me to think it failed for another reason...\n\nThanks.","commit_id":"377da87e3cab513cbd238e5231a68ea56e2d791f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0f5edabe330a5abdd2ea74ca49dfdda91adf218b","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        formData \u003d {\u0027method\u0027: \u0027AddRule\u0027,"},{"line_number":522,"context_line":"                    \u0027id\u0027: sec_group.id,"},{"line_number":523,"context_line":"                    \u0027port_or_range\u0027: \u0027port\u0027,"},{"line_number":524,"context_line":"                    \u0027icmp_type\u0027: icmp_rule.from_port,"},{"line_number":525,"context_line":"                    \u0027icmp_code\u0027: None,"},{"line_number":526,"context_line":"                    \u0027rule_menu\u0027: icmp_rule.ip_protocol,"},{"line_number":527,"context_line":"                    \u0027cidr\u0027: icmp_rule.ip_range[\u0027cidr\u0027],"},{"line_number":528,"context_line":"                    \u0027remote\u0027: \u0027cidr\u0027}"},{"line_number":529,"context_line":"        res \u003d self.client.post(self.edit_url, formData)"},{"line_number":530,"context_line":"        self.assertNoMessages()"},{"line_number":531,"context_line":"        self.assertContains(res, \"The ICMP code is invalid\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_6954e953","side":"PARENT","line":528,"range":{"start_line":524,"start_character":16,"end_line":528,"end_character":37},"updated":"2016-06-10 09:28:07.000000000","message":"Why did you drop this test? L.521-528 and L.533-540 are different.","commit_id":"fedb991435de9b3763ca3e6e9289fd01b3e27f06"},{"author":{"_account_id":8674,"name":"Yves-Gwenael Bourhis","email":"ygbourhis@gmail.com","username":"yves"},"change_message_id":"0c6500212563937147983e29327f6cbdc6893b1d","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        formData \u003d {\u0027method\u0027: \u0027AddRule\u0027,"},{"line_number":522,"context_line":"                    \u0027id\u0027: sec_group.id,"},{"line_number":523,"context_line":"                    \u0027port_or_range\u0027: \u0027port\u0027,"},{"line_number":524,"context_line":"                    \u0027icmp_type\u0027: icmp_rule.from_port,"},{"line_number":525,"context_line":"                    \u0027icmp_code\u0027: None,"},{"line_number":526,"context_line":"                    \u0027rule_menu\u0027: icmp_rule.ip_protocol,"},{"line_number":527,"context_line":"                    \u0027cidr\u0027: icmp_rule.ip_range[\u0027cidr\u0027],"},{"line_number":528,"context_line":"                    \u0027remote\u0027: \u0027cidr\u0027}"},{"line_number":529,"context_line":"        res \u003d self.client.post(self.edit_url, formData)"},{"line_number":530,"context_line":"        self.assertNoMessages()"},{"line_number":531,"context_line":"        self.assertContains(res, \"The ICMP code is invalid\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_357cf271","side":"PARENT","line":528,"range":{"start_line":524,"start_character":16,"end_line":528,"end_character":37},"in_reply_to":"7aa08908_6954e953","updated":"2016-06-10 10:29:30.000000000","message":"Done","commit_id":"fedb991435de9b3763ca3e6e9289fd01b3e27f06"}]}
