)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"57aedc1693ad85962fced1d5d6df1d4c45230632","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2013-04-04 16:53:14 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"CharFields replaced by IntegerFields in LBaaS forms."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The following fields were changed:"},{"line_number":10,"context_line":"* Vip / protocol port"},{"line_number":11,"context_line":"* Vip / connection limit"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAOX%2F%2F9hQ%3D","line":8,"updated":"2013-04-04 13:51:22.000000000","message":"It would be better to describe the range validations are added here.","commit_id":"3ffd3b2920fd8386d3c7556e55ba65fd16785454"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"26baa08a99a6a187041f272140d74494bef2d7e4","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2013-04-04 16:53:14 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"CharFields replaced by IntegerFields in LBaaS forms."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The following fields were changed:"},{"line_number":10,"context_line":"* Vip / protocol port"},{"line_number":11,"context_line":"* Vip / connection limit"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAOX%2F%2F9eM%3D","line":8,"in_reply_to":"AAAAOX%2F%2F9hQ%3D","updated":"2013-04-04 14:33:44.000000000","message":"Done","commit_id":"3ffd3b2920fd8386d3c7556e55ba65fd16785454"}],"openstack_dashboard/dashboards/project/loadbalancers/workflows.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c5811fcfbddb35251a05bbe9ec9d7aef122f3316","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                                   mask\u003dFalse)"},{"line_number":132,"context_line":"    protocol_port \u003d forms.IntegerField(label\u003d_(\"Protocol Port\"), min_value\u003d1,"},{"line_number":133,"context_line":"                              help_text\u003d_(\"Enter an integer value \""},{"line_number":134,"context_line":"                                          \"between 1 and 65535.\"),"},{"line_number":135,"context_line":"                              validators\u003d[validate_port_range])"},{"line_number":136,"context_line":"    protocol \u003d forms.ChoiceField(label\u003d_(\"Protocol\"))"},{"line_number":137,"context_line":"    session_persistence \u003d forms.ChoiceField("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F57A%3D","line":134,"updated":"2013-03-21 15:06:00.000000000","message":"The Quantum code extension/loadbalancer.py accepts ports from 0 to 65535, but this code accepts 1 to 65535. Is it intended? Actually port \u003d\u003d 0 is not used, so I think there is no difference and just I would like to confirm the intention.","commit_id":"5aa9cd24426e9e4eb343bdc9dc59e1adb2f0daef"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"ed48204ae1bfe2490fa41a2b434f24c2fecd54e4","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                                   mask\u003dFalse)"},{"line_number":132,"context_line":"    protocol_port \u003d forms.IntegerField(label\u003d_(\"Protocol Port\"), min_value\u003d1,"},{"line_number":133,"context_line":"                              help_text\u003d_(\"Enter an integer value \""},{"line_number":134,"context_line":"                                          \"between 1 and 65535.\"),"},{"line_number":135,"context_line":"                              validators\u003d[validate_port_range])"},{"line_number":136,"context_line":"    protocol \u003d forms.ChoiceField(label\u003d_(\"Protocol\"))"},{"line_number":137,"context_line":"    session_persistence \u003d forms.ChoiceField("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F53o%3D","line":134,"in_reply_to":"AAAAOH%2F%2F57A%3D","updated":"2013-03-22 12:30:51.000000000","message":"Yes, it is intended because of the same reason.","commit_id":"5aa9cd24426e9e4eb343bdc9dc59e1adb2f0daef"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c5811fcfbddb35251a05bbe9ec9d7aef122f3316","unresolved":false,"context_lines":[{"line_number":260,"context_line":"    weight \u003d forms.IntegerField(max_value\u003d256, min_value\u003d0, label\u003d_(\"Weight\"))"},{"line_number":261,"context_line":"    protocol_port \u003d forms.IntegerField(label\u003d_(\"Protocol Port\"), min_value\u003d1,"},{"line_number":262,"context_line":"                              help_text\u003d_(\"Enter an integer value \""},{"line_number":263,"context_line":"                                          \"between 1 and 65535.\"),"},{"line_number":264,"context_line":"                              validators\u003d[validate_port_range])"},{"line_number":265,"context_line":"    admin_state_up \u003d forms.BooleanField(label\u003d_(\"Admin State\"),"},{"line_number":266,"context_line":"                                        initial\u003dTrue, required\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F564%3D","line":263,"updated":"2013-03-21 15:06:00.000000000","message":"Same as the above.","commit_id":"5aa9cd24426e9e4eb343bdc9dc59e1adb2f0daef"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"f3fb240d9e399aef7caa94a09f46a505ca3ca4a5","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                                   initial\u003d\"\","},{"line_number":130,"context_line":"                                   version\u003dfields.IPv4,"},{"line_number":131,"context_line":"                                   mask\u003dFalse)"},{"line_number":132,"context_line":"    protocol_port \u003d forms.IntegerField(label\u003d_(\"Protocol Port\"), min_value\u003d1,"},{"line_number":133,"context_line":"                              help_text\u003d_(\"Enter an integer value \""},{"line_number":134,"context_line":"                                          \"between 1 and 65535.\"),"},{"line_number":135,"context_line":"                              validators\u003d[validate_port_range])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOX%2F%2F9%2Fc%3D","line":132,"updated":"2013-04-04 05:33:17.000000000","message":"You have a negative test with protocol_port \u003d\u003d 65536 but there isn\u0027t a max_value set here. Should it be set?","commit_id":"8173190cd0a9bb28fa0943eb351852ee02f2812f"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"0dc950829cc4c5e95759de8c0172a55bb2f00ca7","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                                   initial\u003d\"\","},{"line_number":130,"context_line":"                                   version\u003dfields.IPv4,"},{"line_number":131,"context_line":"                                   mask\u003dFalse)"},{"line_number":132,"context_line":"    protocol_port \u003d forms.IntegerField(label\u003d_(\"Protocol Port\"), min_value\u003d1,"},{"line_number":133,"context_line":"                              help_text\u003d_(\"Enter an integer value \""},{"line_number":134,"context_line":"                                          \"between 1 and 65535.\"),"},{"line_number":135,"context_line":"                              validators\u003d[validate_port_range])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOX%2F%2F9wg%3D","line":132,"in_reply_to":"AAAAOX%2F%2F9%2Fc%3D","updated":"2013-04-04 10:12:24.000000000","message":"The method \"validate_port_range\" from horizon/horizon/utils/validators.py checks if the port value is in range from 0 to 65535. I have set min_value\u003d1 for a user-friendly message if port value is 0. Otherwise we just get an error without any explanations.","commit_id":"8173190cd0a9bb28fa0943eb351852ee02f2812f"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"f3fb240d9e399aef7caa94a09f46a505ca3ca4a5","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        help_text\u003d_(\"Required for APP_COOKIE persistence;\""},{"line_number":143,"context_line":"                    \" Ignored otherwise.\"))"},{"line_number":144,"context_line":"    connection_limit \u003d forms.IntegerField("},{"line_number":145,"context_line":"        min_value\u003d1, label\u003d_(\"Connection Limit\"))"},{"line_number":146,"context_line":"    admin_state_up \u003d forms.BooleanField("},{"line_number":147,"context_line":"        label\u003d_(\"Admin State\"), initial\u003dTrue, required\u003dFalse)"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOX%2F%2F9%2FY%3D","line":145,"updated":"2013-04-04 05:33:17.000000000","message":"How would no limit be specified here? Is that a valid value API-wise?","commit_id":"8173190cd0a9bb28fa0943eb351852ee02f2812f"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"0dc950829cc4c5e95759de8c0172a55bb2f00ca7","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        help_text\u003d_(\"Required for APP_COOKIE persistence;\""},{"line_number":143,"context_line":"                    \" Ignored otherwise.\"))"},{"line_number":144,"context_line":"    connection_limit \u003d forms.IntegerField("},{"line_number":145,"context_line":"        min_value\u003d1, label\u003d_(\"Connection Limit\"))"},{"line_number":146,"context_line":"    admin_state_up \u003d forms.BooleanField("},{"line_number":147,"context_line":"        label\u003d_(\"Admin State\"), initial\u003dTrue, required\u003dFalse)"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOX%2F%2F9v8%3D","line":145,"in_reply_to":"AAAAOX%2F%2F9%2FY%3D","updated":"2013-04-04 10:12:24.000000000","message":"The value should be \"-1\" if the limit is not set. I will correct that. Thanks!","commit_id":"8173190cd0a9bb28fa0943eb351852ee02f2812f"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"f3fb240d9e399aef7caa94a09f46a505ca3ca4a5","unresolved":false,"context_lines":[{"line_number":260,"context_line":"    weight \u003d forms.IntegerField(max_value\u003d256, min_value\u003d0, label\u003d_(\"Weight\"))"},{"line_number":261,"context_line":"    protocol_port \u003d forms.IntegerField(label\u003d_(\"Protocol Port\"), min_value\u003d1,"},{"line_number":262,"context_line":"                              help_text\u003d_(\"Enter an integer value \""},{"line_number":263,"context_line":"                                          \"between 1 and 65535.\"),"},{"line_number":264,"context_line":"                              validators\u003d[validate_port_range])"},{"line_number":265,"context_line":"    admin_state_up \u003d forms.BooleanField(label\u003d_(\"Admin State\"),"},{"line_number":266,"context_line":"                                        initial\u003dTrue, required\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOX%2F%2F9%2Fg%3D","line":263,"updated":"2013-04-04 05:33:17.000000000","message":"As above, max_value needed?","commit_id":"8173190cd0a9bb28fa0943eb351852ee02f2812f"}]}