)]}'
{"horizon/static/framework/widgets/charts/pie-chart.directive.js":[{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"412ae826525e5a2a8f765ed6aa4b3f0ccd8ad3a4","unresolved":false,"context_lines":[{"line_number":121,"context_line":"      }"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"      var settings \u003d {};"},{"line_number":124,"context_line":"      var showChart \u003d updateChartVisibility();"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"      // if chartSettings is defined via the attribute value, use it"},{"line_number":127,"context_line":"      if (angular.isObject(scope.chartSettings)) {"}],"source_content_type":"text/javascript","patch_set":1,"id":"9a8ffd7b_969fb34f","side":"PARENT","line":124,"updated":"2015-11-25 17:20:42.000000000","message":"Once the below if(showChart) is removed, this line triggers the no-unused-vars rule.","commit_id":"0960974bddd4183bbe9aa52c81e893a48a275aec"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"412ae826525e5a2a8f765ed6aa4b3f0ccd8ad3a4","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        var pie \u003d d3.layout.pie()"},{"line_number":152,"context_line":"          .sort(null)"},{"line_number":153,"context_line":"          .value(function (d) { return d.value; });"},{"line_number":154,"context_line":"      }"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"      var unwatch \u003d scope.$watch(\u0027chartData\u0027, updateChart);"},{"line_number":157,"context_line":"      scope.$on(\u0027$destroy\u0027, unwatch);"}],"source_content_type":"text/javascript","patch_set":1,"id":"9a8ffd7b_76f9ef7f","side":"PARENT","line":154,"updated":"2015-11-25 17:20:42.000000000","message":"The only place these parameters were used is in the below updateChart() scope.","commit_id":"0960974bddd4183bbe9aa52c81e893a48a275aec"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"30b4ac98a79792632fcd505655a472320deedbf1","unresolved":false,"context_lines":[{"line_number":121,"context_line":"      }"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"      var settings \u003d {};"},{"line_number":124,"context_line":"      var showChart \u003d updateChartVisibility();"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"      // if chartSettings is defined via the attribute value, use it"},{"line_number":127,"context_line":"      if (angular.isObject(scope.chartSettings)) {"}],"source_content_type":"text/javascript","patch_set":2,"id":"9a8ffd7b_c78159c5","side":"PARENT","line":124,"updated":"2015-11-30 16:10:28.000000000","message":"I think you still need this?","commit_id":"0960974bddd4183bbe9aa52c81e893a48a275aec"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"4829d88ed22e865e19a980f76386e1bb7a650479","unresolved":false,"context_lines":[{"line_number":121,"context_line":"      }"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"      var settings \u003d {};"},{"line_number":124,"context_line":"      var showChart \u003d updateChartVisibility();"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"      // if chartSettings is defined via the attribute value, use it"},{"line_number":127,"context_line":"      if (angular.isObject(scope.chartSettings)) {"}],"source_content_type":"text/javascript","patch_set":2,"id":"9a8ffd7b_d9692c27","side":"PARENT","line":124,"in_reply_to":"9a8ffd7b_1b2a51e8","updated":"2015-11-30 21:58:51.000000000","message":"ah... ok made sense once i looked at entire source. I think its a minor optimization here. Load the settings once, then only update the data portion of the chart on data change. If we move this logic into the update function we lose that bit of optimization. But it could small enough to skip over. I would be more comfortable if we come up with an alternate, but if another core feels strongly about it, I\u0027ll help +A it through.","commit_id":"0960974bddd4183bbe9aa52c81e893a48a275aec"},{"author":{"_account_id":13785,"name":"Kelly Domico","email":"kelly.domico@hp.com","username":"kdomico"},"change_message_id":"80388dbedb9b22d8d1812801621610c4cc1fe9eb","unresolved":false,"context_lines":[{"line_number":121,"context_line":"      }"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"      var settings \u003d {};"},{"line_number":124,"context_line":"      var showChart \u003d updateChartVisibility();"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"      // if chartSettings is defined via the attribute value, use it"},{"line_number":127,"context_line":"      if (angular.isObject(scope.chartSettings)) {"}],"source_content_type":"text/javascript","patch_set":2,"id":"9a8ffd7b_1b2a51e8","side":"PARENT","line":124,"in_reply_to":"9a8ffd7b_c78159c5","updated":"2015-11-30 18:59:13.000000000","message":"This line isn\u0027t needed anymore since there is already one in the updateChart function (line 149)","commit_id":"0960974bddd4183bbe9aa52c81e893a48a275aec"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"52dd40762b4b3f9303c8181cc42df1bf24213d56","unresolved":false,"context_lines":[{"line_number":121,"context_line":"      }"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"      var settings \u003d {};"},{"line_number":124,"context_line":"      var showChart \u003d updateChartVisibility();"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"      // if chartSettings is defined via the attribute value, use it"},{"line_number":127,"context_line":"      if (angular.isObject(scope.chartSettings)) {"}],"source_content_type":"text/javascript","patch_set":2,"id":"9a8ffd7b_25e013cc","side":"PARENT","line":124,"in_reply_to":"9a8ffd7b_d9692c27","updated":"2015-12-01 18:43:59.000000000","message":"Loading it once unfortunately creates a rather significant bug - if showChart is false when the directive initializes, and then - for any reason - changes value, then the next time updateChart is triggered, the directive will start throwing errors.\n\nWell, in reality, in this directive all errors will be caught silently, but the ultimate result is that the directive doesn\u0027t behave as expected.","commit_id":"0960974bddd4183bbe9aa52c81e893a48a275aec"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"aa536e52d7e59257089d44a010c5c797eb616d5d","unresolved":false,"context_lines":[{"line_number":146,"context_line":"      scope.model \u003d model;"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"      function updateChart() {"},{"line_number":149,"context_line":"        var showChart \u003d updateChartVisibility();"},{"line_number":150,"context_line":"        angular.forEach(scope.chartData.data, function(item) {"},{"line_number":151,"context_line":"          if (item.value \u003d\u003d\u003d Infinity) {"},{"line_number":152,"context_line":"            item.hideKey \u003d true;"}],"source_content_type":"text/javascript","patch_set":11,"id":"9abb7d3a_8a71df46","line":149,"updated":"2016-05-31 18:34:49.000000000","message":"We don\u0027t need updateChartVisibility() function anymore, it could be safely inlined into updateChart() call, which would prevent false assumptions on its future use cases.","commit_id":"82b9565fbb7ddc91f2dec4e896453a4e65f7c73b"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"edece3dbea8879117675d0b76526e5f0a7ccecd4","unresolved":false,"context_lines":[{"line_number":146,"context_line":"      scope.model \u003d model;"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"      function updateChart() {"},{"line_number":149,"context_line":"        var showChart \u003d updateChartVisibility();"},{"line_number":150,"context_line":"        angular.forEach(scope.chartData.data, function(item) {"},{"line_number":151,"context_line":"          if (item.value \u003d\u003d\u003d Infinity) {"},{"line_number":152,"context_line":"            item.hideKey \u003d true;"}],"source_content_type":"text/javascript","patch_set":11,"id":"7aa08908_0e069c1b","line":149,"in_reply_to":"9abb7d3a_8a71df46","updated":"2016-06-13 19:58:34.000000000","message":"While that may be the case, that seems like it should be a separate patch.","commit_id":"82b9565fbb7ddc91f2dec4e896453a4e65f7c73b"}]}
