)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"00f530a05bfe986fd37f4545b4f153f0376475b1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Change column order for Orchestration Services table"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The `Last Updated` and `Status` column are not consistent with other"},{"line_number":10,"context_line":"tables in system information, change order to make it consistency."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If21aed35afe9dc56754f4b1e7bbd57bbda9369f5"},{"line_number":13,"context_line":"Closes-bug: #1520510"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_9c000403","line":10,"updated":"2015-12-02 14:30:48.000000000","message":"grammar: \"consistency\" --\u003e \"consistent\"","commit_id":"91cacd2211fcd33cb314fcf54049fb31ec0353fc"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"7d67c02397f93d538f3404406bb3dbe95b560e7f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Change column order for Orchestration Services table"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The `Last Updated` and `Status` column are not consistent with other"},{"line_number":10,"context_line":"tables in system information, change order to make it consistency."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If21aed35afe9dc56754f4b1e7bbd57bbda9369f5"},{"line_number":13,"context_line":"Closes-bug: #1520510"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a740942_51232b56","line":10,"in_reply_to":"9a8ffd7b_9c000403","updated":"2015-12-14 07:50:09.000000000","message":"Done","commit_id":"91cacd2211fcd33cb314fcf54049fb31ec0353fc"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"1c95f45034820cb30d114d61810466a17f5942f3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change column order for Orchestration Services table"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The `Last Updated` and `Status` column are not consistent with other"},{"line_number":10,"context_line":"tables in system information, change order to make it consistent."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If21aed35afe9dc56754f4b1e7bbd57bbda9369f5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_ece27cd4","line":9,"updated":"2015-12-14 08:18:17.000000000","message":"\u0027Status\u0027 ---\u003e \u0027State\u0027 ?  \nSince your code has been changed to \"verbose_name\u003d_(\u0027State\u0027)\"","commit_id":"eb7d17404b4256ddb3942ba5608133e5c343a3cb"}],"openstack_dashboard/dashboards/admin/info/tables.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"491112f0ea581bd9a6f6cf1c2cd93ce2548d5d3b","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    engine_id \u003d tables.Column(\u0027engine_id\u0027, verbose_name\u003d_(\u0027Engine Id\u0027))"},{"line_number":209,"context_line":"    host \u003d tables.Column(\u0027host\u0027, verbose_name\u003d_(\u0027Host\u0027))"},{"line_number":210,"context_line":"    topic \u003d tables.Column(\u0027topic\u0027, verbose_name\u003d_(\u0027Topic\u0027))"},{"line_number":211,"context_line":"    status \u003d tables.Column(\u0027status\u0027, verbose_name\u003d_(\u0027Status\u0027),"},{"line_number":212,"context_line":"                           display_choices\u003dSERVICE_STATE_DISPLAY_CHOICES)"},{"line_number":213,"context_line":"    updated_at \u003d tables.Column(\u0027updated_at\u0027,"},{"line_number":214,"context_line":"                               verbose_name\u003dpgettext_lazy("}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_dbef71af","line":211,"updated":"2015-12-11 16:42:47.000000000","message":"It seems to me that to be aligned with other tables, it should be \u0027State\u0027 and not \u0027Status\u0027 (if SERVICE_STATE_DISPLAY_CHOICES are used). Perhaps we should have here both columns - Status and State?","commit_id":"91cacd2211fcd33cb314fcf54049fb31ec0353fc"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"7d67c02397f93d538f3404406bb3dbe95b560e7f","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    engine_id \u003d tables.Column(\u0027engine_id\u0027, verbose_name\u003d_(\u0027Engine Id\u0027))"},{"line_number":209,"context_line":"    host \u003d tables.Column(\u0027host\u0027, verbose_name\u003d_(\u0027Host\u0027))"},{"line_number":210,"context_line":"    topic \u003d tables.Column(\u0027topic\u0027, verbose_name\u003d_(\u0027Topic\u0027))"},{"line_number":211,"context_line":"    status \u003d tables.Column(\u0027status\u0027, verbose_name\u003d_(\u0027Status\u0027),"},{"line_number":212,"context_line":"                           display_choices\u003dSERVICE_STATE_DISPLAY_CHOICES)"},{"line_number":213,"context_line":"    updated_at \u003d tables.Column(\u0027updated_at\u0027,"},{"line_number":214,"context_line":"                               verbose_name\u003dpgettext_lazy("}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_b127ef61","line":211,"in_reply_to":"7a740942_dbef71af","updated":"2015-12-14 07:50:09.000000000","message":"Changed to State, i don\u0027t think we need Status and State both, since heat service only have \u0027status\u0027 field.","commit_id":"91cacd2211fcd33cb314fcf54049fb31ec0353fc"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"cc3d5bd40931dd0af456556208750b2612fce825","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    engine_id \u003d tables.Column(\u0027engine_id\u0027, verbose_name\u003d_(\u0027Engine Id\u0027))"},{"line_number":209,"context_line":"    host \u003d tables.Column(\u0027host\u0027, verbose_name\u003d_(\u0027Host\u0027))"},{"line_number":210,"context_line":"    topic \u003d tables.Column(\u0027topic\u0027, verbose_name\u003d_(\u0027Topic\u0027))"},{"line_number":211,"context_line":"    status \u003d tables.Column(\u0027status\u0027, verbose_name\u003d_(\u0027State\u0027),"},{"line_number":212,"context_line":"                           display_choices\u003dSERVICE_STATE_DISPLAY_CHOICES)"},{"line_number":213,"context_line":"    updated_at \u003d tables.Column(\u0027updated_at\u0027,"},{"line_number":214,"context_line":"                               verbose_name\u003dpgettext_lazy("}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_cd5bf720","line":211,"updated":"2015-12-14 10:06:44.000000000","message":"Having column name different from its label is a bit confusing, yet I understand that Heat service means by \u0027status\u0027 an Up/Down state - the thing that other services name as \u0027state\u0027.\n\nCould you please add a NOTE comment here, so others wouldn\u0027t think it\u0027s a bug or typo? Also I\u0027d suggest rename column name status -\u003e state, leaving only \u0027status\u0027 inside Column init (because it\u0027s used as an accessor for data object returned from heatclient). Having a comment should explain why on the same line we use 2 times \u0027state\u0027 and 1 time \u0027status\u0027.","commit_id":"72263a41db80011945bc0122e88731b021d84686"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"29db74b556f3d83dff479a5c7bac9f740a10eae4","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    engine_id \u003d tables.Column(\u0027engine_id\u0027, verbose_name\u003d_(\u0027Engine Id\u0027))"},{"line_number":209,"context_line":"    host \u003d tables.Column(\u0027host\u0027, verbose_name\u003d_(\u0027Host\u0027))"},{"line_number":210,"context_line":"    topic \u003d tables.Column(\u0027topic\u0027, verbose_name\u003d_(\u0027Topic\u0027))"},{"line_number":211,"context_line":"    status \u003d tables.Column(\u0027status\u0027, verbose_name\u003d_(\u0027State\u0027),"},{"line_number":212,"context_line":"                           display_choices\u003dSERVICE_STATE_DISPLAY_CHOICES)"},{"line_number":213,"context_line":"    updated_at \u003d tables.Column(\u0027updated_at\u0027,"},{"line_number":214,"context_line":"                               verbose_name\u003dpgettext_lazy("}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_3942fd0f","line":211,"in_reply_to":"7a740942_cd5bf720","updated":"2015-12-14 11:26:14.000000000","message":"Done","commit_id":"72263a41db80011945bc0122e88731b021d84686"}]}
