)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"1724cbcebfe30982e71bcadc56cfe3e17ecdb7b6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"-Deletion"},{"line_number":10,"context_line":"-Enabling and Disabling of alarms"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint https://blueprints.launchpad.net/horizon/+spec/ceilometer-alarm-management-page"},{"line_number":13,"context_line":"Change-Id: I6dc13594f4f99bdc026ace07a78c1f7d8f70c2c3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a8ffd7b_58e3ad05","line":12,"updated":"2015-12-02 00:36:18.000000000","message":"don\u0027t need to full path, just:\n\nImplements: blueprint ceilometer-alarm-management-page","commit_id":"cbb510127684a3724c6a558935ca887dca80e5c3"},{"author":{"_account_id":12099,"name":"Pradyumna Sampath","username":"pradysam","inactive":true},"change_message_id":"3cb45a6aed5458d7dabf43ebf6fe02646a8d3296","unresolved":false,"context_lines":[{"line_number":10,"context_line":"deletion, enabling and disabling of threshold"},{"line_number":11,"context_line":"alarms."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: blueprint ceilometer-alarm-management"},{"line_number":14,"context_line":"Change-Id: I6dc13594f4f99bdc026ace07a78c1f7d8f70c2c3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3a57f1b5_01e6eb43","line":13,"updated":"2016-02-12 05:08:34.000000000","message":"Broken link. Use \"ceilometer-alarm-management-page\" instead.","commit_id":"32800cb0ddd6f8702b6e770cff7a1e2ab9ae785d"}],"openstack_dashboard/api/ceilometer.py":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"1724cbcebfe30982e71bcadc56cfe3e17ecdb7b6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from collections import OrderedDict"},{"line_number":14,"context_line":"import logging"},{"line_number":15,"context_line":"import threading"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_78b471f1","line":13,"updated":"2015-12-02 00:36:18.000000000","message":"nice catch!\n\nshould be alphabetical... so under from ceilometerclient import client as ceilometer_client\n\nnit: you could also remove this into another tiny patch with just this change and in the commit msg put: \"SortedDict is deprecated as of Django 1.7 and will be removed in Django 1.9. Use ​collections.OrderedDict instead. Available in Python 2.7 and 3.1+.\" :) (https://code.djangoproject.com/wiki/SortedDict)","commit_id":"cbb510127684a3724c6a558935ca887dca80e5c3"}],"openstack_dashboard/dashboards/admin/alarms/constants.py":[{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"ff2142252eb70bbe353c71285d6f34ac9a49bdbc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"ALARMS_CREATE_URL \u003d \u0027horizon:admin:alarms:create\u0027"},{"line_number":16,"context_line":"ALARMS_CREATE_VIEW_TEMPLATE \u003d \u0027admin/alarms/create.html\u0027"},{"line_number":17,"context_line":"ALARMS_UPDATE_URL \u003d \u0027horizon:admin:alarms:update\u0027"},{"line_number":18,"context_line":"ALARMS_UPDATE_VIEW_TEMPLATE \u003d \u0027admin/alarms/update.html\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"7af24918_3bd890ef","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":27},"updated":"2016-03-01 14:42:25.000000000","message":"Do we really need this file? Looks like you do not use it anywhere except tests file? And insted you\u0027re just using these strings like in `CreateAlarm.url`.","commit_id":"075ee6b94fc221fc81852424dd95c6199a3bae95"},{"author":{"_account_id":16871,"name":"Sanjana","email":"sanjana@hitachi.co.in","username":"sanjana_93"},"change_message_id":"a08ecc8082ebe8dea80375af144fca160686cc6d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"ALARMS_CREATE_URL \u003d \u0027horizon:admin:alarms:create\u0027"},{"line_number":16,"context_line":"ALARMS_CREATE_VIEW_TEMPLATE \u003d \u0027admin/alarms/create.html\u0027"},{"line_number":17,"context_line":"ALARMS_UPDATE_URL \u003d \u0027horizon:admin:alarms:update\u0027"},{"line_number":18,"context_line":"ALARMS_UPDATE_VIEW_TEMPLATE \u003d \u0027admin/alarms/update.html\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"5aef4532_953bfd37","line":18,"updated":"2016-03-09 09:18:14.000000000","message":"This is required in the workflow for editing alarms. \n(\"Edit Alarm\")","commit_id":"80dc482784d049110330a8a458dfda66efbfe1a3"}],"openstack_dashboard/dashboards/admin/alarms/panel.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"bf3f3753e2b76fbaf11f3ccb30a22175e19a83ff","unresolved":false,"context_lines":[{"line_number":13,"context_line":"from django.utils.translation import ugettext_lazy as _"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import horizon"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class Alarms(horizon.Panel):"},{"line_number":19,"context_line":"    name \u003d _(\"Alarms\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_c8514ada","line":16,"updated":"2015-12-01 06:35:44.000000000","message":"Not more than 2  new lines( seems to be 3 here)","commit_id":"e04e15a3309c020d3983a1f31c203c19cff27a8a"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"80fa3fff839333d08ab702841d4a1bf3f987c68c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7a5de9d1_5b67c4e8","line":21,"updated":"2016-02-01 11:34:01.000000000","message":"It needs a permission like a below.\n permissions \u003d (\u0027openstack.services.metering\u0027,)","commit_id":"7e5d39f96fed019f957bc1b39c746ec436977e98"}],"openstack_dashboard/dashboards/admin/alarms/tables.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"bf3f3753e2b76fbaf11f3ccb30a22175e19a83ff","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            self.current_present_action \u003d DISABLE"},{"line_number":101,"context_line":"        else:"},{"line_number":102,"context_line":"            self.current_present_action \u003d ENABLE"},{"line_number":103,"context_line":"        return True"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def action(self, request, obj_id):"},{"line_number":106,"context_line":"        if self.enabled:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_68b93eec","line":103,"updated":"2015-12-01 06:35:44.000000000","message":"Do you need to return true from the function?\nAs such the function is just assigning values.\nIt is not generating any exception.\nYou can remove this line","commit_id":"e04e15a3309c020d3983a1f31c203c19cff27a8a"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"1724cbcebfe30982e71bcadc56cfe3e17ecdb7b6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    @staticmethod"},{"line_number":27,"context_line":"    def action_present(count):"},{"line_number":28,"context_line":"        return ungettext_lazy("},{"line_number":29,"context_line":"            u\"Delete Alarms\","},{"line_number":30,"context_line":"            u\"Delete Alarms\","},{"line_number":31,"context_line":"            count"},{"line_number":32,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_387d891c","line":29,"updated":"2015-12-02 00:36:18.000000000","message":"first should be singular: Delete Alarm","commit_id":"cbb510127684a3724c6a558935ca887dca80e5c3"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"1724cbcebfe30982e71bcadc56cfe3e17ecdb7b6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    @staticmethod"},{"line_number":35,"context_line":"    def action_past(count):"},{"line_number":36,"context_line":"        return ungettext_lazy("},{"line_number":37,"context_line":"            u\"Deleted Alarms\","},{"line_number":38,"context_line":"            u\"Deleted Alarms\","},{"line_number":39,"context_line":"            count"},{"line_number":40,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_58788d2b","line":37,"updated":"2015-12-02 00:36:18.000000000","message":"ditto","commit_id":"cbb510127684a3724c6a558935ca887dca80e5c3"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"191878317207df5d7994589261908cbfded6c360","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            self.current_past_action \u003d ENABLE"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"class AlarmFilterAction(tables.FilterAction):"},{"line_number":115,"context_line":"    def filter(self, table, alarms, filter_string):"},{"line_number":116,"context_line":"        query \u003d filter_string.lower()"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_0df7bfd3","line":114,"updated":"2015-12-14 10:18:35.000000000","message":"the alarm is filtered based on the name, so directly you can use the NameFilterAction. https://github.com/openstack/horizon/blob/master/horizon/tables/actions.py#L522","commit_id":"e5bf193bcdde4985e7dc8d58b0c4fcb1ed36f812"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"191878317207df5d7994589261908cbfded6c360","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    name \u003d tables.Column(get_alarm_name,"},{"line_number":148,"context_line":"                         verbose_name\u003d_(\u0027Alarm Name\u0027),"},{"line_number":149,"context_line":"                         link\u003d(\"horizon:admin:alarms:detail\"))"},{"line_number":150,"context_line":"    alarm_id \u003d tables.Column(\u0027id\u0027, verbose_name\u003d_(\u0027ID\u0027))"},{"line_number":151,"context_line":"    meter_name \u003d tables.Column(get_meter_name, verbose_name\u003d_(\u0027Metric Name\u0027))"},{"line_number":152,"context_line":"    description \u003d tables.Column(get_alarm_desc,"},{"line_number":153,"context_line":"                                verbose_name\u003d_(\u0027Alarm Description\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_0dcfbf56","line":150,"updated":"2015-12-14 10:18:35.000000000","message":"usually Horizon will not display the UUID of any resource in table. unless no specific reason.","commit_id":"e5bf193bcdde4985e7dc8d58b0c4fcb1ed36f812"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"191878317207df5d7994589261908cbfded6c360","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    meter_name \u003d tables.Column(get_meter_name, verbose_name\u003d_(\u0027Metric Name\u0027))"},{"line_number":152,"context_line":"    description \u003d tables.Column(get_alarm_desc,"},{"line_number":153,"context_line":"                                verbose_name\u003d_(\u0027Alarm Description\u0027))"},{"line_number":154,"context_line":"    status \u003d tables.Column(get_alarm_status, verbose_name\u003d_(\u0027Enabled\u0027))"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    class Meta(object):"},{"line_number":157,"context_line":"        name \u003d \"alarms\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_4d9aa763","line":154,"updated":"2015-12-14 10:18:35.000000000","message":"it should display \u0027Yes\u0027 or \u0027No\u0027 instead of \u0027True\u0027 or \u0027False\u0027.","commit_id":"e5bf193bcdde4985e7dc8d58b0c4fcb1ed36f812"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"80fa3fff839333d08ab702841d4a1bf3f987c68c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    url \u003d \"horizon:admin:alarms:create\""},{"line_number":50,"context_line":"    classes \u003d (\"ajax-modal\",)"},{"line_number":51,"context_line":"    icon \u003d \"plus\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class UpdateAlarm(tables.LinkAction):"},{"line_number":55,"context_line":"    name \u003d \"update\""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_db889473","line":52,"updated":"2016-02-01 11:34:01.000000000","message":"Do we need any permission check ?","commit_id":"7e5d39f96fed019f957bc1b39c746ec436977e98"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"bfec05507ff5a7c811a2a06f68a293e83cc910e9","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    meter_name \u003d tables.Column(get_meter_name, verbose_name\u003d_(\u0027Metric Name\u0027))"},{"line_number":141,"context_line":"    description \u003d tables.Column(get_alarm_desc,"},{"line_number":142,"context_line":"                                verbose_name\u003d_(\u0027Alarm Description\u0027))"},{"line_number":143,"context_line":"    status \u003d tables.Column(get_alarm_status, verbose_name\u003d_(\u0027Enabled\u0027))"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    class Meta(object):"},{"line_number":146,"context_line":"        name \u003d \"alarms\""}],"source_content_type":"text/x-python","patch_set":10,"id":"5a5ae5dd_ad1c2f14","line":143,"updated":"2016-02-09 07:31:43.000000000","message":"you can use a filters for this. \nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/networks/tables.py#L176","commit_id":"6d374a47847b73b194ae69b1528998f281694f97"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"8029420257546bdce466c2574c539621425c8018","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    # Toggling of alarm enable and disable option"},{"line_number":98,"context_line":"    def allowed(self, request, alarm\u003dNone):"},{"line_number":99,"context_line":"        self.enabled \u003d alarm.enabled"},{"line_number":100,"context_line":"        if self.enabled:"},{"line_number":101,"context_line":"            self.current_present_action \u003d DISABLE"},{"line_number":102,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":11,"id":"dae33548_92689cbc","line":99,"updated":"2016-02-15 02:47:14.000000000","message":"If alarm is None, AttributeError will raise. Is it as expected ?","commit_id":"32800cb0ddd6f8702b6e770cff7a1e2ab9ae785d"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"8029420257546bdce466c2574c539621425c8018","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    # Toggling of alarm enable and disable option"},{"line_number":98,"context_line":"    def allowed(self, request, alarm\u003dNone):"},{"line_number":99,"context_line":"        self.enabled \u003d alarm.enabled"},{"line_number":100,"context_line":"        if self.enabled:"},{"line_number":101,"context_line":"            self.current_present_action \u003d DISABLE"},{"line_number":102,"context_line":"        else:"},{"line_number":103,"context_line":"            self.current_present_action \u003d ENABLE"}],"source_content_type":"text/x-python","patch_set":11,"id":"dae33548_b2b6803b","line":100,"updated":"2016-02-15 02:47:14.000000000","message":"It is more simply. What do you think?\n\nself.current_present_action \u003d DISABLE if self.enabled else ENABLE","commit_id":"32800cb0ddd6f8702b6e770cff7a1e2ab9ae785d"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"a0b882cdcacec3fb0906109830e5a0549eaba02b","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"def get_alarm_name(alarm):"},{"line_number":116,"context_line":"    return _(\"%s\") % (alarm.name or 0)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"def get_alarm_desc(alarm):"}],"source_content_type":"text/x-python","patch_set":13,"id":"bae84128_03e273d5","line":116,"range":{"start_line":116,"start_character":36,"end_line":116,"end_character":37},"updated":"2016-02-19 17:08:06.000000000","message":"why 0, None or \"\" makes more sense, right?","commit_id":"90c581ca7aa2ebf350da7dba02e1e05a8a60efa5"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"a0b882cdcacec3fb0906109830e5a0549eaba02b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"bae84128_83ce8358","line":144,"updated":"2016-02-19 17:08:06.000000000","message":"could you add table filter action","commit_id":"90c581ca7aa2ebf350da7dba02e1e05a8a60efa5"},{"author":{"_account_id":16871,"name":"Sanjana","email":"sanjana@hitachi.co.in","username":"sanjana_93"},"change_message_id":"c09e27bb6769885a9b31316674ba4a937e75d24c","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"def get_alarm_name(alarm):"},{"line_number":116,"context_line":"    return _(\"%s\") % (alarm.name)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"def get_alarm_desc(alarm):"},{"line_number":120,"context_line":"    return _(\"%s\") % (alarm.description)"}],"source_content_type":"text/x-python","patch_set":14,"id":"bae84128_b444e649","line":117,"updated":"2016-02-24 07:04:17.000000000","message":"The alarm name is a mandatory parameter so it can\u0027t be None.","commit_id":"075ee6b94fc221fc81852424dd95c6199a3bae95"},{"author":{"_account_id":16871,"name":"Sanjana","email":"sanjana@hitachi.co.in","username":"sanjana_93"},"change_message_id":"c09e27bb6769885a9b31316674ba4a937e75d24c","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"def get_alarm_desc(alarm):"},{"line_number":120,"context_line":"    return _(\"%s\") % (alarm.description)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"def get_meter_name(alarm):"},{"line_number":124,"context_line":"    return _(\"%s\") % (alarm.threshold_rule[\u0027meter_name\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"bae84128_d4452a43","line":121,"updated":"2016-02-24 07:04:17.000000000","message":"Done","commit_id":"075ee6b94fc221fc81852424dd95c6199a3bae95"},{"author":{"_account_id":16871,"name":"Sanjana","email":"sanjana@hitachi.co.in","username":"sanjana_93"},"change_message_id":"c09e27bb6769885a9b31316674ba4a937e75d24c","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    class Meta(object):"},{"line_number":138,"context_line":"        name \u003d \"alarms\""},{"line_number":139,"context_line":"        verbose_name \u003d _(\"Alarms\")"},{"line_number":140,"context_line":"        table_actions \u003d (tables.NameFilterAction, CreateAlarm, DeleteAlarm)"},{"line_number":141,"context_line":"        row_actions \u003d (UpdateAlarm,"},{"line_number":142,"context_line":"                       ToggleEnabled,"},{"line_number":143,"context_line":"                       DeleteAlarm)"}],"source_content_type":"text/x-python","patch_set":14,"id":"bae84128_b4b2264a","line":140,"range":{"start_line":140,"start_character":25,"end_line":140,"end_character":48},"updated":"2016-02-24 07:04:17.000000000","message":"I have used generic class NameFilterAction, as the filtering is done based on the name to be more specific.","commit_id":"075ee6b94fc221fc81852424dd95c6199a3bae95"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9592fc71ab22b43efe55bec84d4cc26a82135e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from openstack_dashboard import api"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"ENABLE \u003d 0"},{"line_number":23,"context_line":"DISABLE \u003d 1"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class DeleteAlarm(tables.DeleteAction):"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_5cb89f11","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":11},"updated":"2016-05-04 01:31:23.000000000","message":"I think it is better to move them near to L.63 and add a comment what they mean.","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9592fc71ab22b43efe55bec84d4cc26a82135e","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"def get_alarm_name(alarm):"},{"line_number":116,"context_line":"    return _(\"%s\") % (alarm.name)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"def get_alarm_desc(alarm):"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_fc0d2be9","line":116,"range":{"start_line":116,"start_character":11,"end_line":116,"end_character":18},"updated":"2016-05-04 01:31:23.000000000","message":"There is no need to make the string translatable.\nThis potentially leads to a situation where a user see an unexpected translated string. For example, if a translation catalog contains a translation for a string of alarm.name, a user will get a translation. It is not an expected behavior.","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9592fc71ab22b43efe55bec84d4cc26a82135e","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"def get_alarm_desc(alarm):"},{"line_number":120,"context_line":"    return _(\"%s\") % (alarm.description)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"def get_meter_name(alarm):"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_9c2d1748","line":120,"range":{"start_line":120,"start_character":11,"end_line":120,"end_character":18},"updated":"2016-05-04 01:31:23.000000000","message":"ditto","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9592fc71ab22b43efe55bec84d4cc26a82135e","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"def get_meter_name(alarm):"},{"line_number":124,"context_line":"    return _(\"%s\") % (alarm.threshold_rule[\u0027meter_name\u0027])"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class AlarmsTable(tables.DataTable):"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_fc240b61","line":124,"range":{"start_line":124,"start_character":11,"end_line":124,"end_character":18},"updated":"2016-05-04 01:31:23.000000000","message":"ditto","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9592fc71ab22b43efe55bec84d4cc26a82135e","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class AlarmsTable(tables.DataTable):"},{"line_number":128,"context_line":"    name \u003d tables.Column(get_alarm_name,"},{"line_number":129,"context_line":"                         verbose_name\u003d_(\u0027Alarm Name\u0027),"},{"line_number":130,"context_line":"                         link\u003d(\"horizon:admin:alarms:detail\"))"},{"line_number":131,"context_line":"    meter_name \u003d tables.Column(get_meter_name, verbose_name\u003d_(\u0027Metric Name\u0027))"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_5cfd3fb0","line":128,"range":{"start_line":128,"start_character":25,"end_line":128,"end_character":39},"updated":"2016-05-04 01:31:23.000000000","message":"Per my comment at L.116, get_alarm_name does nothing. There is no need to use a function.\n\n  \"name\"","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9592fc71ab22b43efe55bec84d4cc26a82135e","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    name \u003d tables.Column(get_alarm_name,"},{"line_number":129,"context_line":"                         verbose_name\u003d_(\u0027Alarm Name\u0027),"},{"line_number":130,"context_line":"                         link\u003d(\"horizon:admin:alarms:detail\"))"},{"line_number":131,"context_line":"    meter_name \u003d tables.Column(get_meter_name, verbose_name\u003d_(\u0027Metric Name\u0027))"},{"line_number":132,"context_line":"    description \u003d tables.Column(get_alarm_desc,"},{"line_number":133,"context_line":"                                verbose_name\u003d_(\u0027Alarm Description\u0027))"},{"line_number":134,"context_line":"    status \u003d tables.Column(\"enabled\", verbose_name\u003d_(\u0027Enabled\u0027),"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_dc278f61","line":131,"range":{"start_line":131,"start_character":31,"end_line":131,"end_character":45},"updated":"2016-05-04 01:31:23.000000000","message":"ditto","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"11468213456dd0cd822a200ab1f8f9ba65db99f7","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    name \u003d tables.Column(get_alarm_name,"},{"line_number":129,"context_line":"                         verbose_name\u003d_(\u0027Alarm Name\u0027),"},{"line_number":130,"context_line":"                         link\u003d(\"horizon:admin:alarms:detail\"))"},{"line_number":131,"context_line":"    meter_name \u003d tables.Column(get_meter_name, verbose_name\u003d_(\u0027Metric Name\u0027))"},{"line_number":132,"context_line":"    description \u003d tables.Column(get_alarm_desc,"},{"line_number":133,"context_line":"                                verbose_name\u003d_(\u0027Alarm Description\u0027))"},{"line_number":134,"context_line":"    status \u003d tables.Column(\"enabled\", verbose_name\u003d_(\u0027Enabled\u0027),"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_06b4f632","line":131,"range":{"start_line":131,"start_character":31,"end_line":131,"end_character":45},"in_reply_to":"1a122d0e_dbdb0c20","updated":"2016-05-04 16:28:06.000000000","message":"You are right. In this case you need to access a member of dict, so a function is required.","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":16871,"name":"Sanjana","email":"sanjana@hitachi.co.in","username":"sanjana_93"},"change_message_id":"5cb800f5df33c8d3a6e5af61b4016eda993e105c","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    name \u003d tables.Column(get_alarm_name,"},{"line_number":129,"context_line":"                         verbose_name\u003d_(\u0027Alarm Name\u0027),"},{"line_number":130,"context_line":"                         link\u003d(\"horizon:admin:alarms:detail\"))"},{"line_number":131,"context_line":"    meter_name \u003d tables.Column(get_meter_name, verbose_name\u003d_(\u0027Metric Name\u0027))"},{"line_number":132,"context_line":"    description \u003d tables.Column(get_alarm_desc,"},{"line_number":133,"context_line":"                                verbose_name\u003d_(\u0027Alarm Description\u0027))"},{"line_number":134,"context_line":"    status \u003d tables.Column(\"enabled\", verbose_name\u003d_(\u0027Enabled\u0027),"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_dbdb0c20","line":131,"range":{"start_line":131,"start_character":31,"end_line":131,"end_character":45},"in_reply_to":"1a122d0e_dc278f61","updated":"2016-05-04 09:36:13.000000000","message":"how can i access the meter_name parameter here? I tried with\n\"threshold_rule[\u0027meter_name\u0027]\" but it doesn\u0027t fetch the name.","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9592fc71ab22b43efe55bec84d4cc26a82135e","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                         verbose_name\u003d_(\u0027Alarm Name\u0027),"},{"line_number":130,"context_line":"                         link\u003d(\"horizon:admin:alarms:detail\"))"},{"line_number":131,"context_line":"    meter_name \u003d tables.Column(get_meter_name, verbose_name\u003d_(\u0027Metric Name\u0027))"},{"line_number":132,"context_line":"    description \u003d tables.Column(get_alarm_desc,"},{"line_number":133,"context_line":"                                verbose_name\u003d_(\u0027Alarm Description\u0027))"},{"line_number":134,"context_line":"    status \u003d tables.Column(\"enabled\", verbose_name\u003d_(\u0027Enabled\u0027),"},{"line_number":135,"context_line":"                           filters\u003d(filters.yesno, filters.capfirst))"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_3c1fa30a","line":132,"range":{"start_line":132,"start_character":32,"end_line":132,"end_character":46},"updated":"2016-05-04 01:31:23.000000000","message":"ditto","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"}],"openstack_dashboard/dashboards/admin/alarms/templates/alarms/_detail_overview.html":[{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"ff2142252eb70bbe353c71285d6f34ac9a49bdbc","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    \u003cdt\u003e{% trans \"Enabled\" %}\u003c/dt\u003e"},{"line_number":14,"context_line":"    \u003cdd\u003e{{ alarm.enabled }}\u003c/dd\u003e"},{"line_number":15,"context_line":"    \u003cdt\u003e{% trans \"Description\" %}\u003c/dt\u003e"},{"line_number":16,"context_line":"    \u003cdd\u003e{{ alarm.description|default:_(\"None\") }}\u003c/dd\u003e"},{"line_number":17,"context_line":"  \u003c/dl\u003e"},{"line_number":18,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":14,"id":"7af24918_aa81e491","line":16,"updated":"2016-03-01 14:42:25.000000000","message":"Maybe it would be clearer to use empty string or something like that?","commit_id":"075ee6b94fc221fc81852424dd95c6199a3bae95"},{"author":{"_account_id":16871,"name":"Sanjana","email":"sanjana@hitachi.co.in","username":"sanjana_93"},"change_message_id":"a08ecc8082ebe8dea80375af144fca160686cc6d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    \u003cdt\u003e{% trans \"Enabled\" %}\u003c/dt\u003e"},{"line_number":14,"context_line":"    \u003cdd\u003e{{ alarm.enabled }}\u003c/dd\u003e"},{"line_number":15,"context_line":"    \u003cdt\u003e{% trans \"Description\" %}\u003c/dt\u003e"},{"line_number":16,"context_line":"    \u003cdd\u003e{{ alarm.description }}\u003c/dd\u003e"},{"line_number":17,"context_line":"  \u003c/dl\u003e"},{"line_number":18,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":15,"id":"5aef4532_1a4efa95","line":16,"updated":"2016-03-09 09:18:14.000000000","message":"Every alarm has a default description.So i don\u0027t think there is a need to explicitly mention it.","commit_id":"80dc482784d049110330a8a458dfda66efbfe1a3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9592fc71ab22b43efe55bec84d4cc26a82135e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    \u003cdt\u003e{% trans \"Alarm ID\" %}\u003c/dt\u003e"},{"line_number":12,"context_line":"    \u003cdd\u003e{{ alarm.id }}\u003c/dd\u003e"},{"line_number":13,"context_line":"    \u003cdt\u003e{% trans \"Enabled\" %}\u003c/dt\u003e"},{"line_number":14,"context_line":"    \u003cdd\u003e{{ alarm.enabled }}\u003c/dd\u003e"},{"line_number":15,"context_line":"    \u003cdt\u003e{% trans \"Description\" %}\u003c/dt\u003e"},{"line_number":16,"context_line":"    \u003cdd\u003e{{ alarm.description }}\u003c/dd\u003e"},{"line_number":17,"context_line":"  \u003c/dl\u003e"}],"source_content_type":"text/html","patch_set":16,"id":"1a122d0e_5c141fe8","line":14,"updated":"2016-05-04 01:31:23.000000000","message":"It is better to use \u0027yseno\u0027 filter for translation.","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":16871,"name":"Sanjana","email":"sanjana@hitachi.co.in","username":"sanjana_93"},"change_message_id":"5cb800f5df33c8d3a6e5af61b4016eda993e105c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    \u003cdt\u003e{% trans \"Alarm ID\" %}\u003c/dt\u003e"},{"line_number":12,"context_line":"    \u003cdd\u003e{{ alarm.id }}\u003c/dd\u003e"},{"line_number":13,"context_line":"    \u003cdt\u003e{% trans \"Enabled\" %}\u003c/dt\u003e"},{"line_number":14,"context_line":"    \u003cdd\u003e{{ alarm.enabled }}\u003c/dd\u003e"},{"line_number":15,"context_line":"    \u003cdt\u003e{% trans \"Description\" %}\u003c/dt\u003e"},{"line_number":16,"context_line":"    \u003cdd\u003e{{ alarm.description }}\u003c/dd\u003e"},{"line_number":17,"context_line":"  \u003c/dl\u003e"}],"source_content_type":"text/html","patch_set":16,"id":"1a122d0e_7f28e385","line":14,"in_reply_to":"1a122d0e_5c141fe8","updated":"2016-05-04 09:36:13.000000000","message":"Did you mean this?\n\u003cdd\u003e{{ alarm.enabled|yesno:_(\"yes,no,-\")}} \u003c/dd\u003e","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"11468213456dd0cd822a200ab1f8f9ba65db99f7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    \u003cdt\u003e{% trans \"Alarm ID\" %}\u003c/dt\u003e"},{"line_number":12,"context_line":"    \u003cdd\u003e{{ alarm.id }}\u003c/dd\u003e"},{"line_number":13,"context_line":"    \u003cdt\u003e{% trans \"Enabled\" %}\u003c/dt\u003e"},{"line_number":14,"context_line":"    \u003cdd\u003e{{ alarm.enabled }}\u003c/dd\u003e"},{"line_number":15,"context_line":"    \u003cdt\u003e{% trans \"Description\" %}\u003c/dt\u003e"},{"line_number":16,"context_line":"    \u003cdd\u003e{{ alarm.description }}\u003c/dd\u003e"},{"line_number":17,"context_line":"  \u003c/dl\u003e"}],"source_content_type":"text/html","patch_set":16,"id":"1a122d0e_468a6e1b","line":14,"in_reply_to":"1a122d0e_7f28e385","updated":"2016-05-04 16:28:06.000000000","message":"If valid values of \u0027enabled\u0027 are only True and False,\n\n  \u003cdd\u003e{{ alarm.enabled|yesno }} \u003c/dd\u003e\n\nis enough as many other templates do.","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"}],"openstack_dashboard/dashboards/admin/alarms/templates/alarms/detail.html":[{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"8029420257546bdce466c2574c539621425c8018","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Alarm Details\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"  {% include \"horizon/common/_page_header.html\" with title\u003dpage_title %}"},{"line_number":7,"context_line":"{% endblock page_header %}"}],"source_content_type":"text/html","patch_set":11,"id":"dae33548_d2bea4fe","line":4,"updated":"2016-02-15 02:47:14.000000000","message":"I think we need to add a breadcrumb_nav.\nIn general, all detail page have a breadcrumb list on header like below.\n\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/projects/templates/projects/detail.html#L3","commit_id":"32800cb0ddd6f8702b6e770cff7a1e2ab9ae785d"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"13af14dc08e2eda90b039de05739dc8f4c5498a8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% load breadcrumb_nav %}"},{"line_number":4,"context_line":"{% block title %}{% trans \"Alarm Details\" %}{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block page_header %}"}],"source_content_type":"text/html","patch_set":18,"id":"bab6814e_6d1d52bd","line":3,"updated":"2016-05-18 08:17:20.000000000","message":"Do we need this line ? base.html is already loading it.","commit_id":"487bdcc4ba14d18b5d2db9a7b0cab46fca574455"},{"author":{"_account_id":16871,"name":"Sanjana","email":"sanjana@hitachi.co.in","username":"sanjana_93"},"change_message_id":"5fcd93ec7f08f443279a117aa85923d38f96e7e8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% load breadcrumb_nav %}"},{"line_number":4,"context_line":"{% block title %}{% trans \"Alarm Details\" %}{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block page_header %}"}],"source_content_type":"text/html","patch_set":18,"id":"bab6814e_42ddb441","line":3,"in_reply_to":"bab6814e_6d1d52bd","updated":"2016-05-18 09:28:07.000000000","message":"Done","commit_id":"487bdcc4ba14d18b5d2db9a7b0cab46fca574455"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"13af14dc08e2eda90b039de05739dc8f4c5498a8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% load breadcrumb_nav %}"},{"line_number":4,"context_line":"{% block title %}{% trans \"Alarm Details\" %}{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block page_header %}"},{"line_number":7,"context_line":"  \u003cdiv class\u003d\u0027page-header\u0027\u003e"},{"line_number":8,"context_line":"    {% breadcrumb_nav %}"},{"line_number":9,"context_line":"  \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":18,"id":"bab6814e_10a5b903","line":6,"updated":"2016-05-18 08:17:20.000000000","message":"Same as above","commit_id":"487bdcc4ba14d18b5d2db9a7b0cab46fca574455"},{"author":{"_account_id":16871,"name":"Sanjana","email":"sanjana@hitachi.co.in","username":"sanjana_93"},"change_message_id":"5fcd93ec7f08f443279a117aa85923d38f96e7e8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% load breadcrumb_nav %}"},{"line_number":4,"context_line":"{% block title %}{% trans \"Alarm Details\" %}{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block page_header %}"},{"line_number":7,"context_line":"  \u003cdiv class\u003d\u0027page-header\u0027\u003e"},{"line_number":8,"context_line":"    {% breadcrumb_nav %}"},{"line_number":9,"context_line":"  \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":18,"id":"bab6814e_82e79c11","line":6,"in_reply_to":"bab6814e_10a5b903","updated":"2016-05-18 09:28:07.000000000","message":"Done","commit_id":"487bdcc4ba14d18b5d2db9a7b0cab46fca574455"}],"openstack_dashboard/dashboards/admin/alarms/templates/alarms/update.html":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"1724cbcebfe30982e71bcadc56cfe3e17ecdb7b6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Edit alarm\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block main %}"},{"line_number":6,"context_line":"    {% include \u0027horizon/common/_workflow.html\u0027 %}"}],"source_content_type":"text/html","patch_set":2,"id":"9a8ffd7b_785a3185","line":3,"updated":"2015-12-02 00:36:18.000000000","message":"Alarm*","commit_id":"cbb510127684a3724c6a558935ca887dca80e5c3"}],"openstack_dashboard/dashboards/admin/alarms/tests.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9592fc71ab22b43efe55bec84d4cc26a82135e","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            [\u0027\u003cCreateAlarmInfoStep: createalarminfoaction\u003e\u0027,"},{"line_number":77,"context_line":"             \u0027\u003cSetAlarmConditionsStep: set_alarm_conditions\u003e\u0027,"},{"line_number":78,"context_line":"             \u0027\u003cSetAlarmAfterStep: set_alarm_after\u003e\u0027])"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @test.create_stubs({api.ceilometer: (\u0027alarm_list\u0027,"},{"line_number":81,"context_line":"                                         \u0027resource_list\u0027,"},{"line_number":82,"context_line":"                                         \u0027meter_list\u0027,),"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_7c763b07","line":79,"updated":"2016-05-04 01:31:23.000000000","message":"Tests at L.80-273 are similar. Could you share the logic?","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"11468213456dd0cd822a200ab1f8f9ba65db99f7","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            [\u0027\u003cCreateAlarmInfoStep: createalarminfoaction\u003e\u0027,"},{"line_number":77,"context_line":"             \u0027\u003cSetAlarmConditionsStep: set_alarm_conditions\u003e\u0027,"},{"line_number":78,"context_line":"             \u0027\u003cSetAlarmAfterStep: set_alarm_after\u003e\u0027])"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @test.create_stubs({api.ceilometer: (\u0027alarm_list\u0027,"},{"line_number":81,"context_line":"                                         \u0027resource_list\u0027,"},{"line_number":82,"context_line":"                                         \u0027meter_list\u0027,),"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_a63a62e5","line":79,"in_reply_to":"1a122d0e_1b82a4c8","updated":"2016-05-04 16:28:06.000000000","message":"I know. What in my mind is the difference is more hilighlighted if you have a method to setup mocks.\n\n  def setup_create_alarm_mocks(self, alarm_list\u003dNone, resource_list\u003dNone, ....)","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":16871,"name":"Sanjana","email":"sanjana@hitachi.co.in","username":"sanjana_93"},"change_message_id":"5cb800f5df33c8d3a6e5af61b4016eda993e105c","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            [\u0027\u003cCreateAlarmInfoStep: createalarminfoaction\u003e\u0027,"},{"line_number":77,"context_line":"             \u0027\u003cSetAlarmConditionsStep: set_alarm_conditions\u003e\u0027,"},{"line_number":78,"context_line":"             \u0027\u003cSetAlarmAfterStep: set_alarm_after\u003e\u0027])"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @test.create_stubs({api.ceilometer: (\u0027alarm_list\u0027,"},{"line_number":81,"context_line":"                                         \u0027resource_list\u0027,"},{"line_number":82,"context_line":"                                         \u0027meter_list\u0027,),"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_1b82a4c8","line":79,"in_reply_to":"1a122d0e_7c763b07","updated":"2016-05-04 09:36:13.000000000","message":"I am explicitly setting the required fields to be empty(in case of alarm name, meter name, threshold) and asserting a form error","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":16871,"name":"Sanjana","email":"sanjana@hitachi.co.in","username":"sanjana_93"},"change_message_id":"6c93ea6cb9aacbfe4b5fff14b9b4fbdc1b2c6083","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            [\u0027\u003cCreateAlarmInfoStep: createalarminfoaction\u003e\u0027,"},{"line_number":77,"context_line":"             \u0027\u003cSetAlarmConditionsStep: set_alarm_conditions\u003e\u0027,"},{"line_number":78,"context_line":"             \u0027\u003cSetAlarmAfterStep: set_alarm_after\u003e\u0027])"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @test.create_stubs({api.ceilometer: (\u0027alarm_list\u0027,"},{"line_number":81,"context_line":"                                         \u0027resource_list\u0027,"},{"line_number":82,"context_line":"                                         \u0027meter_list\u0027,),"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_381ad36f","line":79,"in_reply_to":"1a122d0e_a63a62e5","updated":"2016-05-05 05:10:34.000000000","message":"Could you please elaborate","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9592fc71ab22b43efe55bec84d4cc26a82135e","unresolved":false,"context_lines":[{"line_number":322,"context_line":"                         alarm.threshold_rule[\u0027evaluation_periods\u0027])"},{"line_number":323,"context_line":"        self.assertEqual(step.action.initial[\u0027comparison_operator\u0027],"},{"line_number":324,"context_line":"                         alarm.threshold_rule[\u0027comparison_operator\u0027])"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"    @test.create_stubs({api.ceilometer: (\u0027alarm_get\u0027,"},{"line_number":327,"context_line":"                                         \u0027alarm_list\u0027,"},{"line_number":328,"context_line":"                                         \u0027resource_list\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_bcec5393","line":325,"updated":"2016-05-04 01:31:23.000000000","message":"All test_update_alarm_set_xxx tests are similar.\nCould you share the logic, particularly setting up mock?","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"}],"openstack_dashboard/dashboards/admin/alarms/urls.py":[{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"13af14dc08e2eda90b039de05739dc8f4c5498a8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from openstack_dashboard.dashboards.admin.alarms import views"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"urlpatterns \u003d patterns("},{"line_number":20,"context_line":"    \u0027openstack_dashboard.dashboards.admin.alarms.views\u0027,"},{"line_number":21,"context_line":"    url(r\u0027^$\u0027, views.IndexView.as_view(), name\u003d\u0027index\u0027),"},{"line_number":22,"context_line":"    url(r\u0027^create/$\u0027, views.CreateView.as_view(), name\u003d\u0027create\u0027),"}],"source_content_type":"text/x-python","patch_set":18,"id":"bab6814e_30cb9d74","line":19,"updated":"2016-05-18 08:17:20.000000000","message":"The format of \u0027urlpatterns\u0027 seems to be written by older version.\n\nlike below (you can refer to other urls.py\u0027s).\n\n    urlpatterns \u003d [\n        url(r\u0027^$\u0027, views.IndexView.as_view(), name\u003d\u0027index\u0027),\n    ]","commit_id":"487bdcc4ba14d18b5d2db9a7b0cab46fca574455"},{"author":{"_account_id":16871,"name":"Sanjana","email":"sanjana@hitachi.co.in","username":"sanjana_93"},"change_message_id":"5fcd93ec7f08f443279a117aa85923d38f96e7e8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from openstack_dashboard.dashboards.admin.alarms import views"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"urlpatterns \u003d patterns("},{"line_number":20,"context_line":"    \u0027openstack_dashboard.dashboards.admin.alarms.views\u0027,"},{"line_number":21,"context_line":"    url(r\u0027^$\u0027, views.IndexView.as_view(), name\u003d\u0027index\u0027),"},{"line_number":22,"context_line":"    url(r\u0027^create/$\u0027, views.CreateView.as_view(), name\u003d\u0027create\u0027),"}],"source_content_type":"text/x-python","patch_set":18,"id":"bab6814e_02ba8ce1","line":19,"in_reply_to":"bab6814e_30cb9d74","updated":"2016-05-18 09:28:07.000000000","message":"Done","commit_id":"487bdcc4ba14d18b5d2db9a7b0cab46fca574455"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"77d9b2cd3a1bf65d04f3f19af95443f7e5c10dc0","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    url(r\u0027^$\u0027, views.IndexView.as_view(), name\u003d\u0027index\u0027),"},{"line_number":20,"context_line":"    url(r\u0027^create/$\u0027, views.CreateView.as_view(), name\u003d\u0027create\u0027),"},{"line_number":21,"context_line":"    url(r\u0027^(?P\u003cid\u003e[^/]+)/update/$\u0027, views.UpdateView.as_view(), name\u003d\u0027update\u0027),"},{"line_number":22,"context_line":"    url(r\u0027^(?P\u003calarm_id\u003e[^/]+)/detail/$\u0027,"},{"line_number":23,"context_line":"        views.DetailProjectView.as_view(), name\u003d\u0027detail\u0027),"},{"line_number":24,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":22,"id":"3aaa91ec_98a736a6","line":22,"updated":"2016-06-27 01:34:24.000000000","message":"According to https://review.openstack.org/#/c/331895/, \u0027detail\u0027 is unnecessary in url.","commit_id":"2db379a3d9258fe26e839df68f6a4ca9dce98ca2"},{"author":{"_account_id":16871,"name":"Sanjana","email":"sanjana@hitachi.co.in","username":"sanjana_93"},"change_message_id":"769aa028c77ef681e2e085f223d524c0a9487028","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    url(r\u0027^$\u0027, views.IndexView.as_view(), name\u003d\u0027index\u0027),"},{"line_number":20,"context_line":"    url(r\u0027^create/$\u0027, views.CreateView.as_view(), name\u003d\u0027create\u0027),"},{"line_number":21,"context_line":"    url(r\u0027^(?P\u003cid\u003e[^/]+)/update/$\u0027, views.UpdateView.as_view(), name\u003d\u0027update\u0027),"},{"line_number":22,"context_line":"    url(r\u0027^(?P\u003calarm_id\u003e[^/]+)/detail/$\u0027,"},{"line_number":23,"context_line":"        views.DetailProjectView.as_view(), name\u003d\u0027detail\u0027),"},{"line_number":24,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":22,"id":"3aaa91ec_8e61b007","line":22,"in_reply_to":"3aaa91ec_98a736a6","updated":"2016-06-27 03:51:49.000000000","message":"Thanks for pointing that out. But i think it would be appropriate to make the changes after the patch you mentioned ( https://review.openstack.org/#/c/331895/) is merged. What do you say?","commit_id":"2db379a3d9258fe26e839df68f6a4ca9dce98ca2"}],"openstack_dashboard/dashboards/admin/alarms/views.py":[{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"b0202aecff85723dfc2a4aad6c00a2c120c50c35","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            exceptions.handle(request,"},{"line_number":47,"context_line":"                              _(\u0027Unable to retrieve alarm list.\u0027))"},{"line_number":48,"context_line":"            LOG.debug(\u0027Unable to retrieve alarm list\u0027)"},{"line_number":49,"context_line":"        alarms.sort(key\u003dlambda a: (a.name))"},{"line_number":50,"context_line":"        return alarms"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5a5ae5dd_08b9b1ec","line":49,"range":{"start_line":49,"start_character":15,"end_line":49,"end_character":19},"updated":"2016-02-09 08:10:21.000000000","message":"why we have to sort the list here? i guess it will be done while displaying the data.","commit_id":"6d374a47847b73b194ae69b1528998f281694f97"},{"author":{"_account_id":16871,"name":"Sanjana","email":"sanjana@hitachi.co.in","username":"sanjana_93"},"change_message_id":"03e3dd7d15442ed0ad53cad5492177542174c01d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            exceptions.handle(request,"},{"line_number":47,"context_line":"                              _(\u0027Unable to retrieve alarm list.\u0027))"},{"line_number":48,"context_line":"            LOG.debug(\u0027Unable to retrieve alarm list\u0027)"},{"line_number":49,"context_line":"        alarms.sort(key\u003dlambda a: (a.name))"},{"line_number":50,"context_line":"        return alarms"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5a5ae5dd_95737915","line":49,"range":{"start_line":49,"start_character":15,"end_line":49,"end_character":19},"in_reply_to":"5a5ae5dd_08b9b1ec","updated":"2016-02-09 09:50:20.000000000","message":"I think the sorting itself is not required as sorting based on name might not be expected. Should i consider removing this line?","commit_id":"6d374a47847b73b194ae69b1528998f281694f97"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9592fc71ab22b43efe55bec84d4cc26a82135e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    import workflows as alarm_workflows"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"INDEX_URL \u003d \"horizon:admin:alarms:index\""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_3ce68316","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":40},"updated":"2016-05-04 01:31:23.000000000","message":"constants.ALARMS_INDEX_URL?\n\nIf you define constants in constants.py, please use them.\nOtherwise, do not define them. I am okay with either, but make sure to keep the usage consistent.","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9592fc71ab22b43efe55bec84d4cc26a82135e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        except Exception:"},{"line_number":46,"context_line":"            exceptions.handle(request,"},{"line_number":47,"context_line":"                              _(\u0027Unable to retrieve alarm list.\u0027))"},{"line_number":48,"context_line":"            LOG.debug(\u0027Unable to retrieve alarm list\u0027)"},{"line_number":49,"context_line":"        alarms.sort(key\u003dlambda a: (a.name))"},{"line_number":50,"context_line":"        return alarms"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_fcb24b05","line":48,"range":{"start_line":48,"start_character":16,"end_line":48,"end_character":21},"updated":"2016-05-04 01:31:23.000000000","message":"I am not sure \u0027debug\u0027 is a good log level.","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9592fc71ab22b43efe55bec84d4cc26a82135e","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            exceptions.handle(self.request,"},{"line_number":104,"context_line":"                              _(\u0027Unable to retrieve alarm details.\u0027),"},{"line_number":105,"context_line":"                              redirect\u003dreverse(INDEX_URL))"},{"line_number":106,"context_line":"        return alarm"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_1c8f472f","line":106,"updated":"2016-05-04 01:31:23.000000000","message":"nit: From the readability point of view, it is better to move this to inside of try-clause.","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"13af14dc08e2eda90b039de05739dc8f4c5498a8","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                    \u0027threshold\u0027: alarm.threshold_rule[\u0027threshold\u0027],"},{"line_number":80,"context_line":"                    \u0027comparison_operator\u0027: comp_op}"},{"line_number":81,"context_line":"        except Exception:"},{"line_number":82,"context_line":"            exceptions.handle(self.request,"},{"line_number":83,"context_line":"                              _(\u0027Unable to retrieve alarm details. \u0027))"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"bab6814e_b0930d4f","line":82,"updated":"2016-05-18 08:17:20.000000000","message":"Do we need LOG.info as well?","commit_id":"487bdcc4ba14d18b5d2db9a7b0cab46fca574455"},{"author":{"_account_id":16871,"name":"Sanjana","email":"sanjana@hitachi.co.in","username":"sanjana_93"},"change_message_id":"5fcd93ec7f08f443279a117aa85923d38f96e7e8","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                    \u0027threshold\u0027: alarm.threshold_rule[\u0027threshold\u0027],"},{"line_number":80,"context_line":"                    \u0027comparison_operator\u0027: comp_op}"},{"line_number":81,"context_line":"        except Exception:"},{"line_number":82,"context_line":"            exceptions.handle(self.request,"},{"line_number":83,"context_line":"                              _(\u0027Unable to retrieve alarm details. \u0027))"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"bab6814e_82ce7c81","line":82,"in_reply_to":"bab6814e_b0930d4f","updated":"2016-05-18 09:28:07.000000000","message":"Done","commit_id":"487bdcc4ba14d18b5d2db9a7b0cab46fca574455"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"77d9b2cd3a1bf65d04f3f19af95443f7e5c10dc0","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            LOG.info(\u0027Unable to retrieve alarm list: %s\u0027, e)"},{"line_number":50,"context_line":"            exceptions.handle(self.request,"},{"line_number":51,"context_line":"                              _(\u0027Unable to retrieve alarm list.\u0027))"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class CreateView(workflows.WorkflowView):"},{"line_number":55,"context_line":"    workflow_class \u003d alarm_workflows.CreateAlarm"}],"source_content_type":"text/x-python","patch_set":22,"id":"3aaa91ec_18286632","line":52,"updated":"2016-06-27 01:34:24.000000000","message":"In this case, it needs to return \"alarms\". Otherwise the return value of this method is not iteratable. As a result, templateexception will occur.","commit_id":"2db379a3d9258fe26e839df68f6a4ca9dce98ca2"},{"author":{"_account_id":16871,"name":"Sanjana","email":"sanjana@hitachi.co.in","username":"sanjana_93"},"change_message_id":"769aa028c77ef681e2e085f223d524c0a9487028","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            LOG.info(\u0027Unable to retrieve alarm list: %s\u0027, e)"},{"line_number":50,"context_line":"            exceptions.handle(self.request,"},{"line_number":51,"context_line":"                              _(\u0027Unable to retrieve alarm list.\u0027))"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class CreateView(workflows.WorkflowView):"},{"line_number":55,"context_line":"    workflow_class \u003d alarm_workflows.CreateAlarm"}],"source_content_type":"text/x-python","patch_set":22,"id":"3aaa91ec_ae48ecb3","line":52,"in_reply_to":"3aaa91ec_18286632","updated":"2016-06-27 03:51:49.000000000","message":"I have the return statement within the try block.From the readability point of view, it was suggested by earlier review comments that it would be better to move this inside the try-clause.","commit_id":"2db379a3d9258fe26e839df68f6a4ca9dce98ca2"}],"openstack_dashboard/dashboards/admin/alarms/workflows.py":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"1724cbcebfe30982e71bcadc56cfe3e17ecdb7b6","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"OPERATOR_CHOICES \u003d ("},{"line_number":144,"context_line":"    (\u0027gt\u0027, _(\u0027Greater_than\u0027)),"},{"line_number":145,"context_line":"    (\u0027lt\u0027, _(\u0027Lesser_than\u0027)),"},{"line_number":146,"context_line":"    (\u0027ne\u0027, _(\u0027NotEqual\u0027)),"},{"line_number":147,"context_line":"    (\u0027ge\u0027, _(\u0027Greater_or_Equal\u0027)),"},{"line_number":148,"context_line":"    (\u0027le\u0027, _(\u0027Lesser_or_Equal\u0027)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_cc0362b7","line":145,"updated":"2015-12-02 00:36:18.000000000","message":"Less than*","commit_id":"cbb510127684a3724c6a558935ca887dca80e5c3"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"1724cbcebfe30982e71bcadc56cfe3e17ecdb7b6","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    (\u0027lt\u0027, _(\u0027Lesser_than\u0027)),"},{"line_number":146,"context_line":"    (\u0027ne\u0027, _(\u0027NotEqual\u0027)),"},{"line_number":147,"context_line":"    (\u0027ge\u0027, _(\u0027Greater_or_Equal\u0027)),"},{"line_number":148,"context_line":"    (\u0027le\u0027, _(\u0027Lesser_or_Equal\u0027)),"},{"line_number":149,"context_line":"    (\u0027eq\u0027, _(\u0027Equal\u0027)),"},{"line_number":150,"context_line":")"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_ecfe66ad","line":148,"updated":"2015-12-02 00:36:18.000000000","message":"Less or Equal*","commit_id":"cbb510127684a3724c6a558935ca887dca80e5c3"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"1724cbcebfe30982e71bcadc56cfe3e17ecdb7b6","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    (\u0027ge\u0027, _(\u0027Greater_or_Equal\u0027)),"},{"line_number":148,"context_line":"    (\u0027le\u0027, _(\u0027Lesser_or_Equal\u0027)),"},{"line_number":149,"context_line":"    (\u0027eq\u0027, _(\u0027Equal\u0027)),"},{"line_number":150,"context_line":")"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"class SetAlarmConditionsAction(workflows.Action):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_2cf54eca","line":150,"updated":"2015-12-02 00:36:18.000000000","message":"Do we need the underscores?","commit_id":"cbb510127684a3724c6a558935ca887dca80e5c3"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"1724cbcebfe30982e71bcadc56cfe3e17ecdb7b6","unresolved":false,"context_lines":[{"line_number":153,"context_line":"class SetAlarmConditionsAction(workflows.Action):"},{"line_number":154,"context_line":"    meter_name \u003d forms.ChoiceField(label\u003d_(\"Meter\"),"},{"line_number":155,"context_line":"                                   required\u003dTrue)"},{"line_number":156,"context_line":"    comparison_operator \u003d forms.ChoiceField(label\u003d_(\"operators\"),"},{"line_number":157,"context_line":"                                            choices\u003dOPERATOR_CHOICES)"},{"line_number":158,"context_line":"    threshold \u003d forms.FloatField(label\u003d_(\"Threshold\"),"},{"line_number":159,"context_line":"                                 min_value\u003d1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_0c216a4d","line":156,"updated":"2015-12-02 00:36:18.000000000","message":"Operators*","commit_id":"cbb510127684a3724c6a558935ca887dca80e5c3"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"1724cbcebfe30982e71bcadc56cfe3e17ecdb7b6","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                                min_value\u003d1,"},{"line_number":162,"context_line":"                                required\u003dFalse)"},{"line_number":163,"context_line":"    evaluation_period \u003d forms.IntegerField(min_value\u003d1,"},{"line_number":164,"context_line":"                                           required\u003dFalse)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":167,"context_line":"        super(SetAlarmConditionsAction, self).__init__(request,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_3dfa5bbe","line":164,"updated":"2015-12-02 00:36:18.000000000","message":"what\u0027s the difference between period and evaluation_period? what\u0027s the unit for this one?","commit_id":"cbb510127684a3724c6a558935ca887dca80e5c3"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"1724cbcebfe30982e71bcadc56cfe3e17ecdb7b6","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"class SetAlarmAfterAction(workflows.Action):"},{"line_number":211,"context_line":"    alarm_action \u003d forms.CharField(label\u003d(\"Alarm Action\"), required\u003dFalse)"},{"line_number":212,"context_line":"    ok_action \u003d forms.CharField(label\u003d(\"OK Action\"), required\u003dFalse)"},{"line_number":213,"context_line":"    insufficient_data_action \u003d forms.CharField(label\u003d"},{"line_number":214,"context_line":"                                               (\"Insufficient Data Action\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_0cd2ca00","line":211,"updated":"2015-12-02 00:36:18.000000000","message":"put some help text here to describe in what form\n\n\"The alarm action may be either \u0027log://\u0027, which case the alarm will be logged in your Ceilometer log file, or it can be an http(s) endpoint (i.e., a URL), in which case the contents of the alarm will be POSTed, JSON-formatted, to the URL specified.\" (https://wiki.openstack.org/wiki/Ceilometer/Alerting)","commit_id":"cbb510127684a3724c6a558935ca887dca80e5c3"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"02e3fbb0985f7e7e0011e6fee44abbb0148c6f1b","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        if alarms is not None:"},{"line_number":125,"context_line":"            for alarm in alarms:"},{"line_number":126,"context_line":"                if alarm.name \u003d\u003d name:"},{"line_number":127,"context_line":"                    raise forms.ValidationError("},{"line_number":128,"context_line":"                        _(\u0027The name %s is already used by another alarm.\u0027)"},{"line_number":129,"context_line":"                        % name"},{"line_number":130,"context_line":"                    )"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_c2bd6669","line":127,"range":{"start_line":127,"start_character":20,"end_line":127,"end_character":25},"updated":"2016-01-04 12:07:55.000000000","message":"instead of raising to as a general form error. this could be shown below the text field.","commit_id":"4a473437db96ab84906de7f7038b01a3941b8dee"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"02e3fbb0985f7e7e0011e6fee44abbb0148c6f1b","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        return cleaned_data"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"class CreateAlarmInfo(workflows.Step):"},{"line_number":135,"context_line":"    action_class \u003d CreateAlarmInfoAction"},{"line_number":136,"context_line":"    contributes \u003d (\"name\","},{"line_number":137,"context_line":"                   \"alarm_id\","}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_1d1a036f","line":134,"range":{"start_line":134,"start_character":6,"end_line":134,"end_character":21},"updated":"2016-01-04 12:07:55.000000000","message":"nit: similar to CreateAlaramInfoAction this could be renamed as CreateAlarmInfoStep.","commit_id":"4a473437db96ab84906de7f7038b01a3941b8dee"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"02e3fbb0985f7e7e0011e6fee44abbb0148c6f1b","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"OPERATOR_CHOICES \u003d ("},{"line_number":145,"context_line":"    (\u0027gt\u0027, _(\u0027Greater_than\u0027)),"},{"line_number":146,"context_line":"    (\u0027lt\u0027, _(\u0027Less_than\u0027)),"},{"line_number":147,"context_line":"    (\u0027ne\u0027, _(\u0027NotEqual\u0027)),"},{"line_number":148,"context_line":"    (\u0027ge\u0027, _(\u0027Greater_or_Equal\u0027)),"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_42cc166a","line":145,"range":{"start_line":145,"start_character":14,"end_line":145,"end_character":26},"updated":"2016-01-04 12:07:55.000000000","message":"these are display values. why we have use \u0027_\u0027 between the words?","commit_id":"4a473437db96ab84906de7f7038b01a3941b8dee"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"02e3fbb0985f7e7e0011e6fee44abbb0148c6f1b","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"class SetAlarmConditionsAction(workflows.Action):"},{"line_number":155,"context_line":"    meter_name \u003d forms.ChoiceField(label\u003d_(\"Meter\"),"},{"line_number":156,"context_line":"                                   required\u003dTrue)"},{"line_number":157,"context_line":"    comparison_operator \u003d forms.ChoiceField(label\u003d_(\"Operator\"),"},{"line_number":158,"context_line":"                                            choices\u003dOPERATOR_CHOICES)"},{"line_number":159,"context_line":"    threshold \u003d forms.FloatField(label\u003d_(\"Threshold\"),"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_42a5f69f","line":156,"range":{"start_line":156,"start_character":35,"end_line":156,"end_character":43},"updated":"2016-01-04 12:07:55.000000000","message":"by default it will be true. no need to set explicitly","commit_id":"4a473437db96ab84906de7f7038b01a3941b8dee"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"02e3fbb0985f7e7e0011e6fee44abbb0148c6f1b","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    def _get_meter_list_choices(self, request):"},{"line_number":176,"context_line":"        meter_choices \u003d [(\u0027\u0027, _(\"Select a meter\"))]"},{"line_number":177,"context_line":"        meter_list \u003d self._get_meters(request)"},{"line_number":178,"context_line":"        for obj in meter_list:"},{"line_number":179,"context_line":"            flag \u003d 0"},{"line_number":180,"context_line":"            for tup in meter_choices:"},{"line_number":181,"context_line":"                if obj.name \u003d\u003d tup[1]:"},{"line_number":182,"context_line":"                    flag \u003d 1"},{"line_number":183,"context_line":"            if flag \u003d\u003d 0:"},{"line_number":184,"context_line":"                meter_choices.append((obj.name, obj.name))"},{"line_number":185,"context_line":"        return meter_choices"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_ddba2bc0","line":183,"range":{"start_line":178,"start_character":8,"end_line":183,"end_character":25},"updated":"2016-01-04 12:07:55.000000000","message":"why this condition check here? is \"meter_list\" api returns duplicate values?.","commit_id":"4a473437db96ab84906de7f7038b01a3941b8dee"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"02e3fbb0985f7e7e0011e6fee44abbb0148c6f1b","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"class UpdateAlarmInfoAction(CreateAlarmInfoAction):"},{"line_number":236,"context_line":"    alarm_id \u003d forms.CharField(widget\u003dforms.HiddenInput(),"},{"line_number":237,"context_line":"                               required\u003dTrue)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    class Meta(object):"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_9d87d3d6","line":236,"range":{"start_line":236,"start_character":4,"end_line":236,"end_character":12},"updated":"2016-01-04 12:07:55.000000000","message":"this field already present in the parent class. i guess it should be removed in the parent class.","commit_id":"4a473437db96ab84906de7f7038b01a3941b8dee"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"02e3fbb0985f7e7e0011e6fee44abbb0148c6f1b","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        try:"},{"line_number":248,"context_line":"            alarms \u003d api.ceilometer.alarm_list(self.request)"},{"line_number":249,"context_line":"            # Avoid comparison of alarm with itself in case of Alarm update"},{"line_number":250,"context_line":"            for a in alarms:"},{"line_number":251,"context_line":"                if a.alarm_id \u003d\u003d alarm_id:"},{"line_number":252,"context_line":"                    alarms.remove(a)"},{"line_number":253,"context_line":"            if alarms is not None:"},{"line_number":254,"context_line":"                for alarm in alarms:"},{"line_number":255,"context_line":"                    if alarm.name \u003d\u003d name and alarm.id !\u003d alarm_id:"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_5dff1b34","line":252,"range":{"start_line":250,"start_character":12,"end_line":252,"end_character":36},"updated":"2016-01-04 12:07:55.000000000","message":"you can write like this,\n\nif a in alarms:\n    alarms.remove(a)","commit_id":"4a473437db96ab84906de7f7038b01a3941b8dee"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"80fa3fff839333d08ab702841d4a1bf3f987c68c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"class CreateAlarmInfoAction(workflows.Action):"},{"line_number":28,"context_line":"    name \u003d forms.CharField(label\u003d_(\"Alarm Name\"),"},{"line_number":29,"context_line":"                           max_length\u003d255)"},{"line_number":30,"context_line":"    description \u003d forms.CharField(label\u003d(\"Description\"),"},{"line_number":31,"context_line":"                                  widget\u003dforms.Textarea(),"},{"line_number":32,"context_line":"                                  required\u003dFalse)"},{"line_number":33,"context_line":"    project \u003d forms.ChoiceField(label\u003d_(\"Project\"),"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_9ba1bc48","line":30,"updated":"2016-02-01 11:34:01.000000000","message":"It is better to use same definition of other description fields.\n\n    description \u003d forms.CharField(widget\u003dforms.widgets.Textarea(\n                                  attrs\u003d{\u0027rows\u0027: 4}),\n                                  label\u003d_(\"Description\"),\n                                  required\u003dFalse)","commit_id":"7e5d39f96fed019f957bc1b39c746ec436977e98"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"18c8ecee20a104bb0e16ecaa41a0b04a765601e5","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        if alarms is not None:"},{"line_number":124,"context_line":"            for alarm in alarms:"},{"line_number":125,"context_line":"                if alarm.name \u003d\u003d name:"},{"line_number":126,"context_line":"                    raise forms.ValidationError("},{"line_number":127,"context_line":"                        _(\u0027The name %s is already used by another alarm.\u0027)"},{"line_number":128,"context_line":"                        % name"},{"line_number":129,"context_line":"                    )"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a57f1b5_2c635e1c","line":126,"range":{"start_line":126,"start_character":32,"end_line":126,"end_character":47},"updated":"2016-02-10 07:32:19.000000000","message":"This error is specific to the name field. so if you are displaying the error in below the name field will be good.","commit_id":"32800cb0ddd6f8702b6e770cff7a1e2ab9ae785d"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"18c8ecee20a104bb0e16ecaa41a0b04a765601e5","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    def _get_meter_list_choices(self, request):"},{"line_number":173,"context_line":"        meter_choices \u003d [(\u0027\u0027, _(\"Select a meter\"))]"},{"line_number":174,"context_line":"        meter_list \u003d self._get_meters(request)"},{"line_number":175,"context_line":"        for obj in meter_list:"},{"line_number":176,"context_line":"            flag \u003d 0"},{"line_number":177,"context_line":"            for tup in meter_choices:"},{"line_number":178,"context_line":"                if obj.name \u003d\u003d tup[1]:"},{"line_number":179,"context_line":"                    flag \u003d 1"},{"line_number":180,"context_line":"            if flag \u003d\u003d 0:"},{"line_number":181,"context_line":"                meter_choices.append((obj.name, obj.name))"},{"line_number":182,"context_line":"        return meter_choices"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    # Get a list of ceilometer meters"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a57f1b5_274db772","line":181,"range":{"start_line":175,"start_character":8,"end_line":181,"end_character":58},"updated":"2016-02-10 07:32:19.000000000","message":"we can change the code in simplified way like below,\nfor obj in meter_list:\n  if (obj.name, obj.name) not in meter_choices:\n    meter_choices.append((obj.name, obj.name))","commit_id":"32800cb0ddd6f8702b6e770cff7a1e2ab9ae785d"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"18c8ecee20a104bb0e16ecaa41a0b04a765601e5","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        name \u003d self.cleaned_data.get(\u0027name\u0027)"},{"line_number":243,"context_line":"        alarm_id \u003d self.cleaned_data.get(\u0027alarm_id\u0027)"},{"line_number":244,"context_line":"        try:"},{"line_number":245,"context_line":"            alarms \u003d api.ceilometer.alarm_list(self.request)"},{"line_number":246,"context_line":"            # Avoid comparison of alarm with itself in case of Alarm update"},{"line_number":247,"context_line":"            if alarms is not None:"},{"line_number":248,"context_line":"                for alarm in alarms:"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a57f1b5_07cf5bb1","line":245,"range":{"start_line":245,"start_character":21,"end_line":245,"end_character":46},"updated":"2016-02-10 07:32:19.000000000","message":"This api called twice in this file. i think you can have a private method to get the alarm_list.","commit_id":"32800cb0ddd6f8702b6e770cff7a1e2ab9ae785d"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"18c8ecee20a104bb0e16ecaa41a0b04a765601e5","unresolved":false,"context_lines":[{"line_number":248,"context_line":"                for alarm in alarms:"},{"line_number":249,"context_line":"                    if alarm.name \u003d\u003d name and alarm.id !\u003d alarm_id:"},{"line_number":250,"context_line":"                        msg \u003d _(\u0027The name \"%s\" is used by another alarm.\u0027)"},{"line_number":251,"context_line":"                        raise forms.ValidationError(msg % name)"},{"line_number":252,"context_line":"        except Exception:"},{"line_number":253,"context_line":"            alarms \u003d []"},{"line_number":254,"context_line":"            msg \u003d _(\"Unable to get alarm list\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a57f1b5_878d8b7d","line":251,"range":{"start_line":251,"start_character":36,"end_line":251,"end_character":51},"updated":"2016-02-10 07:32:19.000000000","message":"dito: display the error in the name field.","commit_id":"32800cb0ddd6f8702b6e770cff7a1e2ab9ae785d"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"a0b882cdcacec3fb0906109830e5a0549eaba02b","unresolved":false,"context_lines":[{"line_number":336,"context_line":"            return alarm"},{"line_number":337,"context_line":"        except Exception:"},{"line_number":338,"context_line":"            exceptions.handle(request, _(\"Unable to edit alarm.\"))"},{"line_number":339,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":13,"id":"bae84128_e3f2ef99","line":339,"range":{"start_line":339,"start_character":0,"end_line":339,"end_character":24},"updated":"2016-02-19 17:08:06.000000000","message":"should we check policy in the workflow?","commit_id":"90c581ca7aa2ebf350da7dba02e1e05a8a60efa5"},{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"ff2142252eb70bbe353c71285d6f34ac9a49bdbc","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            resource_choices.append((obj.resource_id, obj.metadata[\u0027name\u0027]))"},{"line_number":57,"context_line":"        return resource_choices"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    # Get a list of ceilometer resources"},{"line_number":60,"context_line":"    def _get_resources(self, request):"},{"line_number":61,"context_line":"        resources \u003d []"},{"line_number":62,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":14,"id":"7af24918_ca1c307a","line":59,"updated":"2016-03-01 14:42:25.000000000","message":"Maybe we can get rid of this comments? Function name looks quite obvious.","commit_id":"075ee6b94fc221fc81852424dd95c6199a3bae95"},{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"ff2142252eb70bbe353c71285d6f34ac9a49bdbc","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        try:"},{"line_number":99,"context_line":"            projects, has_more \u003d api.keystone.tenant_list(request)"},{"line_number":100,"context_line":"        except Exception:"},{"line_number":101,"context_line":"            msg \u003d _(\u0027Project list cannot be retrieved.\u0027)"},{"line_number":102,"context_line":"            LOG.info(msg)"},{"line_number":103,"context_line":"            exceptions.handle(request, msg)"},{"line_number":104,"context_line":"        return projects"}],"source_content_type":"text/x-python","patch_set":14,"id":"7af24918_8c13655c","line":101,"updated":"2016-03-01 14:42:25.000000000","message":"Looks like the common text for this error in Horizon is `Unable to retrieve project list.`","commit_id":"075ee6b94fc221fc81852424dd95c6199a3bae95"},{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"ff2142252eb70bbe353c71285d6f34ac9a49bdbc","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"class SetAlarmAfterAction(workflows.Action):"},{"line_number":204,"context_line":"    alarm_action \u003d forms.CharField(label\u003d(\"Alarm Action\"), required\u003dFalse)"},{"line_number":205,"context_line":"    ok_action \u003d forms.CharField(label\u003d(\"OK Action\"), required\u003dFalse)"},{"line_number":206,"context_line":"    insufficient_data_action \u003d forms.CharField("},{"line_number":207,"context_line":"        label\u003d(\"Insufficient Data Action\"), required\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":14,"id":"7af24918_0c4d9572","line":204,"updated":"2016-03-01 14:42:25.000000000","message":"Should we make these labels translatable?","commit_id":"075ee6b94fc221fc81852424dd95c6199a3bae95"},{"author":{"_account_id":16871,"name":"Sanjana","email":"sanjana@hitachi.co.in","username":"sanjana_93"},"change_message_id":"a08ecc8082ebe8dea80375af144fca160686cc6d","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        try:"},{"line_number":96,"context_line":"            projects, has_more \u003d api.keystone.tenant_list(request)"},{"line_number":97,"context_line":"        except Exception:"},{"line_number":98,"context_line":"            msg \u003d _(\u0027Unable to retrieve project list.\u0027)"},{"line_number":99,"context_line":"            LOG.info(msg)"},{"line_number":100,"context_line":"            exceptions.handle(request, msg)"},{"line_number":101,"context_line":"        return projects"}],"source_content_type":"text/x-python","patch_set":15,"id":"5aef4532_d5c0e52c","line":98,"updated":"2016-03-09 09:18:14.000000000","message":"Modified the message as per the common text in Horizon","commit_id":"80dc482784d049110330a8a458dfda66efbfe1a3"},{"author":{"_account_id":16871,"name":"Sanjana","email":"sanjana@hitachi.co.in","username":"sanjana_93"},"change_message_id":"a08ecc8082ebe8dea80375af144fca160686cc6d","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"class SetAlarmAfterAction(workflows.Action):"},{"line_number":201,"context_line":"    alarm_action \u003d forms.CharField(label\u003d_(\"Alarm Action\"), required\u003dFalse)"},{"line_number":202,"context_line":"    ok_action \u003d forms.CharField(label\u003d_(\"OK Action\"), required\u003dFalse)"},{"line_number":203,"context_line":"    insufficient_data_action \u003d forms.CharField("},{"line_number":204,"context_line":"        label\u003d_(\"Insufficient Data Action\"), required\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":15,"id":"5aef4532_b5e8b9e3","line":201,"updated":"2016-03-09 09:18:14.000000000","message":"Made labels translatable.","commit_id":"80dc482784d049110330a8a458dfda66efbfe1a3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9592fc71ab22b43efe55bec84d4cc26a82135e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                                  label\u003d_(\"Description\"),"},{"line_number":33,"context_line":"                                  required\u003dFalse)"},{"line_number":34,"context_line":"    project \u003d forms.ChoiceField(label\u003d_(\"Project\"),"},{"line_number":35,"context_line":"                                required\u003dFalse)"},{"line_number":36,"context_line":"    user \u003d forms.ChoiceField(label\u003d_(\"User\"),"},{"line_number":37,"context_line":"                             required\u003dFalse)"},{"line_number":38,"context_line":"    resource \u003d forms.ChoiceField(label\u003d_(\"Resource\"),"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_3c7b232b","line":35,"range":{"start_line":35,"start_character":32,"end_line":35,"end_character":46},"updated":"2016-05-04 01:31:23.000000000","message":"is it okay? What happens when None is specified for \u0027project\u0027?","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9592fc71ab22b43efe55bec84d4cc26a82135e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    project \u003d forms.ChoiceField(label\u003d_(\"Project\"),"},{"line_number":35,"context_line":"                                required\u003dFalse)"},{"line_number":36,"context_line":"    user \u003d forms.ChoiceField(label\u003d_(\"User\"),"},{"line_number":37,"context_line":"                             required\u003dFalse)"},{"line_number":38,"context_line":"    resource \u003d forms.ChoiceField(label\u003d_(\"Resource\"),"},{"line_number":39,"context_line":"                                 required\u003dFalse)"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_7c759b30","line":37,"range":{"start_line":37,"start_character":29,"end_line":37,"end_character":43},"updated":"2016-05-04 01:31:23.000000000","message":"same question","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9592fc71ab22b43efe55bec84d4cc26a82135e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    user \u003d forms.ChoiceField(label\u003d_(\"User\"),"},{"line_number":37,"context_line":"                             required\u003dFalse)"},{"line_number":38,"context_line":"    resource \u003d forms.ChoiceField(label\u003d_(\"Resource\"),"},{"line_number":39,"context_line":"                                 required\u003dFalse)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":42,"context_line":"        super(CreateAlarmInfoAction, self).__init__(request, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_5c709f40","line":39,"range":{"start_line":39,"start_character":33,"end_line":39,"end_character":47},"updated":"2016-05-04 01:31:23.000000000","message":"same question","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9592fc71ab22b43efe55bec84d4cc26a82135e","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            users \u003d api.keystone.user_list(request)"},{"line_number":80,"context_line":"        except Exception:"},{"line_number":81,"context_line":"            msg \u003d _(\u0027Unable to retrieve user list.\u0027)"},{"line_number":82,"context_line":"            LOG.info(msg)"},{"line_number":83,"context_line":"            exceptions.handle(request, msg)"},{"line_number":84,"context_line":"        return users"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_1c9d8757","line":82,"range":{"start_line":82,"start_character":12,"end_line":82,"end_character":25},"updated":"2016-05-04 01:31:23.000000000","message":"A log message should not be marked as translatable in Horizon. In addition, more detail information should be logged.","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8fde5bf76505ee07e71e662aa742bc5729e33a4e","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            users \u003d api.keystone.user_list(request)"},{"line_number":80,"context_line":"        except Exception:"},{"line_number":81,"context_line":"            msg \u003d _(\u0027Unable to retrieve user list.\u0027)"},{"line_number":82,"context_line":"            LOG.info(msg)"},{"line_number":83,"context_line":"            exceptions.handle(request, msg)"},{"line_number":84,"context_line":"        return users"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"dab17558_6417fda3","line":82,"range":{"start_line":82,"start_character":12,"end_line":82,"end_character":25},"in_reply_to":"1a122d0e_185c3718","updated":"2016-05-06 23:52:01.000000000","message":"My suggestion is the third option:\n\n  LOG.info(\u0027Unable to retrieve user list: %s\u0027, e)\n  exceptions.handle(request, _(\u0027Unable to retrieve user list.\u0027)","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":16871,"name":"Sanjana","email":"sanjana@hitachi.co.in","username":"sanjana_93"},"change_message_id":"6c93ea6cb9aacbfe4b5fff14b9b4fbdc1b2c6083","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            users \u003d api.keystone.user_list(request)"},{"line_number":80,"context_line":"        except Exception:"},{"line_number":81,"context_line":"            msg \u003d _(\u0027Unable to retrieve user list.\u0027)"},{"line_number":82,"context_line":"            LOG.info(msg)"},{"line_number":83,"context_line":"            exceptions.handle(request, msg)"},{"line_number":84,"context_line":"        return users"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_185c3718","line":82,"range":{"start_line":82,"start_character":12,"end_line":82,"end_character":25},"in_reply_to":"1a122d0e_1c9d8757","updated":"2016-05-05 05:10:34.000000000","message":"I can think of two approaches. Which would you suggest?\n\nmsg \u003d (\u0027Unable to retrieve user list from keystone api\u0027)\nLOG.info(msg)\n              or\nexcept Exception as e:\n    msg \u003d _(\u0027Unable to retrieve user list %s\u0027) % e\n    LOG.info(msg)","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9592fc71ab22b43efe55bec84d4cc26a82135e","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            projects, has_more \u003d api.keystone.tenant_list(request)"},{"line_number":97,"context_line":"        except Exception:"},{"line_number":98,"context_line":"            msg \u003d _(\u0027Unable to retrieve project list.\u0027)"},{"line_number":99,"context_line":"            LOG.info(msg)"},{"line_number":100,"context_line":"            exceptions.handle(request, msg)"},{"line_number":101,"context_line":"        return projects"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_7cc3db38","line":99,"range":{"start_line":99,"start_character":12,"end_line":99,"end_character":25},"updated":"2016-05-04 01:31:23.000000000","message":"A log message should not be marked as translatable in Horizon. In addition, more detail information should be logged.","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9592fc71ab22b43efe55bec84d4cc26a82135e","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        try:"},{"line_number":113,"context_line":"            alarms \u003d api.ceilometer.alarm_list(self.request)"},{"line_number":114,"context_line":"        except Exception:"},{"line_number":115,"context_line":"            alarms \u003d []"},{"line_number":116,"context_line":"            msg \u003d _(\"Unable to get alarm list\")"},{"line_number":117,"context_line":"            LOG.info(msg)"},{"line_number":118,"context_line":"            exceptions.check_message([\"Connection\", \"refused\"], msg)"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_5cd53fe3","line":115,"range":{"start_line":115,"start_character":12,"end_line":115,"end_character":23},"updated":"2016-05-04 01:31:23.000000000","message":"L.119 raises an exception, so L.115 looks unnecessary.","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9592fc71ab22b43efe55bec84d4cc26a82135e","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        except Exception:"},{"line_number":115,"context_line":"            alarms \u003d []"},{"line_number":116,"context_line":"            msg \u003d _(\"Unable to get alarm list\")"},{"line_number":117,"context_line":"            LOG.info(msg)"},{"line_number":118,"context_line":"            exceptions.check_message([\"Connection\", \"refused\"], msg)"},{"line_number":119,"context_line":"            raise"},{"line_number":120,"context_line":"        if alarms is not None:"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_bcdbb320","line":117,"range":{"start_line":117,"start_character":12,"end_line":117,"end_character":25},"updated":"2016-05-04 01:31:23.000000000","message":"same as the above","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9592fc71ab22b43efe55bec84d4cc26a82135e","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            LOG.info(msg)"},{"line_number":118,"context_line":"            exceptions.check_message([\"Connection\", \"refused\"], msg)"},{"line_number":119,"context_line":"            raise"},{"line_number":120,"context_line":"        if alarms is not None:"},{"line_number":121,"context_line":"            for alarm in alarms:"},{"line_number":122,"context_line":"                if alarm.name \u003d\u003d name:"},{"line_number":123,"context_line":"                    msg \u003d _(\"The name is already used by another alarm.\")"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_bc029370","line":120,"range":{"start_line":120,"start_character":7,"end_line":120,"end_character":30},"updated":"2016-05-04 01:31:23.000000000","message":"Is there a case where alarm_list returns None?","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":16871,"name":"Sanjana","email":"sanjana@hitachi.co.in","username":"sanjana_93"},"change_message_id":"5cb800f5df33c8d3a6e5af61b4016eda993e105c","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            LOG.info(msg)"},{"line_number":118,"context_line":"            exceptions.check_message([\"Connection\", \"refused\"], msg)"},{"line_number":119,"context_line":"            raise"},{"line_number":120,"context_line":"        if alarms is not None:"},{"line_number":121,"context_line":"            for alarm in alarms:"},{"line_number":122,"context_line":"                if alarm.name \u003d\u003d name:"},{"line_number":123,"context_line":"                    msg \u003d _(\"The name is already used by another alarm.\")"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_bf28bb34","line":120,"range":{"start_line":120,"start_character":7,"end_line":120,"end_character":30},"in_reply_to":"1a122d0e_bc029370","updated":"2016-05-04 09:36:13.000000000","message":"I just want to be sure that i am operating on the alarm_list with some items in the list.","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"11468213456dd0cd822a200ab1f8f9ba65db99f7","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            LOG.info(msg)"},{"line_number":118,"context_line":"            exceptions.check_message([\"Connection\", \"refused\"], msg)"},{"line_number":119,"context_line":"            raise"},{"line_number":120,"context_line":"        if alarms is not None:"},{"line_number":121,"context_line":"            for alarm in alarms:"},{"line_number":122,"context_line":"                if alarm.name \u003d\u003d name:"},{"line_number":123,"context_line":"                    msg \u003d _(\"The name is already used by another alarm.\")"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_c6aafe19","line":120,"range":{"start_line":120,"start_character":7,"end_line":120,"end_character":30},"in_reply_to":"1a122d0e_bf28bb34","updated":"2016-05-04 16:28:06.000000000","message":"If alarms is never None and is always a list (including an empty list),\nL.120 is unnecessary and L.121 is enough.","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9592fc71ab22b43efe55bec84d4cc26a82135e","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        if alarms is not None:"},{"line_number":121,"context_line":"            for alarm in alarms:"},{"line_number":122,"context_line":"                if alarm.name \u003d\u003d name:"},{"line_number":123,"context_line":"                    msg \u003d _(\"The name is already used by another alarm.\")"},{"line_number":124,"context_line":"                    self._errors[\u0027name\u0027] \u003d self.error_class([msg])"},{"line_number":125,"context_line":"        return cleaned_data"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_1cf2a79b","line":123,"range":{"start_line":123,"start_character":29,"end_line":123,"end_character":38},"updated":"2016-05-04 01:31:23.000000000","message":"I think it is better to include a name itself:\n\n  The name %s is ....","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9592fc71ab22b43efe55bec84d4cc26a82135e","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            meters \u003d api.ceilometer.meter_list(request)"},{"line_number":180,"context_line":"        except Exception:"},{"line_number":181,"context_line":"            msg \u003d _(\u0027Meter list cannot be retrieved.\u0027)"},{"line_number":182,"context_line":"            LOG.info(msg)"},{"line_number":183,"context_line":"            exceptions.handle(request, msg)"},{"line_number":184,"context_line":"        return meters"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_bc29f3f4","line":182,"range":{"start_line":182,"start_character":12,"end_line":182,"end_character":25},"updated":"2016-05-04 01:31:23.000000000","message":"same as the above","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9592fc71ab22b43efe55bec84d4cc26a82135e","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        try:"},{"line_number":236,"context_line":"            alarms \u003d api.ceilometer.alarm_list(self.request)"},{"line_number":237,"context_line":"            # Avoid comparison of alarm with itself in case of Alarm update"},{"line_number":238,"context_line":"            if alarms is not None:"},{"line_number":239,"context_line":"                for alarm in alarms:"},{"line_number":240,"context_line":"                    if alarm.name \u003d\u003d name and alarm.id !\u003d alarm_id:"},{"line_number":241,"context_line":"                        msg \u003d _(\"The name \u0027%s\u0027 is already used \""}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_1c20e7f7","line":238,"range":{"start_line":238,"start_character":10,"end_line":238,"end_character":34},"updated":"2016-05-04 01:31:23.000000000","message":"Is there a case where alarm_list returns None?","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9592fc71ab22b43efe55bec84d4cc26a82135e","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        except Exception:"},{"line_number":245,"context_line":"            alarms \u003d []"},{"line_number":246,"context_line":"            msg \u003d _(\"Unable to get alarm list\")"},{"line_number":247,"context_line":"            LOG.info(msg)"},{"line_number":248,"context_line":"            exceptions.check_message([\"Connection\", \"refused\"], msg)"},{"line_number":249,"context_line":"            raise"},{"line_number":250,"context_line":"        return self.cleaned_data"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_fc336b60","line":247,"range":{"start_line":247,"start_character":12,"end_line":247,"end_character":25},"updated":"2016-05-04 01:31:23.000000000","message":"same as the above","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9592fc71ab22b43efe55bec84d4cc26a82135e","unresolved":false,"context_lines":[{"line_number":320,"context_line":"            alarm_id \u003d data[\u0027alarm_id\u0027]"},{"line_number":321,"context_line":"            alarm \u003d api.ceilometer.alarm_update("},{"line_number":322,"context_line":"                request,"},{"line_number":323,"context_line":"                alarm_id,"},{"line_number":324,"context_line":"                name\u003ddata[\u0027name\u0027],"},{"line_number":325,"context_line":"                description\u003ddata[\u0027description\u0027],"},{"line_number":326,"context_line":"                project_id\u003ddata[\u0027project\u0027],"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_5c437faf","line":323,"range":{"start_line":323,"start_character":16,"end_line":323,"end_character":24},"updated":"2016-05-04 01:31:23.000000000","message":"-\u003e data[\u0027alarm_id\u0027]","commit_id":"ecca690b65369525a65c8ef3233c36894a2f278c"},{"author":{"_account_id":16871,"name":"Sanjana","email":"sanjana@hitachi.co.in","username":"sanjana_93"},"change_message_id":"bd1ea9d1277f504d29c7ba40b2087ee98e9fa003","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                                  label\u003d_(\"Description\"),"},{"line_number":35,"context_line":"                                  required\u003dFalse)"},{"line_number":36,"context_line":"    project \u003d forms.ChoiceField(label\u003d_(\"Project\"),"},{"line_number":37,"context_line":"                                required\u003dFalse)"},{"line_number":38,"context_line":"    user \u003d forms.ChoiceField(label\u003d_(\"User\"),"},{"line_number":39,"context_line":"                             required\u003dFalse)"},{"line_number":40,"context_line":"    resource \u003d forms.ChoiceField(label\u003d_(\"Resource\"),"}],"source_content_type":"text/x-python","patch_set":17,"id":"dab17558_21547efd","line":37,"updated":"2016-05-10 05:47:42.000000000","message":"The project id is an optional parameter while creating an alarm from the CLI.","commit_id":"29a5ff28507689c46b305fd1dd2b9921b67192a2"}],"openstack_dashboard/test/test_data/ceilometer_data.py":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"1724cbcebfe30982e71bcadc56cfe3e17ecdb7b6","unresolved":false,"context_lines":[{"line_number":283,"context_line":"    TEST.alarms.add(alarm_1)"},{"line_number":284,"context_line":"    TEST.alarms.add(alarm_2)"},{"line_number":285,"context_line":"    TEST.alarms.add(alarm_3)"},{"line_number":286,"context_line":"    TEST.alarms.add(alarm_4)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    # meters"},{"line_number":289,"context_line":"    meter_dict_1 \u003d {\u0027name\u0027: \u0027instance\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_dd9eafb7","line":286,"updated":"2015-12-02 00:36:18.000000000","message":"minor nit: would be nice if update the parent patch with alert_dict_3/4 to keep api+test separate from dashboard implementation","commit_id":"cbb510127684a3724c6a558935ca887dca80e5c3"}]}
