)]}'
{"horizon/static/framework/widgets/table/hz-basic-table.directive.js":[{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"2333b2e44e9daf47e8959bc8dfa61e8af56efb78","unresolved":false,"context_lines":[{"line_number":41,"context_line":"   * @example"},{"line_number":42,"context_line":"   *"},{"line_number":43,"context_line":"   * ```"},{"line_number":44,"context_line":"   * \u003ctable st-table\u003d\u0027displayedCollection\u0027 st-safe-src\u003d\u0027rowCollection\u0027"},{"line_number":45,"context_line":"   *   hz-table default-sort\u003d\"email\"\u003e"},{"line_number":46,"context_line":"   *  \u003cthead\u003e"},{"line_number":47,"context_line":"   *    \u003ctr\u003e"},{"line_number":48,"context_line":"   *      \u003cth\u003e"},{"line_number":49,"context_line":"   *        \u003cinput type\u003d\u0027checkbox\u0027 hz-select-all\u003d\u0027displayedCollection\u0027/\u003e"},{"line_number":50,"context_line":"   *      \u003c/th\u003e"},{"line_number":51,"context_line":"   *      \u003cth\u003eName\u003c/th\u003e"},{"line_number":52,"context_line":"   *    \u003c/tr\u003e"},{"line_number":53,"context_line":"   *  \u003c/thead\u003e"},{"line_number":54,"context_line":"   *  \u003ctbody\u003e"},{"line_number":55,"context_line":"   *    \u003ctr ng-repeat\u003d\"row in displayedCollection\"\u003e"},{"line_number":56,"context_line":"   *      \u003ctd\u003e"},{"line_number":57,"context_line":"   *        \u003cinput type\u003d\u0027checkbox\u0027 hz-select\u003d\u0027row\u0027"},{"line_number":58,"context_line":"   *          ng-model\u003d\u0027selected[row.id].checked\u0027/\u003e"},{"line_number":59,"context_line":"   *      \u003c/td\u003e"},{"line_number":60,"context_line":"   *      \u003ctd\u003eFoo\u003c/td\u003e"},{"line_number":61,"context_line":"   *    \u003c/tr\u003e"},{"line_number":62,"context_line":"   *  \u003c/tbody\u003e"},{"line_number":63,"context_line":"   * \u003c/table\u003e"},{"line_number":64,"context_line":"   * ```"},{"line_number":65,"context_line":"   *"},{"line_number":66,"context_line":"   */"}],"source_content_type":"text/javascript","patch_set":4,"id":"7a5de9d1_d6fcd0b9","line":63,"range":{"start_line":44,"start_character":5,"end_line":63,"end_character":13},"updated":"2016-02-01 18:56:28.000000000","message":"perhaps this example is out of date? The basic-table template defines thead and tbody\n\nOne way I\u0027ve seen this done is to pass the following to the directive:\n* data collection\n* column renderers (directive) which have a header text attribute, a column attribute (to pull from the data) and (optionally) a renderer for that column in case it isn\u0027t just simple text.","commit_id":"0e15216dfd00a7b6122c58c768bd73a83272873b"}],"horizon/static/framework/widgets/table/hz-basic-table.html":[{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"2333b2e44e9daf47e8959bc8dfa61e8af56efb78","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      Table-batch-actions:"},{"line_number":7,"context_line":"      This is where batch actions like searching, creating, and deleting."},{"line_number":8,"context_line":"    --\u003e"},{"line_number":9,"context_line":"    \u003ctr\u003e"},{"line_number":10,"context_line":"      \u003cth colspan\u003d\"100\" class\u003d\"search-header\"\u003e"},{"line_number":11,"context_line":"        \u003chz-search-bar group-classes\u003d\"input-group-sm\" icon-classes\u003d\"fa-search\"\u003e\u003c/hz-search-bar\u003e"},{"line_number":12,"context_line":"      \u003c/th\u003e"},{"line_number":13,"context_line":"    \u003c/tr\u003e"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    \u003c!--"},{"line_number":16,"context_line":"      Table-column-headers:"}],"source_content_type":"text/html","patch_set":4,"id":"7a5de9d1_166d88cb","line":13,"range":{"start_line":9,"start_character":4,"end_line":13,"end_character":9},"updated":"2016-02-01 18:56:28.000000000","message":"Consider isolating the searchbar and batch actions in their own directives, separate from the table. These controls aren\u0027t really table specific, and can instead apply to any collection.","commit_id":"0e15216dfd00a7b6122c58c768bd73a83272873b"}],"horizon/static/framework/widgets/table/hz-cell.directive.js":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"92a5bea73d4463626691777be340b9f913688f8e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"   * Examples of when to use a template include data that needs"},{"line_number":34,"context_line":"   * to be formatted or if you want to include more complex HTML"},{"line_number":35,"context_line":"   * (e.g conditionally show different icons). You should reference"},{"line_number":36,"context_line":"   * the cell\u0027s \u0027item\u0027 attribute if you need access to the cell\u0027s data."},{"line_number":37,"context_line":"   *"},{"line_number":38,"context_line":"   * @restrict A"},{"line_number":39,"context_line":"   * @scope"}],"source_content_type":"text/javascript","patch_set":7,"id":"5a5ae5dd_1e7ae177","line":36,"updated":"2016-02-05 04:51:22.000000000","message":"This needs an actual HTML fragment example please.","commit_id":"6129dfa3b158c24ddb4b7ee759cfbf8e363a9db6"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"854ffab39bc70701189fceac6e7d92f21755eafc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/**"},{"line_number":2,"context_line":" * Copyright 2015 IBM Corp."},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":" * not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/javascript","patch_set":12,"id":"dae33548_83d1115a","line":2,"updated":"2016-02-16 19:11:03.000000000","message":"2016","commit_id":"8a2d03e316c069fe2e0e289befe20f5e2d23258e"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"854ffab39bc70701189fceac6e7d92f21755eafc","unresolved":false,"context_lines":[{"line_number":28,"context_line":"   * @description"},{"line_number":29,"context_line":"   * The `hzCell` directive allows you to customize your cell content."},{"line_number":30,"context_line":"   * When specifying your table header, you may pass in a template into"},{"line_number":31,"context_line":"   * to `template` attribute to use when rendering your cell."},{"line_number":32,"context_line":"   *"},{"line_number":33,"context_line":"   * Examples of when to use a template include data that needs"},{"line_number":34,"context_line":"   * to be formatted or if you want to include more complex HTML"}],"source_content_type":"text/javascript","patch_set":12,"id":"dae33548_283102ed","line":31,"updated":"2016-02-16 19:11:03.000000000","message":"extra \"to\", I think you can end the sentence after \"in a template\" since you already mentioned customizing cell content in the sentence above.","commit_id":"8a2d03e316c069fe2e0e289befe20f5e2d23258e"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"854ffab39bc70701189fceac6e7d92f21755eafc","unresolved":false,"context_lines":[{"line_number":31,"context_line":"   * to `template` attribute to use when rendering your cell."},{"line_number":32,"context_line":"   *"},{"line_number":33,"context_line":"   * Examples of when to use a template include data that needs"},{"line_number":34,"context_line":"   * to be formatted or if you want to include more complex HTML"},{"line_number":35,"context_line":"   * (e.g conditionally show different icons). You should reference"},{"line_number":36,"context_line":"   * the cell\u0027s \u0027item\u0027 attribute if you need access to the cell\u0027s data."},{"line_number":37,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":12,"id":"dae33548_88380ea2","line":34,"updated":"2016-02-16 19:11:03.000000000","message":"Suggestion: \"You should use a template when you want to format data or show more complex content.\"","commit_id":"8a2d03e316c069fe2e0e289befe20f5e2d23258e"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"854ffab39bc70701189fceac6e7d92f21755eafc","unresolved":false,"context_lines":[{"line_number":43,"context_line":"   *   selectAll: true,"},{"line_number":44,"context_line":"   *   expand: true,"},{"line_number":45,"context_line":"   *   columns: ["},{"line_number":46,"context_line":"   *     {name: \u0027a\u0027, title: \u0027A\u0027, cssClasses: \u0027rsp-p1\u0027, sortId: \u0027a\u0027},"},{"line_number":47,"context_line":"   *     {name: \u0027b\u0027, title: \u0027B\u0027, cssClasses: \u0027rsp-p2\u0027, sortId: \u0027b\u0027},"},{"line_number":48,"context_line":"   *     {name: \u0027c\u0027, title: \u0027C\u0027, cssClasses: \u0027rsp-p1\u0027, sortId: \u0027c\u0027, sortDefault: true},"},{"line_number":49,"context_line":"   *     {name: \u0027d\u0027, title: \u0027D\u0027, cssClasses: \u0027rsp-p2\u0027, sortId: \u0027d\u0027,"}],"source_content_type":"text/javascript","patch_set":12,"id":"dae33548_e8f43a88","line":46,"updated":"2016-02-16 19:11:03.000000000","message":"I think name and title are too similar. I always forget which one controls the header and which one controls the data.","commit_id":"8a2d03e316c069fe2e0e289befe20f5e2d23258e"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"854ffab39bc70701189fceac6e7d92f21755eafc","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    function link(scope, element) {"},{"line_number":77,"context_line":"      var html;"},{"line_number":78,"context_line":"      if (scope.$parent.column.template) {"},{"line_number":79,"context_line":"        html \u003d $compile(scope.$parent.column.template)(scope);"},{"line_number":80,"context_line":"      } else {"},{"line_number":81,"context_line":"        html \u003d scope.item[scope.$parent.column.name];"}],"source_content_type":"text/javascript","patch_set":12,"id":"dae33548_03dfc169","line":78,"updated":"2016-02-16 19:11:03.000000000","message":"I\u0027m not a big fan of using scope like this. You are requiring that hz-cell directive have a parent with \u0027column\u0027 in scope. If I named column to something else like \u0027kolum in config.columns\u0027, it would break. To be fair, I understand that you are using a template for the table so this is not really a problem.\n\nI think passing in the column data and isolating the scope might be better. This makes it a bit more re-usable under a different context. I could be over engineering this, so feel free to ignore it.","commit_id":"8a2d03e316c069fe2e0e289befe20f5e2d23258e"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"2fa2709870c4d9f07f5ac5ca2ed58853351d4c2b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"   *     {name: \u0027b\u0027, title: \u0027Header B\u0027, cssClasses: \u0027rsp-p2\u0027, sortId: \u0027b\u0027},"},{"line_number":52,"context_line":"   *     {name: \u0027c\u0027, title: \u0027Header C\u0027, cssClasses: \u0027rsp-p1\u0027, sortId: \u0027c\u0027, sortDefault: true},"},{"line_number":53,"context_line":"   *     {name: \u0027d\u0027, title: \u0027Header D\u0027, cssClasses: \u0027rsp-p2\u0027, sortId: \u0027d\u0027,"},{"line_number":54,"context_line":"   *       template: \u0027\u003cspan class\u003d\"fa fa-bolt\"\u003e{$ item.name $}\u003c/span\u003e\u0027,"},{"line_number":55,"context_line":"   *       filters: [someFilterFunction, \u0027uppercase\u0027]}"},{"line_number":56,"context_line":"   *   ]"},{"line_number":57,"context_line":"   * };"}],"source_content_type":"text/javascript","patch_set":23,"id":"7af24918_7912205a","line":54,"updated":"2016-03-04 22:18:43.000000000","message":"cool, i think i could use custom directives or whatever i want in here then.  Eg. see line 53 here: https://review.openstack.org/#/c/227036/46/openstack_dashboard/dashboards/project/static/dashboard/project/search/table/search-table.html","commit_id":"ea93f4ca6b84d5495f12d28a6fcb76cb16332e87"},{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"7713e9950fd92fc6119fce20d5f7b273461ffe31","unresolved":false,"context_lines":[{"line_number":85,"context_line":"      var column \u003d scope.column;"},{"line_number":86,"context_line":"      var item \u003d scope.item;"},{"line_number":87,"context_line":"      var html;"},{"line_number":88,"context_line":"      // if template provided, render, and place into cell"},{"line_number":89,"context_line":"      if (column \u0026\u0026 column.template) {"},{"line_number":90,"context_line":"        html \u003d $compile(column.template)(scope);"},{"line_number":91,"context_line":"      } else {"}],"source_content_type":"text/javascript","patch_set":28,"id":"da0c15f0_2c600701","line":88,"updated":"2016-03-28 11:42:51.000000000","message":"Am I right that here we applying some custom horizon filters? And if we applied horizon filters, we not applying angular filters on the line 101 below?","commit_id":"1cba2930bbaf3a5dff44e9c8dc327de90dcc0103"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"27efb210a7f55dfa105a696dc5a2fc1c91200d56","unresolved":false,"context_lines":[{"line_number":85,"context_line":"      var column \u003d scope.column;"},{"line_number":86,"context_line":"      var item \u003d scope.item;"},{"line_number":87,"context_line":"      var html;"},{"line_number":88,"context_line":"      // if template provided, render, and place into cell"},{"line_number":89,"context_line":"      if (column \u0026\u0026 column.template) {"},{"line_number":90,"context_line":"        html \u003d $compile(column.template)(scope);"},{"line_number":91,"context_line":"      } else {"}],"source_content_type":"text/javascript","patch_set":28,"id":"ba0121b8_b681a8fd","line":88,"in_reply_to":"da0c15f0_2c600701","updated":"2016-03-31 16:56:45.000000000","message":"Yeah, we seem to have the ability to pass in filters either directly or by name; it doesn\u0027t matter if they\u0027re custom or not, it frankly is doing exactly the same thing: either the configuration uses the name of the filter to load it, or it gets the filter through injection, which is done by referencing the name.\n\nI\u0027m not so hot on loading the filter by name in this case, but I\u0027m not going to -1 this patch for it.","commit_id":"1cba2930bbaf3a5dff44e9c8dc327de90dcc0103"}],"horizon/static/framework/widgets/table/hz-detail-row.directive.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"7e6b72b79b6043ab06772df0274e8daaff578e9e","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  function hzDetailRow(basePath) {"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    var directive \u003d {"},{"line_number":60,"context_line":"      restrict: \u0027E\u0027,"},{"line_number":61,"context_line":"      scope: {"},{"line_number":62,"context_line":"        columns: \u0027\u003d\u0027,"},{"line_number":63,"context_line":"        item: \u0027\u003d\u0027,"}],"source_content_type":"text/javascript","patch_set":16,"id":"bae84128_c74a5e55","line":60,"updated":"2016-02-25 00:57:31.000000000","message":"transclude: true","commit_id":"56c0fc98540efc0c9326226cc9d1c6393afae160"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"7e6b72b79b6043ab06772df0274e8daaff578e9e","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    return directive;"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    function templateUrl(element, attrs) {"},{"line_number":72,"context_line":"      return attrs.templateUrl || basePath + \u0027table/hz-detail-row.html\u0027;"},{"line_number":73,"context_line":"    }"},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":"})();"}],"source_content_type":"text/javascript","patch_set":16,"id":"bae84128_67ab92d7","line":72,"updated":"2016-02-25 00:57:31.000000000","message":"if (element.hasChild){   \n    transclude(scope, function(clone) {\n      // append and compile clone\n    });\n}","commit_id":"56c0fc98540efc0c9326226cc9d1c6393afae160"}],"horizon/static/framework/widgets/table/hz-dynamic-table.directive.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"854ffab39bc70701189fceac6e7d92f21755eafc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" *"},{"line_number":3,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":" * you may not use this file except in compliance with the License."},{"line_number":5,"context_line":" * You may obtain a copy of the License at"}],"source_content_type":"text/javascript","patch_set":12,"id":"dae33548_43e9c913","line":2,"updated":"2016-02-16 19:11:03.000000000","message":"IBM license?","commit_id":"8a2d03e316c069fe2e0e289befe20f5e2d23258e"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"854ffab39bc70701189fceac6e7d92f21755eafc","unresolved":false,"context_lines":[{"line_number":35,"context_line":"   * You will need to pass in three attributes: `config`, `items`, and `safe-items`."},{"line_number":36,"context_line":"   *"},{"line_number":37,"context_line":"   * This directive is built off the Smart-table module, so `items` and `safe-items`"},{"line_number":38,"context_line":"   * are passed into `st-table` attribute for the displayed row collection and `st-safe-src`"},{"line_number":39,"context_line":"   * attribute for the safe row collection, respectively."},{"line_number":40,"context_line":"   * Note: \u0027name\u0027 is the key used to retrieve cell data from \u0027displayedCollection\u0027"},{"line_number":41,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":12,"id":"dae33548_a313750c","line":38,"updated":"2016-02-16 19:11:03.000000000","message":"We should stick with the same attribute names so it is less confusing down the road. items-\u003esafe-items and safe-items-\u003est-safe-src. Otherwise, I will have to look this up whenever I forget, which is a hassle.","commit_id":"8a2d03e316c069fe2e0e289befe20f5e2d23258e"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"561bcd22765f26093d074f40ba6b36094214957f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"   *     {name: \u0027a\u0027, title: \u0027A\u0027, cssClasses: \u0027rsp-p1\u0027, sortId: \u0027a\u0027},"},{"line_number":50,"context_line":"   *     {name: \u0027b\u0027, title: \u0027B\u0027, cssClasses: \u0027rsp-p2\u0027, sortId: \u0027b\u0027},"},{"line_number":51,"context_line":"   *     {name: \u0027c\u0027, title: \u0027C\u0027, cssClasses: \u0027rsp-p1\u0027, sortId: \u0027c\u0027, sortDefault: true},"},{"line_number":52,"context_line":"   *     {name: \u0027d\u0027, title: \u0027D\u0027, cssClasses: \u0027rsp-p2\u0027, sortId: \u0027d\u0027}"},{"line_number":53,"context_line":"   *   ]"},{"line_number":54,"context_line":"   * };"},{"line_number":55,"context_line":"   * ```"}],"source_content_type":"text/javascript","patch_set":12,"id":"dae33548_30eac4ac","line":52,"updated":"2016-02-17 20:29:41.000000000","message":"Actions?\n\nI\u0027d like to integrate actions in this with the registry.  Where you can just specify the resource type (OS::Glance::Image) and get the actions for that resource type.","commit_id":"8a2d03e316c069fe2e0e289befe20f5e2d23258e"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"854ffab39bc70701189fceac6e7d92f21755eafc","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        items: \u0027\u003d\u0027,"},{"line_number":71,"context_line":"        safeItems: \u0027\u003d\u0027"},{"line_number":72,"context_line":"      },"},{"line_number":73,"context_line":"      templateUrl: basePath + \u0027table/hz-dynamic-table.html\u0027"},{"line_number":74,"context_line":"    };"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    return directive;"}],"source_content_type":"text/javascript","patch_set":12,"id":"dae33548_e3de1c6c","line":73,"updated":"2016-02-16 19:11:03.000000000","message":"Again, might be over engineering. Here is a possible future scenario. Magic-search is coming, so you might need to have more than one template.","commit_id":"8a2d03e316c069fe2e0e289befe20f5e2d23258e"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"617244955b510bfc4e06ece1141bfd947c5f6c48","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        items: \u0027\u003d\u0027,"},{"line_number":87,"context_line":"        safeSrcItems: \u0027\u003d\u0027,"},{"line_number":88,"context_line":"        table: \u0027\u003d\u0027,"},{"line_number":89,"context_line":"        searchFacets: \"\u003d\","},{"line_number":90,"context_line":"        batchActions: \u0027\u003d?\u0027,"},{"line_number":91,"context_line":"        itemActions: \u0027\u003d?\u0027"},{"line_number":92,"context_line":"      },"}],"source_content_type":"text/javascript","patch_set":25,"id":"fa0719c6_3136db03","line":89,"updated":"2016-03-21 16:39:33.000000000","message":"I\u0027d assume a resultHandler would be one of the parameters here.","commit_id":"ca446fa709db8753a608b4ab30eff17ca35ab980"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"05cec4a1ffffcab9f388c88a1467cbfa1a6f5502","unresolved":false,"context_lines":[{"line_number":84,"context_line":"      scope: {"},{"line_number":85,"context_line":"        config: \u0027\u003d\u0027,"},{"line_number":86,"context_line":"        items: \u0027\u003d\u0027,"},{"line_number":87,"context_line":"        safeSrcItems: \u0027\u003d\u0027,"},{"line_number":88,"context_line":"        table: \u0027\u003d\u0027,"},{"line_number":89,"context_line":"        itemActions: \u0027\u003d?\u0027,"},{"line_number":90,"context_line":"        resultHandler: \u0027\u003d?\u0027"}],"source_content_type":"text/javascript","patch_set":30,"id":"5a18252c_be48b488","line":87,"updated":"2016-04-13 16:39:41.000000000","message":"I wonder if it\u0027s possible to store something like \n\n  angular.copy(items) \n\nin directive\u0027s link function and pass it as safe-src-items into scope (or vice versa, as items)? That would be really nice.","commit_id":"a22c5e907c2e62ef5456a9ff9f73d17ab8f7f26c"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"a2df786ebf0f42642ae1ebeb43dca98246c0450c","unresolved":false,"context_lines":[{"line_number":84,"context_line":"      scope: {"},{"line_number":85,"context_line":"        config: \u0027\u003d\u0027,"},{"line_number":86,"context_line":"        items: \u0027\u003d\u0027,"},{"line_number":87,"context_line":"        safeSrcItems: \u0027\u003d\u0027,"},{"line_number":88,"context_line":"        table: \u0027\u003d\u0027,"},{"line_number":89,"context_line":"        itemActions: \u0027\u003d?\u0027,"},{"line_number":90,"context_line":"        resultHandler: \u0027\u003d?\u0027"}],"source_content_type":"text/javascript","patch_set":31,"id":"1a122d0e_9a0bd27c","line":87,"updated":"2016-04-20 19:30:11.000000000","message":"A slightly even better improvement would be to only have items attribute. Then the directive can generate items and safe-src-items to embed into smart table. It is less confusing for newbies to use. From my understanding, items can be blank and safe-src-items is the source array. Smart table is smart enough to fill in items all on its own","commit_id":"8ace45cd3d838e68398aca6e2033ce82b25d6482"}],"horizon/static/framework/widgets/table/hz-dynamic-table.html":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"854ffab39bc70701189fceac6e7d92f21755eafc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003c!--"},{"line_number":2,"context_line":"  Basic table template"},{"line_number":3,"context_line":"--\u003e"},{"line_number":4,"context_line":"\u003ctable"},{"line_number":5,"context_line":"  hz-table ng-cloak"}],"source_content_type":"text/html","patch_set":12,"id":"dae33548_e378dd2d","line":2,"updated":"2016-02-16 19:11:03.000000000","message":"Dynamic table template?","commit_id":"8a2d03e316c069fe2e0e289befe20f5e2d23258e"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"854ffab39bc70701189fceac6e7d92f21755eafc","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  hz-table ng-cloak"},{"line_number":6,"context_line":"  st-table\u003d\"items\""},{"line_number":7,"context_line":"  st-safe-src\u003d\"safeItems\""},{"line_number":8,"context_line":"  default-sort\u003d\"name\""},{"line_number":9,"context_line":"  default-sort-reverse\u003d\"true\""},{"line_number":10,"context_line":"  class\u003d\"table-striped table-rsp table-detail modern\"\u003e"},{"line_number":11,"context_line":"  \u003cthead\u003e"}],"source_content_type":"text/html","patch_set":12,"id":"dae33548_830d9039","line":8,"updated":"2016-02-16 19:11:03.000000000","message":"Seems like a hardcoded \"name\" value here. This comes from \"user.name\" .","commit_id":"8a2d03e316c069fe2e0e289befe20f5e2d23258e"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"854ffab39bc70701189fceac6e7d92f21755eafc","unresolved":false,"context_lines":[{"line_number":20,"context_line":"      Set expand to True if you want to inline details."},{"line_number":21,"context_line":"    --\u003e"},{"line_number":22,"context_line":"    \u003ctr\u003e"},{"line_number":23,"context_line":"      \u003cth ng-show\u003d\"config.selectAll\" class\u003d\"select-col\"\u003e"},{"line_number":24,"context_line":"        \u003cinput type\u003d\"checkbox\" hz-select-all\u003d\"items\"\u003e"},{"line_number":25,"context_line":"      \u003c/th\u003e"},{"line_number":26,"context_line":"      \u003cth ng-show\u003d\"config.expand\" class\u003d\"expander\"\u003e\u003c/th\u003e"}],"source_content_type":"text/html","patch_set":12,"id":"dae33548_635face5","line":23,"updated":"2016-02-16 19:11:03.000000000","message":"nit, can be addressed in a later patch. select-all and expand could be enabled by default, unless user want to disable it. This way, we have less params to pass in.","commit_id":"8a2d03e316c069fe2e0e289befe20f5e2d23258e"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"561bcd22765f26093d074f40ba6b36094214957f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"              \u003cdd translate\u003e{$ item[column.name] $}\u003c/dd\u003e"},{"line_number":75,"context_line":"            \u003c/dl\u003e"},{"line_number":76,"context_line":"          \u003c/span\u003e"},{"line_number":77,"context_line":"        \u003c/div\u003e"},{"line_number":78,"context_line":"      \u003c/td\u003e"},{"line_number":79,"context_line":"    \u003c/tr\u003e"},{"line_number":80,"context_line":"    \u003ctr hz-no-items items\u003d\"items\"\u003e\u003c/tr\u003e"}],"source_content_type":"text/html","patch_set":12,"id":"dae33548_f00b3cd4","line":77,"updated":"2016-02-17 20:29:41.000000000","message":"I think details needs to be a template with a default template. How can I do thing things like we do on ng-images detail?","commit_id":"8a2d03e316c069fe2e0e289befe20f5e2d23258e"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"2fa2709870c4d9f07f5ac5ca2ed58853351d4c2b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"      Batch actions - searching, creating, and deleting."},{"line_number":15,"context_line":"    --\u003e"},{"line_number":16,"context_line":"    \u003ctr\u003e"},{"line_number":17,"context_line":"      \u003cth colspan\u003d\"100\" class\u003d\"search-header\"\u003e"},{"line_number":18,"context_line":"        \u003chz-search-bar group-classes\u003d\"input-group\" icon-classes\u003d\"fa-search\"\u003e"},{"line_number":19,"context_line":"          \u003cactions ng-if\u003d\"batchActions\" allowed\u003d\"batchActions\" type\u003d\"batch\"\u003e\u003c/actions\u003e"},{"line_number":20,"context_line":"        \u003c/hz-search-bar\u003e"}],"source_content_type":"text/html","patch_set":23,"id":"7af24918_1e59428f","line":17,"updated":"2016-03-04 22:18:43.000000000","message":"We need to include the ability to use and set magic search options.\n\ne.g.:\n\nFor searchlight and ng images table i have to do the following:\n\n    \u003cth colspan\u003d\"100\" class\u003d\"search-header\"\u003e\n      \u003chz-magic-search-bar\n        filter-facets\u003d\"table.searchFacets\"\n        client-full-text-search\u003d\"false\"\n        search-settings-callback\u003d\"table.searchSettings.open\"\u003e\n      \u003c/hz-magic-search-bar\u003e\n    \u003c/th\u003e","commit_id":"ea93f4ca6b84d5495f12d28a6fcb76cb16332e87"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"2fa2709870c4d9f07f5ac5ca2ed58853351d4c2b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      \u003ctd ng-show\u003d\"config.expand\" class\u003d\"expander\"\u003e"},{"line_number":55,"context_line":"        \u003cspan class\u003d\"fa fa-chevron-right\" hz-expand-detail duration\u003d\"200\"\u003e\u003c/span\u003e"},{"line_number":56,"context_line":"      \u003c/td\u003e"},{"line_number":57,"context_line":"      \u003ctd ng-repeat\u003d\"column in config.columns\""},{"line_number":58,"context_line":"        class\u003d\"{$ column.classes $}\"\u003e"},{"line_number":59,"context_line":"        \u003chz-cell column\u003d\"column\" item\u003d\"item\" options\u003d\"options\"\u003e\u003c/hz-cell\u003e"},{"line_number":60,"context_line":"      \u003c/td\u003e"}],"source_content_type":"text/html","patch_set":23,"id":"7af24918_9e9272f5","line":57,"updated":"2016-03-04 22:18:43.000000000","message":"can we support policy on TH and TDs?  use the policy directive.  hz-if-policy?\n\nThis would make it so that potentially the same column config can used for admin or project level tables.\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/cloud-services/hz-if-policies.directive.js#L53","commit_id":"ea93f4ca6b84d5495f12d28a6fcb76cb16332e87"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"98776029926a9c057cfb89906c673033ddbfaa64","unresolved":false,"context_lines":[{"line_number":63,"context_line":"          Table-row-action-column:"},{"line_number":64,"context_line":"          Actions taken here apply to a single item/row."},{"line_number":65,"context_line":"        --\u003e"},{"line_number":66,"context_line":"        \u003cactions ng-if\u003d\"itemActions\" allowed\u003d\"itemActions\" type\u003d\"row\" item\u003d\"item\"\u003e\u003c/actions\u003e"},{"line_number":67,"context_line":"      \u003c/td\u003e"},{"line_number":68,"context_line":"    \u003c/tr\u003e"},{"line_number":69,"context_line":""}],"source_content_type":"text/html","patch_set":23,"id":"1af94dfe_32713a77","line":66,"updated":"2016-03-17 20:19:32.000000000","message":"actions are missing the new callback feature.\n\nhttps://review.openstack.org/#/c/290800/4/horizon/static/framework/widgets/action-list/actions.directive.js","commit_id":"ea93f4ca6b84d5495f12d28a6fcb76cb16332e87"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"2819854987c60303bb37abb06368e5f99a90a3b1","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    \u003ctr ng-if\u003d\"config.expand\" ng-repeat-end class\u003d\"detail-row\"\u003e"},{"line_number":77,"context_line":"      \u003ctd class\u003d\"detail\" colspan\u003d\"100\"\u003e"},{"line_number":78,"context_line":"        \u003chz-detail-row"},{"line_number":79,"context_line":"          template-url\u003d\"config.detailsRoute\""},{"line_number":80,"context_line":"          columns\u003d\"config.columns\""},{"line_number":81,"context_line":"          item\u003d\"item\""},{"line_number":82,"context_line":"          options\u003d\"options\"\u003e"}],"source_content_type":"text/html","patch_set":23,"id":"5aef4532_4f6acf81","line":79,"range":{"start_line":79,"start_character":31,"end_line":79,"end_character":43},"updated":"2016-03-07 22:05:47.000000000","message":"This is not a route, this is a template url.","commit_id":"ea93f4ca6b84d5495f12d28a6fcb76cb16332e87"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"617244955b510bfc4e06ece1141bfd947c5f6c48","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        \u003chz-search-bar ng-show\u003d\"!searchFacets\""},{"line_number":19,"context_line":"          group-classes\u003d\"input-group\""},{"line_number":20,"context_line":"          icon-classes\u003d\"fa-search\"\u003e"},{"line_number":21,"context_line":"          \u003cactions ng-if\u003d\"batchActions\" allowed\u003d\"batchActions\" type\u003d\"batch\" result-handler\u003d\"onResult\"\u003e\u003c/actions\u003e"},{"line_number":22,"context_line":"        \u003c/hz-search-bar\u003e"},{"line_number":23,"context_line":"      \u003c/th\u003e"},{"line_number":24,"context_line":"    \u003c/tr\u003e"}],"source_content_type":"text/html","patch_set":25,"id":"fa0719c6_715fb372","line":21,"range":{"start_line":21,"start_character":92,"end_line":21,"end_character":100},"updated":"2016-03-21 16:39:33.000000000","message":"Is this something that\u0027s just expected to lie on scope?  Let me know if I missed something, but I\u0027d prefer that this comes from the directive itself as a parameter.  Did I miss it?","commit_id":"ca446fa709db8753a608b4ab30eff17ca35ab980"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"617244955b510bfc4e06ece1141bfd947c5f6c48","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      \u003c/th\u003e"},{"line_number":34,"context_line":"      \u003cth ng-show\u003d\"config.expand\" class\u003d\"expander\"\u003e\u003c/th\u003e"},{"line_number":35,"context_line":"      \u003cth ng-repeat\u003d\"column in config.columns\""},{"line_number":36,"context_line":"        class\u003d\"rsp-p{$ column.priority $}\""},{"line_number":37,"context_line":"        st-sort\u003d\"{$ column.id $}\""},{"line_number":38,"context_line":"        ng-attr-st-sort-default\u003d\"{$ column.sortDefault $}\""},{"line_number":39,"context_line":"        translate\u003e"}],"source_content_type":"text/html","patch_set":25,"id":"fa0719c6_31a6dbc1","line":36,"range":{"start_line":36,"start_character":30,"end_line":36,"end_character":38},"updated":"2016-03-21 16:39:33.000000000","message":"Nice.","commit_id":"ca446fa709db8753a608b4ab30eff17ca35ab980"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"617244955b510bfc4e06ece1141bfd947c5f6c48","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    --\u003e"},{"line_number":83,"context_line":"    \u003ctr ng-if\u003d\"config.expand\" ng-repeat-end class\u003d\"detail-row\"\u003e"},{"line_number":84,"context_line":"      \u003ctd class\u003d\"detail\" colspan\u003d\"100\"\u003e"},{"line_number":85,"context_line":"        \u003chz-detail-row template-url\u003d\"config.detailsTemplateUrl\"\u003e"},{"line_number":86,"context_line":"        \u003c/hz-detail-row\u003e"},{"line_number":87,"context_line":"      \u003c/td\u003e"},{"line_number":88,"context_line":"    \u003c/tr\u003e"}],"source_content_type":"text/html","patch_set":25,"id":"fa0719c6_5188af22","line":85,"range":{"start_line":85,"start_character":51,"end_line":85,"end_character":62},"updated":"2016-03-21 16:39:33.000000000","message":"that makes more intuitive sense.","commit_id":"ca446fa709db8753a608b4ab30eff17ca35ab980"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"08ea59bf46e0fcdfb56f64501d1123bda3d7534b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"          Table-row-action-column:"},{"line_number":71,"context_line":"          Actions taken here apply to a single item/row."},{"line_number":72,"context_line":"        --\u003e"},{"line_number":73,"context_line":"        \u003cactions ng-if\u003d\"itemActions\" allowed\u003d\"itemActions\" type\u003d\"row\" item\u003d\"item\" result-handler\u003d\"onResult\"\u003e\u003c/actions\u003e"},{"line_number":74,"context_line":"      \u003c/td\u003e"},{"line_number":75,"context_line":"    \u003c/tr\u003e"},{"line_number":76,"context_line":""}],"source_content_type":"text/html","patch_set":27,"id":"fa0719c6_4d80a7c0","line":73,"range":{"start_line":73,"start_character":98,"end_line":73,"end_character":106},"updated":"2016-03-23 13:05:46.000000000","message":"-1 This should be \"resultHandler\".","commit_id":"2d26f2d7eda3dd5a8f45614fdc04a69cd0f23b4c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"349726c1ef4c9546098e68d71644afb0d96be91d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      Table-batch-actions:"},{"line_number":14,"context_line":"      Batch actions - searching, creating, and deleting."},{"line_number":15,"context_line":"    --\u003e"},{"line_number":16,"context_line":"    \u003ctr\u003e"},{"line_number":17,"context_line":"      \u003cth colspan\u003d\"100\" class\u003d\"search-header\"\u003e"},{"line_number":18,"context_line":"        \u003chz-search-bar group-classes\u003d\"input-group\""},{"line_number":19,"context_line":"          icon-classes\u003d\"fa-search\"\u003e"},{"line_number":20,"context_line":"          \u003cactions ng-if\u003d\"batchActions\" allowed\u003d\"batchActions\" type\u003d\"batch\" result-handler\u003d\"resultHandler\"\u003e\u003c/actions\u003e"},{"line_number":21,"context_line":"        \u003c/hz-search-bar\u003e"},{"line_number":22,"context_line":"      \u003c/th\u003e"},{"line_number":23,"context_line":"    \u003c/tr\u003e"},{"line_number":24,"context_line":"    \u003c!--"},{"line_number":25,"context_line":"      Table-column-headers:"},{"line_number":26,"context_line":"      Set selectAll to True if you want to enable select all checkbox."}],"source_content_type":"text/html","patch_set":28,"id":"da0c15f0_5eec40c7","line":23,"range":{"start_line":16,"start_character":0,"end_line":23,"end_character":9},"updated":"2016-03-25 13:23:03.000000000","message":"I know we\u0027re trying to move search bars *out* of these tables; perhaps we need to use a method similar to st-magic-search to do so?","commit_id":"1cba2930bbaf3a5dff44e9c8dc327de90dcc0103"}],"horizon/static/framework/widgets/table/hz-table.directive.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"8e389dbb5c024daed88a88176cae8b424cc937a5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"   * @scope true"},{"line_number":43,"context_line":"   * @example"},{"line_number":44,"context_line":"   *"},{"line_number":45,"context_line":"   * You may either create your own HTML for the table (1) or pass in the"},{"line_number":46,"context_line":"   * table content and let the directive generate all the content for you dynamically (2)."},{"line_number":47,"context_line":"   * If you choose to use the latter, in addition to the necessary attributes"},{"line_number":48,"context_line":"   * listed above, please pass in `header` and `items` attribute.  See example"}],"source_content_type":"text/javascript","patch_set":5,"id":"5a5ae5dd_2ec12b2f","line":45,"updated":"2016-02-03 01:10:45.000000000","message":"The numeric bullets should be indented for readability.\n1) Manually create the table via HTML\nBrief explanation why you might want to do this.\n... example code....\n\n\n2) Use this directive to generate the HTML\nThe necessary attributes are ....\n... example code....","commit_id":"b6e6e222b6a0c9fdc22feeecb0e2fcf21bc66bb2"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"8e389dbb5c024daed88a88176cae8b424cc937a5","unresolved":false,"context_lines":[{"line_number":72,"context_line":"   * \u003c/table\u003e"},{"line_number":73,"context_line":"   * ```"},{"line_number":74,"context_line":"   *"},{"line_number":75,"context_line":"   * (2) Programatically. Note: \u0027name\u0027 is the key used to retrieve cell data from"},{"line_number":76,"context_line":"   * \u0027displayedCollection\u0027"},{"line_number":77,"context_line":"   *"},{"line_number":78,"context_line":"   * var header \u003d {"}],"source_content_type":"text/javascript","patch_set":5,"id":"5a5ae5dd_0e20eff6","line":75,"updated":"2016-02-03 01:10:45.000000000","message":"I think name-\u003efield and title-\u003ename. field as in data field and name as in column names.","commit_id":"b6e6e222b6a0c9fdc22feeecb0e2fcf21bc66bb2"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"8e389dbb5c024daed88a88176cae8b424cc937a5","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        stTableCtrl.sortBy(attrs.defaultSort, reverse);"},{"line_number":134,"context_line":"      }"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"      // if items and header attribute are defined, we are generating the HTML markup"},{"line_number":137,"context_line":"      if (attrs.items \u0026\u0026 attrs.header) {"},{"line_number":138,"context_line":"        scope.$watch(attrs.items, function() {"},{"line_number":139,"context_line":"          if (scope.$eval(attrs.items).length \u003e 1) {"}],"source_content_type":"text/javascript","patch_set":5,"id":"5a5ae5dd_6e22c3bb","line":136,"updated":"2016-02-03 01:10:45.000000000","message":"There should be an option to turn off checkboxes and expander if the need for it is not there.","commit_id":"b6e6e222b6a0c9fdc22feeecb0e2fcf21bc66bb2"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"92a5bea73d4463626691777be340b9f913688f8e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"   * @description"},{"line_number":27,"context_line":"   * The `hzTable` directive extends the Smart-Table module to provide"},{"line_number":28,"context_line":"   * support for saving the checkbox selection state of each row in the"},{"line_number":29,"context_line":"   * table. A default sort key can be specified to sort the table"},{"line_number":30,"context_line":"   * initially by this key. To reverse, add default-sort-reverse\u003d\u0027true\u0027"},{"line_number":31,"context_line":"   * as well."},{"line_number":32,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":7,"id":"5a5ae5dd_9eb7b139","side":"PARENT","line":29,"updated":"2016-02-05 04:51:22.000000000","message":"This description is missing a lot of the capabilities provided.","commit_id":"555865065a8992ee33a48134660c738b37d02e64"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"92a5bea73d4463626691777be340b9f913688f8e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"   *    \u003ctr ng-repeat\u003d\"row in displayedCollection\"\u003e"},{"line_number":54,"context_line":"   *      \u003ctd\u003e"},{"line_number":55,"context_line":"   *        \u003cinput type\u003d\u0027checkbox\u0027 hz-select\u003d\u0027row\u0027"},{"line_number":56,"context_line":"   *          ng-model\u003d\u0027selected[row.id].checked\u0027/\u003e"},{"line_number":57,"context_line":"   *      \u003c/td\u003e"},{"line_number":58,"context_line":"   *      \u003ctd\u003eFoo\u003c/td\u003e"},{"line_number":59,"context_line":"   *    \u003c/tr\u003e"}],"source_content_type":"text/javascript","patch_set":7,"id":"5a5ae5dd_24422c69","side":"PARENT","line":56,"updated":"2016-02-05 04:51:22.000000000","message":"This is incorrect - the ng-model attribute shouldn\u0027t be here.","commit_id":"555865065a8992ee33a48134660c738b37d02e64"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"fe2c21a83ea7bcc6bfcb9b58c181b5ccfe58ece2","unresolved":false,"context_lines":[{"line_number":53,"context_line":"   *    \u003ctr ng-repeat\u003d\"row in displayedCollection\"\u003e"},{"line_number":54,"context_line":"   *      \u003ctd\u003e"},{"line_number":55,"context_line":"   *        \u003cinput type\u003d\u0027checkbox\u0027 hz-select\u003d\u0027row\u0027"},{"line_number":56,"context_line":"   *          ng-model\u003d\u0027selected[row.id].checked\u0027/\u003e"},{"line_number":57,"context_line":"   *      \u003c/td\u003e"},{"line_number":58,"context_line":"   *      \u003ctd\u003eFoo\u003c/td\u003e"},{"line_number":59,"context_line":"   *    \u003c/tr\u003e"}],"source_content_type":"text/javascript","patch_set":7,"id":"5a5ae5dd_2ff1a501","side":"PARENT","line":56,"in_reply_to":"5a5ae5dd_24422c69","updated":"2016-02-05 05:05:49.000000000","message":"OK, you can ignore this, it was a red herring.","commit_id":"555865065a8992ee33a48134660c738b37d02e64"}],"horizon/static/framework/widgets/table/table.controller.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"854ffab39bc70701189fceac6e7d92f21755eafc","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    /*eslint-disable angular/controller-as */"},{"line_number":34,"context_line":"    $scope.selected \u003d {};"},{"line_number":35,"context_line":"    $scope.numSelected \u003d 0;"},{"line_number":36,"context_line":"    // filter to check if responsive column is classified as rsp-p2"},{"line_number":37,"context_line":"    // if it is, include it in the detail row expander"},{"line_number":38,"context_line":"    $scope.isP2 \u003d function(column) {"},{"line_number":39,"context_line":"      return column.classes.indexOf(\u0027rsp-p2\u0027) \u003e -1;"}],"source_content_type":"text/javascript","patch_set":12,"id":"dae33548_63196c88","line":36,"updated":"2016-02-16 19:11:03.000000000","message":"I don\u0027t think this is the right place for it. We\u0027re mixing presentation with data here. Seems more appropriate to put it in the directive instead.","commit_id":"8a2d03e316c069fe2e0e289befe20f5e2d23258e"}],"openstack_dashboard/dashboards/identity/static/dashboard/identity/users/table/table.controller.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"2a16c4e37d6c12a72800abab9ae8535359b2c873","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    ctrl.iusers \u003d [];"},{"line_number":46,"context_line":"    ctrl.userSession \u003d {};"},{"line_number":47,"context_line":"    ctrl.checked \u003d {};"},{"line_number":48,"context_line":"    ctrl.config \u003d {"},{"line_number":49,"context_line":"      selectAll: true,"},{"line_number":50,"context_line":"      expand: false,"},{"line_number":51,"context_line":"      columns: ["}],"source_content_type":"text/javascript","patch_set":6,"id":"5a5ae5dd_a082d550","line":48,"updated":"2016-02-03 21:07:37.000000000","message":"Should probably move this to a service horizon.dashboard.identity.users.tableConfigService so that others can extend it (similar to workflow).","commit_id":"af58dd7ad2821b8afe982b4e6a558d2c0aa2b365"}]}
