)]}'
{"horizon/forms/fields.py":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"1df7b0e893761616c315f5cb6a36229bdf97f028","unresolved":false,"context_lines":[{"line_number":272,"context_line":"            \u0027\u003cdiv class\u003d\"fancy-checkbox\"\u003e{}\u003clabel for\u003d\"{}\"\u003e\u003c/label\u003e\u003c/div\u003e\u0027,"},{"line_number":273,"context_line":"            super(FancyCheckboxInput, self).render(name, value, attrs),"},{"line_number":274,"context_line":"            label_for"},{"line_number":275,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_f6c82857","line":275,"updated":"2015-12-03 03:09:14.000000000","message":"The tests are failing because you\u0027re trying to format a unicode string into a byte string, and since Python has no idea what encoding the byte string is, it guesses ASCII, so you get an ASCII encoding error on the high-bit character u\u0027\\u6346\u0027.\n\nYou need to instead to use a unicode format string in the above:\n\n  u\u0027\u003cdiv class\u003d\"fancy-checkbox\"\u003e{}\u003clabel for\u003d\"{}\"\u003e\u003c/label\u003e\u003c/div\u003e\u0027","commit_id":"64b7439a830e139de3c8bb9e8356dd96fa5af536"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"5d114d91556bff71545ef92468597c1065ba3547","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    def render(self, name, value, attrs\u003dNone):"},{"line_number":264,"context_line":"        label_for \u003d attrs.get(\u0027id\u0027, \u0027\u0027)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        if not label_for or label_for \u003d\u003d \u0027\u0027:"},{"line_number":267,"context_line":"            attrs[\u0027id\u0027] \u003d uuid.uuid4()"},{"line_number":268,"context_line":"            label_for \u003d attrs[\u0027id\u0027]"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"7a5de9d1_8872857b","line":266,"updated":"2016-01-27 20:37:48.000000000","message":"`not label_for`\n\nalso catches the case of `label_for \u003d\u003d \u0027\u0027`","commit_id":"1d43bba5418d431e9c6d3c5a18d1d15e24910cb8"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"54f7760539ccec2b293b7e0b8d097c75febcad35","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    def render(self, name, value, attrs\u003dNone):"},{"line_number":264,"context_line":"        label_for \u003d attrs.get(\u0027id\u0027, \u0027\u0027)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        if not label_for or label_for \u003d\u003d \u0027\u0027:"},{"line_number":267,"context_line":"            attrs[\u0027id\u0027] \u003d uuid.uuid4()"},{"line_number":268,"context_line":"            label_for \u003d attrs[\u0027id\u0027]"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"7a5de9d1_8083e055","line":266,"in_reply_to":"7a5de9d1_8872857b","updated":"2016-01-29 03:11:42.000000000","message":"Done","commit_id":"1d43bba5418d431e9c6d3c5a18d1d15e24910cb8"}],"horizon/static/horizon/js/horizon.tables.js":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"8b076dd6ff98a1f62d54a5a205494d55fbf44db9","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"            // Only replace row if the html content has changed"},{"line_number":91,"context_line":"            if($new_row.html() !\u003d\u003d $row.html()) {"},{"line_number":92,"context_line":"              if($row.find(\u0027.table-row-multi-select\u0027)[0].checked) {"},{"line_number":93,"context_line":"                // Preserve the checkbox if it\u0027s already clicked"},{"line_number":94,"context_line":"                $new_row.find(\u0027.table-row-multi-select\u0027).prop(\u0027checked\u0027, true);"},{"line_number":95,"context_line":"              }"}],"source_content_type":"text/javascript","patch_set":20,"id":"5a5ae5dd_100b4e7e","line":92,"updated":"2016-02-08 14:50:32.000000000","message":"That may be a purely stylistic comment, but nevertheless... Why not use here\n\n  $row.find(\u0027.table-row-multi-select\u0027).prop(\u0027checked\u0027)\n\nwhich is pure jQuery instead of jQuery / native DOM mix?","commit_id":"d29468ab0ff260e036de3b65baa51fdbcece359f"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"cf55d834e2e1aa0e2981da207c9c8ef4cf39406d","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"            // Only replace row if the html content has changed"},{"line_number":91,"context_line":"            if($new_row.html() !\u003d\u003d $row.html()) {"},{"line_number":92,"context_line":"              if($row.find(\u0027.table-row-multi-select\u0027)[0].checked) {"},{"line_number":93,"context_line":"                // Preserve the checkbox if it\u0027s already clicked"},{"line_number":94,"context_line":"                $new_row.find(\u0027.table-row-multi-select\u0027).prop(\u0027checked\u0027, true);"},{"line_number":95,"context_line":"              }"}],"source_content_type":"text/javascript","patch_set":20,"id":"5a5ae5dd_d10a851f","line":92,"in_reply_to":"5a5ae5dd_100b4e7e","updated":"2016-02-08 21:09:42.000000000","message":"Actually, it was in an attempt to make things much faster.\n\nhttps://jsperf.com/prop-vs-ischecked/5","commit_id":"d29468ab0ff260e036de3b65baa51fdbcece359f"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"0e60f0b490ce6f73bf731ad7c10d185f9e706138","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"            // Only replace row if the html content has changed"},{"line_number":91,"context_line":"            if($new_row.html() !\u003d\u003d $row.html()) {"},{"line_number":92,"context_line":"              if($row.find(\u0027.table-row-multi-select\u0027)[0].checked) {"},{"line_number":93,"context_line":"                // Preserve the checkbox if it\u0027s already clicked"},{"line_number":94,"context_line":"                $new_row.find(\u0027.table-row-multi-select\u0027).prop(\u0027checked\u0027, true);"},{"line_number":95,"context_line":"              }"}],"source_content_type":"text/javascript","patch_set":20,"id":"3a57f1b5_12e8c20f","line":92,"in_reply_to":"5a5ae5dd_d10a851f","updated":"2016-02-11 01:16:07.000000000","message":"Done","commit_id":"d29468ab0ff260e036de3b65baa51fdbcece359f"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"69664ec855d806beae4e09d70ba695dd7c10998f","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"            // Only replace row if the html content has changed"},{"line_number":91,"context_line":"            if($new_row.html() !\u003d\u003d $row.html()) {"},{"line_number":92,"context_line":"              if($row.find(\u0027.table-row-multi-select\u0027)[0].checked) {"},{"line_number":93,"context_line":"                // Preserve the checkbox if it\u0027s already clicked"},{"line_number":94,"context_line":"                $new_row.find(\u0027.table-row-multi-select\u0027).prop(\u0027checked\u0027, true);"},{"line_number":95,"context_line":"              }"}],"source_content_type":"text/javascript","patch_set":20,"id":"5a5ae5dd_3d6ce307","line":92,"in_reply_to":"5a5ae5dd_d10a851f","updated":"2016-02-09 12:44:43.000000000","message":"Got it. Could you please add a short comment?","commit_id":"d29468ab0ff260e036de3b65baa51fdbcece359f"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"8b076dd6ff98a1f62d54a5a205494d55fbf44db9","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"  initialize_checkboxes_behavior: function() {"},{"line_number":166,"context_line":"    // Bind the \"select all\" checkbox action."},{"line_number":167,"context_line":"    $(\u0027.table_wrapper, #modal_wrapper\u0027)"},{"line_number":168,"context_line":"      .on(\u0027change\u0027, \u0027th.multi_select_column .table-row-multi-select\u0027, function() {"},{"line_number":169,"context_line":"        var $this \u003d $(this),"},{"line_number":170,"context_line":"        $table \u003d $this.closest(\u0027table\u0027),"}],"source_content_type":"text/javascript","patch_set":20,"id":"5a5ae5dd_bb8a5b62","line":167,"updated":"2016-02-08 14:50:32.000000000","message":"I\u0027ve noticed that when you do mass-unchecking of checkboxes using th.multi_select_column checkbox, enablement of batch actions (tested on Images table, Delete Images batch button) doesn\u0027t go away.","commit_id":"d29468ab0ff260e036de3b65baa51fdbcece359f"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"0e60f0b490ce6f73bf731ad7c10d185f9e706138","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"  initialize_checkboxes_behavior: function() {"},{"line_number":166,"context_line":"    // Bind the \"select all\" checkbox action."},{"line_number":167,"context_line":"    $(\u0027.table_wrapper, #modal_wrapper\u0027)"},{"line_number":168,"context_line":"      .on(\u0027change\u0027, \u0027th.multi_select_column .table-row-multi-select\u0027, function() {"},{"line_number":169,"context_line":"        var $this \u003d $(this),"},{"line_number":170,"context_line":"        $table \u003d $this.closest(\u0027table\u0027),"}],"source_content_type":"text/javascript","patch_set":20,"id":"3a57f1b5_783d57ba","line":167,"in_reply_to":"5a5ae5dd_bb8a5b62","updated":"2016-02-11 01:16:07.000000000","message":"Done","commit_id":"d29468ab0ff260e036de3b65baa51fdbcece359f"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"cf55d834e2e1aa0e2981da207c9c8ef4cf39406d","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"  initialize_checkboxes_behavior: function() {"},{"line_number":166,"context_line":"    // Bind the \"select all\" checkbox action."},{"line_number":167,"context_line":"    $(\u0027.table_wrapper, #modal_wrapper\u0027)"},{"line_number":168,"context_line":"      .on(\u0027change\u0027, \u0027th.multi_select_column .table-row-multi-select\u0027, function() {"},{"line_number":169,"context_line":"        var $this \u003d $(this),"},{"line_number":170,"context_line":"        $table \u003d $this.closest(\u0027table\u0027),"}],"source_content_type":"text/javascript","patch_set":20,"id":"5a5ae5dd_11d6dd4e","line":167,"in_reply_to":"5a5ae5dd_bb8a5b62","updated":"2016-02-08 21:09:42.000000000","message":"I will look into this, thank you!","commit_id":"d29468ab0ff260e036de3b65baa51fdbcece359f"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"8b076dd6ff98a1f62d54a5a205494d55fbf44db9","unresolved":false,"context_lines":[{"line_number":477,"context_line":"  });"},{"line_number":478,"context_line":"};"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"horizon.datatables.add_table_checkboxes \u003d function($parent) {"},{"line_number":481,"context_line":"  $($parent).find(\u0027table thead .multi_select_column\u0027).each(function() {"},{"line_number":482,"context_line":"    var $thead \u003d $(this);"},{"line_number":483,"context_line":"    if (!$thead.find(\u0027.table-row-multi-select\u0027).length \u0026\u0026"}],"source_content_type":"text/javascript","patch_set":20,"id":"5a5ae5dd_bb1a5bc4","line":480,"updated":"2016-02-08 14:50:32.000000000","message":"Just realized that we\u0027ve doing this thing manually all the time for table headers. It\u0027s a shame, we should had reused markup rendered by Django :(.","commit_id":"d29468ab0ff260e036de3b65baa51fdbcece359f"}],"horizon/test/templates/base.html":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"8b076dd6ff98a1f62d54a5a205494d55fbf44db9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    window.WEBROOT \u003d \u0027{{ WEBROOT }}\u0027;"},{"line_number":10,"context_line":"  \u003c/script\u003e"},{"line_number":11,"context_line":"    \u003cscript src\u003d\u0027{{ STATIC_URL }}horizon/lib/jquery/jquery.js\u0027 type\u003d\u0027text/javascript\u0027 charset\u003d\"utf-8\"\u003e\u003c/script\u003e"},{"line_number":12,"context_line":"    \u003cscript src\u003d\u0027{{ STATIC_URL }}horizon/lib/jquery-ui/ui/jquery-ui.js\u0027 type\u003d\u0027text/javascript\u0027 charset\u003d\"utf-8\"\u003e\u003c/script\u003e"},{"line_number":13,"context_line":"    \u003cscript src\u003d\u0027{{ STATIC_URL }}horizon/lib/jquery/jquery-migrate.js\u0027 type\u003d\u0027text/javascript\u0027 charset\u003d\"utf-8\"\u003e\u003c/script\u003e"},{"line_number":14,"context_line":"    \u003cscript src\u003d\"{{ STATIC_URL }}horizon/lib/jquery/jquery.tablesorter.js\"\u003e\u003c/script\u003e"},{"line_number":15,"context_line":"    \u003cscript src\u003d\"{{ STATIC_URL }}horizon/lib/angular/angular.js\" type\u003d\"text/javascript\" charset\u003d\"utf-8\"\u003e\u003c/script\u003e"}],"source_content_type":"text/html","patch_set":20,"id":"5a5ae5dd_9b80bf8c","line":12,"updated":"2016-02-08 14:50:32.000000000","message":"What jquery-ui feature are we starting to use?","commit_id":"d29468ab0ff260e036de3b65baa51fdbcece359f"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"cf55d834e2e1aa0e2981da207c9c8ef4cf39406d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    window.WEBROOT \u003d \u0027{{ WEBROOT }}\u0027;"},{"line_number":10,"context_line":"  \u003c/script\u003e"},{"line_number":11,"context_line":"    \u003cscript src\u003d\u0027{{ STATIC_URL }}horizon/lib/jquery/jquery.js\u0027 type\u003d\u0027text/javascript\u0027 charset\u003d\"utf-8\"\u003e\u003c/script\u003e"},{"line_number":12,"context_line":"    \u003cscript src\u003d\u0027{{ STATIC_URL }}horizon/lib/jquery-ui/ui/jquery-ui.js\u0027 type\u003d\u0027text/javascript\u0027 charset\u003d\"utf-8\"\u003e\u003c/script\u003e"},{"line_number":13,"context_line":"    \u003cscript src\u003d\u0027{{ STATIC_URL }}horizon/lib/jquery/jquery-migrate.js\u0027 type\u003d\u0027text/javascript\u0027 charset\u003d\"utf-8\"\u003e\u003c/script\u003e"},{"line_number":14,"context_line":"    \u003cscript src\u003d\"{{ STATIC_URL }}horizon/lib/jquery/jquery.tablesorter.js\"\u003e\u003c/script\u003e"},{"line_number":15,"context_line":"    \u003cscript src\u003d\"{{ STATIC_URL }}horizon/lib/angular/angular.js\" type\u003d\"text/javascript\" charset\u003d\"utf-8\"\u003e\u003c/script\u003e"}],"source_content_type":"text/html","patch_set":20,"id":"5a5ae5dd_f160e1a6","line":12,"in_reply_to":"5a5ae5dd_9b80bf8c","updated":"2016-02-08 21:09:42.000000000","message":"We are making use of the unique id function to attach a unique id to a checkbox to enable use of \u0027for\u0027","commit_id":"d29468ab0ff260e036de3b65baa51fdbcece359f"}]}
