)]}'
{"openstack_dashboard/dashboards/admin/networks/ports/views.py":[{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"4d41211093a78623b932b3f892d722e55c967f69","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            ip[\u0027subnet_url\u0027] \u003d reverse(subnet_url, args\u003d[ip[\u0027subnet_id\u0027]])"},{"line_number":45,"context_line":"        table \u003d ports_tables.PortsTable(self.request,"},{"line_number":46,"context_line":"                                        network_id\u003dport.network_id)"},{"line_number":47,"context_line":"        # TODO(robcresswell) Add URL for \"Ports\" crumb after bug/1416838"},{"line_number":48,"context_line":"        breadcrumb \u003d ["},{"line_number":49,"context_line":"            (_(\"Networks\"), self.get_redirect_url()),"},{"line_number":50,"context_line":"            ((port.network_name or port.network_id), port.network_url),"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa0719c6_f1091cdf","line":47,"updated":"2016-03-21 10:56:08.000000000","message":"Does Rob know that added this todo here too?:)","commit_id":"2835c06b4a1489792b8a0c516cebfbaa49d59884"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"b64beefa609623bc42de7ce35c2ca74bb3626580","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            ip[\u0027subnet_url\u0027] \u003d reverse(subnet_url, args\u003d[ip[\u0027subnet_id\u0027]])"},{"line_number":45,"context_line":"        table \u003d ports_tables.PortsTable(self.request,"},{"line_number":46,"context_line":"                                        network_id\u003dport.network_id)"},{"line_number":47,"context_line":"        # TODO(robcresswell) Add URL for \"Ports\" crumb after bug/1416838"},{"line_number":48,"context_line":"        breadcrumb \u003d ["},{"line_number":49,"context_line":"            (_(\"Networks\"), self.get_redirect_url()),"},{"line_number":50,"context_line":"            ((port.network_name or port.network_id), port.network_url),"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa0719c6_af3a98cb","line":47,"in_reply_to":"fa0719c6_0f046413","updated":"2016-03-21 11:11:28.000000000","message":"yup! cames from rebasing it to master, introduced here: https://github.com/openstack/horizon/commit/10ecad1a93690fba6d4854e0cbb94736693e40c8","commit_id":"2835c06b4a1489792b8a0c516cebfbaa49d59884"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"2d45e0bb0d6e4a38cc8f940f4b9e1790865bacea","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            ip[\u0027subnet_url\u0027] \u003d reverse(subnet_url, args\u003d[ip[\u0027subnet_id\u0027]])"},{"line_number":45,"context_line":"        table \u003d ports_tables.PortsTable(self.request,"},{"line_number":46,"context_line":"                                        network_id\u003dport.network_id)"},{"line_number":47,"context_line":"        # TODO(robcresswell) Add URL for \"Ports\" crumb after bug/1416838"},{"line_number":48,"context_line":"        breadcrumb \u003d ["},{"line_number":49,"context_line":"            (_(\"Networks\"), self.get_redirect_url()),"},{"line_number":50,"context_line":"            ((port.network_name or port.network_id), port.network_url),"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa0719c6_0f046413","line":47,"in_reply_to":"fa0719c6_f1091cdf","updated":"2016-03-21 11:10:17.000000000","message":"I think this cames from the rebase, let me have a deeper look....","commit_id":"2835c06b4a1489792b8a0c516cebfbaa49d59884"}],"openstack_dashboard/dashboards/project/networks/ports/tables.py":[{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"17daa9e0d6a36b94ee79b1944ff792e8200576af","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @staticmethod"},{"line_number":62,"context_line":"    def action_past(count):"},{"line_number":63,"context_line":"        return ungettext(u\"Deleted Port\", u\"Deleted Ports\", count)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    policy_rules \u003d ((\"network\", \"delete_port\"),)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_62dadeeb","line":63,"updated":"2015-12-09 13:12:52.000000000","message":"Could you plese explain, why you replaced `ungettext_lazy` with ungettext? Looks like it is still makes sense here, isn\u0027t it?","commit_id":"496327f7e428cc39301c1800c4967e3232264b19"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"7d46539b91c620cabef30b48635cb666259f447c","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @staticmethod"},{"line_number":62,"context_line":"    def action_past(count):"},{"line_number":63,"context_line":"        return ungettext(u\"Deleted Port\", u\"Deleted Ports\", count)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    policy_rules \u003d ((\"network\", \"delete_port\"),)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_d8d4e2be","line":63,"in_reply_to":"7a740942_62dadeeb","updated":"2015-12-09 14:04:11.000000000","message":"Wooops! No idea, will fix it. \n\nGood catch!","commit_id":"496327f7e428cc39301c1800c4967e3232264b19"},{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"17daa9e0d6a36b94ee79b1944ff792e8200576af","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        try:"},{"line_number":69,"context_line":"            api.neutron.port_delete(request, obj_id)"},{"line_number":70,"context_line":"        except Exception as e:"},{"line_number":71,"context_line":"            msg \u003d _(\u0027Failed to delete port: %s\u0027) % e"},{"line_number":72,"context_line":"            network_id \u003d self.table.kwargs[\u0027network_id\u0027]"},{"line_number":73,"context_line":"            redirect \u003d reverse(self.url,"},{"line_number":74,"context_line":"                               args\u003d[network_id])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_c20f1287","line":71,"updated":"2015-12-09 13:12:52.000000000","message":"Looks like you forgot to add LOG.info(msg) here (in admin/networks/ports/tables.py it was). If no, I still think it would be nice to have this logging here.","commit_id":"496327f7e428cc39301c1800c4967e3232264b19"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"7d46539b91c620cabef30b48635cb666259f447c","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        try:"},{"line_number":69,"context_line":"            api.neutron.port_delete(request, obj_id)"},{"line_number":70,"context_line":"        except Exception as e:"},{"line_number":71,"context_line":"            msg \u003d _(\u0027Failed to delete port: %s\u0027) % e"},{"line_number":72,"context_line":"            network_id \u003d self.table.kwargs[\u0027network_id\u0027]"},{"line_number":73,"context_line":"            redirect \u003d reverse(self.url,"},{"line_number":74,"context_line":"                               args\u003d[network_id])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_cb0c0a3e","line":71,"in_reply_to":"7a740942_c20f1287","updated":"2015-12-09 14:04:11.000000000","message":"Yep, missed it, thanks!","commit_id":"496327f7e428cc39301c1800c4967e3232264b19"}],"openstack_dashboard/dashboards/project/networks/ports/views.py":[{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"17daa9e0d6a36b94ee79b1944ff792e8200576af","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        return self.tab_group_class(request, port\u003dport, **kwargs)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def get_port_breadcrumb(self, port):"},{"line_number":132,"context_line":"        network_nav \u003d port.network_name or port.network_id"},{"line_number":133,"context_line":"        return [(_(\"Networks\"), self.get_redirect_url()),"},{"line_number":134,"context_line":"                (network_nav, reverse(\u0027horizon:project:networks:detail\u0027,"},{"line_number":135,"context_line":"                                      args\u003d(port.network_id,))),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_88504b60","line":132,"updated":"2015-12-09 13:12:52.000000000","message":"I\u0027m not sure if it is a nitpicking, but maybe it would be more elegant to make some variable for \u0027horizon:project:networks:detail\u0027 url? If so, we will be able to do not override get_port_breadcrumb() function here: https://review.openstack.org/#/c/253112/1/openstack_dashboard/dashboards/admin/networks/ports/views.py \nNow look like we have to override whole function just to override url for navigation.","commit_id":"496327f7e428cc39301c1800c4967e3232264b19"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"7d46539b91c620cabef30b48635cb666259f447c","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        return self.tab_group_class(request, port\u003dport, **kwargs)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def get_port_breadcrumb(self, port):"},{"line_number":132,"context_line":"        network_nav \u003d port.network_name or port.network_id"},{"line_number":133,"context_line":"        return [(_(\"Networks\"), self.get_redirect_url()),"},{"line_number":134,"context_line":"                (network_nav, reverse(\u0027horizon:project:networks:detail\u0027,"},{"line_number":135,"context_line":"                                      args\u003d(port.network_id,))),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_78536e6d","line":132,"in_reply_to":"7a740942_88504b60","updated":"2015-12-09 14:04:11.000000000","message":"Good point, should make the detail_url an attribute instead!","commit_id":"496327f7e428cc39301c1800c4967e3232264b19"}]}
