)]}'
{"openstack_dashboard/static/app/core/cloud-services/hz-if-version.directive.spec.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"f5cb0e187a50c3c5d6d529ccc4f516e93536d596","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      \u0027\u003c/div\u003e\u0027,"},{"line_number":65,"context_line":"      \u0027\u003c/div\u003e\u0027,"},{"line_number":66,"context_line":"      \u0027\u003c/div\u003e\u0027"},{"line_number":67,"context_line":"    ].join(\u0027\u0027);"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    var templateWrongInput \u003d ["},{"line_number":70,"context_line":"      \u0027\u003cdiv\u003e\u0027,"}],"source_content_type":"text/javascript","patch_set":3,"id":"7a740942_dfae5d2d","line":67,"updated":"2015-12-12 20:33:42.000000000","message":"Would you mind adding in a test for all the valid operators in your array of elements? I know the functionality checks it, but this just gives a bit more insurance against future refactors.\n\n[\"\u003c\u003d\", \"\u003c\", \"\u003d\u003d\", \"\u003e\", \"\u003e\u003d\"]\n\nAlso, just FYI, you could easily do this with a baseHTML that you replace the operator being tested so we wouldn\u0027t have as much redundant HTML up here.  See:\n\nhttps://github.com/openstack/horizon/blob/master/horizon/static/framework/util/promise-toggle/hz-promise-toggle.directive.spec.js#L26-L33\n\nhttps://github.com/openstack/horizon/blob/master/horizon/static/framework/util/promise-toggle/hz-promise-toggle.directive.spec.js#L82-L83","commit_id":"0a489b89ac829bdd285d55810b98a50483440431"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"e674d1b093d1830cc76f5d7116303d87dd97238a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      \u0027\u003c/div\u003e\u0027,"},{"line_number":65,"context_line":"      \u0027\u003c/div\u003e\u0027,"},{"line_number":66,"context_line":"      \u0027\u003c/div\u003e\u0027"},{"line_number":67,"context_line":"    ].join(\u0027\u0027);"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    var templateWrongInput \u003d ["},{"line_number":70,"context_line":"      \u0027\u003cdiv\u003e\u0027,"}],"source_content_type":"text/javascript","patch_set":3,"id":"5a710552_e1afa07b","line":67,"in_reply_to":"7a740942_dfae5d2d","updated":"2015-12-14 23:41:22.000000000","message":"Thanks for the baseHtml reference. :)","commit_id":"0a489b89ac829bdd285d55810b98a50483440431"}]}
