)]}'
{"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/launch-instance-model.service.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"6ac0d0060ad393244de8f5f181bf0f9fc0216887","unresolved":false,"context_lines":[{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    function getPorts(networks) {"},{"line_number":388,"context_line":"      model.ports.length \u003d 0;"},{"line_number":389,"context_line":"      networks.data.items.forEach(function(network) {"},{"line_number":390,"context_line":"        return neutronAPI.getPorts({network_id: network.id}).then("},{"line_number":391,"context_line":"          function(ports) {"},{"line_number":392,"context_line":"            onGetPorts(ports, network);"}],"source_content_type":"text/javascript","patch_set":28,"id":"1af94dfe_bbc5a85c","line":389,"updated":"2016-03-15 19:34:27.000000000","message":"I prefer these are named for debugging.","commit_id":"c2de6dab579c5ce377fd46b0fcdac4edad9c4401"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"6ac0d0060ad393244de8f5f181bf0f9fc0216887","unresolved":false,"context_lines":[{"line_number":388,"context_line":"      model.ports.length \u003d 0;"},{"line_number":389,"context_line":"      networks.data.items.forEach(function(network) {"},{"line_number":390,"context_line":"        return neutronAPI.getPorts({network_id: network.id}).then("},{"line_number":391,"context_line":"          function(ports) {"},{"line_number":392,"context_line":"            onGetPorts(ports, network);"},{"line_number":393,"context_line":"          }, noop"},{"line_number":394,"context_line":"        );"}],"source_content_type":"text/javascript","patch_set":28,"id":"1af94dfe_3bb078f4","line":391,"updated":"2016-03-15 19:34:27.000000000","message":"name function","commit_id":"c2de6dab579c5ce377fd46b0fcdac4edad9c4401"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"6ac0d0060ad393244de8f5f181bf0f9fc0216887","unresolved":false,"context_lines":[{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    function onGetPorts(networkPorts, network) {"},{"line_number":399,"context_line":"      var ports \u003d [];"},{"line_number":400,"context_line":"      networkPorts.data.items.forEach(function(port) {"},{"line_number":401,"context_line":"        // no device_owner means that the port can be attached"},{"line_number":402,"context_line":"        if (port.device_owner \u003d\u003d\u003d \"\" \u0026\u0026 port.admin_state \u003d\u003d\u003d \"UP\") {"},{"line_number":403,"context_line":"          port.subnet_names \u003d getPortSubnets(port, network.subnets);"}],"source_content_type":"text/javascript","patch_set":28,"id":"1af94dfe_7b920059","line":400,"updated":"2016-03-15 19:34:27.000000000","message":"name function","commit_id":"c2de6dab579c5ce377fd46b0fcdac4edad9c4401"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"6ac0d0060ad393244de8f5f181bf0f9fc0216887","unresolved":false,"context_lines":[{"line_number":411,"context_line":"    // helper function to return an object of IP:NAME pairs for subnet mapping"},{"line_number":412,"context_line":"    function getPortSubnets(port, subnets) {"},{"line_number":413,"context_line":"      var subnetNames \u003d {};"},{"line_number":414,"context_line":"      port.fixed_ips.forEach(function (ip) {"},{"line_number":415,"context_line":"        subnets.forEach(function (subnet) {"},{"line_number":416,"context_line":"          if (ip.subnet_id \u003d\u003d\u003d subnet.id) {"},{"line_number":417,"context_line":"            subnetNames[ip.ip_address] \u003d subnet.name;"}],"source_content_type":"text/javascript","patch_set":28,"id":"1af94dfe_fb8c5037","line":414,"updated":"2016-03-15 19:34:27.000000000","message":"name function","commit_id":"c2de6dab579c5ce377fd46b0fcdac4edad9c4401"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"6ac0d0060ad393244de8f5f181bf0f9fc0216887","unresolved":false,"context_lines":[{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    function setFinalSpecPorts(finalSpec) {"},{"line_number":426,"context_line":"      // nics should already be filled so we only append to it"},{"line_number":427,"context_line":"      finalSpec.ports.forEach(function (port) {"},{"line_number":428,"context_line":"        finalSpec.nics.push("},{"line_number":429,"context_line":"          {"},{"line_number":430,"context_line":"            \"port-id\": port.id"}],"source_content_type":"text/javascript","patch_set":28,"id":"1af94dfe_3b87d810","line":427,"updated":"2016-03-15 19:34:27.000000000","message":"name function","commit_id":"c2de6dab579c5ce377fd46b0fcdac4edad9c4401"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/launch-instance-workflow.service.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"ae533b79e6b14dd1542a036a6ce2fe7446d9715a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"          templateUrl: basePath + \u0027networkports/ports.html\u0027,"},{"line_number":66,"context_line":"          helpUrl: basePath + \u0027networkports/ports.help.html\u0027,"},{"line_number":67,"context_line":"          formName: \u0027launchInstanceNetworkPortForm\u0027,"},{"line_number":68,"context_line":"          requiredServiceTypes: [\u0027network\u0027]"},{"line_number":69,"context_line":"        },"},{"line_number":70,"context_line":"        {"},{"line_number":71,"context_line":"          id: \u0027secgroups\u0027,"}],"source_content_type":"text/javascript","patch_set":28,"id":"1af94dfe_816e75c7","line":68,"updated":"2016-03-16 00:37:56.000000000","message":"Possibly add policy support here if needed.\n\nhttps://review.openstack.org/#/c/285868/","commit_id":"c2de6dab579c5ce377fd46b0fcdac4edad9c4401"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/network/network.controller.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"6ac0d0060ad393244de8f5f181bf0f9fc0216887","unresolved":false,"context_lines":[{"line_number":104,"context_line":"      }"},{"line_number":105,"context_line":"    ];"},{"line_number":106,"context_line":"    // If a port is selected, then networks are not required"},{"line_number":107,"context_line":"    var portWatcher \u003d $scope.$watch(function () {"},{"line_number":108,"context_line":"      return launchInstanceModel.newInstanceSpec.ports;"},{"line_number":109,"context_line":"    }, function (newValue) {"},{"line_number":110,"context_line":"      // if there is a port selected, remove the validate-number-min"}],"source_content_type":"text/javascript","patch_set":28,"id":"1af94dfe_5b99046e","line":107,"updated":"2016-03-15 19:34:27.000000000","message":"name function","commit_id":"c2de6dab579c5ce377fd46b0fcdac4edad9c4401"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"6ac0d0060ad393244de8f5f181bf0f9fc0216887","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    // If a port is selected, then networks are not required"},{"line_number":107,"context_line":"    var portWatcher \u003d $scope.$watch(function () {"},{"line_number":108,"context_line":"      return launchInstanceModel.newInstanceSpec.ports;"},{"line_number":109,"context_line":"    }, function (newValue) {"},{"line_number":110,"context_line":"      // if there is a port selected, remove the validate-number-min"},{"line_number":111,"context_line":"      // for networks table"},{"line_number":112,"context_line":"      if (newValue.length \u003e 0) {"}],"source_content_type":"text/javascript","patch_set":28,"id":"1af94dfe_9ba38c9e","line":109,"updated":"2016-03-15 19:34:27.000000000","message":"name function","commit_id":"c2de6dab579c5ce377fd46b0fcdac4edad9c4401"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"6ac0d0060ad393244de8f5f181bf0f9fc0216887","unresolved":false,"context_lines":[{"line_number":118,"context_line":"      }"},{"line_number":119,"context_line":"    }, true);"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    $scope.$on(\u0027$destroy\u0027, function() {"},{"line_number":122,"context_line":"      portWatcher();"},{"line_number":123,"context_line":"    });"},{"line_number":124,"context_line":"  }"}],"source_content_type":"text/javascript","patch_set":28,"id":"1af94dfe_bbaac86e","line":121,"updated":"2016-03-15 19:34:27.000000000","message":"name function","commit_id":"c2de6dab579c5ce377fd46b0fcdac4edad9c4401"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/networkports/ports.help.html":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"873b9704f8136772fe899755a75da16c89449517","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv\u003e"},{"line_number":2,"context_line":"  \u003ch1 translate\u003ePort Help\u003c/h1\u003e"},{"line_number":3,"context_line":"    \u003cp translate\u003e"},{"line_number":4,"context_line":"        A port represents a virtual switch port on a logical network switch."}],"source_content_type":"text/html","patch_set":16,"id":"3a57f1b5_d722ee51","line":1,"updated":"2016-02-11 16:48:41.000000000","message":"I think you should add in some of the information here from the commit message and in the network help telling people their selection options between port and network.","commit_id":"314e23f236f33a7514ce4653917a2ef334240451"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"fe64726f329d2a2207ff8c78cb772f88eb9db4ac","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv\u003e"},{"line_number":2,"context_line":"  \u003ch1 translate\u003ePort Help\u003c/h1\u003e"},{"line_number":3,"context_line":"    \u003cp translate\u003e"},{"line_number":4,"context_line":"        A port represents a virtual switch port on a logical network switch."}],"source_content_type":"text/html","patch_set":16,"id":"3a57f1b5_01eb4414","line":1,"in_reply_to":"3a57f1b5_d722ee51","updated":"2016-02-12 09:20:15.000000000","message":"To be honest, ports is probably not gonna be used that much, you need to know about ports and how to use them and so on before coming here. \n\nI agree with adding more info here, specially saying that if you select a port then there is no need to select a network anymore, but Im not sure about changing it in the network help as it can lead to confuse end users.\n\nMaybe a small note like \"You can also select a port to attach to an instance instead of a network\"?","commit_id":"314e23f236f33a7514ce4653917a2ef334240451"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"873b9704f8136772fe899755a75da16c89449517","unresolved":false,"context_lines":[{"line_number":7,"context_line":"        Ports can be created under a network."},{"line_number":8,"context_line":"    \u003c/p\u003e"},{"line_number":9,"context_line":"    \u003cp translate\u003e"},{"line_number":10,"context_line":"        Virtual instances attach their interfaces into ports."},{"line_number":11,"context_line":"    \u003c/p\u003e"},{"line_number":12,"context_line":"    \u003cp translate\u003e"},{"line_number":13,"context_line":"        The logical port also defines the MAC address and the IP address(es) to be assigned to the interfaces plugged into them."}],"source_content_type":"text/html","patch_set":16,"id":"3a57f1b5_57011e04","line":10,"updated":"2016-02-11 16:48:41.000000000","message":"possible nit:  into -\u003e to.","commit_id":"314e23f236f33a7514ce4653917a2ef334240451"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"8cd3e8817c5c6f398817e593d3a10213312b0e6f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        When IP addresses are associated to a port, this also implies the port is associated with a subnet, as the IP address was taken from the allocation pool for a specific subnet."},{"line_number":17,"context_line":"    \u003c/p\u003e"},{"line_number":18,"context_line":"    \u003cp translate\u003e"},{"line_number":19,"context_line":"        You can select a port instead of network or a mix of both to launch your instance attached to."},{"line_number":20,"context_line":"    \u003c/p\u003e"},{"line_number":21,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":21,"id":"9aed3d3a_7901deae","line":19,"updated":"2016-02-29 18:52:09.000000000","message":"Dangling participle (end sentence with to).  Should be:\n\nYou can select ports instead of networks or a mix of both.\n\nThis should be up in the first paragraph. I also think this could be stated  on line 5 here: https://review.openstack.org/#/c/253573/21/openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/networkports/ports.html","commit_id":"45928593059b40c6fa2b24ebee50a3f10971d671"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"923c32bef783b9f6f0a66f18c8ed38b2f8fee1dd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        When IP addresses are associated to a port, this also implies the port is associated with a subnet, as the IP address was taken from the allocation pool for a specific subnet."},{"line_number":17,"context_line":"    \u003c/p\u003e"},{"line_number":18,"context_line":"    \u003cp translate\u003e"},{"line_number":19,"context_line":"        You can select a port instead of network or a mix of both to launch your instance attached to."},{"line_number":20,"context_line":"    \u003c/p\u003e"},{"line_number":21,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":21,"id":"7af24918_f32492b0","line":19,"in_reply_to":"9aed3d3a_57249e5e","updated":"2016-03-01 12:26:22.000000000","message":"Done","commit_id":"45928593059b40c6fa2b24ebee50a3f10971d671"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"d648e199135ac6ab5b267c4d6c1e1ad4a44a8b3d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        When IP addresses are associated to a port, this also implies the port is associated with a subnet, as the IP address was taken from the allocation pool for a specific subnet."},{"line_number":17,"context_line":"    \u003c/p\u003e"},{"line_number":18,"context_line":"    \u003cp translate\u003e"},{"line_number":19,"context_line":"        You can select a port instead of network or a mix of both to launch your instance attached to."},{"line_number":20,"context_line":"    \u003c/p\u003e"},{"line_number":21,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":21,"id":"9aed3d3a_57249e5e","line":19,"in_reply_to":"9aed3d3a_7901deae","updated":"2016-02-29 20:31:39.000000000","message":"Good point, will do","commit_id":"45928593059b40c6fa2b24ebee50a3f10971d671"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"8cd3e8817c5c6f398817e593d3a10213312b0e6f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    \u003c/p\u003e"},{"line_number":18,"context_line":"    \u003cp translate\u003e"},{"line_number":19,"context_line":"        You can select a port instead of network or a mix of both to launch your instance attached to."},{"line_number":20,"context_line":"    \u003c/p\u003e"},{"line_number":21,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":21,"id":"9aed3d3a_dd2d75a9","line":20,"updated":"2016-02-29 18:52:09.000000000","message":"This is missing information on the admin state and status. networks step has that information. Please add:\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/network/network.help.html#L36-L42","commit_id":"45928593059b40c6fa2b24ebee50a3f10971d671"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"923c32bef783b9f6f0a66f18c8ed38b2f8fee1dd","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    \u003c/p\u003e"},{"line_number":18,"context_line":"    \u003cp translate\u003e"},{"line_number":19,"context_line":"        You can select a port instead of network or a mix of both to launch your instance attached to."},{"line_number":20,"context_line":"    \u003c/p\u003e"},{"line_number":21,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":21,"id":"7af24918_533aa6ce","line":20,"in_reply_to":"9aed3d3a_d7ef0ee7","updated":"2016-03-01 12:26:22.000000000","message":"Done","commit_id":"45928593059b40c6fa2b24ebee50a3f10971d671"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"d648e199135ac6ab5b267c4d6c1e1ad4a44a8b3d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    \u003c/p\u003e"},{"line_number":18,"context_line":"    \u003cp translate\u003e"},{"line_number":19,"context_line":"        You can select a port instead of network or a mix of both to launch your instance attached to."},{"line_number":20,"context_line":"    \u003c/p\u003e"},{"line_number":21,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":21,"id":"9aed3d3a_d7ef0ee7","line":20,"in_reply_to":"9aed3d3a_dd2d75a9","updated":"2016-02-29 20:31:39.000000000","message":"Great point, I will add the same stuff but for ports.","commit_id":"45928593059b40c6fa2b24ebee50a3f10971d671"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"68096152cebfb8e0ab0e310f80604f03ea1a7d79","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv\u003e"},{"line_number":2,"context_line":"  \u003ch1 translate\u003ePort Help\u003c/h1\u003e"},{"line_number":3,"context_line":"    \u003cp translate\u003e"},{"line_number":4,"context_line":"        A port represents a virtual switch port on a logical network switch."},{"line_number":5,"context_line":"    \u003c/p\u003e"}],"source_content_type":"text/html","patch_set":22,"id":"7af24918_fa5a5029","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":30},"updated":"2016-03-02 14:02:09.000000000","message":"Remove the header and wrapping div","commit_id":"3e9a948d4585b79aad720af8e95f37a2f1514e0e"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"22194bc17bc2710eb487964bdd8617ee40dfd679","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv\u003e"},{"line_number":2,"context_line":"  \u003ch1 translate\u003ePort Help\u003c/h1\u003e"},{"line_number":3,"context_line":"    \u003cp translate\u003e"},{"line_number":4,"context_line":"        A port represents a virtual switch port on a logical network switch."},{"line_number":5,"context_line":"    \u003c/p\u003e"}],"source_content_type":"text/html","patch_set":22,"id":"7af24918_70d77fed","line":2,"in_reply_to":"7af24918_fa5a5029","updated":"2016-03-02 14:40:39.000000000","message":"Done","commit_id":"3e9a948d4585b79aad720af8e95f37a2f1514e0e"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/networkports/ports.html":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"873b9704f8136772fe899755a75da16c89449517","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    \u003c/div\u003e"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  \u003ctransfer-table tr-model\u003d\"ctrl.tableDataMulti\" help-text\u003d\"ctrl.tableHelpText\" limits\u003d\"ctrl.tableLimits\"\u003e"},{"line_number":9,"context_line":"    \u003callocated validate-number-min\u003d\"0\" ng-model\u003d\"ctrl.tableDataMulti.allocated.length\"\u003e"},{"line_number":10,"context_line":"      \u003ctable st-table\u003d\"ctrl.tableDataMulti.displayedAllocated\" st-safe-src\u003d\"ctrl.tableDataMulti.allocated\" hz-table"},{"line_number":11,"context_line":"        class\u003d\"table-striped table-rsp table-detail modern\"\u003e"},{"line_number":12,"context_line":"        \u003cthead\u003e"}],"source_content_type":"text/html","patch_set":16,"id":"3a57f1b5_b746524d","line":9,"updated":"2016-02-11 16:48:41.000000000","message":"Can this be changed to use the new directives where allocated and available HTML doesn\u0027t have to be repeated?  It was added in this commit:\n\nhttps://github.com/openstack/horizon/commit/cf0b99d4bfb2f896095e45e1e591a6ad2e340de6","commit_id":"314e23f236f33a7514ce4653917a2ef334240451"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"fe64726f329d2a2207ff8c78cb772f88eb9db4ac","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    \u003c/div\u003e"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  \u003ctransfer-table tr-model\u003d\"ctrl.tableDataMulti\" help-text\u003d\"ctrl.tableHelpText\" limits\u003d\"ctrl.tableLimits\"\u003e"},{"line_number":9,"context_line":"    \u003callocated validate-number-min\u003d\"0\" ng-model\u003d\"ctrl.tableDataMulti.allocated.length\"\u003e"},{"line_number":10,"context_line":"      \u003ctable st-table\u003d\"ctrl.tableDataMulti.displayedAllocated\" st-safe-src\u003d\"ctrl.tableDataMulti.allocated\" hz-table"},{"line_number":11,"context_line":"        class\u003d\"table-striped table-rsp table-detail modern\"\u003e"},{"line_number":12,"context_line":"        \u003cthead\u003e"}],"source_content_type":"text/html","patch_set":16,"id":"3a57f1b5_5e535939","line":9,"in_reply_to":"3a57f1b5_b746524d","updated":"2016-02-12 09:20:15.000000000","message":"Thanks Travis, I will try to check how I can add that new directive.","commit_id":"314e23f236f33a7514ce4653917a2ef334240451"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"8cd3e8817c5c6f398817e593d3a10213312b0e6f","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    \u003c/div\u003e"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  \u003ctransfer-table tr-model\u003d\"ctrl.tableDataMulti\" help-text\u003d\"ctrl.tableHelpText\" limits\u003d\"ctrl.tableLimits\"\u003e"},{"line_number":9,"context_line":"    \u003callocated validate-number-min\u003d\"0\" ng-model\u003d\"ctrl.tableDataMulti.allocated.length\"\u003e"},{"line_number":10,"context_line":"      \u003ctable st-table\u003d\"ctrl.tableDataMulti.displayedAllocated\" st-safe-src\u003d\"ctrl.tableDataMulti.allocated\" hz-table"},{"line_number":11,"context_line":"        class\u003d\"table-striped table-rsp table-detail modern\"\u003e"},{"line_number":12,"context_line":"        \u003cthead\u003e"}],"source_content_type":"text/html","patch_set":21,"id":"9aed3d3a_99ef821d","line":9,"updated":"2016-02-29 18:52:09.000000000","message":"Were you not able to use the new directive I pointed you at in patchset 16?\n\nhttps://review.openstack.org/#/c/253573/16..21/openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/networkports/ports.html","commit_id":"45928593059b40c6fa2b24ebee50a3f10971d671"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"d648e199135ac6ab5b267c4d6c1e1ad4a44a8b3d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    \u003c/div\u003e"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  \u003ctransfer-table tr-model\u003d\"ctrl.tableDataMulti\" help-text\u003d\"ctrl.tableHelpText\" limits\u003d\"ctrl.tableLimits\"\u003e"},{"line_number":9,"context_line":"    \u003callocated validate-number-min\u003d\"0\" ng-model\u003d\"ctrl.tableDataMulti.allocated.length\"\u003e"},{"line_number":10,"context_line":"      \u003ctable st-table\u003d\"ctrl.tableDataMulti.displayedAllocated\" st-safe-src\u003d\"ctrl.tableDataMulti.allocated\" hz-table"},{"line_number":11,"context_line":"        class\u003d\"table-striped table-rsp table-detail modern\"\u003e"},{"line_number":12,"context_line":"        \u003cthead\u003e"}],"source_content_type":"text/html","patch_set":21,"id":"9aed3d3a_b7fecaab","line":9,"in_reply_to":"9aed3d3a_99ef821d","updated":"2016-02-29 20:31:39.000000000","message":"I did some work but was unable to make it work, will retry again.","commit_id":"45928593059b40c6fa2b24ebee50a3f10971d671"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"923c32bef783b9f6f0a66f18c8ed38b2f8fee1dd","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    \u003c/div\u003e"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  \u003ctransfer-table tr-model\u003d\"ctrl.tableDataMulti\" help-text\u003d\"ctrl.tableHelpText\" limits\u003d\"ctrl.tableLimits\"\u003e"},{"line_number":9,"context_line":"    \u003callocated validate-number-min\u003d\"0\" ng-model\u003d\"ctrl.tableDataMulti.allocated.length\"\u003e"},{"line_number":10,"context_line":"      \u003ctable st-table\u003d\"ctrl.tableDataMulti.displayedAllocated\" st-safe-src\u003d\"ctrl.tableDataMulti.allocated\" hz-table"},{"line_number":11,"context_line":"        class\u003d\"table-striped table-rsp table-detail modern\"\u003e"},{"line_number":12,"context_line":"        \u003cthead\u003e"}],"source_content_type":"text/html","patch_set":21,"id":"7af24918_b32a0a7d","line":9,"in_reply_to":"9aed3d3a_b7fecaab","updated":"2016-03-01 12:26:22.000000000","message":"Done","commit_id":"45928593059b40c6fa2b24ebee50a3f10971d671"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"68096152cebfb8e0ab0e310f80604f03ea1a7d79","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv ng-controller\u003d\"LaunchInstanceNetworkPortController as ctrl\"\u003e"},{"line_number":2,"context_line":"  \u003ch1 translate\u003ePorts\u003c/h1\u003e"},{"line_number":3,"context_line":"  \u003cdiv class\u003d\"content\"\u003e"},{"line_number":4,"context_line":"    \u003cdiv class\u003d\"subtitle\" translate\u003e"},{"line_number":5,"context_line":"      Ports provide extra communication channels to your instances. You can select ports instead of networks or a mix of both."}],"source_content_type":"text/html","patch_set":22,"id":"7af24918_dfee668a","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":26},"updated":"2016-03-02 14:02:09.000000000","message":"This header can be removed.","commit_id":"3e9a948d4585b79aad720af8e95f37a2f1514e0e"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"22194bc17bc2710eb487964bdd8617ee40dfd679","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv ng-controller\u003d\"LaunchInstanceNetworkPortController as ctrl\"\u003e"},{"line_number":2,"context_line":"  \u003ch1 translate\u003ePorts\u003c/h1\u003e"},{"line_number":3,"context_line":"  \u003cdiv class\u003d\"content\"\u003e"},{"line_number":4,"context_line":"    \u003cdiv class\u003d\"subtitle\" translate\u003e"},{"line_number":5,"context_line":"      Ports provide extra communication channels to your instances. You can select ports instead of networks or a mix of both."}],"source_content_type":"text/html","patch_set":22,"id":"7af24918_30f4d785","line":2,"in_reply_to":"7af24918_dfee668a","updated":"2016-03-02 14:40:39.000000000","message":"Done","commit_id":"3e9a948d4585b79aad720af8e95f37a2f1514e0e"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"68096152cebfb8e0ab0e310f80604f03ea1a7d79","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv ng-controller\u003d\"LaunchInstanceNetworkPortController as ctrl\"\u003e"},{"line_number":2,"context_line":"  \u003ch1 translate\u003ePorts\u003c/h1\u003e"},{"line_number":3,"context_line":"  \u003cdiv class\u003d\"content\"\u003e"},{"line_number":4,"context_line":"    \u003cdiv class\u003d\"subtitle\" translate\u003e"},{"line_number":5,"context_line":"      Ports provide extra communication channels to your instances. You can select ports instead of networks or a mix of both."},{"line_number":6,"context_line":"    \u003c/div\u003e"},{"line_number":7,"context_line":""}],"source_content_type":"text/html","patch_set":22,"id":"7af24918_dfc78610","line":4,"range":{"start_line":3,"start_character":2,"end_line":4,"end_character":36},"updated":"2016-03-02 14:02:09.000000000","message":"These divs can be removed. Just use a \u003cp\u003e for the top line.","commit_id":"3e9a948d4585b79aad720af8e95f37a2f1514e0e"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"22194bc17bc2710eb487964bdd8617ee40dfd679","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv ng-controller\u003d\"LaunchInstanceNetworkPortController as ctrl\"\u003e"},{"line_number":2,"context_line":"  \u003ch1 translate\u003ePorts\u003c/h1\u003e"},{"line_number":3,"context_line":"  \u003cdiv class\u003d\"content\"\u003e"},{"line_number":4,"context_line":"    \u003cdiv class\u003d\"subtitle\" translate\u003e"},{"line_number":5,"context_line":"      Ports provide extra communication channels to your instances. You can select ports instead of networks or a mix of both."},{"line_number":6,"context_line":"    \u003c/div\u003e"},{"line_number":7,"context_line":""}],"source_content_type":"text/html","patch_set":22,"id":"7af24918_d012d3b3","line":4,"in_reply_to":"7af24918_dfc78610","updated":"2016-03-02 14:40:39.000000000","message":"Done","commit_id":"3e9a948d4585b79aad720af8e95f37a2f1514e0e"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"68096152cebfb8e0ab0e310f80604f03ea1a7d79","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  \u003ctransfer-table tr-model\u003d\"ctrl.tableDataMulti\" help-text\u003d\"ctrl.tableHelpText\" limits\u003d\"ctrl.tableLimits\" clone-content\u003e"},{"line_number":9,"context_line":"  \u003ctable st-table\u003d\"$displayedItems\" st-safe-src\u003d\"$sourceItems\""},{"line_number":10,"context_line":"    hz-table class\u003d\"table-striped table-rsp table-detail modern\"\u003e"},{"line_number":11,"context_line":"    \u003cthead\u003e"},{"line_number":12,"context_line":"      \u003c!-- show search bar only for available table --\u003e"},{"line_number":13,"context_line":"      \u003ctr ng-show\u003d\"$isAvailableTable\"\u003e"}],"source_content_type":"text/html","patch_set":22,"id":"7af24918_1f5bae88","line":10,"updated":"2016-03-02 14:02:09.000000000","message":"Missing the \u0027table\u0027 class","commit_id":"3e9a948d4585b79aad720af8e95f37a2f1514e0e"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"68096152cebfb8e0ab0e310f80604f03ea1a7d79","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  \u003ctransfer-table tr-model\u003d\"ctrl.tableDataMulti\" help-text\u003d\"ctrl.tableHelpText\" limits\u003d\"ctrl.tableLimits\" clone-content\u003e"},{"line_number":9,"context_line":"  \u003ctable st-table\u003d\"$displayedItems\" st-safe-src\u003d\"$sourceItems\""},{"line_number":10,"context_line":"    hz-table class\u003d\"table-striped table-rsp table-detail modern\"\u003e"},{"line_number":11,"context_line":"    \u003cthead\u003e"},{"line_number":12,"context_line":"      \u003c!-- show search bar only for available table --\u003e"},{"line_number":13,"context_line":"      \u003ctr ng-show\u003d\"$isAvailableTable\"\u003e"}],"source_content_type":"text/html","patch_set":22,"id":"7af24918_ba29e88b","line":10,"range":{"start_line":10,"start_character":57,"end_line":10,"end_character":63},"updated":"2016-03-02 14:02:09.000000000","message":"remove the \u0027modern\u0027 class","commit_id":"3e9a948d4585b79aad720af8e95f37a2f1514e0e"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"22194bc17bc2710eb487964bdd8617ee40dfd679","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  \u003ctransfer-table tr-model\u003d\"ctrl.tableDataMulti\" help-text\u003d\"ctrl.tableHelpText\" limits\u003d\"ctrl.tableLimits\" clone-content\u003e"},{"line_number":9,"context_line":"  \u003ctable st-table\u003d\"$displayedItems\" st-safe-src\u003d\"$sourceItems\""},{"line_number":10,"context_line":"    hz-table class\u003d\"table-striped table-rsp table-detail modern\"\u003e"},{"line_number":11,"context_line":"    \u003cthead\u003e"},{"line_number":12,"context_line":"      \u003c!-- show search bar only for available table --\u003e"},{"line_number":13,"context_line":"      \u003ctr ng-show\u003d\"$isAvailableTable\"\u003e"}],"source_content_type":"text/html","patch_set":22,"id":"7af24918_90216bfe","line":10,"in_reply_to":"7af24918_1f5bae88","updated":"2016-03-02 14:40:39.000000000","message":"Done","commit_id":"3e9a948d4585b79aad720af8e95f37a2f1514e0e"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"22194bc17bc2710eb487964bdd8617ee40dfd679","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  \u003ctransfer-table tr-model\u003d\"ctrl.tableDataMulti\" help-text\u003d\"ctrl.tableHelpText\" limits\u003d\"ctrl.tableLimits\" clone-content\u003e"},{"line_number":9,"context_line":"  \u003ctable st-table\u003d\"$displayedItems\" st-safe-src\u003d\"$sourceItems\""},{"line_number":10,"context_line":"    hz-table class\u003d\"table-striped table-rsp table-detail modern\"\u003e"},{"line_number":11,"context_line":"    \u003cthead\u003e"},{"line_number":12,"context_line":"      \u003c!-- show search bar only for available table --\u003e"},{"line_number":13,"context_line":"      \u003ctr ng-show\u003d\"$isAvailableTable\"\u003e"}],"source_content_type":"text/html","patch_set":22,"id":"7af24918_701c9fc1","line":10,"in_reply_to":"7af24918_ba29e88b","updated":"2016-03-02 14:40:39.000000000","message":"Done","commit_id":"3e9a948d4585b79aad720af8e95f37a2f1514e0e"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"68096152cebfb8e0ab0e310f80604f03ea1a7d79","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      \u003c!-- show search bar only for available table --\u003e"},{"line_number":13,"context_line":"      \u003ctr ng-show\u003d\"$isAvailableTable\"\u003e"},{"line_number":14,"context_line":"        \u003cth class\u003d\"search-header\" colspan\u003d\"10\"\u003e"},{"line_number":15,"context_line":"          \u003chz-search-bar group-classes\u003d\"input-group-sm\" icon-classes\u003d\"fa-search\"\u003e"},{"line_number":16,"context_line":"          \u003c/hz-search-bar\u003e"},{"line_number":17,"context_line":"        \u003c/th\u003e"},{"line_number":18,"context_line":"      \u003c/tr\u003e"}],"source_content_type":"text/html","patch_set":22,"id":"7af24918_ba028807","line":15,"range":{"start_line":15,"start_character":40,"end_line":15,"end_character":54},"updated":"2016-03-02 14:02:09.000000000","message":"remove this class","commit_id":"3e9a948d4585b79aad720af8e95f37a2f1514e0e"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"22194bc17bc2710eb487964bdd8617ee40dfd679","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      \u003c!-- show search bar only for available table --\u003e"},{"line_number":13,"context_line":"      \u003ctr ng-show\u003d\"$isAvailableTable\"\u003e"},{"line_number":14,"context_line":"        \u003cth class\u003d\"search-header\" colspan\u003d\"10\"\u003e"},{"line_number":15,"context_line":"          \u003chz-search-bar group-classes\u003d\"input-group-sm\" icon-classes\u003d\"fa-search\"\u003e"},{"line_number":16,"context_line":"          \u003c/hz-search-bar\u003e"},{"line_number":17,"context_line":"        \u003c/th\u003e"},{"line_number":18,"context_line":"      \u003c/tr\u003e"}],"source_content_type":"text/html","patch_set":22,"id":"7af24918_10139b67","line":15,"in_reply_to":"7af24918_ba028807","updated":"2016-03-02 14:40:39.000000000","message":"Done","commit_id":"3e9a948d4585b79aad720af8e95f37a2f1514e0e"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/networkports/ports.scss":[{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"530810399a640722c1192b72dec2de4b46683438","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"7a5de9d1_55440173","line":1,"updated":"2016-01-28 10:06:59.000000000","message":"why this empty file added here? is there any specific reason?","commit_id":"ee9a6eea77cb4cd84edd9582ec3dda3b37438769"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/source/source.controller.spec.js":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"be013050efdb9ba686e291b4e173b09f2f1824ba","unresolved":false,"context_lines":[{"line_number":303,"context_line":"          });"},{"line_number":304,"context_line":"        });"},{"line_number":305,"context_line":"      });"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    });"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    describe(\u0027diskFormatFilter\u0027, function() {"}],"source_content_type":"text/javascript","patch_set":28,"id":"1af94dfe_ac5e1843","line":306,"updated":"2016-03-15 17:57:40.000000000","message":"probably not necessary","commit_id":"c2de6dab579c5ce377fd46b0fcdac4edad9c4401"}],"openstack_dashboard/static/app/core/images/steps/create-volume/create-volume.controller.spec.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"873b9704f8136772fe899755a75da16c89449517","unresolved":false,"context_lines":[{"line_number":325,"context_line":"      expect(emittedEventArgs[1]).toEqual(expectedVolume);"},{"line_number":326,"context_line":"    });"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    it(\u0027should emit changed volume events even if the volume name is empty\u0027, function() {"},{"line_number":329,"context_line":"      var ctrl \u003d createController();"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"      $scope.$apply();"}],"source_content_type":"text/javascript","patch_set":16,"id":"3a57f1b5_b75092d5","line":328,"updated":"2016-02-11 16:48:41.000000000","message":"It seems like this should be its own patch?? Would be quick to land, perhaps.","commit_id":"314e23f236f33a7514ce4653917a2ef334240451"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"fe64726f329d2a2207ff8c78cb772f88eb9db4ac","unresolved":false,"context_lines":[{"line_number":325,"context_line":"      expect(emittedEventArgs[1]).toEqual(expectedVolume);"},{"line_number":326,"context_line":"    });"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    it(\u0027should emit changed volume events even if the volume name is empty\u0027, function() {"},{"line_number":329,"context_line":"      var ctrl \u003d createController();"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"      $scope.$apply();"}],"source_content_type":"text/javascript","patch_set":16,"id":"3a57f1b5_612f9888","line":328,"in_reply_to":"3a57f1b5_b75092d5","updated":"2016-02-12 09:20:15.000000000","message":"To be honest something weird happened here. I added tests for the new methods and was above the threshold. Then I rebased and the threshold went down by quite a lot :(\n\nSo Im not sure if it was another patch that brought coverage down.\n\n\nStill, I think you are right, this is no place for extra tests. I will split this into its own patch and look harder to increase the coverage in this patch instead.\n\nThanks!","commit_id":"314e23f236f33a7514ce4653917a2ef334240451"}]}
