)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a10cb8a7b5cba7800dd5abb47055431e9491e203","unresolved":false,"context_lines":[{"line_number":13,"context_line":"of the controller/service/html."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This changes the list type attribute for the directive"},{"line_number":16,"context_line":"from the action-list-type to list-type."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Idc344153aa7582c485a5d9c6b3cccbf8ff788d7c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_0128d531","line":16,"updated":"2015-12-09 00:58:11.000000000","message":"Just reading this msg, I am unclear what this patch is resolving.  Can you please give a use case?","commit_id":"a4b157d1710679d11a71f6bb4f527a8bd178c693"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"2b8c9edcf813e150ad4ce96718e544070197edf8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"of the controller/service/html."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This changes the list type attribute for the directive"},{"line_number":16,"context_line":"from the action-list-type to list-type."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Idc344153aa7582c485a5d9c6b3cccbf8ff788d7c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_d1a93491","line":16,"in_reply_to":"7a740942_0128d531","updated":"2015-12-09 06:34:06.000000000","message":"I\u0027ve updated the message in the next commit. Also, the changes in the patch https://review.openstack.org/#/c/217422/ which uses this help explain.\n\nHave a look at\n\nhttps://review.openstack.org/#/c/217422/73..79/openstack_dashboard/static/app/core/images/table/images-table.html\n\nhttps://review.openstack.org/#/c/217422/73..79/openstack_dashboard/static/app/core/images/table/row-actions.service.js","commit_id":"a4b157d1710679d11a71f6bb4f527a8bd178c693"}],"horizon/static/framework/widgets/action-list/actions.directive.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"71c44048249be69a00882c900cd3e99222e6d061","unresolved":false,"context_lines":[{"line_number":35,"context_line":"   *"},{"line_number":36,"context_line":"   * Attributes:"},{"line_number":37,"context_line":"   *"},{"line_number":38,"context_line":"   * listType: can be only be `row` or `batch`"},{"line_number":39,"context_line":"   * `batch` is rendered as buttons, `row` is rendered as dropdown menu."},{"line_number":40,"context_line":"   *"},{"line_number":41,"context_line":"   * item: the context item to pass to the callback"}],"source_content_type":"text/javascript","patch_set":4,"id":"7a740942_afa76da5","line":38,"updated":"2015-12-09 00:03:19.000000000","message":"can probably simplify to just \"type\". \u003caction type\u003d\"row\"\u003e is a nicer read. I know that type is already a standard HTML attribute, but I think it is ok since it is use in conjunction with a custom element (vs a standard element like input).","commit_id":"8d4e67201ce23d2b11588566afaddc2f862e3b3a"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"106f5383bfd1f9a5a0cd97d95f9abb99e653c9ac","unresolved":false,"context_lines":[{"line_number":35,"context_line":"   *"},{"line_number":36,"context_line":"   * Attributes:"},{"line_number":37,"context_line":"   *"},{"line_number":38,"context_line":"   * listType: can be only be `row` or `batch`"},{"line_number":39,"context_line":"   * `batch` is rendered as buttons, `row` is rendered as dropdown menu."},{"line_number":40,"context_line":"   *"},{"line_number":41,"context_line":"   * item: the context item to pass to the callback"}],"source_content_type":"text/javascript","patch_set":4,"id":"7a740942_41e33dd9","line":38,"in_reply_to":"7a740942_afa76da5","updated":"2015-12-09 00:13:39.000000000","message":"Done","commit_id":"8d4e67201ce23d2b11588566afaddc2f862e3b3a"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"986153375f7122dae6619abd4eb270d9aab4e5a5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"   *"},{"line_number":36,"context_line":"   * Attributes:"},{"line_number":37,"context_line":"   *"},{"line_number":38,"context_line":"   * listType: can be only be `row` or `batch`"},{"line_number":39,"context_line":"   * `batch` is rendered as buttons, `row` is rendered as dropdown menu."},{"line_number":40,"context_line":"   *"},{"line_number":41,"context_line":"   * item: the context item to pass to the callback"}],"source_content_type":"text/javascript","patch_set":4,"id":"7a740942_020101af","line":38,"in_reply_to":"7a740942_afa76da5","updated":"2015-12-11 19:14:10.000000000","message":"You are playing with fire tqtran... (somewhat serious as I\u0027ve already been bitten by title attr on hz-header) although I do like type a bit better so not going to fight this.","commit_id":"8d4e67201ce23d2b11588566afaddc2f862e3b3a"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"71c44048249be69a00882c900cd3e99222e6d061","unresolved":false,"context_lines":[{"line_number":38,"context_line":"   * listType: can be only be `row` or `batch`"},{"line_number":39,"context_line":"   * `batch` is rendered as buttons, `row` is rendered as dropdown menu."},{"line_number":40,"context_line":"   *"},{"line_number":41,"context_line":"   * item: the context item to pass to the callback"},{"line_number":42,"context_line":"   * for `row` listType, the variable is evaluated and passed as an argument"},{"line_number":43,"context_line":"   * when evaluating `allowedActions`"},{"line_number":44,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":4,"id":"7a740942_cffbd977","line":41,"updated":"2015-12-09 00:03:19.000000000","message":"I think this is fine for now. I am thinking a bit longer term where we might be able to pass in any contextItem into any action. For batch actions, maybe a list of items.","commit_id":"8d4e67201ce23d2b11588566afaddc2f862e3b3a"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"71c44048249be69a00882c900cd3e99222e6d061","unresolved":false,"context_lines":[{"line_number":49,"context_line":"   * It\u0027s an array of objects of the form:"},{"line_number":50,"context_line":"   * { template: {}, permissions: \u003cpromise to determine permissions\u003e, callback: \u0027callback\u0027}"},{"line_number":51,"context_line":"   *"},{"line_number":52,"context_line":"   * `template` is an object that can be"},{"line_number":53,"context_line":"   *"},{"line_number":54,"context_line":"   * {url: \u0027template.html\u0027} the location of the template for the action button."},{"line_number":55,"context_line":"   * Use this for complete extensibility and control over what is rendered."}],"source_content_type":"text/javascript","patch_set":4,"id":"7a740942_af00cd02","line":52,"updated":"2015-12-09 00:03:19.000000000","message":"Documentation needs better layout. Things need to be indented so users reading know what level the attributes fall under. Sorry I didn\u0027t catch this first commit.","commit_id":"8d4e67201ce23d2b11588566afaddc2f862e3b3a"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"71c44048249be69a00882c900cd3e99222e6d061","unresolved":false,"context_lines":[{"line_number":55,"context_line":"   * Use this for complete extensibility and control over what is rendered."},{"line_number":56,"context_line":"   * The template will be responsible for binding the callback and styling."},{"line_number":57,"context_line":"   *"},{"line_number":58,"context_line":"   * {type: \u0027type\u0027, item: \u0027item\u0027} use a known action button type."},{"line_number":59,"context_line":"   * Currently supported values are \u0027delete\u0027, \u0027delete-selected\u0027 and \u0027create\u0027."},{"line_number":60,"context_line":"   * `item` is optional and if provided will override the value provided"},{"line_number":61,"context_line":"   * on the directive level. This is used in the callback of the action."}],"source_content_type":"text/javascript","patch_set":4,"id":"7a740942_6f50a532","line":58,"updated":"2015-12-09 00:03:19.000000000","message":"It\u0027s not clear to me whether these are attributes assigned to the directive in the HTML or within an object pass to the directive. You mentioned item above and here we have it again. Perhaps we should use a different name? Something like buttonType? I\u0027m not sure what or how to use item since I am already providing this above? Are they the same?\n\nIf I have to stop and think about it, I am sure someone new to this will have no idea how to use it. Ok after reading it more carefully, seems like an indentation is needed to distinguish that this section falls under the template attribute.","commit_id":"8d4e67201ce23d2b11588566afaddc2f862e3b3a"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"71c44048249be69a00882c900cd3e99222e6d061","unresolved":false,"context_lines":[{"line_number":56,"context_line":"   * The template will be responsible for binding the callback and styling."},{"line_number":57,"context_line":"   *"},{"line_number":58,"context_line":"   * {type: \u0027type\u0027, item: \u0027item\u0027} use a known action button type."},{"line_number":59,"context_line":"   * Currently supported values are \u0027delete\u0027, \u0027delete-selected\u0027 and \u0027create\u0027."},{"line_number":60,"context_line":"   * `item` is optional and if provided will override the value provided"},{"line_number":61,"context_line":"   * on the directive level. This is used in the callback of the action."},{"line_number":62,"context_line":"   * The styling and binding of the callback is done by the template."}],"source_content_type":"text/javascript","patch_set":4,"id":"7a740942_0f8241c8","line":59,"updated":"2015-12-09 00:03:19.000000000","message":"This should be listed to make it easier to pick out. Example:\n\n  Currently supported values are:\n    * \u0027delete\u0027\n    * \u0027delete-selected\u0027\n    * \u0027create\u0027","commit_id":"8d4e67201ce23d2b11588566afaddc2f862e3b3a"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"106f5383bfd1f9a5a0cd97d95f9abb99e653c9ac","unresolved":false,"context_lines":[{"line_number":56,"context_line":"   * The template will be responsible for binding the callback and styling."},{"line_number":57,"context_line":"   *"},{"line_number":58,"context_line":"   * {type: \u0027type\u0027, item: \u0027item\u0027} use a known action button type."},{"line_number":59,"context_line":"   * Currently supported values are \u0027delete\u0027, \u0027delete-selected\u0027 and \u0027create\u0027."},{"line_number":60,"context_line":"   * `item` is optional and if provided will override the value provided"},{"line_number":61,"context_line":"   * on the directive level. This is used in the callback of the action."},{"line_number":62,"context_line":"   * The styling and binding of the callback is done by the template."}],"source_content_type":"text/javascript","patch_set":4,"id":"7a740942_a1fb0178","line":59,"in_reply_to":"7a740942_0f8241c8","updated":"2015-12-09 00:13:39.000000000","message":"I\u0027ve indented the code better to highlight the intent","commit_id":"8d4e67201ce23d2b11588566afaddc2f862e3b3a"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"71c44048249be69a00882c900cd3e99222e6d061","unresolved":false,"context_lines":[{"line_number":79,"context_line":"   * @example"},{"line_number":80,"context_line":"   *"},{"line_number":81,"context_line":"   * batch:"},{"line_number":82,"context_line":"   *"},{"line_number":83,"context_line":"   * var actions \u003d [{"},{"line_number":84,"context_line":"   *   callback: \u0027table.batchActions.delete.open\u0027,"},{"line_number":85,"context_line":"   *   template: {"}],"source_content_type":"text/javascript","patch_set":4,"id":"7a740942_41a1fdf6","line":82,"updated":"2015-12-09 00:03:19.000000000","message":"normally, examples are shown below, but I think in this case, it might help to see them first, then talk about what each property means. We have a lot of nested properties and some of them have similar names so its really hard to follow the documentation. This will be especially true for first time users.","commit_id":"8d4e67201ce23d2b11588566afaddc2f862e3b3a"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a10cb8a7b5cba7800dd5abb47055431e9491e203","unresolved":false,"context_lines":[{"line_number":36,"context_line":"   * Attributes:"},{"line_number":37,"context_line":"   *"},{"line_number":38,"context_line":"   * listType: can be only be `row` or `batch`"},{"line_number":39,"context_line":"   * `batch` is rendered as buttons, `row` is rendered as dropdown menu."},{"line_number":40,"context_line":"   *"},{"line_number":41,"context_line":"   * item: the context item to pass to the callback"},{"line_number":42,"context_line":"   * for `row` listType, the variable is evaluated and passed as an argument"}],"source_content_type":"text/javascript","patch_set":5,"id":"7a740942_41a7bdbc","line":39,"updated":"2015-12-09 00:58:11.000000000","message":"probably mention what \"batch actions\" are so that ppl understand why they are rendered as buttons\n\nalso, attributes should probably be ngDoc formatted, it will also help convey what params are required and which are not\n\n@param {string} listType \u003cdescription\u003e\n\nSee: https://github.com/openstack/horizon/blob/master/horizon/static/framework/widgets/magic-search/hz-magic-search-bar.directive.js#L27","commit_id":"a4b157d1710679d11a71f6bb4f527a8bd178c693"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"2b8c9edcf813e150ad4ce96718e544070197edf8","unresolved":false,"context_lines":[{"line_number":36,"context_line":"   * Attributes:"},{"line_number":37,"context_line":"   *"},{"line_number":38,"context_line":"   * listType: can be only be `row` or `batch`"},{"line_number":39,"context_line":"   * `batch` is rendered as buttons, `row` is rendered as dropdown menu."},{"line_number":40,"context_line":"   *"},{"line_number":41,"context_line":"   * item: the context item to pass to the callback"},{"line_number":42,"context_line":"   * for `row` listType, the variable is evaluated and passed as an argument"}],"source_content_type":"text/javascript","patch_set":5,"id":"7a740942_31051810","line":39,"in_reply_to":"7a740942_41a7bdbc","updated":"2015-12-09 06:34:06.000000000","message":"Done","commit_id":"a4b157d1710679d11a71f6bb4f527a8bd178c693"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a10cb8a7b5cba7800dd5abb47055431e9491e203","unresolved":false,"context_lines":[{"line_number":40,"context_line":"   *"},{"line_number":41,"context_line":"   * item: the context item to pass to the callback"},{"line_number":42,"context_line":"   * for `row` listType, the variable is evaluated and passed as an argument"},{"line_number":43,"context_line":"   * when evaluating `allowedActions`"},{"line_number":44,"context_line":"   *"},{"line_number":45,"context_line":"   * allowedActions: actions allowed that can be displayed"},{"line_number":46,"context_line":"   * actionListType: allow the buttons to be shown as a list or doropdown"}],"source_content_type":"text/javascript","patch_set":5,"id":"7a740942_a18c61da","line":43,"updated":"2015-12-09 00:58:11.000000000","message":"so this attribute is only required if listType \u003d\u003d \u0027row\u0027?\n\nso something like:\n\n@param {object\u003d} item \u003cdescription\u003e\n\nAlso, I think this should be called contextItem for clarity.","commit_id":"a4b157d1710679d11a71f6bb4f527a8bd178c693"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"2b8c9edcf813e150ad4ce96718e544070197edf8","unresolved":false,"context_lines":[{"line_number":40,"context_line":"   *"},{"line_number":41,"context_line":"   * item: the context item to pass to the callback"},{"line_number":42,"context_line":"   * for `row` listType, the variable is evaluated and passed as an argument"},{"line_number":43,"context_line":"   * when evaluating `allowedActions`"},{"line_number":44,"context_line":"   *"},{"line_number":45,"context_line":"   * allowedActions: actions allowed that can be displayed"},{"line_number":46,"context_line":"   * actionListType: allow the buttons to be shown as a list or doropdown"}],"source_content_type":"text/javascript","patch_set":5,"id":"7a740942_d107f415","line":43,"in_reply_to":"7a740942_a18c61da","updated":"2015-12-09 06:34:06.000000000","message":"Done","commit_id":"a4b157d1710679d11a71f6bb4f527a8bd178c693"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a10cb8a7b5cba7800dd5abb47055431e9491e203","unresolved":false,"context_lines":[{"line_number":55,"context_line":"   * Use this for complete extensibility and control over what is rendered."},{"line_number":56,"context_line":"   * The template will be responsible for binding the callback and styling."},{"line_number":57,"context_line":"   *"},{"line_number":58,"context_line":"   * {type: \u0027type\u0027, item: \u0027item\u0027} use a known action button type."},{"line_number":59,"context_line":"   * Currently supported values are \u0027delete\u0027, \u0027delete-selected\u0027 and \u0027create\u0027."},{"line_number":60,"context_line":"   * `item` is optional and if provided will override the value provided"},{"line_number":61,"context_line":"   * on the directive level. This is used in the callback of the action."}],"source_content_type":"text/javascript","patch_set":5,"id":"7a740942_214dd199","line":58,"updated":"2015-12-09 00:58:11.000000000","message":"nit: this seems more clear:\n\n{type: \u003caction_button_type\u003e, item: \u003ccallback_item\u003e}\n\nCurrently supported action button types are \u0027delete\u0027, \u0027delete-selected\u0027 and \u0027create\u0027.","commit_id":"a4b157d1710679d11a71f6bb4f527a8bd178c693"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a10cb8a7b5cba7800dd5abb47055431e9491e203","unresolved":false,"context_lines":[{"line_number":64,"context_line":"   * {text: \u0027text\u0027, item: \u0027item\u0027} use an unstyled button with given text."},{"line_number":65,"context_line":"   * `item` is optional and if provided will override the value provided"},{"line_number":66,"context_line":"   * on the directive level. This is used in the callback of the action."},{"line_number":67,"context_line":"   * The styling of the button will vary per the `actionListType` chosen."},{"line_number":68,"context_line":"   * For custom styling of the button, `actionClasses` can be included in"},{"line_number":69,"context_line":"   * the template."},{"line_number":70,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":5,"id":"7a740942_e110295b","line":67,"updated":"2015-12-09 00:58:11.000000000","message":"listType*","commit_id":"a4b157d1710679d11a71f6bb4f527a8bd178c693"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"2b8c9edcf813e150ad4ce96718e544070197edf8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"   * {text: \u0027text\u0027, item: \u0027item\u0027} use an unstyled button with given text."},{"line_number":65,"context_line":"   * `item` is optional and if provided will override the value provided"},{"line_number":66,"context_line":"   * on the directive level. This is used in the callback of the action."},{"line_number":67,"context_line":"   * The styling of the button will vary per the `actionListType` chosen."},{"line_number":68,"context_line":"   * For custom styling of the button, `actionClasses` can be included in"},{"line_number":69,"context_line":"   * the template."},{"line_number":70,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":5,"id":"7a740942_51e6a444","line":67,"in_reply_to":"7a740942_e110295b","updated":"2015-12-09 06:34:06.000000000","message":"Done","commit_id":"a4b157d1710679d11a71f6bb4f527a8bd178c693"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a10cb8a7b5cba7800dd5abb47055431e9491e203","unresolved":false,"context_lines":[{"line_number":72,"context_line":"   * if permitted and is rejected if not."},{"line_number":73,"context_line":"   *"},{"line_number":74,"context_line":"   * `callback` is the method to call when the button is clicked. The callback"},{"line_number":75,"context_line":"   * will be called with the `item` if provided."},{"line_number":76,"context_line":"   *"},{"line_number":77,"context_line":"   * @restrict E"},{"line_number":78,"context_line":"   * @scope"}],"source_content_type":"text/javascript","patch_set":5,"id":"7a740942_e407d715","line":75,"updated":"2015-12-09 00:58:11.000000000","message":"There are a lot of dependent and sub attributes, and it makes it confusing.  I wish there was a better way to convey this.  I think following ngDoc guidelines is a good first step.","commit_id":"a4b157d1710679d11a71f6bb4f527a8bd178c693"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a10cb8a7b5cba7800dd5abb47055431e9491e203","unresolved":false,"context_lines":[{"line_number":116,"context_line":"   *     template: {"},{"line_number":117,"context_line":"   *       text: gettext(\u0027Create Volume\u0027),"},{"line_number":118,"context_line":"   *     },"},{"line_number":119,"context_line":"\t *     permissions: createVolumeFromImagePermitted(image)"},{"line_number":120,"context_line":"   *   }];"},{"line_number":121,"context_line":"   * }"},{"line_number":122,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":5,"id":"7a740942_64f1a794","line":119,"updated":"2015-12-09 00:58:11.000000000","message":"accidental indent","commit_id":"a4b157d1710679d11a71f6bb4f527a8bd178c693"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"2b8c9edcf813e150ad4ce96718e544070197edf8","unresolved":false,"context_lines":[{"line_number":116,"context_line":"   *     template: {"},{"line_number":117,"context_line":"   *       text: gettext(\u0027Create Volume\u0027),"},{"line_number":118,"context_line":"   *     },"},{"line_number":119,"context_line":"\t *     permissions: createVolumeFromImagePermitted(image)"},{"line_number":120,"context_line":"   *   }];"},{"line_number":121,"context_line":"   * }"},{"line_number":122,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":5,"id":"7a740942_b1702873","line":119,"in_reply_to":"7a740942_64f1a794","updated":"2015-12-09 06:34:06.000000000","message":"Done","commit_id":"a4b157d1710679d11a71f6bb4f527a8bd178c693"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"1145891f80f5e47cdc377daa79531213df413106","unresolved":false,"context_lines":[{"line_number":52,"context_line":"   *   callback: \u0027callback for the action\u0027"},{"line_number":53,"context_line":"   * }"},{"line_number":54,"context_line":"   *"},{"line_number":55,"context_line":"   *   template: is an object that can be"},{"line_number":56,"context_line":"   *   1. {url: \u0027full_path_to_template.html\u0027}"},{"line_number":57,"context_line":"   *      This specifies the location of the template for the action button."},{"line_number":58,"context_line":"   *      Use this for complete extensibility and control over what is rendered."}],"source_content_type":"text/javascript","patch_set":9,"id":"7a740942_bd837255","line":55,"updated":"2015-12-11 19:37:12.000000000","message":"template: is an object with the following possible properties:\n\n\nAnd then putting surrounding each property with the {} is actually confusing.","commit_id":"e525215fa4329559a1b0a2b2be6b0f17e846e316"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"ffced4be5fa4cd6c40570badc8b558c3f6d9616c","unresolved":false,"context_lines":[{"line_number":129,"context_line":"   * }"},{"line_number":130,"context_line":"   *"},{"line_number":131,"context_line":"   * ```"},{"line_number":132,"context_line":"   * \u003cactions allowed-actions\u003d\"actions\" type\u003d\"row\" context-item\u003d\"image\"\u003e"},{"line_number":133,"context_line":"   * \u003c/actions\u003e"},{"line_number":134,"context_line":"   *"},{"line_number":135,"context_line":"   * ```"}],"source_content_type":"text/javascript","patch_set":9,"id":"7a740942_4cd5f4e2","line":132,"updated":"2015-12-12 00:46:48.000000000","message":"i am a little unsure about \"context-item\" vs item or \"action-item\".  I know \"action\" is repetitive (it is inside an Actions directive), but it takes less thought when I look at it vs context-item.\n\nItem is more directly correlated to action:\n\nhttps://github.com/openstack/horizon/blob/master/horizon/static/framework/widgets/action-list/action.directive.js#L76\n\nSo, my vote is item.","commit_id":"e525215fa4329559a1b0a2b2be6b0f17e846e316"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"dd26f372595e29d31807a36a7d9f11d1048acda3","unresolved":false,"context_lines":[{"line_number":51,"context_line":"   *   callback: \u0027callback for the action\u0027"},{"line_number":52,"context_line":"   *"},{"line_number":53,"context_line":"   *   template: is an object that can be any of"},{"line_number":54,"context_line":"   *   1. {url: \u0027full_path_to_template.html\u0027}"},{"line_number":55,"context_line":"   *      This specifies the location of the template for the action button."},{"line_number":56,"context_line":"   *      Use this for complete extensibility and control over what is rendered."},{"line_number":57,"context_line":"   *      The template will be responsible for binding the callback and styling."}],"source_content_type":"text/javascript","patch_set":10,"id":"7a740942_ff0eb93b","line":54,"updated":"2015-12-12 20:46:52.000000000","message":"I\u0027m sorry for the confusion here. In patchset 9, I actually meant the properties with {} on lines 56, 61, 72 were what I found confusing. Having what you had on line 49 - 53 made sense and was better.  :-S","commit_id":"5bd12d639bfa33d8b0757bd27626543b90e5f5bf"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"e2547b48fd2396c1f18bd605e7214e436407b511","unresolved":false,"context_lines":[{"line_number":51,"context_line":"   *   callback: \u0027callback for the action\u0027"},{"line_number":52,"context_line":"   *"},{"line_number":53,"context_line":"   *   template: is an object that can be any of"},{"line_number":54,"context_line":"   *   1. {url: \u0027full_path_to_template.html\u0027}"},{"line_number":55,"context_line":"   *      This specifies the location of the template for the action button."},{"line_number":56,"context_line":"   *      Use this for complete extensibility and control over what is rendered."},{"line_number":57,"context_line":"   *      The template will be responsible for binding the callback and styling."}],"source_content_type":"text/javascript","patch_set":10,"id":"7a740942_44d82b53","line":54,"in_reply_to":"7a740942_ff0eb93b","updated":"2015-12-14 16:34:02.000000000","message":"Done","commit_id":"5bd12d639bfa33d8b0757bd27626543b90e5f5bf"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"dd26f372595e29d31807a36a7d9f11d1048acda3","unresolved":false,"context_lines":[{"line_number":64,"context_line":"   *      3. \u0027create\u0027"},{"line_number":65,"context_line":"   *"},{"line_number":66,"context_line":"   *      `item` is optional and if provided will override the item provided"},{"line_number":67,"context_line":"   *      on the directive level. This will passed as parameter in the callback"},{"line_number":68,"context_line":"   *      of the action where applicable."},{"line_number":69,"context_line":"   *      The styling and binding of the callback is done by the template."},{"line_number":70,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":10,"id":"7a740942_df0add25","line":67,"updated":"2015-12-12 20:46:52.000000000","message":"Uber nit: \n\nThis will be passed as a parameter...\n\nmissing the \"be\" and \"a\" in the sentence above.\n\nSee line 73 below where you have it right.","commit_id":"5bd12d639bfa33d8b0757bd27626543b90e5f5bf"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"e2547b48fd2396c1f18bd605e7214e436407b511","unresolved":false,"context_lines":[{"line_number":64,"context_line":"   *      3. \u0027create\u0027"},{"line_number":65,"context_line":"   *"},{"line_number":66,"context_line":"   *      `item` is optional and if provided will override the item provided"},{"line_number":67,"context_line":"   *      on the directive level. This will passed as parameter in the callback"},{"line_number":68,"context_line":"   *      of the action where applicable."},{"line_number":69,"context_line":"   *      The styling and binding of the callback is done by the template."},{"line_number":70,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":10,"id":"7a740942_6418c71e","line":67,"in_reply_to":"7a740942_df0add25","updated":"2015-12-14 16:34:02.000000000","message":"Done","commit_id":"5bd12d639bfa33d8b0757bd27626543b90e5f5bf"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"dd26f372595e29d31807a36a7d9f11d1048acda3","unresolved":false,"context_lines":[{"line_number":81,"context_line":"   *   if permitted and is rejected if not."},{"line_number":82,"context_line":"   *"},{"line_number":83,"context_line":"   *   callback: is the method to call when the button is clicked."},{"line_number":84,"context_line":"   *   This method will called with the `item`."},{"line_number":85,"context_line":"   *   When using \u0027batch\u0027 type, `item` is not passed if using known type or text."},{"line_number":86,"context_line":"   *   When using \u0027row\u0027 type, \u0027item\u0027 is evaluated and always passed."},{"line_number":87,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":10,"id":"7a740942_9f00d503","line":84,"updated":"2015-12-12 20:46:52.000000000","message":"Uber nit:\n\n\"This method will be called\"\n\nmissing the \"be\"","commit_id":"5bd12d639bfa33d8b0757bd27626543b90e5f5bf"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"e2547b48fd2396c1f18bd605e7214e436407b511","unresolved":false,"context_lines":[{"line_number":81,"context_line":"   *   if permitted and is rejected if not."},{"line_number":82,"context_line":"   *"},{"line_number":83,"context_line":"   *   callback: is the method to call when the button is clicked."},{"line_number":84,"context_line":"   *   This method will called with the `item`."},{"line_number":85,"context_line":"   *   When using \u0027batch\u0027 type, `item` is not passed if using known type or text."},{"line_number":86,"context_line":"   *   When using \u0027row\u0027 type, \u0027item\u0027 is evaluated and always passed."},{"line_number":87,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":10,"id":"7a740942_84137300","line":84,"in_reply_to":"7a740942_9f00d503","updated":"2015-12-14 16:34:02.000000000","message":"Done","commit_id":"5bd12d639bfa33d8b0757bd27626543b90e5f5bf"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"991f8f7efbc5a6acd91e28f1a7b485d8ad22218d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"   * for `row` type, the variable is evaluated and passed as an argument"},{"line_number":45,"context_line":"   * when evaluating `allowedActions`."},{"line_number":46,"context_line":"   *"},{"line_number":47,"context_line":"   * @param {Array\u003cobject\u003e} allowedActions: actions allowed that can be displayed"},{"line_number":48,"context_line":"   * It\u0027s an array of objects each with the following properties:"},{"line_number":49,"context_line":"   * {"},{"line_number":50,"context_line":"   *   template: \u003ctemplate object - described later\u003e,"}],"source_content_type":"text/javascript","patch_set":12,"id":"5a710552_8a72717b","line":47,"updated":"2015-12-15 01:18:50.000000000","message":"Markup isn\u0027t consistent here. allowedActions has a colon, the others params don\u0027t have a colon.","commit_id":"d4eaad6f181bd26727787c62671e9f83f4b7bc9f"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"782c81c7c6ceba470f46b649d77df7b1f6c14deb","unresolved":false,"context_lines":[{"line_number":44,"context_line":"   * for `row` type, the variable is evaluated and passed as an argument"},{"line_number":45,"context_line":"   * when evaluating `allowedActions`."},{"line_number":46,"context_line":"   *"},{"line_number":47,"context_line":"   * @param {Array\u003cobject\u003e} allowedActions: actions allowed that can be displayed"},{"line_number":48,"context_line":"   * It\u0027s an array of objects each with the following properties:"},{"line_number":49,"context_line":"   * {"},{"line_number":50,"context_line":"   *   template: \u003ctemplate object - described later\u003e,"}],"source_content_type":"text/javascript","patch_set":12,"id":"5a710552_91bb80c4","line":47,"in_reply_to":"5a710552_8a72717b","updated":"2015-12-15 07:33:17.000000000","message":"Done","commit_id":"d4eaad6f181bd26727787c62671e9f83f4b7bc9f"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"991f8f7efbc5a6acd91e28f1a7b485d8ad22218d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"   *"},{"line_number":68,"context_line":"   *      `item` is optional and if provided will override the item provided"},{"line_number":69,"context_line":"   *      on the directive level. This will be passed as a parameter in the callback"},{"line_number":70,"context_line":"   *      of the action where applicable."},{"line_number":71,"context_line":"   *      The styling and binding of the callback is done by the template."},{"line_number":72,"context_line":"   *"},{"line_number":73,"context_line":"   *   3. text: \u0027text\u0027, item: \u0027item\u0027"}],"source_content_type":"text/javascript","patch_set":12,"id":"5a710552_efec6791","line":70,"updated":"2015-12-15 01:18:50.000000000","message":"There\u0027s no example showing the usage of this; it\u0027s not clear to me how it works, either. Is \"item\" an actual object, or the name of an object that is looked up in some scope? I tried to delve deeper into the action list implementation but frankly, it\u0027s beyond me right now :(","commit_id":"d4eaad6f181bd26727787c62671e9f83f4b7bc9f"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"782c81c7c6ceba470f46b649d77df7b1f6c14deb","unresolved":false,"context_lines":[{"line_number":67,"context_line":"   *"},{"line_number":68,"context_line":"   *      `item` is optional and if provided will override the item provided"},{"line_number":69,"context_line":"   *      on the directive level. This will be passed as a parameter in the callback"},{"line_number":70,"context_line":"   *      of the action where applicable."},{"line_number":71,"context_line":"   *      The styling and binding of the callback is done by the template."},{"line_number":72,"context_line":"   *"},{"line_number":73,"context_line":"   *   3. text: \u0027text\u0027, item: \u0027item\u0027"}],"source_content_type":"text/javascript","patch_set":12,"id":"5a710552_d1c10830","line":70,"in_reply_to":"5a710552_efec6791","updated":"2015-12-15 07:33:17.000000000","message":"I\u0027ve taken out this particular option as it added limited value but was causing complexity when using it.","commit_id":"d4eaad6f181bd26727787c62671e9f83f4b7bc9f"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"991f8f7efbc5a6acd91e28f1a7b485d8ad22218d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"   *   callback: is the method to call when the button is clicked."},{"line_number":87,"context_line":"   *   This method will be called with the `item`."},{"line_number":88,"context_line":"   *   When using \u0027batch\u0027 type, `item` is not passed if using known type or text."},{"line_number":89,"context_line":"   *   When using \u0027row\u0027 type, \u0027item\u0027 is evaluated and always passed."},{"line_number":90,"context_line":"   *"},{"line_number":91,"context_line":"   * @restrict E"},{"line_number":92,"context_line":"   * @scope"}],"source_content_type":"text/javascript","patch_set":12,"id":"5a710552_4a5569c4","line":89,"updated":"2015-12-15 01:18:50.000000000","message":"Markup isn\u0027t consistent here. Either use backticks or single quotes, make a call :-)","commit_id":"d4eaad6f181bd26727787c62671e9f83f4b7bc9f"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"782c81c7c6ceba470f46b649d77df7b1f6c14deb","unresolved":false,"context_lines":[{"line_number":86,"context_line":"   *   callback: is the method to call when the button is clicked."},{"line_number":87,"context_line":"   *   This method will be called with the `item`."},{"line_number":88,"context_line":"   *   When using \u0027batch\u0027 type, `item` is not passed if using known type or text."},{"line_number":89,"context_line":"   *   When using \u0027row\u0027 type, \u0027item\u0027 is evaluated and always passed."},{"line_number":90,"context_line":"   *"},{"line_number":91,"context_line":"   * @restrict E"},{"line_number":92,"context_line":"   * @scope"}],"source_content_type":"text/javascript","patch_set":12,"id":"5a710552_91e2a0d4","line":89,"in_reply_to":"5a710552_4a5569c4","updated":"2015-12-15 07:33:17.000000000","message":"Done","commit_id":"d4eaad6f181bd26727787c62671e9f83f4b7bc9f"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"d04112284df5e141f2883efa5af88b6d8bebcaed","unresolved":false,"context_lines":[{"line_number":48,"context_line":"   *"},{"line_number":49,"context_line":"   * @param {function} allowed"},{"line_number":50,"context_line":"   * Returns an array of actions that can be performed on the item(s)."},{"line_number":51,"context_line":"   * When using \u0027row\u0027 type, the function will be provided with the \u0027item\u0027 evaluated."},{"line_number":52,"context_line":"   * When using \u0027batch\u0027 type, no arguments are provided."},{"line_number":53,"context_line":"   *"},{"line_number":54,"context_line":"   * This is an array that should contain objects with the following properties:"}],"source_content_type":"text/javascript","patch_set":16,"id":"5a710552_622ff7f6","line":51,"updated":"2015-12-15 20:29:04.000000000","message":"When using \u0027row\u0027 type, the current \u0027item\u0027 will be passed to the function.\n\n ^ might read a little easier.","commit_id":"f43c24686909791898d7d032c059ce7689a5da5b"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"7693666c9bdb788f894ae2293c76e8812e4d2637","unresolved":false,"context_lines":[{"line_number":48,"context_line":"   *"},{"line_number":49,"context_line":"   * @param {function} allowed"},{"line_number":50,"context_line":"   * Returns an array of actions that can be performed on the item(s)."},{"line_number":51,"context_line":"   * When using \u0027row\u0027 type, the function will be provided with the \u0027item\u0027 evaluated."},{"line_number":52,"context_line":"   * When using \u0027batch\u0027 type, no arguments are provided."},{"line_number":53,"context_line":"   *"},{"line_number":54,"context_line":"   * This is an array that should contain objects with the following properties:"}],"source_content_type":"text/javascript","patch_set":16,"id":"5a710552_73d7cabf","line":51,"in_reply_to":"5a710552_622ff7f6","updated":"2015-12-15 21:52:51.000000000","message":"Done","commit_id":"f43c24686909791898d7d032c059ce7689a5da5b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"d04112284df5e141f2883efa5af88b6d8bebcaed","unresolved":false,"context_lines":[{"line_number":76,"context_line":"   *   3. text: \u0027text\u0027, actionClasses: \u0027custom-classes\u0027"},{"line_number":77,"context_line":"   *      This creates a button with the given text."},{"line_number":78,"context_line":"   *      For custom styling of the button, `actionClasses` can be optionally included."},{"line_number":79,"context_line":"   *"},{"line_number":80,"context_line":"   *   permissions: is expected to be a promise that resolves"},{"line_number":81,"context_line":"   *   if the action is permitted and is rejected if not. If there are multiple promises that"},{"line_number":82,"context_line":"   *   need to be resolved, you can $q.all to combine multiple promises into a single promise."}],"source_content_type":"text/javascript","patch_set":16,"id":"5a710552_424bdb87","line":79,"updated":"2015-12-15 20:29:04.000000000","message":"i\u0027d vote for changing this to \u0027allowed\u0027.  Permissions actually is different in the django code. It represents a string of some permissions that some utility code evaluates it.\n\nhttps://github.com/openstack/horizon/blob/master/horizon/base.py#L240-L245\n\nThis more closely aligns to the allowed base function in the python django code.\n\nhttps://github.com/openstack/horizon/blob/master/horizon/base.py#L131\n\n\nSee here for examples of permissions:\n\nhttps://github.com/openstack/horizon/search?utf8\u003d%E2%9C%93\u0026q\u003dpermissions\n\nI\u0027d say this could be a different patch since this patch is supposed be about items.  However, you are already modifying a bit more than that.","commit_id":"f43c24686909791898d7d032c059ce7689a5da5b"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"7693666c9bdb788f894ae2293c76e8812e4d2637","unresolved":false,"context_lines":[{"line_number":76,"context_line":"   *   3. text: \u0027text\u0027, actionClasses: \u0027custom-classes\u0027"},{"line_number":77,"context_line":"   *      This creates a button with the given text."},{"line_number":78,"context_line":"   *      For custom styling of the button, `actionClasses` can be optionally included."},{"line_number":79,"context_line":"   *"},{"line_number":80,"context_line":"   *   permissions: is expected to be a promise that resolves"},{"line_number":81,"context_line":"   *   if the action is permitted and is rejected if not. If there are multiple promises that"},{"line_number":82,"context_line":"   *   need to be resolved, you can $q.all to combine multiple promises into a single promise."}],"source_content_type":"text/javascript","patch_set":16,"id":"5a710552_53788ec4","line":79,"in_reply_to":"5a710552_424bdb87","updated":"2015-12-15 21:52:51.000000000","message":"I\u0027d want to make that in a different patch as that\u0027ll trickle a lot of merge conflicts to patch in the tree below.\n\nAlso, the directive uses \"allowed\" on the attribute level so it might be confusing to use the same name.\n\nIf the idea to move the permission check from the row-actions service to the actual service performing the action is fine, then it make more sense to combine both callback and permissions to a singular \"service\" call which exposes \"check\" and \"perform\" methods.\n\nI\u0027ll create a demo patch with the idea.","commit_id":"f43c24686909791898d7d032c059ce7689a5da5b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"9164e31dcc89a5f37648893b08b30e79c398ef52","unresolved":false,"context_lines":[{"line_number":76,"context_line":"   *   3. text: \u0027text\u0027, actionClasses: \u0027custom-classes\u0027"},{"line_number":77,"context_line":"   *      This creates a button with the given text."},{"line_number":78,"context_line":"   *      For custom styling of the button, `actionClasses` can be optionally included."},{"line_number":79,"context_line":"   *"},{"line_number":80,"context_line":"   *   permissions: is expected to be a promise that resolves"},{"line_number":81,"context_line":"   *   if the action is permitted and is rejected if not. If there are multiple promises that"},{"line_number":82,"context_line":"   *   need to be resolved, you can $q.all to combine multiple promises into a single promise."}],"source_content_type":"text/javascript","patch_set":16,"id":"5a710552_27ba580b","line":79,"in_reply_to":"5a710552_53788ec4","updated":"2015-12-15 23:05:15.000000000","message":"Ok, that makes sense. I think we should just wrap up this change in this patch.","commit_id":"f43c24686909791898d7d032c059ce7689a5da5b"}],"horizon/static/framework/widgets/action-list/actions.row.mock.html":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"ce4eb90076dae917711d39c3bf2450962fb38012","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cactions allowed-actions\u003d\"actions\" type\u003d\"row\" context-item\u003d\"rowItem\"\u003e"},{"line_number":2,"context_line":"\u003c/actions\u003e"}],"source_content_type":"text/html","patch_set":11,"id":"5a710552_a70e96e3","line":1,"updated":"2015-12-14 19:15:36.000000000","message":"Shouldn\u0027t this be item and not context-item?","commit_id":"724c04ec5e5b6336dd8cb8d061e53c6a22776e28"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"942e020e938f6ac492621dbd67dbc1cc8adc5dae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cactions allowed-actions\u003d\"actions\" type\u003d\"row\" context-item\u003d\"rowItem\"\u003e"},{"line_number":2,"context_line":"\u003c/actions\u003e"}],"source_content_type":"text/html","patch_set":11,"id":"5a710552_624bbc2c","line":1,"in_reply_to":"5a710552_a70e96e3","updated":"2015-12-14 19:32:36.000000000","message":"Done. Fixed the tests as well.\nMissed it as the callback and assertions were broken.","commit_id":"724c04ec5e5b6336dd8cb8d061e53c6a22776e28"}],"horizon/static/framework/widgets/action-list/actions.service.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"71c44048249be69a00882c900cd3e99222e6d061","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        return defered.promise;"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        function onTemplateGet(response) {"},{"line_number":192,"context_line":"          var item \u003d action.template.item || contextItem;"},{"line_number":193,"context_line":"          var template \u003d response.data"},{"line_number":194,"context_line":"                .replace(\u0027$action-classes$\u0027, action.template.actionClasses || \u0027\u0027)"},{"line_number":195,"context_line":"                .replace(\u0027$text$\u0027, action.template.text)"}],"source_content_type":"text/javascript","patch_set":4,"id":"7a740942_af99ad7a","line":192,"updated":"2015-12-09 00:03:19.000000000","message":"Should the order be swap here (contextItem first)?","commit_id":"8d4e67201ce23d2b11588566afaddc2f862e3b3a"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"106f5383bfd1f9a5a0cd97d95f9abb99e653c9ac","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        return defered.promise;"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        function onTemplateGet(response) {"},{"line_number":192,"context_line":"          var item \u003d action.template.item || contextItem;"},{"line_number":193,"context_line":"          var template \u003d response.data"},{"line_number":194,"context_line":"                .replace(\u0027$action-classes$\u0027, action.template.actionClasses || \u0027\u0027)"},{"line_number":195,"context_line":"                .replace(\u0027$text$\u0027, action.template.text)"}],"source_content_type":"text/javascript","patch_set":4,"id":"7a740942_c1a16d95","line":192,"in_reply_to":"7a740942_af99ad7a","updated":"2015-12-09 00:13:39.000000000","message":"Not really. If you don\u0027t want the action working on the default item, then there\u0027ll be no way to change that.","commit_id":"8d4e67201ce23d2b11588566afaddc2f862e3b3a"}]}
