)]}'
{"openstack_dashboard/api/rest/swift.py":[{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"18e29b1a1bd84862c90c4d4f7fddea292337b1ed","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":12,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":13,"context_line":"# limitations under the License."},{"line_number":14,"context_line":"\"\"\"API for the glance service."},{"line_number":15,"context_line":"\"\"\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from six import StringIO"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a7b0d38_7e3a4238","line":14,"range":{"start_line":14,"start_character":29,"end_line":14,"end_character":30},"updated":"2015-12-23 19:01:30.000000000","message":"Should be \"swift\"","commit_id":"e33d8376a60d08179d192e970cc4a5a2f34ce5c8"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"51b1e36bdc95ee3363607117c14fbeaa62397d4d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":12,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":13,"context_line":"# limitations under the License."},{"line_number":14,"context_line":"\"\"\"API for the glance service."},{"line_number":15,"context_line":"\"\"\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from six import StringIO"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_75f68ffa","line":14,"in_reply_to":"1a7b0d38_7e3a4238","updated":"2016-01-05 04:45:42.000000000","message":"Heh. Fixed.","commit_id":"e33d8376a60d08179d192e970cc4a5a2f34ce5c8"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"18e29b1a1bd84862c90c4d4f7fddea292337b1ed","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"CLIENT_KEYWORDS \u003d {"},{"line_number":28,"context_line":"    \u0027resource_type\u0027, \u0027marker\u0027, \u0027sort_dir\u0027, \u0027sort_key\u0027, \u0027paginate\u0027"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"@urls.register"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a7b0d38_7ed6c2c6","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":1},"updated":"2015-12-23 19:01:30.000000000","message":"This is unused.","commit_id":"e33d8376a60d08179d192e970cc4a5a2f34ce5c8"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"51b1e36bdc95ee3363607117c14fbeaa62397d4d","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"CLIENT_KEYWORDS \u003d {"},{"line_number":28,"context_line":"    \u0027resource_type\u0027, \u0027marker\u0027, \u0027sort_dir\u0027, \u0027sort_key\u0027, \u0027paginate\u0027"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"@urls.register"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_15e07328","line":29,"in_reply_to":"1a7b0d38_7ed6c2c6","updated":"2016-01-05 04:45:42.000000000","message":"Done","commit_id":"e33d8376a60d08179d192e970cc4a5a2f34ce5c8"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"18e29b1a1bd84862c90c4d4f7fddea292337b1ed","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    @rest_utils.ajax()"},{"line_number":174,"context_line":"    def delete(self, request, container, object_name):"},{"line_number":175,"context_line":"        api.swift.swift_delete_object(request, container, object_name)"},{"line_number":176,"context_line":"        return \u0027{name} deleted\u0027.format(name\u003dobject_name)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    @rest_utils.ajax()"},{"line_number":179,"context_line":"    def get(self, request, container, object_name):"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a7b0d38_7e5fa272","line":176,"range":{"start_line":176,"start_character":55,"end_line":176,"end_character":56},"updated":"2015-12-23 19:01:30.000000000","message":"Should not return. A status code of 204 is fine for a DELETE call. Same as you\u0027ve got above for the Container DELETE Request","commit_id":"e33d8376a60d08179d192e970cc4a5a2f34ce5c8"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"51b1e36bdc95ee3363607117c14fbeaa62397d4d","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    @rest_utils.ajax()"},{"line_number":174,"context_line":"    def delete(self, request, container, object_name):"},{"line_number":175,"context_line":"        api.swift.swift_delete_object(request, container, object_name)"},{"line_number":176,"context_line":"        return \u0027{name} deleted\u0027.format(name\u003dobject_name)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    @rest_utils.ajax()"},{"line_number":179,"context_line":"    def get(self, request, container, object_name):"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_55f10b00","line":176,"in_reply_to":"1a7b0d38_7e5fa272","updated":"2016-01-05 04:45:42.000000000","message":"Yep, good catch.","commit_id":"e33d8376a60d08179d192e970cc4a5a2f34ce5c8"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"4f9c68a16666543a22aafd8c8c13512f58012bff","unresolved":false,"context_lines":[{"line_number":14,"context_line":"\"\"\"API for the swift service."},{"line_number":15,"context_line":"\"\"\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from six import StringIO"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from django.core.files.uploadedfile import InMemoryUploadedFile"},{"line_number":20,"context_line":"from django.views import generic"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a68dd71_20cb1274","line":17,"updated":"2016-01-22 06:32:38.000000000","message":"(nit) could be same group as django import, they are both third party imports","commit_id":"147d74e6d17819736f73c20ac2c942723816cc82"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"f4651f73191db267c36df7bab95b2118f34536ac","unresolved":false,"context_lines":[{"line_number":14,"context_line":"\"\"\"API for the swift service."},{"line_number":15,"context_line":"\"\"\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from six import StringIO"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from django.core.files.uploadedfile import InMemoryUploadedFile"},{"line_number":20,"context_line":"from django.views import generic"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a68dd71_5f0b337d","line":17,"in_reply_to":"9a68dd71_20cb1274","updated":"2016-01-25 05:02:04.000000000","message":"Done","commit_id":"147d74e6d17819736f73c20ac2c942723816cc82"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"4f9c68a16666543a22aafd8c8c13512f58012bff","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @rest_utils.ajax()"},{"line_number":34,"context_line":"    def get(self, request):"},{"line_number":35,"context_line":"        \"\"\"Get active glance version."},{"line_number":36,"context_line":"        \"\"\""},{"line_number":37,"context_line":"        capabilities \u003d api.swift.swift_get_capabilities(request)"},{"line_number":38,"context_line":"        return {\u0027info\u0027: capabilities}"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a68dd71_60afca94","line":35,"range":{"start_line":35,"start_character":22,"end_line":35,"end_character":28},"updated":"2016-01-22 06:32:38.000000000","message":"swift","commit_id":"147d74e6d17819736f73c20ac2c942723816cc82"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"f4651f73191db267c36df7bab95b2118f34536ac","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @rest_utils.ajax()"},{"line_number":34,"context_line":"    def get(self, request):"},{"line_number":35,"context_line":"        \"\"\"Get active glance version."},{"line_number":36,"context_line":"        \"\"\""},{"line_number":37,"context_line":"        capabilities \u003d api.swift.swift_get_capabilities(request)"},{"line_number":38,"context_line":"        return {\u0027info\u0027: capabilities}"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a68dd71_7f0e378d","line":35,"in_reply_to":"9a68dd71_60afca94","updated":"2016-01-25 05:02:04.000000000","message":"Done","commit_id":"147d74e6d17819736f73c20ac2c942723816cc82"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"4f9c68a16666543a22aafd8c8c13512f58012bff","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"            TODO(neillc): Add pagination"},{"line_number":52,"context_line":"        \"\"\""},{"line_number":53,"context_line":"        containers \u003d api.swift.swift_get_containers(request)[0]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        result \u003d []"},{"line_number":56,"context_line":"        for container in containers:"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a68dd71_007e0e19","line":53,"updated":"2016-01-22 06:32:38.000000000","message":"suggestion: instead of accessing index directly it would be more readable with tuple unpacking\n\ncontainers, has_more \u003d api.swift.swift_get_containers(request)","commit_id":"147d74e6d17819736f73c20ac2c942723816cc82"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"f4651f73191db267c36df7bab95b2118f34536ac","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"            TODO(neillc): Add pagination"},{"line_number":52,"context_line":"        \"\"\""},{"line_number":53,"context_line":"        containers \u003d api.swift.swift_get_containers(request)[0]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        result \u003d []"},{"line_number":56,"context_line":"        for container in containers:"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a68dd71_bfcd8f32","line":53,"in_reply_to":"9a68dd71_007e0e19","updated":"2016-01-25 05:02:04.000000000","message":"Done. Also I\u0027ve removed the additional iteration over the result set here - this should be done as the client requires, not for all containers by default.","commit_id":"147d74e6d17819736f73c20ac2c942723816cc82"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"4f9c68a16666543a22aafd8c8c13512f58012bff","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            with_data\u003dFalse"},{"line_number":179,"context_line":"        ).to_dict()"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        # return {"},{"line_number":182,"context_line":"        #     \u0027name\u0027: result.name,"},{"line_number":183,"context_line":"        #     \u0027hash\u0027: result.etag,"},{"line_number":184,"context_line":"        #     \u0027content_type\u0027: result.content_type,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a68dd71_83bbe8e4","line":181,"updated":"2016-01-22 06:32:38.000000000","message":"this can be dropped","commit_id":"147d74e6d17819736f73c20ac2c942723816cc82"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"f4651f73191db267c36df7bab95b2118f34536ac","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            with_data\u003dFalse"},{"line_number":179,"context_line":"        ).to_dict()"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        # return {"},{"line_number":182,"context_line":"        #     \u0027name\u0027: result.name,"},{"line_number":183,"context_line":"        #     \u0027hash\u0027: result.etag,"},{"line_number":184,"context_line":"        #     \u0027content_type\u0027: result.content_type,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a68dd71_9ff1ab6d","line":181,"in_reply_to":"9a68dd71_83bbe8e4","updated":"2016-01-25 05:02:04.000000000","message":"Done","commit_id":"147d74e6d17819736f73c20ac2c942723816cc82"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"45e18ed04ff67ddb24f816876ebb6c0a6770c159","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @rest_utils.ajax()"},{"line_number":33,"context_line":"    def get(self, request):"},{"line_number":34,"context_line":"        \"\"\"Get active swift version."},{"line_number":35,"context_line":"        \"\"\""},{"line_number":36,"context_line":"        capabilities \u003d api.swift.swift_get_capabilities(request)"},{"line_number":37,"context_line":"        return {\u0027info\u0027: capabilities}"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a5de9d1_40bbeb72","line":34,"updated":"2016-01-28 02:11:02.000000000","message":"Nit this isn\u0027t really getting just the active version.  It is returning the capabilities which are more than version)","commit_id":"ddda9ff0d55a7f1e4baa70e0a95497d31dcaa521"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"bc61477b177afebcbe4a3c270942a7a718efc3cb","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @rest_utils.ajax()"},{"line_number":33,"context_line":"    def get(self, request):"},{"line_number":34,"context_line":"        \"\"\"Get active swift version."},{"line_number":35,"context_line":"        \"\"\""},{"line_number":36,"context_line":"        capabilities \u003d api.swift.swift_get_capabilities(request)"},{"line_number":37,"context_line":"        return {\u0027info\u0027: capabilities}"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a5de9d1_de9a5b14","line":34,"in_reply_to":"7a5de9d1_40bbeb72","updated":"2016-01-28 06:34:02.000000000","message":"Done","commit_id":"ddda9ff0d55a7f1e4baa70e0a95497d31dcaa521"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"b701660e31929bab33a90c589c390c49c7cf5aa1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015, Rackspace, US, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":30,"id":"dae33548_413932d8","line":1,"updated":"2016-02-19 00:54:59.000000000","message":"nit (non-blocker) 2016, but heck, i guess it was started in 2015.","commit_id":"717ca09781d9fef2a5bf414796a6ff99166d2eb8"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a94f5ab2b75dc02a77ea8cb9b97a05a782a2b8c8","unresolved":false,"context_lines":[{"line_number":27,"context_line":"class Info(generic.View):"},{"line_number":28,"context_line":"    \"\"\"API for information about the Swift installation."},{"line_number":29,"context_line":"    \"\"\""},{"line_number":30,"context_line":"    url_regex \u003d r\u0027swift/info/$\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @rest_utils.ajax()"},{"line_number":33,"context_line":"    def get(self, request):"}],"source_content_type":"text/x-python","patch_set":30,"id":"bae84128_579bee17","line":30,"updated":"2016-02-23 22:45:32.000000000","message":"nit: keep it consistent with API call?\n\nurl_regex \u003d r\u0027swift/capabilities/$\u0027","commit_id":"717ca09781d9fef2a5bf414796a6ff99166d2eb8"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"474fbf2b1560cc87bc481d350310ac44073ee59e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"class Info(generic.View):"},{"line_number":28,"context_line":"    \"\"\"API for information about the Swift installation."},{"line_number":29,"context_line":"    \"\"\""},{"line_number":30,"context_line":"    url_regex \u003d r\u0027swift/info/$\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @rest_utils.ajax()"},{"line_number":33,"context_line":"    def get(self, request):"}],"source_content_type":"text/x-python","patch_set":30,"id":"bae84128_2669a226","line":30,"in_reply_to":"bae84128_579bee17","updated":"2016-02-24 18:47:39.000000000","message":"I\u0027m actually keeping it consistent with the swift endpoint, which is /info :-)","commit_id":"717ca09781d9fef2a5bf414796a6ff99166d2eb8"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a94f5ab2b75dc02a77ea8cb9b97a05a782a2b8c8","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    url_regex \u003d r\u0027swift/containers/(?P\u003ccontainer\u003e[^/]+)/metadata/$\u0027"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @rest_utils.ajax()"},{"line_number":65,"context_line":"    def get(self, request, container):"},{"line_number":66,"context_line":"        \"\"\"Get the container details"},{"line_number":67,"context_line":"        \"\"\""},{"line_number":68,"context_line":"        return api.swift.swift_get_container(request, container).to_dict()"}],"source_content_type":"text/x-python","patch_set":30,"id":"bae84128_a2f5daed","line":65,"updated":"2016-02-23 22:45:32.000000000","message":"pass in params and document\n\nhttp://docs.openstack.org/developer/python-swiftclient/swiftclient.html#swiftclient.client.get_container","commit_id":"717ca09781d9fef2a5bf414796a6ff99166d2eb8"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"474fbf2b1560cc87bc481d350310ac44073ee59e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    url_regex \u003d r\u0027swift/containers/(?P\u003ccontainer\u003e[^/]+)/metadata/$\u0027"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @rest_utils.ajax()"},{"line_number":65,"context_line":"    def get(self, request, container):"},{"line_number":66,"context_line":"        \"\"\"Get the container details"},{"line_number":67,"context_line":"        \"\"\""},{"line_number":68,"context_line":"        return api.swift.swift_get_container(request, container).to_dict()"}],"source_content_type":"text/x-python","patch_set":30,"id":"bae84128_e6d4dabe","line":65,"in_reply_to":"bae84128_a2f5daed","updated":"2016-02-24 18:47:39.000000000","message":"This call is actually different to the get_container call you refer to (I know, it\u0027s confusing) which retrieves the objects listing for a container. This call here just fetches the metadata for the container.","commit_id":"717ca09781d9fef2a5bf414796a6ff99166d2eb8"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"61657b8b31fd528efea257889634e70233ad9c57","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        api.swift.swift_delete_container(request, container)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @rest_utils.ajax(data_required\u003dTrue)"},{"line_number":87,"context_line":"    def put(self, request, container):"},{"line_number":88,"context_line":"        metadata \u003d {\u0027is_public\u0027: request.DATA[\u0027is_public\u0027]}"},{"line_number":89,"context_line":"        api.swift.swift_update_container(request, container, metadata\u003dmetadata)"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"bae84128_95d084f9","line":87,"updated":"2016-02-24 22:43:49.000000000","message":"I wonder do we really to implement PUT method? Looking at other REST APIs, seems like POST is enough for us.","commit_id":"7931b38b181bdc1a1e1fec8b26e54144c1220f8e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"61657b8b31fd528efea257889634e70233ad9c57","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                object_name"},{"line_number":151,"context_line":"            )"},{"line_number":152,"context_line":"        else:"},{"line_number":153,"context_line":"            object_file \u003d InMemoryUploadedFile("},{"line_number":154,"context_line":"                StringIO(request.body),"},{"line_number":155,"context_line":"                object_name,"},{"line_number":156,"context_line":"                object_name,"}],"source_content_type":"text/x-python","patch_set":31,"id":"bae84128_f53ab097","line":153,"updated":"2016-02-24 22:43:49.000000000","message":"Given that files of different sizes are going to be uploaded into Swift, we\u0027re gonna overflow server memory with that (see https://review.openstack.org/#/c/161204/). Btw, Django uses an internal file size threshold for choosing between InMemoryUploadedFile and TemporaryUploadedFile. And looking at https://github.com/openstack/python-swiftclient/blob/master/swiftclient/client.py#L342 we can avoid passing all the data at once by using generators.","commit_id":"7931b38b181bdc1a1e1fec8b26e54144c1220f8e"}],"openstack_dashboard/static/app/core/openstack-service-api/swift.service.js":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"4f9c68a16666543a22aafd8c8c13512f58012bff","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    function getContainer(container) {"},{"line_number":78,"context_line":"      return apiService.get(\u0027/api/swift/containers/\u0027 + container + \u0027/\u0027)"},{"line_number":79,"context_line":"        .error(function() {"},{"line_number":80,"context_line":"          toastService.add(\u0027error\u0027, gettext(\u0027Unable to get the container details for \"\u0027 +"},{"line_number":81,"context_line":"            container + \u0027\".\u0027));"}],"source_content_type":"text/javascript","patch_set":18,"id":"9a68dd71_439ad064","line":78,"range":{"start_line":78,"start_character":55,"end_line":78,"end_character":64},"updated":"2016-01-22 06:32:38.000000000","message":"does this need to be escaped? same comment applies to the rest of the file","commit_id":"147d74e6d17819736f73c20ac2c942723816cc82"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"f4651f73191db267c36df7bab95b2118f34536ac","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    function getContainer(container) {"},{"line_number":78,"context_line":"      return apiService.get(\u0027/api/swift/containers/\u0027 + container + \u0027/\u0027)"},{"line_number":79,"context_line":"        .error(function() {"},{"line_number":80,"context_line":"          toastService.add(\u0027error\u0027, gettext(\u0027Unable to get the container details for \"\u0027 +"},{"line_number":81,"context_line":"            container + \u0027\".\u0027));"}],"source_content_type":"text/javascript","patch_set":18,"id":"9a68dd71_5fe7b3ab","line":78,"in_reply_to":"9a68dd71_439ad064","updated":"2016-01-25 05:02:04.000000000","message":"No, special characters are escaped by the underlying HTTP call mechanisms.","commit_id":"147d74e6d17819736f73c20ac2c942723816cc82"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"4f9c68a16666543a22aafd8c8c13512f58012bff","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    function getContainer(container) {"},{"line_number":78,"context_line":"      return apiService.get(\u0027/api/swift/containers/\u0027 + container + \u0027/\u0027)"},{"line_number":79,"context_line":"        .error(function() {"},{"line_number":80,"context_line":"          toastService.add(\u0027error\u0027, gettext(\u0027Unable to get the container details for \"\u0027 +"},{"line_number":81,"context_line":"            container + \u0027\".\u0027));"},{"line_number":82,"context_line":"        });"},{"line_number":83,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":18,"id":"9a68dd71_8305287b","line":80,"range":{"start_line":80,"start_character":45,"end_line":80,"end_character":51},"updated":"2016-01-22 06:32:38.000000000","message":"this won\u0027t be translatable..\n\nit should be:\n\u0027Unable to get the container details for %{container}\u0027.\n\nand use interpolate function to apply the container value.","commit_id":"147d74e6d17819736f73c20ac2c942723816cc82"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"f4651f73191db267c36df7bab95b2118f34536ac","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    function getContainer(container) {"},{"line_number":78,"context_line":"      return apiService.get(\u0027/api/swift/containers/\u0027 + container + \u0027/\u0027)"},{"line_number":79,"context_line":"        .error(function() {"},{"line_number":80,"context_line":"          toastService.add(\u0027error\u0027, gettext(\u0027Unable to get the container details for \"\u0027 +"},{"line_number":81,"context_line":"            container + \u0027\".\u0027));"},{"line_number":82,"context_line":"        });"},{"line_number":83,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":18,"id":"9a68dd71_39b4577e","line":80,"in_reply_to":"9a68dd71_8305287b","updated":"2016-01-25 05:02:04.000000000","message":"None of the other APIs have such things interpolated into their errors, so I\u0027ve removed that entirely here also.","commit_id":"147d74e6d17819736f73c20ac2c942723816cc82"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"4f9c68a16666543a22aafd8c8c13512f58012bff","unresolved":false,"context_lines":[{"line_number":91,"context_line":"      return apiService.post(\u0027/api/swift/containers/\u0027 + container + \u0027/\u0027, data)"},{"line_number":92,"context_line":"        .error(function () {"},{"line_number":93,"context_line":"          toastService.add(\u0027error\u0027, gettext("},{"line_number":94,"context_line":"            \u0027Unable to create the container \"\u0027 + container + \u0027\".\u0027"},{"line_number":95,"context_line":"            )"},{"line_number":96,"context_line":"          );"},{"line_number":97,"context_line":"        });"}],"source_content_type":"text/javascript","patch_set":18,"id":"9a68dd71_03fa9875","line":94,"updated":"2016-01-22 06:32:38.000000000","message":"same here, translation issue..\n\nsame comment for the rest of the messages.","commit_id":"147d74e6d17819736f73c20ac2c942723816cc82"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"f4651f73191db267c36df7bab95b2118f34536ac","unresolved":false,"context_lines":[{"line_number":91,"context_line":"      return apiService.post(\u0027/api/swift/containers/\u0027 + container + \u0027/\u0027, data)"},{"line_number":92,"context_line":"        .error(function () {"},{"line_number":93,"context_line":"          toastService.add(\u0027error\u0027, gettext("},{"line_number":94,"context_line":"            \u0027Unable to create the container \"\u0027 + container + \u0027\".\u0027"},{"line_number":95,"context_line":"            )"},{"line_number":96,"context_line":"          );"},{"line_number":97,"context_line":"        });"}],"source_content_type":"text/javascript","patch_set":18,"id":"9a68dd71_59afcb29","line":94,"in_reply_to":"9a68dd71_03fa9875","updated":"2016-01-25 05:02:04.000000000","message":"Done","commit_id":"147d74e6d17819736f73c20ac2c942723816cc82"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"b701660e31929bab33a90c589c390c49c7cf5aa1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      getObjectURL: getObjectURL,"},{"line_number":45,"context_line":"      getInfo: getInfo,"},{"line_number":46,"context_line":"      createFolder: createFolder,"},{"line_number":47,"context_line":"      copyObject: copyObject"},{"line_number":48,"context_line":"    };"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    /**"}],"source_content_type":"text/javascript","patch_set":30,"id":"dae33548_67e1e69a","line":47,"updated":"2016-02-19 00:54:59.000000000","message":"nit: alphabetize on first patch?","commit_id":"717ca09781d9fef2a5bf414796a6ff99166d2eb8"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"474fbf2b1560cc87bc481d350310ac44073ee59e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      getObjectURL: getObjectURL,"},{"line_number":45,"context_line":"      getInfo: getInfo,"},{"line_number":46,"context_line":"      createFolder: createFolder,"},{"line_number":47,"context_line":"      copyObject: copyObject"},{"line_number":48,"context_line":"    };"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    /**"}],"source_content_type":"text/javascript","patch_set":30,"id":"bae84128_3478a82b","line":47,"in_reply_to":"dae33548_67e1e69a","updated":"2016-02-24 18:47:39.000000000","message":"Done","commit_id":"717ca09781d9fef2a5bf414796a6ff99166d2eb8"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"b701660e31929bab33a90c589c390c49c7cf5aa1","unresolved":false,"context_lines":[{"line_number":77,"context_line":"          toastService.add(\u0027error\u0027, gettext(\u0027Unable to get the Swift container listing.\u0027));"},{"line_number":78,"context_line":"        });"},{"line_number":79,"context_line":"    }"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    function getContainer(container) {"},{"line_number":82,"context_line":"      return apiService.get(\u0027/api/swift/containers/\u0027 + container + \u0027/metadata/\u0027)"},{"line_number":83,"context_line":"        .error(function() {"}],"source_content_type":"text/javascript","patch_set":30,"id":"dae33548_07e73aad","line":80,"updated":"2016-02-19 00:54:59.000000000","message":"docs?","commit_id":"717ca09781d9fef2a5bf414796a6ff99166d2eb8"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"474fbf2b1560cc87bc481d350310ac44073ee59e","unresolved":false,"context_lines":[{"line_number":77,"context_line":"          toastService.add(\u0027error\u0027, gettext(\u0027Unable to get the Swift container listing.\u0027));"},{"line_number":78,"context_line":"        });"},{"line_number":79,"context_line":"    }"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    function getContainer(container) {"},{"line_number":82,"context_line":"      return apiService.get(\u0027/api/swift/containers/\u0027 + container + \u0027/metadata/\u0027)"},{"line_number":83,"context_line":"        .error(function() {"}],"source_content_type":"text/javascript","patch_set":30,"id":"bae84128_af9e25b6","line":80,"in_reply_to":"dae33548_07e73aad","updated":"2016-02-24 18:47:39.000000000","message":"Done","commit_id":"717ca09781d9fef2a5bf414796a6ff99166d2eb8"}],"openstack_dashboard/test/api_tests/swift_rest_tests.py":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a94f5ab2b75dc02a77ea8cb9b97a05a782a2b8c8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014, Rackspace, US, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":30,"id":"bae84128_77a432b9","line":1,"updated":"2016-02-23 22:45:32.000000000","message":"2016*","commit_id":"717ca09781d9fef2a5bf414796a6ff99166d2eb8"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"474fbf2b1560cc87bc481d350310ac44073ee59e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014, Rackspace, US, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":30,"id":"bae84128_147be47c","line":1,"in_reply_to":"bae84128_77a432b9","updated":"2016-02-24 18:47:39.000000000","message":"Done","commit_id":"717ca09781d9fef2a5bf414796a6ff99166d2eb8"}],"openstack_dashboard/test/helpers.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"4f9c68a16666543a22aafd8c8c13512f58012bff","unresolved":false,"context_lines":[{"line_number":628,"context_line":"                    kwargs[key] \u003d copied"},{"line_number":629,"context_line":"        super(update_settings, self).__init__(**kwargs)"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"def mock_obj_to_dict(r):"},{"line_number":633,"context_line":"    return mock.Mock(**{\u0027to_dict.return_value\u0027: r})"},{"line_number":634,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"9a68dd71_233c7c2e","line":631,"updated":"2016-01-22 06:32:38.000000000","message":"nice move!","commit_id":"147d74e6d17819736f73c20ac2c942723816cc82"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"f4651f73191db267c36df7bab95b2118f34536ac","unresolved":false,"context_lines":[{"line_number":628,"context_line":"                    kwargs[key] \u003d copied"},{"line_number":629,"context_line":"        super(update_settings, self).__init__(**kwargs)"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"def mock_obj_to_dict(r):"},{"line_number":633,"context_line":"    return mock.Mock(**{\u0027to_dict.return_value\u0027: r})"},{"line_number":634,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"9a68dd71_34177e49","line":631,"in_reply_to":"9a68dd71_233c7c2e","updated":"2016-01-25 05:02:04.000000000","message":"Done","commit_id":"147d74e6d17819736f73c20ac2c942723816cc82"}]}
