)]}'
{"openstack_dashboard/dashboards/project/loadbalancers/tests.py":[{"author":{"_account_id":8674,"name":"Yves-Gwenael Bourhis","email":"ygbourhis@gmail.com","username":"yves"},"change_message_id":"09314e689f58f4cac7cdbe8efc43aaa6bc5e186f","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    DASHBOARD \u003d \u0027project\u0027"},{"line_number":37,"context_line":"    INDEX_URL \u003d str(reverse_lazy(\u0027horizon:%s:loadbalancers:index\u0027 % DASHBOARD))"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    ADDPOOL_PATH \u003d \u0027horizon:%s:loadbalancers:addpool\u0027 % DASHBOARD"},{"line_number":40,"context_line":"    ADDVIP_PATH \u003d \u0027horizon:%s:loadbalancers:addvip\u0027 % DASHBOARD"},{"line_number":41,"context_line":"    ADDMEMBER_PATH \u003d \u0027horizon:%s:loadbalancers:addmember\u0027 % DASHBOARD"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_21d3e205","line":38,"updated":"2015-12-11 17:15:44.000000000","message":"Wouldn\u0027t reverse(\u0027horizon:%s:loadbalancers:index\u0027 % DASHBOARD) do the same without requiring calling str?","commit_id":"7cec70e7dc9f835b26e115b728db7af36964d22d"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"e5bf963529c9b656de54c6758b933fcb0d4d93ac","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    DASHBOARD \u003d \u0027project\u0027"},{"line_number":37,"context_line":"    INDEX_URL \u003d str(reverse_lazy(\u0027horizon:%s:loadbalancers:index\u0027 % DASHBOARD))"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    ADDPOOL_PATH \u003d \u0027horizon:%s:loadbalancers:addpool\u0027 % DASHBOARD"},{"line_number":40,"context_line":"    ADDVIP_PATH \u003d \u0027horizon:%s:loadbalancers:addvip\u0027 % DASHBOARD"},{"line_number":41,"context_line":"    ADDMEMBER_PATH \u003d \u0027horizon:%s:loadbalancers:addmember\u0027 % DASHBOARD"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_7152e768","line":38,"in_reply_to":"7a740942_21d3e205","updated":"2015-12-14 07:54:46.000000000","message":"I don\u0027t know the Django API, so yes, maybe it works. What do you suggest?","commit_id":"7cec70e7dc9f835b26e115b728db7af36964d22d"},{"author":{"_account_id":8674,"name":"Yves-Gwenael Bourhis","email":"ygbourhis@gmail.com","username":"yves"},"change_message_id":"df84f223c3fbeb6123f58023dbcb30bfd4fd5f15","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    DASHBOARD \u003d \u0027project\u0027"},{"line_number":37,"context_line":"    INDEX_URL \u003d str(reverse_lazy(\u0027horizon:%s:loadbalancers:index\u0027 % DASHBOARD))"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    ADDPOOL_PATH \u003d \u0027horizon:%s:loadbalancers:addpool\u0027 % DASHBOARD"},{"line_number":40,"context_line":"    ADDVIP_PATH \u003d \u0027horizon:%s:loadbalancers:addvip\u0027 % DASHBOARD"},{"line_number":41,"context_line":"    ADDMEMBER_PATH \u003d \u0027horizon:%s:loadbalancers:addmember\u0027 % DASHBOARD"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_e2bb63c2","line":38,"in_reply_to":"7a740942_7152e768","updated":"2015-12-14 09:03:49.000000000","message":"I would suggest reverse without str:\nhttps://docs.djangoproject.com/en/1.9/ref/urlresolvers/#reverse\n\nInstead of reverse_lazy:\nhttps://docs.djangoproject.com/en/1.9/ref/urlresolvers/#reverse-lazy\n\nbecause reverse_lazy adds extra overhead by adding the \"lazy\" decorator to reverse:\nhttps://github.com/django/django/blob/master/django/core/urlresolvers.py#L548\nAnd calling \"str\" on it triggers the lazy evaluation right away, so it means we do not want it to be lazy :-)","commit_id":"7cec70e7dc9f835b26e115b728db7af36964d22d"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"531999ec7b98ebafe88898edeb9fe2b80d9a689a","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    DASHBOARD \u003d \u0027project\u0027"},{"line_number":37,"context_line":"    INDEX_URL \u003d str(reverse_lazy(\u0027horizon:%s:loadbalancers:index\u0027 % DASHBOARD))"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    ADDPOOL_PATH \u003d \u0027horizon:%s:loadbalancers:addpool\u0027 % DASHBOARD"},{"line_number":40,"context_line":"    ADDVIP_PATH \u003d \u0027horizon:%s:loadbalancers:addvip\u0027 % DASHBOARD"},{"line_number":41,"context_line":"    ADDMEMBER_PATH \u003d \u0027horizon:%s:loadbalancers:addmember\u0027 % DASHBOARD"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_cb74eafe","line":38,"in_reply_to":"7a740942_e2bb63c2","updated":"2015-12-17 10:15:34.000000000","message":"Ok, I replaced the code with reverse()","commit_id":"7cec70e7dc9f835b26e115b728db7af36964d22d"}]}
