)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"5d1a79673a23ffd952dab95cde7f827604d8bdea","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Cinder has added support for creating and managing volume consistency"},{"line_number":10,"context_line":"groups. This first patch adds this functionality into Horizon."},{"line_number":11,"context_line":"Subsequent patches will add features to utilize these consistency"},{"line_number":12,"context_line":"groups - such as for craating snapshots."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I33ebe39e79d7c1d1dc7e741b4199bcb259b642d1"},{"line_number":15,"context_line":"Partially-implements: blueprint cinder-consistency-groups"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a7e1126_2c037311","line":12,"range":{"start_line":12,"start_character":21,"end_line":12,"end_character":29},"updated":"2015-12-16 21:33:38.000000000","message":"craating -\u003e creating","commit_id":"5b0b2a54967768eec1537173c1fa10e30e6fef0d"}],"openstack_dashboard/dashboards/project/volumes/cgroups/forms.py":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"4ea6c610cb2dd1fdb6f5bcfab13d4fbdc365c60b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            cinder.volume_cgroup_update(request,"},{"line_number":35,"context_line":"                                        cgroup_id,"},{"line_number":36,"context_line":"                                        data[\u0027name\u0027],"},{"line_number":37,"context_line":"                                        data[\u0027description\u0027])"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"            message \u003d _(\u0027Updating volume consistency \u0027"},{"line_number":40,"context_line":"                        \u0027group \"%s\"\u0027) % data[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":18,"id":"5aef4532_443cf7c7","line":37,"updated":"2016-03-09 19:58:33.000000000","message":"I might be missing something here, but this seems to pass through only name and description, but the API seems able to take more fields. \n\nRegardless, its much neater to just pass through data, and sanitise on the API layer. Currently, the update seems to restrict what is passed through, and then the API checks if the fields are None, and submits them again; its a duplication of logic.\n\nIf you look at endpoint_group_create here: https://review.openstack.org/#/c/288946/2/openstack_dashboard/api/vpn.py I believe thats a slightly neater way of doing it? It also means that if any further fields are added to the form, you need only update one field in the API layer, rather than updating the form API call, the API function parameters, and then the API calls handling (param x \u003d None etc,)","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"022f0e103cdd330e833c0548ca45ec5ca8b5f7db","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            cinder.volume_cgroup_update(request,"},{"line_number":35,"context_line":"                                        cgroup_id,"},{"line_number":36,"context_line":"                                        data[\u0027name\u0027],"},{"line_number":37,"context_line":"                                        data[\u0027description\u0027])"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"            message \u003d _(\u0027Updating volume consistency \u0027"},{"line_number":40,"context_line":"                        \u0027group \"%s\"\u0027) % data[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":18,"id":"5aef4532_ce9dbd67","line":37,"in_reply_to":"5aef4532_443cf7c7","updated":"2016-03-09 22:58:37.000000000","message":"UpdateForm only deals with changing name and/or description of the CG, so I think this is appropriate. The API can handle also adding/removing volumes into the CG, and that update is done inside of \"workflows\". Should I create 2 APIs to make this more obvious?","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"41518e05f78184d5f14c95472ca1378f597020ad","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        delete_volumes \u003d data[\u0027delete_volumes\u0027]"},{"line_number":58,"context_line":"        search_opts \u003d {\u0027consistencygroup_id\u0027: cgroup_id}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        try:"},{"line_number":61,"context_line":"            # get list of assigned volumes"},{"line_number":62,"context_line":"            assigned_vols \u003d []"},{"line_number":63,"context_line":"            volumes \u003d cinder.volume_list(request,"}],"source_content_type":"text/x-python","patch_set":24,"id":"1af94dfe_1fbac723","line":60,"updated":"2016-03-15 19:32:13.000000000","message":"This seems like something that should be left to the backend; if there\u0027s no API to delete assigned volumes, adding the functionality in Horizon seems like a bit of a workaround. This would also just allow you to use the default Delete Action in the tables, until there is an API for handling this.","commit_id":"407f39f63f07c13615a4d5b1b8df069e35ad8556"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"e0ef194f77c49e94ae4673bd8202cc77daa17f80","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        delete_volumes \u003d data[\u0027delete_volumes\u0027]"},{"line_number":58,"context_line":"        search_opts \u003d {\u0027consistencygroup_id\u0027: cgroup_id}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        try:"},{"line_number":61,"context_line":"            # get list of assigned volumes"},{"line_number":62,"context_line":"            assigned_vols \u003d []"},{"line_number":63,"context_line":"            volumes \u003d cinder.volume_list(request,"}],"source_content_type":"text/x-python","patch_set":24,"id":"1af94dfe_d3cb3871","line":60,"in_reply_to":"1af94dfe_1fbac723","updated":"2016-03-15 21:04:23.000000000","message":"I don\u0027t agree that we are adding missing API functionality into Horizon. There are 2 modes for deleting CGs. One is to leave the assigned volumes intact, and the other is to also delete the assigned volumes. In the first case, there is an API to first un-assign all volumes from the CG, and then another API delete the CG. In the second case, we just delete the CG with the forceflag set to true. The only additional logic I am adding is \"waiting\" for the functions to complete (this was causing stale data in the other volume tabs). So for the first case, I loop through the assigned volumes until they return as \"not assigned\" to a CG. In the second case, I make sure the volumes no longer exist. I can take this out, but this can lead to confusion, such as the volume tab showing volumes that no longer exist. I think this problem is somewhat unique because the data is in tabs, and is not always refreshed when clicked from another tab in the same panel.","commit_id":"407f39f63f07c13615a4d5b1b8df069e35ad8556"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"d857a614ab0b00d7d2a8b5daba20136dffee011b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        delete_volumes \u003d data[\u0027delete_volumes\u0027]"},{"line_number":58,"context_line":"        search_opts \u003d {\u0027consistencygroup_id\u0027: cgroup_id}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        try:"},{"line_number":61,"context_line":"            # get list of assigned volumes"},{"line_number":62,"context_line":"            assigned_vols \u003d []"},{"line_number":63,"context_line":"            volumes \u003d cinder.volume_list(request,"}],"source_content_type":"text/x-python","patch_set":24,"id":"1af94dfe_a585585a","line":60,"in_reply_to":"1af94dfe_66825296","updated":"2016-03-16 15:30:56.000000000","message":"I have removed the complexity of the delete function for now. It will use the standard DeleteAction action, and will only be enabled if no volumes are associated with the CG. This will avoid 2 issues - no need to unassign here, and no need to check if all assigned volumes are deleted.","commit_id":"407f39f63f07c13615a4d5b1b8df069e35ad8556"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"c32b1626607ccd7b25cab5d5455c5b53607d89c7","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        delete_volumes \u003d data[\u0027delete_volumes\u0027]"},{"line_number":58,"context_line":"        search_opts \u003d {\u0027consistencygroup_id\u0027: cgroup_id}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        try:"},{"line_number":61,"context_line":"            # get list of assigned volumes"},{"line_number":62,"context_line":"            assigned_vols \u003d []"},{"line_number":63,"context_line":"            volumes \u003d cinder.volume_list(request,"}],"source_content_type":"text/x-python","patch_set":24,"id":"1af94dfe_66825296","line":60,"in_reply_to":"1af94dfe_d3cb3871","updated":"2016-03-16 08:39:23.000000000","message":"I can see the intent, but I think this would start potentially giving a poor UX. I think removing the loop would be wise, and the data being maintained on a separate tab sounds more like a bug in Horizon than something that should be worked around here.","commit_id":"407f39f63f07c13615a4d5b1b8df069e35ad8556"}],"openstack_dashboard/dashboards/project/volumes/cgroups/tables.py":[{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"05c2f8aadf8364ac3dc6984c75a781e676eeb203","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 Nebula, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":18,"id":"5aef4532_c8b49536","line":1,"updated":"2016-03-09 21:46:06.000000000","message":"(Applies to a few other files in this review) Remove the Nebula references in copyrights.","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"022f0e103cdd330e833c0548ca45ec5ca8b5f7db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 Nebula, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":18,"id":"5aef4532_6ec90959","line":1,"in_reply_to":"5aef4532_c8b49536","updated":"2016-03-09 22:58:37.000000000","message":"Done","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"eb1803cf43a7bc5a8e40365531172b4daad33ace","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    policy_rules \u003d ((\"volume\", \"consistencygroup:create\"),)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class DeleteVolumeCGroup(policy.PolicyTargetMixin, tables.LinkAction):"},{"line_number":33,"context_line":"    name \u003d \"deletecg\""},{"line_number":34,"context_line":"    verbose_name \u003d _(\"Delete Consistency Group\")"},{"line_number":35,"context_line":"    url \u003d \"horizon:project:volumes:cgroups:delete\""}],"source_content_type":"text/x-python","patch_set":19,"id":"5aef4532_fc33f7f3","line":32,"updated":"2016-03-10 11:55:34.000000000","message":"This should be a tables.DeleteAction. See  https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/flavors/tables.py#L31 for an example.","commit_id":"37410c0376f4704d0a19b8dd63f6afa36f523b1e"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"fe8918da39a3eb3e9e2c6722ffdfc36ca20ae575","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    policy_rules \u003d ((\"volume\", \"consistencygroup:create\"),)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class DeleteVolumeCGroup(policy.PolicyTargetMixin, tables.LinkAction):"},{"line_number":33,"context_line":"    name \u003d \"deletecg\""},{"line_number":34,"context_line":"    verbose_name \u003d _(\"Delete Consistency Group\")"},{"line_number":35,"context_line":"    url \u003d \"horizon:project:volumes:cgroups:delete\""}],"source_content_type":"text/x-python","patch_set":19,"id":"5aef4532_099e55b8","line":32,"in_reply_to":"5aef4532_fc33f7f3","updated":"2016-03-10 15:46:58.000000000","message":"I did this because I needed to add a prompt to the delete dialog (does the user wish to also delete the volumes within the CG). Is that possible using a DeleteAction? Having the prompt is also the reason this is only a row action, and not a table action.","commit_id":"37410c0376f4704d0a19b8dd63f6afa36f523b1e"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"2b567ebfc41919212467e3e2d5bdaa08c27bfc3e","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                search_opts \u003d {\u0027consistencygroup_id\u0027: cgroup.id}"},{"line_number":117,"context_line":"                vols \u003d cinder.volume_list(self.request,"},{"line_number":118,"context_line":"                                          search_opts\u003dsearch_opts)"},{"line_number":119,"context_line":"                num_vols \u003d len(vols)"},{"line_number":120,"context_line":"            except Exception:"},{"line_number":121,"context_line":"                exceptions.handle(self.request, _(\u0027Unable to display \u0027"},{"line_number":122,"context_line":"                                                  \u0027consistency group.\u0027))"}],"source_content_type":"text/x-python","patch_set":19,"id":"5aef4532_39073183","line":119,"updated":"2016-03-10 11:51:55.000000000","message":"Personally, I would not display this field at all but I\u0027m not entirely sure on the use case. It seems like this would cause very bad performance at scale, as every single cgroup would be doing a filtered list call on the all the volumes. That has the potentially to be a lot of data processing to show the list of cgroups; a cleaner way might be just to list the volumes on the details page. Your call :)","commit_id":"37410c0376f4704d0a19b8dd63f6afa36f523b1e"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"fe8918da39a3eb3e9e2c6722ffdfc36ca20ae575","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                search_opts \u003d {\u0027consistencygroup_id\u0027: cgroup.id}"},{"line_number":117,"context_line":"                vols \u003d cinder.volume_list(self.request,"},{"line_number":118,"context_line":"                                          search_opts\u003dsearch_opts)"},{"line_number":119,"context_line":"                num_vols \u003d len(vols)"},{"line_number":120,"context_line":"            except Exception:"},{"line_number":121,"context_line":"                exceptions.handle(self.request, _(\u0027Unable to display \u0027"},{"line_number":122,"context_line":"                                                  \u0027consistency group.\u0027))"}],"source_content_type":"text/x-python","patch_set":19,"id":"5aef4532_8c239355","line":119,"in_reply_to":"5aef4532_39073183","updated":"2016-03-10 15:46:58.000000000","message":"I think this a nice feature, and is a big improvement over the CLI, but I agree that this could be performance issue so I will take it out. And I already list the volumes in the details page.","commit_id":"37410c0376f4704d0a19b8dd63f6afa36f523b1e"}],"openstack_dashboard/dashboards/project/volumes/cgroups/tabs.py":[{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"5afb82975a540fcab46ef33e1e1c586c08eb31e2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 Nebula, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":21,"id":"5aef4532_23a40ab8","line":1,"updated":"2016-03-10 17:15:57.000000000","message":"Remove Nebula references in copyrights","commit_id":"163ea828c1700bb5527999aaf68b4391ddf6ea17"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"08487b5fd0b9a36f2fac9e32a28acfeab5c2a475","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 Nebula, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":21,"id":"5aef4532_1222f9a2","line":1,"in_reply_to":"5aef4532_23a40ab8","updated":"2016-03-10 21:44:27.000000000","message":"Done","commit_id":"163ea828c1700bb5527999aaf68b4391ddf6ea17"}],"openstack_dashboard/dashboards/project/volumes/cgroups/tests.py":[{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"05c2f8aadf8364ac3dc6984c75a781e676eeb203","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @test.create_stubs({cinder: (\u0027volume_cgroup_update\u0027,"},{"line_number":121,"context_line":"                                 \u0027volume_cgroup_get\u0027)})"},{"line_number":122,"context_line":"    def test_update_cgroup_add_vol(self):"},{"line_number":123,"context_line":"        cgroup \u003d self.cinder_consistencygroups.first()"},{"line_number":124,"context_line":"        volume \u003d self.cinder_volumes.first()"},{"line_number":125,"context_line":"        formData \u003d {\u0027volume_types\u0027: \u00271\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"5aef4532_7371f675","line":122,"updated":"2016-03-09 21:46:06.000000000","message":"It would be good to test that updating the name and description works properly as well, doing a get after the update and asserting that the update succeeded. Either in this test or in a separate test.","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"022f0e103cdd330e833c0548ca45ec5ca8b5f7db","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @test.create_stubs({cinder: (\u0027volume_cgroup_update\u0027,"},{"line_number":121,"context_line":"                                 \u0027volume_cgroup_get\u0027)})"},{"line_number":122,"context_line":"    def test_update_cgroup_add_vol(self):"},{"line_number":123,"context_line":"        cgroup \u003d self.cinder_consistencygroups.first()"},{"line_number":124,"context_line":"        volume \u003d self.cinder_volumes.first()"},{"line_number":125,"context_line":"        formData \u003d {\u0027volume_types\u0027: \u00271\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"5aef4532_146058a4","line":122,"in_reply_to":"5aef4532_7371f675","updated":"2016-03-09 22:58:37.000000000","message":"added new test to only pass name and description. Not sure what the additional \"get\" does. Maybe point me to a good example?","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"5afb82975a540fcab46ef33e1e1c586c08eb31e2","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    @test.create_stubs({cinder: (\u0027volume_cgroup_update\u0027,"},{"line_number":171,"context_line":"                                 \u0027volume_cgroup_get\u0027)})"},{"line_number":172,"context_line":"    def test_update_cgroup_name_and_description(self):"},{"line_number":173,"context_line":"        cgroup \u003d self.cinder_consistencygroups.first()"},{"line_number":174,"context_line":"        formData \u003d {\u0027volume_types\u0027: \u00271\u0027,"},{"line_number":175,"context_line":"                    \u0027name\u0027: \u0027test CG-new\u0027,"}],"source_content_type":"text/x-python","patch_set":21,"id":"5aef4532_1eb965cc","line":172,"updated":"2016-03-10 17:15:57.000000000","message":"What I was thinking of for this test was a validation at the end that the update actually succeeded. For example, this test for image update, where they do a get at the end to validate the get returns the updated info.\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/images/images/tests.py#L117","commit_id":"163ea828c1700bb5527999aaf68b4391ddf6ea17"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"08487b5fd0b9a36f2fac9e32a28acfeab5c2a475","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    @test.create_stubs({cinder: (\u0027volume_cgroup_update\u0027,"},{"line_number":171,"context_line":"                                 \u0027volume_cgroup_get\u0027)})"},{"line_number":172,"context_line":"    def test_update_cgroup_name_and_description(self):"},{"line_number":173,"context_line":"        cgroup \u003d self.cinder_consistencygroups.first()"},{"line_number":174,"context_line":"        formData \u003d {\u0027volume_types\u0027: \u00271\u0027,"},{"line_number":175,"context_line":"                    \u0027name\u0027: \u0027test CG-new\u0027,"}],"source_content_type":"text/x-python","patch_set":21,"id":"5aef4532_2b3fb3b4","line":172,"in_reply_to":"5aef4532_1eb965cc","updated":"2016-03-10 21:44:27.000000000","message":"As per our conversation, I will defer this change for now","commit_id":"163ea828c1700bb5527999aaf68b4391ddf6ea17"}],"openstack_dashboard/dashboards/project/volumes/cgroups/views.py":[{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"05c2f8aadf8364ac3dc6984c75a781e676eeb203","unresolved":false,"context_lines":[{"line_number":41,"context_line":"class CreateView(workflows.WorkflowView):"},{"line_number":42,"context_line":"    workflow_class \u003d vol_cgroup_workflows.CreateCGroupWorkflow"},{"line_number":43,"context_line":"    template_name \u003d \u0027project/volumes/cgroups/create.html\u0027"},{"line_number":44,"context_line":"    page_title \u003d _(\"Create Volume Consistency GroupXX\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class UpdateView(forms.ModalFormView):"}],"source_content_type":"text/x-python","patch_set":18,"id":"5aef4532_080cbdeb","line":44,"updated":"2016-03-09 21:46:06.000000000","message":"Is the XX here a typo?","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"022f0e103cdd330e833c0548ca45ec5ca8b5f7db","unresolved":false,"context_lines":[{"line_number":41,"context_line":"class CreateView(workflows.WorkflowView):"},{"line_number":42,"context_line":"    workflow_class \u003d vol_cgroup_workflows.CreateCGroupWorkflow"},{"line_number":43,"context_line":"    template_name \u003d \u0027project/volumes/cgroups/create.html\u0027"},{"line_number":44,"context_line":"    page_title \u003d _(\"Create Volume Consistency GroupXX\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class UpdateView(forms.ModalFormView):"}],"source_content_type":"text/x-python","patch_set":18,"id":"5aef4532_8e28d5e3","line":44,"in_reply_to":"5aef4532_080cbdeb","updated":"2016-03-09 22:58:37.000000000","message":"Done","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"4ea6c610cb2dd1fdb6f5bcfab13d4fbdc365c60b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    success_url \u003d reverse_lazy(\u0027horizon:project:volumes:index\u0027)"},{"line_number":52,"context_line":"    submit_url \u003d \"horizon:project:volumes:cgroups:update\""},{"line_number":53,"context_line":"    submit_label \u003d _(\"Edit Consistency Group\")"},{"line_number":54,"context_line":"    page_title \u003d _(\"Edit Consistency Group\")"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def get_initial(self):"},{"line_number":57,"context_line":"        cgroup \u003d self.get_object()"}],"source_content_type":"text/x-python","patch_set":18,"id":"5aef4532_49b25095","line":54,"updated":"2016-03-09 19:58:33.000000000","message":"No need to duplicate the translation object. Just set these strings to equal one another.","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"022f0e103cdd330e833c0548ca45ec5ca8b5f7db","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    success_url \u003d reverse_lazy(\u0027horizon:project:volumes:index\u0027)"},{"line_number":52,"context_line":"    submit_url \u003d \"horizon:project:volumes:cgroups:update\""},{"line_number":53,"context_line":"    submit_label \u003d _(\"Edit Consistency Group\")"},{"line_number":54,"context_line":"    page_title \u003d _(\"Edit Consistency Group\")"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def get_initial(self):"},{"line_number":57,"context_line":"        cgroup \u003d self.get_object()"}],"source_content_type":"text/x-python","patch_set":18,"id":"5aef4532_4ecfed28","line":54,"in_reply_to":"5aef4532_49b25095","updated":"2016-03-09 22:58:37.000000000","message":"Done","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"4ea6c610cb2dd1fdb6f5bcfab13d4fbdc365c60b","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    success_url \u003d reverse_lazy(\u0027horizon:project:volumes:index\u0027)"},{"line_number":86,"context_line":"    submit_url \u003d \"horizon:project:volumes:cgroups:delete\""},{"line_number":87,"context_line":"    submit_label \u003d _(\"Delete Consistency Group\")"},{"line_number":88,"context_line":"    page_title \u003d _(\"Delete Consistency Group\")"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def get_initial(self):"},{"line_number":91,"context_line":"        cgroup \u003d self.get_object()"}],"source_content_type":"text/x-python","patch_set":18,"id":"5aef4532_8449df62","line":88,"updated":"2016-03-09 19:58:33.000000000","message":"Ditto","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"4ea6c610cb2dd1fdb6f5bcfab13d4fbdc365c60b","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    @memoized.memoized_method"},{"line_number":156,"context_line":"    def get_data(self):"},{"line_number":157,"context_line":"        try:"},{"line_number":158,"context_line":"            cgroup_id \u003d self.kwargs[\u0027cgroup_id\u0027]"},{"line_number":159,"context_line":"            cgroup \u003d api.cinder.volume_cgroup_get(self.request,"},{"line_number":160,"context_line":"                                                  cgroup_id)"},{"line_number":161,"context_line":"            cgroup.volume_type_names \u003d []"}],"source_content_type":"text/x-python","patch_set":18,"id":"5aef4532_449877c0","line":158,"updated":"2016-03-09 19:58:33.000000000","message":"I think at this stage, cgroup_id is always available; you could more it out of this block and pass it to the error message at the end to make it more useful","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"}],"openstack_dashboard/dashboards/project/volumes/cgroups/workflows.py":[{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"5afb82975a540fcab46ef33e1e1c586c08eb31e2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 United States Government as represented by the"},{"line_number":2,"context_line":"# Administrator of the National Aeronautics and Space Administration."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":21,"id":"5aef4532_238b6a20","line":1,"updated":"2016-03-10 17:15:57.000000000","message":"Remove","commit_id":"163ea828c1700bb5527999aaf68b4391ddf6ea17"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"08487b5fd0b9a36f2fac9e32a28acfeab5c2a475","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 United States Government as represented by the"},{"line_number":2,"context_line":"# Administrator of the National Aeronautics and Space Administration."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":21,"id":"5aef4532_d2525112","line":1,"in_reply_to":"5aef4532_238b6a20","updated":"2016-03-10 21:44:27.000000000","message":"Done","commit_id":"163ea828c1700bb5527999aaf68b4391ddf6ea17"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"5afb82975a540fcab46ef33e1e1c586c08eb31e2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Administrator of the National Aeronautics and Space Administration."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Copyright 2012 Nebula, Inc."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":8,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":21,"id":"5aef4532_a3981a79","line":5,"updated":"2016-03-10 17:15:57.000000000","message":"Remove","commit_id":"163ea828c1700bb5527999aaf68b4391ddf6ea17"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"08487b5fd0b9a36f2fac9e32a28acfeab5c2a475","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Administrator of the National Aeronautics and Space Administration."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Copyright 2012 Nebula, Inc."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":8,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":21,"id":"5aef4532_32561506","line":5,"in_reply_to":"5aef4532_a3981a79","updated":"2016-03-10 21:44:27.000000000","message":"Done","commit_id":"163ea828c1700bb5527999aaf68b4391ddf6ea17"}],"openstack_dashboard/dashboards/project/volumes/tabs.py":[{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"05c2f8aadf8364ac3dc6984c75a781e676eeb203","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from horizon import tabs"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from openstack_dashboard import api"},{"line_number":23,"context_line":"from openstack_dashboard.api import cinder"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from openstack_dashboard.dashboards.project.volumes.backups \\"},{"line_number":26,"context_line":"    import tables as backups_tables"}],"source_content_type":"text/x-python","patch_set":18,"id":"5aef4532_c8edb5b8","line":23,"updated":"2016-03-09 21:46:06.000000000","message":"Suggest using api.cinder throughout this file instead of adding an extra import to stay consistent.","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"022f0e103cdd330e833c0548ca45ec5ca8b5f7db","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from horizon import tabs"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from openstack_dashboard import api"},{"line_number":23,"context_line":"from openstack_dashboard.api import cinder"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from openstack_dashboard.dashboards.project.volumes.backups \\"},{"line_number":26,"context_line":"    import tables as backups_tables"}],"source_content_type":"text/x-python","patch_set":18,"id":"5aef4532_0e14c59d","line":23,"in_reply_to":"5aef4532_c8edb5b8","updated":"2016-03-09 22:58:37.000000000","message":"Done","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"05c2f8aadf8364ac3dc6984c75a781e676eeb203","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        try:"},{"line_number":41,"context_line":"            marker, sort_dir \u003d self._get_marker()"},{"line_number":42,"context_line":"            volumes, self._has_more_data, self._has_prev_data \u003d \\"},{"line_number":43,"context_line":"                api.cinder.volume_list_paged(self.request, marker\u003dmarker,"},{"line_number":44,"context_line":"                                             search_opts\u003dsearch_opts,"},{"line_number":45,"context_line":"                                             sort_dir\u003dsort_dir, paginate\u003dTrue)"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"5aef4532_688101c3","line":43,"updated":"2016-03-09 21:46:06.000000000","message":"Regarding my above comment, api.cinder is still being used here, so I would continue using api.cinder everywhere.","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"022f0e103cdd330e833c0548ca45ec5ca8b5f7db","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        try:"},{"line_number":41,"context_line":"            marker, sort_dir \u003d self._get_marker()"},{"line_number":42,"context_line":"            volumes, self._has_more_data, self._has_prev_data \u003d \\"},{"line_number":43,"context_line":"                api.cinder.volume_list_paged(self.request, marker\u003dmarker,"},{"line_number":44,"context_line":"                                             search_opts\u003dsearch_opts,"},{"line_number":45,"context_line":"                                             sort_dir\u003dsort_dir, paginate\u003dTrue)"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"5aef4532_ee1879d5","line":43,"in_reply_to":"5aef4532_688101c3","updated":"2016-03-09 22:58:37.000000000","message":"Done","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"}],"openstack_dashboard/dashboards/project/volumes/templates/volumes/cgroups/_delete.html":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"4ea6c610cb2dd1fdb6f5bcfab13d4fbdc365c60b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \"horizon/common/_modal_form.html\" %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Delete Volume Consistency Group\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block modal-body-right %}"},{"line_number":6,"context_line":"  \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"}],"source_content_type":"text/html","patch_set":18,"id":"5aef4532_84539fe1","line":3,"range":{"start_line":3,"start_character":17,"end_line":3,"end_character":62},"updated":"2016-03-09 19:58:33.000000000","message":"{{ page_title }}","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"022f0e103cdd330e833c0548ca45ec5ca8b5f7db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \"horizon/common/_modal_form.html\" %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Delete Volume Consistency Group\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block modal-body-right %}"},{"line_number":6,"context_line":"  \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"}],"source_content_type":"text/html","patch_set":18,"id":"5aef4532_ce601dd2","line":3,"range":{"start_line":3,"start_character":17,"end_line":3,"end_character":62},"in_reply_to":"5aef4532_84539fe1","updated":"2016-03-09 22:58:37.000000000","message":"Done","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"4ea6c610cb2dd1fdb6f5bcfab13d4fbdc365c60b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Delete Volume Consistency Group\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block modal-body-right %}"},{"line_number":6,"context_line":"  \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"},{"line_number":7,"context_line":"  \u003cp\u003e{% trans \"Volume consistency groups can only be deleted after all the volumes it contains are either deleted or unassigned.\" %}\u003c/p\u003e"},{"line_number":8,"context_line":"  \u003cp\u003e{% trans \"The default action for deleting a consistency group is to first unassign all associated volumes.\" %}\u003c/p\u003e"},{"line_number":9,"context_line":"  \u003cp\u003e{% trans \"Check the \u0026quot;Delete Volumes\u0026quot; box to also delete the volumes associated with this consistency group.\" %}\u003c/p\u003e"}],"source_content_type":"text/html","patch_set":18,"id":"5aef4532_a4d69b4c","line":6,"updated":"2016-03-09 19:58:33.000000000","message":"Although I realise its the current design, you can drop this header. Its not helpful.","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"022f0e103cdd330e833c0548ca45ec5ca8b5f7db","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Delete Volume Consistency Group\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block modal-body-right %}"},{"line_number":6,"context_line":"  \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"},{"line_number":7,"context_line":"  \u003cp\u003e{% trans \"Volume consistency groups can only be deleted after all the volumes it contains are either deleted or unassigned.\" %}\u003c/p\u003e"},{"line_number":8,"context_line":"  \u003cp\u003e{% trans \"The default action for deleting a consistency group is to first unassign all associated volumes.\" %}\u003c/p\u003e"},{"line_number":9,"context_line":"  \u003cp\u003e{% trans \"Check the \u0026quot;Delete Volumes\u0026quot; box to also delete the volumes associated with this consistency group.\" %}\u003c/p\u003e"}],"source_content_type":"text/html","patch_set":18,"id":"5aef4532_ae5dd116","line":6,"in_reply_to":"5aef4532_a4d69b4c","updated":"2016-03-09 22:58:37.000000000","message":"Done","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"05c2f8aadf8364ac3dc6984c75a781e676eeb203","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block modal-body-right %}"},{"line_number":6,"context_line":"  \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"},{"line_number":7,"context_line":"  \u003cp\u003e{% trans \"Volume consistency groups can only be deleted after all the volumes it contains are either deleted or unassigned.\" %}\u003c/p\u003e"},{"line_number":8,"context_line":"  \u003cp\u003e{% trans \"The default action for deleting a consistency group is to first unassign all associated volumes.\" %}\u003c/p\u003e"},{"line_number":9,"context_line":"  \u003cp\u003e{% trans \"Check the \u0026quot;Delete Volumes\u0026quot; box to also delete the volumes associated with this consistency group.\" %}\u003c/p\u003e"},{"line_number":10,"context_line":"  \u003cp\u003e{% trans \"Note that a volume can not be deleted if it is \u0026quot;attached\u0026quot; or has any dependent snapshots.\" %}\u003c/p\u003e"}],"source_content_type":"text/html","patch_set":18,"id":"5aef4532_48eb6578","line":7,"updated":"2016-03-09 21:46:06.000000000","message":"\"all the volumes it contains are\" -\u003e \"all the volumes they contain are\"","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"022f0e103cdd330e833c0548ca45ec5ca8b5f7db","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block modal-body-right %}"},{"line_number":6,"context_line":"  \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"},{"line_number":7,"context_line":"  \u003cp\u003e{% trans \"Volume consistency groups can only be deleted after all the volumes it contains are either deleted or unassigned.\" %}\u003c/p\u003e"},{"line_number":8,"context_line":"  \u003cp\u003e{% trans \"The default action for deleting a consistency group is to first unassign all associated volumes.\" %}\u003c/p\u003e"},{"line_number":9,"context_line":"  \u003cp\u003e{% trans \"Check the \u0026quot;Delete Volumes\u0026quot; box to also delete the volumes associated with this consistency group.\" %}\u003c/p\u003e"},{"line_number":10,"context_line":"  \u003cp\u003e{% trans \"Note that a volume can not be deleted if it is \u0026quot;attached\u0026quot; or has any dependent snapshots.\" %}\u003c/p\u003e"}],"source_content_type":"text/html","patch_set":18,"id":"5aef4532_4ea36d00","line":7,"in_reply_to":"5aef4532_48eb6578","updated":"2016-03-09 22:58:37.000000000","message":"Done","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"05c2f8aadf8364ac3dc6984c75a781e676eeb203","unresolved":false,"context_lines":[{"line_number":5,"context_line":"{% block modal-body-right %}"},{"line_number":6,"context_line":"  \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"},{"line_number":7,"context_line":"  \u003cp\u003e{% trans \"Volume consistency groups can only be deleted after all the volumes it contains are either deleted or unassigned.\" %}\u003c/p\u003e"},{"line_number":8,"context_line":"  \u003cp\u003e{% trans \"The default action for deleting a consistency group is to first unassign all associated volumes.\" %}\u003c/p\u003e"},{"line_number":9,"context_line":"  \u003cp\u003e{% trans \"Check the \u0026quot;Delete Volumes\u0026quot; box to also delete the volumes associated with this consistency group.\" %}\u003c/p\u003e"},{"line_number":10,"context_line":"  \u003cp\u003e{% trans \"Note that a volume can not be deleted if it is \u0026quot;attached\u0026quot; or has any dependent snapshots.\" %}\u003c/p\u003e"},{"line_number":11,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":18,"id":"5aef4532_28bed964","line":8,"updated":"2016-03-09 21:46:06.000000000","message":"\"unassign all associated volumes\"\nWould it make more sense to say \"disassociate all associated volumes\"?","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"022f0e103cdd330e833c0548ca45ec5ca8b5f7db","unresolved":false,"context_lines":[{"line_number":5,"context_line":"{% block modal-body-right %}"},{"line_number":6,"context_line":"  \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"},{"line_number":7,"context_line":"  \u003cp\u003e{% trans \"Volume consistency groups can only be deleted after all the volumes it contains are either deleted or unassigned.\" %}\u003c/p\u003e"},{"line_number":8,"context_line":"  \u003cp\u003e{% trans \"The default action for deleting a consistency group is to first unassign all associated volumes.\" %}\u003c/p\u003e"},{"line_number":9,"context_line":"  \u003cp\u003e{% trans \"Check the \u0026quot;Delete Volumes\u0026quot; box to also delete the volumes associated with this consistency group.\" %}\u003c/p\u003e"},{"line_number":10,"context_line":"  \u003cp\u003e{% trans \"Note that a volume can not be deleted if it is \u0026quot;attached\u0026quot; or has any dependent snapshots.\" %}\u003c/p\u003e"},{"line_number":11,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":18,"id":"5aef4532_8edf3568","line":8,"in_reply_to":"5aef4532_28bed964","updated":"2016-03-09 22:58:37.000000000","message":"Done","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"}],"openstack_dashboard/dashboards/project/volumes/templates/volumes/cgroups/_detail_overview.html":[{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"488f7fff88fcd6a509762c5433b13a99451007b7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  {% for vol_names in cgroup.volume_names %}"},{"line_number":29,"context_line":"    \u003cdd\u003e{{ vol_names }}\u003c/dd\u003e"},{"line_number":30,"context_line":"  {% empty %}"},{"line_number":31,"context_line":"    \u003cdd\u003e\u003cem\u003e{% trans \"No assigned volumes\" %}\u003c/em\u003e\u003c/dd\u003e"},{"line_number":32,"context_line":"  {% endfor %}"},{"line_number":33,"context_line":"  \u003c/dl\u003e"},{"line_number":34,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":9,"id":"da6ed579_1680ef45","line":31,"updated":"2016-01-16 17:04:48.000000000","message":"Tiny nit: can we float the \u003cem\u003e to the next line for readability?","commit_id":"f65c13da295b2104b08e6a5e7143918ad9762a3e"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"c96e7b29bae21ce91f4f0ac280ae5c5e3f4792aa","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  {% for vol_names in cgroup.volume_names %}"},{"line_number":29,"context_line":"    \u003cdd\u003e{{ vol_names }}\u003c/dd\u003e"},{"line_number":30,"context_line":"  {% empty %}"},{"line_number":31,"context_line":"    \u003cdd\u003e\u003cem\u003e{% trans \"No assigned volumes\" %}\u003c/em\u003e\u003c/dd\u003e"},{"line_number":32,"context_line":"  {% endfor %}"},{"line_number":33,"context_line":"  \u003c/dl\u003e"},{"line_number":34,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":9,"id":"ba63e191_0cdc3ee3","line":31,"in_reply_to":"da6ed579_1680ef45","updated":"2016-01-19 15:45:07.000000000","message":"Done","commit_id":"f65c13da295b2104b08e6a5e7143918ad9762a3e"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"4ea6c610cb2dd1fdb6f5bcfab13d4fbdc365c60b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    \u003cdd\u003e{{ cgroup.id }}\u003c/dd\u003e"},{"line_number":9,"context_line":"    {% if cgroup.description %}"},{"line_number":10,"context_line":"    \u003cdt\u003e{% trans \"Description\" %}\u003c/dt\u003e"},{"line_number":11,"context_line":"    \u003cdd\u003e{{ cgroup.description }}\u003c/dd\u003e"},{"line_number":12,"context_line":"    {% endif %}"},{"line_number":13,"context_line":"    \u003cdt\u003e{% trans \"Status\" %}\u003c/dt\u003e"},{"line_number":14,"context_line":"    \u003cdd\u003e{{ cgroup.status|capfirst }}\u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":18,"id":"5aef4532_44223753","line":11,"updated":"2016-03-09 19:58:33.000000000","message":"Is this field actually removed from the consistency group? I think there is more value in displaying the Description title, and then a default of \"None\" or \"-\", if there is no data. Hiding fields can be a little mysterious for end users.","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"022f0e103cdd330e833c0548ca45ec5ca8b5f7db","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    \u003cdd\u003e{{ cgroup.id }}\u003c/dd\u003e"},{"line_number":9,"context_line":"    {% if cgroup.description %}"},{"line_number":10,"context_line":"    \u003cdt\u003e{% trans \"Description\" %}\u003c/dt\u003e"},{"line_number":11,"context_line":"    \u003cdd\u003e{{ cgroup.description }}\u003c/dd\u003e"},{"line_number":12,"context_line":"    {% endif %}"},{"line_number":13,"context_line":"    \u003cdt\u003e{% trans \"Status\" %}\u003c/dt\u003e"},{"line_number":14,"context_line":"    \u003cdd\u003e{{ cgroup.status|capfirst }}\u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":18,"id":"5aef4532_53cf9a28","line":11,"in_reply_to":"5aef4532_44223753","updated":"2016-03-09 22:58:37.000000000","message":"Done","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"}],"openstack_dashboard/dashboards/project/volumes/templates/volumes/cgroups/_update.html":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"4ea6c610cb2dd1fdb6f5bcfab13d4fbdc365c60b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \"horizon/common/_modal_form.html\" %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Edit Volume Consistency Group\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block modal-body-right %}"},{"line_number":6,"context_line":"  \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"}],"source_content_type":"text/html","patch_set":18,"id":"5aef4532_44e997e5","line":3,"updated":"2016-03-09 19:58:33.000000000","message":"{{ page_title }}","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"022f0e103cdd330e833c0548ca45ec5ca8b5f7db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \"horizon/common/_modal_form.html\" %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Edit Volume Consistency Group\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block modal-body-right %}"},{"line_number":6,"context_line":"  \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"}],"source_content_type":"text/html","patch_set":18,"id":"5aef4532_13beb264","line":3,"in_reply_to":"5aef4532_44e997e5","updated":"2016-03-09 22:58:37.000000000","message":"Done","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"4ea6c610cb2dd1fdb6f5bcfab13d4fbdc365c60b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Edit Volume Consistency Group\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block modal-body-right %}"},{"line_number":6,"context_line":"  \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"},{"line_number":7,"context_line":"  \u003cp\u003e{% trans \"Modify the name and description of a volume consistency group.\" %}\u003c/p\u003e"},{"line_number":8,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":18,"id":"5aef4532_04db0f50","line":6,"range":{"start_line":6,"start_character":2,"end_line":6,"end_character":37},"updated":"2016-03-09 19:58:33.000000000","message":"this header can be dropped.","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"022f0e103cdd330e833c0548ca45ec5ca8b5f7db","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Edit Volume Consistency Group\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block modal-body-right %}"},{"line_number":6,"context_line":"  \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"},{"line_number":7,"context_line":"  \u003cp\u003e{% trans \"Modify the name and description of a volume consistency group.\" %}\u003c/p\u003e"},{"line_number":8,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":18,"id":"5aef4532_6e40e934","line":6,"range":{"start_line":6,"start_character":2,"end_line":6,"end_character":37},"in_reply_to":"5aef4532_04db0f50","updated":"2016-03-09 22:58:37.000000000","message":"Done","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"}],"openstack_dashboard/dashboards/project/volumes/templates/volumes/cgroups/create.html":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"4ea6c610cb2dd1fdb6f5bcfab13d4fbdc365c60b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Create Volume Consistency Group\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block main %}"},{"line_number":6,"context_line":"    {% include \u0027horizon/common/_workflow.html\u0027 %}"}],"source_content_type":"text/html","patch_set":18,"id":"5aef4532_84ef1fe8","line":3,"updated":"2016-03-09 19:58:33.000000000","message":"{{ page_title }}","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"022f0e103cdd330e833c0548ca45ec5ca8b5f7db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Create Volume Consistency Group\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block main %}"},{"line_number":6,"context_line":"    {% include \u0027horizon/common/_workflow.html\u0027 %}"}],"source_content_type":"text/html","patch_set":18,"id":"5aef4532_33b76ef6","line":3,"in_reply_to":"5aef4532_84ef1fe8","updated":"2016-03-09 22:58:37.000000000","message":"Done","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"}],"openstack_dashboard/dashboards/project/volumes/templates/volumes/cgroups/delete.html":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"4ea6c610cb2dd1fdb6f5bcfab13d4fbdc365c60b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Delete Volume Consistency Group\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block main %}"},{"line_number":6,"context_line":"    {% include \u0027project/volumes/cgroups/_delete.html\u0027 %}"}],"source_content_type":"text/html","patch_set":18,"id":"5aef4532_a4a7bbbb","line":3,"updated":"2016-03-09 19:58:33.000000000","message":"{{ page_title }}","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"022f0e103cdd330e833c0548ca45ec5ca8b5f7db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Delete Volume Consistency Group\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block main %}"},{"line_number":6,"context_line":"    {% include \u0027project/volumes/cgroups/_delete.html\u0027 %}"}],"source_content_type":"text/html","patch_set":18,"id":"5aef4532_937e4217","line":3,"in_reply_to":"5aef4532_a4a7bbbb","updated":"2016-03-09 22:58:37.000000000","message":"Done","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"}],"openstack_dashboard/dashboards/project/volumes/templates/volumes/cgroups/update.html":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"4ea6c610cb2dd1fdb6f5bcfab13d4fbdc365c60b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Edit Volume Consistency Group\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block main %}"},{"line_number":6,"context_line":"    {% include \u0027project/volumes/cgroups/_update.html\u0027 %}"}],"source_content_type":"text/html","patch_set":18,"id":"5aef4532_04a94f90","line":3,"updated":"2016-03-09 19:58:33.000000000","message":"{{ page_title }}","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"022f0e103cdd330e833c0548ca45ec5ca8b5f7db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Edit Volume Consistency Group\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block main %}"},{"line_number":6,"context_line":"    {% include \u0027project/volumes/cgroups/_update.html\u0027 %}"}],"source_content_type":"text/html","patch_set":18,"id":"5aef4532_13919247","line":3,"in_reply_to":"5aef4532_04a94f90","updated":"2016-03-09 22:58:37.000000000","message":"Done","commit_id":"6c84892c2df26646c0581c7b8eace30b1f222533"}]}
