)]}'
{"horizon/static/framework/util/extensible/extensible.service.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"08af18ea64ec7443d57e4d172123929b08e02d0f","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    return items.filter(function filterItems(item) {"},{"line_number":224,"context_line":"      return item._ext \u0026\u0026 item._ext.position \u003d\u003d\u003d position;"},{"line_number":225,"context_line":"    }).sort(function sortItems(a, b) {"},{"line_number":226,"context_line":"      return a._ext.priority - b._ext.priority || 1;"},{"line_number":227,"context_line":"    });"},{"line_number":228,"context_line":"  }"},{"line_number":229,"context_line":""}],"source_content_type":"text/javascript","patch_set":8,"id":"dae33548_e8c85e57","line":226,"updated":"2016-02-19 06:18:21.000000000","message":"i personally hate this lint warning... i like the parens... but alas it was voted in.","commit_id":"da621eb6ae1917e1b458877db3f437bc5969db8f"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"ef0e929f429f02da8904b4e73ae0e797282b90e1","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    return items.filter(function filterItems(item) {"},{"line_number":224,"context_line":"      return item._ext \u0026\u0026 item._ext.position \u003d\u003d\u003d position;"},{"line_number":225,"context_line":"    }).sort(function sortItems(a, b) {"},{"line_number":226,"context_line":"      return a._ext.priority - b._ext.priority || 1;"},{"line_number":227,"context_line":"    });"},{"line_number":228,"context_line":"  }"},{"line_number":229,"context_line":""}],"source_content_type":"text/javascript","patch_set":8,"id":"bae84128_80e5f6a9","line":226,"in_reply_to":"dae33548_e8c85e57","updated":"2016-02-19 08:49:57.000000000","message":"Agreed, I also dont like it but it will trigger warnings :(","commit_id":"da621eb6ae1917e1b458877db3f437bc5969db8f"}],"horizon/static/framework/util/i18n/i18n.js":[{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"86bcf2e458911171a7c88612458cfaa6aa27bd30","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    // If no global function, revert to just returning given text."},{"line_number":45,"context_line":"    var gettextFunc \u003d $window.gettext || function (x) {"},{"line_number":46,"context_line":"        return x;"},{"line_number":47,"context_line":"      };"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    // Eventually, could delete the window gettext references here,"},{"line_number":50,"context_line":"    // or provide an appropriate method."}],"source_content_type":"text/javascript","patch_set":4,"id":"1a7b0d38_e78d5432","line":47,"range":{"start_line":47,"start_character":6,"end_line":47,"end_character":8},"updated":"2015-12-23 14:51:18.000000000","message":"There is a modification currently proposed that may make this adjustment unnecessary: https://review.openstack.org/#/c/249983/","commit_id":"cedbbd266b4cb94bc1087656fb38710219d722f1"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"40cd9af3904d59423d760fd0bb8328ee3e6bf4c2","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    // If no global function, revert to just returning given text."},{"line_number":45,"context_line":"    var gettextFunc \u003d $window.gettext || function (x) {"},{"line_number":46,"context_line":"        return x;"},{"line_number":47,"context_line":"      };"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    // Eventually, could delete the window gettext references here,"},{"line_number":50,"context_line":"    // or provide an appropriate method."}],"source_content_type":"text/javascript","patch_set":4,"id":"1a7b0d38_7026f869","line":47,"in_reply_to":"1a7b0d38_e78d5432","updated":"2015-12-23 15:58:22.000000000","message":"Thanks for the ping Michael! :)","commit_id":"cedbbd266b4cb94bc1087656fb38710219d722f1"}],"horizon/static/framework/widgets/transfer-table/transfer-table.directive.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"de502f4bacd544810c7e0561c2d441842f98d9db","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      transclude: true,"},{"line_number":57,"context_line":"      templateUrl: path + \u0027transfer-table/transfer-table.html\u0027,"},{"line_number":58,"context_line":"      link: link"},{"line_number":59,"context_line":"    };"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    //////////////////////"},{"line_number":62,"context_line":""}],"source_content_type":"text/javascript","patch_set":10,"id":"bae84128_a810b44f","line":59,"updated":"2016-02-19 23:42:16.000000000","message":"Doesn\u0027t this one also match john papa?","commit_id":"3b021f569bf0c0c6f87ec54791c9242328d935c5"}],"openstack_dashboard/dashboards/identity/static/dashboard/identity/users/table/table.controller.spec.js":[{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"688674307f9c3ff4c423052f91da916d1f84c38e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        then: function(successFn, errorFn) {"},{"line_number":26,"context_line":"          if (policy.allowed) {"},{"line_number":27,"context_line":"            successFn();"},{"line_number":28,"context_line":"          } else {"},{"line_number":29,"context_line":"            errorFn();"},{"line_number":30,"context_line":"          }"},{"line_number":31,"context_line":"        }"}],"source_content_type":"text/javascript","patch_set":1,"id":"5a710552_224caac6","line":28,"updated":"2015-12-15 13:01:21.000000000","message":"else -- It requires a new line.","commit_id":"41a18652269ae3aef0d5eec8bc8ba0f23292a884"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"50662b7726c7511b9655ff4822720aeb0f882e34","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        then: function(successFn, errorFn) {"},{"line_number":26,"context_line":"          if (policy.allowed) {"},{"line_number":27,"context_line":"            successFn();"},{"line_number":28,"context_line":"          } else {"},{"line_number":29,"context_line":"            errorFn();"},{"line_number":30,"context_line":"          }"},{"line_number":31,"context_line":"        }"}],"source_content_type":"text/javascript","patch_set":1,"id":"5a710552_65ae3c30","line":28,"in_reply_to":"5a710552_224caac6","updated":"2015-12-15 13:15:53.000000000","message":"Going by the eslint rules in here, the else should be like that as its \"one of the most common brace styles in JavaScript\":\nhttp://eslint.org/docs/rules/brace-style.html\n\nI cant find anything in openstack that says which one is the preferred, so I went with the simplest one :)","commit_id":"41a18652269ae3aef0d5eec8bc8ba0f23292a884"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/source/source.controller.js":[{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"688674307f9c3ff4c423052f91da916d1f84c38e","unresolved":false,"context_lines":[{"line_number":304,"context_line":"        var volumeSizeObj \u003d { minVolumeSize: ctrl.minVolumeSize };"},{"line_number":305,"context_line":"        ctrl.minVolumeSizeError \u003d interpolate(volumeSizeText, volumeSizeObj, true);"},{"line_number":306,"context_line":"      } else {"},{"line_number":307,"context_line":"        ctrl.minVolumeSize \u003d undefined;"},{"line_number":308,"context_line":"      }"},{"line_number":309,"context_line":"    }"},{"line_number":310,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"5a710552_255354e3","side":"PARENT","line":307,"updated":"2015-12-15 13:01:21.000000000","message":"Whether we need to reset the \u0027ctrl.minVolumeSize\u0027 if it has been set a value before?","commit_id":"3ab782040563e86255dc66a8bbefca527660bc52"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"50662b7726c7511b9655ff4822720aeb0f882e34","unresolved":false,"context_lines":[{"line_number":304,"context_line":"        var volumeSizeObj \u003d { minVolumeSize: ctrl.minVolumeSize };"},{"line_number":305,"context_line":"        ctrl.minVolumeSizeError \u003d interpolate(volumeSizeText, volumeSizeObj, true);"},{"line_number":306,"context_line":"      } else {"},{"line_number":307,"context_line":"        ctrl.minVolumeSize \u003d undefined;"},{"line_number":308,"context_line":"      }"},{"line_number":309,"context_line":"    }"},{"line_number":310,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"5a710552_a8aab9d2","side":"PARENT","line":307,"in_reply_to":"5a710552_255354e3","updated":"2015-12-15 13:15:53.000000000","message":"Aha! Good catch!","commit_id":"3ab782040563e86255dc66a8bbefca527660bc52"}],"openstack_dashboard/static/app/core/openstack-service-api/cinder.service.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"08af18ea64ec7443d57e4d172123929b08e02d0f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"   * @description Provides direct access to Cinder APIs."},{"line_number":32,"context_line":"   */"},{"line_number":33,"context_line":"  function cinderAPI(apiService, toastService) {"},{"line_number":34,"context_line":"    return {"},{"line_number":35,"context_line":"      getVolumes: getVolumes,"},{"line_number":36,"context_line":"      getVolume: getVolume,"},{"line_number":37,"context_line":"      getVolumeTypes: getVolumeTypes,"}],"source_content_type":"text/javascript","patch_set":8,"id":"dae33548_e83dfe2b","line":34,"updated":"2016-02-19 06:18:21.000000000","message":"Hmm... the style is from the john papa style guide which adopted...\n\nWould have to be convinced to go otherwise:\n\nhttps://github.com/johnpapa/angular-styleguide#services","commit_id":"da621eb6ae1917e1b458877db3f437bc5969db8f"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"ef0e929f429f02da8904b4e73ae0e797282b90e1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"   * @description Provides direct access to Cinder APIs."},{"line_number":32,"context_line":"   */"},{"line_number":33,"context_line":"  function cinderAPI(apiService, toastService) {"},{"line_number":34,"context_line":"    return {"},{"line_number":35,"context_line":"      getVolumes: getVolumes,"},{"line_number":36,"context_line":"      getVolume: getVolume,"},{"line_number":37,"context_line":"      getVolumeTypes: getVolumeTypes,"}],"source_content_type":"text/javascript","patch_set":8,"id":"bae84128_407c8e20","line":34,"in_reply_to":"dae33548_e83dfe2b","updated":"2016-02-19 08:49:57.000000000","message":"This rule seems to have changed since I created this patch so its not valid anymore. Reverted","commit_id":"da621eb6ae1917e1b458877db3f437bc5969db8f"}]}
