)]}'
{"openstack_dashboard/dashboards/project/access_and_security/security_groups/forms.py":[{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"fbc1d425f647c38f23e7527f4d59b5d9c54e2acb","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    icmp_type \u003d forms.IntegerField(label\u003d_(\"Type\"),"},{"line_number":181,"context_line":"                                   required\u003dFalse,"},{"line_number":182,"context_line":"                                   help_text\u003d_(\"Enter a value for ICMP type \""},{"line_number":183,"context_line":"                                               \"in the range (0: 255)\"),"},{"line_number":184,"context_line":"                                   widget\u003dforms.TextInput(attrs\u003d{"},{"line_number":185,"context_line":"                                       \u0027class\u0027: \u0027switched\u0027,"},{"line_number":186,"context_line":"                                       \u0027data-switch-on\u0027: \u0027rule_menu\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_206a241b","line":183,"updated":"2015-12-18 08:15:40.000000000","message":"nit help_text is \"(0: 255)\" and msg is \"(0, 255)\".\nI think it is better to be same format.","commit_id":"1a74bb541fcd8091806b66430bbf06aa692fe7c5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4997117b8265bb7e3cec8b584d105ca57ada2a28","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    icmp_type \u003d forms.IntegerField(label\u003d_(\"Type\"),"},{"line_number":181,"context_line":"                                   required\u003dFalse,"},{"line_number":182,"context_line":"                                   help_text\u003d_(\"Enter a value for ICMP type \""},{"line_number":183,"context_line":"                                               \"in the range (0, 255)\"),"},{"line_number":184,"context_line":"                                   widget\u003dforms.TextInput(attrs\u003d{"},{"line_number":185,"context_line":"                                       \u0027class\u0027: \u0027switched\u0027,"},{"line_number":186,"context_line":"                                       \u0027data-switch-on\u0027: \u0027rule_menu\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_14c50e3b","line":183,"updated":"2016-01-03 16:26:30.000000000","message":"i think that -1 may be the wild card. Not sure","commit_id":"ef693d5a7de6f29b04f5f7acb26b261d69f04727"},{"author":{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},"change_message_id":"46679a22e7372ba7f43b52be3a082bb086cde8b3","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    icmp_type \u003d forms.IntegerField(label\u003d_(\"Type\"),"},{"line_number":181,"context_line":"                                   required\u003dFalse,"},{"line_number":182,"context_line":"                                   help_text\u003d_(\"Enter a value for ICMP type \""},{"line_number":183,"context_line":"                                               \"in the range (0, 255)\"),"},{"line_number":184,"context_line":"                                   widget\u003dforms.TextInput(attrs\u003d{"},{"line_number":185,"context_line":"                                       \u0027class\u0027: \u0027switched\u0027,"},{"line_number":186,"context_line":"                                       \u0027data-switch-on\u0027: \u0027rule_menu\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_64a823dc","line":183,"in_reply_to":"fa69d971_14c50e3b","updated":"2016-01-05 05:54:01.000000000","message":"Hi garyk,\n\nfrom CLI -1 is wild card,but on horizon,-1 is invaild value.if input type or code is -1,horizon display error message.so we should change help_text\n\nThanks","commit_id":"ef693d5a7de6f29b04f5f7acb26b261d69f04727"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3d19c217c4b9f6fb0895cf15c580a6b1a838e106","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    icmp_type \u003d forms.IntegerField(label\u003d_(\"Type\"),"},{"line_number":181,"context_line":"                                   required\u003dFalse,"},{"line_number":182,"context_line":"                                   help_text\u003d_(\"Enter a value for ICMP type \""},{"line_number":183,"context_line":"                                               \"in the range (0, 255)\"),"},{"line_number":184,"context_line":"                                   widget\u003dforms.TextInput(attrs\u003d{"},{"line_number":185,"context_line":"                                       \u0027class\u0027: \u0027switched\u0027,"},{"line_number":186,"context_line":"                                       \u0027data-switch-on\u0027: \u0027rule_menu\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_e9bbb973","line":183,"updated":"2016-06-10 09:29:18.000000000","message":"-1 means any. At least you need to mention -1.","commit_id":"c7a0f4f9ef5723bb8a60a3f2b74776c93de19ead"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3d19c217c4b9f6fb0895cf15c580a6b1a838e106","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    icmp_code \u003d forms.IntegerField(label\u003d_(\"Code\"),"},{"line_number":192,"context_line":"                                   required\u003dFalse,"},{"line_number":193,"context_line":"                                   help_text\u003d_(\"Enter a value for ICMP code \""},{"line_number":194,"context_line":"                                               \"in the range (0, 255)\"),"},{"line_number":195,"context_line":"                                   widget\u003dforms.TextInput(attrs\u003d{"},{"line_number":196,"context_line":"                                       \u0027class\u0027: \u0027switched\u0027,"},{"line_number":197,"context_line":"                                       \u0027data-switch-on\u0027: \u0027rule_menu\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_c9bebd63","line":194,"updated":"2016-06-10 09:29:18.000000000","message":"ditto.","commit_id":"c7a0f4f9ef5723bb8a60a3f2b74776c93de19ead"}],"openstack_dashboard/dashboards/project/access_and_security/security_groups/tests.py":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"d2aa82cf6617eb1e3741ef5862f01f2deb9e5622","unresolved":false,"context_lines":[{"line_number":511,"context_line":"                    \u0027cidr\u0027: icmp_rule.ip_range[\u0027cidr\u0027],"},{"line_number":512,"context_line":"                    \u0027remote\u0027: \u0027cidr\u0027}"},{"line_number":513,"context_line":"        res \u003d self.client.post(self.edit_url, formData)"},{"line_number":514,"context_line":"        self.assertNoMessages()"},{"line_number":515,"context_line":"        self.assertContains(res, \"The ICMP type is invalid.\")"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        formData \u003d {\u0027method\u0027: \u0027AddRule\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_8fbfd9cf","line":514,"updated":"2015-12-23 07:50:34.000000000","message":"you\u0027re mixing two tests here, please make this one (or the other test) separate.","commit_id":"98cdfc6757470fc54a2669206b91709976d0e6fc"}]}