)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"db0c331954bef9a3c1486ea2f72db47c154ed02e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Timur Sufiev \u003ctsufiev@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-18 17:02:07 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t wait for spinner to disappear explicitly in i9n tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now it\u0027s done implicitly when invoking .submit() method of a base form"},{"line_number":10,"context_line":"test wrapper."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da6ed579_da724ce3","line":7,"updated":"2016-01-18 14:37:03.000000000","message":"Would you consider retitling this patch to something like \"Always wait for spinner to disappear after submit\"?\n\nThe title concerned me - I thought maybe the tests were supposed to proceed even if the spinner was showing!","commit_id":"61cca9d3d165235c43ad2beef990ecc132e048e6"}],"openstack_dashboard/test/integration_tests/basewebobject.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"c11c765ca1cd86926897ee07610a22284ce488cd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import unittest"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from selenium.common.exceptions import NoSuchElementException"},{"line_number":18,"context_line":"from selenium.webdriver.common import by"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class BaseWebObject(unittest.TestCase):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a68dd71_3d133968","line":18,"updated":"2016-01-22 05:28:06.000000000","message":"combine this imports with the group above, they are all third party import","commit_id":"d1117a1eddc51be02703a27a4bcb386d579667d5"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"0cedaa9031b69f238fd172122775680223da7b28","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import unittest"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from selenium.common.exceptions import NoSuchElementException"},{"line_number":18,"context_line":"from selenium.webdriver.common import by"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class BaseWebObject(unittest.TestCase):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a68dd71_a9ab661c","line":18,"in_reply_to":"9a68dd71_3d133968","updated":"2016-01-22 09:43:25.000000000","message":"Done","commit_id":"d1117a1eddc51be02703a27a4bcb386d579667d5"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"c11c765ca1cd86926897ee07610a22284ce488cd","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        try:"},{"line_number":116,"context_line":"            self._turn_off_implicit_wait()"},{"line_number":117,"context_line":"            self._wait_till_element_disappears(element_getter())"},{"line_number":118,"context_line":"        except NoSuchElementException:"},{"line_number":119,"context_line":"            # NOTE(mpavlase): This is valid state. When request completes"},{"line_number":120,"context_line":"            # even before Selenium get a chance to get the spinner element,"},{"line_number":121,"context_line":"            # it will raise the NoSuchElementException exception."}],"source_content_type":"text/x-python","patch_set":11,"id":"9a68dd71_7d19b187","line":118,"updated":"2016-01-22 05:28:06.000000000","message":"why not use Exceptions.NoSuchElementException ? Exception is already imported","commit_id":"d1117a1eddc51be02703a27a4bcb386d579667d5"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"0cedaa9031b69f238fd172122775680223da7b28","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        try:"},{"line_number":116,"context_line":"            self._turn_off_implicit_wait()"},{"line_number":117,"context_line":"            self._wait_till_element_disappears(element_getter())"},{"line_number":118,"context_line":"        except NoSuchElementException:"},{"line_number":119,"context_line":"            # NOTE(mpavlase): This is valid state. When request completes"},{"line_number":120,"context_line":"            # even before Selenium get a chance to get the spinner element,"},{"line_number":121,"context_line":"            # it will raise the NoSuchElementException exception."}],"source_content_type":"text/x-python","patch_set":11,"id":"9a68dd71_69648e21","line":118,"in_reply_to":"9a68dd71_7d19b187","updated":"2016-01-22 09:43:25.000000000","message":"Done","commit_id":"d1117a1eddc51be02703a27a4bcb386d579667d5"}]}
