)]}'
{"horizon/static/framework/widgets/action-list/actions.custom.mock.html":[{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"e6e1e1e66c5ce08cf88649cb1b0109dfb9ca7c6f","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"\u003caction action-classes\u003d\"\u0027btn-custom\u0027\" item\u003d\"customItem\"\u003e"},{"line_number":3,"context_line":"  \u003cspan class\u003d\"fa fa-custom\" translate\u003eCustom Button\u003c/span\u003e"},{"line_number":4,"context_line":"\u003c/action\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"da6ed579_65fdc639","line":3,"updated":"2016-01-13 00:05:45.000000000","message":"Custom Button should be outside of the icon-font span","commit_id":"2899bda4724ec1376c3c83bed2ea2e4b31169939"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"9d49dc202cefb81f64b261f37e67927c588aa410","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"\u003caction action-classes\u003d\"\u0027btn-custom\u0027\" item\u003d\"customItem\"\u003e"},{"line_number":3,"context_line":"  \u003cspan class\u003d\"fa fa-custom\" translate\u003eCustom Button\u003c/span\u003e"},{"line_number":4,"context_line":"\u003c/action\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"da6ed579_401670a8","line":3,"in_reply_to":"da6ed579_65fdc639","updated":"2016-01-13 00:30:52.000000000","message":"This is a mock test file. Not used.","commit_id":"2899bda4724ec1376c3c83bed2ea2e4b31169939"}],"horizon/static/framework/widgets/action-list/actions.custom2.mock.html":[{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"e6e1e1e66c5ce08cf88649cb1b0109dfb9ca7c6f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003caction action-classes\u003d\"\u0027btn-custom-2\u0027\"\u003e"},{"line_number":2,"context_line":"  \u003cspan class\u003d\"fa fa-custom-2\" translate\u003eCustom Button 2\u003c/span\u003e"},{"line_number":3,"context_line":"\u003c/action\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"da6ed579_85f8fa4a","line":2,"updated":"2016-01-13 00:05:45.000000000","message":"Custom Button 2 should be outside of the icon font span","commit_id":"2899bda4724ec1376c3c83bed2ea2e4b31169939"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"9d49dc202cefb81f64b261f37e67927c588aa410","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003caction action-classes\u003d\"\u0027btn-custom-2\u0027\"\u003e"},{"line_number":2,"context_line":"  \u003cspan class\u003d\"fa fa-custom-2\" translate\u003eCustom Button 2\u003c/span\u003e"},{"line_number":3,"context_line":"\u003c/action\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"da6ed579_c0226001","line":2,"in_reply_to":"da6ed579_85f8fa4a","updated":"2016-01-13 00:30:52.000000000","message":"This is a mock test file. Not used.","commit_id":"2899bda4724ec1376c3c83bed2ea2e4b31169939"}],"horizon/static/framework/widgets/action-list/actions.directive.js":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"d30d35133512c42a8b540576e3364def6fc1bb2e","unresolved":false,"context_lines":[{"line_number":63,"context_line":"   *      which will be passed to the callback. For \u0027row\u0027 type, the current \u0027item\u0027 will not be"},{"line_number":64,"context_line":"   *      passed if not specified as an attribute in the template. Specifying an \u0027item\u0027 other"},{"line_number":65,"context_line":"   *      than the current \u0027item\u0027 is supported."},{"line_number":66,"context_line":"   *      The \u0027scope\u0027 in use for the \u0027actions\u0027 directive can be used in the custom template."},{"line_number":67,"context_line":"   *"},{"line_number":68,"context_line":"   *   2. type: \u0027\u003caction_button_type\u003e\u0027"},{"line_number":69,"context_line":"   *      This creates an action button based off a \u0027known\u0027 button type."}],"source_content_type":"text/javascript","patch_set":1,"id":"fa69d971_faf16796","line":66,"updated":"2016-01-08 02:43:53.000000000","message":"This isn\u0027t entirely clear to me. Could we have examples demonstrating the various attributes and the flexibility here?\n\nAlso, the various substitution variables need to be listed and explained.","commit_id":"a4afd4277fe4878d33785f873c4c8fa28a9b4df3"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"699ddaaa8d8e4b9ec97f4fd7ad34e8cacd97888f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"   *      which will be passed to the callback. For \u0027row\u0027 type, the current \u0027item\u0027 will not be"},{"line_number":64,"context_line":"   *      passed if not specified as an attribute in the template. Specifying an \u0027item\u0027 other"},{"line_number":65,"context_line":"   *      than the current \u0027item\u0027 is supported."},{"line_number":66,"context_line":"   *      The \u0027scope\u0027 in use for the \u0027actions\u0027 directive can be used in the custom template."},{"line_number":67,"context_line":"   *"},{"line_number":68,"context_line":"   *   2. type: \u0027\u003caction_button_type\u003e\u0027"},{"line_number":69,"context_line":"   *      This creates an action button based off a \u0027known\u0027 button type."}],"source_content_type":"text/javascript","patch_set":1,"id":"fa69d971_cc461b21","line":66,"in_reply_to":"fa69d971_faf16796","updated":"2016-01-08 06:58:34.000000000","message":"I\u0027ve put a reference to the tests here and mentioned the templates they use. The tests I added are a little more explicit about how it gets used.\n\nThe idea here is that the developer wants to have a very custom Action button which needs a different item in the callback or maybe has a lot more logic.\n\nThe substitutions being performed is an unintended result of implementation detail and for developers using custom templates relying on that is a real bad idea in the sense, if I can specify everything (classes, item to use, text) in the HTML why would I do it instead in the Service. \nDocumenting substitutions will confuse the developer IMHO.","commit_id":"a4afd4277fe4878d33785f873c4c8fa28a9b4df3"}]}