)]}'
{"horizon/static/horizon/js/horizon.forms.js":[{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"d701ff1826799d30206b963f80235348df1f2d3e","unresolved":false,"context_lines":[{"line_number":247,"context_line":"  \"use strict\";"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"  // Update the select value if dropdown value changes"},{"line_number":250,"context_line":"  $(\u0027.fancy-select\u0027)"},{"line_number":251,"context_line":"    .on(\u0027click\u0027, \u0027li a\u0027, function () {"},{"line_number":252,"context_line":"      var $this \u003d $(this);"},{"line_number":253,"context_line":"      var $fancySelectParent \u003d $this.parents(\u0027.fancy-select\u0027);"}],"source_content_type":"text/javascript","patch_set":16,"id":"da6ed579_99e69ee6","line":250,"updated":"2016-01-15 01:23:25.000000000","message":"No reason to find this selector twice.  We can cache it and then (down below) use that cache and $fancySelector.find(\u0027select\u0027)","commit_id":"82878914aacfe2c8dedf8b6d53664f5ab46a0af7"},{"author":{"_account_id":9659,"name":"Matt Wood","email":"matt.wood@hpe.com","username":"woodm1979"},"change_message_id":"06409c84e11089cad964df7ece276eafd7bec6a1","unresolved":false,"context_lines":[{"line_number":247,"context_line":"  \"use strict\";"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"  // Update the select value if dropdown value changes"},{"line_number":250,"context_line":"  $(\u0027.fancy-select\u0027)"},{"line_number":251,"context_line":"    .on(\u0027click\u0027, \u0027li a\u0027, function () {"},{"line_number":252,"context_line":"      var $this \u003d $(this);"},{"line_number":253,"context_line":"      var $fancySelectParent \u003d $this.parents(\u0027.fancy-select\u0027);"}],"source_content_type":"text/javascript","patch_set":16,"id":"da6ed579_3492eff6","line":250,"in_reply_to":"da6ed579_99e69ee6","updated":"2016-01-15 22:12:19.000000000","message":"Done","commit_id":"82878914aacfe2c8dedf8b6d53664f5ab46a0af7"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"d701ff1826799d30206b963f80235348df1f2d3e","unresolved":false,"context_lines":[{"line_number":254,"context_line":"      var value \u003d $this.data(\u0027selectValue\u0027);"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"      // Go to the parent form-group and find the select"},{"line_number":257,"context_line":"      var $select \u003d $fancySelectParent.find(\u0027select\u0027);"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"      // Set the select if necessary"},{"line_number":260,"context_line":"      if($select.val() !\u003d\u003d value) {"}],"source_content_type":"text/javascript","patch_set":16,"id":"da6ed579_5971060e","line":257,"updated":"2016-01-15 01:23:25.000000000","message":"Minor speed improvement: We can cache the parent selector in a \u0027data\u0027 attribute after the first click so we don\u0027t have to search the dom for it again.","commit_id":"82878914aacfe2c8dedf8b6d53664f5ab46a0af7"},{"author":{"_account_id":9659,"name":"Matt Wood","email":"matt.wood@hpe.com","username":"woodm1979"},"change_message_id":"06409c84e11089cad964df7ece276eafd7bec6a1","unresolved":false,"context_lines":[{"line_number":254,"context_line":"      var value \u003d $this.data(\u0027selectValue\u0027);"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"      // Go to the parent form-group and find the select"},{"line_number":257,"context_line":"      var $select \u003d $fancySelectParent.find(\u0027select\u0027);"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"      // Set the select if necessary"},{"line_number":260,"context_line":"      if($select.val() !\u003d\u003d value) {"}],"source_content_type":"text/javascript","patch_set":16,"id":"da6ed579_f4be9763","line":257,"in_reply_to":"da6ed579_5971060e","updated":"2016-01-15 22:12:19.000000000","message":"Done","commit_id":"82878914aacfe2c8dedf8b6d53664f5ab46a0af7"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"d701ff1826799d30206b963f80235348df1f2d3e","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    var $this \u003d $(this);"},{"line_number":269,"context_line":"    var thisVal \u003d $this.val();"},{"line_number":270,"context_line":"    var thisLabel \u003d $this.find(\u0027option[value\u003d\"\u0027 + thisVal + \u0027\"]\u0027).text();"},{"line_number":271,"context_line":"    var $title \u003d $this.parents(\u0027.fancy-select\u0027).find(\u0027.dropdown-title\u0027);"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    // Set dropdown title to first option if the select menu is unset"},{"line_number":274,"context_line":"    if (thisLabel \u003d\u003d\u003d null || thisLabel.length \u003d\u003d\u003d 0) {"}],"source_content_type":"text/javascript","patch_set":16,"id":"da6ed579_19e5cea6","line":271,"updated":"2016-01-15 01:23:25.000000000","message":"We can cache this guy using the same method above.","commit_id":"82878914aacfe2c8dedf8b6d53664f5ab46a0af7"},{"author":{"_account_id":9659,"name":"Matt Wood","email":"matt.wood@hpe.com","username":"woodm1979"},"change_message_id":"06409c84e11089cad964df7ece276eafd7bec6a1","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    var $this \u003d $(this);"},{"line_number":269,"context_line":"    var thisVal \u003d $this.val();"},{"line_number":270,"context_line":"    var thisLabel \u003d $this.find(\u0027option[value\u003d\"\u0027 + thisVal + \u0027\"]\u0027).text();"},{"line_number":271,"context_line":"    var $title \u003d $this.parents(\u0027.fancy-select\u0027).find(\u0027.dropdown-title\u0027);"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    // Set dropdown title to first option if the select menu is unset"},{"line_number":274,"context_line":"    if (thisLabel \u003d\u003d\u003d null || thisLabel.length \u003d\u003d\u003d 0) {"}],"source_content_type":"text/javascript","patch_set":16,"id":"da6ed579_f465371d","line":271,"in_reply_to":"da6ed579_19e5cea6","updated":"2016-01-15 22:12:19.000000000","message":"What element would I be storing this \"data\" on?  $this?\nThat seems to work, and seems to be caching it.  Figured I\u0027d check with you though.\n\n(I spoke with Diana, and that was what she was looking for.)\n\nDone","commit_id":"82878914aacfe2c8dedf8b6d53664f5ab46a0af7"},{"author":{"_account_id":9659,"name":"Matt Wood","email":"matt.wood@hpe.com","username":"woodm1979"},"change_message_id":"0fbbd40dda2448249ab9dc97f80a2512fde15cb5","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    var $this \u003d $(this);"},{"line_number":269,"context_line":"    var thisVal \u003d $this.val();"},{"line_number":270,"context_line":"    var thisLabel \u003d $this.find(\u0027option[value\u003d\"\u0027 + thisVal + \u0027\"]\u0027).text();"},{"line_number":271,"context_line":"    var $title \u003d $this.parents(\u0027.fancy-select\u0027).find(\u0027.dropdown-title\u0027);"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    // Set dropdown title to first option if the select menu is unset"},{"line_number":274,"context_line":"    if (thisLabel \u003d\u003d\u003d null || thisLabel.length \u003d\u003d\u003d 0) {"}],"source_content_type":"text/javascript","patch_set":16,"id":"ba63e191_d7ca236e","line":271,"in_reply_to":"da6ed579_f465371d","updated":"2016-01-19 18:19:43.000000000","message":"Upon further review, this one breaks things.  So I\u0027m reverting this particular change.","commit_id":"82878914aacfe2c8dedf8b6d53664f5ab46a0af7"}],"horizon/templates/horizon/common/fields/_themable_select.html":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"83c715e8a89e119384bbb69d02cabcc5e15e942f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% load horizon %}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{% minifyspace %}"},{"line_number":4,"context_line":"\u003cdiv class\u003d\"themable-select dropdown {% if not not_form_control %} form-control{% endif %}\" xmlns\u003d\"http://www.w3.org/1999/html\"\u003e"},{"line_number":5,"context_line":"  \u003cbutton type\u003d\"button\" class\u003d\"btn btn-default dropdown-toggle\""},{"line_number":6,"context_line":"          data-toggle\u003d\"dropdown\"{% if value %}"},{"line_number":7,"context_line":"          title\u003d\"{{ value }}\" {% endif %}"}],"source_content_type":"text/html","patch_set":45,"id":"9abb7d3a_189b5719","line":4,"range":{"start_line":4,"start_character":43,"end_line":4,"end_character":63},"updated":"2016-06-01 15:40:20.000000000","message":"Can we make the logic less strange here? Double negatives should be avoided.","commit_id":"dbaefc7ab665b2a1e43987e5cb10d6d4b27599bc"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"4a386e8d80e0ce0fb35779a47f0e8ac59a5266d4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% load horizon %}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{% minifyspace %}"},{"line_number":4,"context_line":"\u003cdiv class\u003d\"themable-select dropdown {% if not not_form_control %} form-control{% endif %}\" xmlns\u003d\"http://www.w3.org/1999/html\"\u003e"},{"line_number":5,"context_line":"  \u003cbutton type\u003d\"button\" class\u003d\"btn btn-default dropdown-toggle\""},{"line_number":6,"context_line":"          data-toggle\u003d\"dropdown\"{% if value %}"},{"line_number":7,"context_line":"          title\u003d\"{{ value }}\" {% endif %}"}],"source_content_type":"text/html","patch_set":45,"id":"9abb7d3a_81dfcf38","line":4,"range":{"start_line":4,"start_character":43,"end_line":4,"end_character":63},"in_reply_to":"9abb7d3a_189b5719","updated":"2016-06-01 16:24:07.000000000","message":"Done","commit_id":"dbaefc7ab665b2a1e43987e5cb10d6d4b27599bc"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"83c715e8a89e119384bbb69d02cabcc5e15e942f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    \u003c/span\u003e"},{"line_number":22,"context_line":"    \u003cspan class\u003d\"fa fa-caret-down\"\u003e\u003c/span\u003e"},{"line_number":23,"context_line":"  \u003c/button\u003e"},{"line_number":24,"context_line":"  \u003cul class\u003d\"dropdown-menu\"\u003e"},{"line_number":25,"context_line":"    {% for option in options %}"},{"line_number":26,"context_line":"      \u003cli data-original-index\u003d\"{{ forloop.counter0 }}\"\u003e"},{"line_number":27,"context_line":"        \u003ca data-select-value\u003d\"{{ option.0 }}\""}],"source_content_type":"text/html","patch_set":45,"id":"9abb7d3a_8884140b","line":24,"range":{"start_line":24,"start_character":13,"end_line":24,"end_character":26},"updated":"2016-06-01 15:40:20.000000000","message":"Combined with width:100%, adding dropdown-menu-right makes this much nicer on themes with arrow styling.","commit_id":"dbaefc7ab665b2a1e43987e5cb10d6d4b27599bc"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"4a386e8d80e0ce0fb35779a47f0e8ac59a5266d4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    \u003c/span\u003e"},{"line_number":22,"context_line":"    \u003cspan class\u003d\"fa fa-caret-down\"\u003e\u003c/span\u003e"},{"line_number":23,"context_line":"  \u003c/button\u003e"},{"line_number":24,"context_line":"  \u003cul class\u003d\"dropdown-menu\"\u003e"},{"line_number":25,"context_line":"    {% for option in options %}"},{"line_number":26,"context_line":"      \u003cli data-original-index\u003d\"{{ forloop.counter0 }}\"\u003e"},{"line_number":27,"context_line":"        \u003ca data-select-value\u003d\"{{ option.0 }}\""}],"source_content_type":"text/html","patch_set":45,"id":"9abb7d3a_6108ebda","line":24,"range":{"start_line":24,"start_character":13,"end_line":24,"end_character":26},"in_reply_to":"9abb7d3a_8884140b","updated":"2016-06-01 16:24:07.000000000","message":"Did the 100%, but not sure if I agree with the dropdown-menu-right being a global change.  I did, however, add it to the \u0027default\u0027 theme through an @extend","commit_id":"dbaefc7ab665b2a1e43987e5cb10d6d4b27599bc"}],"horizon/templatetags/horizon.py":[{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"851dd38cee461415d45b7f376c69ee67f8fbc069","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def render(self, context):"},{"line_number":39,"context_line":"        return \u0027 \u0027.join("},{"line_number":40,"context_line":"            force_text(self.nodelist.render(context).strip()).split()"},{"line_number":41,"context_line":"        ).replace(\u0027 \u003e \u0027, \u0027\u003e\u0027).replace(\u0027 \u003c\u0027, \u0027\u003c\u0027)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"@register.filter"}],"source_content_type":"text/x-python","patch_set":16,"id":"da6ed579_b9ada29c","line":41,"updated":"2016-01-15 01:14:55.000000000","message":"This is a whee-bit hackish.  A better solution is on its way.","commit_id":"82878914aacfe2c8dedf8b6d53664f5ab46a0af7"}],"openstack_dashboard/dashboards/project/images/images/forms.py":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"257c32530f51e84b65c96d12dca874b102db32de","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        widget\u003dforms.SelectWidget("},{"line_number":136,"context_line":"            transform\u003dlambda x: \"%s (%s)\" % ("},{"line_number":137,"context_line":"                x.name, defaultfilters.filesizeformat(x.size))))"},{"line_number":138,"context_line":"    disk_format \u003d forms.ChoiceField(label\u003d_(\u0027Format\u0027),"},{"line_number":139,"context_line":"                                    choices\u003d[],"},{"line_number":140,"context_line":"                                    widget\u003dforms.SelectWidget(attrs\u003d{"},{"line_number":141,"context_line":"                                        \u0027class\u0027: \u0027switchable\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba63e191_9002710a","line":138,"range":{"start_line":138,"start_character":24,"end_line":138,"end_character":53},"updated":"2016-01-19 19:34:43.000000000","message":"I understand that the choices include \"Select format\" in a way, but it actually looks odd to see that as a selectable choice in the drop down section.  Is there a more intuitive way to provide the placeholder name, while yet restricting it from the list of selectable items?","commit_id":"b896feccc728a6f2839d0372a1bbcff8c21c61d4"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"f7305b9cc8130e7e76122de6e3a34c513a8f4be5","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        widget\u003dforms.SelectWidget("},{"line_number":136,"context_line":"            transform\u003dlambda x: \"%s (%s)\" % ("},{"line_number":137,"context_line":"                x.name, defaultfilters.filesizeformat(x.size))))"},{"line_number":138,"context_line":"    disk_format \u003d forms.ChoiceField(label\u003d_(\u0027Format\u0027),"},{"line_number":139,"context_line":"                                    choices\u003d[],"},{"line_number":140,"context_line":"                                    widget\u003dforms.SelectWidget(attrs\u003d{"},{"line_number":141,"context_line":"                                        \u0027class\u0027: \u0027switchable\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a68dd71_b9379de2","line":138,"range":{"start_line":138,"start_character":24,"end_line":138,"end_character":53},"in_reply_to":"9a68dd71_15cc6f34","updated":"2016-01-20 16:00:16.000000000","message":"Agreed, it\u0027s a UX improvement for later.  Thanks!","commit_id":"b896feccc728a6f2839d0372a1bbcff8c21c61d4"},{"author":{"_account_id":9659,"name":"Matt Wood","email":"matt.wood@hpe.com","username":"woodm1979"},"change_message_id":"0667934450468aa84eed01e83c2e49ffa20137b6","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        widget\u003dforms.SelectWidget("},{"line_number":136,"context_line":"            transform\u003dlambda x: \"%s (%s)\" % ("},{"line_number":137,"context_line":"                x.name, defaultfilters.filesizeformat(x.size))))"},{"line_number":138,"context_line":"    disk_format \u003d forms.ChoiceField(label\u003d_(\u0027Format\u0027),"},{"line_number":139,"context_line":"                                    choices\u003d[],"},{"line_number":140,"context_line":"                                    widget\u003dforms.SelectWidget(attrs\u003d{"},{"line_number":141,"context_line":"                                        \u0027class\u0027: \u0027switchable\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba63e191_cb783ec7","line":138,"range":{"start_line":138,"start_character":24,"end_line":138,"end_character":53},"in_reply_to":"ba63e191_9002710a","updated":"2016-01-19 19:49:41.000000000","message":"I think we can look into some options for that, but it\u0027s rather much outside the scope of this patch.  I\u0027m attempting to allow styling to the standard selects in a somewhat drop-in/straight-replacement style.\n\nBut I\u0027m definitely not against looking into this going forward.  :-D","commit_id":"b896feccc728a6f2839d0372a1bbcff8c21c61d4"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"7bed70cdfba601f3caf38b8f8599d5d463f0ef34","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        widget\u003dforms.SelectWidget("},{"line_number":136,"context_line":"            transform\u003dlambda x: \"%s (%s)\" % ("},{"line_number":137,"context_line":"                x.name, defaultfilters.filesizeformat(x.size))))"},{"line_number":138,"context_line":"    disk_format \u003d forms.ChoiceField(label\u003d_(\u0027Format\u0027),"},{"line_number":139,"context_line":"                                    choices\u003d[],"},{"line_number":140,"context_line":"                                    widget\u003dforms.SelectWidget(attrs\u003d{"},{"line_number":141,"context_line":"                                        \u0027class\u0027: \u0027switchable\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a68dd71_15cc6f34","line":138,"range":{"start_line":138,"start_character":24,"end_line":138,"end_character":53},"in_reply_to":"ba63e191_cb783ec7","updated":"2016-01-20 15:57:15.000000000","message":"Its meant to be a direct replacement.  Any changes beyond that will provoke massive discussion AND someone might bring in UX for feedback.  I feel that that is beyond the scope of this particular review.","commit_id":"b896feccc728a6f2839d0372a1bbcff8c21c61d4"}],"openstack_dashboard/static/dashboard/scss/components/_dropdowns.scss":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"83c715e8a89e119384bbb69d02cabcc5e15e942f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  \u0026.btn-primary {"},{"line_number":38,"context_line":"    color: $brand-primary;"},{"line_number":39,"context_line":"  }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  \u0026.btn-danger {"},{"line_number":42,"context_line":"    color: $brand-danger;"},{"line_number":43,"context_line":"  }"}],"source_content_type":"text/x-scss","patch_set":45,"id":"9abb7d3a_10c40b8f","line":40,"updated":"2016-06-01 15:40:20.000000000","message":"\u003e.\u003c","commit_id":"dbaefc7ab665b2a1e43987e5cb10d6d4b27599bc"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"4a386e8d80e0ce0fb35779a47f0e8ac59a5266d4","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  \u0026.btn-primary {"},{"line_number":38,"context_line":"    color: $brand-primary;"},{"line_number":39,"context_line":"  }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  \u0026.btn-danger {"},{"line_number":42,"context_line":"    color: $brand-danger;"},{"line_number":43,"context_line":"  }"}],"source_content_type":"text/x-scss","patch_set":45,"id":"9abb7d3a_068bf568","line":40,"in_reply_to":"9abb7d3a_10c40b8f","updated":"2016-06-01 16:24:07.000000000","message":"ಠ◡ಠ","commit_id":"dbaefc7ab665b2a1e43987e5cb10d6d4b27599bc"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"83c715e8a89e119384bbb69d02cabcc5e15e942f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  \u0026.btn-danger {"},{"line_number":42,"context_line":"    color: $brand-danger;"},{"line_number":43,"context_line":"  }"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  \u0026.btn-warning {"},{"line_number":46,"context_line":"    color: $brand-warning;"},{"line_number":47,"context_line":"  }"}],"source_content_type":"text/x-scss","patch_set":45,"id":"9abb7d3a_f03fc784","line":44,"updated":"2016-06-01 15:40:20.000000000","message":"0.o","commit_id":"dbaefc7ab665b2a1e43987e5cb10d6d4b27599bc"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"4a386e8d80e0ce0fb35779a47f0e8ac59a5266d4","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  \u0026.btn-danger {"},{"line_number":42,"context_line":"    color: $brand-danger;"},{"line_number":43,"context_line":"  }"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  \u0026.btn-warning {"},{"line_number":46,"context_line":"    color: $brand-warning;"},{"line_number":47,"context_line":"  }"}],"source_content_type":"text/x-scss","patch_set":45,"id":"9abb7d3a_a6f2e903","line":44,"in_reply_to":"9abb7d3a_f03fc784","updated":"2016-06-01 16:24:07.000000000","message":"ಠ◡ಠ","commit_id":"dbaefc7ab665b2a1e43987e5cb10d6d4b27599bc"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"83c715e8a89e119384bbb69d02cabcc5e15e942f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  \u0026.btn-warning {"},{"line_number":46,"context_line":"    color: $brand-warning;"},{"line_number":47,"context_line":"  }"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  \u0026.btn-info {"},{"line_number":50,"context_line":"    color: $brand-info;"},{"line_number":51,"context_line":"  }"}],"source_content_type":"text/x-scss","patch_set":45,"id":"9abb7d3a_505173d7","line":48,"updated":"2016-06-01 15:40:20.000000000","message":":/","commit_id":"dbaefc7ab665b2a1e43987e5cb10d6d4b27599bc"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"4a386e8d80e0ce0fb35779a47f0e8ac59a5266d4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  \u0026.btn-warning {"},{"line_number":46,"context_line":"    color: $brand-warning;"},{"line_number":47,"context_line":"  }"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  \u0026.btn-info {"},{"line_number":50,"context_line":"    color: $brand-info;"},{"line_number":51,"context_line":"  }"}],"source_content_type":"text/x-scss","patch_set":45,"id":"9abb7d3a_e6e0712b","line":48,"in_reply_to":"9abb7d3a_505173d7","updated":"2016-06-01 16:24:07.000000000","message":"ಠ◡ಠ","commit_id":"dbaefc7ab665b2a1e43987e5cb10d6d4b27599bc"}],"openstack_dashboard/static/dashboard/scss/components/_fancy_select.scss":[{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"0ed339ac5883970f09d8fd927bd71dd61807e97d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  select.form-control {"},{"line_number":40,"context_line":"    display: none;"},{"line_number":41,"context_line":"  }"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"form:not(.form-inline) .form-group .fancy-select {"}],"source_content_type":"text/x-scss","patch_set":16,"id":"da6ed579_59a7c6a9","line":42,"updated":"2016-01-15 01:17:02.000000000","message":"Extra space here","commit_id":"82878914aacfe2c8dedf8b6d53664f5ab46a0af7"},{"author":{"_account_id":9659,"name":"Matt Wood","email":"matt.wood@hpe.com","username":"woodm1979"},"change_message_id":"06409c84e11089cad964df7ece276eafd7bec6a1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  select.form-control {"},{"line_number":40,"context_line":"    display: none;"},{"line_number":41,"context_line":"  }"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"form:not(.form-inline) .form-group .fancy-select {"}],"source_content_type":"text/x-scss","patch_set":16,"id":"da6ed579_0a530018","line":42,"in_reply_to":"da6ed579_59a7c6a9","updated":"2016-01-15 22:12:19.000000000","message":"Done","commit_id":"82878914aacfe2c8dedf8b6d53664f5ab46a0af7"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"0ed339ac5883970f09d8fd927bd71dd61807e97d","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"form:not(.form-inline) .form-group .fancy-select {"},{"line_number":46,"context_line":"  width: 100%;"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  .dropdown-toggle {"}],"source_content_type":"text/x-scss","patch_set":16,"id":"da6ed579_d9b976cd","line":45,"updated":"2016-01-15 01:17:02.000000000","message":"This seems crafty.  Can we provide a quick comment about what it is accomplishing for future devs?","commit_id":"82878914aacfe2c8dedf8b6d53664f5ab46a0af7"},{"author":{"_account_id":9659,"name":"Matt Wood","email":"matt.wood@hpe.com","username":"woodm1979"},"change_message_id":"06409c84e11089cad964df7ece276eafd7bec6a1","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"form:not(.form-inline) .form-group .fancy-select {"},{"line_number":46,"context_line":"  width: 100%;"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  .dropdown-toggle {"}],"source_content_type":"text/x-scss","patch_set":16,"id":"da6ed579_d8161958","line":45,"in_reply_to":"da6ed579_d9b976cd","updated":"2016-01-15 22:12:19.000000000","message":"Done","commit_id":"82878914aacfe2c8dedf8b6d53664f5ab46a0af7"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"257c32530f51e84b65c96d12dca874b102db32de","unresolved":false,"context_lines":[{"line_number":1,"context_line":"@import \u0027/horizon/lib/font-awesome/scss/variables\u0027;"},{"line_number":2,"context_line":"@import \u0027/horizon/lib/font-awesome/scss/mixins\u0027;"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"//"}],"source_content_type":"text/x-scss","patch_set":20,"id":"ba63e191_0b6f36c6","line":1,"updated":"2016-01-19 19:34:43.000000000","message":"Shouldn\u0027t this get renamed (since we\u0027re not using \u0027FancySelect\u0027 anymore)?","commit_id":"b896feccc728a6f2839d0372a1bbcff8c21c61d4"},{"author":{"_account_id":9659,"name":"Matt Wood","email":"matt.wood@hpe.com","username":"woodm1979"},"change_message_id":"0667934450468aa84eed01e83c2e49ffa20137b6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"@import \u0027/horizon/lib/font-awesome/scss/variables\u0027;"},{"line_number":2,"context_line":"@import \u0027/horizon/lib/font-awesome/scss/mixins\u0027;"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"//"}],"source_content_type":"text/x-scss","patch_set":20,"id":"ba63e191_260d8f37","line":1,"in_reply_to":"ba63e191_0b6f36c6","updated":"2016-01-19 19:49:41.000000000","message":"Diana had a reason why we shouldn\u0027t.  I must confess, I kinda just went with it.  I personally don\u0027t really care what we label this as.  :-)","commit_id":"b896feccc728a6f2839d0372a1bbcff8c21c61d4"}],"openstack_dashboard/static/dashboard/scss/components/_selects.scss":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"83c715e8a89e119384bbb69d02cabcc5e15e942f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      background-color: $input-bg;"},{"line_number":39,"context_line":"      background-image: none; // Reset unusual Firefox-on-Android default style; see https://github.com/necolas/normalize.css/issues/214"},{"line_number":40,"context_line":"      border-color: $input-border;"},{"line_number":41,"context_line":"      max-width: 100%;"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"      li \u003e a {"},{"line_number":44,"context_line":"        @include text-overflow();"}],"source_content_type":"text/x-scss","patch_set":45,"id":"9abb7d3a_a825985c","line":41,"updated":"2016-06-01 15:40:20.000000000","message":"Can we have width: 100% too? The effect is much nicer on every theme.","commit_id":"dbaefc7ab665b2a1e43987e5cb10d6d4b27599bc"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"4a386e8d80e0ce0fb35779a47f0e8ac59a5266d4","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      background-color: $input-bg;"},{"line_number":39,"context_line":"      background-image: none; // Reset unusual Firefox-on-Android default style; see https://github.com/necolas/normalize.css/issues/214"},{"line_number":40,"context_line":"      border-color: $input-border;"},{"line_number":41,"context_line":"      max-width: 100%;"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"      li \u003e a {"},{"line_number":44,"context_line":"        @include text-overflow();"}],"source_content_type":"text/x-scss","patch_set":45,"id":"9abb7d3a_0150ffd2","line":41,"in_reply_to":"9abb7d3a_a825985c","updated":"2016-06-01 16:24:07.000000000","message":"Done","commit_id":"dbaefc7ab665b2a1e43987e5cb10d6d4b27599bc"}],"openstack_dashboard/static/dashboard/scss/horizon.scss":[{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"9ffb7f0d3700200c84c1f741fdb1caa3de200902","unresolved":false,"context_lines":[{"line_number":36,"context_line":"@import \"components/tables\";"},{"line_number":37,"context_line":"@import \"components/messages\";"},{"line_number":38,"context_line":"@import \"components/table_actions\";"},{"line_number":39,"context_line":"@import \"components/fancy_select\";"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"// Contrib stuff"},{"line_number":42,"context_line":"@import \"contrib\";"}],"source_content_type":"text/x-scss","patch_set":16,"id":"da6ed579_3971b244","line":39,"updated":"2016-01-15 01:15:50.000000000","message":"If this is going to touch horizon.scss, then can we make it live on the end of the patch train that is currently refactoring it?","commit_id":"82878914aacfe2c8dedf8b6d53664f5ab46a0af7"},{"author":{"_account_id":9659,"name":"Matt Wood","email":"matt.wood@hpe.com","username":"woodm1979"},"change_message_id":"06409c84e11089cad964df7ece276eafd7bec6a1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"@import \"components/tables\";"},{"line_number":37,"context_line":"@import \"components/messages\";"},{"line_number":38,"context_line":"@import \"components/table_actions\";"},{"line_number":39,"context_line":"@import \"components/fancy_select\";"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"// Contrib stuff"},{"line_number":42,"context_line":"@import \"contrib\";"}],"source_content_type":"text/x-scss","patch_set":16,"id":"da6ed579_f81bdd7e","line":39,"in_reply_to":"da6ed579_3971b244","updated":"2016-01-15 22:12:19.000000000","message":"Done","commit_id":"82878914aacfe2c8dedf8b6d53664f5ab46a0af7"}]}
