)]}'
{"openstack_dashboard/static/app/app.module.js":[{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"f5f3113ee0b893ed0e09e3b2da70b01bb6eb1a1f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    $locationProvider.html5Mode(true).hashPrefix(\u0027!\u0027);"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    $routeProvider"},{"line_number":76,"context_line":"      .otherwise({"},{"line_number":77,"context_line":"        template: \u0027\u0027,"},{"line_number":78,"context_line":"        controller: \u0027RedirectController\u0027"},{"line_number":79,"context_line":"      });"}],"source_content_type":"text/javascript","patch_set":4,"id":"da6ed579_7e4e8b70","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":6},"updated":"2016-01-13 16:42:42.000000000","message":"-1: The reason for this is subtle enough that it deserves a comment. Something like:\n\nSetting a default Angular route which will apply If a link is clicked that doesn\u0027t match any current Angular route.","commit_id":"956c9716f0f707138d1ae7df721a8be731aeee90"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"df38224c2ad29556f5e626b343d41f1887b4ae95","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    $locationProvider.html5Mode(true).hashPrefix(\u0027!\u0027);"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    $routeProvider"},{"line_number":76,"context_line":"      .otherwise({"},{"line_number":77,"context_line":"        template: \u0027\u0027,"},{"line_number":78,"context_line":"        controller: \u0027RedirectController\u0027"},{"line_number":79,"context_line":"      });"}],"source_content_type":"text/javascript","patch_set":4,"id":"da6ed579_ef6e432e","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":6},"in_reply_to":"da6ed579_7e4e8b70","updated":"2016-01-13 17:35:00.000000000","message":"Done","commit_id":"956c9716f0f707138d1ae7df721a8be731aeee90"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"52102eb7b22664e3d159142cbd3948c9a5c7c2c2","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            .concat(horizonBuiltInModules)"},{"line_number":62,"context_line":"            .concat(horizonPlugInModules)"},{"line_number":63,"context_line":"           )"},{"line_number":64,"context_line":"    .config(configHorizon)"},{"line_number":65,"context_line":"    .run(updateHorizon);"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  configHorizon.$inject \u003d ["}],"source_content_type":"text/javascript","patch_set":6,"id":"ba63e191_d3f6a1f8","line":64,"updated":"2016-01-20 02:44:53.000000000","message":"I would prefer if unnecessary indentation changes like this could be avoided, it\u0027s a distraction for review.","commit_id":"ac695d016ae7fef0064673a5d15af792adb3e8cc"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"514eccc690f60aeb5d7eda8bf1614ede4ed968da","unresolved":false,"context_lines":[{"line_number":76,"context_line":"   *"},{"line_number":77,"context_line":"   * It also sets the default Angular route which will apply if"},{"line_number":78,"context_line":"   * a link is clicked that doesn\u0027t match any current Angular route."},{"line_number":79,"context_line":"   *"},{"line_number":80,"context_line":"   */"},{"line_number":81,"context_line":"  function configHorizon($locationProvider, $routeProvider) {"},{"line_number":82,"context_line":"    $locationProvider.html5Mode(true).hashPrefix(\u0027!\u0027);"}],"source_content_type":"text/javascript","patch_set":6,"id":"ba63e191_96b4a2f2","line":79,"updated":"2016-01-19 22:46:33.000000000","message":"non-blocking (for me anyway) nit: extra blank line.","commit_id":"ac695d016ae7fef0064673a5d15af792adb3e8cc"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"52102eb7b22664e3d159142cbd3948c9a5c7c2c2","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    hzUtils,"},{"line_number":104,"context_line":"    $cookieStore,"},{"line_number":105,"context_line":"    $http,"},{"line_number":106,"context_line":"    $cookies"},{"line_number":107,"context_line":"  ) {"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    $http.defaults.headers.post[\u0027X-CSRFToken\u0027] \u003d $cookies.csrftoken;"}],"source_content_type":"text/javascript","patch_set":6,"id":"ba63e191_b341ad0d","line":106,"updated":"2016-01-20 02:44:53.000000000","message":"Same here, this is just indentation changes, and it takes a while to read through them to ensure no code changes, which takes time I could spend on other things.","commit_id":"ac695d016ae7fef0064673a5d15af792adb3e8cc"}],"openstack_dashboard/static/app/redirect.controller.js":[{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"f5f3113ee0b893ed0e09e3b2da70b01bb6eb1a1f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \u0027horizon.framework.widgets.modal-wait-spinner.service\u0027"},{"line_number":25,"context_line":"  ];"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  /**"},{"line_number":28,"context_line":"   * @ngdoc controller"},{"line_number":29,"context_line":"   * @name RedirectController"},{"line_number":30,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":4,"id":"da6ed579_be91639b","line":27,"range":{"start_line":27,"start_character":2,"end_line":27,"end_character":5},"updated":"2016-01-13 16:42:42.000000000","message":"-1: Again, just subtle enough that a better explanation will prevent future problems. How about:\n\nForce a reload from the server. This is used when a clicked link doesn\u0027t match any current Angular route. It gives the Django code a chance to try and find a matching template for the requested URL.","commit_id":"956c9716f0f707138d1ae7df721a8be731aeee90"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"df38224c2ad29556f5e626b343d41f1887b4ae95","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \u0027horizon.framework.widgets.modal-wait-spinner.service\u0027"},{"line_number":25,"context_line":"  ];"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  /**"},{"line_number":28,"context_line":"   * @ngdoc controller"},{"line_number":29,"context_line":"   * @name RedirectController"},{"line_number":30,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":4,"id":"da6ed579_ef8ac3be","line":27,"range":{"start_line":27,"start_character":2,"end_line":27,"end_character":5},"in_reply_to":"da6ed579_be91639b","updated":"2016-01-13 17:35:00.000000000","message":"Done","commit_id":"956c9716f0f707138d1ae7df721a8be731aeee90"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"f5f3113ee0b893ed0e09e3b2da70b01bb6eb1a1f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"   * @description"},{"line_number":32,"context_line":"   * Controller to redirect to current location."},{"line_number":33,"context_line":"   */"},{"line_number":34,"context_line":"  function RedirectController($window, $location, waitSpinnerService) {"},{"line_number":35,"context_line":"    waitSpinnerService.showModalSpinner(\u0027\u0027);"},{"line_number":36,"context_line":"    $window.location.href \u003d $location.path();"},{"line_number":37,"context_line":"  }"}],"source_content_type":"text/javascript","patch_set":4,"id":"da6ed579_5e394740","line":34,"range":{"start_line":34,"start_character":11,"end_line":34,"end_character":29},"updated":"2016-01-13 16:42:42.000000000","message":"nit: Not critical, but it would be cool if the current page remained behind the spinner while waiting for the redirect. I\u0027ll experiment a little to see if this might be possible.","commit_id":"956c9716f0f707138d1ae7df721a8be731aeee90"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"f5f3113ee0b893ed0e09e3b2da70b01bb6eb1a1f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"   * Controller to redirect to current location."},{"line_number":33,"context_line":"   */"},{"line_number":34,"context_line":"  function RedirectController($window, $location, waitSpinnerService) {"},{"line_number":35,"context_line":"    waitSpinnerService.showModalSpinner(\u0027\u0027);"},{"line_number":36,"context_line":"    $window.location.href \u003d $location.path();"},{"line_number":37,"context_line":"  }"},{"line_number":38,"context_line":""}],"source_content_type":"text/javascript","patch_set":4,"id":"da6ed579_5e9dc757","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":4},"updated":"2016-01-13 16:42:42.000000000","message":"-1: Spinner shows default text \"...\". To be consistent with legacy spinner, it should show \"Loading...\".\n\nwaitSpinnerService.showModalSpinner(\u0027Loading\u0027)","commit_id":"956c9716f0f707138d1ae7df721a8be731aeee90"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"df38224c2ad29556f5e626b343d41f1887b4ae95","unresolved":false,"context_lines":[{"line_number":32,"context_line":"   * Controller to redirect to current location."},{"line_number":33,"context_line":"   */"},{"line_number":34,"context_line":"  function RedirectController($window, $location, waitSpinnerService) {"},{"line_number":35,"context_line":"    waitSpinnerService.showModalSpinner(\u0027\u0027);"},{"line_number":36,"context_line":"    $window.location.href \u003d $location.path();"},{"line_number":37,"context_line":"  }"},{"line_number":38,"context_line":""}],"source_content_type":"text/javascript","patch_set":4,"id":"da6ed579_4a72ddae","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":4},"in_reply_to":"da6ed579_5e9dc757","updated":"2016-01-13 17:35:00.000000000","message":"Done","commit_id":"956c9716f0f707138d1ae7df721a8be731aeee90"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"514eccc690f60aeb5d7eda8bf1614ede4ed968da","unresolved":false,"context_lines":[{"line_number":32,"context_line":"   * @description"},{"line_number":33,"context_line":"   * Controller to redirect to current location."},{"line_number":34,"context_line":"   * It forces a reload from the server when the clicked link doesn\u0027t match"},{"line_number":35,"context_line":"   * an current Angular route configured in the $routeProvider Service."},{"line_number":36,"context_line":"   *"},{"line_number":37,"context_line":"   * This controller is used in the \u0027otherwise\u0027 of the $routeProvider Service."},{"line_number":38,"context_line":"   * It gives the Django code a chance to try and find a matching template for the requested URL."}],"source_content_type":"text/javascript","patch_set":6,"id":"ba63e191_76f48e86","line":35,"updated":"2016-01-19 22:46:33.000000000","message":"nit: \"a\" not \"an\"","commit_id":"ac695d016ae7fef0064673a5d15af792adb3e8cc"}]}
