)]}'
{"openstack_dashboard/dashboards/identity/projects/tables.py":[{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"98a861f646840625ee9420b170c19222bd83b40d","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        return response"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"class TenantFilterAction(tables.FilterAction):"},{"line_number":166,"context_line":"    def filter(self, table, tenants, filter_string):"},{"line_number":167,"context_line":"        \"\"\"Really naive case-insensitive search.\"\"\""},{"line_number":168,"context_line":"        q \u003d filter_string.lower()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_1fec4e8e","line":165,"range":{"start_line":165,"start_character":6,"end_line":165,"end_character":24},"updated":"2016-01-13 06:04:25.000000000","message":"you can remove this class and use a common name filter (tables.NameFilterAction). no need to of a subclass here.","commit_id":"151deba07761a95424974b21601e326b771159e2"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"dc7b1798186c9a7cf5dcd39c3353414e1f2e5fb3","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        return response"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"class TenantFilterAction(tables.FilterAction):"},{"line_number":166,"context_line":"    def filter(self, table, tenants, filter_string):"},{"line_number":167,"context_line":"        \"\"\"Really naive case-insensitive search.\"\"\""},{"line_number":168,"context_line":"        q \u003d filter_string.lower()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_6896ed4d","line":165,"range":{"start_line":165,"start_character":6,"end_line":165,"end_character":24},"in_reply_to":"da6ed579_1fec4e8e","updated":"2016-01-13 07:56:23.000000000","message":"Do you mean change to as following ?\n\nclass TenantFilterAction():\n    pass\n\nActually I am confused why \"def filter()\" does not work to filter as specified field. refer:https://bugs.launchpad.net/horizon/+bug/1533514","commit_id":"151deba07761a95424974b21601e326b771159e2"},{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"1cc0ecd0194fbf3d3ded88663bf6ae8c271803d4","unresolved":false,"context_lines":[{"line_number":165,"context_line":"class TenantFilterAction(tables.FilterAction):"},{"line_number":166,"context_line":"    def filter(self, table, tenants, filter_string):"},{"line_number":167,"context_line":"        \"\"\"Really naive case-insensitive search.\"\"\""},{"line_number":168,"context_line":"        # FIXME(gabriel): This should be smarter. Written for demo purposes."},{"line_number":169,"context_line":"        q \u003d filter_string.lower()"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        def comp(tenant):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_115cb37b","side":"PARENT","line":168,"updated":"2016-02-18 15:19:28.000000000","message":"I\u0027m not sure that should be smarter is about codestyle. As for, it is about making more smart filtering, isn\u0027t it? I\u0027m not against of refactoring, but I\u0027m not sure that it is related to this #FIXME.","commit_id":"21374785ed43b4b157d9f1c4d5713ede47fe7d7b"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"716bfdbdff3c4955dcad3de3fc72265cc4312c65","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        return response"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"class TenantFilterAction(tables.FilterAction):"},{"line_number":166,"context_line":"    def filter(self, table, tenants, filter_string):"},{"line_number":167,"context_line":"        \"\"\"Naive case-insensitive search.\"\"\""},{"line_number":168,"context_line":"        q \u003d filter_string.lower()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_c94165ab","line":165,"updated":"2016-02-29 05:55:22.000000000","message":"Could you use the \"NameFilterAction\" ?\nIf possible, this class will be unnecessary.\n\nThanks.","commit_id":"9c0f8074f3b0a669360483e57e9a3196158d005d"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"a1bfbe93072026f6919bd45c23d5f4aa1f9e1fe3","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        return response"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"class TenantFilterAction(tables.FilterAction):"},{"line_number":166,"context_line":"    def filter(self, table, tenants, filter_string):"},{"line_number":167,"context_line":"        \"\"\"Naive case-insensitive search.\"\"\""},{"line_number":168,"context_line":"        q \u003d filter_string.lower()"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_dc391fd9","line":165,"in_reply_to":"9aed3d3a_c94165ab","updated":"2016-03-03 03:41:08.000000000","message":"Thanks for your comments.\n\nAgree with you, fix it in patch set 4.","commit_id":"9c0f8074f3b0a669360483e57e9a3196158d005d"}]}
