)]}'
{"openstack_dashboard/test/integration_tests/pages/project/network/routerspage.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"5879adf42d6c28678fdf9a73e2129cc0dcdcadd9","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        def get_router_name():"},{"line_number":83,"context_line":"            return row.cells[self.ROUTERS_TABLE_NAME_COLUMN]"},{"line_number":84,"context_line":"        set_gateway_form \u003d self.routers_table.set_gateway(row)"},{"line_number":85,"context_line":"        set_gateway_form.network_id.text \u003d network_id"},{"line_number":86,"context_line":"        set_gateway_form.router_name.value \u003d get_router_name()"},{"line_number":87,"context_line":"        set_gateway_form.router_id.value \u003d router_id"},{"line_number":88,"context_line":"        set_gateway_form.submit()"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_d24a2255","line":85,"updated":"2016-02-24 22:09:19.000000000","message":"I would name it network_name, not network_id (since ids usually are in UUID format).","commit_id":"bf2d086e9331679110ff04d5852988afa7560850"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"5879adf42d6c28678fdf9a73e2129cc0dcdcadd9","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            return row.cells[self.ROUTERS_TABLE_NAME_COLUMN]"},{"line_number":84,"context_line":"        set_gateway_form \u003d self.routers_table.set_gateway(row)"},{"line_number":85,"context_line":"        set_gateway_form.network_id.text \u003d network_id"},{"line_number":86,"context_line":"        set_gateway_form.router_name.value \u003d get_router_name()"},{"line_number":87,"context_line":"        set_gateway_form.router_id.value \u003d router_id"},{"line_number":88,"context_line":"        set_gateway_form.submit()"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_f2ec862b","line":86,"updated":"2016-02-24 22:09:19.000000000","message":"This and below fields actually cannot be set in this form, since they are read-only. I think it should be changed in future (raising an error when we try to set value here?), but for now let\u0027s just remove them.","commit_id":"bf2d086e9331679110ff04d5852988afa7560850"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"5879adf42d6c28678fdf9a73e2129cc0dcdcadd9","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        def cell_getter():"},{"line_number":130,"context_line":"            return row.cells[self.ROUTERS_TABLE_NETWORK_COLUMN]"},{"line_number":131,"context_line":"        try:"},{"line_number":132,"context_line":"            self._wait_till_text_present_in_element(cell_getter, \u0027public\u0027)"},{"line_number":133,"context_line":"        except exceptions.TimeoutException:"},{"line_number":134,"context_line":"            return False"},{"line_number":135,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_72c0767d","line":132,"updated":"2016-02-24 22:09:19.000000000","message":"\u0027public\u0027 value actually should be passed as a default argument to is_gateway_set() method (like in set_gateway() method).","commit_id":"bf2d086e9331679110ff04d5852988afa7560850"}]}
