)]}'
{"openstack_dashboard/test/integration_tests/pages/project/compute/volumes/volumespage.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"3f1e1ad9840305eb20fedb8a7398ddc2b8613d6f","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    CREATE_VOLUME_SNAPSHOT_FORM_FIELDS \u003d (\"name\", \"description\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    EXTEND_VOLUME_FORM_FIELDS \u003d (("},{"line_number":38,"context_line":"        \"orig_size\", \"new_size\"))"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    UPLOAD_VOLUME_FORM_FIELDS \u003d (("}],"source_content_type":"text/x-python","patch_set":30,"id":"7af24918_8548615d","line":37,"updated":"2016-03-01 12:50:38.000000000","message":"You don\u0027t need outer parens here, because for FormRegion you just need a tuple of field ids (or a dictionary), the outer tuple (which actually you don\u0027t have here - trailing comma is missing) is meant to be used for TabbedFormRegion, it denotes different tabs\u0027 fields.\n\nAlso, all fields could be placed on a single line.","commit_id":"340a7449b72ae05e8c14608f1b81718371c12709"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"3f1e1ad9840305eb20fedb8a7398ddc2b8613d6f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        \"orig_size\", \"new_size\"))"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    UPLOAD_VOLUME_FORM_FIELDS \u003d (("},{"line_number":41,"context_line":"        \"image_name\", \"disk_format\"))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @tables.bind_table_action(\u0027create\u0027)"},{"line_number":44,"context_line":"    def create_volume(self, create_button):"}],"source_content_type":"text/x-python","patch_set":30,"id":"7af24918_c578a992","line":41,"updated":"2016-03-01 12:50:38.000000000","message":"ditto","commit_id":"340a7449b72ae05e8c14608f1b81718371c12709"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"3f1e1ad9840305eb20fedb8a7398ddc2b8613d6f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    @tables.bind_row_action(\u0027extend\u0027)"},{"line_number":69,"context_line":"    def extend_volume(self, extend_button, row):"},{"line_number":70,"context_line":"        extend_button.click()"},{"line_number":71,"context_line":"        return forms.FormRegion(self.driver, self.conf, None,"},{"line_number":72,"context_line":"                                self.EXTEND_VOLUME_FORM_FIELDS)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @tables.bind_row_action(\u0027upload_to_image\u0027)"}],"source_content_type":"text/x-python","patch_set":30,"id":"7af24918_05f8d1e4","line":71,"updated":"2016-03-01 12:50:38.000000000","message":"You could use another notation here: forms.FormRegion(self.driver, self.conf, field_mappings\u003dself.EXTEND_VOLUME_FORM_FIELDS)","commit_id":"340a7449b72ae05e8c14608f1b81718371c12709"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"3f1e1ad9840305eb20fedb8a7398ddc2b8613d6f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    @tables.bind_row_action(\u0027upload_to_image\u0027)"},{"line_number":75,"context_line":"    def upload_volume_to_image(self, upload_button, row):"},{"line_number":76,"context_line":"        upload_button.click()"},{"line_number":77,"context_line":"        return forms.FormRegion(self.driver, self.conf, None,"},{"line_number":78,"context_line":"                                self.UPLOAD_VOLUME_FORM_FIELDS)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"7af24918_85e4e13b","line":77,"updated":"2016-03-01 12:50:38.000000000","message":"ditto","commit_id":"340a7449b72ae05e8c14608f1b81718371c12709"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"3f1e1ad9840305eb20fedb8a7398ddc2b8613d6f","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    def extend_volume(self, name, orig_size, new_size\u003dNone):"},{"line_number":177,"context_line":"        row \u003d self._get_row_with_volume_name(name)"},{"line_number":178,"context_line":"        extend_volume_form \u003d self.volumes_table.extend_volume(row)"},{"line_number":179,"context_line":"        if new_size and new_size \u003e orig_size:"},{"line_number":180,"context_line":"            extend_volume_form.new_size.text \u003d new_size"},{"line_number":181,"context_line":"        else:"},{"line_number":182,"context_line":"            extend_volume_form.new_size.value \u003d orig_size + 1"}],"source_content_type":"text/x-python","patch_set":30,"id":"7af24918_c530a9a1","line":179,"updated":"2016-03-01 12:50:38.000000000","message":"I would prefer that page object wouldn\u0027t change an explicit \u0027new_size\u0027 value for me. What if I would like to test the behavior when new_size is passed equal to the original size (right now I\u0027m not able to do so using an existing extend_volume() method).","commit_id":"340a7449b72ae05e8c14608f1b81718371c12709"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"3f1e1ad9840305eb20fedb8a7398ddc2b8613d6f","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    def get_size(self, name):"},{"line_number":193,"context_line":"        row \u003d self._get_row_with_volume_name(name)"},{"line_number":194,"context_line":"        size \u003d row.cells[self.VOLUMES_TABLE_SIZE_COLUMN].text"},{"line_number":195,"context_line":"        return int(size[:-3])"}],"source_content_type":"text/x-python","patch_set":30,"id":"7af24918_05b9f1e9","line":195,"updated":"2016-03-01 12:50:38.000000000","message":"Have you checked if this worked for languages other than English?","commit_id":"340a7449b72ae05e8c14608f1b81718371c12709"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"872ab3810c3a083d5252667712f680dc546454d1","unresolved":false,"context_lines":[{"line_number":187,"context_line":"    def get_size(self, name):"},{"line_number":188,"context_line":"        row \u003d self._get_row_with_volume_name(name)"},{"line_number":189,"context_line":"        size \u003d str(row.cells[self.VOLUMES_TABLE_SIZE_COLUMN].text)"},{"line_number":190,"context_line":"        return int(filter(str.isdigit, size))"}],"source_content_type":"text/x-python","patch_set":31,"id":"7af24918_071723a4","line":190,"updated":"2016-03-01 17:04:26.000000000","message":"Won\u0027t work for floats (with decimal point). Are you sure we won\u0027t encounter non-integer sizes?","commit_id":"5be17df3ac85e03b2b04d16bc4b3af2612d96752"}],"openstack_dashboard/test/integration_tests/tests/test_volumes.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"3f1e1ad9840305eb20fedb8a7398ddc2b8613d6f","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            5. Check that the volume size is changed"},{"line_number":142,"context_line":"        \"\"\""},{"line_number":143,"context_line":"        orig_size \u003d self.volumes_page.get_size(self.VOLUME_NAME)"},{"line_number":144,"context_line":"        self.volumes_page.extend_volume(self.VOLUME_NAME, orig_size)"},{"line_number":145,"context_line":"        self.assertTrue("},{"line_number":146,"context_line":"            self.volumes_page.find_message_and_dismiss(messages.INFO))"},{"line_number":147,"context_line":"        self.assertFalse("}],"source_content_type":"text/x-python","patch_set":30,"id":"7af24918_a5763d3c","line":144,"updated":"2016-03-01 12:50:38.000000000","message":"I suggest passing `orig_size + 1` here, as it\u0027s more explicit.","commit_id":"340a7449b72ae05e8c14608f1b81718371c12709"}]}