)]}'
{"openstack_dashboard/test/integration_tests/basewebobject.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2042bba1b85b05bcc2075da16de6926199697a2b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        except Exception:"},{"line_number":51,"context_line":"            return False"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _is_text_visible(self, element, text):"},{"line_number":54,"context_line":"        try:"},{"line_number":55,"context_line":"            return element.text \u003d\u003d text"},{"line_number":56,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_83383bd4","line":53,"updated":"2016-01-15 18:59:49.000000000","message":"Honestly, I was surprised that we have such a trivial function (IMO it just obscures the meaning of element.text \u003d\u003d text check). But if we have it, why not enhance it with `strict\u003dTrue` boolean flag? If strict\u003dFalse, then this methods tests for a given string being `in` the text property of a given element.","commit_id":"6339a85ce0bb01beb14d9e2650ff7bb2f71f4d94"}],"openstack_dashboard/test/integration_tests/pages/admin/system/metadatadefinitionspage.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2042bba1b85b05bcc2075da16de6926199697a2b","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        # If we are not using default values, let\u0027s update them"},{"line_number":96,"context_line":"        if is_public !\u003d self.DEFAULT_PUBLIC:"},{"line_number":97,"context_line":"            self.DEFAULT_PUBLIC \u003d is_public"},{"line_number":98,"context_line":"        if is_protected !\u003d self.DEFAULT_PROTECTION:"},{"line_number":99,"context_line":"            self.DEFAULT_PROTECTION \u003d is_protected"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_becb16a3","line":97,"updated":"2016-01-15 18:59:49.000000000","message":"If it\u0027s not constant, it should not be uppercased.","commit_id":"6339a85ce0bb01beb14d9e2650ff7bb2f71f4d94"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2042bba1b85b05bcc2075da16de6926199697a2b","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        if is_public !\u003d self.DEFAULT_PUBLIC:"},{"line_number":97,"context_line":"            self.DEFAULT_PUBLIC \u003d is_public"},{"line_number":98,"context_line":"        if is_protected !\u003d self.DEFAULT_PROTECTION:"},{"line_number":99,"context_line":"            self.DEFAULT_PROTECTION \u003d is_protected"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        # CREATE NEW NAMESPACE"},{"line_number":102,"context_line":"        create_namespace_form \u003d self.namespaces_table.import_namespace()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_3eb88610","line":99,"updated":"2016-01-15 18:59:49.000000000","message":"Ditto","commit_id":"6339a85ce0bb01beb14d9e2650ff7bb2f71f4d94"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2042bba1b85b05bcc2075da16de6926199697a2b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        if is_protected !\u003d self.DEFAULT_PROTECTION:"},{"line_number":99,"context_line":"            self.DEFAULT_PROTECTION \u003d is_protected"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        # CREATE NEW NAMESPACE"},{"line_number":102,"context_line":"        create_namespace_form \u003d self.namespaces_table.import_namespace()"},{"line_number":103,"context_line":"        # Namespace Definition Source"},{"line_number":104,"context_line":"        create_namespace_form.source_type.value \u003d namespace_source_type"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_be10f600","line":101,"updated":"2016-01-15 18:59:49.000000000","message":"I\u0027d not use comments when method and variable names are self-explanatory (and they are).","commit_id":"6339a85ce0bb01beb14d9e2650ff7bb2f71f4d94"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2042bba1b85b05bcc2075da16de6926199697a2b","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def is_public_set_correct(self, name):"},{"line_number":133,"context_line":"        row \u003d self._get_row_with_namespace_name(name)"},{"line_number":134,"context_line":"        cell_getter \u003d row.cells[self.NAMESPACE_TABLE_PUBLIC_COLUMN]"},{"line_number":135,"context_line":"        if self.DEFAULT_PUBLIC:"},{"line_number":136,"context_line":"            public \u003d \u0027Yes\u0027"},{"line_number":137,"context_line":"        elif self.DEFAULT_PUBLIC is False:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_7e935e5b","line":134,"updated":"2016-01-15 18:59:49.000000000","message":"_getter suffix means that a variable holds a function.","commit_id":"6339a85ce0bb01beb14d9e2650ff7bb2f71f4d94"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2042bba1b85b05bcc2075da16de6926199697a2b","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def is_protected_set_correct(self, name):"},{"line_number":144,"context_line":"        row \u003d self._get_row_with_namespace_name(name)"},{"line_number":145,"context_line":"        cell_getter \u003d row.cells[self.NAMESPACE_TABLE_PROTECTED_COLUMN]"},{"line_number":146,"context_line":"        if self.DEFAULT_PROTECTION:"},{"line_number":147,"context_line":"            protected \u003d \u0027Yes\u0027"},{"line_number":148,"context_line":"        elif self.DEFAULT_PROTECTION is False:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_de8a8a1a","line":145,"updated":"2016-01-15 18:59:49.000000000","message":"Ditto","commit_id":"6339a85ce0bb01beb14d9e2650ff7bb2f71f4d94"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2042bba1b85b05bcc2075da16de6926199697a2b","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def is_resource_type_set_correct(self, name, expected_resources):"},{"line_number":155,"context_line":"        row \u003d self._get_row_with_namespace_name(name)"},{"line_number":156,"context_line":"        cell_getter \u003d row.cells[self.NAMESPACE_TABLE_RESOURCE_TYPES_COLUMN]"},{"line_number":157,"context_line":"        for resource in expected_resources:"},{"line_number":158,"context_line":"            if self._is_text_present_in_visible(cell_getter, resource) is \\"},{"line_number":159,"context_line":"                    False:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_5e7f7a14","line":156,"updated":"2016-01-15 18:59:49.000000000","message":"Dito","commit_id":"6339a85ce0bb01beb14d9e2650ff7bb2f71f4d94"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"065ca6a91b21ff9e5b4885ac9e5d8d6076dba53d","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    def is_namespace_present(self, name):"},{"line_number":115,"context_line":"        return bool(self._get_row_with_namespace_name(name))"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def is_public_set_correct(self, name):"},{"line_number":118,"context_line":"        row \u003d self._get_row_with_namespace_name(name)"},{"line_number":119,"context_line":"        cell \u003d row.cells[self.NAMESPACE_TABLE_PUBLIC_COLUMN]"},{"line_number":120,"context_line":"        if self.default_public:"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a5de9d1_b395b133","line":117,"updated":"2016-02-01 15:42:02.000000000","message":"I still smell a foul stench of overengineering here. First, you\u0027re introducing 3 dedicated helper functions and 2 instance-level variables (self.default_protection and self.default_public) where you could really work with just one helper method that gets an entity with given name and checks that values present at columns with given names have expected values.\n\nSecond, below three methods implicitly expect that first .import_namespace() method has to be invoked for them to succeed (because it sets shared self.default_protection and self.default_public), but this relation is captured only in actual test, making this Page Object not very reusable.","commit_id":"4c6fac72daf9b9e0e7a20d5b5d18665cf98fb1b6"},{"author":{"_account_id":19361,"name":"Alexander Koryagin","email":"akoryagin@mirantis.com","username":"akoryagin"},"change_message_id":"62207f3048a9051d49c321361eb8fae8e16cada4","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    def is_namespace_present(self, name):"},{"line_number":115,"context_line":"        return bool(self._get_row_with_namespace_name(name))"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def is_public_set_correct(self, name):"},{"line_number":118,"context_line":"        row \u003d self._get_row_with_namespace_name(name)"},{"line_number":119,"context_line":"        cell \u003d row.cells[self.NAMESPACE_TABLE_PUBLIC_COLUMN]"},{"line_number":120,"context_line":"        if self.default_public:"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a5de9d1_c62962f4","line":117,"in_reply_to":"7a5de9d1_b395b133","updated":"2016-02-02 09:31:03.000000000","message":"Done","commit_id":"4c6fac72daf9b9e0e7a20d5b5d18665cf98fb1b6"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"f67388490c167976cabb0cc24970784a94777b83","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def import_namespace("},{"line_number":74,"context_line":"            self, namespace_source_type, namespace_json_container,"},{"line_number":75,"context_line":"            is_public, is_protected):"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        create_namespace_form \u003d self.namespaces_table.import_namespace()"},{"line_number":78,"context_line":"        create_namespace_form.source_type.value \u003d namespace_source_type"}],"source_content_type":"text/x-python","patch_set":24,"id":"5a5ae5dd_433f1587","line":75,"updated":"2016-02-05 09:40:54.000000000","message":"Although tying default values to class attributes you\u0027re going to use for an assignment later is overengineered/too complicated, providing reasonable defaults still makes sense. Like:\n\n  def import_namespace(self, source_type, json_container, is_public\u003dFalse, is_protected\u003dFalse)","commit_id":"74db1ef6ac5353157004761898bd719dc19ee2cb"},{"author":{"_account_id":19361,"name":"Alexander Koryagin","email":"akoryagin@mirantis.com","username":"akoryagin"},"change_message_id":"7ce613bc6620e60cb768234a6ad7bcbcf968613b","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def import_namespace("},{"line_number":74,"context_line":"            self, namespace_source_type, namespace_json_container,"},{"line_number":75,"context_line":"            is_public, is_protected):"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        create_namespace_form \u003d self.namespaces_table.import_namespace()"},{"line_number":78,"context_line":"        create_namespace_form.source_type.value \u003d namespace_source_type"}],"source_content_type":"text/x-python","patch_set":24,"id":"5a5ae5dd_09ba9b0a","line":75,"in_reply_to":"5a5ae5dd_433f1587","updated":"2016-02-05 12:54:30.000000000","message":"Done","commit_id":"74db1ef6ac5353157004761898bd719dc19ee2cb"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"f67388490c167976cabb0cc24970784a94777b83","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    def is_namespace_present(self, name):"},{"line_number":101,"context_line":"        return bool(self._get_row_with_namespace_name(name))"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def is_public_set_correct(self, name, exp_value, row\u003d\u0027\u0027):"},{"line_number":104,"context_line":"        if not row:"},{"line_number":105,"context_line":"            row \u003d self._get_row_with_namespace_name(name)"},{"line_number":106,"context_line":"        cell \u003d row.cells[self.NAMESPACE_TABLE_PUBLIC_COLUMN]"}],"source_content_type":"text/x-python","patch_set":24,"id":"5a5ae5dd_e8f7fe56","line":103,"updated":"2016-02-05 09:40:54.000000000","message":"Usual convention is to specify None as the default value, if you\u0027re not going to use this exact \u0027\u0027 default. Not an error, just a matter of code etiquette.","commit_id":"74db1ef6ac5353157004761898bd719dc19ee2cb"},{"author":{"_account_id":19361,"name":"Alexander Koryagin","email":"akoryagin@mirantis.com","username":"akoryagin"},"change_message_id":"7ce613bc6620e60cb768234a6ad7bcbcf968613b","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    def is_namespace_present(self, name):"},{"line_number":101,"context_line":"        return bool(self._get_row_with_namespace_name(name))"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def is_public_set_correct(self, name, exp_value, row\u003d\u0027\u0027):"},{"line_number":104,"context_line":"        if not row:"},{"line_number":105,"context_line":"            row \u003d self._get_row_with_namespace_name(name)"},{"line_number":106,"context_line":"        cell \u003d row.cells[self.NAMESPACE_TABLE_PUBLIC_COLUMN]"}],"source_content_type":"text/x-python","patch_set":24,"id":"5a5ae5dd_49b0938a","line":103,"in_reply_to":"5a5ae5dd_e8f7fe56","updated":"2016-02-05 12:54:30.000000000","message":"Done","commit_id":"74db1ef6ac5353157004761898bd719dc19ee2cb"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"f67388490c167976cabb0cc24970784a94777b83","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        if not row:"},{"line_number":105,"context_line":"            row \u003d self._get_row_with_namespace_name(name)"},{"line_number":106,"context_line":"        cell \u003d row.cells[self.NAMESPACE_TABLE_PUBLIC_COLUMN]"},{"line_number":107,"context_line":"        if exp_value:"},{"line_number":108,"context_line":"            public \u003d \u0027Yes\u0027"},{"line_number":109,"context_line":"        elif exp_value is False:"},{"line_number":110,"context_line":"            public \u003d \u0027No\u0027"}],"source_content_type":"text/x-python","patch_set":24,"id":"5a5ae5dd_c8048219","line":107,"updated":"2016-02-05 09:40:54.000000000","message":"If you\u0027d like to pass is_public as boolean, using dict for mapping could be more concise:\n\n  publicity_mapping \u003d {True: \u0027Yes\u0027, False: \u0027No\u0027}\n  return self._is_text_visible(cell, publicity_mapping[exp_value])","commit_id":"74db1ef6ac5353157004761898bd719dc19ee2cb"},{"author":{"_account_id":19361,"name":"Alexander Koryagin","email":"akoryagin@mirantis.com","username":"akoryagin"},"change_message_id":"7ce613bc6620e60cb768234a6ad7bcbcf968613b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        if not row:"},{"line_number":105,"context_line":"            row \u003d self._get_row_with_namespace_name(name)"},{"line_number":106,"context_line":"        cell \u003d row.cells[self.NAMESPACE_TABLE_PUBLIC_COLUMN]"},{"line_number":107,"context_line":"        if exp_value:"},{"line_number":108,"context_line":"            public \u003d \u0027Yes\u0027"},{"line_number":109,"context_line":"        elif exp_value is False:"},{"line_number":110,"context_line":"            public \u003d \u0027No\u0027"}],"source_content_type":"text/x-python","patch_set":24,"id":"5a5ae5dd_aceb5512","line":107,"in_reply_to":"5a5ae5dd_c8048219","updated":"2016-02-05 12:54:30.000000000","message":"Done","commit_id":"74db1ef6ac5353157004761898bd719dc19ee2cb"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"f67388490c167976cabb0cc24970784a94777b83","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        if not row:"},{"line_number":129,"context_line":"            row \u003d self._get_row_with_namespace_name(name)"},{"line_number":130,"context_line":"        cell \u003d row.cells[self.NAMESPACE_TABLE_RESOURCE_TYPES_COLUMN]"},{"line_number":131,"context_line":"        for resource in expected_resources:"},{"line_number":132,"context_line":"            if self._is_text_visible(cell, resource, strict\u003dFalse) is False:"},{"line_number":133,"context_line":"                return False"},{"line_number":134,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":24,"id":"5a5ae5dd_08293ae6","line":131,"updated":"2016-02-05 09:40:54.000000000","message":"Could be rewritten in a more pythonic way:\n\n  return all([self._is_text_visible(cell, res, strict\u003dFalse) for res in expected_resources])","commit_id":"74db1ef6ac5353157004761898bd719dc19ee2cb"},{"author":{"_account_id":19361,"name":"Alexander Koryagin","email":"akoryagin@mirantis.com","username":"akoryagin"},"change_message_id":"7ce613bc6620e60cb768234a6ad7bcbcf968613b","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        if not row:"},{"line_number":129,"context_line":"            row \u003d self._get_row_with_namespace_name(name)"},{"line_number":130,"context_line":"        cell \u003d row.cells[self.NAMESPACE_TABLE_RESOURCE_TYPES_COLUMN]"},{"line_number":131,"context_line":"        for resource in expected_resources:"},{"line_number":132,"context_line":"            if self._is_text_visible(cell, resource, strict\u003dFalse) is False:"},{"line_number":133,"context_line":"                return False"},{"line_number":134,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":24,"id":"5a5ae5dd_ac4cb59e","line":131,"in_reply_to":"5a5ae5dd_08293ae6","updated":"2016-02-05 12:54:30.000000000","message":"Done","commit_id":"74db1ef6ac5353157004761898bd719dc19ee2cb"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"cf3de2412054afcca1748c6f0a66eaa68398985b","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        create_namespace_form.submit()"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def delete_image(self, name):"},{"line_number":96,"context_line":"        row \u003d self._get_row_with_namespace_name(name)"},{"line_number":97,"context_line":"        row.mark()"},{"line_number":98,"context_line":"        confirm_delete_namespaces_form \u003d \\"}],"source_content_type":"text/x-python","patch_set":31,"id":"5a5ae5dd_a4246a0c","line":95,"updated":"2016-02-08 20:55:55.000000000","message":"Shouldn\u0027t this be delete_namespace?","commit_id":"98fc6a55e2e36a98bfc7291939a95cbae22180a6"},{"author":{"_account_id":19361,"name":"Alexander Koryagin","email":"akoryagin@mirantis.com","username":"akoryagin"},"change_message_id":"0e411724d8689a9cd85add0fd039c8fddbd9450d","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        create_namespace_form.submit()"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def delete_image(self, name):"},{"line_number":96,"context_line":"        row \u003d self._get_row_with_namespace_name(name)"},{"line_number":97,"context_line":"        row.mark()"},{"line_number":98,"context_line":"        confirm_delete_namespaces_form \u003d \\"}],"source_content_type":"text/x-python","patch_set":31,"id":"5a5ae5dd_c36b6e84","line":95,"in_reply_to":"5a5ae5dd_a4246a0c","updated":"2016-02-09 13:09:23.000000000","message":"Done","commit_id":"98fc6a55e2e36a98bfc7291939a95cbae22180a6"}],"openstack_dashboard/test/integration_tests/tests/test_metadata_definitions.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"065ca6a91b21ff9e5b4885ac9e5d8d6076dba53d","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        # Create / Delete NameSpaces with checks"},{"line_number":129,"context_line":"        self.namespace_create_with_checks("},{"line_number":130,"context_line":"            template_source_type\u003d\u0027raw\u0027,"},{"line_number":131,"context_line":"            is_public\u003dTrue,"},{"line_number":132,"context_line":"            namespace_name\u003dnamespace_name,"},{"line_number":133,"context_line":"            page_connection_point\u003dnamespaces_page,"},{"line_number":134,"context_line":"            template_json_container\u003dtemplate_json_container,"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a5de9d1_d32e2da4","line":131,"updated":"2016-02-01 15:42:02.000000000","message":"Why don\u0027t you specify here `is_protected` flag?","commit_id":"4c6fac72daf9b9e0e7a20d5b5d18665cf98fb1b6"},{"author":{"_account_id":19361,"name":"Alexander Koryagin","email":"akoryagin@mirantis.com","username":"akoryagin"},"change_message_id":"62207f3048a9051d49c321361eb8fae8e16cada4","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        # Create / Delete NameSpaces with checks"},{"line_number":129,"context_line":"        self.namespace_create_with_checks("},{"line_number":130,"context_line":"            template_source_type\u003d\u0027raw\u0027,"},{"line_number":131,"context_line":"            is_public\u003dTrue,"},{"line_number":132,"context_line":"            namespace_name\u003dnamespace_name,"},{"line_number":133,"context_line":"            page_connection_point\u003dnamespaces_page,"},{"line_number":134,"context_line":"            template_json_container\u003dtemplate_json_container,"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a5de9d1_06a9ba24","line":131,"in_reply_to":"7a5de9d1_d32e2da4","updated":"2016-02-02 09:31:03.000000000","message":"Because default value will be always \u0027False\u0027 in this test, as it is not possible to delete protected namespace.\n\ndef namespace_create_with_checks(\n    ...\n    is_protected\u003dFalse,\n    ...\n\nBut anyway, for more clear view I\u0027ve added this value for \u0027namespace_create_with_checks\u0027 call in the test.","commit_id":"4c6fac72daf9b9e0e7a20d5b5d18665cf98fb1b6"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"065ca6a91b21ff9e5b4885ac9e5d8d6076dba53d","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            template_source_type\u003d\u0027raw\u0027,"},{"line_number":131,"context_line":"            is_public\u003dTrue,"},{"line_number":132,"context_line":"            namespace_name\u003dnamespace_name,"},{"line_number":133,"context_line":"            page_connection_point\u003dnamespaces_page,"},{"line_number":134,"context_line":"            template_json_container\u003dtemplate_json_container,"},{"line_number":135,"context_line":"            expected_namespace_res\u003dnamespace_resources_type,"},{"line_number":136,"context_line":"            run_all_checks\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a5de9d1_b39b7117","line":133,"updated":"2016-02-01 15:42:02.000000000","message":"What value besides `namespaces_page` could variable hold?","commit_id":"4c6fac72daf9b9e0e7a20d5b5d18665cf98fb1b6"},{"author":{"_account_id":19361,"name":"Alexander Koryagin","email":"akoryagin@mirantis.com","username":"akoryagin"},"change_message_id":"62207f3048a9051d49c321361eb8fae8e16cada4","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            template_source_type\u003d\u0027raw\u0027,"},{"line_number":131,"context_line":"            is_public\u003dTrue,"},{"line_number":132,"context_line":"            namespace_name\u003dnamespace_name,"},{"line_number":133,"context_line":"            page_connection_point\u003dnamespaces_page,"},{"line_number":134,"context_line":"            template_json_container\u003dtemplate_json_container,"},{"line_number":135,"context_line":"            expected_namespace_res\u003dnamespace_resources_type,"},{"line_number":136,"context_line":"            run_all_checks\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a5de9d1_693641e9","line":133,"in_reply_to":"7a5de9d1_b39b7117","updated":"2016-02-02 09:31:03.000000000","message":"Actually it can hold just \u0027namespace page connection point\u0027.\nI\u0027ll rename \u0027page_connection_point\u0027 -\u003e \u0027page\u0027.","commit_id":"4c6fac72daf9b9e0e7a20d5b5d18665cf98fb1b6"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"065ca6a91b21ff9e5b4885ac9e5d8d6076dba53d","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            page_connection_point\u003dnamespaces_page,"},{"line_number":134,"context_line":"            template_json_container\u003dtemplate_json_container,"},{"line_number":135,"context_line":"            expected_namespace_res\u003dnamespace_resources_type,"},{"line_number":136,"context_line":"            run_all_checks\u003dTrue)"},{"line_number":137,"context_line":"        self.namespace_delete_with_checks(namespace_name, namespaces_page)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        self.namespace_create_with_checks("}],"source_content_type":"text/x-python","patch_set":21,"id":"7a5de9d1_335d4147","line":136,"updated":"2016-02-01 15:42:02.000000000","message":"Are you going to set this flag to False in some further test?","commit_id":"4c6fac72daf9b9e0e7a20d5b5d18665cf98fb1b6"},{"author":{"_account_id":19361,"name":"Alexander Koryagin","email":"akoryagin@mirantis.com","username":"akoryagin"},"change_message_id":"62207f3048a9051d49c321361eb8fae8e16cada4","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            page_connection_point\u003dnamespaces_page,"},{"line_number":134,"context_line":"            template_json_container\u003dtemplate_json_container,"},{"line_number":135,"context_line":"            expected_namespace_res\u003dnamespace_resources_type,"},{"line_number":136,"context_line":"            run_all_checks\u003dTrue)"},{"line_number":137,"context_line":"        self.namespace_delete_with_checks(namespace_name, namespaces_page)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        self.namespace_create_with_checks("}],"source_content_type":"text/x-python","patch_set":21,"id":"7a5de9d1_09f1cd95","line":136,"in_reply_to":"7a5de9d1_335d4147","updated":"2016-02-02 09:31:03.000000000","message":"If there will be some additional tests for namespaces possibly there will be no more need to check public/protected fields. That is why I\u0027ve decided to keep \u0027run_all_checks\u0027 value.\n\nNow I\u0027ve changed old code to something like this:\n\n def namespace_create_with_checks():\n . . .\n if \u0027public\u0027 in check:\n     is_public_set_correct()\n elif \u0027protected\u0027 in check:\n     is_protected_set_correct()\n\n\n self.namespace_create_with_checks(\n ...\n check\u003d\u0027public, protected\u0027","commit_id":"4c6fac72daf9b9e0e7a20d5b5d18665cf98fb1b6"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"f67388490c167976cabb0cc24970784a94777b83","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    def namespace_create_with_checks("},{"line_number":26,"context_line":"            self, namespace_name, page, template_json_container,"},{"line_number":27,"context_line":"            expected_namespace_res\u003dNone, template_source_type\u003d\u0027raw\u0027,"},{"line_number":28,"context_line":"            is_public\u003dTrue, is_protected\u003dFalse, check\u003d\u0027\u0027, template_path\u003dNone):"},{"line_number":29,"context_line":"        \"\"\"Create NameSpace and run checks"},{"line_number":30,"context_line":"        :param namespace_name: Display name of namespace in template"},{"line_number":31,"context_line":"        :param page: Connection point"}],"source_content_type":"text/x-python","patch_set":24,"id":"5a5ae5dd_4324f55e","line":28,"updated":"2016-02-05 09:40:54.000000000","message":"It would be better to use tuple instead of string (\u003d\u003e less fuss with proper parsing) and use pre-defined constants for strings \u0027public\u0027 and \u0027protected\u0027. Imagine, what would happen if one passes \u0027nonpublic, unprotected\u0027 as a check string :)?","commit_id":"74db1ef6ac5353157004761898bd719dc19ee2cb"},{"author":{"_account_id":19361,"name":"Alexander Koryagin","email":"akoryagin@mirantis.com","username":"akoryagin"},"change_message_id":"7ce613bc6620e60cb768234a6ad7bcbcf968613b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    def namespace_create_with_checks("},{"line_number":26,"context_line":"            self, namespace_name, page, template_json_container,"},{"line_number":27,"context_line":"            expected_namespace_res\u003dNone, template_source_type\u003d\u0027raw\u0027,"},{"line_number":28,"context_line":"            is_public\u003dTrue, is_protected\u003dFalse, check\u003d\u0027\u0027, template_path\u003dNone):"},{"line_number":29,"context_line":"        \"\"\"Create NameSpace and run checks"},{"line_number":30,"context_line":"        :param namespace_name: Display name of namespace in template"},{"line_number":31,"context_line":"        :param page: Connection point"}],"source_content_type":"text/x-python","patch_set":24,"id":"5a5ae5dd_58561bcf","line":28,"in_reply_to":"5a5ae5dd_4324f55e","updated":"2016-02-05 12:54:30.000000000","message":"Done","commit_id":"74db1ef6ac5353157004761898bd719dc19ee2cb"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"9fb2e544cc4ec9bec3be4640ae0186639adc21c0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"            self, namespace_name, page, template_json_container,"},{"line_number":27,"context_line":"            expected_namespace_res\u003dNone, template_source_type\u003d\u0027raw\u0027,"},{"line_number":28,"context_line":"            is_public\u003dTrue, is_protected\u003dFalse, template_path\u003dNone,"},{"line_number":29,"context_line":"            check\u003d[\u0027public\u0027, \u0027protected\u0027]):"},{"line_number":30,"context_line":"        \"\"\"Create NameSpace and run checks"},{"line_number":31,"context_line":"        :param namespace_name: Display name of namespace in template"},{"line_number":32,"context_line":"        :param page: Connection point"}],"source_content_type":"text/x-python","patch_set":26,"id":"5a5ae5dd_457aafbe","line":29,"updated":"2016-02-05 17:38:04.000000000","message":"Using mutable lists as default values is very dangerous, because if they are ever get modified, these modifications will be carried across function calls. Please, use tuples.\n\nAlso, it\u0027s better to used constants/tokens here, like\n  \n  class TestMetadataDefinitions\n    PUBLIC \u003d \u0027public\u0027\n    PROTECTED \u003d \u0027protected\u0027\n\nand below.","commit_id":"d4c6832df6d424092099149d8a763899355d5269"},{"author":{"_account_id":19361,"name":"Alexander Koryagin","email":"akoryagin@mirantis.com","username":"akoryagin"},"change_message_id":"b9161b9eca6ad04d43c7a1ce7217ad8630f34a3e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"            self, namespace_name, page, template_json_container,"},{"line_number":27,"context_line":"            expected_namespace_res\u003dNone, template_source_type\u003d\u0027raw\u0027,"},{"line_number":28,"context_line":"            is_public\u003dTrue, is_protected\u003dFalse, template_path\u003dNone,"},{"line_number":29,"context_line":"            check\u003d[\u0027public\u0027, \u0027protected\u0027]):"},{"line_number":30,"context_line":"        \"\"\"Create NameSpace and run checks"},{"line_number":31,"context_line":"        :param namespace_name: Display name of namespace in template"},{"line_number":32,"context_line":"        :param page: Connection point"}],"source_content_type":"text/x-python","patch_set":26,"id":"5a5ae5dd_5a77b39f","line":29,"in_reply_to":"5a5ae5dd_457aafbe","updated":"2016-02-08 09:03:09.000000000","message":"Done","commit_id":"d4c6832df6d424092099149d8a763899355d5269"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"9fb2e544cc4ec9bec3be4640ae0186639adc21c0","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        if check:"},{"line_number":58,"context_line":"            checks_list \u003d [\u0027public\u0027, \u0027protected\u0027]"},{"line_number":59,"context_line":"            not_suitable_check \u003d [x for x in check if x not in checks_list]"},{"line_number":60,"context_line":"            self.assertEqual(0, len(not_suitable_check),"},{"line_number":61,"context_line":"                             \u0027Check \"{0}\" not in suitable \"{1}\"\u0027."},{"line_number":62,"context_line":"                             format(not_suitable_check, checks_list))"},{"line_number":63,"context_line":"            if \u0027public\u0027 in check:"}],"source_content_type":"text/x-python","patch_set":26,"id":"5a5ae5dd_a044b11a","line":60,"updated":"2016-02-05 17:38:04.000000000","message":"Why would we test the skill/knowledge of test writer inside tests? Tests are for testing the code of rest Horizon, not tests themselves. It\u0027d be simpler to just ignore unexpected flags.","commit_id":"d4c6832df6d424092099149d8a763899355d5269"},{"author":{"_account_id":19361,"name":"Alexander Koryagin","email":"akoryagin@mirantis.com","username":"akoryagin"},"change_message_id":"b9161b9eca6ad04d43c7a1ce7217ad8630f34a3e","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        if check:"},{"line_number":58,"context_line":"            checks_list \u003d [\u0027public\u0027, \u0027protected\u0027]"},{"line_number":59,"context_line":"            not_suitable_check \u003d [x for x in check if x not in checks_list]"},{"line_number":60,"context_line":"            self.assertEqual(0, len(not_suitable_check),"},{"line_number":61,"context_line":"                             \u0027Check \"{0}\" not in suitable \"{1}\"\u0027."},{"line_number":62,"context_line":"                             format(not_suitable_check, checks_list))"},{"line_number":63,"context_line":"            if \u0027public\u0027 in check:"}],"source_content_type":"text/x-python","patch_set":26,"id":"5a5ae5dd_7a7aaf89","line":60,"in_reply_to":"5a5ae5dd_a044b11a","updated":"2016-02-08 09:03:09.000000000","message":"Done","commit_id":"d4c6832df6d424092099149d8a763899355d5269"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"9fb2e544cc4ec9bec3be4640ae0186639adc21c0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            self.assertEqual(0, len(not_suitable_check),"},{"line_number":61,"context_line":"                             \u0027Check \"{0}\" not in suitable \"{1}\"\u0027."},{"line_number":62,"context_line":"                             format(not_suitable_check, checks_list))"},{"line_number":63,"context_line":"            if \u0027public\u0027 in check:"},{"line_number":64,"context_line":"                self.assertTrue(page."},{"line_number":65,"context_line":"                                is_public_set_correct(namespace_name,"},{"line_number":66,"context_line":"                                                      is_public, row))"}],"source_content_type":"text/x-python","patch_set":26,"id":"5a5ae5dd_a07fd164","line":63,"updated":"2016-02-05 17:38:04.000000000","message":"if self.PUBLIC in check:","commit_id":"d4c6832df6d424092099149d8a763899355d5269"},{"author":{"_account_id":19361,"name":"Alexander Koryagin","email":"akoryagin@mirantis.com","username":"akoryagin"},"change_message_id":"b9161b9eca6ad04d43c7a1ce7217ad8630f34a3e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            self.assertEqual(0, len(not_suitable_check),"},{"line_number":61,"context_line":"                             \u0027Check \"{0}\" not in suitable \"{1}\"\u0027."},{"line_number":62,"context_line":"                             format(not_suitable_check, checks_list))"},{"line_number":63,"context_line":"            if \u0027public\u0027 in check:"},{"line_number":64,"context_line":"                self.assertTrue(page."},{"line_number":65,"context_line":"                                is_public_set_correct(namespace_name,"},{"line_number":66,"context_line":"                                                      is_public, row))"}],"source_content_type":"text/x-python","patch_set":26,"id":"5a5ae5dd_1a6dbbcb","line":63,"in_reply_to":"5a5ae5dd_a07fd164","updated":"2016-02-08 09:03:09.000000000","message":"Done","commit_id":"d4c6832df6d424092099149d8a763899355d5269"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"9fb2e544cc4ec9bec3be4640ae0186639adc21c0","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                             \u0027Check \"{0}\" not in suitable \"{1}\"\u0027."},{"line_number":62,"context_line":"                             format(not_suitable_check, checks_list))"},{"line_number":63,"context_line":"            if \u0027public\u0027 in check:"},{"line_number":64,"context_line":"                self.assertTrue(page."},{"line_number":65,"context_line":"                                is_public_set_correct(namespace_name,"},{"line_number":66,"context_line":"                                                      is_public, row))"},{"line_number":67,"context_line":"            elif \u0027protected\u0027 in check:"}],"source_content_type":"text/x-python","patch_set":26,"id":"5a5ae5dd_a0127107","line":64,"updated":"2016-02-05 17:38:04.000000000","message":"weird indentation, why no move page to next line and keep it on the same line with method invocation?","commit_id":"d4c6832df6d424092099149d8a763899355d5269"},{"author":{"_account_id":19361,"name":"Alexander Koryagin","email":"akoryagin@mirantis.com","username":"akoryagin"},"change_message_id":"b9161b9eca6ad04d43c7a1ce7217ad8630f34a3e","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                             \u0027Check \"{0}\" not in suitable \"{1}\"\u0027."},{"line_number":62,"context_line":"                             format(not_suitable_check, checks_list))"},{"line_number":63,"context_line":"            if \u0027public\u0027 in check:"},{"line_number":64,"context_line":"                self.assertTrue(page."},{"line_number":65,"context_line":"                                is_public_set_correct(namespace_name,"},{"line_number":66,"context_line":"                                                      is_public, row))"},{"line_number":67,"context_line":"            elif \u0027protected\u0027 in check:"}],"source_content_type":"text/x-python","patch_set":26,"id":"5a5ae5dd_3a70b7a3","line":64,"in_reply_to":"5a5ae5dd_a0127107","updated":"2016-02-08 09:03:09.000000000","message":"Done","commit_id":"d4c6832df6d424092099149d8a763899355d5269"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"9fb2e544cc4ec9bec3be4640ae0186639adc21c0","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                self.assertTrue(page."},{"line_number":65,"context_line":"                                is_public_set_correct(namespace_name,"},{"line_number":66,"context_line":"                                                      is_public, row))"},{"line_number":67,"context_line":"            elif \u0027protected\u0027 in check:"},{"line_number":68,"context_line":"                self.assertTrue(page."},{"line_number":69,"context_line":"                                is_protected_set_correct(namespace_name,"},{"line_number":70,"context_line":"                                                         is_protected, row))"}],"source_content_type":"text/x-python","patch_set":26,"id":"5a5ae5dd_008fc575","line":67,"updated":"2016-02-05 17:38:04.000000000","message":"ditto","commit_id":"d4c6832df6d424092099149d8a763899355d5269"},{"author":{"_account_id":19361,"name":"Alexander Koryagin","email":"akoryagin@mirantis.com","username":"akoryagin"},"change_message_id":"b9161b9eca6ad04d43c7a1ce7217ad8630f34a3e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                self.assertTrue(page."},{"line_number":65,"context_line":"                                is_public_set_correct(namespace_name,"},{"line_number":66,"context_line":"                                                      is_public, row))"},{"line_number":67,"context_line":"            elif \u0027protected\u0027 in check:"},{"line_number":68,"context_line":"                self.assertTrue(page."},{"line_number":69,"context_line":"                                is_protected_set_correct(namespace_name,"},{"line_number":70,"context_line":"                                                         is_protected, row))"}],"source_content_type":"text/x-python","patch_set":26,"id":"5a5ae5dd_fa669feb","line":67,"in_reply_to":"5a5ae5dd_008fc575","updated":"2016-02-08 09:03:09.000000000","message":"Done","commit_id":"d4c6832df6d424092099149d8a763899355d5269"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"9fb2e544cc4ec9bec3be4640ae0186639adc21c0","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                                                      is_public, row))"},{"line_number":67,"context_line":"            elif \u0027protected\u0027 in check:"},{"line_number":68,"context_line":"                self.assertTrue(page."},{"line_number":69,"context_line":"                                is_protected_set_correct(namespace_name,"},{"line_number":70,"context_line":"                                                         is_protected, row))"},{"line_number":71,"context_line":"        if expected_namespace_res:"},{"line_number":72,"context_line":"            self.assertTrue(page.is_resource_type_set_correct("}],"source_content_type":"text/x-python","patch_set":26,"id":"5a5ae5dd_c02e8d42","line":69,"updated":"2016-02-05 17:38:04.000000000","message":"ditto","commit_id":"d4c6832df6d424092099149d8a763899355d5269"},{"author":{"_account_id":19361,"name":"Alexander Koryagin","email":"akoryagin@mirantis.com","username":"akoryagin"},"change_message_id":"b9161b9eca6ad04d43c7a1ce7217ad8630f34a3e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                                                      is_public, row))"},{"line_number":67,"context_line":"            elif \u0027protected\u0027 in check:"},{"line_number":68,"context_line":"                self.assertTrue(page."},{"line_number":69,"context_line":"                                is_protected_set_correct(namespace_name,"},{"line_number":70,"context_line":"                                                         is_protected, row))"},{"line_number":71,"context_line":"        if expected_namespace_res:"},{"line_number":72,"context_line":"            self.assertTrue(page.is_resource_type_set_correct("}],"source_content_type":"text/x-python","patch_set":26,"id":"5a5ae5dd_9a61abd5","line":69,"in_reply_to":"5a5ae5dd_c02e8d42","updated":"2016-02-08 09:03:09.000000000","message":"Done","commit_id":"d4c6832df6d424092099149d8a763899355d5269"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"9fb2e544cc4ec9bec3be4640ae0186639adc21c0","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            template_source_type\u003d\u0027raw\u0027,"},{"line_number":133,"context_line":"            is_public\u003dTrue,"},{"line_number":134,"context_line":"            expected_namespace_res\u003dnamespace_res_type,"},{"line_number":135,"context_line":"            check\u003d[\u0027public\u0027, \u0027protected\u0027],"},{"line_number":136,"context_line":"            **kwargs)"},{"line_number":137,"context_line":"        self.namespace_delete_with_checks(namespace_name, namespaces_page)"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"5a5ae5dd_80b2d504","line":135,"updated":"2016-02-05 17:38:04.000000000","message":"tuple","commit_id":"d4c6832df6d424092099149d8a763899355d5269"},{"author":{"_account_id":19361,"name":"Alexander Koryagin","email":"akoryagin@mirantis.com","username":"akoryagin"},"change_message_id":"b9161b9eca6ad04d43c7a1ce7217ad8630f34a3e","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            template_source_type\u003d\u0027raw\u0027,"},{"line_number":133,"context_line":"            is_public\u003dTrue,"},{"line_number":134,"context_line":"            expected_namespace_res\u003dnamespace_res_type,"},{"line_number":135,"context_line":"            check\u003d[\u0027public\u0027, \u0027protected\u0027],"},{"line_number":136,"context_line":"            **kwargs)"},{"line_number":137,"context_line":"        self.namespace_delete_with_checks(namespace_name, namespaces_page)"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"5a5ae5dd_ba5ca719","line":135,"in_reply_to":"5a5ae5dd_80b2d504","updated":"2016-02-08 09:03:09.000000000","message":"Done","commit_id":"d4c6832df6d424092099149d8a763899355d5269"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"b669133abc7bc9bdfdd47807abeaa1eef62720d9","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            template_source_type\u003d\u0027raw\u0027,"},{"line_number":138,"context_line":"            is_public\u003dFalse,"},{"line_number":139,"context_line":"            expected_namespace_res\u003dNone,"},{"line_number":140,"context_line":"            check\u003dself.PUBLIC,"},{"line_number":141,"context_line":"            **kwargs)"},{"line_number":142,"context_line":"        self.namespace_delete_with_checks(namespace_name, namespaces_page)"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"5a5ae5dd_a5a9e825","line":140,"updated":"2016-02-08 09:46:53.000000000","message":"Please note that here you\u0027re still testing for one string being a substring of another string and not a string literal as whole being present inside iterable containing other string literals. To make it behave the way similar to above test, you\u0027ll need to specify it here as \n  \n  check\u003d(self.PUBLIC,)\n\nAlso, it seems reasonable to rename keyword `check` -\u003e `checks` since it can contain \u003e1 checkflags.","commit_id":"6ff9dd6f4009934a00ba097a6b1686af2d11ac60"},{"author":{"_account_id":19361,"name":"Alexander Koryagin","email":"akoryagin@mirantis.com","username":"akoryagin"},"change_message_id":"e99883de673e2ef2bf7c8aed8fc40b235bca930f","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            template_source_type\u003d\u0027raw\u0027,"},{"line_number":138,"context_line":"            is_public\u003dFalse,"},{"line_number":139,"context_line":"            expected_namespace_res\u003dNone,"},{"line_number":140,"context_line":"            check\u003dself.PUBLIC,"},{"line_number":141,"context_line":"            **kwargs)"},{"line_number":142,"context_line":"        self.namespace_delete_with_checks(namespace_name, namespaces_page)"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"5a5ae5dd_f770f541","line":140,"in_reply_to":"5a5ae5dd_a5a9e825","updated":"2016-02-08 10:41:24.000000000","message":"Done","commit_id":"6ff9dd6f4009934a00ba097a6b1686af2d11ac60"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"b669133abc7bc9bdfdd47807abeaa1eef62720d9","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            template_source_type\u003d\u0027file\u0027,"},{"line_number":154,"context_line":"            is_public\u003dFalse,"},{"line_number":155,"context_line":"            expected_namespace_res\u003dNone,"},{"line_number":156,"context_line":"            check\u003dself.PUBLIC,"},{"line_number":157,"context_line":"            **kwargs)"},{"line_number":158,"context_line":"        self.namespace_delete_with_checks(namespace_name, namespaces_page)"}],"source_content_type":"text/x-python","patch_set":29,"id":"5a5ae5dd_6566902b","line":156,"updated":"2016-02-08 09:46:53.000000000","message":"ditto","commit_id":"6ff9dd6f4009934a00ba097a6b1686af2d11ac60"},{"author":{"_account_id":19361,"name":"Alexander Koryagin","email":"akoryagin@mirantis.com","username":"akoryagin"},"change_message_id":"e99883de673e2ef2bf7c8aed8fc40b235bca930f","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            template_source_type\u003d\u0027file\u0027,"},{"line_number":154,"context_line":"            is_public\u003dFalse,"},{"line_number":155,"context_line":"            expected_namespace_res\u003dNone,"},{"line_number":156,"context_line":"            check\u003dself.PUBLIC,"},{"line_number":157,"context_line":"            **kwargs)"},{"line_number":158,"context_line":"        self.namespace_delete_with_checks(namespace_name, namespaces_page)"}],"source_content_type":"text/x-python","patch_set":29,"id":"5a5ae5dd_5798e969","line":156,"in_reply_to":"5a5ae5dd_6566902b","updated":"2016-02-08 10:41:24.000000000","message":"Done","commit_id":"6ff9dd6f4009934a00ba097a6b1686af2d11ac60"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"01773e422134a035b72ac9f84b10a679c2655795","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            template_source_type\u003d\u0027raw\u0027,"},{"line_number":138,"context_line":"            is_public\u003dFalse,"},{"line_number":139,"context_line":"            expected_namespace_res\u003dNone,"},{"line_number":140,"context_line":"            checks\u003d(self.PUBLIC),"},{"line_number":141,"context_line":"            **kwargs)"},{"line_number":142,"context_line":"        self.namespace_delete_with_checks(namespace_name, namespaces_page)"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"5a5ae5dd_4d0e16e6","line":140,"updated":"2016-02-08 11:17:39.000000000","message":"Still not a tuple, it\u0027s a string. To make tuple with just one element, you have to leave trailing comma:\n\n  (self.PUBLIC,)","commit_id":"efffd9face6279c397ede1ffa60a41c02948da0e"},{"author":{"_account_id":19361,"name":"Alexander Koryagin","email":"akoryagin@mirantis.com","username":"akoryagin"},"change_message_id":"05474b73afe768c60bb2a2376d2848481156c8ae","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            template_source_type\u003d\u0027raw\u0027,"},{"line_number":138,"context_line":"            is_public\u003dFalse,"},{"line_number":139,"context_line":"            expected_namespace_res\u003dNone,"},{"line_number":140,"context_line":"            checks\u003d(self.PUBLIC),"},{"line_number":141,"context_line":"            **kwargs)"},{"line_number":142,"context_line":"        self.namespace_delete_with_checks(namespace_name, namespaces_page)"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"5a5ae5dd_0d433eb3","line":140,"in_reply_to":"5a5ae5dd_4d0e16e6","updated":"2016-02-08 11:23:33.000000000","message":"Done","commit_id":"efffd9face6279c397ede1ffa60a41c02948da0e"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"cf3de2412054afcca1748c6f0a66eaa68398985b","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            expected_namespace_res\u003dNone,"},{"line_number":156,"context_line":"            checks\u003d(self.PUBLIC,),"},{"line_number":157,"context_line":"            **kwargs)"},{"line_number":158,"context_line":"        self.namespace_delete_with_checks(namespace_name, namespaces_page)"}],"source_content_type":"text/x-python","patch_set":31,"id":"5a5ae5dd_ae976438","line":158,"updated":"2016-02-08 20:55:55.000000000","message":"Can we add a test that sends in is_protected as an argument?","commit_id":"98fc6a55e2e36a98bfc7291939a95cbae22180a6"},{"author":{"_account_id":19361,"name":"Alexander Koryagin","email":"akoryagin@mirantis.com","username":"akoryagin"},"change_message_id":"0e411724d8689a9cd85add0fd039c8fddbd9450d","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            expected_namespace_res\u003dNone,"},{"line_number":156,"context_line":"            checks\u003d(self.PUBLIC,),"},{"line_number":157,"context_line":"            **kwargs)"},{"line_number":158,"context_line":"        self.namespace_delete_with_checks(namespace_name, namespaces_page)"}],"source_content_type":"text/x-python","patch_set":31,"id":"5a5ae5dd_e3ff8aa8","line":158,"in_reply_to":"5a5ae5dd_ae976438","updated":"2016-02-09 13:09:23.000000000","message":"In this test creation on the namespace will be with \u0027is_protected\u003dFalse\u0027, because otherwise it won\u0027t be possible to delete it.\n\nhttps://review.openstack.org/#/c/268039/31/openstack_dashboard/test/integration_tests/tests/test_metadata_definitions.py@124\n # Create / Delete NameSpaces with checks\n kwargs \u003d {\u0027namespace_name\u0027: namespace_name,\n           . . .\n           \u0027is_protected\u0027: False,\n           . . .\n\nBut in another test you can find creation with \u0027is_protected\u003dTrue\u0027:\nAdd test for modification of Public and Protected fields for NameSpace on \u0027Metadata Definitions\u0027 page\nhttps://review.openstack.org/#/c/271995/","commit_id":"98fc6a55e2e36a98bfc7291939a95cbae22180a6"}],"openstack_dashboard/test/integration_tests/tests/test_namespace_create_delete.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2042bba1b85b05bcc2075da16de6926199697a2b","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class TestNamespaceCreateDelete(helpers.AdminTestCase):"},{"line_number":18,"context_line":"    NAMESPACE_TEMPLATE_NAME \u003d \\"},{"line_number":19,"context_line":"        \u0027openstack_dashboard/test/integration_tests/tests/templates/\u0027 \\"},{"line_number":20,"context_line":"        \u0027empty_namespace.json\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def test_namespace_create_delete(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_a8975c38","line":19,"updated":"2016-01-15 18:59:49.000000000","message":"A relative path in form of\n  os.path.join(os.path.dirname(__file__),\n               \u0027data/empty_namespace.json\u0027)\n\nwould be more robust.\n\nAlso, I\u0027m against using \u0027templates\u0027 as dir name, because it has a different meaning in django/angular apps. A name \u0027data\u0027 or \u0027test-data\u0027 is more neutral.\n\nIf more than one file should be placed there, you could define module-wise\n\n  TEST_DATA_BASE_DIR \u003d os.path.join(os.path.dirname(__file__), \u0027data\u0027)","commit_id":"6339a85ce0bb01beb14d9e2650ff7bb2f71f4d94"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2042bba1b85b05bcc2075da16de6926199697a2b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        \u0027openstack_dashboard/test/integration_tests/tests/templates/\u0027 \\"},{"line_number":20,"context_line":"        \u0027empty_namespace.json\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def test_namespace_create_delete(self):"},{"line_number":23,"context_line":"        \"\"\"Tests the NameSpace creation and deletion functionality:"},{"line_number":24,"context_line":"        * Actions:"},{"line_number":25,"context_line":"        * 1) Login to Horizon Dashboard as admin user."}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_88cff854","line":22,"updated":"2016-01-15 18:59:49.000000000","message":"This name is okay, but the module naming scheme you\u0027ve already encountered in image tests is not good. In fact, I was going to rename it, but hadn\u0027t time yet to do it. \u0027test_metadata\u0027 / \u0027test_metadata_defs\u0027 is a better name for this module, since it\u0027s less specific and allows to put more tests related to metadata definitions here.","commit_id":"6339a85ce0bb01beb14d9e2650ff7bb2f71f4d94"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2042bba1b85b05bcc2075da16de6926199697a2b","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        namespaces_page \u003d self.home_pg.go_to_system_metadatadefinitionspage()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        # Take name from json template"},{"line_number":51,"context_line":"        namespace_name \u003d namespaces_page.json_get_value_from_file("},{"line_number":52,"context_line":"            namespace_template_name\u003dself.NAMESPACE_TEMPLATE_NAME,"},{"line_number":53,"context_line":"            key\u003d\u0027display_name\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_fee2eed3","line":50,"updated":"2016-01-15 18:59:49.000000000","message":"Most of the comments don\u0027t make the logic clearer (it\u0027s already clear enough).","commit_id":"6339a85ce0bb01beb14d9e2650ff7bb2f71f4d94"}]}
