)]}'
{"horizon/test/firefox_binary.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"979fd9f9ebbc19e6753223d93f0dfa284088879f","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        fp.set_preference(\"browser.download.folderList\", 2)"},{"line_number":82,"context_line":"        fp.set_preference(\"browser.download.manager.showWhenStarting\","},{"line_number":83,"context_line":"                          False)"},{"line_number":84,"context_line":"        fp.set_preference(\"browser.download.dir\", os.getcwd())"},{"line_number":85,"context_line":"        fp.set_preference(\"browser.helperApps.neverAsk.saveToDisk\","},{"line_number":86,"context_line":"                          \"application/binary,text/plain\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_a623cb04","line":84,"updated":"2016-02-15 14:10:36.000000000","message":"Please keep in mind that os.getcwd() is not the best place for downloads since depending on test environment, there may be insufficient write permissions for current apache process user. It\u0027s far safer to use directory inside /tmp (python has a special module for working with temp files and dirs).","commit_id":"077a16e1a692849ee1e86f6e88de639d40c805ff"}],"openstack_dashboard/test/integration_tests/pages/project/compute/access_and_security/apiaccesspage.py":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"bceab757ef348e86b2eee00580d766898bfc65c3","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from os.path import join"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class ApiaccessTable(tables.TableRegion):"},{"line_number":21,"context_line":"    name \u003d \"endpoints\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @tables.bind_table_action(\u0027download_openrc_v2\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_8915944a","line":20,"updated":"2016-02-17 09:09:10.000000000","message":"CamelCase? ApiAccessTable","commit_id":"0f0e7a084274fecb4b28d980ac4a467eac295e4e"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"bceab757ef348e86b2eee00580d766898bfc65c3","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        download_button.click()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class ApiaccessPage(basepage.BaseNavigationPage):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, driver, conf):"},{"line_number":35,"context_line":"        super(ApiaccessPage, self).__init__(driver, conf)"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_64015705","line":32,"updated":"2016-02-17 09:09:10.000000000","message":"ApiAccessPage","commit_id":"0f0e7a084274fecb4b28d980ac4a467eac295e4e"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"bceab757ef348e86b2eee00580d766898bfc65c3","unresolved":false,"context_lines":[{"line_number":32,"context_line":"class ApiaccessPage(basepage.BaseNavigationPage):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, driver, conf):"},{"line_number":35,"context_line":"        super(ApiaccessPage, self).__init__(driver, conf)"},{"line_number":36,"context_line":"        self._page_title \u003d \"Access \u0026 Security\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_647677a5","line":35,"updated":"2016-02-17 09:09:10.000000000","message":"ApiAccessPage","commit_id":"0f0e7a084274fecb4b28d980ac4a467eac295e4e"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"bceab757ef348e86b2eee00580d766898bfc65c3","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @property"},{"line_number":39,"context_line":"    def apiaccess_table(self):"},{"line_number":40,"context_line":"        return ApiaccessTable(self.driver, self.conf)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def download_openstack_rc_file(self, version, directory, template):"},{"line_number":43,"context_line":"        if version \u003d\u003d 2:"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_e443a740","line":40,"updated":"2016-02-17 09:09:10.000000000","message":"ApiAccessTable","commit_id":"0f0e7a084274fecb4b28d980ac4a467eac295e4e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"0fcbac1c60c0687bbf961b49677f3e3bb64c66dd","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            lambda _: len(self.list_of_files(directory, template)) \u003e 0)"},{"line_number":55,"context_line":"        file_name \u003d self.list_of_files(directory, template)[0]"},{"line_number":56,"context_line":"        with open(join(directory, file_name)) as f:"},{"line_number":57,"context_line":"            content \u003d f.read().split(\"\\n\")"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        username \u003d [i[7:] for i in content if \u0027USERNAME\u0027 in i][0]"},{"line_number":60,"context_line":"        if version \u003d\u003d 2:"}],"source_content_type":"text/x-python","patch_set":10,"id":"dae33548_c842f167","line":57,"updated":"2016-02-17 10:58:36.000000000","message":"Why not use f.readlines() instead?","commit_id":"ca3ae83d6ecd47f85877789c2a47d8ad8975a15c"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"0fcbac1c60c0687bbf961b49677f3e3bb64c66dd","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        with open(join(directory, file_name)) as f:"},{"line_number":57,"context_line":"            content \u003d f.read().split(\"\\n\")"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        username \u003d [i[7:] for i in content if \u0027USERNAME\u0027 in i][0]"},{"line_number":60,"context_line":"        if version \u003d\u003d 2:"},{"line_number":61,"context_line":"            tenant_name \u003d [i[7:] for i in content if \u0027TENANT_NAME\u0027 in i][0]"},{"line_number":62,"context_line":"            tenant_id \u003d [i[7:] for i in content if \u0027TENANT_ID\u0027 in i][0]"}],"source_content_type":"text/x-python","patch_set":10,"id":"dae33548_b39d620c","line":59,"updated":"2016-02-17 10:58:36.000000000","message":"There is a more elegant way to do this: regexp. For example, you could write:\n\n  content \u003d open(...).read()\n  username_re \u003d r\u0027export OS_USERNAME\u003d\"([^\"]+)\"\u0027\n  if version \u003d\u003d 2:\n    tenant_name_re \u003d r\u0027export OS_TENANT_NAME\u003d\"([^\"]+)\"\u0027\n    tenant_id_re \u003d r\u0027export OS_TENANT_ID\u003d(.+)\u0027\n  elif version \u003d\u003d 3:\n    tenant_name_re \u003d r\u0027export OS_PROJECT_NAME\u003d\"([^\"]+)\"\u0027\n    tenant_id_re \u003d r\u0027export OS_PROJECT_ID\u003d(.+)\u0027\n  username \u003d re.search(username_re, content).group(1)\n  tenant_id \u003d re.search(tenant_id_re, content).group(1)\n  tenant_name \u003d re.search(tenant_name_re, content).group(1)\n\nand this would eliminate need in list_to_dict() function","commit_id":"ca3ae83d6ecd47f85877789c2a47d8ad8975a15c"}],"openstack_dashboard/test/integration_tests/tests/test_credentials.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"0fcbac1c60c0687bbf961b49677f3e3bb64c66dd","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        cred_dict \u003d api_access_page.get_credentials_from_file("},{"line_number":41,"context_line":"            2, self._directory, self._openrc_template)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        user_name \u003d self.TEST_USER_NAME"},{"line_number":44,"context_line":"        tenant_name \u003d self.HOME_PROJECT"},{"line_number":45,"context_line":"        projects_page \u003d self.home_pg.go_to_identity_projectspage()"},{"line_number":46,"context_line":"        tenant_id \u003d projects_page.get_project_id_from_row(tenant_name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"dae33548_c80af178","line":43,"updated":"2016-02-17 10:58:36.000000000","message":"Lines 43-49 are the same for both tests and retrieving self.actual_dict could be moved to setUp().","commit_id":"ca3ae83d6ecd47f85877789c2a47d8ad8975a15c"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"0fcbac1c60c0687bbf961b49677f3e3bb64c66dd","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def tearDown(self):"},{"line_number":79,"context_line":"        super(TestDownloadRCFile, self).tearDown()"},{"line_number":80,"context_line":"        for root, _, files in walk(self._directory):"},{"line_number":81,"context_line":"            remove(join(root, files[0]))"}],"source_content_type":"text/x-python","patch_set":10,"id":"dae33548_c8fcb174","line":80,"updated":"2016-02-17 10:58:36.000000000","message":"Why not use os.path.listdir() here?","commit_id":"ca3ae83d6ecd47f85877789c2a47d8ad8975a15c"}],"openstack_dashboard/test/integration_tests/tests/test_download_rc_file.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"979fd9f9ebbc19e6753223d93f0dfa284088879f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        super(TestDownloadRCFile, self).setUp()"},{"line_number":30,"context_line":"        self._directory \u003d getcwd()"},{"line_number":31,"context_line":"        # initial preparation"},{"line_number":32,"context_line":"        for f in self.list_of_files(self._openrc_template):"},{"line_number":33,"context_line":"            unlink(f)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    \"\"\"This is a basic scenario test:"}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_c6d1affd","line":32,"updated":"2016-02-15 14:10:36.000000000","message":"Why do we need to delete files in setUp method?\n\nTo me it makes sense only inside tearDown.","commit_id":"077a16e1a692849ee1e86f6e88de639d40c805ff"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"979fd9f9ebbc19e6753223d93f0dfa284088879f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            go_to_compute_accessandsecurity_apiaccesspage()"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        # Close alerts"},{"line_number":58,"context_line":"        while apiaccess_page.find_message_and_dismiss(messages.SUCCESS):"},{"line_number":59,"context_line":"            continue"},{"line_number":60,"context_line":"        while apiaccess_page.find_message_and_dismiss(messages.ERROR):"},{"line_number":61,"context_line":"            continue"}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_e6c5d35b","line":58,"updated":"2016-02-15 14:10:36.000000000","message":"Please see how it\u0027s done in other tests, this form is redundant.","commit_id":"077a16e1a692849ee1e86f6e88de639d40c805ff"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"979fd9f9ebbc19e6753223d93f0dfa284088879f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        # Close alerts"},{"line_number":58,"context_line":"        while apiaccess_page.find_message_and_dismiss(messages.SUCCESS):"},{"line_number":59,"context_line":"            continue"},{"line_number":60,"context_line":"        while apiaccess_page.find_message_and_dismiss(messages.ERROR):"},{"line_number":61,"context_line":"            continue"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        # Press required button"}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_26a69bc1","line":60,"updated":"2016-02-15 14:10:36.000000000","message":"ditto.","commit_id":"077a16e1a692849ee1e86f6e88de639d40c805ff"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"979fd9f9ebbc19e6753223d93f0dfa284088879f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            continue"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        # Press required button"},{"line_number":64,"context_line":"        if version \u003d\u003d 2:"},{"line_number":65,"context_line":"            apiaccess_page.download_openstack_rc_v2()"},{"line_number":66,"context_line":"        elif version \u003d\u003d 3:"},{"line_number":67,"context_line":"            apiaccess_page.download_openstack_rc_v3()"}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_2694db35","line":64,"updated":"2016-02-15 14:10:36.000000000","message":"Logic with different versions is better to be put into page object being used.","commit_id":"077a16e1a692849ee1e86f6e88de639d40c805ff"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"979fd9f9ebbc19e6753223d93f0dfa284088879f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            apiaccess_page.download_openstack_rc_v2()"},{"line_number":66,"context_line":"        elif version \u003d\u003d 3:"},{"line_number":67,"context_line":"            apiaccess_page.download_openstack_rc_v3()"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        # Just wait while download process will be completed"},{"line_number":70,"context_line":"        self.home_pg._wait_until("},{"line_number":71,"context_line":"            lambda _: len(self.list_of_files(self._openrc_template)) \u003e 0)"}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_c6ca4f4f","line":68,"updated":"2016-02-15 14:10:36.000000000","message":"If we\u0027re downloading these files, it would make sense to analyze their contents as well, at least that username and tenant name correspond to current user and tenant names.","commit_id":"077a16e1a692849ee1e86f6e88de639d40c805ff"}]}
