)]}'
{"horizon/static/framework/widgets/modal/wizard.controller.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"fab2ec957a7ebadac73c4a31efbf8cf36477036d","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  angular"},{"line_number":21,"context_line":"    .module(\u0027horizon.framework.widgets.modal\u0027)"},{"line_number":22,"context_line":"    .controller(\u0027WizardModalController\u0027, wizardModalController);"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  wizardModalController.$inject \u003d ["},{"line_number":25,"context_line":"    \u0027$modalInstance\u0027,"}],"source_content_type":"text/javascript","patch_set":1,"id":"da6ed579_debccadd","line":22,"updated":"2016-01-15 18:54:42.000000000","message":".controller(\u0027WizardModalController\u0027, WizardModalController);\n\nshould be capitalized.","commit_id":"7baab038d62acb14b969b6539800af6ee69718a7"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"0d4c27ea4705e12f7c6ca25db0b9e0d5f1a4b9a9","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  angular"},{"line_number":21,"context_line":"    .module(\u0027horizon.framework.widgets.modal\u0027)"},{"line_number":22,"context_line":"    .controller(\u0027WizardModalController\u0027, wizardModalController);"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  wizardModalController.$inject \u003d ["},{"line_number":25,"context_line":"    \u0027$modalInstance\u0027,"}],"source_content_type":"text/javascript","patch_set":1,"id":"da6ed579_fe650e44","line":22,"in_reply_to":"da6ed579_debccadd","updated":"2016-01-15 18:59:31.000000000","message":"Done","commit_id":"7baab038d62acb14b969b6539800af6ee69718a7"}],"horizon/static/framework/widgets/modal/wizard.controller.spec.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"3cc417b441982096fb3097490de5a0f353c34df8","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    }"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    function closeCancel() {"},{"line_number":54,"context_line":"      scope.close();"},{"line_number":55,"context_line":"      scope.cancel();"},{"line_number":56,"context_line":"      expect(modalInstance.close).toHaveBeenCalled();"},{"line_number":57,"context_line":"      expect(modalInstance.dismiss).toHaveBeenCalledWith(\u0027cancel\u0027);"},{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  });"}],"source_content_type":"text/javascript","patch_set":2,"id":"da6ed579_ddce0bb7","line":57,"range":{"start_line":54,"start_character":6,"end_line":57,"end_character":67},"updated":"2016-01-15 21:05:57.000000000","message":"Why not break this into two tests (one for close and one for cancel)?  That would guarantee that the behaviors are as expected.  With this current approach there could be some overlap (close calls with cancel, etc.), esp. since it\u0027s just a vague toHaveBeenCalled() in the one case.","commit_id":"cc842c19bc43e9b8dd3b4ed24902552e4f03a18f"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"03e1d7f9a0e59c1f3406f74297b168ccad9053c8","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    }"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    function closeCancel() {"},{"line_number":54,"context_line":"      scope.close();"},{"line_number":55,"context_line":"      scope.cancel();"},{"line_number":56,"context_line":"      expect(modalInstance.close).toHaveBeenCalled();"},{"line_number":57,"context_line":"      expect(modalInstance.dismiss).toHaveBeenCalledWith(\u0027cancel\u0027);"},{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  });"}],"source_content_type":"text/javascript","patch_set":2,"id":"da6ed579_5801c938","line":57,"range":{"start_line":54,"start_character":6,"end_line":57,"end_character":67},"in_reply_to":"da6ed579_ddce0bb7","updated":"2016-01-15 21:46:19.000000000","message":"Done","commit_id":"cc842c19bc43e9b8dd3b4ed24902552e4f03a18f"}]}
