)]}'
{"openstack_dashboard/api/cinder.py":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"cf96c65dc40b4f88e1fcab8d340308c8e950ebc3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 United States Government as represented by the"},{"line_number":2,"context_line":"# Administrator of the National Aeronautics and Space Administration."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Copyright 2012 OpenStack Foundation"}],"source_content_type":"text/x-python","patch_set":21,"id":"5aef4532_95bef3ab","line":2,"range":{"start_line":1,"start_character":2,"end_line":2,"end_character":69},"updated":"2016-03-10 17:52:02.000000000","message":"Remove","commit_id":"a91a8510414d4470809f798d4763f2a7624c95ba"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"80159ca725008b6b3b1abf77e91f3f61b0343626","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 United States Government as represented by the"},{"line_number":2,"context_line":"# Administrator of the National Aeronautics and Space Administration."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Copyright 2012 OpenStack Foundation"}],"source_content_type":"text/x-python","patch_set":21,"id":"5aef4532_a665ba45","line":2,"range":{"start_line":1,"start_character":2,"end_line":2,"end_character":69},"in_reply_to":"5aef4532_95bef3ab","updated":"2016-03-10 22:00:01.000000000","message":"As Brad mentioned, no need to change copyright for existing files","commit_id":"a91a8510414d4470809f798d4763f2a7624c95ba"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"cf96c65dc40b4f88e1fcab8d340308c8e950ebc3","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":6,"context_line":"# Copyright 2012 Nebula, Inc."},{"line_number":7,"context_line":"# Copyright (c) 2012 X.commerce, a business unit of eBay Inc."},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":10,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":21,"id":"5aef4532_d5099b96","line":7,"range":{"start_line":6,"start_character":0,"end_line":7,"end_character":61},"updated":"2016-03-10 17:52:02.000000000","message":"Remove","commit_id":"a91a8510414d4470809f798d4763f2a7624c95ba"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"80159ca725008b6b3b1abf77e91f3f61b0343626","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":6,"context_line":"# Copyright 2012 Nebula, Inc."},{"line_number":7,"context_line":"# Copyright (c) 2012 X.commerce, a business unit of eBay Inc."},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":10,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":21,"id":"5aef4532_e6d222d0","line":7,"range":{"start_line":6,"start_character":0,"end_line":7,"end_character":61},"in_reply_to":"5aef4532_d5099b96","updated":"2016-03-10 22:00:01.000000000","message":"same as above","commit_id":"a91a8510414d4470809f798d4763f2a7624c95ba"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"bee6d9dbab30cb9a674fe9d558d7728928720892","unresolved":false,"context_lines":[{"line_number":443,"context_line":"    cgroup.volume_type_names \u003d []"},{"line_number":444,"context_line":"    for vol_type_id in cgroup.volume_types:"},{"line_number":445,"context_line":"        vol_type \u003d volume_type_get(request, vol_type_id)"},{"line_number":446,"context_line":"        cgroup.volume_type_names.append(vol_type.name)"},{"line_number":447,"context_line":"    return cgroup"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":""}],"source_content_type":"text/x-python","patch_set":41,"id":"dab17558_d20c54ee","line":446,"updated":"2016-05-16 09:58:01.000000000","message":"It may be quicker to do a list and iterate over it than to do individual gets. The CPU time would be higher, but it\u0027d mean a single network request rather than multiple. Same goes for volume_cgroup_list_with_vol_type_names below.","commit_id":"f3b149e8d4f29a4403820016de2c7ee082d9805d"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"052180ec25d6ec815bf772cddd95af635577537e","unresolved":false,"context_lines":[{"line_number":443,"context_line":"    cgroup.volume_type_names \u003d []"},{"line_number":444,"context_line":"    for vol_type_id in cgroup.volume_types:"},{"line_number":445,"context_line":"        vol_type \u003d volume_type_get(request, vol_type_id)"},{"line_number":446,"context_line":"        cgroup.volume_type_names.append(vol_type.name)"},{"line_number":447,"context_line":"    return cgroup"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":""}],"source_content_type":"text/x-python","patch_set":41,"id":"bab6814e_0ddbbbee","line":446,"in_reply_to":"dab17558_d20c54ee","updated":"2016-05-25 17:01:20.000000000","message":"Done","commit_id":"f3b149e8d4f29a4403820016de2c7ee082d9805d"}],"openstack_dashboard/conf/cinder_policy.json":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"86066c032a890afa096439558c834d87c85bc475","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    \"consistencygroup:create_cgsnapshot\" : \"rule:admin_or_owner\","},{"line_number":105,"context_line":"    \"consistencygroup:delete_cgsnapshot\": \"rule:admin_or_owner\","},{"line_number":106,"context_line":"    \"consistencygroup:get_cgsnapshot\": \"rule:admin_or_owner\","},{"line_number":107,"context_line":"    \"consistencygroup:get_all_cgsnapshots\": \"rule:admin_or_owner\","},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    \"scheduler_extension:scheduler_stats:get_pools\" : \"rule:admin_api\","},{"line_number":110,"context_line":"    \"message:delete\": \"rule:admin_or_owner\","}],"source_content_type":"application/json","patch_set":46,"id":"7aa08908_f0add8e9","line":107,"updated":"2016-06-08 15:31:30.000000000","message":"I\u0027m assuming these are all from testing, but they need to be reverted.","commit_id":"63e95d752ba884c4332bb16c9418efa8d4c48dde"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"3111c8fa236f2b0706150c63dadd5436f01ea3bb","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    \"consistencygroup:create_cgsnapshot\" : \"rule:admin_or_owner\","},{"line_number":105,"context_line":"    \"consistencygroup:delete_cgsnapshot\": \"rule:admin_or_owner\","},{"line_number":106,"context_line":"    \"consistencygroup:get_cgsnapshot\": \"rule:admin_or_owner\","},{"line_number":107,"context_line":"    \"consistencygroup:get_all_cgsnapshots\": \"rule:admin_or_owner\","},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    \"scheduler_extension:scheduler_stats:get_pools\" : \"rule:admin_api\","},{"line_number":110,"context_line":"    \"message:delete\": \"rule:admin_or_owner\","}],"source_content_type":"application/json","patch_set":46,"id":"7aa08908_3e2e03fb","line":107,"in_reply_to":"7aa08908_f0add8e9","updated":"2016-06-08 16:34:39.000000000","message":"Done","commit_id":"63e95d752ba884c4332bb16c9418efa8d4c48dde"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"574294a8755411a1b4a7f57cb84a7d59878dec74","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    \"snapshot_extension:snapshot_manage\": \"rule:admin_api\","},{"line_number":96,"context_line":"    \"snapshot_extension:snapshot_unmanage\": \"rule:admin_api\","},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    \"consistencygroup:create\" : \"group:nodody\","},{"line_number":99,"context_line":"    \"consistencygroup:delete\": \"group:nodody\","},{"line_number":100,"context_line":"    \"consistencygroup:update\": \"group:nodody\","},{"line_number":101,"context_line":"    \"consistencygroup:get\": \"group:nodody\","},{"line_number":102,"context_line":"    \"consistencygroup:get_all\": \"group:nodody\","},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    \"consistencygroup:create_cgsnapshot\" : \"group:nodody\","},{"line_number":105,"context_line":"    \"consistencygroup:delete_cgsnapshot\": \"group:nodody\","},{"line_number":106,"context_line":"    \"consistencygroup:get_cgsnapshot\": \"group:nodody\","},{"line_number":107,"context_line":"    \"consistencygroup:get_all_cgsnapshots\": \"group:nodody\", "},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    \"scheduler_extension:scheduler_stats:get_pools\" : \"rule:admin_api\","},{"line_number":110,"context_line":"    \"message:delete\": \"rule:admin_or_owner\","}],"source_content_type":"application/json","patch_set":48,"id":"7aa08908_aee0f329","line":107,"range":{"start_line":98,"start_character":0,"end_line":107,"end_character":60},"updated":"2016-06-08 20:15:21.000000000","message":"typo: should be group:nobody","commit_id":"dfae44d64e5d130618c517566a8d14e8a7bbe487"}],"openstack_dashboard/dashboards/project/volumes/cg_snapshots/forms.py":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"bee6d9dbab30cb9a674fe9d558d7728928720892","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            return cgroup"},{"line_number":69,"context_line":"        except Exception:"},{"line_number":70,"context_line":"            redirect \u003d reverse(\"horizon:project:volumes:index\")"},{"line_number":71,"context_line":"            msg \u003d _(\u0027Unable to create consistency group snapshot.\u0027)"},{"line_number":72,"context_line":"            exceptions.handle(request,"},{"line_number":73,"context_line":"                              msg,"},{"line_number":74,"context_line":"                              redirect\u003dredirect)"}],"source_content_type":"text/x-python","patch_set":41,"id":"dab17558_92892c29","line":71,"updated":"2016-05-16 09:58:01.000000000","message":"We still have access to the name, so we could drop it in here for better feedback. Also, wouldn\u0027t this be \"unable to create consistency group from snapshot\"? Sorry if I\u0027ve misunderstood the workflow; seems to be swapping between cgroup and cgroup snapshot.","commit_id":"f3b149e8d4f29a4403820016de2c7ee082d9805d"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"052180ec25d6ec815bf772cddd95af635577537e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            return cgroup"},{"line_number":69,"context_line":"        except Exception:"},{"line_number":70,"context_line":"            redirect \u003d reverse(\"horizon:project:volumes:index\")"},{"line_number":71,"context_line":"            msg \u003d _(\u0027Unable to create consistency group snapshot.\u0027)"},{"line_number":72,"context_line":"            exceptions.handle(request,"},{"line_number":73,"context_line":"                              msg,"},{"line_number":74,"context_line":"                              redirect\u003dredirect)"}],"source_content_type":"text/x-python","patch_set":41,"id":"bab6814e_186db732","line":71,"in_reply_to":"dab17558_92892c29","updated":"2016-05-25 17:01:20.000000000","message":"agreed","commit_id":"f3b149e8d4f29a4403820016de2c7ee082d9805d"}],"openstack_dashboard/dashboards/project/volumes/cg_snapshots/tables.py":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"70f69673f86015d96ce95df3ca8dec533319a74a","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def get_object_id(self, cg_snapshot):"},{"line_number":108,"context_line":"        try:"},{"line_number":109,"context_line":"            cgroup \u003d cinder.volume_cgroup_get(self.request,"},{"line_number":110,"context_line":"                                              cg_snapshot.consistencygroup_id)"},{"line_number":111,"context_line":"        except Exception:"},{"line_number":112,"context_line":"            exceptions.handle(self.request, _(\u0027Unable to display \u0027"},{"line_number":113,"context_line":"                                              \u0027consistency group name.\u0027))"}],"source_content_type":"text/x-python","patch_set":41,"id":"dab17558_b8b24fe3","line":110,"updated":"2016-05-16 10:17:17.000000000","message":"Again, this is going to get very very expensive to run a GET every time. Consider a single list and iterating over it, or not resolving the name at all except in details pages","commit_id":"f3b149e8d4f29a4403820016de2c7ee082d9805d"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"052180ec25d6ec815bf772cddd95af635577537e","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def get_object_id(self, cg_snapshot):"},{"line_number":108,"context_line":"        try:"},{"line_number":109,"context_line":"            cgroup \u003d cinder.volume_cgroup_get(self.request,"},{"line_number":110,"context_line":"                                              cg_snapshot.consistencygroup_id)"},{"line_number":111,"context_line":"        except Exception:"},{"line_number":112,"context_line":"            exceptions.handle(self.request, _(\u0027Unable to display \u0027"},{"line_number":113,"context_line":"                                              \u0027consistency group name.\u0027))"}],"source_content_type":"text/x-python","patch_set":41,"id":"bab6814e_2852eadd","line":110,"in_reply_to":"dab17558_b8b24fe3","updated":"2016-05-25 17:01:20.000000000","message":"Agreed. Removed from table and added to detail page.","commit_id":"f3b149e8d4f29a4403820016de2c7ee082d9805d"}],"openstack_dashboard/dashboards/project/volumes/cg_snapshots/tests.py":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"bee6d9dbab30cb9a674fe9d558d7728928720892","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        res \u003d self.client.post(VOLUME_CG_SNAPSHOTS_TAB_URL, form_data,"},{"line_number":71,"context_line":"                               follow\u003dTrue)"},{"line_number":72,"context_line":"        self.assertIn(\"Scheduled deletion of Snapshot: cg_ss_1\","},{"line_number":73,"context_line":"                      [m.message for m in res.context[\u0027messages\u0027]])"}],"source_content_type":"text/x-python","patch_set":41,"id":"dab17558_f5ad02ea","line":73,"updated":"2016-05-16 09:58:01.000000000","message":"Can we test the various views are resolving and calling the APIs properly? A little light on tests :)","commit_id":"f3b149e8d4f29a4403820016de2c7ee082d9805d"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"052180ec25d6ec815bf772cddd95af635577537e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        res \u003d self.client.post(VOLUME_CG_SNAPSHOTS_TAB_URL, form_data,"},{"line_number":71,"context_line":"                               follow\u003dTrue)"},{"line_number":72,"context_line":"        self.assertIn(\"Scheduled deletion of Snapshot: cg_ss_1\","},{"line_number":73,"context_line":"                      [m.message for m in res.context[\u0027messages\u0027]])"}],"source_content_type":"text/x-python","patch_set":41,"id":"bab6814e_4e848fb0","line":73,"in_reply_to":"dab17558_f5ad02ea","updated":"2016-05-25 17:01:20.000000000","message":"will address in next patch","commit_id":"f3b149e8d4f29a4403820016de2c7ee082d9805d"}],"openstack_dashboard/dashboards/project/volumes/cgroups/forms.py":[{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"0c4d16b6b5841d437cffdd63aee769d45891d421","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            messages.success(request, message)"},{"line_number":72,"context_line":"            return True"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        except Exception:"},{"line_number":75,"context_line":"            exceptions.handle(request, _(\u0027Errors occurred in removing volumes \u0027"},{"line_number":76,"context_line":"                                         \u0027from consistency group.\u0027))"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"9a061dce_38a8f7da","line":74,"updated":"2016-04-07 00:53:06.000000000","message":"Should we redirect to the index page if the removal fails?","commit_id":"85915e8d9e872964ef8f00fdeba520f73bf74c81"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"a32adbbbf1b3bb5d9366077900176fd2556acecb","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            messages.success(request, message)"},{"line_number":72,"context_line":"            return True"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        except Exception:"},{"line_number":75,"context_line":"            exceptions.handle(request, _(\u0027Errors occurred in removing volumes \u0027"},{"line_number":76,"context_line":"                                         \u0027from consistency group.\u0027))"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"5a18252c_e5c5bd5b","line":74,"in_reply_to":"9a061dce_38a8f7da","updated":"2016-04-12 16:10:52.000000000","message":"Done","commit_id":"85915e8d9e872964ef8f00fdeba520f73bf74c81"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"0c4d16b6b5841d437cffdd63aee769d45891d421","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            messages.success(request, message)"},{"line_number":95,"context_line":"            return True"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        except Exception:"},{"line_number":98,"context_line":"            exceptions.handle(request, _(\u0027Errors occurred in deleting \u0027"},{"line_number":99,"context_line":"                                         \u0027consistency group.\u0027))"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"9a061dce_189d33bc","line":97,"updated":"2016-04-07 00:53:06.000000000","message":"Should we redirect to the index page if the delete fails? I noticed the redirect wasn\u0027t happening when working on the tests, but I\u0027m not sure if that\u0027s intended.","commit_id":"85915e8d9e872964ef8f00fdeba520f73bf74c81"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"a32adbbbf1b3bb5d9366077900176fd2556acecb","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            messages.success(request, message)"},{"line_number":95,"context_line":"            return True"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        except Exception:"},{"line_number":98,"context_line":"            exceptions.handle(request, _(\u0027Errors occurred in deleting \u0027"},{"line_number":99,"context_line":"                                         \u0027consistency group.\u0027))"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"5a18252c_45a111a9","line":97,"in_reply_to":"9a061dce_189d33bc","updated":"2016-04-12 16:10:52.000000000","message":"Done","commit_id":"85915e8d9e872964ef8f00fdeba520f73bf74c81"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"bee6d9dbab30cb9a674fe9d558d7728928720892","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            message \u003d _(\u0027Removing volumes from volume consistency \u0027"},{"line_number":83,"context_line":"                        \u0027group \"%s\"\u0027) % name"},{"line_number":84,"context_line":"            messages.success(request, message)"},{"line_number":85,"context_line":"            return True"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":41,"id":"dab17558_d506fe1a","line":84,"updated":"2016-05-16 09:58:01.000000000","message":"should probably be messages.info","commit_id":"f3b149e8d4f29a4403820016de2c7ee082d9805d"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"052180ec25d6ec815bf772cddd95af635577537e","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            message \u003d _(\u0027Removing volumes from volume consistency \u0027"},{"line_number":83,"context_line":"                        \u0027group \"%s\"\u0027) % name"},{"line_number":84,"context_line":"            messages.success(request, message)"},{"line_number":85,"context_line":"            return True"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":41,"id":"bab6814e_a8affa92","line":84,"in_reply_to":"dab17558_d506fe1a","updated":"2016-05-25 17:01:20.000000000","message":"Done","commit_id":"f3b149e8d4f29a4403820016de2c7ee082d9805d"}],"openstack_dashboard/dashboards/project/volumes/cgroups/tables.py":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"bee6d9dbab30cb9a674fe9d558d7728928720892","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    policy_rules \u003d ((\"volume\", \"consistencygroup:create_cgsnapshot\"),)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def allowed(self, request, cgroup\u003dNone):"},{"line_number":90,"context_line":"        return has_volumes_and_available(request, cgroup)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"class CloneCGroup(policy.PolicyTargetMixin, tables.LinkAction):"}],"source_content_type":"text/x-python","patch_set":41,"id":"dab17558_92d12c5a","line":90,"range":{"start_line":90,"start_character":8,"end_line":90,"end_character":57},"updated":"2016-05-16 09:58:01.000000000","message":"Is this calling volume_list for every single cgroup?","commit_id":"f3b149e8d4f29a4403820016de2c7ee082d9805d"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"052180ec25d6ec815bf772cddd95af635577537e","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    policy_rules \u003d ((\"volume\", \"consistencygroup:create_cgsnapshot\"),)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def allowed(self, request, cgroup\u003dNone):"},{"line_number":90,"context_line":"        return has_volumes_and_available(request, cgroup)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"class CloneCGroup(policy.PolicyTargetMixin, tables.LinkAction):"}],"source_content_type":"text/x-python","patch_set":41,"id":"bab6814e_eedc631a","line":90,"range":{"start_line":90,"start_character":8,"end_line":90,"end_character":57},"in_reply_to":"dab17558_92d12c5a","updated":"2016-05-25 17:01:20.000000000","message":"I modified this function (and the same function for the class below) to just check if the status of the CG is not in error. So this means the CG create from snapshot or clone will be allowed, even if the CG contains no volumes. In this case, the CG create snapshot or clone will fail with a useful message.","commit_id":"f3b149e8d4f29a4403820016de2c7ee082d9805d"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"bee6d9dbab30cb9a674fe9d558d7728928720892","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def get_data(self, request, cgroup_id):"},{"line_number":108,"context_line":"        try:"},{"line_number":109,"context_line":"            cgroup \u003d cinder.volume_cgroup_get_with_vol_type_names(request,"},{"line_number":110,"context_line":"                                                                  cgroup_id)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"            # update number of volume groups within"},{"line_number":113,"context_line":"            search_opts \u003d {\u0027consistencygroup_id\u0027: cgroup.id}"}],"source_content_type":"text/x-python","patch_set":41,"id":"dab17558_5249845f","line":110,"range":{"start_line":109,"start_character":12,"end_line":110,"end_character":76},"updated":"2016-05-16 09:58:01.000000000","message":"This is a pretty expensive API call to poll on. It\u0027s doing a GET on the cgroup, then a GET for each volume type attached to it, none of it cached. Once you scale that up, that\u0027s a hell of a lot of network latency being added.","commit_id":"f3b149e8d4f29a4403820016de2c7ee082d9805d"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"052180ec25d6ec815bf772cddd95af635577537e","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def get_data(self, request, cgroup_id):"},{"line_number":108,"context_line":"        try:"},{"line_number":109,"context_line":"            cgroup \u003d cinder.volume_cgroup_get_with_vol_type_names(request,"},{"line_number":110,"context_line":"                                                                  cgroup_id)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"            # update number of volume groups within"},{"line_number":113,"context_line":"            search_opts \u003d {\u0027consistencygroup_id\u0027: cgroup.id}"}],"source_content_type":"text/x-python","patch_set":41,"id":"bab6814e_2e0cab93","line":110,"range":{"start_line":109,"start_character":12,"end_line":110,"end_character":76},"in_reply_to":"dab17558_5249845f","updated":"2016-05-25 17:01:20.000000000","message":"I removed the \"get number of volumes\" call (no longer displaying this in the table), so that should help. Plus, the underlying API has been changed to just fetch the list of volume types once.","commit_id":"f3b149e8d4f29a4403820016de2c7ee082d9805d"}],"openstack_dashboard/dashboards/project/volumes/templates/volumes/_volume_limits.html":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"bee6d9dbab30cb9a674fe9d558d7728928720892","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"\u003cdiv class\u003d\"quota_title\"\u003e"},{"line_number":6,"context_line":"  \u003cdiv class\u003d\"pull-left\"\u003e"},{"line_number":7,"context_line":"    \u003cstrong\"\u003e{% trans \"Total Gibibytes\" %}\u003c/strong\u003e"},{"line_number":8,"context_line":"    \u003cspan\u003e({% block gigabytes_used %}{{ usages.gigabytesUsed|intcomma }}{% endblock %} {% trans \"GiB\" %})\u003c/span\u003e"},{"line_number":9,"context_line":"  \u003c/div\u003e"},{"line_number":10,"context_line":"  \u003cspan class\u003d\"pull-right\"\u003e{{ usages.maxTotalVolumeGigabytes|intcomma|quota:_(\"GiB\") }}\u003c/span\u003e"}],"source_content_type":"text/html","patch_set":41,"id":"dab17558_358b0a6a","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":12},"updated":"2016-05-16 09:58:01.000000000","message":"Got an extra \" which is messing up the highlighting.","commit_id":"f3b149e8d4f29a4403820016de2c7ee082d9805d"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"052180ec25d6ec815bf772cddd95af635577537e","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"\u003cdiv class\u003d\"quota_title\"\u003e"},{"line_number":6,"context_line":"  \u003cdiv class\u003d\"pull-left\"\u003e"},{"line_number":7,"context_line":"    \u003cstrong\"\u003e{% trans \"Total Gibibytes\" %}\u003c/strong\u003e"},{"line_number":8,"context_line":"    \u003cspan\u003e({% block gigabytes_used %}{{ usages.gigabytesUsed|intcomma }}{% endblock %} {% trans \"GiB\" %})\u003c/span\u003e"},{"line_number":9,"context_line":"  \u003c/div\u003e"},{"line_number":10,"context_line":"  \u003cspan class\u003d\"pull-right\"\u003e{{ usages.maxTotalVolumeGigabytes|intcomma|quota:_(\"GiB\") }}\u003c/span\u003e"}],"source_content_type":"text/html","patch_set":41,"id":"bab6814e_dbc0467f","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":12},"in_reply_to":"dab17558_358b0a6a","updated":"2016-05-25 17:01:20.000000000","message":"Done","commit_id":"f3b149e8d4f29a4403820016de2c7ee082d9805d"}],"openstack_dashboard/dashboards/project/volumes/urls.py":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"cf96c65dc40b4f88e1fcab8d340308c8e950ebc3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 Nebula, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":21,"id":"5aef4532_d517dba0","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":1},"updated":"2016-03-10 17:52:02.000000000","message":"Remove","commit_id":"a91a8510414d4470809f798d4763f2a7624c95ba"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"80159ca725008b6b3b1abf77e91f3f61b0343626","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 Nebula, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":21,"id":"5aef4532_26752aca","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":1},"in_reply_to":"5aef4532_d517dba0","updated":"2016-03-10 22:00:01.000000000","message":"no change - existing file copyright","commit_id":"a91a8510414d4470809f798d4763f2a7624c95ba"}],"openstack_dashboard/dashboards/project/volumes/volumes/tables.py":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"cf96c65dc40b4f88e1fcab8d340308c8e950ebc3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 Nebula, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":21,"id":"5aef4532_b51fafb5","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":1},"updated":"2016-03-10 17:52:02.000000000","message":"Remove","commit_id":"a91a8510414d4470809f798d4763f2a7624c95ba"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"80159ca725008b6b3b1abf77e91f3f61b0343626","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 Nebula, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":21,"id":"5aef4532_a64f7a90","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":1},"in_reply_to":"5aef4532_b51fafb5","updated":"2016-03-10 22:00:01.000000000","message":"no change - existing file copyright","commit_id":"a91a8510414d4470809f798d4763f2a7624c95ba"}],"openstack_dashboard/test/test_data/cinder_data.py":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"cf96c65dc40b4f88e1fcab8d340308c8e950ebc3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 Nebula, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":21,"id":"5aef4532_7570870b","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":1},"updated":"2016-03-10 17:52:02.000000000","message":"Remove","commit_id":"a91a8510414d4470809f798d4763f2a7624c95ba"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"80159ca725008b6b3b1abf77e91f3f61b0343626","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 Nebula, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":21,"id":"5aef4532_c69726ea","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":1},"in_reply_to":"5aef4532_7570870b","updated":"2016-03-10 22:00:01.000000000","message":"no change - existing file copyright","commit_id":"a91a8510414d4470809f798d4763f2a7624c95ba"}],"releasenotes/notes/bp-cinder-consistency-groups-7cc98fda0ff3bb7a.yaml":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"bee6d9dbab30cb9a674fe9d558d7728928720892","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  - Policies associated with Consistency Groups exist in the Cinder policy file, and"},{"line_number":13,"context_line":"    by default, all actions are disabled. Also, there is a flag in the Horizon"},{"line_number":14,"context_line":"    local_settings that must be enabled to see the new tabs. The flag is named"},{"line_number":15,"context_line":"    \u0027enable_consistency_groups\u0027."}],"source_content_type":"text/x-yaml","patch_set":41,"id":"dab17558_559dee64","line":15,"updated":"2016-05-16 09:58:01.000000000","message":"The security section is for fixed security issues. We should just put this part under the feature part, or \u0027other\u0027.","commit_id":"f3b149e8d4f29a4403820016de2c7ee082d9805d"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"052180ec25d6ec815bf772cddd95af635577537e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  - Policies associated with Consistency Groups exist in the Cinder policy file, and"},{"line_number":13,"context_line":"    by default, all actions are disabled. Also, there is a flag in the Horizon"},{"line_number":14,"context_line":"    local_settings that must be enabled to see the new tabs. The flag is named"},{"line_number":15,"context_line":"    \u0027enable_consistency_groups\u0027."}],"source_content_type":"text/x-yaml","patch_set":41,"id":"bab6814e_6e023340","line":15,"in_reply_to":"dab17558_559dee64","updated":"2016-05-25 17:01:20.000000000","message":"Done","commit_id":"f3b149e8d4f29a4403820016de2c7ee082d9805d"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"86066c032a890afa096439558c834d87c85bc475","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    snapshot all volumes in a CG, clone all volumes in a CG, and create a new CG and"},{"line_number":10,"context_line":"    volumes from a CG snapshot."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    | Policies associated with Consistency Groups exist in the Cinder policy file, and"},{"line_number":13,"context_line":"    by default, all actions are disabled."}],"source_content_type":"text/x-yaml","patch_set":46,"id":"7aa08908_9da46cba","line":12,"range":{"start_line":12,"start_character":4,"end_line":12,"end_character":6},"updated":"2016-06-08 15:31:30.000000000","message":"Not sure what this is for, but it renders a little oddly. See http://docs-draft.openstack.org/68/268368/46/check/gate-horizon-releasenotes/3909658//releasenotes/build/html/unreleased.html Just remove the |","commit_id":"63e95d752ba884c4332bb16c9418efa8d4c48dde"},{"author":{"_account_id":11941,"name":"Richard Hagarty","email":"rich.hagarty@ibm.com","username":"rhagarty"},"change_message_id":"3111c8fa236f2b0706150c63dadd5436f01ea3bb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    snapshot all volumes in a CG, clone all volumes in a CG, and create a new CG and"},{"line_number":10,"context_line":"    volumes from a CG snapshot."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    | Policies associated with Consistency Groups exist in the Cinder policy file, and"},{"line_number":13,"context_line":"    by default, all actions are disabled."}],"source_content_type":"text/x-yaml","patch_set":46,"id":"7aa08908_def6df5b","line":12,"range":{"start_line":12,"start_character":4,"end_line":12,"end_character":6},"in_reply_to":"7aa08908_9da46cba","updated":"2016-06-08 16:34:39.000000000","message":"Done","commit_id":"63e95d752ba884c4332bb16c9418efa8d4c48dde"}]}
