)]}'
{"openstack_dashboard/test/integration_tests/pages/project/compute/instancespage.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"870ee520e96c0e8d7893681600ea01914986664e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        delete_button.click()"},{"line_number":43,"context_line":"        return forms.BaseFormRegion(self.driver, self.conf)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def is_next_link_available(self):"},{"line_number":46,"context_line":"        return self._is_element_visible(*self._next_locator)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def next_page(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_26c1f62e","line":45,"updated":"2016-01-20 07:43:17.000000000","message":"We should reuse methods from TableRegion, these overrides could be skipped.","commit_id":"a614d8e07313362c15ffc9415b76da2fae75a5ef"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"07780f439e7356b49e7f764eb6ab862f66a4d4a4","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        \"volume_id\", \"volume_snapshot_id\", \"image_id\", \"volume_size\","},{"line_number":25,"context_line":"        \"vol_delete_on_instance_delete\"),"},{"line_number":26,"context_line":"        (\"keypair\", \"groups\"),"},{"line_number":27,"context_line":"        (\"selected_network\", \"available_network\"),"},{"line_number":28,"context_line":"        (\"script_source\", \"script_upload\", \"script_data\"),"},{"line_number":29,"context_line":"        (\"disk_config\", \"config_drive\")"},{"line_number":30,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_89c7c011","line":27,"updated":"2016-01-28 11:25:57.000000000","message":"You really should use new mapping fields feature to map a separate region to that widget (because standard form field machinery won\u0027t work with it).","commit_id":"fb9539ceb7b3a7a401017eb28aa730f20a68d834"}],"openstack_dashboard/test/integration_tests/regions/tables.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"8a43a09529597106447f00555b93c1867924d389","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        actual_table \u003d {\u0027Next\u0027: self.is_next_link_available(),"},{"line_number":157,"context_line":"                        \u0027Prev\u0027: self.is_prev_link_available(),"},{"line_number":158,"context_line":"                        \u0027Count\u0027: len(self.rows),"},{"line_number":159,"context_line":"                        \u0027Names\u0027: sorted(names)}"},{"line_number":160,"context_line":"        self.assertDictEqual(actual_table, expected_table_definition)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_ea819190","line":159,"updated":"2016-01-21 09:17:59.000000000","message":"I think we should not sort actual names by default, because it could hide ordering bugs in images pagination test. Instead, we could add a boolean arg to assert_definition method specifying whether to sort them.","commit_id":"7ded891f3c97063a9e27cc50c0fa860926dd0d45"}],"openstack_dashboard/test/integration_tests/tests/test_instances.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"870ee520e96c0e8d7893681600ea01914986664e","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        instances_page.instances_table.filter(instance_list[1])"},{"line_number":91,"context_line":"        instances_page.instances_table.assert_definition(filter_first_instance)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        instances_page.instances_table.clear_search_field()"},{"line_number":94,"context_line":"        instances_page.instances_table.filter(instance_list[0])"},{"line_number":95,"context_line":"        instances_page.instances_table.assert_definition("},{"line_number":96,"context_line":"            second_page_definition)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_c661fa3a","line":93,"updated":"2016-01-20 07:43:17.000000000","message":"Afaik, the following filter() method resets filter input contents. Do we need to clear it explicitly?","commit_id":"a614d8e07313362c15ffc9415b76da2fae75a5ef"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"870ee520e96c0e8d7893681600ea01914986664e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        instances_page.instances_table.assert_definition("},{"line_number":96,"context_line":"            second_page_definition)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        instances_page.instances_table.clear_search_field()"},{"line_number":99,"context_line":"        instances_page.instances_table.filter(instance_name)"},{"line_number":100,"context_line":"        instances_page.instances_table.assert_definition(filter_both_instances)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_a65e4674","line":98,"updated":"2016-01-20 07:43:17.000000000","message":"Ditto","commit_id":"a614d8e07313362c15ffc9415b76da2fae75a5ef"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"8a43a09529597106447f00555b93c1867924d389","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class TestInstance(helpers.TestCase):"},{"line_number":17,"context_line":"    INSTANCES_NAME \u003d helpers.gen_random_resource_name(\u0027instance\u0027,"},{"line_number":18,"context_line":"                                                      timestamp\u003dFalse)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def test_create_delete_instance(self):"},{"line_number":21,"context_line":"        \"\"\"tests the instance creation and deletion functionality:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_5e209e9b","line":18,"updated":"2016-01-21 09:17:59.000000000","message":"You use this class attribute only in the first method. Why not make it a function-scoped variable then?","commit_id":"7ded891f3c97063a9e27cc50c0fa860926dd0d45"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"8a43a09529597106447f00555b93c1867924d389","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    def test_instances_pagination(self):"},{"line_number":45,"context_line":"        \"\"\"This test checks instance pagination"},{"line_number":46,"context_line":"        Steps:"},{"line_number":47,"context_line":"        1) Login to Horizon Dashboard as horizon user"},{"line_number":48,"context_line":"        2) Navigate to user settings page"},{"line_number":49,"context_line":"        3) Change \u0027Items Per Page\u0027 value to 1"},{"line_number":50,"context_line":"        4) Go to Project \u003e Compute \u003e Instances page"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_ca1dad74","line":47,"updated":"2016-01-21 09:17:59.000000000","message":"As a regular user","commit_id":"7ded891f3c97063a9e27cc50c0fa860926dd0d45"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"8a43a09529597106447f00555b93c1867924d389","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        items_per_page \u003d 1"},{"line_number":62,"context_line":"        instance_count \u003d 2"},{"line_number":63,"context_line":"        instance_list \u003d [\"{0}-{1}\".format(instance_name, item)"},{"line_number":64,"context_line":"                         for item in range(1, 3)]"},{"line_number":65,"context_line":"        first_page_definition \u003d {\u0027Next\u0027: True, \u0027Prev\u0027: False,"},{"line_number":66,"context_line":"                                 \u0027Count\u0027: items_per_page,"},{"line_number":67,"context_line":"                                 \u0027Names\u0027: [instance_list[1]]}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_9e2cd64b","line":64,"updated":"2016-01-21 09:17:59.000000000","message":"3 -\u003e instance_count - 1","commit_id":"7ded891f3c97063a9e27cc50c0fa860926dd0d45"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"8a43a09529597106447f00555b93c1867924d389","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        instances_page.instances_table.assert_definition(first_page_definition)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        instances_page.delete_instance(instance_list[1])"},{"line_number":89,"context_line":"        instances_page.find_message_and_dismiss(messages.SUCCESS)"},{"line_number":90,"context_line":"        instances_page.instances_table.turn_next_page()"},{"line_number":91,"context_line":"        instances_page.delete_instance(instance_list[0])"},{"line_number":92,"context_line":"        instances_page.find_message_and_dismiss(messages.SUCCESS)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_bed51a44","line":89,"updated":"2016-01-21 09:17:59.000000000","message":"I wonder, if it would be more valuable to wait until instance is actually deleted (like in create/delete test) and then check the consequences?","commit_id":"7ded891f3c97063a9e27cc50c0fa860926dd0d45"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"8a43a09529597106447f00555b93c1867924d389","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    def test_instances_pagination_filtration(self):"},{"line_number":99,"context_line":"        \"\"\"This test checks instance pagination and filtration"},{"line_number":100,"context_line":"        Steps:"},{"line_number":101,"context_line":"        1) Login to Horizon Dashboard as horizon user"},{"line_number":102,"context_line":"        2) Navigate to user settings page"},{"line_number":103,"context_line":"        3) Change \u0027Items Per Page\u0027 value to 1"},{"line_number":104,"context_line":"        4) Go to Project \u003e Compute \u003e Instances page"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_3ec28a86","line":101,"updated":"2016-01-21 09:17:59.000000000","message":"A regular user","commit_id":"7ded891f3c97063a9e27cc50c0fa860926dd0d45"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"8a43a09529597106447f00555b93c1867924d389","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        instances_page \u003d self.home_pg.go_to_compute_instancespage()"},{"line_number":136,"context_line":"        instances_page.create_instance(instance_name,"},{"line_number":137,"context_line":"                                       instance_count\u003dinstance_count)"},{"line_number":138,"context_line":"        instances_page.instances_table.assert_definition(first_page_definition)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        instances_page.instances_table.turn_next_page()"},{"line_number":141,"context_line":"        instances_page.instances_table.assert_definition("}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_5eabbe89","line":138,"updated":"2016-01-21 09:17:59.000000000","message":"You already tested this and the next assertion in pagination test, I suggest to skip it there and immediately start with filtration.","commit_id":"7ded891f3c97063a9e27cc50c0fa860926dd0d45"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"8a43a09529597106447f00555b93c1867924d389","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        instances_page.instances_table.assert_definition(first_page_definition)"},{"line_number":154,"context_line":"        instances_page.instances_table.filter(\u0027\u0027)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        instances_page.delete_instance(instance_list[1])"},{"line_number":157,"context_line":"        instances_page.find_message_and_dismiss(messages.SUCCESS)"},{"line_number":158,"context_line":"        instances_page.instances_table.turn_next_page()"},{"line_number":159,"context_line":"        instances_page.delete_instance(instance_list[0])"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_9e8ff622","line":156,"updated":"2016-01-21 09:17:59.000000000","message":"Same comment about waiting till entry is actually deleted. Or, if you need this as a part of cleanup, you could move tests creating multiple instances to a separate test case, create instances and set items per page in setUp, delete them and restore settings in tearDown.","commit_id":"7ded891f3c97063a9e27cc50c0fa860926dd0d45"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"07780f439e7356b49e7f764eb6ab862f66a4d4a4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    ADMIN_PASSWORD \u003d CONFIG.identity.admin_password"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(TestInstance, self).setUp()"},{"line_number":29,"context_line":"        self.login_pg \u003d loginpage.LoginPage(self.driver, self.CONFIG)"},{"line_number":30,"context_line":"        self.login_pg.go_to_login_page()"},{"line_number":31,"context_line":"        self.home_pg_admin \u003d self.login_pg.login("}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_a99abc12","line":28,"updated":"2016-01-28 11:25:57.000000000","message":"It\u0027s better to subclass AdminTestCase here, because it\u0027s setUp() does half of the actions you\u0027re doing here.","commit_id":"fb9539ceb7b3a7a401017eb28aa730f20a68d834"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"07780f439e7356b49e7f764eb6ab862f66a4d4a4","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        self.login_pg.go_to_login_page()"},{"line_number":31,"context_line":"        self.home_pg_admin \u003d self.login_pg.login("},{"line_number":32,"context_line":"            user\u003dself.ADMIN_USERNAME, password\u003dself.ADMIN_PASSWORD)"},{"line_number":33,"context_line":"        networks_page \u003d self.home_pg_admin.go_to_system_networkspage()"},{"line_number":34,"context_line":"        networks_page.edit_network(\u0027private\u0027, is_shared\u003dTrue)"},{"line_number":35,"context_line":"        self.home_pg_admin.log_out()"},{"line_number":36,"context_line":"        time.sleep(1)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_a9c15ce6","line":33,"updated":"2016-01-28 11:25:57.000000000","message":"Then, here you could use self.home_pg of admin test case.","commit_id":"fb9539ceb7b3a7a401017eb28aa730f20a68d834"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"07780f439e7356b49e7f764eb6ab862f66a4d4a4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        self.home_pg_admin \u003d self.login_pg.login("},{"line_number":32,"context_line":"            user\u003dself.ADMIN_USERNAME, password\u003dself.ADMIN_PASSWORD)"},{"line_number":33,"context_line":"        networks_page \u003d self.home_pg_admin.go_to_system_networkspage()"},{"line_number":34,"context_line":"        networks_page.edit_network(\u0027private\u0027, is_shared\u003dTrue)"},{"line_number":35,"context_line":"        self.home_pg_admin.log_out()"},{"line_number":36,"context_line":"        time.sleep(1)"},{"line_number":37,"context_line":"        self.login_pg.go_to_login_page()"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_69bb6473","line":34,"updated":"2016-01-28 11:25:57.000000000","message":"Don\u0027t forget to dismiss SUCCESS message here. Once you do it, time.sleep() won\u0027t be needed.","commit_id":"fb9539ceb7b3a7a401017eb28aa730f20a68d834"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"07780f439e7356b49e7f764eb6ab862f66a4d4a4","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def tearDown(self):"},{"line_number":192,"context_line":"        self.home_pg.log_out()"},{"line_number":193,"context_line":"        self.home_pg_admin \u003d self.login_pg.login("},{"line_number":194,"context_line":"            user\u003dself.ADMIN_USERNAME, password\u003dself.ADMIN_PASSWORD)"},{"line_number":195,"context_line":"        networks_page \u003d self.home_pg_admin.go_to_system_networkspage()"},{"line_number":196,"context_line":"        networks_page.edit_network(\u0027private\u0027, is_shared\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_697284e7","line":193,"updated":"2016-01-28 11:25:57.000000000","message":"Actually, you don\u0027t even need to write new page to self.","commit_id":"fb9539ceb7b3a7a401017eb28aa730f20a68d834"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"07780f439e7356b49e7f764eb6ab862f66a4d4a4","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        self.home_pg_admin \u003d self.login_pg.login("},{"line_number":194,"context_line":"            user\u003dself.ADMIN_USERNAME, password\u003dself.ADMIN_PASSWORD)"},{"line_number":195,"context_line":"        networks_page \u003d self.home_pg_admin.go_to_system_networkspage()"},{"line_number":196,"context_line":"        networks_page.edit_network(\u0027private\u0027, is_shared\u003dFalse)"},{"line_number":197,"context_line":"        super(TestInstance, self).tearDown()"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_49446873","line":196,"updated":"2016-01-28 11:25:57.000000000","message":"Again, don\u0027t forget to dismiss the message here.","commit_id":"fb9539ceb7b3a7a401017eb28aa730f20a68d834"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"6aeb6d0d72fdd4019f3fcdfc26c2f91edb69e291","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        instances_page.delete_instance(instance_list[1])"},{"line_number":98,"context_line":"        instances_page.find_message_and_dismiss(messages.SUCCESS)"},{"line_number":99,"context_line":"        self.assertTrue(instances_page.is_instance_deleted(instance_list[1]))"},{"line_number":100,"context_line":"        instances_page.instances_table.turn_next_page()"},{"line_number":101,"context_line":"        instances_page.delete_instance(instance_list[0])"},{"line_number":102,"context_line":"        instances_page.find_message_and_dismiss(messages.SUCCESS)"}],"source_content_type":"text/x-python","patch_set":14,"id":"dae33548_174c68c6","line":99,"updated":"2016-02-15 13:41:08.000000000","message":"This weird behavior (first page becoming empty with active Next link - instead of refilling pages so the first page now contains an instance from the second page) looks like a bug to me and I don\u0027t think we should rely on this behavior in tests. Actually, I filed https://bugs.launchpad.net/horizon/+bug/1545724\n\nInstead I suggest to first reset the number of items per page (line 105) and then delete all instances (which should be now displayed on one page).","commit_id":"e9bf78e11467fa6651d9e4f1833380a969d74783"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"b8fa7909b28cc14e8b0b5176b44918d3f4030254","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        instance_count \u003d 2"},{"line_number":66,"context_line":"        instance_list \u003d [\"{0}-{1}\".format(self.INSTANCE_NAME, item)"},{"line_number":67,"context_line":"                         for item in range(1, instance_count + 1)]"},{"line_number":68,"context_line":"        first_page_definition \u003d {\u0027Next\u0027: True, \u0027Prev\u0027: False,"},{"line_number":69,"context_line":"                                 \u0027Count\u0027: items_per_page,"},{"line_number":70,"context_line":"                                 \u0027Names\u0027: [instance_list[1]]}"},{"line_number":71,"context_line":"        second_page_definition \u003d {\u0027Next\u0027: False, \u0027Prev\u0027: False,"}],"source_content_type":"text/x-python","patch_set":22,"id":"3afc51ec_be456eb4","line":68,"updated":"2016-03-14 08:56:01.000000000","message":"The base of this patch is now a change that adds \u0027Prev\u0027 link to Instances table. We should use the same pattern for Instances as we already use for Images - 3 entities, \u0027Prev\u0027 is available on 2nd and 3rd pages.","commit_id":"e4442ee2bfb54d0d00c5d1f4af5046941e20e7ff"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"b8fa7909b28cc14e8b0b5176b44918d3f4030254","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        instance_count \u003d 2"},{"line_number":128,"context_line":"        instance_list \u003d [\"{0}-{1}\".format(self.INSTANCE_NAME, item)"},{"line_number":129,"context_line":"                         for item in range(1, instance_count + 1)]"},{"line_number":130,"context_line":"        first_page_definition \u003d {\u0027Next\u0027: True, \u0027Prev\u0027: False,"},{"line_number":131,"context_line":"                                 \u0027Count\u0027: items_per_page,"},{"line_number":132,"context_line":"                                 \u0027Names\u0027: [instance_list[1]]}"},{"line_number":133,"context_line":"        second_page_definition \u003d {\u0027Next\u0027: False, \u0027Prev\u0027: False,"}],"source_content_type":"text/x-python","patch_set":22,"id":"3afc51ec_9e27d211","line":130,"updated":"2016-03-14 08:56:01.000000000","message":"ditto","commit_id":"e4442ee2bfb54d0d00c5d1f4af5046941e20e7ff"}]}
