)]}'
{"openstack_dashboard/static/app/core/images/filters/image-visibility.filter.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"24a2e9b1c84396264b477b52258a9647da53eb00","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    function evaluateImageProperties(image) {"},{"line_number":63,"context_line":"      if (angular.isDefined(image.visibility)) {"},{"line_number":64,"context_line":"        return (imageVisibility[image.visibility]);"},{"line_number":65,"context_line":"      } else if (image.is_public) {"},{"line_number":66,"context_line":"        return imageVisibility.public;"},{"line_number":67,"context_line":"      } else {"}],"source_content_type":"text/javascript","patch_set":3,"id":"9a68dd71_00ce535a","line":64,"range":{"start_line":64,"start_character":31,"end_line":64,"end_character":49},"updated":"2016-01-26 20:28:22.000000000","message":"what is behavior if the value doesn\u0027t match a key from the object?  Is it OK to just return \u0027undefined\u0027?","commit_id":"89b0c686c00fb0efa8aebe2e7ae4c6d6ca7ea618"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"ba95d88f73907ded684512e71ba57ae6519bd6f1","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    function evaluateImageProperties(image) {"},{"line_number":63,"context_line":"      if (angular.isDefined(image.visibility)) {"},{"line_number":64,"context_line":"        return (imageVisibility[image.visibility]);"},{"line_number":65,"context_line":"      } else if (image.is_public) {"},{"line_number":66,"context_line":"        return imageVisibility.public;"},{"line_number":67,"context_line":"      } else {"}],"source_content_type":"text/javascript","patch_set":3,"id":"7a5de9d1_652639bc","line":64,"range":{"start_line":64,"start_character":31,"end_line":64,"end_character":49},"in_reply_to":"7a5de9d1_a0caed4d","updated":"2016-01-28 01:07:18.000000000","message":"Done","commit_id":"89b0c686c00fb0efa8aebe2e7ae4c6d6ca7ea618"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"449301207f72d7a1f97eb475973dcd8c1bc54642","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    function evaluateImageProperties(image) {"},{"line_number":63,"context_line":"      if (angular.isDefined(image.visibility)) {"},{"line_number":64,"context_line":"        return (imageVisibility[image.visibility]);"},{"line_number":65,"context_line":"      } else if (image.is_public) {"},{"line_number":66,"context_line":"        return imageVisibility.public;"},{"line_number":67,"context_line":"      } else {"}],"source_content_type":"text/javascript","patch_set":3,"id":"7a5de9d1_a0caed4d","line":64,"range":{"start_line":64,"start_character":31,"end_line":64,"end_character":49},"in_reply_to":"9a68dd71_00ce535a","updated":"2016-01-27 18:47:18.000000000","message":"I guess I\u0027d prefer that it return the key string if the value is not present, even if not localized, etc.  Thoughts?","commit_id":"89b0c686c00fb0efa8aebe2e7ae4c6d6ca7ea618"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"52e6bc9a5b13ac3715adc12f19bd20671dd2442c","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        return translation;"},{"line_number":85,"context_line":"      } else {"},{"line_number":86,"context_line":"        // \"foo_bar\" --\u003e \"Foo Bar\""},{"line_number":87,"context_line":"        return titleFilter(noUnderscoreFilter(visibility));"},{"line_number":88,"context_line":"      }"},{"line_number":89,"context_line":"    }"},{"line_number":90,"context_line":""}],"source_content_type":"text/javascript","patch_set":4,"id":"7a5de9d1_a0497fd2","line":87,"updated":"2016-01-28 01:54:27.000000000","message":"Just thinking about this a bit more and I think it is better to just show actual status with no attempts to clean up. So will remove that.","commit_id":"10917fe586fcaa1f0f96a4488ebb478b76c52bc0"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"0d29903993087b47ed4f90a7443e6a15ec57954d","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  angular"},{"line_number":20,"context_line":"    .module(\u0027horizon.app.core.images\u0027)"},{"line_number":21,"context_line":"    .filter(\u0027imageVisibility\u0027, imageVisibilityFilter);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  imageVisibilityFilter.$inject \u003d ["},{"line_number":24,"context_line":"    \u0027horizon.framework.util.i18n.gettext\u0027"}],"source_content_type":"text/javascript","patch_set":7,"id":"7a5de9d1_89ef8b86","line":21,"updated":"2016-01-29 05:48:47.000000000","message":"We are fully qualifying these things these days.","commit_id":"5e4ee58f70a3a8b7b59c9ecd8a47ca027f8107a7"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"37d4dde7a8bd653931251ecd322ec4c4a8bd6c44","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  angular"},{"line_number":20,"context_line":"    .module(\u0027horizon.app.core.images\u0027)"},{"line_number":21,"context_line":"    .filter(\u0027imageVisibility\u0027, imageVisibilityFilter);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  imageVisibilityFilter.$inject \u003d ["},{"line_number":24,"context_line":"    \u0027horizon.framework.util.i18n.gettext\u0027"}],"source_content_type":"text/javascript","patch_set":7,"id":"7a5de9d1_8a019d6c","line":21,"in_reply_to":"7a5de9d1_89ef8b86","updated":"2016-01-29 16:43:46.000000000","message":"Hey Richard, are we doing that now for filters as well?  Perhaps they should be, but I patterned this off the other filters in horizon which don\u0027t use the fully qualified. I believe done originally to keep the html tidier (although even an hz- prefix might have made more sense).  In any case, went with existing pattern for filter, but if you feel strongly on this, it can be changed.\n\nRefs:\n\n https://github.com/openstack/horizon/blob/master/horizon/static/framework/util/filters/filters.js\n\n https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/filters/image-status.filter.js#L21\n\n https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/table/images-table.html#L73","commit_id":"5e4ee58f70a3a8b7b59c9ecd8a47ca027f8107a7"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"7018417c81f16bca203138c2aa07175ca361b393","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  angular"},{"line_number":20,"context_line":"    .module(\u0027horizon.app.core.images\u0027)"},{"line_number":21,"context_line":"    .filter(\u0027imageVisibility\u0027, imageVisibilityFilter);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  imageVisibilityFilter.$inject \u003d ["},{"line_number":24,"context_line":"    \u0027horizon.framework.util.i18n.gettext\u0027"}],"source_content_type":"text/javascript","patch_set":7,"id":"7a5de9d1_6a80e1f7","line":21,"in_reply_to":"7a5de9d1_89ef8b86","updated":"2016-01-29 16:42:33.000000000","message":"I think that makes sense for services, but for filters it isn\u0027t an established pattern, and it would be ugly:\n\n\"ctrl.image | horizon.app.core.images.imageVisibility\"\n\nespecially with multiple pipes/filters.","commit_id":"5e4ee58f70a3a8b7b59c9ecd8a47ca027f8107a7"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"e83ca6e9164eb01c3510ceecf0d9e2b2de95c1d7","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  angular"},{"line_number":20,"context_line":"    .module(\u0027horizon.app.core.images\u0027)"},{"line_number":21,"context_line":"    .filter(\u0027imageVisibility\u0027, imageVisibilityFilter);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  imageVisibilityFilter.$inject \u003d ["},{"line_number":24,"context_line":"    \u0027horizon.framework.util.i18n.gettext\u0027"}],"source_content_type":"text/javascript","patch_set":7,"id":"7a5de9d1_3afc70b7","line":21,"in_reply_to":"7a5de9d1_8a019d6c","updated":"2016-01-29 21:17:43.000000000","message":"Ah, of course, it makes sense to have the more terse name in this context. The full qualification of names is a relatively new thing a few weeks old now, to bring consistency into the naming. There was an email thread :-)","commit_id":"5e4ee58f70a3a8b7b59c9ecd8a47ca027f8107a7"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"0af52f69ca6619a7c146f0cb06dafd559315c5f7","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    function deriveSharingStatus(image, currentProjectId, translatedVisibility) {"},{"line_number":110,"context_line":"      if (angular.equals(translatedVisibility, imageVisibility.public)) {"},{"line_number":111,"context_line":"        return translatedVisibility;"},{"line_number":112,"context_line":"      } else if (angular.isDefined(currentProjectId) \u0026\u0026"},{"line_number":113,"context_line":"        !angular.equals(image.owner, currentProjectId)) {"},{"line_number":114,"context_line":"        return imageVisibility.shared_with_me;"}],"source_content_type":"text/javascript","patch_set":7,"id":"7a5de9d1_097b34c2","line":111,"updated":"2016-02-01 16:09:31.000000000","message":"nit of the highest order: IMO it would improve readability to return imageVisability.public here, since that\u0027s the only value than can be returned in this block.","commit_id":"5e4ee58f70a3a8b7b59c9ecd8a47ca027f8107a7"}],"openstack_dashboard/static/app/core/images/filters/image-visibility.filter.spec.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"24a2e9b1c84396264b477b52258a9647da53eb00","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      it(\u0027returns Private for visibility.private\u0027, function () {"},{"line_number":34,"context_line":"        expect(imageVisibilityFilter({visibility: \u0027private\u0027})).toBe(\u0027Private\u0027);"},{"line_number":35,"context_line":"      });"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"      it(\u0027returns Public for is_public \u003d true\u0027, function () {"},{"line_number":38,"context_line":"        expect(imageVisibilityFilter({is_public: true})).toBe(\u0027Public\u0027);"},{"line_number":39,"context_line":"      });"}],"source_content_type":"text/javascript","patch_set":3,"id":"9a68dd71_0079732f","line":36,"updated":"2016-01-26 20:28:22.000000000","message":"Depending on decision for handling unknown visibility values, should have a test in here.","commit_id":"89b0c686c00fb0efa8aebe2e7ae4c6d6ca7ea618"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"ba95d88f73907ded684512e71ba57ae6519bd6f1","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      it(\u0027returns Private for visibility.private\u0027, function () {"},{"line_number":34,"context_line":"        expect(imageVisibilityFilter({visibility: \u0027private\u0027})).toBe(\u0027Private\u0027);"},{"line_number":35,"context_line":"      });"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"      it(\u0027returns Public for is_public \u003d true\u0027, function () {"},{"line_number":38,"context_line":"        expect(imageVisibilityFilter({is_public: true})).toBe(\u0027Public\u0027);"},{"line_number":39,"context_line":"      });"}],"source_content_type":"text/javascript","patch_set":3,"id":"7a5de9d1_0538a5d2","line":36,"in_reply_to":"9a68dd71_0079732f","updated":"2016-01-28 01:07:18.000000000","message":"Done","commit_id":"89b0c686c00fb0efa8aebe2e7ae4c6d6ca7ea618"}],"openstack_dashboard/static/app/core/images/table/images-table.controller.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"24a2e9b1c84396264b477b52258a9647da53eb00","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    }"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    function onGetImages(response) {"},{"line_number":75,"context_line":"      ctrl.imagesSrc.length \u003d 0;"},{"line_number":76,"context_line":"      angular.forEach(response.items, function itemFilter (image) {"},{"line_number":77,"context_line":"        //This sets up data expected by the table for display or sorting."},{"line_number":78,"context_line":"        image.visibility \u003d imageVisibilityFilter(image);"}],"source_content_type":"text/javascript","patch_set":3,"id":"9a68dd71_40ec4b8f","line":75,"range":{"start_line":75,"start_character":21,"end_line":75,"end_character":31},"updated":"2016-01-26 20:28:22.000000000","message":"Cool, I didn\u0027t know you could do this! :)","commit_id":"89b0c686c00fb0efa8aebe2e7ae4c6d6ca7ea618"}],"openstack_dashboard/static/app/core/images/table/images-table.html":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"2b85cfe7a45f9328f8000aa13f999ab81ce4ac61","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      \u003cth class\u003d\"rsp-p1\" st-sort\u003d\"name\" st-sort-default\u003d\"name\" translate\u003eImage Name\u003c/th\u003e"},{"line_number":40,"context_line":"      \u003cth class\u003d\"rsp-p1\" st-sort\u003d\"type\" translate\u003eType\u003c/th\u003e"},{"line_number":41,"context_line":"      \u003cth class\u003d\"rsp-p1\" st-sort\u003d\"status\" translate\u003eStatus\u003c/th\u003e"},{"line_number":42,"context_line":"      \u003cth class\u003d\"rsp-p2\" st-sort\u003d\"visibility\" translate\u003eVisibility\u003c/th\u003e"},{"line_number":43,"context_line":"      \u003cth class\u003d\"rsp-p2\" st-sort\u003d\"protected\" translate\u003eProtected\u003c/th\u003e"},{"line_number":44,"context_line":"      \u003cth class\u003d\"rsp-p2\" st-sort\u003d\"disk_format\" translate\u003eFormat\u003c/th\u003e"},{"line_number":45,"context_line":"      \u003cth class\u003d\"rsp-p2\" st-sort\u003d\"size\" translate\u003eSize\u003c/th\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"9a68dd71_5d19d220","line":42,"range":{"start_line":42,"start_character":34,"end_line":42,"end_character":44},"updated":"2016-01-25 18:12:47.000000000","message":"I think this will only sort those values that have the \u0027visibility\u0027 property set, so nothing just coming across with is_public, etc.  I believe this is processed before consideration of the filter, but I haven\u0027t tested.","commit_id":"c892b5e776469f2ea6dea93837fbdc750ba00b48"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"16c07a4c55f25a37d117cf3fd0485cd24467d79a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      \u003cth class\u003d\"rsp-p1\" st-sort\u003d\"name\" st-sort-default\u003d\"name\" translate\u003eImage Name\u003c/th\u003e"},{"line_number":40,"context_line":"      \u003cth class\u003d\"rsp-p1\" st-sort\u003d\"type\" translate\u003eType\u003c/th\u003e"},{"line_number":41,"context_line":"      \u003cth class\u003d\"rsp-p1\" st-sort\u003d\"status\" translate\u003eStatus\u003c/th\u003e"},{"line_number":42,"context_line":"      \u003cth class\u003d\"rsp-p2\" st-sort\u003d\"visibility\" translate\u003eVisibility\u003c/th\u003e"},{"line_number":43,"context_line":"      \u003cth class\u003d\"rsp-p2\" st-sort\u003d\"protected\" translate\u003eProtected\u003c/th\u003e"},{"line_number":44,"context_line":"      \u003cth class\u003d\"rsp-p2\" st-sort\u003d\"disk_format\" translate\u003eFormat\u003c/th\u003e"},{"line_number":45,"context_line":"      \u003cth class\u003d\"rsp-p2\" st-sort\u003d\"size\" translate\u003eSize\u003c/th\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"9a68dd71_67667cbc","line":42,"range":{"start_line":42,"start_character":34,"end_line":42,"end_character":44},"in_reply_to":"9a68dd71_5d19d220","updated":"2016-01-25 22:52:12.000000000","message":"I\u0027ve now changed this to add and normalize the visibility property on images as they load from the server. I had a discussion with a glance core and he let me know that although they are talking about the additional statuses [0], it hasn\u0027t landed in glance yet.\n\n[0] https://wiki.openstack.org/wiki/Glance-v2-community-image-visibility-design","commit_id":"c892b5e776469f2ea6dea93837fbdc750ba00b48"}]}
