)]}'
{"openstack_dashboard/static/app/core/openstack-service-api/neutron.service.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"3f425dadcbc18d6f6e9893d7bfa0925938025c90","unresolved":false,"context_lines":[{"line_number":220,"context_line":"     * The listing result is an object with property \"items\". Each item is"},{"line_number":221,"context_line":"     * a port."},{"line_number":222,"context_line":"     *"},{"line_number":223,"context_line":"     * @param {string} params.other"},{"line_number":224,"context_line":"     * Any additional request parameters will be passed through the API as"},{"line_number":225,"context_line":"     * filters. For example \"status\" : \"ACTIVE\" would filter on the status."},{"line_number":226,"context_line":"     */"}],"source_content_type":"text/javascript","patch_set":1,"id":"9a68dd71_851e030a","line":223,"updated":"2016-01-26 03:09:33.000000000","message":"A list of what those params are would be helpful, does not have to cover everything, just the important ones. This is more consistent with what we currently have.","commit_id":"0c59b21c4b6c48e07695f7ceb623dde382e3f7c5"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"a3254b3ac8cebd5a07a41dfad681da9b79eb0fea","unresolved":false,"context_lines":[{"line_number":220,"context_line":"     * The listing result is an object with property \"items\". Each item is"},{"line_number":221,"context_line":"     * a port."},{"line_number":222,"context_line":"     *"},{"line_number":223,"context_line":"     * @param {string} params.other"},{"line_number":224,"context_line":"     * Any additional request parameters will be passed through the API as"},{"line_number":225,"context_line":"     * filters. For example \"status\" : \"ACTIVE\" would filter on the status."},{"line_number":226,"context_line":"     */"}],"source_content_type":"text/javascript","patch_set":1,"id":"9a68dd71_5c4a1929","line":223,"in_reply_to":"9a68dd71_41731616","updated":"2016-01-26 09:38:21.000000000","message":"I documented all optional parameters, it doesnt look that bad :)","commit_id":"0c59b21c4b6c48e07695f7ceb623dde382e3f7c5"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"e71b9a116ac5fef8fcc9fd494ed0c18db16c949c","unresolved":false,"context_lines":[{"line_number":220,"context_line":"     * The listing result is an object with property \"items\". Each item is"},{"line_number":221,"context_line":"     * a port."},{"line_number":222,"context_line":"     *"},{"line_number":223,"context_line":"     * @param {string} params.other"},{"line_number":224,"context_line":"     * Any additional request parameters will be passed through the API as"},{"line_number":225,"context_line":"     * filters. For example \"status\" : \"ACTIVE\" would filter on the status."},{"line_number":226,"context_line":"     */"}],"source_content_type":"text/javascript","patch_set":1,"id":"9a68dd71_41731616","line":223,"in_reply_to":"9a68dd71_851e030a","updated":"2016-01-26 09:32:12.000000000","message":"Unfortunately, which ones are important? \nThem being optional means that there is not any parameter more important that any other. I could write them all but...they are 10 in total. Not sure if that would be ok?","commit_id":"0c59b21c4b6c48e07695f7ceb623dde382e3f7c5"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"3f425dadcbc18d6f6e9893d7bfa0925938025c90","unresolved":false,"context_lines":[{"line_number":225,"context_line":"     * filters. For example \"status\" : \"ACTIVE\" would filter on the status."},{"line_number":226,"context_line":"     */"},{"line_number":227,"context_line":"    function getPorts(params) {"},{"line_number":228,"context_line":"      var config \u003d (params) ? { \u0027params\u0027 : params} : {};"},{"line_number":229,"context_line":"      return apiService.get(\u0027/api/neutron/ports/\u0027, config)"},{"line_number":230,"context_line":"        .error(function () {"},{"line_number":231,"context_line":"          toastService.add(\u0027error\u0027, gettext(\u0027Unable to retrieve the ports.\u0027));"}],"source_content_type":"text/javascript","patch_set":1,"id":"9a68dd71_45148be7","line":228,"updated":"2016-01-26 03:09:33.000000000","message":"{ \u0027params\u0027: params } could just be { params: params } without the string since JSON.stringify will handle it for us.","commit_id":"0c59b21c4b6c48e07695f7ceb623dde382e3f7c5"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"e71b9a116ac5fef8fcc9fd494ed0c18db16c949c","unresolved":false,"context_lines":[{"line_number":225,"context_line":"     * filters. For example \"status\" : \"ACTIVE\" would filter on the status."},{"line_number":226,"context_line":"     */"},{"line_number":227,"context_line":"    function getPorts(params) {"},{"line_number":228,"context_line":"      var config \u003d (params) ? { \u0027params\u0027 : params} : {};"},{"line_number":229,"context_line":"      return apiService.get(\u0027/api/neutron/ports/\u0027, config)"},{"line_number":230,"context_line":"        .error(function () {"},{"line_number":231,"context_line":"          toastService.add(\u0027error\u0027, gettext(\u0027Unable to retrieve the ports.\u0027));"}],"source_content_type":"text/javascript","patch_set":1,"id":"9a68dd71_a10a1278","line":228,"in_reply_to":"9a68dd71_45148be7","updated":"2016-01-26 09:32:12.000000000","message":"This is how the rest of the other services write it, so Im not changing it to be consistent with the rest of the js service files.","commit_id":"0c59b21c4b6c48e07695f7ceb623dde382e3f7c5"}]}