)]}'
{"openstack_dashboard/test/integration_tests/tests/test_images.py":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"89eef0af2d7d57f0edffa92c9e67bf14e6a3ae8d","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        images_page.images_table.filter(\u0027\u0027)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def test_images_pagination_with_filter(self):"},{"line_number":198,"context_line":"        \"\"\"This test checks filtering of images in case of filter using"},{"line_number":199,"context_line":"            Steps:"},{"line_number":200,"context_line":"            1) Login to Horizon dashboard as admin user"},{"line_number":201,"context_line":"            2) Go to Admin -\u003e System -\u003e Images"}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_adb0b4f5","line":198,"updated":"2016-03-02 02:20:23.000000000","message":"Suggested: \"This test checks filtering of images with pagination.\"","commit_id":"d53fdf882895d2db59a426abe91c65a274b8716e"},{"author":{"_account_id":19333,"name":"Alexandra Allakhverdieva","email":"aallakhverdieva@mirantis.com","username":"AlexandraAllakhverdieva"},"change_message_id":"0feee4c9f741baba4f13c52e20337c27027a5179","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        images_page.images_table.filter(\u0027\u0027)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def test_images_pagination_with_filter(self):"},{"line_number":198,"context_line":"        \"\"\"This test checks filtering of images in case of filter using"},{"line_number":199,"context_line":"            Steps:"},{"line_number":200,"context_line":"            1) Login to Horizon dashboard as admin user"},{"line_number":201,"context_line":"            2) Go to Admin -\u003e System -\u003e Images"}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_6efa06bf","line":198,"in_reply_to":"7af24918_adb0b4f5","updated":"2016-03-02 13:23:46.000000000","message":"Done","commit_id":"d53fdf882895d2db59a426abe91c65a274b8716e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"89eef0af2d7d57f0edffa92c9e67bf14e6a3ae8d","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            3) Create 3 images with the same name"},{"line_number":203,"context_line":"            4) Set this name as value of filer by image name"},{"line_number":204,"context_line":"            5) Check that table is expected one: no \u0027Next\u0027/\u0027Prev\u0027 links,"},{"line_number":205,"context_line":"            count of rows is 3, list of images names is expected also"},{"line_number":206,"context_line":"            6) Go to the user settings and change \u0027Items per page\u0027 to 2"},{"line_number":207,"context_line":"            7) Go to Admin -\u003e System -\u003e Images"},{"line_number":208,"context_line":"            8) Check 1st table page: no \u0027Prev\u0027 link, \u0027Next\u0027 is available,"}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_8d8fb822","line":205,"updated":"2016-03-02 02:20:23.000000000","message":"We\u0027re not checking the *unfiltered* image count prior to this, so there\u0027s no guarantee the filtering is actually working (yes, I know this is checked in the test above, but this checks in combination with pagination). We should check that there are other images, and that an unfiltered count is higher than 3.","commit_id":"d53fdf882895d2db59a426abe91c65a274b8716e"},{"author":{"_account_id":19333,"name":"Alexandra Allakhverdieva","email":"aallakhverdieva@mirantis.com","username":"AlexandraAllakhverdieva"},"change_message_id":"0feee4c9f741baba4f13c52e20337c27027a5179","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            3) Create 3 images with the same name"},{"line_number":203,"context_line":"            4) Set this name as value of filer by image name"},{"line_number":204,"context_line":"            5) Check that table is expected one: no \u0027Next\u0027/\u0027Prev\u0027 links,"},{"line_number":205,"context_line":"            count of rows is 3, list of images names is expected also"},{"line_number":206,"context_line":"            6) Go to the user settings and change \u0027Items per page\u0027 to 2"},{"line_number":207,"context_line":"            7) Go to Admin -\u003e System -\u003e Images"},{"line_number":208,"context_line":"            8) Check 1st table page: no \u0027Prev\u0027 link, \u0027Next\u0027 is available,"}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_ce2fda3c","line":205,"in_reply_to":"7af24918_8d8fb822","updated":"2016-03-02 13:23:46.000000000","message":"Done\nI\u0027ve added additional assert for images count before filtering. There is no need to create 4th image within this test since default images are already in list \u003d\u003e unfiltered count of images higher than 3.","commit_id":"d53fdf882895d2db59a426abe91c65a274b8716e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"89eef0af2d7d57f0edffa92c9e67bf14e6a3ae8d","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        images_count \u003d 3"},{"line_number":217,"context_line":"        image_name \u003d \"test_image_pagination_with_filter\""},{"line_number":218,"context_line":"        images_names \u003d []"},{"line_number":219,"context_line":"        for i in xrange(images_count):"},{"line_number":220,"context_line":"            images_page.create_image(image_name)"},{"line_number":221,"context_line":"            images_page.find_message_and_dismiss(messages.SUCCESS)"},{"line_number":222,"context_line":"            self.assertTrue(images_page.is_image_present(image_name))"}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_6dbfccd0","line":219,"updated":"2016-03-02 02:20:23.000000000","message":"Use of range here is unnecessary. Plain ol\u0027 range() will do.","commit_id":"d53fdf882895d2db59a426abe91c65a274b8716e"},{"author":{"_account_id":19333,"name":"Alexandra Allakhverdieva","email":"aallakhverdieva@mirantis.com","username":"AlexandraAllakhverdieva"},"change_message_id":"0feee4c9f741baba4f13c52e20337c27027a5179","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        images_count \u003d 3"},{"line_number":217,"context_line":"        image_name \u003d \"test_image_pagination_with_filter\""},{"line_number":218,"context_line":"        images_names \u003d []"},{"line_number":219,"context_line":"        for i in xrange(images_count):"},{"line_number":220,"context_line":"            images_page.create_image(image_name)"},{"line_number":221,"context_line":"            images_page.find_message_and_dismiss(messages.SUCCESS)"},{"line_number":222,"context_line":"            self.assertTrue(images_page.is_image_present(image_name))"}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_2e10fe00","line":219,"in_reply_to":"7af24918_6dbfccd0","updated":"2016-03-02 13:23:46.000000000","message":"Done","commit_id":"d53fdf882895d2db59a426abe91c65a274b8716e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"e9d50b3c55962f317c22c5684ce14cf048574b43","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        image_name \u003d \"test_image_pagination_with_filter\""},{"line_number":244,"context_line":"        images_names \u003d []"},{"line_number":245,"context_line":"        for i in range(images_count):"},{"line_number":246,"context_line":"            images_page.create_image(image_name)"},{"line_number":247,"context_line":"            images_page.find_message_and_dismiss(messages.SUCCESS)"},{"line_number":248,"context_line":"            self.assertTrue(images_page.is_image_present(image_name))"},{"line_number":249,"context_line":"            images_names.append(image_name)"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba0121b8_7ff44af1","line":246,"updated":"2016-03-30 14:35:24.000000000","message":"So, you\u0027re creating all images with the name here. I suppose that was hardly the actual purpose of the test :).","commit_id":"4a006eb34271fd635cd0187e597278c399166912"},{"author":{"_account_id":19333,"name":"Alexandra Allakhverdieva","email":"aallakhverdieva@mirantis.com","username":"AlexandraAllakhverdieva"},"change_message_id":"ca6ef3e49bf78031d073584ae2671e1e64513832","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        image_name \u003d \"test_image_pagination_with_filter\""},{"line_number":244,"context_line":"        images_names \u003d []"},{"line_number":245,"context_line":"        for i in range(images_count):"},{"line_number":246,"context_line":"            images_page.create_image(image_name)"},{"line_number":247,"context_line":"            images_page.find_message_and_dismiss(messages.SUCCESS)"},{"line_number":248,"context_line":"            self.assertTrue(images_page.is_image_present(image_name))"},{"line_number":249,"context_line":"            images_names.append(image_name)"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba0121b8_dc711d46","line":246,"in_reply_to":"ba0121b8_1c06f51c","updated":"2016-03-30 16:00:47.000000000","message":"Agree with this solution. I\u0027ll remove it in the next patch set","commit_id":"4a006eb34271fd635cd0187e597278c399166912"},{"author":{"_account_id":19333,"name":"Alexandra Allakhverdieva","email":"aallakhverdieva@mirantis.com","username":"AlexandraAllakhverdieva"},"change_message_id":"8850fbca83d0ef6bf03a66120d514522dacf20a2","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        image_name \u003d \"test_image_pagination_with_filter\""},{"line_number":244,"context_line":"        images_names \u003d []"},{"line_number":245,"context_line":"        for i in range(images_count):"},{"line_number":246,"context_line":"            images_page.create_image(image_name)"},{"line_number":247,"context_line":"            images_page.find_message_and_dismiss(messages.SUCCESS)"},{"line_number":248,"context_line":"            self.assertTrue(images_page.is_image_present(image_name))"},{"line_number":249,"context_line":"            images_names.append(image_name)"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba0121b8_eb2d3da9","line":246,"in_reply_to":"ba0121b8_7ff44af1","updated":"2016-03-30 15:29:47.000000000","message":"Actually filter for images looking for full image name (for comparison for instance we can use \u0027inst\u0027 to filter out \u0027inst\u0027, \u0027instance1\u0027, etc).\nSo in case of creation all images with the same name I can check case when more than 1 image is in filtered table \u003d\u003e I can check pagination with filter.\nOtherwise (all images have different names) is almost identical to \u0027test_filter_images\u0027. One difference only: \u0027test_filter_images\u0027 doesn\u0027t contains assert_definition(no Prev, no Next, etc)\n\nWhat\u0027s your view of scenario for this test?)","commit_id":"4a006eb34271fd635cd0187e597278c399166912"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"162cd1f88f26e5098ab1fac60ef82554274923b1","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        image_name \u003d \"test_image_pagination_with_filter\""},{"line_number":244,"context_line":"        images_names \u003d []"},{"line_number":245,"context_line":"        for i in range(images_count):"},{"line_number":246,"context_line":"            images_page.create_image(image_name)"},{"line_number":247,"context_line":"            images_page.find_message_and_dismiss(messages.SUCCESS)"},{"line_number":248,"context_line":"            self.assertTrue(images_page.is_image_present(image_name))"},{"line_number":249,"context_line":"            images_names.append(image_name)"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba0121b8_1c06f51c","line":246,"in_reply_to":"ba0121b8_eb2d3da9","updated":"2016-03-30 15:53:44.000000000","message":"Oh, didn\u0027t know that partial filtering doesn\u0027t work for Glance (or forgot it). Folks from horizon chat pointed me to https://review.openstack.org/#/c/269992/ and https://review.openstack.org/#/c/98119/ although I\u0027m not sure we should bother reviving this work.\n\nWhat if just removed this test completely then? Because I don\u0027t see this feature as really useful and worth of testing (and spending any time on it).","commit_id":"4a006eb34271fd635cd0187e597278c399166912"}]}
