)]}'
{"openstack_dashboard/dashboards/project/instances/workflows/create_instance.py":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"d97a2e72d449202415af81ba3abb0412394273a1","unresolved":false,"context_lines":[{"line_number":803,"context_line":"class SetNetworkPorts(workflows.Step):"},{"line_number":804,"context_line":"    action_class \u003d SetNetworkPortsAction"},{"line_number":805,"context_line":"    contributes \u003d (\"ports\",)"},{"line_number":806,"context_line":""},{"line_number":807,"context_line":"    def contribute(self, data, context):"},{"line_number":808,"context_line":"        if data:"},{"line_number":809,"context_line":"            ports \u003d self.workflow.request.POST.getlist(\"ports\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_52e1dd2b","line":806,"updated":"2016-01-25 09:15:23.000000000","message":"Unfortunately, this shows up, even if there are no ports available; I would like to see the tab removed, when there\u0027s nothing to see.\n\nThat might even address davids comment from the other ports patch (looking if the plugin is enabled in neutron)","commit_id":"eb0903df32f8dfb38e35cf5e47c5807026a932e4"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"b818cd99fcb844c9d08b5ec356c3b92795f57066","unresolved":false,"context_lines":[{"line_number":803,"context_line":"class SetNetworkPorts(workflows.Step):"},{"line_number":804,"context_line":"    action_class \u003d SetNetworkPortsAction"},{"line_number":805,"context_line":"    contributes \u003d (\"ports\",)"},{"line_number":806,"context_line":""},{"line_number":807,"context_line":"    def contribute(self, data, context):"},{"line_number":808,"context_line":"        if data:"},{"line_number":809,"context_line":"            ports \u003d self.workflow.request.POST.getlist(\"ports\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_12db651c","line":806,"in_reply_to":"9a68dd71_52e1dd2b","updated":"2016-01-25 09:24:34.000000000","message":"Im not a fan of automatic changes in the UX that may confuse the end user.\n\nThat is why if neutron is enabled but there are no ports, I display a info message instead of showing just an empty port list.\n\nRemoving the tab altogether is IMHO a bad UX move as the end user may expect to find it there and not finding it can lead to confusion, while having it there with a message saying \"No ports available\" sends a clear message to what the user needs to do if he wants to use ports to launch.","commit_id":"eb0903df32f8dfb38e35cf5e47c5807026a932e4"}]}