)]}'
{"openstack_dashboard/test/integration_tests/helpers.py":[{"author":{"_account_id":20772,"name":"Sergei Chipiga","email":"schipiga@mirantis.com","username":"schipiga"},"change_message_id":"711ce336c1c55f5b48a1bdf6ecd89bfa34492df7","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        html_elem \u003d self.driver.find_element_by_tag_name(\"html\")"},{"line_number":174,"context_line":"        return html_elem.get_attribute(\"innerHTML\").encode(\"UTF-8\")"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def assertSequenceTrue(self, actual):"},{"line_number":177,"context_line":"        return self.assertEqual(list(actual), [True] * len(actual))"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def assertSequenceFalse(self, actual):"},{"line_number":180,"context_line":"        return self.assertEqual(list(actual), [False] * len(actual))"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def tearDown(self):"},{"line_number":183,"context_line":"        if os.environ.get(\u0027INTEGRATION_TESTS\u0027, False):"}],"source_content_type":"text/x-python","patch_set":28,"id":"fa0719c6_d1a583a2","line":180,"range":{"start_line":176,"start_character":0,"end_line":180,"end_character":68},"updated":"2016-03-23 09:10:30.000000000","message":"That works and looks not bad. But I would prefer better implementation from the architectural point of view. And I believe you will be agree with me.\nSee, `assertSequenceTrue` and `assertSequenceFalse` can be useful not only for integration tests but for unittests too. But you implement it for integration tests only. That\u0027s why it will be cool to code `assertSequenceTrue` and `assertSequenceFalse` inside `horizon.test.helpers` - it\u0027s higher abstraction level. But integration tests are inherited from `testtools.TestCase` (see `openstack_dashboard.test.integration_tests.helpers.BaseTestCase`), but unittests are inherited from `django.test.TestCase` (see `horizon.test.helpers.TestCase`). So integration tests and unittests don\u0027t have common ancestor, inside which we can implement `assertSequenceTrue` and `assertSequenceFalse`. So it\u0027s better to use mixin. You should implement `class AssertsMixin` inside `horizon.test.helpers`:\n\n    class AssertsMixin(object):\n\n        def assertSequenceTrue(self, actual):\n            return self.assertSequenceEqual(actual, [True] * len(actual))\n\n        def assertSequenceFalse(self, actual):\n            return self.assertSequenceEqual(actual, [False] * len(actual))\n\nand mix it, where you need (in this case mix with `openstack_dashboard.test.integration_tests.helpers.BaseTestCase`):\n\n    from horizon.test.helpers import AssertsMixin\n\n    class BaseTestCase(testtools.TestCase, AssertsMixin):\n\n\n\nP.S.\n! Please note, that I use self.assertSequenceEqual during implementation. It\u0027s because django.test.TestCase and testtools.TestCase have this assert method:\n\n    In [9]: import testtools\n\n    In [10]: import django.test\n\n    In [11]: filter(lambda method_name: method_name \u003d\u003d \u0027assertSequenceEqual\u0027, dir(testtools.TestCase))\n    Out[11]: [\u0027assertSequenceEqual\u0027]\n\n    In [12]: filter(lambda method_name: method_name \u003d\u003d \u0027assertSequenceEqual\u0027, dir(django.test.TestCase))\n    Out[12]: [\u0027assertSequenceEqual\u0027]\n\nThey have `assertSequenceEqual` because they are based on `unittest.TestCase`, which has such method:\n\n    In [15]: testtools.TestCase.__mro__\n    Out[15]: \n    (testtools.testcase.TestCase,\n     unittest2.case.TestCase,\n     unittest.case.TestCase,\n     object)\n\n    In [16]: django.test.TestCase.__mro__\n    Out[16]: \n    (django.test.testcases.TestCase,\n     django.test.testcases.TransactionTestCase,\n     django.test.testcases.SimpleTestCase,\n     unittest.case.TestCase,\n     object)\n\n    In [17]: import unittest\n\n    In [18]: filter(lambda method_name: method_name \u003d\u003d \u0027assertSequenceEqual\u0027, dir(unittest.TestCase))\n    Out[18]: [\u0027assertSequenceEqual\u0027]\n\nAnd `assertSequenceEqual` implementation:\n\n    In [22]: import inspect\n\n    In [23]: print inspect.getsource(unittest.TestCase.assertSequenceEqual)\n        def assertSequenceEqual(self, seq1, seq2, msg\u003dNone, seq_type\u003dNone):\n            \"\"\"An equality assertion for ordered sequences (like lists and tuples).\n\n            For the purposes of this function, a valid ordered sequence type is one\n            which can be indexed, has a length, and has an equality operator.\n\n            Args:\n                seq1: The first sequence to compare.\n                seq2: The second sequence to compare.\n                seq_type: The expected datatype of the sequences, or None if no\n                        datatype should be enforced.\n                msg: Optional message to use on failure instead of a list of\n                        differences.\n            \"\"\"\n            if seq_type is not None:\n                seq_type_name \u003d seq_type.__name__\n                if not isinstance(seq1, seq_type):\n                    raise self.failureException(\u0027First sequence is not a %s: %s\u0027\n                                            % (seq_type_name, safe_repr(seq1)))\n                if not isinstance(seq2, seq_type):\n                    raise self.failureException(\u0027Second sequence is not a %s: %s\u0027\n                                            % (seq_type_name, safe_repr(seq2)))\n            else:\n                seq_type_name \u003d \"sequence\"\n\n            differing \u003d None\n            try:\n                len1 \u003d len(seq1)\n            except (TypeError, NotImplementedError):\n                differing \u003d \u0027First %s has no length.    Non-sequence?\u0027 % (\n                        seq_type_name)\n\n            if differing is None:\n                try:\n                    len2 \u003d len(seq2)\n                except (TypeError, NotImplementedError):\n                    differing \u003d \u0027Second %s has no length.    Non-sequence?\u0027 % (\n                            seq_type_name)\n\n            if differing is None:\n                if seq1 \u003d\u003d seq2:\n                    return\n\n                seq1_repr \u003d safe_repr(seq1)\n                seq2_repr \u003d safe_repr(seq2)\n                if len(seq1_repr) \u003e 30:\n                    seq1_repr \u003d seq1_repr[:30] + \u0027...\u0027\n                if len(seq2_repr) \u003e 30:\n                    seq2_repr \u003d seq2_repr[:30] + \u0027...\u0027\n                elements \u003d (seq_type_name.capitalize(), seq1_repr, seq2_repr)\n                differing \u003d \u0027%ss differ: %s !\u003d %s\\n\u0027 % elements\n\n                for i in xrange(min(len1, len2)):\n                    try:\n                        item1 \u003d seq1[i]\n                    except (TypeError, IndexError, NotImplementedError):\n                        differing +\u003d (\u0027\\nUnable to index element %d of first %s\\n\u0027 %\n                                     (i, seq_type_name))\n                        break\n\n                    try:\n                        item2 \u003d seq2[i]\n                    except (TypeError, IndexError, NotImplementedError):\n                        differing +\u003d (\u0027\\nUnable to index element %d of second %s\\n\u0027 %\n                                     (i, seq_type_name))\n                        break\n\n                    if item1 !\u003d item2:\n                        differing +\u003d (\u0027\\nFirst differing element %d:\\n%s\\n%s\\n\u0027 %\n                                     (i, item1, item2))\n                        break\n                else:\n                    if (len1 \u003d\u003d len2 and seq_type is None and\n                        type(seq1) !\u003d type(seq2)):\n                        # The sequences are the same, but have differing types.\n                        return\n\n                if len1 \u003e len2:\n                    differing +\u003d (\u0027\\nFirst %s contains %d additional \u0027\n                                 \u0027elements.\\n\u0027 % (seq_type_name, len1 - len2))\n                    try:\n                        differing +\u003d (\u0027First extra element %d:\\n%s\\n\u0027 %\n                                      (len2, seq1[len2]))\n                    except (TypeError, IndexError, NotImplementedError):\n                        differing +\u003d (\u0027Unable to index element %d \u0027\n                                      \u0027of first %s\\n\u0027 % (len2, seq_type_name))\n                elif len1 \u003c len2:\n                    differing +\u003d (\u0027\\nSecond %s contains %d additional \u0027\n                                 \u0027elements.\\n\u0027 % (seq_type_name, len2 - len1))\n                    try:\n                        differing +\u003d (\u0027First extra element %d:\\n%s\\n\u0027 %\n                                      (len1, seq2[len1]))\n                    except (TypeError, IndexError, NotImplementedError):\n                        differing +\u003d (\u0027Unable to index element %d \u0027\n                                      \u0027of second %s\\n\u0027 % (len1, seq_type_name))\n            standardMsg \u003d differing\n            diffMsg \u003d \u0027\\n\u0027 + \u0027\\n\u0027.join(\n                difflib.ndiff(pprint.pformat(seq1).splitlines(),\n                              pprint.pformat(seq2).splitlines()))\n            standardMsg \u003d self._truncateMessage(standardMsg, diffMsg)\n            msg \u003d self._formatMessage(msg, standardMsg)\n            self.fail(msg)","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"679d5e48cf49a95a9d2e9f3b366089fd7b706865","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        html_elem \u003d self.driver.find_element_by_tag_name(\"html\")"},{"line_number":174,"context_line":"        return html_elem.get_attribute(\"innerHTML\").encode(\"UTF-8\")"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def assertSequenceTrue(self, actual):"},{"line_number":177,"context_line":"        return self.assertEqual(list(actual), [True] * len(actual))"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def assertSequenceFalse(self, actual):"},{"line_number":180,"context_line":"        return self.assertEqual(list(actual), [False] * len(actual))"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def tearDown(self):"},{"line_number":183,"context_line":"        if os.environ.get(\u0027INTEGRATION_TESTS\u0027, False):"}],"source_content_type":"text/x-python","patch_set":28,"id":"da0c15f0_7c062ccf","line":180,"range":{"start_line":176,"start_character":0,"end_line":180,"end_character":68},"in_reply_to":"fa0719c6_d1a583a2","updated":"2016-03-28 13:31:02.000000000","message":"Fixed","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"}],"openstack_dashboard/test/integration_tests/pages/project/compute/imagespage.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2ad0280d9f55a9c23535bc5ec7f573cc4c9a973b","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        return forms.MetadataFormRegion(self.driver, self.conf)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @tables.bind_row_anchor_column()"},{"line_number":79,"context_line":"    def go_to_image_description_page(self, row_link, row):"},{"line_number":80,"context_line":"        row_link.click()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"7af24918_3b37f0e4","line":79,"updated":"2016-03-01 13:50:30.000000000","message":"nitpicking: cell_link is a more proper name here (\u003e1 link could exist in a row).","commit_id":"6fc38711cd0034ea62cd05c0c1e25ec660c5c4ba"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"fa2c675a75923df6e3be07f1da5fc459daedd1db","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        return forms.MetadataFormRegion(self.driver, self.conf)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @tables.bind_row_anchor_column()"},{"line_number":79,"context_line":"    def go_to_image_description_page(self, row_link, row):"},{"line_number":80,"context_line":"        row_link.click()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"3afc51ec_1faca7ec","line":79,"in_reply_to":"7af24918_3b37f0e4","updated":"2016-03-11 11:01:59.000000000","message":"Will apply this one and below comments in next patchset.","commit_id":"6fc38711cd0034ea62cd05c0c1e25ec660c5c4ba"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2ad0280d9f55a9c23535bc5ec7f573cc4c9a973b","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @tables.bind_row_anchor_column()"},{"line_number":79,"context_line":"    def go_to_image_description_page(self, row_link, row):"},{"line_number":80,"context_line":"        row_link.click()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"class ImagesPage(basepage.BaseNavigationPage):"}],"source_content_type":"text/x-python","patch_set":23,"id":"7af24918_b9fca83f","line":80,"updated":"2016-03-01 13:50:30.000000000","message":"Since we\u0027re going to new page after this button is clicked, it\u0027d be fitting to return the new page object here.","commit_id":"6fc38711cd0034ea62cd05c0c1e25ec660c5c4ba"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2ad0280d9f55a9c23535bc5ec7f573cc4c9a973b","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        row \u003d self._get_row_with_image_name(name)"},{"line_number":140,"context_line":"        update_metadata_form \u003d self.images_table.update_metadata(row)"},{"line_number":141,"context_line":"        for field_name, value in metadata.iteritems():"},{"line_number":142,"context_line":"            update_metadata_form.custom_filed_value.send_keys(field_name)"},{"line_number":143,"context_line":"            update_metadata_form.custom_filed_add_button.click()"},{"line_number":144,"context_line":"            update_metadata_form.update_input_fields()"},{"line_number":145,"context_line":"            field \u003d getattr(update_metadata_form, field_name)"}],"source_content_type":"text/x-python","patch_set":23,"id":"7af24918_59512462","line":142,"updated":"2016-03-01 13:50:30.000000000","message":"Could this pretty low-level stuff be hidden into MetadataFormRegion?","commit_id":"6fc38711cd0034ea62cd05c0c1e25ec660c5c4ba"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2ad0280d9f55a9c23535bc5ec7f573cc4c9a973b","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        row \u003d self._get_row_with_image_name(name)"},{"line_number":152,"context_line":"        self.images_table.go_to_image_description_page(row)"},{"line_number":153,"context_line":"        # On the opened page just check all text regions"},{"line_number":154,"context_line":"        elems \u003d self.driver.find_elements_by_class_name(\u0027dl-horizontal\u0027)"},{"line_number":155,"context_line":"        for elem in elems:"},{"line_number":156,"context_line":"            if field_name in elem.text and value in elem.text:"},{"line_number":157,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":23,"id":"7af24918_595be454","line":154,"updated":"2016-03-01 13:50:30.000000000","message":"Instead of mixing low-level selectors into page code, it\u0027d be better to have in a new page object (see above) methods for retrieval properties (perhaps, dictionary of properties?).","commit_id":"6fc38711cd0034ea62cd05c0c1e25ec660c5c4ba"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"a859f32a00b363c75d0de44a46a961281b0ae086","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    def check_image_details(self, name, field_name, value):"},{"line_number":143,"context_line":"        row \u003d self._get_row_with_image_name(name)"},{"line_number":144,"context_line":"        description \u003d self.images_table.go_to_image_description_page(row)"},{"line_number":145,"context_line":"        for elem in description.get_content():"},{"line_number":146,"context_line":"            if field_name in elem.text and value in elem.text:"},{"line_number":147,"context_line":"                return True"},{"line_number":148,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":25,"id":"3afc51ec_1ea2a2ae","line":145,"updated":"2016-03-14 08:53:45.000000000","message":"It is not trivial to get info from page in dictionaries. \u0027\u003cdl-horizontal\u003e\u0027 sections contain \u003cdt\u003e which can be used as key and \u003cdd\u003e node with data. But \u003cdd\u003e node is not nested from \u003cdt\u003e, so there are will be problems with parsing.","commit_id":"5a5eaef62197a566e5400d8f64d8b697c2067453"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"50d0f352363c8890b8fff69534b50b84bd65e023","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    def check_image_details(self, name, field_name, value):"},{"line_number":143,"context_line":"        row \u003d self._get_row_with_image_name(name)"},{"line_number":144,"context_line":"        description \u003d self.images_table.go_to_image_description_page(row)"},{"line_number":145,"context_line":"        for elem in description.get_content():"},{"line_number":146,"context_line":"            if field_name in elem.text and value in elem.text:"},{"line_number":147,"context_line":"                return True"},{"line_number":148,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":25,"id":"fa0719c6_d8f8ffc5","line":145,"in_reply_to":"3afc51ec_1ea2a2ae","updated":"2016-03-23 11:14:01.000000000","message":"Sure, it\u0027s not trivial. Still you could return list of dictionaries.","commit_id":"5a5eaef62197a566e5400d8f64d8b697c2067453"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"1556024f806a21b79e55e599b8bc06670776aa71","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    def check_image_details(self, name, field_name, value):"},{"line_number":143,"context_line":"        row \u003d self._get_row_with_image_name(name)"},{"line_number":144,"context_line":"        description \u003d self.images_table.go_to_image_description_page(row)"},{"line_number":145,"context_line":"        for elem in description.get_content():"},{"line_number":146,"context_line":"            if field_name in elem.text and value in elem.text:"},{"line_number":147,"context_line":"                return True"},{"line_number":148,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":25,"id":"da0c15f0_9f169253","line":145,"in_reply_to":"fa0719c6_d8f8ffc5","updated":"2016-03-28 13:30:49.000000000","message":"Looks like dt and dd nodes come in pairs. Even if the dd is empty. So used the next approach: get list of dt text values and dd text values. And make dict of the two lists.","commit_id":"5a5eaef62197a566e5400d8f64d8b697c2067453"},{"author":{"_account_id":20772,"name":"Sergei Chipiga","email":"schipiga@mirantis.com","username":"schipiga"},"change_message_id":"e2d1f92fb062c5c974f98fb4e66afe713cd4a8dd","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def check_image_details(self, name, field_name, value):"},{"line_number":143,"context_line":"        row \u003d self._get_row_with_image_name(name)"},{"line_number":144,"context_line":"        description \u003d self.images_table.go_to_image_description_page(row)"},{"line_number":145,"context_line":"        for elem in description.get_content():"},{"line_number":146,"context_line":"            if field_name in elem.text and value in elem.text:"},{"line_number":147,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":26,"id":"fa0719c6_36506a5e","line":144,"updated":"2016-03-22 12:13:19.000000000","message":"I think, it\u0027s better to name `description_page`, because it\u0027s easy to confuse with description as a text field","commit_id":"0ed1d7953053f9281a8bd71d3af08e22aad5f1dc"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"d14da44fbfb78d9c7996cf81fd97aac46877c2af","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def check_image_details(self, name, field_name, value):"},{"line_number":143,"context_line":"        row \u003d self._get_row_with_image_name(name)"},{"line_number":144,"context_line":"        description \u003d self.images_table.go_to_image_description_page(row)"},{"line_number":145,"context_line":"        for elem in description.get_content():"},{"line_number":146,"context_line":"            if field_name in elem.text and value in elem.text:"},{"line_number":147,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":26,"id":"fa0719c6_993977da","line":144,"in_reply_to":"fa0719c6_36506a5e","updated":"2016-03-23 07:57:35.000000000","message":"Fixed.","commit_id":"0ed1d7953053f9281a8bd71d3af08e22aad5f1dc"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"b7907645338b10dea10e3b185b4eb050ae99aaad","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        metadata_button.click()"},{"line_number":74,"context_line":"        return forms.MetadataFormRegion(self.driver, self.conf)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @tables.bind_row_anchor_column"},{"line_number":77,"context_line":"    def go_to_image_description_page(self, row_link, row):"},{"line_number":78,"context_line":"        row_link.click()"},{"line_number":79,"context_line":"        return forms.ItemTextDescription(self.driver, self.conf)"}],"source_content_type":"text/x-python","patch_set":28,"id":"fa0719c6_bbdc2874","line":76,"updated":"2016-03-23 11:08:40.000000000","message":"it would be natural to pass column name to the decorator here (to distinguish between several anchors for a single row).","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"679d5e48cf49a95a9d2e9f3b366089fd7b706865","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        metadata_button.click()"},{"line_number":74,"context_line":"        return forms.MetadataFormRegion(self.driver, self.conf)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @tables.bind_row_anchor_column"},{"line_number":77,"context_line":"    def go_to_image_description_page(self, row_link, row):"},{"line_number":78,"context_line":"        row_link.click()"},{"line_number":79,"context_line":"        return forms.ItemTextDescription(self.driver, self.conf)"}],"source_content_type":"text/x-python","patch_set":28,"id":"da0c15f0_ac909744","line":76,"in_reply_to":"fa0719c6_bbdc2874","updated":"2016-03-28 13:31:02.000000000","message":"Fixed. However to use the column name here I moved the constants outside the class.","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"b7907645338b10dea10e3b185b4eb050ae99aaad","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        confirm_delete_images_form.submit()"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def add_custom_metadata(self, name, metadata):"},{"line_number":135,"context_line":"        self.driver.refresh()"},{"line_number":136,"context_line":"        row \u003d self._get_row_with_image_name(name)"},{"line_number":137,"context_line":"        update_metadata_form \u003d self.images_table.update_metadata(row)"},{"line_number":138,"context_line":"        for field_name, value in metadata.iteritems():"}],"source_content_type":"text/x-python","patch_set":28,"id":"fa0719c6_5b07ccc9","line":135,"updated":"2016-03-23 11:08:40.000000000","message":"This should be no longer necessary, since that behavior was fixed with https://review.openstack.org/#/c/289849/","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"679d5e48cf49a95a9d2e9f3b366089fd7b706865","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        confirm_delete_images_form.submit()"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def add_custom_metadata(self, name, metadata):"},{"line_number":135,"context_line":"        self.driver.refresh()"},{"line_number":136,"context_line":"        row \u003d self._get_row_with_image_name(name)"},{"line_number":137,"context_line":"        update_metadata_form \u003d self.images_table.update_metadata(row)"},{"line_number":138,"context_line":"        for field_name, value in metadata.iteritems():"}],"source_content_type":"text/x-python","patch_set":28,"id":"da0c15f0_eca0cf45","line":135,"in_reply_to":"fa0719c6_5b07ccc9","updated":"2016-03-28 13:31:02.000000000","message":"fixed","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"b7907645338b10dea10e3b185b4eb050ae99aaad","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    def check_image_details(self, name, field_name, value):"},{"line_number":143,"context_line":"        row \u003d self._get_row_with_image_name(name)"},{"line_number":144,"context_line":"        description_page \u003d self.images_table.go_to_image_description_page(row)"},{"line_number":145,"context_line":"        for elem in description_page.get_content():"},{"line_number":146,"context_line":"            if field_name in elem.text and value in elem.text:"},{"line_number":147,"context_line":"                return True"},{"line_number":148,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":28,"id":"fa0719c6_5b7b4cf5","line":145,"updated":"2016-03-23 11:08:40.000000000","message":"Please notice that this is not the most efficient usage of Selenium: you\u0027re invoking .get_contents() repeatedly while using one element of many being fetched at a time. Instead of this you could just return a dictionary of label: value to iterate over it in a custom matcher.","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"679d5e48cf49a95a9d2e9f3b366089fd7b706865","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    def check_image_details(self, name, field_name, value):"},{"line_number":143,"context_line":"        row \u003d self._get_row_with_image_name(name)"},{"line_number":144,"context_line":"        description_page \u003d self.images_table.go_to_image_description_page(row)"},{"line_number":145,"context_line":"        for elem in description_page.get_content():"},{"line_number":146,"context_line":"            if field_name in elem.text and value in elem.text:"},{"line_number":147,"context_line":"                return True"},{"line_number":148,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":28,"id":"da0c15f0_ffdceee5","line":145,"in_reply_to":"fa0719c6_5b7b4cf5","updated":"2016-03-28 13:31:02.000000000","message":"Fixed. See the last comment n pathset 25.","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"}],"openstack_dashboard/test/integration_tests/regions/forms.py":[{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"08efb30e620029168c4e9e0128c72a9e2cc3683d","unresolved":false,"context_lines":[{"line_number":433,"context_line":"        # Will wait till the form itself disappears"},{"line_number":434,"context_line":"        try:"},{"line_number":435,"context_line":"            self.wait_till_element_disappears(self._form_getter)"},{"line_number":436,"context_line":"        except Exception:"},{"line_number":437,"context_line":"            # The form might be absent already by the time the first check"},{"line_number":438,"context_line":"            # occurs. So just suppress the exceptions here."},{"line_number":439,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":22,"id":"9aed3d3a_a549ef8d","line":436,"updated":"2016-02-26 14:03:00.000000000","message":"Too broad except, should catch TimeoutException instead?","commit_id":"3d10e12034b9d422cdb5dcfc5de9ae782ee41d99"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"d5dedba98160a203b809da5d153fbaf46dde6e0a","unresolved":false,"context_lines":[{"line_number":433,"context_line":"        # Will wait till the form itself disappears"},{"line_number":434,"context_line":"        try:"},{"line_number":435,"context_line":"            self.wait_till_element_disappears(self._form_getter)"},{"line_number":436,"context_line":"        except Exception:"},{"line_number":437,"context_line":"            # The form might be absent already by the time the first check"},{"line_number":438,"context_line":"            # occurs. So just suppress the exceptions here."},{"line_number":439,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":22,"id":"7af24918_81adfc8a","line":436,"in_reply_to":"9aed3d3a_a549ef8d","updated":"2016-03-01 11:03:05.000000000","message":"Fixed","commit_id":"3d10e12034b9d422cdb5dcfc5de9ae782ee41d99"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2ad0280d9f55a9c23535bc5ec7f573cc4c9a973b","unresolved":false,"context_lines":[{"line_number":411,"context_line":"                       \u0027div.input-group.input-group-sm.ng-scope\u0027)"},{"line_number":412,"context_line":"    _custom_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":413,"context_line":"                       \u0027div.input-group.input-group-sm\u0027)"},{"line_number":414,"context_line":"    _submit_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":415,"context_line":"                       \u0027*.btn.btn-primary[ng-click\u003d\\\"modal.save()\\\"]\u0027)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    # private methods"}],"source_content_type":"text/x-python","patch_set":23,"id":"7af24918_fe8736d5","line":414,"updated":"2016-03-01 13:50:30.000000000","message":"I got an impression that _submit_locator inherited from BaseFormRegion also works here. Why use a customized one?","commit_id":"6fc38711cd0034ea62cd05c0c1e25ec660c5c4ba"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"fa2c675a75923df6e3be07f1da5fc459daedd1db","unresolved":false,"context_lines":[{"line_number":411,"context_line":"                       \u0027div.input-group.input-group-sm.ng-scope\u0027)"},{"line_number":412,"context_line":"    _custom_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":413,"context_line":"                       \u0027div.input-group.input-group-sm\u0027)"},{"line_number":414,"context_line":"    _submit_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":415,"context_line":"                       \u0027*.btn.btn-primary[ng-click\u003d\\\"modal.save()\\\"]\u0027)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    # private methods"}],"source_content_type":"text/x-python","patch_set":23,"id":"5aef4532_7fee82b5","line":414,"in_reply_to":"7af24918_fe8736d5","updated":"2016-03-11 11:01:59.000000000","message":"Need to distinguish between \u0027Add\u0027 buttons in existing metadata section and \u0027Save\u0027 button at the bottom of the page.","commit_id":"6fc38711cd0034ea62cd05c0c1e25ec660c5c4ba"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2ad0280d9f55a9c23535bc5ec7f573cc4c9a973b","unresolved":false,"context_lines":[{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    def __init__(self, driver, conf, field_mappings\u003dNone, src_elem\u003dNone):"},{"line_number":422,"context_line":"        super(MetadataFormRegion, self).__init__(driver, conf, src_elem)"},{"line_number":423,"context_line":"        self.wait_till_spinner_disappears()"},{"line_number":424,"context_line":"        self.fields_src \u003d self._form_getter()"},{"line_number":425,"context_line":"        custom_field \u003d self.fields_src.find_element(*self._custom_locator)"},{"line_number":426,"context_line":"        input_field \u003d custom_field.find_element_by_tag_name(\u0027input\u0027)"}],"source_content_type":"text/x-python","patch_set":23,"id":"7af24918_bb35c0f8","line":423,"updated":"2016-03-01 13:50:30.000000000","message":"I\u0027m not noticing any spinner before Metadata form appears. Do we actually need to wait for it to disappear?","commit_id":"6fc38711cd0034ea62cd05c0c1e25ec660c5c4ba"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"fa2c675a75923df6e3be07f1da5fc459daedd1db","unresolved":false,"context_lines":[{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    def __init__(self, driver, conf, field_mappings\u003dNone, src_elem\u003dNone):"},{"line_number":422,"context_line":"        super(MetadataFormRegion, self).__init__(driver, conf, src_elem)"},{"line_number":423,"context_line":"        self.wait_till_spinner_disappears()"},{"line_number":424,"context_line":"        self.fields_src \u003d self._form_getter()"},{"line_number":425,"context_line":"        custom_field \u003d self.fields_src.find_element(*self._custom_locator)"},{"line_number":426,"context_line":"        input_field \u003d custom_field.find_element_by_tag_name(\u0027input\u0027)"}],"source_content_type":"text/x-python","patch_set":23,"id":"3afc51ec_5c8d9d7a","line":423,"in_reply_to":"7af24918_bb35c0f8","updated":"2016-03-11 11:01:59.000000000","message":"Hm... probably used that for debug and forget to delete. Will check without it.","commit_id":"6fc38711cd0034ea62cd05c0c1e25ec660c5c4ba"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2ad0280d9f55a9c23535bc5ec7f573cc4c9a973b","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        self.wait_till_spinner_disappears()"},{"line_number":424,"context_line":"        self.fields_src \u003d self._form_getter()"},{"line_number":425,"context_line":"        custom_field \u003d self.fields_src.find_element(*self._custom_locator)"},{"line_number":426,"context_line":"        input_field \u003d custom_field.find_element_by_tag_name(\u0027input\u0027)"},{"line_number":427,"context_line":"        submit_btn \u003d custom_field.find_element_by_tag_name(\u0027button\u0027)"},{"line_number":428,"context_line":"        self._dynamic_properties[\u0027custom_filed_value\u0027] \u003d input_field"},{"line_number":429,"context_line":"        self._dynamic_properties[\u0027custom_filed_add_button\u0027] \u003d submit_btn"}],"source_content_type":"text/x-python","patch_set":23,"id":"7af24918_d9bed4d3","line":426,"updated":"2016-03-01 13:50:30.000000000","message":"It\u0027d be better to move the whole selector (by.By.CSS_SELECTOR, \u0027div.input-group \u003e input\u0027) to a separate locator (not mixing locators into code) and @property-ze it.\n\nAlso, as soon as you\u0027ll start working with Available and Existing metadata, you\u0027ll need to distinguish between them.","commit_id":"6fc38711cd0034ea62cd05c0c1e25ec660c5c4ba"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"fa2c675a75923df6e3be07f1da5fc459daedd1db","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        self.wait_till_spinner_disappears()"},{"line_number":424,"context_line":"        self.fields_src \u003d self._form_getter()"},{"line_number":425,"context_line":"        custom_field \u003d self.fields_src.find_element(*self._custom_locator)"},{"line_number":426,"context_line":"        input_field \u003d custom_field.find_element_by_tag_name(\u0027input\u0027)"},{"line_number":427,"context_line":"        submit_btn \u003d custom_field.find_element_by_tag_name(\u0027button\u0027)"},{"line_number":428,"context_line":"        self._dynamic_properties[\u0027custom_filed_value\u0027] \u003d input_field"},{"line_number":429,"context_line":"        self._dynamic_properties[\u0027custom_filed_add_button\u0027] \u003d submit_btn"}],"source_content_type":"text/x-python","patch_set":23,"id":"3afc51ec_bc494191","line":426,"in_reply_to":"7af24918_d9bed4d3","updated":"2016-03-11 11:01:59.000000000","message":"Will fix this one and the same in next patchset.","commit_id":"6fc38711cd0034ea62cd05c0c1e25ec660c5c4ba"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2ad0280d9f55a9c23535bc5ec7f573cc4c9a973b","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        self.fields_src \u003d self._form_getter()"},{"line_number":425,"context_line":"        custom_field \u003d self.fields_src.find_element(*self._custom_locator)"},{"line_number":426,"context_line":"        input_field \u003d custom_field.find_element_by_tag_name(\u0027input\u0027)"},{"line_number":427,"context_line":"        submit_btn \u003d custom_field.find_element_by_tag_name(\u0027button\u0027)"},{"line_number":428,"context_line":"        self._dynamic_properties[\u0027custom_filed_value\u0027] \u003d input_field"},{"line_number":429,"context_line":"        self._dynamic_properties[\u0027custom_filed_add_button\u0027] \u003d submit_btn"},{"line_number":430,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"7af24918_b9c82876","line":427,"updated":"2016-03-01 13:50:30.000000000","message":"ditto","commit_id":"6fc38711cd0034ea62cd05c0c1e25ec660c5c4ba"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2ad0280d9f55a9c23535bc5ec7f573cc4c9a973b","unresolved":false,"context_lines":[{"line_number":425,"context_line":"        custom_field \u003d self.fields_src.find_element(*self._custom_locator)"},{"line_number":426,"context_line":"        input_field \u003d custom_field.find_element_by_tag_name(\u0027input\u0027)"},{"line_number":427,"context_line":"        submit_btn \u003d custom_field.find_element_by_tag_name(\u0027button\u0027)"},{"line_number":428,"context_line":"        self._dynamic_properties[\u0027custom_filed_value\u0027] \u003d input_field"},{"line_number":429,"context_line":"        self._dynamic_properties[\u0027custom_filed_add_button\u0027] \u003d submit_btn"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    def submit(self):"}],"source_content_type":"text/x-python","patch_set":23,"id":"7af24918_7ba7b84f","line":428,"updated":"2016-03-01 13:50:30.000000000","message":"Was it \u0027filed\u0027 intentionally and not \u0027field\u0027?","commit_id":"6fc38711cd0034ea62cd05c0c1e25ec660c5c4ba"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"fa2c675a75923df6e3be07f1da5fc459daedd1db","unresolved":false,"context_lines":[{"line_number":425,"context_line":"        custom_field \u003d self.fields_src.find_element(*self._custom_locator)"},{"line_number":426,"context_line":"        input_field \u003d custom_field.find_element_by_tag_name(\u0027input\u0027)"},{"line_number":427,"context_line":"        submit_btn \u003d custom_field.find_element_by_tag_name(\u0027button\u0027)"},{"line_number":428,"context_line":"        self._dynamic_properties[\u0027custom_filed_value\u0027] \u003d input_field"},{"line_number":429,"context_line":"        self._dynamic_properties[\u0027custom_filed_add_button\u0027] \u003d submit_btn"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    def submit(self):"}],"source_content_type":"text/x-python","patch_set":23,"id":"3afc51ec_bcbb0175","line":428,"in_reply_to":"7af24918_7ba7b84f","updated":"2016-03-11 11:01:59.000000000","message":"Ups... it\u0027s mistype.","commit_id":"6fc38711cd0034ea62cd05c0c1e25ec660c5c4ba"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2ad0280d9f55a9c23535bc5ec7f573cc4c9a973b","unresolved":false,"context_lines":[{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    def submit(self):"},{"line_number":432,"context_line":"        self._submit_element.click()"},{"line_number":433,"context_line":"        # No spinner is invoked after the \u0027Save\u0027 button click"},{"line_number":434,"context_line":"        # Will wait till the form itself disappears"},{"line_number":435,"context_line":"        try:"},{"line_number":436,"context_line":"            self.wait_till_element_disappears(self._form_getter)"}],"source_content_type":"text/x-python","patch_set":23,"id":"7af24918_9948cc5d","line":433,"updated":"2016-03-01 13:50:30.000000000","message":"What if instead redefining submit() method, we redefined here wait_till_spinner_disappears() here (with all these comments)?","commit_id":"6fc38711cd0034ea62cd05c0c1e25ec660c5c4ba"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"fa2c675a75923df6e3be07f1da5fc459daedd1db","unresolved":false,"context_lines":[{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    def submit(self):"},{"line_number":432,"context_line":"        self._submit_element.click()"},{"line_number":433,"context_line":"        # No spinner is invoked after the \u0027Save\u0027 button click"},{"line_number":434,"context_line":"        # Will wait till the form itself disappears"},{"line_number":435,"context_line":"        try:"},{"line_number":436,"context_line":"            self.wait_till_element_disappears(self._form_getter)"}],"source_content_type":"text/x-python","patch_set":23,"id":"3afc51ec_9c1c4579","line":433,"in_reply_to":"7af24918_9948cc5d","updated":"2016-03-11 11:01:59.000000000","message":"will try in next patchset.","commit_id":"6fc38711cd0034ea62cd05c0c1e25ec660c5c4ba"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2ad0280d9f55a9c23535bc5ec7f573cc4c9a973b","unresolved":false,"context_lines":[{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    def update_input_fields(self):"},{"line_number":443,"context_line":"        for element in self.fields_src.find_elements(*self._inputs_locator):"},{"line_number":444,"context_line":"            field_name \u003d element.find_element_by_tag_name(\u0027span\u0027).text"},{"line_number":445,"context_line":"            input_field \u003d element.find_element_by_tag_name(\u0027input\u0027)"},{"line_number":446,"context_line":"            self._dynamic_properties[field_name] \u003d input_field"}],"source_content_type":"text/x-python","patch_set":23,"id":"7af24918_f903d074","line":444,"updated":"2016-03-01 13:50:30.000000000","message":"Same comment here about not mixing selectors into code.","commit_id":"6fc38711cd0034ea62cd05c0c1e25ec660c5c4ba"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2ad0280d9f55a9c23535bc5ec7f573cc4c9a973b","unresolved":false,"context_lines":[{"line_number":442,"context_line":"    def update_input_fields(self):"},{"line_number":443,"context_line":"        for element in self.fields_src.find_elements(*self._inputs_locator):"},{"line_number":444,"context_line":"            field_name \u003d element.find_element_by_tag_name(\u0027span\u0027).text"},{"line_number":445,"context_line":"            input_field \u003d element.find_element_by_tag_name(\u0027input\u0027)"},{"line_number":446,"context_line":"            self._dynamic_properties[field_name] \u003d input_field"}],"source_content_type":"text/x-python","patch_set":23,"id":"7af24918_19031c75","line":445,"updated":"2016-03-01 13:50:30.000000000","message":"ditto","commit_id":"6fc38711cd0034ea62cd05c0c1e25ec660c5c4ba"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"b7907645338b10dea10e3b185b4eb050ae99aaad","unresolved":false,"context_lines":[{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    _metadata_locator \u003d (by.By.CSS_SELECTOR, \u0027div.metadata-tree\u0027)"},{"line_number":427,"context_line":"    _input_fields \u003d (by.By.CSS_SELECTOR,"},{"line_number":428,"context_line":"                     \u0027div.input-group.input-group-sm.ng-scope \u003e input\u0027)"},{"line_number":429,"context_line":"    _custom_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":430,"context_line":"                       \u0027div.input-group.input-group-sm\u0027)"},{"line_number":431,"context_line":"    _custom_input_button \u003d (by.By.CSS_SELECTOR,"}],"source_content_type":"text/x-python","patch_set":28,"id":"fa0719c6_5b97cceb","line":428,"updated":"2016-03-23 11:08:40.000000000","message":"I don\u0027t think that .input-group-sm or .ng-scope are really important here, they can be omitted (same thing below).","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"679d5e48cf49a95a9d2e9f3b366089fd7b706865","unresolved":false,"context_lines":[{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    _metadata_locator \u003d (by.By.CSS_SELECTOR, \u0027div.metadata-tree\u0027)"},{"line_number":427,"context_line":"    _input_fields \u003d (by.By.CSS_SELECTOR,"},{"line_number":428,"context_line":"                     \u0027div.input-group.input-group-sm.ng-scope \u003e input\u0027)"},{"line_number":429,"context_line":"    _custom_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":430,"context_line":"                       \u0027div.input-group.input-group-sm\u0027)"},{"line_number":431,"context_line":"    _custom_input_button \u003d (by.By.CSS_SELECTOR,"}],"source_content_type":"text/x-python","patch_set":28,"id":"da0c15f0_57aa2871","line":428,"in_reply_to":"fa0719c6_5b97cceb","updated":"2016-03-28 13:31:02.000000000","message":"They can by omitted for \"custom\" locators. The problem is that custom metadata input field has the similar parent div class as the input fields for the data (that appears on the left after the custom metadata is created). So to distinguish between them at least for _input_fields the locator should be kept.","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"b7907645338b10dea10e3b185b4eb050ae99aaad","unresolved":false,"context_lines":[{"line_number":433,"context_line":"    _custom_input_field \u003d (by.By.CSS_SELECTOR,"},{"line_number":434,"context_line":"                           \u0027div.input-group.input-group-sm \u003e input\u0027)"},{"line_number":435,"context_line":"    _submit_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":436,"context_line":"                       \u0027*.btn.btn-primary[ng-click\u003d\\\"modal.save()\\\"]\u0027)"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    # private methods"},{"line_number":439,"context_line":"    def _form_getter(self):"}],"source_content_type":"text/x-python","patch_set":28,"id":"fa0719c6_bb76e8d4","line":436,"updated":"2016-03-23 11:08:40.000000000","message":"Could we simplify this thing to .btn.btn-primary? If it starts with *.some-class, it is the same as just .some-class, and relying on ng-click value might be fragile.","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"679d5e48cf49a95a9d2e9f3b366089fd7b706865","unresolved":false,"context_lines":[{"line_number":433,"context_line":"    _custom_input_field \u003d (by.By.CSS_SELECTOR,"},{"line_number":434,"context_line":"                           \u0027div.input-group.input-group-sm \u003e input\u0027)"},{"line_number":435,"context_line":"    _submit_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":436,"context_line":"                       \u0027*.btn.btn-primary[ng-click\u003d\\\"modal.save()\\\"]\u0027)"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    # private methods"},{"line_number":439,"context_line":"    def _form_getter(self):"}],"source_content_type":"text/x-python","patch_set":28,"id":"da0c15f0_1ce45039","line":436,"in_reply_to":"fa0719c6_bb76e8d4","updated":"2016-03-28 13:31:02.000000000","message":"The metadata form contains a lot of add buttons which have the same class .btn.btn-primary.btn-xs. To distingush between them and submit form button that trick was used. Changed the locator in next patchset.","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"b7907645338b10dea10e3b185b4eb050ae99aaad","unresolved":false,"context_lines":[{"line_number":435,"context_line":"    _submit_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":436,"context_line":"                       \u0027*.btn.btn-primary[ng-click\u003d\\\"modal.save()\\\"]\u0027)"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    # private methods"},{"line_number":439,"context_line":"    def _form_getter(self):"},{"line_number":440,"context_line":"        return self._get_element(*self._metadata_locator)"},{"line_number":441,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"fa0719c6_760c653b","line":438,"updated":"2016-03-23 11:08:40.000000000","message":"redundant","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"679d5e48cf49a95a9d2e9f3b366089fd7b706865","unresolved":false,"context_lines":[{"line_number":435,"context_line":"    _submit_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":436,"context_line":"                       \u0027*.btn.btn-primary[ng-click\u003d\\\"modal.save()\\\"]\u0027)"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    # private methods"},{"line_number":439,"context_line":"    def _form_getter(self):"},{"line_number":440,"context_line":"        return self._get_element(*self._metadata_locator)"},{"line_number":441,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"da0c15f0_123c3e2e","line":438,"in_reply_to":"fa0719c6_760c653b","updated":"2016-03-28 13:31:02.000000000","message":"Fixed","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"b7907645338b10dea10e3b185b4eb050ae99aaad","unresolved":false,"context_lines":[{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    def __init__(self, driver, conf, src_elem\u003dNone):"},{"line_number":443,"context_line":"        super(MetadataFormRegion, self).__init__(driver, conf, src_elem)"},{"line_number":444,"context_line":"        self.fields_src \u003d self._form_getter()"},{"line_number":445,"context_line":"        input_field \u003d self.fields_src.find_element(*self._custom_input_field)"},{"line_number":446,"context_line":"        self._dynamic_properties[\u0027custom_field_value\u0027] \u003d input_field"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"fa0719c6_76ae2599","line":444,"updated":"2016-03-23 11:08:40.000000000","message":"If you define class attribute \n  \n  _default_src_locator \u003d (by.By.CSS_SELECTOR, \u0027div.metadata-tree\u0027) \n\nyou won\u0027t need this.","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"679d5e48cf49a95a9d2e9f3b366089fd7b706865","unresolved":false,"context_lines":[{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    def __init__(self, driver, conf, src_elem\u003dNone):"},{"line_number":443,"context_line":"        super(MetadataFormRegion, self).__init__(driver, conf, src_elem)"},{"line_number":444,"context_line":"        self.fields_src \u003d self._form_getter()"},{"line_number":445,"context_line":"        input_field \u003d self.fields_src.find_element(*self._custom_input_field)"},{"line_number":446,"context_line":"        self._dynamic_properties[\u0027custom_field_value\u0027] \u003d input_field"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"da0c15f0_2903d410","line":444,"in_reply_to":"fa0719c6_76ae2599","updated":"2016-03-28 13:31:02.000000000","message":"Even better and simpler than that. The attribute _default_form_locator from BaseFormRegion do all the job :). Please see  the next pathcset.","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"679d5e48cf49a95a9d2e9f3b366089fd7b706865","unresolved":false,"context_lines":[{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    def __init__(self, driver, conf, src_elem\u003dNone):"},{"line_number":443,"context_line":"        super(MetadataFormRegion, self).__init__(driver, conf, src_elem)"},{"line_number":444,"context_line":"        self.fields_src \u003d self._form_getter()"},{"line_number":445,"context_line":"        input_field \u003d self.fields_src.find_element(*self._custom_input_field)"},{"line_number":446,"context_line":"        self._dynamic_properties[\u0027custom_field_value\u0027] \u003d input_field"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"da0c15f0_86bdaf6a","line":444,"in_reply_to":"fa0719c6_76ae2599","updated":"2016-03-28 13:31:02.000000000","message":"Fixed","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"b7907645338b10dea10e3b185b4eb050ae99aaad","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        super(MetadataFormRegion, self).__init__(driver, conf, src_elem)"},{"line_number":444,"context_line":"        self.fields_src \u003d self._form_getter()"},{"line_number":445,"context_line":"        input_field \u003d self.fields_src.find_element(*self._custom_input_field)"},{"line_number":446,"context_line":"        self._dynamic_properties[\u0027custom_field_value\u0027] \u003d input_field"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def add_custom_field(self, field_name, field_value):"},{"line_number":449,"context_line":"        self.custom_field_value.send_keys(field_name)"}],"source_content_type":"text/x-python","patch_set":28,"id":"fa0719c6_76eaa5ad","line":446,"updated":"2016-03-23 11:08:40.000000000","message":"Why not define\n\n  @property\n  def custom_field_value(self):\n    return self._get_element(*self._custom_input_field)\n\ninstead?","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"679d5e48cf49a95a9d2e9f3b366089fd7b706865","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        super(MetadataFormRegion, self).__init__(driver, conf, src_elem)"},{"line_number":444,"context_line":"        self.fields_src \u003d self._form_getter()"},{"line_number":445,"context_line":"        input_field \u003d self.fields_src.find_element(*self._custom_input_field)"},{"line_number":446,"context_line":"        self._dynamic_properties[\u0027custom_field_value\u0027] \u003d input_field"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def add_custom_field(self, field_name, field_value):"},{"line_number":449,"context_line":"        self.custom_field_value.send_keys(field_name)"}],"source_content_type":"text/x-python","patch_set":28,"id":"da0c15f0_b213d2b7","line":446,"in_reply_to":"fa0719c6_76eaa5ad","updated":"2016-03-28 13:31:02.000000000","message":"Fixed","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"b7907645338b10dea10e3b185b4eb050ae99aaad","unresolved":false,"context_lines":[{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def add_custom_field(self, field_name, field_value):"},{"line_number":449,"context_line":"        self.custom_field_value.send_keys(field_name)"},{"line_number":450,"context_line":"        add_button \u003d self.fields_src.find_element(*self._custom_input_button)"},{"line_number":451,"context_line":"        add_button.click()"},{"line_number":452,"context_line":"        for field in self.fields_src.find_elements(*self._input_fields):"},{"line_number":453,"context_line":"            if not hasattr(self, field_name):"}],"source_content_type":"text/x-python","patch_set":28,"id":"fa0719c6_f6ed15b8","line":450,"updated":"2016-03-23 11:08:40.000000000","message":"again,\n\n  @property\n  def add_button(self):\n    return self._get_element(*self._custom_input_button)","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"679d5e48cf49a95a9d2e9f3b366089fd7b706865","unresolved":false,"context_lines":[{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def add_custom_field(self, field_name, field_value):"},{"line_number":449,"context_line":"        self.custom_field_value.send_keys(field_name)"},{"line_number":450,"context_line":"        add_button \u003d self.fields_src.find_element(*self._custom_input_button)"},{"line_number":451,"context_line":"        add_button.click()"},{"line_number":452,"context_line":"        for field in self.fields_src.find_elements(*self._input_fields):"},{"line_number":453,"context_line":"            if not hasattr(self, field_name):"}],"source_content_type":"text/x-python","patch_set":28,"id":"da0c15f0_d2392643","line":450,"in_reply_to":"fa0719c6_f6ed15b8","updated":"2016-03-28 13:31:02.000000000","message":"Fixed","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"b7907645338b10dea10e3b185b4eb050ae99aaad","unresolved":false,"context_lines":[{"line_number":457,"context_line":"    def set_field_value(self, field_name, field_value):"},{"line_number":458,"context_line":"        if hasattr(self, field_name):"},{"line_number":459,"context_line":"            field \u003d getattr(self, field_name)"},{"line_number":460,"context_line":"            field.send_keys(field_value)"},{"line_number":461,"context_line":"        else:"},{"line_number":462,"context_line":"            raise AttributeError(\"Unknown form field \u0027{}\u0027.\".format(field_name))"},{"line_number":463,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"fa0719c6_966bf9f0","line":460,"updated":"2016-03-23 11:08:40.000000000","message":"That will work only if fields to be filled could be either text or numeric input. Is it true (no select boxes, etc)?","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"679d5e48cf49a95a9d2e9f3b366089fd7b706865","unresolved":false,"context_lines":[{"line_number":457,"context_line":"    def set_field_value(self, field_name, field_value):"},{"line_number":458,"context_line":"        if hasattr(self, field_name):"},{"line_number":459,"context_line":"            field \u003d getattr(self, field_name)"},{"line_number":460,"context_line":"            field.send_keys(field_value)"},{"line_number":461,"context_line":"        else:"},{"line_number":462,"context_line":"            raise AttributeError(\"Unknown form field \u0027{}\u0027.\".format(field_name))"},{"line_number":463,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"da0c15f0_d2800649","line":460,"in_reply_to":"fa0719c6_966bf9f0","updated":"2016-03-28 13:31:02.000000000","message":"Yes, only text and numeric types are allowed here. For custom metadata it is enough.","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"b7907645338b10dea10e3b185b4eb050ae99aaad","unresolved":false,"context_lines":[{"line_number":480,"context_line":"        super(ItemTextDescription, self).__init__(driver, conf, src)"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"    def get_content(self):"},{"line_number":483,"context_line":"        return self.driver.find_elements(*self._separator_locator)"}],"source_content_type":"text/x-python","patch_set":28,"id":"fa0719c6_582d0f94","line":483,"updated":"2016-03-23 11:08:40.000000000","message":"Could be rewritten as self._get_elements(*self._separator_locator).\n\nWould it make sense to return key-value dictionary here?","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"679d5e48cf49a95a9d2e9f3b366089fd7b706865","unresolved":false,"context_lines":[{"line_number":480,"context_line":"        super(ItemTextDescription, self).__init__(driver, conf, src)"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"    def get_content(self):"},{"line_number":483,"context_line":"        return self.driver.find_elements(*self._separator_locator)"}],"source_content_type":"text/x-python","patch_set":28,"id":"da0c15f0_5ac6c848","line":483,"in_reply_to":"fa0719c6_582d0f94","updated":"2016-03-28 13:31:02.000000000","message":"Fixed. See the last comment n pathset 25.","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"c90211a6a64c4dae84a58d7305e868b89b6896ee","unresolved":false,"context_lines":[{"line_number":430,"context_line":"    _custom_input_field \u003d (by.By.CSS_SELECTOR,"},{"line_number":431,"context_line":"                           \u0027div.input-group.input-group-sm \u003e input\u0027)"},{"line_number":432,"context_line":"    _submit_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":433,"context_line":"                       \u0027div.modal-footer.ng-scope \u003e button.btn.btn-primary\u0027)"},{"line_number":434,"context_line":"    _cancel_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":435,"context_line":"                       \u0027div.modal-footer.ng-scope \u003e button.btn.btn-default\u0027)"},{"line_number":436,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"da0c15f0_6e002902","line":433,"updated":"2016-03-28 15:09:07.000000000","message":"\u0027.modal-footer \u003e .btn.btn-primary\u0027 should be enough here.","commit_id":"63a57dec58b1f509b971ba2022a7e7f982f41fc8"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"4af97db6a56f6ff0a1736109b5769518dea17dc7","unresolved":false,"context_lines":[{"line_number":430,"context_line":"    _custom_input_field \u003d (by.By.CSS_SELECTOR,"},{"line_number":431,"context_line":"                           \u0027div.input-group.input-group-sm \u003e input\u0027)"},{"line_number":432,"context_line":"    _submit_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":433,"context_line":"                       \u0027div.modal-footer.ng-scope \u003e button.btn.btn-primary\u0027)"},{"line_number":434,"context_line":"    _cancel_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":435,"context_line":"                       \u0027div.modal-footer.ng-scope \u003e button.btn.btn-default\u0027)"},{"line_number":436,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"5a18252c_d4d3e75d","line":433,"in_reply_to":"da0c15f0_6e002902","updated":"2016-04-13 12:02:02.000000000","message":"Fixed.","commit_id":"63a57dec58b1f509b971ba2022a7e7f982f41fc8"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"c90211a6a64c4dae84a58d7305e868b89b6896ee","unresolved":false,"context_lines":[{"line_number":432,"context_line":"    _submit_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":433,"context_line":"                       \u0027div.modal-footer.ng-scope \u003e button.btn.btn-primary\u0027)"},{"line_number":434,"context_line":"    _cancel_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":435,"context_line":"                       \u0027div.modal-footer.ng-scope \u003e button.btn.btn-default\u0027)"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    def __init__(self, driver, conf, src_elem\u003dNone):"},{"line_number":438,"context_line":"        super(MetadataFormRegion, self).__init__(driver, conf, src_elem)"}],"source_content_type":"text/x-python","patch_set":29,"id":"da0c15f0_ce0fb52c","line":435,"updated":"2016-03-28 15:09:07.000000000","message":"ditto","commit_id":"63a57dec58b1f509b971ba2022a7e7f982f41fc8"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"4af97db6a56f6ff0a1736109b5769518dea17dc7","unresolved":false,"context_lines":[{"line_number":432,"context_line":"    _submit_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":433,"context_line":"                       \u0027div.modal-footer.ng-scope \u003e button.btn.btn-primary\u0027)"},{"line_number":434,"context_line":"    _cancel_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":435,"context_line":"                       \u0027div.modal-footer.ng-scope \u003e button.btn.btn-default\u0027)"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    def __init__(self, driver, conf, src_elem\u003dNone):"},{"line_number":438,"context_line":"        super(MetadataFormRegion, self).__init__(driver, conf, src_elem)"}],"source_content_type":"text/x-python","patch_set":29,"id":"5a18252c_54c0777c","line":435,"in_reply_to":"da0c15f0_ce0fb52c","updated":"2016-04-13 12:02:02.000000000","message":"Fixed.","commit_id":"63a57dec58b1f509b971ba2022a7e7f982f41fc8"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"c90211a6a64c4dae84a58d7305e868b89b6896ee","unresolved":false,"context_lines":[{"line_number":434,"context_line":"    _cancel_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":435,"context_line":"                       \u0027div.modal-footer.ng-scope \u003e button.btn.btn-default\u0027)"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    def __init__(self, driver, conf, src_elem\u003dNone):"},{"line_number":438,"context_line":"        super(MetadataFormRegion, self).__init__(driver, conf, src_elem)"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    def _form_getter(self):"}],"source_content_type":"text/x-python","patch_set":29,"id":"da0c15f0_8e2add2a","line":437,"updated":"2016-03-28 15:09:07.000000000","message":"You don\u0027t need to override __init__ since you\u0027re not doing anything besides calling parent __init__.","commit_id":"63a57dec58b1f509b971ba2022a7e7f982f41fc8"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"4af97db6a56f6ff0a1736109b5769518dea17dc7","unresolved":false,"context_lines":[{"line_number":434,"context_line":"    _cancel_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":435,"context_line":"                       \u0027div.modal-footer.ng-scope \u003e button.btn.btn-default\u0027)"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    def __init__(self, driver, conf, src_elem\u003dNone):"},{"line_number":438,"context_line":"        super(MetadataFormRegion, self).__init__(driver, conf, src_elem)"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    def _form_getter(self):"}],"source_content_type":"text/x-python","patch_set":29,"id":"5a18252c_d43ac797","line":437,"in_reply_to":"da0c15f0_8e2add2a","updated":"2016-04-13 12:02:02.000000000","message":"Fixed.","commit_id":"63a57dec58b1f509b971ba2022a7e7f982f41fc8"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"9173277b5bec5a360313bb517cc03e9d342d5671","unresolved":false,"context_lines":[{"line_number":408,"context_line":""},{"line_number":409,"context_line":"class MetadataFormRegion(BaseFormRegion):"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    _input_fields \u003d (by.By.CSS_SELECTOR, \u0027div.input-group\u0027)"},{"line_number":412,"context_line":"    _custom_input_field \u003d (by.By.XPATH, \"//input[@name\u003d\u0027customItem\u0027]\")"},{"line_number":413,"context_line":"    _custom_input_button \u003d (by.By.CSS_SELECTOR, \u0027span.input-group-btn \u003e .btn\u0027)"},{"line_number":414,"context_line":"    _submit_locator \u003d (by.By.CSS_SELECTOR, \u0027.modal-footer \u003e .btn.btn-primary\u0027)"}],"source_content_type":"text/x-python","patch_set":30,"id":"5a18252c_14ba7f6e","line":411,"updated":"2016-04-13 12:19:31.000000000","message":"This locator is used to find all input fields on the form. The fields for input of values for new custom metadata categories are detected within them by category name (which is contained in div.input-group \u003e span element)","commit_id":"ff8faeb0664edc4f4daff620e2aade429bfabf58"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"9173277b5bec5a360313bb517cc03e9d342d5671","unresolved":false,"context_lines":[{"line_number":409,"context_line":"class MetadataFormRegion(BaseFormRegion):"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    _input_fields \u003d (by.By.CSS_SELECTOR, \u0027div.input-group\u0027)"},{"line_number":412,"context_line":"    _custom_input_field \u003d (by.By.XPATH, \"//input[@name\u003d\u0027customItem\u0027]\")"},{"line_number":413,"context_line":"    _custom_input_button \u003d (by.By.CSS_SELECTOR, \u0027span.input-group-btn \u003e .btn\u0027)"},{"line_number":414,"context_line":"    _submit_locator \u003d (by.By.CSS_SELECTOR, \u0027.modal-footer \u003e .btn.btn-primary\u0027)"},{"line_number":415,"context_line":"    _cancel_locator \u003d (by.By.CSS_SELECTOR, \u0027.modal-footer \u003e .btn.btn-default\u0027)"}],"source_content_type":"text/x-python","patch_set":30,"id":"5a18252c_143f1fd7","line":412,"updated":"2016-04-13 12:19:31.000000000","message":"And this one is used to locate exactly the input filed to state new custom metadata category.","commit_id":"ff8faeb0664edc4f4daff620e2aade429bfabf58"}],"openstack_dashboard/test/integration_tests/regions/tables.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2ad0280d9f55a9c23535bc5ec7f573cc4c9a973b","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    \"\"\""},{"line_number":277,"context_line":"    _anchor_locator \u003d ("},{"line_number":278,"context_line":"        by.By.CSS_SELECTOR,"},{"line_number":279,"context_line":"        \u0027td.sortable.anchor.normal_column \u003e a\u0027)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def decorator(method):"},{"line_number":282,"context_line":"        @functools.wraps(method)"}],"source_content_type":"text/x-python","patch_set":23,"id":"7af24918_a806141e","line":279,"updated":"2016-03-01 13:50:30.000000000","message":"Can\u0027t help but notice that this is going to work only while the link you need to click is the first one among the clickable cell links for that row. In case a new clickable link is added (new column) or existing columns are rearranged, this will fail. \n\nI suggest to specify a column name/id to be anchored when you\u0027re invoking a decorator.","commit_id":"6fc38711cd0034ea62cd05c0c1e25ec660c5c4ba"},{"author":{"_account_id":20772,"name":"Sergei Chipiga","email":"schipiga@mirantis.com","username":"schipiga"},"change_message_id":"50da0957b6178b59f53cb3731418653e2849ffa0","unresolved":false,"context_lines":[{"line_number":292,"context_line":"    return decorator"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"def bind_row_anchor_column():"},{"line_number":296,"context_line":"    \"\"\"A decorator to bind table region method to a anchor in a column."},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    Typical examples of such tables are Project -\u003e Compute -\u003e Images, Admin"},{"line_number":299,"context_line":"    -\u003e System -\u003e Flavors, Project -\u003e Compute -\u003e Instancies."},{"line_number":300,"context_line":"    The method can be used to follow the link in the anchor by the click."},{"line_number":301,"context_line":"    \"\"\""},{"line_number":302,"context_line":"    _anchor_locator \u003d ("},{"line_number":303,"context_line":"        by.By.CSS_SELECTOR,"},{"line_number":304,"context_line":"        \u0027td.sortable.anchor.normal_column \u003e a\u0027)"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    def decorator(method):"},{"line_number":307,"context_line":"        @functools.wraps(method)"},{"line_number":308,"context_line":"        def wrapper(table, row):"},{"line_number":309,"context_line":"            action_element \u003d row._get_element(*_anchor_locator)"},{"line_number":310,"context_line":"            return method(table, action_element, row)"},{"line_number":311,"context_line":"        return wrapper"},{"line_number":312,"context_line":"    return decorator"}],"source_content_type":"text/x-python","patch_set":26,"id":"fa0719c6_b6e0facd","line":312,"range":{"start_line":295,"start_character":0,"end_line":312,"end_character":20},"updated":"2016-03-22 11:54:02.000000000","message":"Suppose, it\u0027s not need to create a decorator factory, because you don\u0027t pass any arguments through it. Just enough decorator only:\n\n    def bind_row_anchor_column(method):\n        \"\"\"A decorator to bind table region method to a anchor in a column.\n\n        Typical examples of such tables are Project -\u003e Compute -\u003e Images, Admin\n        -\u003e System -\u003e Flavors, Project -\u003e Compute -\u003e Instancies.\n        The method can be used to follow the link in the anchor by the click.\n        \"\"\"\n\n        @functools.wraps(method)\n        def wrapper(table, row):\n            action_element \u003d row._get_element(\n                by.By.CSS_SELECTOR, \u0027td.sortable.anchor.normal_column \u003e a\u0027)\n            return method(table, action_element, row)\n\n        return wrapper","commit_id":"0ed1d7953053f9281a8bd71d3af08e22aad5f1dc"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"d14da44fbfb78d9c7996cf81fd97aac46877c2af","unresolved":false,"context_lines":[{"line_number":292,"context_line":"    return decorator"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"def bind_row_anchor_column():"},{"line_number":296,"context_line":"    \"\"\"A decorator to bind table region method to a anchor in a column."},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    Typical examples of such tables are Project -\u003e Compute -\u003e Images, Admin"},{"line_number":299,"context_line":"    -\u003e System -\u003e Flavors, Project -\u003e Compute -\u003e Instancies."},{"line_number":300,"context_line":"    The method can be used to follow the link in the anchor by the click."},{"line_number":301,"context_line":"    \"\"\""},{"line_number":302,"context_line":"    _anchor_locator \u003d ("},{"line_number":303,"context_line":"        by.By.CSS_SELECTOR,"},{"line_number":304,"context_line":"        \u0027td.sortable.anchor.normal_column \u003e a\u0027)"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    def decorator(method):"},{"line_number":307,"context_line":"        @functools.wraps(method)"},{"line_number":308,"context_line":"        def wrapper(table, row):"},{"line_number":309,"context_line":"            action_element \u003d row._get_element(*_anchor_locator)"},{"line_number":310,"context_line":"            return method(table, action_element, row)"},{"line_number":311,"context_line":"        return wrapper"},{"line_number":312,"context_line":"    return decorator"}],"source_content_type":"text/x-python","patch_set":26,"id":"fa0719c6_b93c3bc9","line":312,"range":{"start_line":295,"start_character":0,"end_line":312,"end_character":20},"in_reply_to":"fa0719c6_b6e0facd","updated":"2016-03-23 07:57:35.000000000","message":"Fixed.","commit_id":"0ed1d7953053f9281a8bd71d3af08e22aad5f1dc"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"b7907645338b10dea10e3b185b4eb050ae99aaad","unresolved":false,"context_lines":[{"line_number":299,"context_line":"    @functools.wraps(method)"},{"line_number":300,"context_line":"    def wrapper(table, row):"},{"line_number":301,"context_line":"        action_element \u003d row._get_element("},{"line_number":302,"context_line":"            by.By.CSS_SELECTOR, \u0027td.sortable.anchor.normal_column \u003e a\u0027)"},{"line_number":303,"context_line":"        return method(table, action_element, row)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    return wrapper"}],"source_content_type":"text/x-python","patch_set":28,"id":"fa0719c6_9b55e4fb","line":302,"updated":"2016-03-23 11:08:40.000000000","message":"A few comments about this selector:\n\n* what if more than one column in a row has hyperlink? See Project-\u003eVolumes table for an example\n* .sortable class is irrelevant here - .anchor column may not have it\n* could you please use NORMAL_COLUMN_CLASS constant instead of \u0027normal_column\u0027 to deduplicate knowledge?","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"679d5e48cf49a95a9d2e9f3b366089fd7b706865","unresolved":false,"context_lines":[{"line_number":299,"context_line":"    @functools.wraps(method)"},{"line_number":300,"context_line":"    def wrapper(table, row):"},{"line_number":301,"context_line":"        action_element \u003d row._get_element("},{"line_number":302,"context_line":"            by.By.CSS_SELECTOR, \u0027td.sortable.anchor.normal_column \u003e a\u0027)"},{"line_number":303,"context_line":"        return method(table, action_element, row)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    return wrapper"}],"source_content_type":"text/x-python","patch_set":28,"id":"da0c15f0_ec5baf85","line":302,"in_reply_to":"fa0719c6_9b55e4fb","updated":"2016-03-28 13:31:02.000000000","message":"The columns to be distinguished by data-selenium tags that are passed in the decorator.\nNORMAL_COLUMN_CLASS to be used to find the \u003ctd\u003e node.\nPlease see the next patchset.","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"}],"openstack_dashboard/test/integration_tests/tests/test_images.py":[{"author":{"_account_id":20772,"name":"Sergei Chipiga","email":"schipiga@mirantis.com","username":"schipiga"},"change_message_id":"e2d1f92fb062c5c974f98fb4e66afe713cd4a8dd","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            result \u003d images_page.check_image_details(IMAGE_NAME,"},{"line_number":121,"context_line":"                                                     field_name,"},{"line_number":122,"context_line":"                                                     value)"},{"line_number":123,"context_line":"            self.assertTrue(result)"},{"line_number":124,"context_line":"        self.image_delete()"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"fa0719c6_99dc0914","line":123,"updated":"2016-03-22 12:13:19.000000000","message":"I\u0027m confused, that `assertTrue` is inside the cycle. It means, that if test will be failed at first iteration, we will never know results of other. I would like to see a chunk like that:\n\n    results \u003d []\n    for field_name, value in new_metadata.iteritems():\n        results.append(\n            images_page.check_image_details(IMAGE_NAME,\n                                            field_name,\n                                            value))\n    self.assertSequenceTrue(results)  # custom matcher\n\n\n    def assertSequenceTrue(self, actual):\n        return self.assertEqual(list(actual), [True] * len(actual))\n\n    def assertSequenceFalse(self, actual):\n        return self.assertEqual(list(actual), [False] * len(actual))","commit_id":"0ed1d7953053f9281a8bd71d3af08e22aad5f1dc"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"d14da44fbfb78d9c7996cf81fd97aac46877c2af","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            result \u003d images_page.check_image_details(IMAGE_NAME,"},{"line_number":121,"context_line":"                                                     field_name,"},{"line_number":122,"context_line":"                                                     value)"},{"line_number":123,"context_line":"            self.assertTrue(result)"},{"line_number":124,"context_line":"        self.image_delete()"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"fa0719c6_99405736","line":123,"in_reply_to":"fa0719c6_99dc0914","updated":"2016-03-23 07:57:35.000000000","message":"Fixed.","commit_id":"0ed1d7953053f9281a8bd71d3af08e22aad5f1dc"},{"author":{"_account_id":20772,"name":"Sergei Chipiga","email":"schipiga@mirantis.com","username":"schipiga"},"change_message_id":"de94f6692980392c8f4e992986e76066c913e07f","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                images_page.check_image_details(IMAGE_NAME,"},{"line_number":123,"context_line":"                                                field_name,"},{"line_number":124,"context_line":"                                                value))"},{"line_number":125,"context_line":"        self.assertSequenceTrue(results)  # custom matcher"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"class TestImagesAdvanced(helpers.TestCase):"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa0719c6_d372caac","line":125,"updated":"2016-03-22 16:40:34.000000000","message":"Your tests are failed, because assertSequenceTrue is not implemented. You need to implement it like that:\n\n    def assertSequenceTrue(self, actual):\n        self.assertSequenceEqual(actual, [True] * len(actual))","commit_id":"36344f117d969f6063acd85fcfd553e8738cb23b"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"747daa971e2965b114cc602e1ed1c4db770b0808","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                images_page.check_image_details(IMAGE_NAME,"},{"line_number":123,"context_line":"                                                field_name,"},{"line_number":124,"context_line":"                                                value))"},{"line_number":125,"context_line":"        self.assertSequenceTrue(results)  # custom matcher"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"class TestImagesAdvanced(helpers.TestCase):"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa0719c6_f91b5371","line":125,"in_reply_to":"fa0719c6_d372caac","updated":"2016-03-23 07:56:16.000000000","message":"Yes, I accidentally missed update of the helpers.py in the previous patch set.","commit_id":"36344f117d969f6063acd85fcfd553e8738cb23b"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"b7907645338b10dea10e3b185b4eb050ae99aaad","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        * verifies the image does not appear in the table after deletion"},{"line_number":115,"context_line":"        \"\"\""},{"line_number":116,"context_line":"        new_metadata \u003d {\u0027metadata\u0027: \u0027image\u0027}"},{"line_number":117,"context_line":"        images_page \u003d self.image_create()"},{"line_number":118,"context_line":"        images_page.add_custom_metadata(IMAGE_NAME, new_metadata)"},{"line_number":119,"context_line":"        results \u003d []"},{"line_number":120,"context_line":"        for field_name, value in new_metadata.iteritems():"}],"source_content_type":"text/x-python","patch_set":28,"id":"fa0719c6_201c6369","line":117,"updated":"2016-03-23 11:08:40.000000000","message":"This is lacking image cleanup. Tests are still passing only because first you\u0027re running admin tests, then regular tests (if it was otherwise, the admin pagination test would fail on an image visible after basic metadata update test).","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"679d5e48cf49a95a9d2e9f3b366089fd7b706865","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        * verifies the image does not appear in the table after deletion"},{"line_number":115,"context_line":"        \"\"\""},{"line_number":116,"context_line":"        new_metadata \u003d {\u0027metadata\u0027: \u0027image\u0027}"},{"line_number":117,"context_line":"        images_page \u003d self.image_create()"},{"line_number":118,"context_line":"        images_page.add_custom_metadata(IMAGE_NAME, new_metadata)"},{"line_number":119,"context_line":"        results \u003d []"},{"line_number":120,"context_line":"        for field_name, value in new_metadata.iteritems():"}],"source_content_type":"text/x-python","patch_set":28,"id":"da0c15f0_6305f2ba","line":117,"in_reply_to":"fa0719c6_201c6369","updated":"2016-03-28 13:31:02.000000000","message":"Oh... sry, lost the image_delete in the last patchset.","commit_id":"120003c78605a23b49dcfee6b498eb32b3ecc7d0"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"c90211a6a64c4dae84a58d7305e868b89b6896ee","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        results \u003d []"},{"line_number":120,"context_line":"        for field_name, value in new_metadata.iteritems():"},{"line_number":121,"context_line":"            results.append("},{"line_number":122,"context_line":"                images_page.check_image_details(IMAGE_NAME,"},{"line_number":123,"context_line":"                                                field_name,"},{"line_number":124,"context_line":"                                                value))"},{"line_number":125,"context_line":"        self.image_delete()"}],"source_content_type":"text/x-python","patch_set":29,"id":"da0c15f0_f1141e45","line":122,"updated":"2016-03-28 15:09:07.000000000","message":"You\u0027re still invoking get_contents() inside each call to check_image_details(), while actually it would suffice just to compare dictionary from get_contents() with `new_metadata`.","commit_id":"63a57dec58b1f509b971ba2022a7e7f982f41fc8"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"4af97db6a56f6ff0a1736109b5769518dea17dc7","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        results \u003d []"},{"line_number":120,"context_line":"        for field_name, value in new_metadata.iteritems():"},{"line_number":121,"context_line":"            results.append("},{"line_number":122,"context_line":"                images_page.check_image_details(IMAGE_NAME,"},{"line_number":123,"context_line":"                                                field_name,"},{"line_number":124,"context_line":"                                                value))"},{"line_number":125,"context_line":"        self.image_delete()"}],"source_content_type":"text/x-python","patch_set":29,"id":"5a18252c_541cf712","line":122,"in_reply_to":"da0c15f0_f1141e45","updated":"2016-04-13 12:02:02.000000000","message":"Changed that logic and also changed locators that we discussed in https://review.openstack.org/#/c/271249/28..29/openstack_dashboard/test/integration_tests/regions/forms.py line 428.","commit_id":"63a57dec58b1f509b971ba2022a7e7f982f41fc8"}]}
