)]}'
{"openstack_dashboard/dashboards/project/stacks/tables.py":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"a8861120bb6746e67a1194492a9c56e9d4ea34fa","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    def action(self, request, stack_id):"},{"line_number":123,"context_line":"        try:"},{"line_number":124,"context_line":"            stack \u003d api.heat.stack_get(request, stack_id)"},{"line_number":125,"context_line":"            if stack.stack_status \u003d\u003d \u0027SUSPEND_COMPLETE\u0027:"},{"line_number":126,"context_line":"                # Unable to resume stack what status is not"},{"line_number":127,"context_line":"                # \"SUSPEND_COMPLETE\""},{"line_number":128,"context_line":"                api.heat.action_resume(request, stack_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_b01ee35c","line":125,"updated":"2016-02-02 07:08:36.000000000","message":"AFAIK \u0027SUSPEND_COMPLETE\u0027 is not the only status to resume a stack since Heat allows to check a suspended stack, so it\u0027s possible resume a stack with \u0027CHECK_COMPLETE\u0027 state too. May be the better way is to check states which make stack resume unable.","commit_id":"fe376b763bcb6a8c3c7d996a12aa869dc7667290"},{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"31d4aacc1490d0bc77e642df5d53de3a81f56353","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        try:"},{"line_number":124,"context_line":"            stack \u003d api.heat.stack_get(request, stack_id)"},{"line_number":125,"context_line":"            if stack.stack_status \u003d\u003d \u0027SUSPEND_COMPLETE\u0027:"},{"line_number":126,"context_line":"                # Unable to resume stack what status is not"},{"line_number":127,"context_line":"                # \"SUSPEND_COMPLETE\""},{"line_number":128,"context_line":"                api.heat.action_resume(request, stack_id)"},{"line_number":129,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_a95bd9f5","line":126,"range":{"start_line":126,"start_character":24,"end_line":126,"end_character":25},"updated":"2016-02-02 09:22:56.000000000","message":"Agree with Tatiana. Isn\u0027t it clearer to check if exception is raised and send apropriate msg to user?\nEven if .action_resume throws no errors if it failed, I think, it should be corrected in api.heat.action)resume.","commit_id":"fe376b763bcb6a8c3c7d996a12aa869dc7667290"}],"openstack_dashboard/dashboards/project/stacks/tests.py":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"a8861120bb6746e67a1194492a9c56e9d4ea34fa","unresolved":false,"context_lines":[{"line_number":749,"context_line":"    def test_suspend_stack(self):"},{"line_number":750,"context_line":"        self._test_stack_action(\u0027suspend\u0027)"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"    @test.create_stubs({api.heat: (\u0027stacks_list\u0027, \u0027action_resume\u0027,)})"},{"line_number":753,"context_line":"    def test_resume_stack(self):"},{"line_number":754,"context_line":"        self._test_stack_action(\u0027resume\u0027)"},{"line_number":755,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_b08023f8","side":"PARENT","line":752,"updated":"2016-02-02 07:08:36.000000000","message":"Deleting failed test solves a problem, of course, but usually adds another problems :) If anything goes wrong with a test, you should rewrite it, not just delete it.","commit_id":"e6a6adda4da7b0880bc42155bb44dd816958ee83"}]}