)]}'
{"openstack_dashboard/dashboards/project/networks/templates/networks/ports/_detail_overview.html":[{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"5cf63745fea9c41686f2df3437972fdb369e6490","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  \u003ch4\u003e{% trans \"Binding\" %}\u003c/h4\u003e"},{"line_number":86,"context_line":"  \u003chr class\u003d\"header_rule\"\u003e"},{"line_number":87,"context_line":"    \u003cdl class\u003d\"dl-horizontal\"\u003e"},{"line_number":88,"context_line":"      \u003cdt\u003e{% trans \"VNIC Type\" %}\u003c/dt\u003e"},{"line_number":89,"context_line":"      \u003cdd\u003e{{ port.binding__vnic_type }}\u003c/dd\u003e"},{"line_number":90,"context_line":"    {% if port.binding__host_id %}"}],"source_content_type":"text/html","patch_set":1,"id":"9a68dd71_e9cd3587","line":87,"updated":"2016-01-26 16:47:37.000000000","message":"(nit) This \u003cdl\u003e block does not to be indented under the \u003chr\u003e tag.","commit_id":"9503e1d97f61425d25ae90c95780280df5510c9e"},{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"5cf63745fea9c41686f2df3437972fdb369e6490","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    \u003cdl class\u003d\"dl-horizontal\"\u003e"},{"line_number":88,"context_line":"      \u003cdt\u003e{% trans \"VNIC Type\" %}\u003c/dt\u003e"},{"line_number":89,"context_line":"      \u003cdd\u003e{{ port.binding__vnic_type }}\u003c/dd\u003e"},{"line_number":90,"context_line":"    {% if port.binding__host_id %}"},{"line_number":91,"context_line":"      \u003cdt\u003e{% trans \"Host\" %}\u003c/dt\u003e"},{"line_number":92,"context_line":"      \u003cdd\u003e{{ port.binding__host_id|default:_(\"None\") }}\u003c/dd\u003e"},{"line_number":93,"context_line":"      \u003cdt\u003e{% trans \"Profile\" %}\u003c/dt\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"9a68dd71_e9c9b55b","line":90,"updated":"2016-01-26 16:47:37.000000000","message":"(nit) This entire if block can probably be indented to be consistent with other indentation styles on this and other pages.","commit_id":"9503e1d97f61425d25ae90c95780280df5510c9e"},{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"0719a276962ec80a0ca9af0f01769dfd62ad3a27","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        \u003cdd\u003e"},{"line_number":99,"context_line":"          \u003cul\u003e"},{"line_number":100,"context_line":"          {% for key,value in port.binding__vif_details.items %}"},{"line_number":101,"context_line":"          \u003cli\u003e\u003cb\u003e{{ key }}\u003c/b\u003e {{ value }}\u003c/li\u003e"},{"line_number":102,"context_line":"          {% endfor %}"},{"line_number":103,"context_line":"          \u003c/ul\u003e"},{"line_number":104,"context_line":"        \u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"5a5ae5dd_279d2566","line":101,"updated":"2016-02-05 22:01:30.000000000","message":"This can be indented as well...","commit_id":"2ae819b0ec1ba6eb85795a84971e9c37e79213ed"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"2b3a50160d2622be70659a072aaa8ecb16a0d18b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    \u003cdt\u003e{% trans \"Admin State\" %}\u003c/dt\u003e"},{"line_number":21,"context_line":"    \u003cdd\u003e{{ port.admin_state_label|default:_(\"None\") }}\u003c/dd\u003e"},{"line_number":22,"context_line":"    \u003cdt\u003e{% trans \"Port Security Enabled\" %}\u003c/dt\u003e"},{"line_number":23,"context_line":"    \u003cdd\u003e{{ port.port_security_enabled }}\u003c/dd\u003e"},{"line_number":24,"context_line":"    \u003cdt\u003e{% trans \"DNS Name\" %}\u003c/dt\u003e"},{"line_number":25,"context_line":"    \u003cdd\u003e{{ port.dns_name|default:_(\"None\") }}\u003c/dd\u003e"},{"line_number":26,"context_line":"    {% if port.mac_state %}"}],"source_content_type":"text/html","patch_set":3,"id":"5a5ae5dd_d5559af9","line":23,"updated":"2016-02-08 17:36:46.000000000","message":"Seems that all my ports either dont have this field or its empty. Maybe a default filter with False would be good to add here?","commit_id":"8985022f9ef2232b0f99af84aecc64553f9c6fb5"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"7b9c61e0da973150a9ae887efba8e99746326b8f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    \u003cdt\u003e{% trans \"Admin State\" %}\u003c/dt\u003e"},{"line_number":21,"context_line":"    \u003cdd\u003e{{ port.admin_state_label|default:_(\"None\") }}\u003c/dd\u003e"},{"line_number":22,"context_line":"    \u003cdt\u003e{% trans \"Port Security Enabled\" %}\u003c/dt\u003e"},{"line_number":23,"context_line":"    \u003cdd\u003e{{ port.port_security_enabled|default:_(\"True\") }}\u003c/dd\u003e"},{"line_number":24,"context_line":"    \u003cdt\u003e{% trans \"DNS Name\" %}\u003c/dt\u003e"},{"line_number":25,"context_line":"    \u003cdd\u003e{{ port.dns_name|default:_(\"None\") }}\u003c/dd\u003e"},{"line_number":26,"context_line":"    {% if port.mac_state %}"}],"source_content_type":"text/html","patch_set":4,"id":"5a5ae5dd_3853c318","line":23,"updated":"2016-02-08 17:57:33.000000000","message":"Actually I was reading about this and port security seems to be an extension so:\n - We check for the extension an depending on that we display it or not \u003c- Too complicated for a small line\n - We check in the template {% if port.port_security_enabled %} instead as to not confuse the end user showing parameters that they dont have enabled.\n - We default to False instead of True, because if there is no attribute its probably because the extension is disabled thus no port security enabled? \u003c- Not sure if this is really true?","commit_id":"902ce2f53f63f7cfac35dda67677b3e543195e19"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"4e2c98a6b476acbd358cc9725067a71aaf843354","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    \u003cdl class\u003d\"dl-horizontal\"\u003e"},{"line_number":59,"context_line":"      \u003cdt\u003e{% trans \"IP Address\" %}\u003c/dt\u003e"},{"line_number":60,"context_line":"      \u003cdd\u003e{{ ip.ip_address }}\u003c/dd\u003e"},{"line_number":61,"context_line":"      {% url \u0027horizon:project:networks:subnets:detail\u0027 ip.subnet_id as subnet_url %}"},{"line_number":62,"context_line":"      \u003cdt\u003e{% trans \"Subnet ID\" %}\u003c/dt\u003e"},{"line_number":63,"context_line":"      \u003cdd\u003e\u003ca href\u003d\"{{ subnet_url }}\"\u003e{{ ip.subnet_id }}\u003c/a\u003e\u003c/dd\u003e"},{"line_number":64,"context_line":"    \u003c/dl\u003e"}],"source_content_type":"text/html","patch_set":5,"id":"3a57f1b5_8f76fa3c","line":61,"range":{"start_line":61,"start_character":14,"end_line":61,"end_character":53},"updated":"2016-02-10 11:11:25.000000000","message":"from admin detail page, if you are clicking on the subnet id. it will redirect to project subnet panel.","commit_id":"00111b6a38a6e619849397f95545dc337ed846f3"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"3c614348966f18473305e2813d476ce410d336f2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    {% endif %}"},{"line_number":37,"context_line":"  \u003c/dl\u003e"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  \u003ch4\u003e{% trans \"DNS Assignment\" %}\u003c/h4\u003e"},{"line_number":40,"context_line":"  \u003chr class\u003d\"header_rule\"\u003e"},{"line_number":41,"context_line":"  {% for host in port.dns_assignment %}"},{"line_number":42,"context_line":"    \u003cdl class\u003d\"dl-horizontal\"\u003e"}],"source_content_type":"text/html","patch_set":9,"id":"3afc51ec_5223b905","line":39,"updated":"2016-03-11 14:51:47.000000000","message":"A conceptual question here: should we display a title if the section is empty?","commit_id":"10ecad1a93690fba6d4854e0cbb94736693e40c8"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"9437a7ec38b08812e098ae0cbbf4e9ce99e632e5","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    {% endif %}"},{"line_number":37,"context_line":"  \u003c/dl\u003e"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  \u003ch4\u003e{% trans \"DNS Assignment\" %}\u003c/h4\u003e"},{"line_number":40,"context_line":"  \u003chr class\u003d\"header_rule\"\u003e"},{"line_number":41,"context_line":"  {% for host in port.dns_assignment %}"},{"line_number":42,"context_line":"    \u003cdl class\u003d\"dl-horizontal\"\u003e"}],"source_content_type":"text/html","patch_set":9,"id":"3afc51ec_553a7937","line":39,"in_reply_to":"3afc51ec_5223b905","updated":"2016-03-11 18:15:23.000000000","message":"I\u0027m unsure. I thought it was more valuable to see that nothing was assigned, than just hide the info. Hidden info is ambiguous; a visible \"None\" is not. Schrödinger\u0027s DNS Assignment, if you will.","commit_id":"10ecad1a93690fba6d4854e0cbb94736693e40c8"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"3c614348966f18473305e2813d476ce410d336f2","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        \u003cdd\u003e"},{"line_number":101,"context_line":"          \u003cul\u003e"},{"line_number":102,"context_line":"            {% for key,value in port.binding__vif_details.items %}"},{"line_number":103,"context_line":"              \u003cli\u003e\u003cb\u003e{{ key }}\u003c/b\u003e {{ value }}\u003c/li\u003e"},{"line_number":104,"context_line":"            {% endfor %}"},{"line_number":105,"context_line":"          \u003c/ul\u003e"},{"line_number":106,"context_line":"        \u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":9,"id":"3afc51ec_52ce195b","line":103,"updated":"2016-03-11 14:51:47.000000000","message":"This double-bold (first for \u003cdt\u003e, then for \u003cdd\u003e key entry) may be confusing, as there will be too many bold terms and it\u0027s the same as having no bold at all.\n\nWhat if we used table style here?","commit_id":"10ecad1a93690fba6d4854e0cbb94736693e40c8"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"54dbf02c28b1d74927f10f71d7e5c26adf0493ec","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        \u003cdd\u003e"},{"line_number":101,"context_line":"          \u003cul\u003e"},{"line_number":102,"context_line":"            {% for key,value in port.binding__vif_details.items %}"},{"line_number":103,"context_line":"              \u003cli\u003e\u003cb\u003e{{ key }}\u003c/b\u003e {{ value }}\u003c/li\u003e"},{"line_number":104,"context_line":"            {% endfor %}"},{"line_number":105,"context_line":"          \u003c/ul\u003e"},{"line_number":106,"context_line":"        \u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":9,"id":"3afc51ec_a84bb058","line":103,"in_reply_to":"3afc51ec_52ce195b","updated":"2016-03-11 15:12:25.000000000","message":"Here is an illustration of what I deem confusing: http://imgur.com/zEGOMZp","commit_id":"10ecad1a93690fba6d4854e0cbb94736693e40c8"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"9437a7ec38b08812e098ae0cbbf4e9ce99e632e5","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        \u003cdd\u003e"},{"line_number":101,"context_line":"          \u003cul\u003e"},{"line_number":102,"context_line":"            {% for key,value in port.binding__vif_details.items %}"},{"line_number":103,"context_line":"              \u003cli\u003e\u003cb\u003e{{ key }}\u003c/b\u003e {{ value }}\u003c/li\u003e"},{"line_number":104,"context_line":"            {% endfor %}"},{"line_number":105,"context_line":"          \u003c/ul\u003e"},{"line_number":106,"context_line":"        \u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":9,"id":"3afc51ec_750cd594","line":103,"in_reply_to":"3afc51ec_52ce195b","updated":"2016-03-11 18:15:23.000000000","message":"I kinda disagree, because the indentation is what shows the separation; the bold/regular weighting is just to show between keypair and value.","commit_id":"10ecad1a93690fba6d4854e0cbb94736693e40c8"}]}