)]}'
{"openstack_dashboard/dashboards/project/loadbalancers/tables.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"eece771f2e1ea7c305138ef72c818ffa7e2f7035","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"class UpdatePoolLink(tables.LinkAction):"},{"line_number":105,"context_line":"    name \u003d \"updatepool\""},{"line_number":106,"context_line":"    verbose_name \u003d _(\"Update Pool\")"},{"line_number":107,"context_line":"    classes \u003d (\"btn-updatepool\",)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def get_link_url(self, pool):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fy3c%3D","line":106,"updated":"2013-04-23 04:59:50.000000000","message":"Please use the term \"Edit\" instead of \"Update\" for consistency.","commit_id":"47630fc4f77982a1cc4aecbb7fc6e040fddb2539"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"d8de6f42eab4ee626564f0f02ed0d7abc79018a5","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"class UpdatePoolLink(tables.LinkAction):"},{"line_number":105,"context_line":"    name \u003d \"updatepool\""},{"line_number":106,"context_line":"    verbose_name \u003d _(\"Update Pool\")"},{"line_number":107,"context_line":"    classes \u003d (\"btn-updatepool\",)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def get_link_url(self, pool):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fyu4%3D","line":106,"in_reply_to":"AAAAOn%2F%2Fy3c%3D","updated":"2013-04-23 12:04:45.000000000","message":"Done","commit_id":"47630fc4f77982a1cc4aecbb7fc6e040fddb2539"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"eece771f2e1ea7c305138ef72c818ffa7e2f7035","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    verbose_name \u003d _(\"Update Pool\")"},{"line_number":107,"context_line":"    classes \u003d (\"btn-updatepool\",)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def get_link_url(self, pool):"},{"line_number":110,"context_line":"        base_url \u003d reverse(\"horizon:project:loadbalancers:updatepool\","},{"line_number":111,"context_line":"                           kwargs\u003d{\u0027pool_id\u0027: pool.id})"},{"line_number":112,"context_line":"        return base_url"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fy3Y%3D","line":109,"updated":"2013-04-23 04:59:50.000000000","message":"I don\u0027t think you need to override get_link_url method.. \n\nYou just need to define:\nurl \u003d \"horizon:project:loadbalancers:updatepool\"\n\nDefault implementation of get_link_url () already takes care of calling reverse and passing the object id as argument.","commit_id":"47630fc4f77982a1cc4aecbb7fc6e040fddb2539"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"d8de6f42eab4ee626564f0f02ed0d7abc79018a5","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    verbose_name \u003d _(\"Update Pool\")"},{"line_number":107,"context_line":"    classes \u003d (\"btn-updatepool\",)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def get_link_url(self, pool):"},{"line_number":110,"context_line":"        base_url \u003d reverse(\"horizon:project:loadbalancers:updatepool\","},{"line_number":111,"context_line":"                           kwargs\u003d{\u0027pool_id\u0027: pool.id})"},{"line_number":112,"context_line":"        return base_url"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fyqo%3D","line":109,"in_reply_to":"AAAAOn%2F%2Fy3Y%3D","updated":"2013-04-23 12:04:45.000000000","message":"The pool id is needed for \"update pool\" page. I used the same get_link_url () method as it was in AddVipLink () for consistency.","commit_id":"47630fc4f77982a1cc4aecbb7fc6e040fddb2539"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"eece771f2e1ea7c305138ef72c818ffa7e2f7035","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        verbose_name \u003d _(\"Pools\")"},{"line_number":133,"context_line":"        table_actions \u003d (AddPoolLink, DeletePoolLink)"},{"line_number":134,"context_line":"        row_actions \u003d (AddVipLink, DeleteVipLink,"},{"line_number":135,"context_line":"                       UpdatePoolLink, DeletePoolLink)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"def get_pool_link(member):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fy3U%3D","line":135,"updated":"2013-04-23 04:59:50.000000000","message":"Probably better to have \"Edit Pool\" going first for consistency with other screens.","commit_id":"47630fc4f77982a1cc4aecbb7fc6e040fddb2539"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"d8de6f42eab4ee626564f0f02ed0d7abc79018a5","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        verbose_name \u003d _(\"Pools\")"},{"line_number":133,"context_line":"        table_actions \u003d (AddPoolLink, DeletePoolLink)"},{"line_number":134,"context_line":"        row_actions \u003d (AddVipLink, DeleteVipLink,"},{"line_number":135,"context_line":"                       UpdatePoolLink, DeletePoolLink)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"def get_pool_link(member):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fyuw%3D","line":135,"in_reply_to":"AAAAOn%2F%2Fy3U%3D","updated":"2013-04-23 12:04:45.000000000","message":"Done","commit_id":"47630fc4f77982a1cc4aecbb7fc6e040fddb2539"}],"openstack_dashboard/dashboards/project/loadbalancers/templates/loadbalancers/updatepool.html":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"eece771f2e1ea7c305138ef72c818ffa7e2f7035","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Update Pool\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"  {% include \"horizon/common/_page_header.html\" with title\u003d_(\"Update Pool\") %}"}],"source_content_type":"text/html","patch_set":1,"id":"AAAAOn%2F%2Fy3Q%3D","line":3,"updated":"2013-04-23 04:59:50.000000000","message":"Change to \"Edit\" for consistency.","commit_id":"47630fc4f77982a1cc4aecbb7fc6e040fddb2539"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"d8de6f42eab4ee626564f0f02ed0d7abc79018a5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Update Pool\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"  {% include \"horizon/common/_page_header.html\" with title\u003d_(\"Update Pool\") %}"}],"source_content_type":"text/html","patch_set":1,"id":"AAAAOn%2F%2Fyus%3D","line":3,"in_reply_to":"AAAAOn%2F%2Fy3Q%3D","updated":"2013-04-23 12:04:45.000000000","message":"Done","commit_id":"47630fc4f77982a1cc4aecbb7fc6e040fddb2539"}],"openstack_dashboard/dashboards/project/loadbalancers/tests.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"eece771f2e1ea7c305138ef72c818ffa7e2f7035","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        api.lbaas.pool_update("},{"line_number":344,"context_line":"            IsA(http.HttpRequest),"},{"line_number":345,"context_line":"            pool.id,"},{"line_number":346,"context_line":"            pool\u003d{\u0027name\u0027: pool.name,"},{"line_number":347,"context_line":"            \u0027description\u0027: pool.description,"},{"line_number":348,"context_line":"            \u0027lb_method\u0027: pool.lb_method,"},{"line_number":349,"context_line":"            \u0027admin_state_up\u0027: pool.admin_state_up}).AndReturn(Pool(pool))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fy24%3D","line":346,"updated":"2013-04-23 04:59:50.000000000","message":"This should be taking in form_data.\n\nSee example in: api_tests/lbaas_test.py test_pool_update()","commit_id":"47630fc4f77982a1cc4aecbb7fc6e040fddb2539"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"d8de6f42eab4ee626564f0f02ed0d7abc79018a5","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        api.lbaas.pool_update("},{"line_number":344,"context_line":"            IsA(http.HttpRequest),"},{"line_number":345,"context_line":"            pool.id,"},{"line_number":346,"context_line":"            pool\u003d{\u0027name\u0027: pool.name,"},{"line_number":347,"context_line":"            \u0027description\u0027: pool.description,"},{"line_number":348,"context_line":"            \u0027lb_method\u0027: pool.lb_method,"},{"line_number":349,"context_line":"            \u0027admin_state_up\u0027: pool.admin_state_up}).AndReturn(Pool(pool))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FyuY%3D","line":346,"in_reply_to":"AAAAOn%2F%2Fy24%3D","updated":"2013-04-23 12:04:45.000000000","message":"Done","commit_id":"47630fc4f77982a1cc4aecbb7fc6e040fddb2539"}],"openstack_dashboard/dashboards/project/loadbalancers/views.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"eece771f2e1ea7c305138ef72c818ffa7e2f7035","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        initial[\u0027pool_id\u0027] \u003d self.kwargs[\u0027pool_id\u0027]"},{"line_number":167,"context_line":"        try:"},{"line_number":168,"context_line":"            pool \u003d api.lbaas.pool_get(self.request, initial[\u0027pool_id\u0027])"},{"line_number":169,"context_line":"            initial[\u0027pool_name\u0027] \u003d pool.name"},{"line_number":170,"context_line":"            initial[\u0027pool_description\u0027] \u003d pool.description"},{"line_number":171,"context_line":"            initial[\u0027pool_lb_method\u0027] \u003d pool.lb_method"},{"line_number":172,"context_line":"            initial[\u0027pool_admin_state_up\u0027] \u003d pool.admin_state_up"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fy2s%3D","line":169,"updated":"2013-04-23 04:59:50.000000000","message":"The key should be the same name as the field name, this way it would be automatically loaded in the form.\n\nYou can use thi as reference: openstack_dashboard/dashboards/admin/projects/views.py - UpdateProjectView()","commit_id":"47630fc4f77982a1cc4aecbb7fc6e040fddb2539"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"d8de6f42eab4ee626564f0f02ed0d7abc79018a5","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        initial[\u0027pool_id\u0027] \u003d self.kwargs[\u0027pool_id\u0027]"},{"line_number":167,"context_line":"        try:"},{"line_number":168,"context_line":"            pool \u003d api.lbaas.pool_get(self.request, initial[\u0027pool_id\u0027])"},{"line_number":169,"context_line":"            initial[\u0027pool_name\u0027] \u003d pool.name"},{"line_number":170,"context_line":"            initial[\u0027pool_description\u0027] \u003d pool.description"},{"line_number":171,"context_line":"            initial[\u0027pool_lb_method\u0027] \u003d pool.lb_method"},{"line_number":172,"context_line":"            initial[\u0027pool_admin_state_up\u0027] \u003d pool.admin_state_up"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FynE%3D","line":169,"in_reply_to":"AAAAOn%2F%2Fy2s%3D","updated":"2013-04-23 12:04:45.000000000","message":"Done. Thanks.","commit_id":"47630fc4f77982a1cc4aecbb7fc6e040fddb2539"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"eece771f2e1ea7c305138ef72c818ffa7e2f7035","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            initial[\u0027pool_lb_method\u0027] \u003d pool.lb_method"},{"line_number":172,"context_line":"            initial[\u0027pool_admin_state_up\u0027] \u003d pool.admin_state_up"},{"line_number":173,"context_line":"        except:"},{"line_number":174,"context_line":"            initial[\u0027pool_name\u0027] \u003d \u0027\u0027"},{"line_number":175,"context_line":"            initial[\u0027pool_description\u0027] \u003d \u0027\u0027"},{"line_number":176,"context_line":"            initial[\u0027pool_lb_method\u0027] \u003d \u0027\u0027"},{"line_number":177,"context_line":"            initial[\u0027pool_admin_state_up\u0027] \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fy2k%3D","line":174,"updated":"2013-04-23 04:59:50.000000000","message":"Not sure why you still need to initialize the values here, I don\u0027t this is still needed..\n\nThe page won\u0027t load anyway if there is an error.","commit_id":"47630fc4f77982a1cc4aecbb7fc6e040fddb2539"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"d8de6f42eab4ee626564f0f02ed0d7abc79018a5","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            initial[\u0027pool_lb_method\u0027] \u003d pool.lb_method"},{"line_number":172,"context_line":"            initial[\u0027pool_admin_state_up\u0027] \u003d pool.admin_state_up"},{"line_number":173,"context_line":"        except:"},{"line_number":174,"context_line":"            initial[\u0027pool_name\u0027] \u003d \u0027\u0027"},{"line_number":175,"context_line":"            initial[\u0027pool_description\u0027] \u003d \u0027\u0027"},{"line_number":176,"context_line":"            initial[\u0027pool_lb_method\u0027] \u003d \u0027\u0027"},{"line_number":177,"context_line":"            initial[\u0027pool_admin_state_up\u0027] \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fys4%3D","line":174,"in_reply_to":"AAAAOn%2F%2Fy2k%3D","updated":"2013-04-23 12:04:45.000000000","message":"Done","commit_id":"47630fc4f77982a1cc4aecbb7fc6e040fddb2539"},{"author":{"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},"change_message_id":"e5ee3a88b3bc6a33d1596ed70c1dc5b0617b9a3a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from openstack_dashboard import api"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from .workflows import AddPool, AddMember, AddMonitor, AddVip"},{"line_number":31,"context_line":"from .workflows import UpdatePool"},{"line_number":32,"context_line":"from .tabs import LoadBalancerTabs, PoolDetailsTabs, VipDetailsTabs"},{"line_number":33,"context_line":"from .tabs import MemberDetailsTabs, MonitorDetailsTabs"},{"line_number":34,"context_line":"from .tables import DeleteMonitorLink"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FxnA%3D","line":31,"updated":"2013-04-23 19:36:17.000000000","message":"You\u0027re importing from the same file twice. This should just be a continuation of the line above.","commit_id":"44c66d247a3ca5c6dfaace3d2c8c24f1478efa23"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"439e006d547c90bb02ac242a2ae996a91afaf266","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from openstack_dashboard import api"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from .workflows import AddPool, AddMember, AddMonitor, AddVip"},{"line_number":31,"context_line":"from .workflows import UpdatePool"},{"line_number":32,"context_line":"from .tabs import LoadBalancerTabs, PoolDetailsTabs, VipDetailsTabs"},{"line_number":33,"context_line":"from .tabs import MemberDetailsTabs, MonitorDetailsTabs"},{"line_number":34,"context_line":"from .tables import DeleteMonitorLink"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fw0w%3D","line":31,"in_reply_to":"AAAAOn%2F%2FxnA%3D","updated":"2013-04-24 10:02:29.000000000","message":"Done","commit_id":"44c66d247a3ca5c6dfaace3d2c8c24f1478efa23"}],"openstack_dashboard/dashboards/project/loadbalancers/workflows.py":[{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"1a64f9fce7c9553985000e140460af9d1f5f0723","unresolved":false,"context_lines":[{"line_number":512,"context_line":"class UpdatePoolAction(workflows.Action):"},{"line_number":513,"context_line":"    name \u003d forms.CharField(max_length\u003d80, label\u003d_(\"Name\"))"},{"line_number":514,"context_line":"    description \u003d forms.CharField(required\u003dFalse,"},{"line_number":515,"context_line":"        max_length\u003d80, label\u003d_(\"Description\"))"},{"line_number":516,"context_line":"    lb_method \u003d forms.ChoiceField(label\u003d_(\"Load Balancing Method\"))"},{"line_number":517,"context_line":"    admin_state_up \u003d forms.BooleanField(label\u003d_(\"Admin State\"),"},{"line_number":518,"context_line":"                                     initial\u003dTrue, required\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F0DM%3D","line":515,"updated":"2013-04-22 15:16:30.000000000","message":"Not indented correctly.","commit_id":"47630fc4f77982a1cc4aecbb7fc6e040fddb2539"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"d8de6f42eab4ee626564f0f02ed0d7abc79018a5","unresolved":false,"context_lines":[{"line_number":512,"context_line":"class UpdatePoolAction(workflows.Action):"},{"line_number":513,"context_line":"    name \u003d forms.CharField(max_length\u003d80, label\u003d_(\"Name\"))"},{"line_number":514,"context_line":"    description \u003d forms.CharField(required\u003dFalse,"},{"line_number":515,"context_line":"        max_length\u003d80, label\u003d_(\"Description\"))"},{"line_number":516,"context_line":"    lb_method \u003d forms.ChoiceField(label\u003d_(\"Load Balancing Method\"))"},{"line_number":517,"context_line":"    admin_state_up \u003d forms.BooleanField(label\u003d_(\"Admin State\"),"},{"line_number":518,"context_line":"                                     initial\u003dTrue, required\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fysw%3D","line":515,"in_reply_to":"AAAAOn%2F%2F0DM%3D","updated":"2013-04-23 12:04:45.000000000","message":"Done","commit_id":"47630fc4f77982a1cc4aecbb7fc6e040fddb2539"},{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"1a64f9fce7c9553985000e140460af9d1f5f0723","unresolved":false,"context_lines":[{"line_number":515,"context_line":"        max_length\u003d80, label\u003d_(\"Description\"))"},{"line_number":516,"context_line":"    lb_method \u003d forms.ChoiceField(label\u003d_(\"Load Balancing Method\"))"},{"line_number":517,"context_line":"    admin_state_up \u003d forms.BooleanField(label\u003d_(\"Admin State\"),"},{"line_number":518,"context_line":"                                     initial\u003dTrue, required\u003dFalse)"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":521,"context_line":"        super(UpdatePoolAction, self).__init__(request, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F0Cs%3D","line":518,"updated":"2013-04-22 15:16:30.000000000","message":"Again - indentation is not correct.","commit_id":"47630fc4f77982a1cc4aecbb7fc6e040fddb2539"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"d8de6f42eab4ee626564f0f02ed0d7abc79018a5","unresolved":false,"context_lines":[{"line_number":515,"context_line":"        max_length\u003d80, label\u003d_(\"Description\"))"},{"line_number":516,"context_line":"    lb_method \u003d forms.ChoiceField(label\u003d_(\"Load Balancing Method\"))"},{"line_number":517,"context_line":"    admin_state_up \u003d forms.BooleanField(label\u003d_(\"Admin State\"),"},{"line_number":518,"context_line":"                                     initial\u003dTrue, required\u003dFalse)"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":521,"context_line":"        super(UpdatePoolAction, self).__init__(request, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fyss%3D","line":518,"in_reply_to":"AAAAOn%2F%2F0Cs%3D","updated":"2013-04-23 12:04:45.000000000","message":"Done","commit_id":"47630fc4f77982a1cc4aecbb7fc6e040fddb2539"},{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"1a64f9fce7c9553985000e140460af9d1f5f0723","unresolved":false,"context_lines":[{"line_number":525,"context_line":"        self.initial[\u0027lb_method\u0027] \u003d args[0][\u0027pool_lb_method\u0027]"},{"line_number":526,"context_line":"        lb_method_choices \u003d [(\u0027ROUND_ROBIN\u0027, \u0027ROUND_ROBIN\u0027),"},{"line_number":527,"context_line":"                             (\u0027LEAST_CONNECTIONS\u0027, \u0027LEAST_CONNECTIONS\u0027),"},{"line_number":528,"context_line":"                             (\u0027SOURCE_IP\u0027, \u0027SOURCE_IP\u0027)]"},{"line_number":529,"context_line":"        self.fields[\u0027lb_method\u0027].choices \u003d lb_method_choices"},{"line_number":530,"context_line":"        self.fields[\u0027admin_state_up\u0027].initial \u003d args[0][\u0027pool_admin_state_up\u0027]"},{"line_number":531,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F0C0%3D","line":528,"updated":"2013-04-22 15:16:30.000000000","message":"If this is a lookup list, maybe it is better to be added as a module variable, in case it needs to be reused somewhere else. Also, the choices work as [(id, name)]. Does the \u0027name\u0027 also need to be LOWER_CASE, or could be a bit user-friendly instead?","commit_id":"47630fc4f77982a1cc4aecbb7fc6e040fddb2539"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"d8de6f42eab4ee626564f0f02ed0d7abc79018a5","unresolved":false,"context_lines":[{"line_number":525,"context_line":"        self.initial[\u0027lb_method\u0027] \u003d args[0][\u0027pool_lb_method\u0027]"},{"line_number":526,"context_line":"        lb_method_choices \u003d [(\u0027ROUND_ROBIN\u0027, \u0027ROUND_ROBIN\u0027),"},{"line_number":527,"context_line":"                             (\u0027LEAST_CONNECTIONS\u0027, \u0027LEAST_CONNECTIONS\u0027),"},{"line_number":528,"context_line":"                             (\u0027SOURCE_IP\u0027, \u0027SOURCE_IP\u0027)]"},{"line_number":529,"context_line":"        self.fields[\u0027lb_method\u0027].choices \u003d lb_method_choices"},{"line_number":530,"context_line":"        self.fields[\u0027admin_state_up\u0027].initial \u003d args[0][\u0027pool_admin_state_up\u0027]"},{"line_number":531,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fyms%3D","line":528,"in_reply_to":"AAAAOn%2F%2F0C0%3D","updated":"2013-04-23 12:04:45.000000000","message":"This form of choices was used for consistency with the one in AddPoolAction.","commit_id":"47630fc4f77982a1cc4aecbb7fc6e040fddb2539"},{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"1a64f9fce7c9553985000e140460af9d1f5f0723","unresolved":false,"context_lines":[{"line_number":527,"context_line":"                             (\u0027LEAST_CONNECTIONS\u0027, \u0027LEAST_CONNECTIONS\u0027),"},{"line_number":528,"context_line":"                             (\u0027SOURCE_IP\u0027, \u0027SOURCE_IP\u0027)]"},{"line_number":529,"context_line":"        self.fields[\u0027lb_method\u0027].choices \u003d lb_method_choices"},{"line_number":530,"context_line":"        self.fields[\u0027admin_state_up\u0027].initial \u003d args[0][\u0027pool_admin_state_up\u0027]"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"    class Meta:"},{"line_number":533,"context_line":"        name \u003d _(\"PoolDetails\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F0DE%3D","line":530,"updated":"2013-04-22 15:16:30.000000000","message":"The multiple usage of args[0] seems not quite good. Actually the base class - workflows.Action has __init__ declaration as:\n\n        def __init__(self, request, context, *args, **kwargs):\n\nI can\u0027t see a reason why \u0027context\u0027 cannot be used here instead of *args and args[0].","commit_id":"47630fc4f77982a1cc4aecbb7fc6e040fddb2539"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"d8de6f42eab4ee626564f0f02ed0d7abc79018a5","unresolved":false,"context_lines":[{"line_number":527,"context_line":"                             (\u0027LEAST_CONNECTIONS\u0027, \u0027LEAST_CONNECTIONS\u0027),"},{"line_number":528,"context_line":"                             (\u0027SOURCE_IP\u0027, \u0027SOURCE_IP\u0027)]"},{"line_number":529,"context_line":"        self.fields[\u0027lb_method\u0027].choices \u003d lb_method_choices"},{"line_number":530,"context_line":"        self.fields[\u0027admin_state_up\u0027].initial \u003d args[0][\u0027pool_admin_state_up\u0027]"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"    class Meta:"},{"line_number":533,"context_line":"        name \u003d _(\"PoolDetails\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fysk%3D","line":530,"in_reply_to":"AAAAOn%2F%2F0DE%3D","updated":"2013-04-23 12:04:45.000000000","message":"Done","commit_id":"47630fc4f77982a1cc4aecbb7fc6e040fddb2539"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"eece771f2e1ea7c305138ef72c818ffa7e2f7035","unresolved":false,"context_lines":[{"line_number":570,"context_line":"                             \u0027lb_method\u0027: context[\u0027lb_method\u0027],"},{"line_number":571,"context_line":"                             \u0027admin_state_up\u0027: context[\u0027admin_state_up\u0027],"},{"line_number":572,"context_line":"                             }}"},{"line_number":573,"context_line":"            pool \u003d api.lbaas.pool_update(request, context[\u0027pool_id\u0027], **data)"},{"line_number":574,"context_line":"            return True"},{"line_number":575,"context_line":"        except:"},{"line_number":576,"context_line":"            msg \u003d self.format_status_message(self.failure_message)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fy28%3D","line":573,"updated":"2013-04-23 04:59:50.000000000","message":"This should be: \npool \u003d api.lbaas.pool_update(request, context[\u0027pool_id\u0027], **context)\n\nThe logic of creating the pool object structure should go into api.lbaas.pool_update().\n\nYou can check api_tests/lbaas_test.py - test_pool_update() on how the method is intended to be used.","commit_id":"47630fc4f77982a1cc4aecbb7fc6e040fddb2539"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"d8de6f42eab4ee626564f0f02ed0d7abc79018a5","unresolved":false,"context_lines":[{"line_number":570,"context_line":"                             \u0027lb_method\u0027: context[\u0027lb_method\u0027],"},{"line_number":571,"context_line":"                             \u0027admin_state_up\u0027: context[\u0027admin_state_up\u0027],"},{"line_number":572,"context_line":"                             }}"},{"line_number":573,"context_line":"            pool \u003d api.lbaas.pool_update(request, context[\u0027pool_id\u0027], **data)"},{"line_number":574,"context_line":"            return True"},{"line_number":575,"context_line":"        except:"},{"line_number":576,"context_line":"            msg \u003d self.format_status_message(self.failure_message)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fydc%3D","line":573,"in_reply_to":"AAAAOn%2F%2Fy28%3D","updated":"2013-04-23 12:04:45.000000000","message":"The data dict doesn\u0027t contain the pool id argument in test_pool_update(). But here context does, and pool_update() method would get multiple values for keyword argument \u0027pool_id\u0027.","commit_id":"47630fc4f77982a1cc4aecbb7fc6e040fddb2539"},{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"1a64f9fce7c9553985000e140460af9d1f5f0723","unresolved":false,"context_lines":[{"line_number":577,"context_line":"            exceptions.handle(request, msg)"},{"line_number":578,"context_line":"            return False"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        try:"},{"line_number":581,"context_line":"            pool \u003d api.lbaas.pool_get(request, context[\u0027pool_id\u0027])"},{"line_number":582,"context_line":"            context[\u0027pool_name\u0027] \u003d pool[\u0027name\u0027]"},{"line_number":583,"context_line":"            context[\u0027pool_description\u0027] \u003d pool[\u0027description\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F0B8%3D","line":580,"updated":"2013-04-22 15:16:30.000000000","message":"In which case the code below will be reached and executed? I see \u0027return\u0027 clause in both \u0027try\u0027 and \u0027except\u0027 above.","commit_id":"47630fc4f77982a1cc4aecbb7fc6e040fddb2539"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"d8de6f42eab4ee626564f0f02ed0d7abc79018a5","unresolved":false,"context_lines":[{"line_number":577,"context_line":"            exceptions.handle(request, msg)"},{"line_number":578,"context_line":"            return False"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        try:"},{"line_number":581,"context_line":"            pool \u003d api.lbaas.pool_get(request, context[\u0027pool_id\u0027])"},{"line_number":582,"context_line":"            context[\u0027pool_name\u0027] \u003d pool[\u0027name\u0027]"},{"line_number":583,"context_line":"            context[\u0027pool_description\u0027] \u003d pool[\u0027description\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fye4%3D","line":580,"in_reply_to":"AAAAOn%2F%2F0B8%3D","updated":"2013-04-23 12:04:45.000000000","message":"Done","commit_id":"47630fc4f77982a1cc4aecbb7fc6e040fddb2539"}]}