)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3190e183592c362f5354daab7b9a487034f3f990","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add feature to log an operation of users to Horizon"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To enable this feature, you do some step below."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"1. You merge the change which is done by this patch to"},{"line_number":12,"context_line":"   local_settings.py."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7af24918_61427eaf","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":47},"updated":"2016-03-04 14:37:36.000000000","message":"This kind of instruction should be documented in the devref.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add feature to log an operation of users to Horizon"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To enable this feature, you do some step below."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"1. You merge the change which is done by this patch to"},{"line_number":12,"context_line":"   local_settings.py."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa0719c6_f0a3ab9c","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":47},"in_reply_to":"7af24918_61427eaf","updated":"2016-03-22 02:20:42.000000000","message":"Done. I added the release notes file and wrote these information.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"22e383e3a7acfeb646d1f37381e653965039298b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kenji Ishii \u003cken-ishii@sx.jp.nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-24 06:47:48 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add feature to log an operation of users to Horizon"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To enable this feature, you can see the release notes on this patch."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"da0c15f0_f508dd93","line":7,"range":{"start_line":7,"start_character":19,"end_line":7,"end_character":31},"updated":"2016-03-25 09:55:46.000000000","message":"-\u003e operations","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"703d22ee0bf65df2195febbbc4991c40232eeae0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kenji Ishii \u003cken-ishii@sx.jp.nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-24 06:47:48 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add feature to log an operation of users to Horizon"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To enable this feature, you can see the release notes on this patch."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"da0c15f0_5e109ca8","line":7,"range":{"start_line":7,"start_character":19,"end_line":7,"end_character":31},"in_reply_to":"da0c15f0_f508dd93","updated":"2016-03-27 02:47:26.000000000","message":"Done","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"22e383e3a7acfeb646d1f37381e653965039298b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add feature to log an operation of users to Horizon"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To enable this feature, you can see the release notes on this patch."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I784b92104be244f7f288d7648c20e61e0a0c1d09"},{"line_number":12,"context_line":"Implements: blueprint operation-history-log"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"da0c15f0_b5d8251f","line":9,"range":{"start_line":9,"start_character":24,"end_line":9,"end_character":68},"updated":"2016-03-25 09:55:46.000000000","message":"The detail should be described in the document (not in the release note). Could you add a content about this feature to the devref document?","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"703d22ee0bf65df2195febbbc4991c40232eeae0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add feature to log an operation of users to Horizon"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To enable this feature, you can see the release notes on this patch."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I784b92104be244f7f288d7648c20e61e0a0c1d09"},{"line_number":12,"context_line":"Implements: blueprint operation-history-log"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"da0c15f0_fe4ff0ba","line":9,"range":{"start_line":9,"start_character":24,"end_line":9,"end_character":68},"in_reply_to":"da0c15f0_b5d8251f","updated":"2016-03-27 02:47:26.000000000","message":"Done. I added the explanation regarding this feature to rst as the address to devref, if my understanding is wrong, please let me know.","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"}],"doc/source/topics/settings.rst":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"408d8fbf7105eb7fa5c96ab5ace9b72657544ee2","unresolved":false,"context_lines":[{"line_number":1489,"context_line":"Can be used to selectively disable certain costly extensions for performance"},{"line_number":1490,"context_line":"reasons."},{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":""},{"line_number":1493,"context_line":"``OPERATION_LOG_ENABLED``"},{"line_number":1494,"context_line":"-------------------------"},{"line_number":1495,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"7a1b2928_c05b5653","line":1492,"updated":"2016-04-20 13:17:37.000000000","message":"I don\u0027t think it is a part of openstack_dashboard.\nIsn\u0027t it a part of horizon?","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"24a2fc83201d020e73dff3be32294ea1a285c97b","unresolved":false,"context_lines":[{"line_number":1489,"context_line":"Can be used to selectively disable certain costly extensions for performance"},{"line_number":1490,"context_line":"reasons."},{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":""},{"line_number":1493,"context_line":"``OPERATION_LOG_ENABLED``"},{"line_number":1494,"context_line":"-------------------------"},{"line_number":1495,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"dab17558_260655ce","line":1492,"in_reply_to":"1a122d0e_a2054e7a","updated":"2016-05-10 04:48:09.000000000","message":"Yes, I agree with you. we should improve this issue as an another patch.","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f580a3ddecc6285a959c1da98d8b5bbb81b87b4f","unresolved":false,"context_lines":[{"line_number":1489,"context_line":"Can be used to selectively disable certain costly extensions for performance"},{"line_number":1490,"context_line":"reasons."},{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":""},{"line_number":1493,"context_line":"``OPERATION_LOG_ENABLED``"},{"line_number":1494,"context_line":"-------------------------"},{"line_number":1495,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"1a122d0e_a2054e7a","line":1492,"in_reply_to":"1a122d0e_b67bfd28","updated":"2016-05-04 03:17:42.000000000","message":"I think you are right.\n\nOn the other hand, there is no section for settings defined in \u0027horizon\u0027  in the current horizon :-(   It needs to be improved but it is a separate issue.","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"700bb0862facba06816678221c8297f171ee71af","unresolved":false,"context_lines":[{"line_number":1489,"context_line":"Can be used to selectively disable certain costly extensions for performance"},{"line_number":1490,"context_line":"reasons."},{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":""},{"line_number":1493,"context_line":"``OPERATION_LOG_ENABLED``"},{"line_number":1494,"context_line":"-------------------------"},{"line_number":1495,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"1a122d0e_b67bfd28","line":1492,"in_reply_to":"7a1b2928_c05b5653","updated":"2016-05-02 01:50:44.000000000","message":"A part of horizon is the case that we define as \u0027HORIZON_CONFIG\u0027.\n\nAt the moment, horizon is using not settings of \u0027HORIZON_CONFIG\u0027 but also others settings which defined as a part of openstack_dashboard.\n\nTherefore I thought \u0027HORIZON_CONFIG\u0027 is used to define fundamental settings like queue limit, bug_url and so on. and in other cases like any function, I thought we define its settings as a part of openstack_dashboard.\n\nIs my understanding wrong?","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"408d8fbf7105eb7fa5c96ab5ace9b72657544ee2","unresolved":false,"context_lines":[{"line_number":1500,"context_line":"This setting can be used to log operations of all of users on Horizon."},{"line_number":1501,"context_line":"In this log, it can include a operation date, time, a operator information"},{"line_number":1502,"context_line":"such as a domain, project, user and a operation url and so on."},{"line_number":1503,"context_line":"And this log format is configurable. In detail, you can see OPERATION_LOG_OPTION."},{"line_number":1504,"context_line":""},{"line_number":1505,"context_line":".. note::"},{"line_number":1506,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"7a1b2928_e302dc3d","line":1503,"updated":"2016-04-20 13:17:37.000000000","message":"one question: can we configure the log filename of the operation log?\nI think it is worth customized.","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"700bb0862facba06816678221c8297f171ee71af","unresolved":false,"context_lines":[{"line_number":1500,"context_line":"This setting can be used to log operations of all of users on Horizon."},{"line_number":1501,"context_line":"In this log, it can include a operation date, time, a operator information"},{"line_number":1502,"context_line":"such as a domain, project, user and a operation url and so on."},{"line_number":1503,"context_line":"And this log format is configurable. In detail, you can see OPERATION_LOG_OPTION."},{"line_number":1504,"context_line":""},{"line_number":1505,"context_line":".. note::"},{"line_number":1506,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"1a122d0e_03fc353d","line":1503,"in_reply_to":"7a1b2928_e302dc3d","updated":"2016-05-02 01:50:44.000000000","message":"Yes, its filename can be customized.","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"408d8fbf7105eb7fa5c96ab5ace9b72657544ee2","unresolved":false,"context_lines":[{"line_number":1508,"context_line":"  a outputting path for operation log in ``local_settings.py``."},{"line_number":1509,"context_line":""},{"line_number":1510,"context_line":""},{"line_number":1511,"context_line":"``OPERATION_LOG_OPTION``"},{"line_number":1512,"context_line":"------------------------"},{"line_number":1513,"context_line":""},{"line_number":1514,"context_line":".. versionadded:: 10.0.0(Newton)"}],"source_content_type":"text/x-rst","patch_set":17,"id":"7a1b2928_a3caa49f","line":1511,"range":{"start_line":1511,"start_character":16,"end_line":1511,"end_character":23},"updated":"2016-04-20 13:17:37.000000000","message":"OPTION -\u003e OPTIONS","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"700bb0862facba06816678221c8297f171ee71af","unresolved":false,"context_lines":[{"line_number":1508,"context_line":"  a outputting path for operation log in ``local_settings.py``."},{"line_number":1509,"context_line":""},{"line_number":1510,"context_line":""},{"line_number":1511,"context_line":"``OPERATION_LOG_OPTION``"},{"line_number":1512,"context_line":"------------------------"},{"line_number":1513,"context_line":""},{"line_number":1514,"context_line":".. versionadded:: 10.0.0(Newton)"}],"source_content_type":"text/x-rst","patch_set":17,"id":"1a122d0e_43946de7","line":1511,"range":{"start_line":1511,"start_character":16,"end_line":1511,"end_character":23},"in_reply_to":"7a1b2928_a3caa49f","updated":"2016-05-02 01:50:44.000000000","message":"Done","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"408d8fbf7105eb7fa5c96ab5ace9b72657544ee2","unresolved":false,"context_lines":[{"line_number":1524,"context_line":"             \" [%(http_status)s] [%(param)s]\"),"},{"line_number":1525,"context_line":"        }"},{"line_number":1526,"context_line":""},{"line_number":1527,"context_line":"This setting can be used as a option when you log the operation log."},{"line_number":1528,"context_line":"``mask_fields`` is a key of a post data to mask a value. In security viewpoint,"},{"line_number":1529,"context_line":"if you would like to mask some data like password, you can use this."},{"line_number":1530,"context_line":"The value which is specified as a mask data is logged as \u0027********\u0027"}],"source_content_type":"text/x-rst","patch_set":17,"id":"7a1b2928_a3262466","line":1527,"updated":"2016-04-20 13:17:37.000000000","message":"This setting controls the behavior of the operation log.","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"700bb0862facba06816678221c8297f171ee71af","unresolved":false,"context_lines":[{"line_number":1524,"context_line":"             \" [%(http_status)s] [%(param)s]\"),"},{"line_number":1525,"context_line":"        }"},{"line_number":1526,"context_line":""},{"line_number":1527,"context_line":"This setting can be used as a option when you log the operation log."},{"line_number":1528,"context_line":"``mask_fields`` is a key of a post data to mask a value. In security viewpoint,"},{"line_number":1529,"context_line":"if you would like to mask some data like password, you can use this."},{"line_number":1530,"context_line":"The value which is specified as a mask data is logged as \u0027********\u0027"}],"source_content_type":"text/x-rst","patch_set":17,"id":"1a122d0e_d9ed0af1","line":1527,"in_reply_to":"7a1b2928_a3262466","updated":"2016-05-02 01:50:44.000000000","message":"Done","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"408d8fbf7105eb7fa5c96ab5ace9b72657544ee2","unresolved":false,"context_lines":[{"line_number":1526,"context_line":""},{"line_number":1527,"context_line":"This setting can be used as a option when you log the operation log."},{"line_number":1528,"context_line":"``mask_fields`` is a key of a post data to mask a value. In security viewpoint,"},{"line_number":1529,"context_line":"if you would like to mask some data like password, you can use this."},{"line_number":1530,"context_line":"The value which is specified as a mask data is logged as \u0027********\u0027"},{"line_number":1531,"context_line":"``target_methods`` is a request method which is logged to a operation log."},{"line_number":1532,"context_line":"It can be specified ``POST`` or ``GET``."}],"source_content_type":"text/x-rst","patch_set":17,"id":"7a1b2928_e3a3fc9c","line":1529,"updated":"2016-04-20 13:17:37.000000000","message":"``mask_fields`` is a list of keys of post data which should be masked from the point of view of security. Fields like ``password`` should be included.","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"700bb0862facba06816678221c8297f171ee71af","unresolved":false,"context_lines":[{"line_number":1526,"context_line":""},{"line_number":1527,"context_line":"This setting can be used as a option when you log the operation log."},{"line_number":1528,"context_line":"``mask_fields`` is a key of a post data to mask a value. In security viewpoint,"},{"line_number":1529,"context_line":"if you would like to mask some data like password, you can use this."},{"line_number":1530,"context_line":"The value which is specified as a mask data is logged as \u0027********\u0027"},{"line_number":1531,"context_line":"``target_methods`` is a request method which is logged to a operation log."},{"line_number":1532,"context_line":"It can be specified ``POST`` or ``GET``."}],"source_content_type":"text/x-rst","patch_set":17,"id":"1a122d0e_4330ed07","line":1529,"in_reply_to":"7a1b2928_e3a3fc9c","updated":"2016-05-02 01:50:44.000000000","message":"Done","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"408d8fbf7105eb7fa5c96ab5ace9b72657544ee2","unresolved":false,"context_lines":[{"line_number":1527,"context_line":"This setting can be used as a option when you log the operation log."},{"line_number":1528,"context_line":"``mask_fields`` is a key of a post data to mask a value. In security viewpoint,"},{"line_number":1529,"context_line":"if you would like to mask some data like password, you can use this."},{"line_number":1530,"context_line":"The value which is specified as a mask data is logged as \u0027********\u0027"},{"line_number":1531,"context_line":"``target_methods`` is a request method which is logged to a operation log."},{"line_number":1532,"context_line":"It can be specified ``POST`` or ``GET``."},{"line_number":1533,"context_line":"``format`` is the operation log format. You can outputting data below.::"}],"source_content_type":"text/x-rst","patch_set":17,"id":"7a1b2928_c33c0032","line":1530,"updated":"2016-04-20 13:17:37.000000000","message":"The fields specified in ``mask_fields`` are logged as ....","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"700bb0862facba06816678221c8297f171ee71af","unresolved":false,"context_lines":[{"line_number":1527,"context_line":"This setting can be used as a option when you log the operation log."},{"line_number":1528,"context_line":"``mask_fields`` is a key of a post data to mask a value. In security viewpoint,"},{"line_number":1529,"context_line":"if you would like to mask some data like password, you can use this."},{"line_number":1530,"context_line":"The value which is specified as a mask data is logged as \u0027********\u0027"},{"line_number":1531,"context_line":"``target_methods`` is a request method which is logged to a operation log."},{"line_number":1532,"context_line":"It can be specified ``POST`` or ``GET``."},{"line_number":1533,"context_line":"``format`` is the operation log format. You can outputting data below.::"}],"source_content_type":"text/x-rst","patch_set":17,"id":"1a122d0e_0358b555","line":1530,"in_reply_to":"7a1b2928_c33c0032","updated":"2016-05-02 01:50:44.000000000","message":"Done","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"408d8fbf7105eb7fa5c96ab5ace9b72657544ee2","unresolved":false,"context_lines":[{"line_number":1529,"context_line":"if you would like to mask some data like password, you can use this."},{"line_number":1530,"context_line":"The value which is specified as a mask data is logged as \u0027********\u0027"},{"line_number":1531,"context_line":"``target_methods`` is a request method which is logged to a operation log."},{"line_number":1532,"context_line":"It can be specified ``POST`` or ``GET``."},{"line_number":1533,"context_line":"``format`` is the operation log format. You can outputting data below.::"},{"line_number":1534,"context_line":""},{"line_number":1535,"context_line":"        %(domain_name)s"}],"source_content_type":"text/x-rst","patch_set":17,"id":"7a1b2928_23ab341f","line":1532,"range":{"start_line":1532,"start_character":0,"end_line":1532,"end_character":40},"updated":"2016-04-20 13:17:37.000000000","message":"Suggestion:\n\n  The available values are ``POST`` or ``GET``.\n\nQuestion: why don\u0027t you support other methods?","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"700bb0862facba06816678221c8297f171ee71af","unresolved":false,"context_lines":[{"line_number":1529,"context_line":"if you would like to mask some data like password, you can use this."},{"line_number":1530,"context_line":"The value which is specified as a mask data is logged as \u0027********\u0027"},{"line_number":1531,"context_line":"``target_methods`` is a request method which is logged to a operation log."},{"line_number":1532,"context_line":"It can be specified ``POST`` or ``GET``."},{"line_number":1533,"context_line":"``format`` is the operation log format. You can outputting data below.::"},{"line_number":1534,"context_line":""},{"line_number":1535,"context_line":"        %(domain_name)s"}],"source_content_type":"text/x-rst","patch_set":17,"id":"1a122d0e_d8d9cd23","line":1532,"range":{"start_line":1532,"start_character":0,"end_line":1532,"end_character":40},"in_reply_to":"7a1b2928_23ab341f","updated":"2016-05-02 01:50:44.000000000","message":"Yes, there is no reason to restrict methods, so I\u0027ll address it.","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"408d8fbf7105eb7fa5c96ab5ace9b72657544ee2","unresolved":false,"context_lines":[{"line_number":1530,"context_line":"The value which is specified as a mask data is logged as \u0027********\u0027"},{"line_number":1531,"context_line":"``target_methods`` is a request method which is logged to a operation log."},{"line_number":1532,"context_line":"It can be specified ``POST`` or ``GET``."},{"line_number":1533,"context_line":"``format`` is the operation log format. You can outputting data below.::"},{"line_number":1534,"context_line":""},{"line_number":1535,"context_line":"        %(domain_name)s"},{"line_number":1536,"context_line":"        %(domain_id)s"}],"source_content_type":"text/x-rst","patch_set":17,"id":"7a1b2928_2e1e7b63","line":1533,"range":{"start_line":1533,"start_character":40,"end_line":1533,"end_character":72},"updated":"2016-04-20 13:17:37.000000000","message":"I would suggest:\n\n Currently you can use the following keywords::\n\nNote that a period is unnecessary in this case.","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"408d8fbf7105eb7fa5c96ab5ace9b72657544ee2","unresolved":false,"context_lines":[{"line_number":1530,"context_line":"The value which is specified as a mask data is logged as \u0027********\u0027"},{"line_number":1531,"context_line":"``target_methods`` is a request method which is logged to a operation log."},{"line_number":1532,"context_line":"It can be specified ``POST`` or ``GET``."},{"line_number":1533,"context_line":"``format`` is the operation log format. You can outputting data below.::"},{"line_number":1534,"context_line":""},{"line_number":1535,"context_line":"        %(domain_name)s"},{"line_number":1536,"context_line":"        %(domain_id)s"}],"source_content_type":"text/x-rst","patch_set":17,"id":"7a1b2928_434f5092","line":1533,"range":{"start_line":1533,"start_character":11,"end_line":1533,"end_character":13},"updated":"2016-04-20 13:17:37.000000000","message":"is -\u003e defines","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"700bb0862facba06816678221c8297f171ee71af","unresolved":false,"context_lines":[{"line_number":1530,"context_line":"The value which is specified as a mask data is logged as \u0027********\u0027"},{"line_number":1531,"context_line":"``target_methods`` is a request method which is logged to a operation log."},{"line_number":1532,"context_line":"It can be specified ``POST`` or ``GET``."},{"line_number":1533,"context_line":"``format`` is the operation log format. You can outputting data below.::"},{"line_number":1534,"context_line":""},{"line_number":1535,"context_line":"        %(domain_name)s"},{"line_number":1536,"context_line":"        %(domain_id)s"}],"source_content_type":"text/x-rst","patch_set":17,"id":"1a122d0e_2335f1f6","line":1533,"range":{"start_line":1533,"start_character":40,"end_line":1533,"end_character":72},"in_reply_to":"7a1b2928_2e1e7b63","updated":"2016-05-02 01:50:44.000000000","message":"Done","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"700bb0862facba06816678221c8297f171ee71af","unresolved":false,"context_lines":[{"line_number":1530,"context_line":"The value which is specified as a mask data is logged as \u0027********\u0027"},{"line_number":1531,"context_line":"``target_methods`` is a request method which is logged to a operation log."},{"line_number":1532,"context_line":"It can be specified ``POST`` or ``GET``."},{"line_number":1533,"context_line":"``format`` is the operation log format. You can outputting data below.::"},{"line_number":1534,"context_line":""},{"line_number":1535,"context_line":"        %(domain_name)s"},{"line_number":1536,"context_line":"        %(domain_id)s"}],"source_content_type":"text/x-rst","patch_set":17,"id":"1a122d0e_032f15a2","line":1533,"range":{"start_line":1533,"start_character":11,"end_line":1533,"end_character":13},"in_reply_to":"7a1b2928_434f5092","updated":"2016-05-02 01:50:44.000000000","message":"Done","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a14f3187df27b11316e1d66fd61e5fc1123ad53e","unresolved":false,"context_lines":[{"line_number":1551,"context_line":"Default: ``False``"},{"line_number":1552,"context_line":""},{"line_number":1553,"context_line":"This setting can be used to log operations of all of users on Horizon."},{"line_number":1554,"context_line":"In this log, it can include a operation date, time, a operator information"},{"line_number":1555,"context_line":"such as a domain, project, user and a operation url and so on."},{"line_number":1556,"context_line":"And this log format is configurable. In detail, you can see OPERATION_LOG_OPTION."},{"line_number":1557,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"1a122d0e_8705c415","line":1554,"range":{"start_line":1554,"start_character":54,"end_line":1554,"end_character":62},"updated":"2016-05-04 03:19:31.000000000","message":"operator usually associates \u0027administrator\u0027.\nI would suggest \u0027user information\u0027 instead.","commit_id":"f6b19aa848afa5f5ebf3aaab3fccbd221a9750be"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"185aa0f8258dd6f12ba0a8cb086db75741b05478","unresolved":false,"context_lines":[{"line_number":1551,"context_line":"Default: ``False``"},{"line_number":1552,"context_line":""},{"line_number":1553,"context_line":"This setting can be used to log operations of all of users on Horizon."},{"line_number":1554,"context_line":"In this log, it can include a operation date, time, a operator information"},{"line_number":1555,"context_line":"such as a domain, project, user and a operation url and so on."},{"line_number":1556,"context_line":"And this log format is configurable. In detail, you can see OPERATION_LOG_OPTION."},{"line_number":1557,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"dab17558_e6c9ed79","line":1554,"range":{"start_line":1554,"start_character":54,"end_line":1554,"end_character":62},"in_reply_to":"1a122d0e_8705c415","updated":"2016-05-10 04:50:01.000000000","message":"Done","commit_id":"f6b19aa848afa5f5ebf3aaab3fccbd221a9750be"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a14f3187df27b11316e1d66fd61e5fc1123ad53e","unresolved":false,"context_lines":[{"line_number":1552,"context_line":""},{"line_number":1553,"context_line":"This setting can be used to log operations of all of users on Horizon."},{"line_number":1554,"context_line":"In this log, it can include a operation date, time, a operator information"},{"line_number":1555,"context_line":"such as a domain, project, user and a operation url and so on."},{"line_number":1556,"context_line":"And this log format is configurable. In detail, you can see OPERATION_LOG_OPTION."},{"line_number":1557,"context_line":""},{"line_number":1558,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":19,"id":"1a122d0e_622e968d","line":1555,"updated":"2016-05-04 03:19:31.000000000","message":"double \u0027and\u0027 looks tricky.\nHow about:\n\n  date and time of an operation, an operation URL,\n  user information such as domain, project and user, and so on.","commit_id":"f6b19aa848afa5f5ebf3aaab3fccbd221a9750be"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"185aa0f8258dd6f12ba0a8cb086db75741b05478","unresolved":false,"context_lines":[{"line_number":1552,"context_line":""},{"line_number":1553,"context_line":"This setting can be used to log operations of all of users on Horizon."},{"line_number":1554,"context_line":"In this log, it can include a operation date, time, a operator information"},{"line_number":1555,"context_line":"such as a domain, project, user and a operation url and so on."},{"line_number":1556,"context_line":"And this log format is configurable. In detail, you can see OPERATION_LOG_OPTION."},{"line_number":1557,"context_line":""},{"line_number":1558,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":19,"id":"dab17558_e6c56d3c","line":1555,"in_reply_to":"1a122d0e_622e968d","updated":"2016-05-10 04:50:01.000000000","message":"Done","commit_id":"f6b19aa848afa5f5ebf3aaab3fccbd221a9750be"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a14f3187df27b11316e1d66fd61e5fc1123ad53e","unresolved":false,"context_lines":[{"line_number":1553,"context_line":"This setting can be used to log operations of all of users on Horizon."},{"line_number":1554,"context_line":"In this log, it can include a operation date, time, a operator information"},{"line_number":1555,"context_line":"such as a domain, project, user and a operation url and so on."},{"line_number":1556,"context_line":"And this log format is configurable. In detail, you can see OPERATION_LOG_OPTION."},{"line_number":1557,"context_line":""},{"line_number":1558,"context_line":".. note::"},{"line_number":1559,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"1a122d0e_a24eee6b","line":1556,"updated":"2016-05-04 03:19:31.000000000","message":"LOG_OPTIONS?","commit_id":"f6b19aa848afa5f5ebf3aaab3fccbd221a9750be"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"185aa0f8258dd6f12ba0a8cb086db75741b05478","unresolved":false,"context_lines":[{"line_number":1553,"context_line":"This setting can be used to log operations of all of users on Horizon."},{"line_number":1554,"context_line":"In this log, it can include a operation date, time, a operator information"},{"line_number":1555,"context_line":"such as a domain, project, user and a operation url and so on."},{"line_number":1556,"context_line":"And this log format is configurable. In detail, you can see OPERATION_LOG_OPTION."},{"line_number":1557,"context_line":""},{"line_number":1558,"context_line":".. note::"},{"line_number":1559,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"dab17558_c6c0292d","line":1556,"in_reply_to":"1a122d0e_a24eee6b","updated":"2016-05-10 04:50:01.000000000","message":"Done","commit_id":"f6b19aa848afa5f5ebf3aaab3fccbd221a9750be"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"77b438df30e04b225450466fb3a4a495450eb134","unresolved":false,"context_lines":[{"line_number":1589,"context_line":"             \" [%(http_status)s] [%(param)s]\"),"},{"line_number":1590,"context_line":"        }"},{"line_number":1591,"context_line":""},{"line_number":1592,"context_line":"This setting controls the behavior of the operation log."},{"line_number":1593,"context_line":"``mask_fields`` is a list of keys of post data which should be masked from the"},{"line_number":1594,"context_line":"point of view of security. Fields like ``password`` should be included."},{"line_number":1595,"context_line":"The fields specified in ``mask_fields`` are logged as \u0027********\u0027"}],"source_content_type":"text/x-rst","patch_set":20,"id":"bab6814e_377e1e6a","line":1592,"updated":"2016-05-23 13:02:21.000000000","message":"I would suggest to use a list to explain individual options:\n\n  * ``mask_fields`` is a list of ...\n  * ``target_methods`` is a request ...\n  * ``format`` defines ....","commit_id":"c67d557544551f5bdc88d29e641e4429fe7eca3e"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"08cce71d5e1bab8c562c45e339b21cd39fe44bec","unresolved":false,"context_lines":[{"line_number":1589,"context_line":"             \" [%(http_status)s] [%(param)s]\"),"},{"line_number":1590,"context_line":"        }"},{"line_number":1591,"context_line":""},{"line_number":1592,"context_line":"This setting controls the behavior of the operation log."},{"line_number":1593,"context_line":"``mask_fields`` is a list of keys of post data which should be masked from the"},{"line_number":1594,"context_line":"point of view of security. Fields like ``password`` should be included."},{"line_number":1595,"context_line":"The fields specified in ``mask_fields`` are logged as \u0027********\u0027"}],"source_content_type":"text/x-rst","patch_set":20,"id":"bab6814e_ebb48ad5","line":1592,"in_reply_to":"bab6814e_377e1e6a","updated":"2016-05-24 02:01:07.000000000","message":"Done","commit_id":"c67d557544551f5bdc88d29e641e4429fe7eca3e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"77b438df30e04b225450466fb3a4a495450eb134","unresolved":false,"context_lines":[{"line_number":1592,"context_line":"This setting controls the behavior of the operation log."},{"line_number":1593,"context_line":"``mask_fields`` is a list of keys of post data which should be masked from the"},{"line_number":1594,"context_line":"point of view of security. Fields like ``password`` should be included."},{"line_number":1595,"context_line":"The fields specified in ``mask_fields`` are logged as \u0027********\u0027"},{"line_number":1596,"context_line":"``target_methods`` is a request method which is logged to a operation log."},{"line_number":1597,"context_line":"It can be specified ``POST``, ``GET``, ``PUT``, ``DELETE``."},{"line_number":1598,"context_line":"``format`` defines the operation log format."}],"source_content_type":"text/x-rst","patch_set":20,"id":"bab6814e_b4004c03","line":1595,"range":{"start_line":1595,"start_character":54,"end_line":1595,"end_character":64},"updated":"2016-05-23 13:02:21.000000000","message":"I see eight stars here, but after rendered I see only four stars [1].\nI think you need to quote the string with double backqutoes:\n\n  ``********``\n\nIn addition, a period is required at the end of line.\n\n[1] http://docs-draft.openstack.org/35/272935/20/check/gate-horizon-docs/95ead92//doc/build/html/topics/settings.html#operation-log-options","commit_id":"c67d557544551f5bdc88d29e641e4429fe7eca3e"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"08cce71d5e1bab8c562c45e339b21cd39fe44bec","unresolved":false,"context_lines":[{"line_number":1592,"context_line":"This setting controls the behavior of the operation log."},{"line_number":1593,"context_line":"``mask_fields`` is a list of keys of post data which should be masked from the"},{"line_number":1594,"context_line":"point of view of security. Fields like ``password`` should be included."},{"line_number":1595,"context_line":"The fields specified in ``mask_fields`` are logged as \u0027********\u0027"},{"line_number":1596,"context_line":"``target_methods`` is a request method which is logged to a operation log."},{"line_number":1597,"context_line":"It can be specified ``POST``, ``GET``, ``PUT``, ``DELETE``."},{"line_number":1598,"context_line":"``format`` defines the operation log format."}],"source_content_type":"text/x-rst","patch_set":20,"id":"bab6814e_eb02ca71","line":1595,"range":{"start_line":1595,"start_character":54,"end_line":1595,"end_character":64},"in_reply_to":"bab6814e_b4004c03","updated":"2016-05-24 02:01:07.000000000","message":"Done","commit_id":"c67d557544551f5bdc88d29e641e4429fe7eca3e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"77b438df30e04b225450466fb3a4a495450eb134","unresolved":false,"context_lines":[{"line_number":1594,"context_line":"point of view of security. Fields like ``password`` should be included."},{"line_number":1595,"context_line":"The fields specified in ``mask_fields`` are logged as \u0027********\u0027"},{"line_number":1596,"context_line":"``target_methods`` is a request method which is logged to a operation log."},{"line_number":1597,"context_line":"It can be specified ``POST``, ``GET``, ``PUT``, ``DELETE``."},{"line_number":1598,"context_line":"``format`` defines the operation log format."},{"line_number":1599,"context_line":"Currently you can use the following keywords::"},{"line_number":1600,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"bab6814e_f7d5b642","line":1597,"range":{"start_line":1597,"start_character":0,"end_line":1597,"end_character":19},"updated":"2016-05-23 13:02:21.000000000","message":"-\u003e The valid methods are","commit_id":"c67d557544551f5bdc88d29e641e4429fe7eca3e"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"08cce71d5e1bab8c562c45e339b21cd39fe44bec","unresolved":false,"context_lines":[{"line_number":1594,"context_line":"point of view of security. Fields like ``password`` should be included."},{"line_number":1595,"context_line":"The fields specified in ``mask_fields`` are logged as \u0027********\u0027"},{"line_number":1596,"context_line":"``target_methods`` is a request method which is logged to a operation log."},{"line_number":1597,"context_line":"It can be specified ``POST``, ``GET``, ``PUT``, ``DELETE``."},{"line_number":1598,"context_line":"``format`` defines the operation log format."},{"line_number":1599,"context_line":"Currently you can use the following keywords::"},{"line_number":1600,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"bab6814e_abf1e297","line":1597,"range":{"start_line":1597,"start_character":0,"end_line":1597,"end_character":19},"in_reply_to":"bab6814e_f7d5b642","updated":"2016-05-24 02:01:07.000000000","message":"Done","commit_id":"c67d557544551f5bdc88d29e641e4429fe7eca3e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"77b438df30e04b225450466fb3a4a495450eb134","unresolved":false,"context_lines":[{"line_number":1596,"context_line":"``target_methods`` is a request method which is logged to a operation log."},{"line_number":1597,"context_line":"It can be specified ``POST``, ``GET``, ``PUT``, ``DELETE``."},{"line_number":1598,"context_line":"``format`` defines the operation log format."},{"line_number":1599,"context_line":"Currently you can use the following keywords::"},{"line_number":1600,"context_line":""},{"line_number":1601,"context_line":"        %(domain_name)s"},{"line_number":1602,"context_line":"        %(domain_id)s"}],"source_content_type":"text/x-rst","patch_set":20,"id":"bab6814e_17083ad9","line":1599,"updated":"2016-05-23 13:02:21.000000000","message":"I\u0027d suggest to add:\n\n  The default value contains all keywords.","commit_id":"c67d557544551f5bdc88d29e641e4429fe7eca3e"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"08cce71d5e1bab8c562c45e339b21cd39fe44bec","unresolved":false,"context_lines":[{"line_number":1596,"context_line":"``target_methods`` is a request method which is logged to a operation log."},{"line_number":1597,"context_line":"It can be specified ``POST``, ``GET``, ``PUT``, ``DELETE``."},{"line_number":1598,"context_line":"``format`` defines the operation log format."},{"line_number":1599,"context_line":"Currently you can use the following keywords::"},{"line_number":1600,"context_line":""},{"line_number":1601,"context_line":"        %(domain_name)s"},{"line_number":1602,"context_line":"        %(domain_id)s"}],"source_content_type":"text/x-rst","patch_set":20,"id":"bab6814e_cb2ee6f9","line":1599,"in_reply_to":"bab6814e_17083ad9","updated":"2016-05-24 02:01:07.000000000","message":"Done","commit_id":"c67d557544551f5bdc88d29e641e4429fe7eca3e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"77b438df30e04b225450466fb3a4a495450eb134","unresolved":false,"context_lines":[{"line_number":1598,"context_line":"``format`` defines the operation log format."},{"line_number":1599,"context_line":"Currently you can use the following keywords::"},{"line_number":1600,"context_line":""},{"line_number":1601,"context_line":"        %(domain_name)s"},{"line_number":1602,"context_line":"        %(domain_id)s"},{"line_number":1603,"context_line":"        %(project_name)s"},{"line_number":1604,"context_line":"        %(project_id)s"},{"line_number":1605,"context_line":"        %(user_name)s"},{"line_number":1606,"context_line":"        %(user_id)s"},{"line_number":1607,"context_line":"        %(request_scheme)s"},{"line_number":1608,"context_line":"        %(referer_url)s"},{"line_number":1609,"context_line":"        %(request_url)s"},{"line_number":1610,"context_line":"        %(message)s"},{"line_number":1611,"context_line":"        %(method)s"},{"line_number":1612,"context_line":"        %(http_status)s"},{"line_number":1613,"context_line":"        %(param)s"},{"line_number":1614,"context_line":""},{"line_number":1615,"context_line":""},{"line_number":1616,"context_line":"Django Settings (Partial)"}],"source_content_type":"text/x-rst","patch_set":20,"id":"bab6814e_d754f2ca","line":1613,"range":{"start_line":1601,"start_character":8,"end_line":1613,"end_character":17},"updated":"2016-05-23 13:02:21.000000000","message":"Consider using a list.","commit_id":"c67d557544551f5bdc88d29e641e4429fe7eca3e"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"08cce71d5e1bab8c562c45e339b21cd39fe44bec","unresolved":false,"context_lines":[{"line_number":1598,"context_line":"``format`` defines the operation log format."},{"line_number":1599,"context_line":"Currently you can use the following keywords::"},{"line_number":1600,"context_line":""},{"line_number":1601,"context_line":"        %(domain_name)s"},{"line_number":1602,"context_line":"        %(domain_id)s"},{"line_number":1603,"context_line":"        %(project_name)s"},{"line_number":1604,"context_line":"        %(project_id)s"},{"line_number":1605,"context_line":"        %(user_name)s"},{"line_number":1606,"context_line":"        %(user_id)s"},{"line_number":1607,"context_line":"        %(request_scheme)s"},{"line_number":1608,"context_line":"        %(referer_url)s"},{"line_number":1609,"context_line":"        %(request_url)s"},{"line_number":1610,"context_line":"        %(message)s"},{"line_number":1611,"context_line":"        %(method)s"},{"line_number":1612,"context_line":"        %(http_status)s"},{"line_number":1613,"context_line":"        %(param)s"},{"line_number":1614,"context_line":""},{"line_number":1615,"context_line":""},{"line_number":1616,"context_line":"Django Settings (Partial)"}],"source_content_type":"text/x-rst","patch_set":20,"id":"bab6814e_c677fb9d","line":1613,"range":{"start_line":1601,"start_character":8,"end_line":1613,"end_character":17},"in_reply_to":"bab6814e_d754f2ca","updated":"2016-05-24 02:01:07.000000000","message":"Done","commit_id":"c67d557544551f5bdc88d29e641e4429fe7eca3e"}],"horizon/middleware.py":[{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"54ffd4a2a95c42dcbc9912176ef6248abea28a1c","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        return response"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"class OperationLogMiddleware(object):"},{"line_number":195,"context_line":"    \"\"\"This middleware output operation log."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    operation log mechanism is based on python logging."}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_7571460b","line":194,"updated":"2016-02-08 17:52:31.000000000","message":"A middleware should check on __init__ if its enabled and if not raise  django.core.exceptions.MiddlewareNotUsed so django can ignore it :)","commit_id":"4d4056846fe617d224e078e3b05550215dfe28ec"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"4e45f9ae54581500cff922ad8049933d52aa480a","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        return response"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"class OperationLogMiddleware(object):"},{"line_number":195,"context_line":"    \"\"\"This middleware output operation log."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    operation log mechanism is based on python logging."}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_070e7b34","line":194,"in_reply_to":"5a5ae5dd_7571460b","updated":"2016-02-10 12:00:03.000000000","message":"Done","commit_id":"4d4056846fe617d224e078e3b05550215dfe28ec"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"54ffd4a2a95c42dcbc9912176ef6248abea28a1c","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        # json parameter"},{"line_number":238,"context_line":"        param \u003d json.dumps(request.POST.items())"},{"line_number":239,"context_line":"        try:"},{"line_number":240,"context_line":"            post_datas \u003d request.POST.iteritems()"},{"line_number":241,"context_line":"        except Exception:"},{"line_number":242,"context_line":"            post_datas \u003d request.POST.items()"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_756626bc","line":240,"updated":"2016-02-08 17:52:31.000000000","message":"iteritems doesnt seem to be compatible with python3 so it would be nice to have six.iteritems instead for compatibility.","commit_id":"4d4056846fe617d224e078e3b05550215dfe28ec"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"4e45f9ae54581500cff922ad8049933d52aa480a","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        # json parameter"},{"line_number":238,"context_line":"        param \u003d json.dumps(request.POST.items())"},{"line_number":239,"context_line":"        try:"},{"line_number":240,"context_line":"            post_datas \u003d request.POST.iteritems()"},{"line_number":241,"context_line":"        except Exception:"},{"line_number":242,"context_line":"            post_datas \u003d request.POST.items()"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_67adef87","line":240,"in_reply_to":"5a5ae5dd_756626bc","updated":"2016-02-10 12:00:03.000000000","message":"Done","commit_id":"4d4056846fe617d224e078e3b05550215dfe28ec"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"54ffd4a2a95c42dcbc9912176ef6248abea28a1c","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                    param \u003d param.replace("},{"line_number":251,"context_line":"                        \u0027\"\u0027 + post_key + \u0027\", \"\u0027 + post_value + \u0027\"\u0027,"},{"line_number":252,"context_line":"                        \u0027\"\u0027 + post_key + \u0027\", \"\u0027 + \u0027*\u0027 * 8"},{"line_number":253,"context_line":"                        + \u0027\"\u0027)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        # when a file uploaded (E.g create image)"},{"line_number":256,"context_line":"        files \u003d request.FILES"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_d5db5a4d","line":253,"updated":"2016-02-08 17:52:31.000000000","message":"This seems overly complicated way to mask data. Why not just discard the value and add \"*\" * 8 instead? \n\nIf the reasoning is that we want a part of the masked data to be shown then why not use truncatechars instead?\n\nI think I may be missing the reason for that.","commit_id":"4d4056846fe617d224e078e3b05550215dfe28ec"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"4e45f9ae54581500cff922ad8049933d52aa480a","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                    param \u003d param.replace("},{"line_number":251,"context_line":"                        \u0027\"\u0027 + post_key + \u0027\", \"\u0027 + post_value + \u0027\"\u0027,"},{"line_number":252,"context_line":"                        \u0027\"\u0027 + post_key + \u0027\", \"\u0027 + \u0027*\u0027 * 8"},{"line_number":253,"context_line":"                        + \u0027\"\u0027)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        # when a file uploaded (E.g create image)"},{"line_number":256,"context_line":"        files \u003d request.FILES"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_924b7d59","line":253,"in_reply_to":"5a5ae5dd_d5db5a4d","updated":"2016-02-10 12:00:03.000000000","message":"Yes, this is just discard the value and add \"*\" * 8 instead.\nAnd it just want to change to string. so I\u0027ll modify more simply.","commit_id":"4d4056846fe617d224e078e3b05550215dfe28ec"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"54ffd4a2a95c42dcbc9912176ef6248abea28a1c","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    def get_log_format(self, request, exception\u003dFalse):"},{"line_number":270,"context_line":"        \"\"\"Get operation log format.\"\"\""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        request_log \u003d \u0027\u0027"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        if not self.ENABLED:"},{"line_number":275,"context_line":"            return request_log"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_d5fcba73","line":272,"updated":"2016-02-08 17:52:31.000000000","message":"Better to have None instead of an empty string, makes easier to work with it afterwards by checking for is None instead of string comparison.","commit_id":"4d4056846fe617d224e078e3b05550215dfe28ec"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"4e45f9ae54581500cff922ad8049933d52aa480a","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    def get_log_format(self, request, exception\u003dFalse):"},{"line_number":270,"context_line":"        \"\"\"Get operation log format.\"\"\""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        request_log \u003d \u0027\u0027"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        if not self.ENABLED:"},{"line_number":275,"context_line":"            return request_log"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_2737f7b1","line":272,"in_reply_to":"5a5ae5dd_d5fcba73","updated":"2016-02-10 12:00:03.000000000","message":"Done","commit_id":"4d4056846fe617d224e078e3b05550215dfe28ec"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"54ffd4a2a95c42dcbc9912176ef6248abea28a1c","unresolved":false,"context_lines":[{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        if self.OPERATION_LOG is None:"},{"line_number":286,"context_line":"            self.OPERATION_LOG \u003d\\"},{"line_number":287,"context_line":"                logging.getLogger(__name__ + \u0027.\u0027 + self.__class__.__name__)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        if method in self.METHOD_TARGETS:"},{"line_number":290,"context_line":"            if exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_559e8a63","line":287,"updated":"2016-02-08 17:52:31.000000000","message":"Doesnt this makes it a bit difficult to get the logger name? Why not have a common logger name like openstack_dashboard.operation_log or something easier?","commit_id":"4d4056846fe617d224e078e3b05550215dfe28ec"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"4e45f9ae54581500cff922ad8049933d52aa480a","unresolved":false,"context_lines":[{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        if self.OPERATION_LOG is None:"},{"line_number":286,"context_line":"            self.OPERATION_LOG \u003d\\"},{"line_number":287,"context_line":"                logging.getLogger(__name__ + \u0027.\u0027 + self.__class__.__name__)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        if method in self.METHOD_TARGETS:"},{"line_number":290,"context_line":"            if exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_87aa6b6f","line":287,"in_reply_to":"5a5ae5dd_559e8a63","updated":"2016-02-10 12:00:03.000000000","message":"This file is horizon/middleware.py. so I\u0027ll change this name to \u0027horizon.operation_log\u0027.","commit_id":"4d4056846fe617d224e078e3b05550215dfe28ec"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"54ffd4a2a95c42dcbc9912176ef6248abea28a1c","unresolved":false,"context_lines":[{"line_number":300,"context_line":"                                          .replace(str(host), \u0027\u0027))"},{"line_number":301,"context_line":"                           if not request.META.get(\u0027HTTP_REFERER\u0027) is None"},{"line_number":302,"context_line":"                           else self.EMPTY_DATA)"},{"line_number":303,"context_line":"            if user.is_authenticated():"},{"line_number":304,"context_line":"                project_name \u003d \"[\" + user.project_name + \"]\""},{"line_number":305,"context_line":"                user_name \u003d \"[\" + user.username + \"]\""},{"line_number":306,"context_line":"                project_id \u003d user.project_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_55ac4a8b","line":303,"updated":"2016-02-08 17:52:31.000000000","message":"Do we want to log non-authenticated post requests? That seems more of the work of apache or gunicorn than a internal logger for actions.","commit_id":"4d4056846fe617d224e078e3b05550215dfe28ec"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"4e45f9ae54581500cff922ad8049933d52aa480a","unresolved":false,"context_lines":[{"line_number":300,"context_line":"                                          .replace(str(host), \u0027\u0027))"},{"line_number":301,"context_line":"                           if not request.META.get(\u0027HTTP_REFERER\u0027) is None"},{"line_number":302,"context_line":"                           else self.EMPTY_DATA)"},{"line_number":303,"context_line":"            if user.is_authenticated():"},{"line_number":304,"context_line":"                project_name \u003d \"[\" + user.project_name + \"]\""},{"line_number":305,"context_line":"                user_name \u003d \"[\" + user.username + \"]\""},{"line_number":306,"context_line":"                project_id \u003d user.project_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_c8e4f33c","line":303,"in_reply_to":"5a5ae5dd_55ac4a8b","updated":"2016-02-10 12:00:03.000000000","message":"As you say, we don\u0027t need to log in that case.\nI\u0027ll delete it. Thanks!","commit_id":"4d4056846fe617d224e078e3b05550215dfe28ec"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3190e183592c362f5354daab7b9a487034f3f990","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                response[\u0027X-Horizon-Messages\u0027] \u003d json.dumps(queued_msgs)"},{"line_number":191,"context_line":"        return response"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"class OperationLogMiddleware(object):"},{"line_number":195,"context_line":"    \"\"\"This middleware output operation log."},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_ec0de58f","line":193,"updated":"2016-03-04 14:37:36.000000000","message":"Honestly speaking, I would like to see one middleware per file.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                response[\u0027X-Horizon-Messages\u0027] \u003d json.dumps(queued_msgs)"},{"line_number":191,"context_line":"        return response"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"class OperationLogMiddleware(object):"},{"line_number":195,"context_line":"    \"\"\"This middleware output operation log."},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_11aadc85","line":193,"in_reply_to":"7af24918_ec0de58f","updated":"2016-03-22 02:20:42.000000000","message":"Done","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee024128f75d87ac5e8d2b4a781d332a57c1fd83","unresolved":false,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    OPERATION_LOG \u003d None"},{"line_number":218,"context_line":"    MASK_TARGETS \u003d getattr(settings,"},{"line_number":219,"context_line":"                           \"OPERATION_LOG_ASK_TARGETS\", [\u0027password\u0027])"},{"line_number":220,"context_line":"    METHOD_TARGETS \u003d getattr(settings,"},{"line_number":221,"context_line":"                             \"OPERATION_LOG_METHOD_TARGETS\", [\u0027POST\u0027])"},{"line_number":222,"context_line":"    STATIC_RULE \u003d [\u0027/js/\u0027, \u0027/static/\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_7facd68b","line":219,"range":{"start_line":219,"start_character":42,"end_line":219,"end_character":53},"updated":"2016-03-04 17:45:38.000000000","message":"ASK -\u003e MASK\n\nHow about OPERATION_LOG_MASK_FIELDS?","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    OPERATION_LOG \u003d None"},{"line_number":218,"context_line":"    MASK_TARGETS \u003d getattr(settings,"},{"line_number":219,"context_line":"                           \"OPERATION_LOG_ASK_TARGETS\", [\u0027password\u0027])"},{"line_number":220,"context_line":"    METHOD_TARGETS \u003d getattr(settings,"},{"line_number":221,"context_line":"                             \"OPERATION_LOG_METHOD_TARGETS\", [\u0027POST\u0027])"},{"line_number":222,"context_line":"    STATIC_RULE \u003d [\u0027/js/\u0027, \u0027/static/\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_ce948f8c","line":219,"range":{"start_line":219,"start_character":42,"end_line":219,"end_character":53},"in_reply_to":"7af24918_7facd68b","updated":"2016-03-22 02:20:42.000000000","message":"Done","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee024128f75d87ac5e8d2b4a781d332a57c1fd83","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    MASK_TARGETS \u003d getattr(settings,"},{"line_number":219,"context_line":"                           \"OPERATION_LOG_ASK_TARGETS\", [\u0027password\u0027])"},{"line_number":220,"context_line":"    METHOD_TARGETS \u003d getattr(settings,"},{"line_number":221,"context_line":"                             \"OPERATION_LOG_METHOD_TARGETS\", [\u0027POST\u0027])"},{"line_number":222,"context_line":"    STATIC_RULE \u003d [\u0027/js/\u0027, \u0027/static/\u0027]"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_ffb2a604","line":221,"range":{"start_line":221,"start_character":44,"end_line":221,"end_character":58},"updated":"2016-03-04 17:45:38.000000000","message":"I prefer to TARGET_METHODS.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    MASK_TARGETS \u003d getattr(settings,"},{"line_number":219,"context_line":"                           \"OPERATION_LOG_ASK_TARGETS\", [\u0027password\u0027])"},{"line_number":220,"context_line":"    METHOD_TARGETS \u003d getattr(settings,"},{"line_number":221,"context_line":"                             \"OPERATION_LOG_METHOD_TARGETS\", [\u0027POST\u0027])"},{"line_number":222,"context_line":"    STATIC_RULE \u003d [\u0027/js/\u0027, \u0027/static/\u0027]"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_0e8b1769","line":221,"range":{"start_line":221,"start_character":44,"end_line":221,"end_character":58},"in_reply_to":"7af24918_ffb2a604","updated":"2016-03-22 02:20:42.000000000","message":"Done","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3190e183592c362f5354daab7b9a487034f3f990","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    STATIC_RULE \u003d [\u0027/js/\u0027, \u0027/static/\u0027]"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def __init__(self):"},{"line_number":225,"context_line":"        if not getattr(settings, \"OPERATION_LOG_ENABLED\", False):"},{"line_number":226,"context_line":"            raise MiddlewareNotUsed"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def _get_unicode(self, param_object):"},{"line_number":229,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_8cfb8146","line":226,"range":{"start_line":225,"start_character":8,"end_line":226,"end_character":35},"updated":"2016-03-04 14:37:36.000000000","message":"I would like to see a comment why it is needed.\nI know you added this per the past comment.\nIt would be nice if the reason is described here.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"450c4a37b7e2391ba13333f0bed3a9f0919a80db","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def __init__(self):"},{"line_number":225,"context_line":"        if not getattr(settings, \"OPERATION_LOG_ENABLED\", False):"},{"line_number":226,"context_line":"            raise MiddlewareNotUsed"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def _get_unicode(self, param_object):"},{"line_number":229,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_d22ec241","line":226,"in_reply_to":"7af24918_07b58a7c","updated":"2016-03-04 14:47:36.000000000","message":"Thanks for the explanation. I read through the django document about middleware and it is now clear to me.\n\nIt is a suggested way in the django docs, so now I don\u0027t think we need a comment.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"641512853bba4c3fc7522d6f029e268dfdcdbfa6","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def __init__(self):"},{"line_number":225,"context_line":"        if not getattr(settings, \"OPERATION_LOG_ENABLED\", False):"},{"line_number":226,"context_line":"            raise MiddlewareNotUsed"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def _get_unicode(self, param_object):"},{"line_number":229,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_07b58a7c","line":226,"in_reply_to":"7af24918_8cfb8146","updated":"2016-03-04 14:41:00.000000000","message":"You can read about it in the django docs about middleware. Basically if you start django and you raise this, djngo will unload the middleware. If you dont do this, on each request the middleware class will be executed, even if it doesnt do anything.\n\nIts just good practice and a bit of performance improvement when dealing with a lot of requests.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee024128f75d87ac5e8d2b4a781d332a57c1fd83","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        if not getattr(settings, \"OPERATION_LOG_ENABLED\", False):"},{"line_number":226,"context_line":"            raise MiddlewareNotUsed"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def _get_unicode(self, param_object):"},{"line_number":229,"context_line":"        try:"},{"line_number":230,"context_line":"            return unicode(param_object, \u0027utf_8\u0027)"},{"line_number":231,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_81a97c27","line":228,"range":{"start_line":228,"start_character":4,"end_line":228,"end_character":20},"updated":"2016-03-04 17:45:38.000000000","message":"In what case do you want this?","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        if not getattr(settings, \"OPERATION_LOG_ENABLED\", False):"},{"line_number":226,"context_line":"            raise MiddlewareNotUsed"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def _get_unicode(self, param_object):"},{"line_number":229,"context_line":"        try:"},{"line_number":230,"context_line":"            return unicode(param_object, \u0027utf_8\u0027)"},{"line_number":231,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_b12e88f8","line":228,"range":{"start_line":228,"start_character":4,"end_line":228,"end_character":20},"in_reply_to":"7af24918_81a97c27","updated":"2016-03-22 02:20:42.000000000","message":"This method is unnecessary because of reconsidering old implementation. Thus, I deleted it.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3190e183592c362f5354daab7b9a487034f3f990","unresolved":false,"context_lines":[{"line_number":232,"context_line":"            return str(param_object)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    def _get_json_param(self, request):"},{"line_number":235,"context_line":"        \"\"\"Change POST data to JSON data and mask data"},{"line_number":236,"context_line":"        request: HttpRequest"},{"line_number":237,"context_line":"        \"\"\""},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_6c7b95be","line":235,"updated":"2016-03-04 14:37:36.000000000","message":"A blank line at the second line.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":232,"context_line":"            return str(param_object)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    def _get_json_param(self, request):"},{"line_number":235,"context_line":"        \"\"\"Change POST data to JSON data and mask data"},{"line_number":236,"context_line":"        request: HttpRequest"},{"line_number":237,"context_line":"        \"\"\""},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_eefcebb9","line":235,"in_reply_to":"7af24918_6c7b95be","updated":"2016-03-22 02:20:42.000000000","message":"Done","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee024128f75d87ac5e8d2b4a781d332a57c1fd83","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        \"\"\""},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        # json parameter"},{"line_number":240,"context_line":"        param \u003d json.dumps(request.POST.items())"},{"line_number":241,"context_line":"        try:"},{"line_number":242,"context_line":"            post_datas \u003d six.iteritems(request.POST)"},{"line_number":243,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_0243b56c","line":240,"updated":"2016-03-04 17:45:38.000000000","message":"This logic manipulate JSON data as a string. It is really a bad idea.\nJSON is a string representation of a structured data, so we should manipulate the data first and then dump it as JSON.\n\nThis means:\n\n  params \u003d request.POST.copy()\n  \u003ccleanup params\u003e\n  return json.dumps(params)\n\nIf POST data is nested, you need to use copy.deepcopy.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        \"\"\""},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        # json parameter"},{"line_number":240,"context_line":"        param \u003d json.dumps(request.POST.items())"},{"line_number":241,"context_line":"        try:"},{"line_number":242,"context_line":"            post_datas \u003d six.iteritems(request.POST)"},{"line_number":243,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_f1381040","line":240,"in_reply_to":"7af24918_0243b56c","updated":"2016-03-22 02:20:42.000000000","message":"Done. As you say, because of manipulating JSON data as a string, the logic was much complex. But thanks to your review this implementation is much simpler than before. Great thanks.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee024128f75d87ac5e8d2b4a781d332a57c1fd83","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        param \u003d json.dumps(request.POST.items())"},{"line_number":241,"context_line":"        try:"},{"line_number":242,"context_line":"            post_datas \u003d six.iteritems(request.POST)"},{"line_number":243,"context_line":"        except Exception:"},{"line_number":244,"context_line":"            post_datas \u003d request.POST.items()"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        for key, value in post_datas:"},{"line_number":247,"context_line":"            # replace a value to a masked characters"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_a2cc8135","line":244,"range":{"start_line":243,"start_character":8,"end_line":244,"end_character":45},"updated":"2016-03-04 17:45:38.000000000","message":"Is there a case where six.iteritems() fails?\nPreviously you try iteritems and if it fails (for python3), items() is used.\nsix.iteritems hides the difference between python2 and 3, so I wonder when an exception is raised.\n\nIf it never fails, you can replace L.246 with:\n\n  for key, value in six.iteritems(request.POST):\n\nIn addition, how is request.POST large?\nIf it is not so big, you can simply use request.POST.items().","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        param \u003d json.dumps(request.POST.items())"},{"line_number":241,"context_line":"        try:"},{"line_number":242,"context_line":"            post_datas \u003d six.iteritems(request.POST)"},{"line_number":243,"context_line":"        except Exception:"},{"line_number":244,"context_line":"            post_datas \u003d request.POST.items()"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        for key, value in post_datas:"},{"line_number":247,"context_line":"            # replace a value to a masked characters"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_9176ec04","line":244,"range":{"start_line":243,"start_character":8,"end_line":244,"end_character":45},"in_reply_to":"7af24918_a2cc8135","updated":"2016-03-22 02:20:42.000000000","message":"request.POST does not large in almost cases. So we don\u0027t need to use \"iteritems\". I changed to use \"items()\".","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee024128f75d87ac5e8d2b4a781d332a57c1fd83","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                    continue"},{"line_number":251,"context_line":"                post_key \u003d key.encode(\u0027utf-8\u0027)"},{"line_number":252,"context_line":"                post_value \u003d value.encode(\u0027utf-8\u0027)"},{"line_number":253,"context_line":"                param \u003d param.replace("},{"line_number":254,"context_line":"                    \u0027\"\u0027 + post_key + \u0027\", \"\u0027 + post_value + \u0027\"\u0027,"},{"line_number":255,"context_line":"                    \u0027\"\u0027 + post_key + \u0027\", \"\u0027 + \u0027*\u0027 * 8 + \u0027\"\u0027)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        # when a file uploaded (E.g create image)"},{"line_number":258,"context_line":"        files \u003d request.FILES"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_f558058c","line":255,"range":{"start_line":253,"start_character":16,"end_line":255,"end_character":60},"updated":"2016-03-04 17:45:38.000000000","message":"If we can process against dict (not json),\nit would be much simpler.\n\n  params[key] \u003d \u0027*\u0027 * 8","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                    continue"},{"line_number":251,"context_line":"                post_key \u003d key.encode(\u0027utf-8\u0027)"},{"line_number":252,"context_line":"                post_value \u003d value.encode(\u0027utf-8\u0027)"},{"line_number":253,"context_line":"                param \u003d param.replace("},{"line_number":254,"context_line":"                    \u0027\"\u0027 + post_key + \u0027\", \"\u0027 + post_value + \u0027\"\u0027,"},{"line_number":255,"context_line":"                    \u0027\"\u0027 + post_key + \u0027\", \"\u0027 + \u0027*\u0027 * 8 + \u0027\"\u0027)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        # when a file uploaded (E.g create image)"},{"line_number":258,"context_line":"        files \u003d request.FILES"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_394e1fc1","line":255,"range":{"start_line":253,"start_character":16,"end_line":255,"end_character":60},"in_reply_to":"7af24918_f558058c","updated":"2016-03-22 02:20:42.000000000","message":"Done","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee024128f75d87ac5e8d2b4a781d332a57c1fd83","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        # when a file uploaded (E.g create image)"},{"line_number":258,"context_line":"        files \u003d request.FILES"},{"line_number":259,"context_line":"        if len(files) \u003e 0:"},{"line_number":260,"context_line":"            file_name \u003d \u0027\u0027"},{"line_number":261,"context_line":"            separator \u003d \u0027\u0027"},{"line_number":262,"context_line":"            for key in files.keys():"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_78618cd2","line":259,"updated":"2016-03-04 17:45:38.000000000","message":"Consider the following logic.\n\n   filenames \u003d \u0027, \u0027.join(request.FILES.values())\n   if filenames:\n       params[\u0027file_name\u0027] \u003d filenames\n   return json.dumps(params)","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        # when a file uploaded (E.g create image)"},{"line_number":258,"context_line":"        files \u003d request.FILES"},{"line_number":259,"context_line":"        if len(files) \u003e 0:"},{"line_number":260,"context_line":"            file_name \u003d \u0027\u0027"},{"line_number":261,"context_line":"            separator \u003d \u0027\u0027"},{"line_number":262,"context_line":"            for key in files.keys():"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_d923bbbb","line":259,"in_reply_to":"7af24918_78618cd2","updated":"2016-03-22 02:20:42.000000000","message":"Done","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee024128f75d87ac5e8d2b4a781d332a57c1fd83","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            file_name \u003d \u0027\u0027"},{"line_number":261,"context_line":"            separator \u003d \u0027\u0027"},{"line_number":262,"context_line":"            for key in files.keys():"},{"line_number":263,"context_line":"                file_name +\u003d separator + str(files.get(key))"},{"line_number":264,"context_line":"                separator \u003d \u0027, \u0027"},{"line_number":265,"context_line":"            param \u003d param.replace(\u0027]]\u0027,"},{"line_number":266,"context_line":"                                  \u0027], [\"file_name\", \"\u0027 + file_name + \u0027\"]]\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_b5979dea","line":263,"range":{"start_line":263,"start_character":45,"end_line":263,"end_character":58},"updated":"2016-03-04 17:45:38.000000000","message":"we know key always exists in this case.\n\n  files[key]","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            file_name \u003d \u0027\u0027"},{"line_number":261,"context_line":"            separator \u003d \u0027\u0027"},{"line_number":262,"context_line":"            for key in files.keys():"},{"line_number":263,"context_line":"                file_name +\u003d separator + str(files.get(key))"},{"line_number":264,"context_line":"                separator \u003d \u0027, \u0027"},{"line_number":265,"context_line":"            param \u003d param.replace(\u0027]]\u0027,"},{"line_number":266,"context_line":"                                  \u0027], [\"file_name\", \"\u0027 + file_name + \u0027\"]]\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_192a4390","line":263,"range":{"start_line":263,"start_character":45,"end_line":263,"end_character":58},"in_reply_to":"7af24918_b5979dea","updated":"2016-03-22 02:20:42.000000000","message":"Done","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee024128f75d87ac5e8d2b4a781d332a57c1fd83","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        return param"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    def get_log_format(self, request, exception\u003dFalse):"},{"line_number":270,"context_line":"        \"\"\"Get operation log format.\"\"\""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        request_log \u003d None"},{"line_number":273,"context_line":"        request_url \u003d urllib.unquote(request.path)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_ed595ffe","line":270,"updated":"2016-03-04 17:45:38.000000000","message":"The method name is \"get_log_format\", but this method renders request information. How about split the logic into two: (1) get logging format and (2) get parameters from request?\n\nFor (1), I prefer to return the format like:\n\n  [%(project_name)s %(project_name)s %(user_name)s] ....\n\nFor (2), we can return data like:\n\n  {\u0027project_name\u0027: ....,\n   \u0027project_id\u0027: ....,\n   \u0027user_name\u0027: ....\n   ...\n   }","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        return param"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    def get_log_format(self, request, exception\u003dFalse):"},{"line_number":270,"context_line":"        \"\"\"Get operation log format.\"\"\""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        request_log \u003d None"},{"line_number":273,"context_line":"        request_url \u003d urllib.unquote(request.path)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_b1632841","line":270,"in_reply_to":"7af24918_ed595ffe","updated":"2016-03-22 02:20:42.000000000","message":"Done. Great idea!","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee024128f75d87ac5e8d2b4a781d332a57c1fd83","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        request_url \u003d urllib.unquote(request.path)"},{"line_number":274,"context_line":"        method \u003d request.method"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        if not request.user.is_authenticated():"},{"line_number":277,"context_line":"            return request_log"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        if method \u003d\u003d \u0027GET\u0027:"},{"line_number":280,"context_line":"            for rule in self.STATIC_RULE:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_b294d636","line":277,"range":{"start_line":276,"start_character":8,"end_line":277,"end_character":30},"updated":"2016-03-04 17:45:38.000000000","message":"How about moving this at the beginning?\n\n  if not request.user.is_authenticated():\n      return\n\nThere is no need to use \u0027request_log\u0027.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        request_url \u003d urllib.unquote(request.path)"},{"line_number":274,"context_line":"        method \u003d request.method"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        if not request.user.is_authenticated():"},{"line_number":277,"context_line":"            return request_log"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        if method \u003d\u003d \u0027GET\u0027:"},{"line_number":280,"context_line":"            for rule in self.STATIC_RULE:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_dac8c957","line":277,"range":{"start_line":276,"start_character":8,"end_line":277,"end_character":30},"in_reply_to":"7af24918_b294d636","updated":"2016-03-22 02:20:42.000000000","message":"Done","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee024128f75d87ac5e8d2b4a781d332a57c1fd83","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        if method \u003d\u003d \u0027GET\u0027:"},{"line_number":280,"context_line":"            for rule in self.STATIC_RULE:"},{"line_number":281,"context_line":"                if rule in request_url:"},{"line_number":282,"context_line":"                    return request_log"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        if self.OPERATION_LOG is None:"},{"line_number":285,"context_line":"            self.OPERATION_LOG \u003d logging.getLogger(\u0027horizon.operation_log\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_92f1da97","line":282,"range":{"start_line":282,"start_character":20,"end_line":282,"end_character":38},"updated":"2016-03-04 17:45:38.000000000","message":"request_log is still None. I think it is easier to understand if we use just \u0027return\u0027.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        if method \u003d\u003d \u0027GET\u0027:"},{"line_number":280,"context_line":"            for rule in self.STATIC_RULE:"},{"line_number":281,"context_line":"                if rule in request_url:"},{"line_number":282,"context_line":"                    return request_log"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        if self.OPERATION_LOG is None:"},{"line_number":285,"context_line":"            self.OPERATION_LOG \u003d logging.getLogger(\u0027horizon.operation_log\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_3150b85e","line":282,"range":{"start_line":282,"start_character":20,"end_line":282,"end_character":38},"in_reply_to":"7af24918_92f1da97","updated":"2016-03-22 02:20:42.000000000","message":"Done","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee024128f75d87ac5e8d2b4a781d332a57c1fd83","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                if rule in request_url:"},{"line_number":282,"context_line":"                    return request_log"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        if self.OPERATION_LOG is None:"},{"line_number":285,"context_line":"            self.OPERATION_LOG \u003d logging.getLogger(\u0027horizon.operation_log\u0027)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        if method in self.METHOD_TARGETS:"},{"line_number":288,"context_line":"            if exception:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_7ff17694","line":285,"range":{"start_line":284,"start_character":8,"end_line":285,"end_character":75},"updated":"2016-03-04 17:45:38.000000000","message":"Can we do this in __init__()?","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                if rule in request_url:"},{"line_number":282,"context_line":"                    return request_log"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        if self.OPERATION_LOG is None:"},{"line_number":285,"context_line":"            self.OPERATION_LOG \u003d logging.getLogger(\u0027horizon.operation_log\u0027)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        if method in self.METHOD_TARGETS:"},{"line_number":288,"context_line":"            if exception:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_4e3d1f8e","line":285,"range":{"start_line":284,"start_character":8,"end_line":285,"end_character":75},"in_reply_to":"7af24918_7ff17694","updated":"2016-03-22 02:20:42.000000000","message":"Done","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee024128f75d87ac5e8d2b4a781d332a57c1fd83","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        if self.OPERATION_LOG is None:"},{"line_number":285,"context_line":"            self.OPERATION_LOG \u003d logging.getLogger(\u0027horizon.operation_log\u0027)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        if method in self.METHOD_TARGETS:"},{"line_number":288,"context_line":"            if exception:"},{"line_number":289,"context_line":"                # when exception occur, process_exception only know its"},{"line_number":290,"context_line":"                # reason. If this method is called by process_exception,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_1f003233","line":287,"updated":"2016-03-04 17:45:38.000000000","message":"How about:\n\n  if method not in self.METHOD_TARGETS:\n      return\n  \u003clogic below\u003e\n\nIt reduces the indent level and clarifies the logic more.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        if self.OPERATION_LOG is None:"},{"line_number":285,"context_line":"            self.OPERATION_LOG \u003d logging.getLogger(\u0027horizon.operation_log\u0027)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        if method in self.METHOD_TARGETS:"},{"line_number":288,"context_line":"            if exception:"},{"line_number":289,"context_line":"                # when exception occur, process_exception only know its"},{"line_number":290,"context_line":"                # reason. If this method is called by process_exception,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_b1ca0819","line":287,"in_reply_to":"7af24918_1f003233","updated":"2016-03-22 02:20:42.000000000","message":"Done","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee024128f75d87ac5e8d2b4a781d332a57c1fd83","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                # when exception occur, process_exception only know its"},{"line_number":290,"context_line":"                # reason. If this method is called by process_exception,"},{"line_number":291,"context_line":"                # this log expresses not a operation but a reason for exception"},{"line_number":292,"context_line":"                method \u003d \u0027ERROR\u0027"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"            user \u003d request.user"},{"line_number":295,"context_line":"            host \u003d request.scheme"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_64471e4c","line":292,"range":{"start_line":292,"start_character":16,"end_line":292,"end_character":32},"updated":"2016-03-04 17:45:38.000000000","message":"In case of exception, don\u0027t we need \"method\"?\n\"ERROR\" hides a method type. Is it okay?","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                # when exception occur, process_exception only know its"},{"line_number":290,"context_line":"                # reason. If this method is called by process_exception,"},{"line_number":291,"context_line":"                # this log expresses not a operation but a reason for exception"},{"line_number":292,"context_line":"                method \u003d \u0027ERROR\u0027"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"            user \u003d request.user"},{"line_number":295,"context_line":"            host \u003d request.scheme"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_1a44f1b4","line":292,"range":{"start_line":292,"start_character":16,"end_line":292,"end_character":32},"in_reply_to":"7af24918_64471e4c","updated":"2016-03-22 02:20:42.000000000","message":"Yes, it\u0027s as you say.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee024128f75d87ac5e8d2b4a781d332a57c1fd83","unresolved":false,"context_lines":[{"line_number":292,"context_line":"                method \u003d \u0027ERROR\u0027"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"            user \u003d request.user"},{"line_number":295,"context_line":"            host \u003d request.scheme"},{"line_number":296,"context_line":"            host +\u003d \u0027://\u0027 + request.META.get(\u0027HTTP_HOST\u0027)"},{"line_number":297,"context_line":"            referer_url \u003d (urllib.unquote(request.META.get(\u0027HTTP_REFERER\u0027)"},{"line_number":298,"context_line":"                                          .replace(str(host), \u0027\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_42993dc3","line":295,"range":{"start_line":295,"start_character":12,"end_line":295,"end_character":33},"updated":"2016-03-04 17:45:38.000000000","message":"Is there any reason you concatenate scheme and host?\nI think we can log \u0027scheme\u0027 as a separate field.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":292,"context_line":"                method \u003d \u0027ERROR\u0027"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"            user \u003d request.user"},{"line_number":295,"context_line":"            host \u003d request.scheme"},{"line_number":296,"context_line":"            host +\u003d \u0027://\u0027 + request.META.get(\u0027HTTP_HOST\u0027)"},{"line_number":297,"context_line":"            referer_url \u003d (urllib.unquote(request.META.get(\u0027HTTP_REFERER\u0027)"},{"line_number":298,"context_line":"                                          .replace(str(host), \u0027\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_b46cf608","line":295,"range":{"start_line":295,"start_character":12,"end_line":295,"end_character":33},"in_reply_to":"7af24918_42993dc3","updated":"2016-03-22 02:20:42.000000000","message":"Done","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee024128f75d87ac5e8d2b4a781d332a57c1fd83","unresolved":false,"context_lines":[{"line_number":295,"context_line":"            host \u003d request.scheme"},{"line_number":296,"context_line":"            host +\u003d \u0027://\u0027 + request.META.get(\u0027HTTP_HOST\u0027)"},{"line_number":297,"context_line":"            referer_url \u003d (urllib.unquote(request.META.get(\u0027HTTP_REFERER\u0027)"},{"line_number":298,"context_line":"                                          .replace(str(host), \u0027\u0027))"},{"line_number":299,"context_line":"                           if not request.META.get(\u0027HTTP_REFERER\u0027) is None"},{"line_number":300,"context_line":"                           else \u0027None\u0027)"},{"line_number":301,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_c276eda2","line":298,"range":{"start_line":298,"start_character":51,"end_line":298,"end_character":60},"updated":"2016-03-04 17:45:38.000000000","message":"If the path component contains a same string as \u0027host\u0027, it will be replaced too. I think it is better to parse HTTP_REFERER and check the host component.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":295,"context_line":"            host \u003d request.scheme"},{"line_number":296,"context_line":"            host +\u003d \u0027://\u0027 + request.META.get(\u0027HTTP_HOST\u0027)"},{"line_number":297,"context_line":"            referer_url \u003d (urllib.unquote(request.META.get(\u0027HTTP_REFERER\u0027)"},{"line_number":298,"context_line":"                                          .replace(str(host), \u0027\u0027))"},{"line_number":299,"context_line":"                           if not request.META.get(\u0027HTTP_REFERER\u0027) is None"},{"line_number":300,"context_line":"                           else \u0027None\u0027)"},{"line_number":301,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_5a1839d3","line":298,"range":{"start_line":298,"start_character":51,"end_line":298,"end_character":60},"in_reply_to":"7af24918_c276eda2","updated":"2016-03-22 02:20:42.000000000","message":"Done. Python has a function to parse url, so I changed this processes to use it.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee024128f75d87ac5e8d2b4a781d332a57c1fd83","unresolved":false,"context_lines":[{"line_number":296,"context_line":"            host +\u003d \u0027://\u0027 + request.META.get(\u0027HTTP_HOST\u0027)"},{"line_number":297,"context_line":"            referer_url \u003d (urllib.unquote(request.META.get(\u0027HTTP_REFERER\u0027)"},{"line_number":298,"context_line":"                                          .replace(str(host), \u0027\u0027))"},{"line_number":299,"context_line":"                           if not request.META.get(\u0027HTTP_REFERER\u0027) is None"},{"line_number":300,"context_line":"                           else \u0027None\u0027)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"            project_name \u003d \"[\" + user.project_name + \"]\""}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_ff10e65a","line":299,"updated":"2016-03-04 17:45:38.000000000","message":"This is normal if-else.\nHow about using normal if-clause?\n\n  if request.META.get(\u0027HTTP_REFERER\u0027):\n      referer_url \u003d urllib.unquote(...)\n  else:\n      referer_url \u003d None\n\nquestion: is there a case where HTTP_REFERER exists but its value is an empty string. If there is no such case, you don\u0027t need to compare request.META.get(\u0027HTTP_REFERER\u0027) with None explicitly.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9f3b4a73f4d284dbaa2362a9afaa388c20016bd7","unresolved":false,"context_lines":[{"line_number":296,"context_line":"            host +\u003d \u0027://\u0027 + request.META.get(\u0027HTTP_HOST\u0027)"},{"line_number":297,"context_line":"            referer_url \u003d (urllib.unquote(request.META.get(\u0027HTTP_REFERER\u0027)"},{"line_number":298,"context_line":"                                          .replace(str(host), \u0027\u0027))"},{"line_number":299,"context_line":"                           if not request.META.get(\u0027HTTP_REFERER\u0027) is None"},{"line_number":300,"context_line":"                           else \u0027None\u0027)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"            project_name \u003d \"[\" + user.project_name + \"]\""}],"source_content_type":"text/x-python","patch_set":7,"id":"da0c15f0_fad44a48","line":299,"in_reply_to":"5aef4532_ba0b3d7c","updated":"2016-03-25 09:51:26.000000000","message":"I hope you reply my question above.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":296,"context_line":"            host +\u003d \u0027://\u0027 + request.META.get(\u0027HTTP_HOST\u0027)"},{"line_number":297,"context_line":"            referer_url \u003d (urllib.unquote(request.META.get(\u0027HTTP_REFERER\u0027)"},{"line_number":298,"context_line":"                                          .replace(str(host), \u0027\u0027))"},{"line_number":299,"context_line":"                           if not request.META.get(\u0027HTTP_REFERER\u0027) is None"},{"line_number":300,"context_line":"                           else \u0027None\u0027)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"            project_name \u003d \"[\" + user.project_name + \"]\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_ba0b3d7c","line":299,"in_reply_to":"7af24918_ff10e65a","updated":"2016-03-22 02:20:42.000000000","message":"Done","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"77dd4386edcad07e92f8e08dc3d1a78e4cc28525","unresolved":false,"context_lines":[{"line_number":296,"context_line":"            host +\u003d \u0027://\u0027 + request.META.get(\u0027HTTP_HOST\u0027)"},{"line_number":297,"context_line":"            referer_url \u003d (urllib.unquote(request.META.get(\u0027HTTP_REFERER\u0027)"},{"line_number":298,"context_line":"                                          .replace(str(host), \u0027\u0027))"},{"line_number":299,"context_line":"                           if not request.META.get(\u0027HTTP_REFERER\u0027) is None"},{"line_number":300,"context_line":"                           else \u0027None\u0027)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"            project_name \u003d \"[\" + user.project_name + \"]\""}],"source_content_type":"text/x-python","patch_set":7,"id":"da0c15f0_7eac80a0","line":299,"in_reply_to":"da0c15f0_fad44a48","updated":"2016-03-27 02:28:23.000000000","message":"In general, there is no case but this value can be changed by browser. So, we need to consider such case but this viewpoint was missing in previous patch. I\u0027ll address.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee024128f75d87ac5e8d2b4a781d332a57c1fd83","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                           if not request.META.get(\u0027HTTP_REFERER\u0027) is None"},{"line_number":300,"context_line":"                           else \u0027None\u0027)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"            project_name \u003d \"[\" + user.project_name + \"]\""},{"line_number":303,"context_line":"            user_name \u003d \"[\" + user.username + \"]\""},{"line_number":304,"context_line":"            project_id \u003d user.project_id"},{"line_number":305,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_a2d80154","line":302,"range":{"start_line":302,"start_character":12,"end_line":302,"end_character":56},"updated":"2016-03-04 17:45:38.000000000","message":"If you follow my comment at L.270, this will be unnecessary. \nWe can return the format string like\n\n  [%(project_name)s] [%(user_name)s] ...","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                           if not request.META.get(\u0027HTTP_REFERER\u0027) is None"},{"line_number":300,"context_line":"                           else \u0027None\u0027)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"            project_name \u003d \"[\" + user.project_name + \"]\""},{"line_number":303,"context_line":"            user_name \u003d \"[\" + user.username + \"]\""},{"line_number":304,"context_line":"            project_id \u003d user.project_id"},{"line_number":305,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_da24490e","line":302,"range":{"start_line":302,"start_character":12,"end_line":302,"end_character":56},"in_reply_to":"7af24918_a2d80154","updated":"2016-03-22 02:20:42.000000000","message":"Done","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee024128f75d87ac5e8d2b4a781d332a57c1fd83","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            user_name \u003d \"[\" + user.username + \"]\""},{"line_number":304,"context_line":"            project_id \u003d user.project_id"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"            if \u0027user_id\u0027 in request.session.keys():"},{"line_number":307,"context_line":"                user_id \u003d request.session.get(\u0027user_id\u0027)"},{"line_number":308,"context_line":"            else:"},{"line_number":309,"context_line":"                user_id \u003d \u0027None\u0027"},{"line_number":310,"context_line":"            param \u003d self._get_json_param(request)"},{"line_number":311,"context_line":"            request_log \u003d \u0027 \u0027.join([project_name,"},{"line_number":312,"context_line":"                                    project_id, user_name,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_92055a15","line":309,"range":{"start_line":306,"start_character":12,"end_line":309,"end_character":32},"updated":"2016-03-04 17:45:38.000000000","message":"Can we replace this with:\n\n  user_id \u003d request.session.get(\u0027user_id\u0027, \u0027None\u0027)","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            user_name \u003d \"[\" + user.username + \"]\""},{"line_number":304,"context_line":"            project_id \u003d user.project_id"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"            if \u0027user_id\u0027 in request.session.keys():"},{"line_number":307,"context_line":"                user_id \u003d request.session.get(\u0027user_id\u0027)"},{"line_number":308,"context_line":"            else:"},{"line_number":309,"context_line":"                user_id \u003d \u0027None\u0027"},{"line_number":310,"context_line":"            param \u003d self._get_json_param(request)"},{"line_number":311,"context_line":"            request_log \u003d \u0027 \u0027.join([project_name,"},{"line_number":312,"context_line":"                                    project_id, user_name,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_94a1fa48","line":309,"range":{"start_line":306,"start_character":12,"end_line":309,"end_character":32},"in_reply_to":"7af24918_92055a15","updated":"2016-03-22 02:20:42.000000000","message":"Done","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee024128f75d87ac5e8d2b4a781d332a57c1fd83","unresolved":false,"context_lines":[{"line_number":308,"context_line":"            else:"},{"line_number":309,"context_line":"                user_id \u003d \u0027None\u0027"},{"line_number":310,"context_line":"            param \u003d self._get_json_param(request)"},{"line_number":311,"context_line":"            request_log \u003d \u0027 \u0027.join([project_name,"},{"line_number":312,"context_line":"                                    project_id, user_name,"},{"line_number":313,"context_line":"                                    user_id,"},{"line_number":314,"context_line":"                                    referer_url,"},{"line_number":315,"context_line":"                                    request_url,"},{"line_number":316,"context_line":"                                    \u0027%s\u0027,"},{"line_number":317,"context_line":"                                    method,"},{"line_number":318,"context_line":"                                    \u0027%s\u0027,"},{"line_number":319,"context_line":"                                    param])"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        return request_log"},{"line_number":322,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_62b8b911","line":319,"range":{"start_line":311,"start_character":26,"end_line":319,"end_character":43},"updated":"2016-03-04 17:45:38.000000000","message":"See my comment at L.270.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":308,"context_line":"            else:"},{"line_number":309,"context_line":"                user_id \u003d \u0027None\u0027"},{"line_number":310,"context_line":"            param \u003d self._get_json_param(request)"},{"line_number":311,"context_line":"            request_log \u003d \u0027 \u0027.join([project_name,"},{"line_number":312,"context_line":"                                    project_id, user_name,"},{"line_number":313,"context_line":"                                    user_id,"},{"line_number":314,"context_line":"                                    referer_url,"},{"line_number":315,"context_line":"                                    request_url,"},{"line_number":316,"context_line":"                                    \u0027%s\u0027,"},{"line_number":317,"context_line":"                                    method,"},{"line_number":318,"context_line":"                                    \u0027%s\u0027,"},{"line_number":319,"context_line":"                                    param])"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        return request_log"},{"line_number":322,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_3a20cdf6","line":319,"range":{"start_line":311,"start_character":26,"end_line":319,"end_character":43},"in_reply_to":"7af24918_62b8b911","updated":"2016-03-22 02:20:42.000000000","message":"Done","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee024128f75d87ac5e8d2b4a781d332a57c1fd83","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        if log is not None:"},{"line_number":331,"context_line":"            # Get result message"},{"line_number":332,"context_line":"            message_array \u003d django_messages.get_messages(request)"},{"line_number":333,"context_line":"            result_message \u003d \u0027[\u0027"},{"line_number":334,"context_line":"            separator \u003d \u0027\u0027"},{"line_number":335,"context_line":"            if request.method \u003d\u003d \u0027POST\u0027:"},{"line_number":336,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_b84cb49e","line":333,"updated":"2016-03-04 17:45:38.000000000","message":"The logic of L.333-348 can be much simpler if we touch JSON string directly.\n\n  if message_array:\n      result_message \u003d \u0027, \u0027.join(\u0027%s: %s\" % (message.tags, message)\n                                  for message in message_array)\n  elif \u0027action\u0027 in request.POST:\n      result_message \u003d request.POST[\u0027action\u0027]","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        if log is not None:"},{"line_number":331,"context_line":"            # Get result message"},{"line_number":332,"context_line":"            message_array \u003d django_messages.get_messages(request)"},{"line_number":333,"context_line":"            result_message \u003d \u0027[\u0027"},{"line_number":334,"context_line":"            separator \u003d \u0027\u0027"},{"line_number":335,"context_line":"            if request.method \u003d\u003d \u0027POST\u0027:"},{"line_number":336,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_5188e4c6","line":333,"in_reply_to":"7af24918_b84cb49e","updated":"2016-03-22 02:20:42.000000000","message":"Done","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee024128f75d87ac5e8d2b4a781d332a57c1fd83","unresolved":false,"context_lines":[{"line_number":345,"context_line":"                elif \u0027action\u0027 in post_keys:"},{"line_number":346,"context_line":"                    result_message +\u003d str(request.POST.get(\u0027action\u0027))"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"            result_message +\u003d \u0027]\u0027"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"            log \u003d log % (self._get_unicode(result_message),"},{"line_number":351,"context_line":"                         str(response.status_code))"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_c442750e","line":348,"range":{"start_line":348,"start_character":30,"end_line":348,"end_character":32},"updated":"2016-03-04 17:45:38.000000000","message":"Regarding [ and ], I prefer to defining [] as a part of log format (as I commented at L.270).","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":345,"context_line":"                elif \u0027action\u0027 in post_keys:"},{"line_number":346,"context_line":"                    result_message +\u003d str(request.POST.get(\u0027action\u0027))"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"            result_message +\u003d \u0027]\u0027"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"            log \u003d log % (self._get_unicode(result_message),"},{"line_number":351,"context_line":"                         str(response.status_code))"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_91926cf5","line":348,"range":{"start_line":348,"start_character":30,"end_line":348,"end_character":32},"in_reply_to":"7af24918_c442750e","updated":"2016-03-22 02:20:42.000000000","message":"Done","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee024128f75d87ac5e8d2b4a781d332a57c1fd83","unresolved":false,"context_lines":[{"line_number":347,"context_line":""},{"line_number":348,"context_line":"            result_message +\u003d \u0027]\u0027"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"            log \u003d log % (self._get_unicode(result_message),"},{"line_number":351,"context_line":"                         str(response.status_code))"},{"line_number":352,"context_line":"            try:"},{"line_number":353,"context_line":"                self.OPERATION_LOG.info(log)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_a4df690b","line":350,"range":{"start_line":350,"start_character":21,"end_line":350,"end_character":24},"updated":"2016-03-04 17:45:38.000000000","message":"You don\u0027t need to evaluate a string format here by using %.\nInstead it is better to pass \u0027string format\u0027 and \u0027parameters\u0027 to a logging method, that is,\n\n  LOG.info(log, params)\n\nBy doing so, we can defer string evaluation until what it is actually needed. If a log level is warn,  a string evaluation never happens.\n\nSee http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages for more detail.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9f3b4a73f4d284dbaa2362a9afaa388c20016bd7","unresolved":false,"context_lines":[{"line_number":347,"context_line":""},{"line_number":348,"context_line":"            result_message +\u003d \u0027]\u0027"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"            log \u003d log % (self._get_unicode(result_message),"},{"line_number":351,"context_line":"                         str(response.status_code))"},{"line_number":352,"context_line":"            try:"},{"line_number":353,"context_line":"                self.OPERATION_LOG.info(log)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da0c15f0_5add7641","line":350,"range":{"start_line":350,"start_character":21,"end_line":350,"end_character":24},"in_reply_to":"5aef4532_773070e9","updated":"2016-03-25 09:51:26.000000000","message":"Generally speaking, it is not a good reason to % because \"unit test does not work if I change something\"....\nIt should be addressed in the unit test side.\n\nWhich test is affected?","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":347,"context_line":""},{"line_number":348,"context_line":"            result_message +\u003d \u0027]\u0027"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"            log \u003d log % (self._get_unicode(result_message),"},{"line_number":351,"context_line":"                         str(response.status_code))"},{"line_number":352,"context_line":"            try:"},{"line_number":353,"context_line":"                self.OPERATION_LOG.info(log)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_773070e9","line":350,"range":{"start_line":350,"start_character":21,"end_line":350,"end_character":24},"in_reply_to":"7af24918_a4df690b","updated":"2016-03-22 02:20:42.000000000","message":"I could confirm that proposed implementation work well. \nHowever, when I use \"LOG.info(log, params)\", Test does not work. \nIn this test, I use unittest.mock and test whether the output content is as expected. \nI\u0027m afraid that if you know how to avoid this issue, please let me know.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"77dd4386edcad07e92f8e08dc3d1a78e4cc28525","unresolved":false,"context_lines":[{"line_number":347,"context_line":""},{"line_number":348,"context_line":"            result_message +\u003d \u0027]\u0027"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"            log \u003d log % (self._get_unicode(result_message),"},{"line_number":351,"context_line":"                         str(response.status_code))"},{"line_number":352,"context_line":"            try:"},{"line_number":353,"context_line":"                self.OPERATION_LOG.info(log)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da0c15f0_feaed083","line":350,"range":{"start_line":350,"start_character":21,"end_line":350,"end_character":24},"in_reply_to":"da0c15f0_5add7641","updated":"2016-03-27 02:28:23.000000000","message":"I agree with you. I\u0027d like to improve it and try to continue to do so.\n\nCurrently, I am using \u0027patch\u0027 decorator in all tests to confirm the logged value. When I use a better way of writing, tests cannot get a logged value.\n\n@patch((\u0027horizon.operation_log.OperationLogMiddleware.\u0027\n            \u0027OPERATION_LOG\u0027))","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2f35358884d8620b7f51ab6edf054543b3b11f53","unresolved":false,"context_lines":[{"line_number":347,"context_line":""},{"line_number":348,"context_line":"            result_message +\u003d \u0027]\u0027"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"            log \u003d log % (self._get_unicode(result_message),"},{"line_number":351,"context_line":"                         str(response.status_code))"},{"line_number":352,"context_line":"            try:"},{"line_number":353,"context_line":"                self.OPERATION_LOG.info(log)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_b7ede890","line":350,"range":{"start_line":350,"start_character":21,"end_line":350,"end_character":24},"in_reply_to":"da0c15f0_feaed083","updated":"2016-04-04 07:36:24.000000000","message":"I addressed this on the patch 14.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee024128f75d87ac5e8d2b4a781d332a57c1fd83","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            result_message +\u003d \u0027]\u0027"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"            log \u003d log % (self._get_unicode(result_message),"},{"line_number":351,"context_line":"                         str(response.status_code))"},{"line_number":352,"context_line":"            try:"},{"line_number":353,"context_line":"                self.OPERATION_LOG.info(log)"},{"line_number":354,"context_line":"            except Exception as e:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_44d5c5e2","line":351,"range":{"start_line":351,"start_character":25,"end_line":351,"end_character":29},"updated":"2016-03-04 17:45:38.000000000","message":"str() is unnecessary because \u0027%s\u0027 does the same.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            result_message +\u003d \u0027]\u0027"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"            log \u003d log % (self._get_unicode(result_message),"},{"line_number":351,"context_line":"                         str(response.status_code))"},{"line_number":352,"context_line":"            try:"},{"line_number":353,"context_line":"                self.OPERATION_LOG.info(log)"},{"line_number":354,"context_line":"            except Exception as e:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_b750380c","line":351,"range":{"start_line":351,"start_character":25,"end_line":351,"end_character":29},"in_reply_to":"7af24918_44d5c5e2","updated":"2016-03-22 02:20:42.000000000","message":"Done","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee024128f75d87ac5e8d2b4a781d332a57c1fd83","unresolved":false,"context_lines":[{"line_number":351,"context_line":"                         str(response.status_code))"},{"line_number":352,"context_line":"            try:"},{"line_number":353,"context_line":"                self.OPERATION_LOG.info(log)"},{"line_number":354,"context_line":"            except Exception as e:"},{"line_number":355,"context_line":"                LOG.error(e)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"        return response"},{"line_number":358,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_9309d997","line":355,"range":{"start_line":354,"start_character":12,"end_line":355,"end_character":28},"updated":"2016-03-04 17:45:38.000000000","message":"When does logging fail?\nIf you try to catch unexpected exception, django logs stacktrace in such case, so I don\u0027t think it is unnecessary.\nIf there is an expected failure mode, it should be handled in the log generation logic.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":351,"context_line":"                         str(response.status_code))"},{"line_number":352,"context_line":"            try:"},{"line_number":353,"context_line":"                self.OPERATION_LOG.info(log)"},{"line_number":354,"context_line":"            except Exception as e:"},{"line_number":355,"context_line":"                LOG.error(e)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"        return response"},{"line_number":358,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_b777989e","line":355,"range":{"start_line":354,"start_character":12,"end_line":355,"end_character":28},"in_reply_to":"7af24918_9309d997","updated":"2016-03-22 02:20:42.000000000","message":"You\u0027re right. This is unnecessary. I removed it.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee024128f75d87ac5e8d2b4a781d332a57c1fd83","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        \"\"\"Exception log is made by information of HttpRequest and Exception."},{"line_number":361,"context_line":"        And Exception log is output."},{"line_number":362,"context_line":"        \"\"\""},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        log \u003d self.get_log_format(request, True)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        if log is not None:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_44ae62e8","line":363,"updated":"2016-03-04 17:45:38.000000000","message":"All comments for process_response apply to process_exception too.","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2593a76d254c230a89aca8466238b69569d1c4d2","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        \"\"\"Exception log is made by information of HttpRequest and Exception."},{"line_number":361,"context_line":"        And Exception log is output."},{"line_number":362,"context_line":"        \"\"\""},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        log \u003d self.get_log_format(request, True)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        if log is not None:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_176daccc","line":363,"in_reply_to":"7af24918_44ae62e8","updated":"2016-03-22 02:20:42.000000000","message":"Done","commit_id":"e20b490ce63b8c3f06413b44aefabdf052b4fab6"}],"horizon/middleware/__init__.py":[{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"939324b316ae62cd5ca44993c8a0b2e68c1a53e4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from horizon.middleware import base"},{"line_number":16,"context_line":"from horizon.middleware import operation_log"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"bab6814e_ea453db3","line":14,"updated":"2016-05-19 18:41:34.000000000","message":"why is this technique needed ?","commit_id":"c67d557544551f5bdc88d29e641e4429fe7eca3e"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"ad431e813c46236c46fd226520b05058c583f2b2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from horizon.middleware import base"},{"line_number":16,"context_line":"from horizon.middleware import operation_log"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"bab6814e_3d8f782b","line":14,"in_reply_to":"bab6814e_ea453db3","updated":"2016-05-20 05:09:26.000000000","message":"I added a new file for this feature\u0027s middleware class.\n(In first patch, I implemented new middleware class in middleware.py, but I moved into a new file(operation_log.py) by Akihiro\u0027s comment.)\n\nIn this case, files about middleware class(middleware.py, operation_log.py) should be located in same folder. \nAt the moment, middleware.py is located under \u0027horizon\u0027 folder.\nso I created \u0027middlware\u0027 folder and moved middlware.py into that folder.\n\nAnd namespace pattern should be same as Django as much as possible.\n(For example\n    \u0027django.middleware.common.CommonMiddleware\u0027,\n    \u0027django.middleware.csrf.CsrfViewMiddleware)\nThis is also necessary for the reason why to maintain compatibility about middlware.py.\n(After this change, we have to be able to access original middleware class by \u0027horizon.middleware.HorizonMiddleware\u0027)\n\nTherefore, I use this way.\nUsing this way, middlware files are located in same folder, we can maintain compatibility and we can use new middlware class as \u0027horizon.middleware.OperationLogMiddleware\u0027.","commit_id":"c67d557544551f5bdc88d29e641e4429fe7eca3e"}],"horizon/middleware/base.py":[{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"939324b316ae62cd5ca44993c8a0b2e68c1a53e4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 United States Government as represented by the"},{"line_number":2,"context_line":"# Administrator of the National Aeronautics and Space Administration."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":20,"id":"bab6814e_caf95982","line":1,"updated":"2016-05-19 18:41:34.000000000","message":"why is this file being renamed?","commit_id":"c67d557544551f5bdc88d29e641e4429fe7eca3e"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"ad431e813c46236c46fd226520b05058c583f2b2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 United States Government as represented by the"},{"line_number":2,"context_line":"# Administrator of the National Aeronautics and Space Administration."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":20,"id":"bab6814e_7db3c0e9","line":1,"in_reply_to":"bab6814e_caf95982","updated":"2016-05-20 05:09:26.000000000","message":"If this file name doesn\u0027t change, the name of \u0027horizon\u0027 will be conflicted in __init__.py. To use the mechanism in __init__.py, I needed to change this file name.","commit_id":"c67d557544551f5bdc88d29e641e4429fe7eca3e"}],"horizon/middlewares/__init__.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"408d8fbf7105eb7fa5c96ab5ace9b72657544ee2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"1a122d0e_6505920f","updated":"2016-04-20 13:17:37.000000000","message":"Honestly I would like to move horizon/middleware.py in the same directory.\n\nHow about creating \u0027middleware\u0027 dir instaed of \u0027middlewares\u0027?\nDjango uses a singular name directory for middleware \"django.middleware.xxxx\", so I don\u0027t think it is a problem.\n\nIf we move horizon/middleware.py into horizon/middleware/horizon.py,  or something, we can see all middlewares provided by horizon in a single place. If we go this way, note that we need to prepare:\n\n  from horizon.middleware import horizon\n  HorizonMiddleware \u003d horizon.HorizonMiddleware\n\nin horizon/middleware/__init__.py for backward compatibility.\nYou can define yours in a same way.","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"700bb0862facba06816678221c8297f171ee71af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"1a122d0e_98fab573","in_reply_to":"1a122d0e_6505920f","updated":"2016-05-02 01:50:44.000000000","message":"Great idea. I addressed it. By the way, the name of \"horizon\" is already used, so to avoid any conflict, original middleware file move \"middleware.py\" to \"base.py\".","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"}],"horizon/middlewares/operation_log.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"408d8fbf7105eb7fa5c96ab5ace9b72657544ee2","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        _log_option \u003d getattr(settings, \"OPERATION_LOG_OPTION\", {})"},{"line_number":51,"context_line":"        _available_methods \u003d [\u0027POST\u0027, \u0027GET\u0027]"},{"line_number":52,"context_line":"        _methods \u003d _log_option.get(\"target_methods\", [\u0027POST\u0027])"},{"line_number":53,"context_line":"        _format \u003d (\"[%(domain_name)s] [%(domain_id)s] [%(project_name)s]\""},{"line_number":54,"context_line":"                   \" [%(project_id)s] [%(user_name)s] [%(user_id)s]\""},{"line_number":55,"context_line":"                   \" [%(request_scheme)s] [%(referer_url)s] [%(request_url)s]\""},{"line_number":56,"context_line":"                   \" [%(message)s] [%(method)s] [%(http_status)s] [%(param)s]\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"1a122d0e_a5596a37","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":15},"updated":"2016-04-20 13:17:37.000000000","message":"-\u003e default_format","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"700bb0862facba06816678221c8297f171ee71af","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        _log_option \u003d getattr(settings, \"OPERATION_LOG_OPTION\", {})"},{"line_number":51,"context_line":"        _available_methods \u003d [\u0027POST\u0027, \u0027GET\u0027]"},{"line_number":52,"context_line":"        _methods \u003d _log_option.get(\"target_methods\", [\u0027POST\u0027])"},{"line_number":53,"context_line":"        _format \u003d (\"[%(domain_name)s] [%(domain_id)s] [%(project_name)s]\""},{"line_number":54,"context_line":"                   \" [%(project_id)s] [%(user_name)s] [%(user_id)s]\""},{"line_number":55,"context_line":"                   \" [%(request_scheme)s] [%(referer_url)s] [%(request_url)s]\""},{"line_number":56,"context_line":"                   \" [%(message)s] [%(method)s] [%(http_status)s] [%(param)s]\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"1a122d0e_984115ac","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":15},"in_reply_to":"1a122d0e_a5596a37","updated":"2016-05-02 01:50:44.000000000","message":"Done","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"}],"horizon/operation_log.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"22e383e3a7acfeb646d1f37381e653965039298b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"da0c15f0_75796d2f","updated":"2016-03-25 09:55:46.000000000","message":"Hopefully the file is placed like horizon/middlewares/operation_log.py.\n\nhorizon middleware itself can be moved, but I would like to hear opinions from other reviewers.","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"703d22ee0bf65df2195febbbc4991c40232eeae0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"da0c15f0_9bca6fa0","in_reply_to":"da0c15f0_75796d2f","updated":"2016-03-27 02:47:26.000000000","message":"All right, this file move to under \"middlewares\" folder. As you say, about middleware.py, I\u0027d like to hear other reviewers.","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"22e383e3a7acfeb646d1f37381e653965039298b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":11,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"import json"},{"line_number":15,"context_line":"import logging"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_359ed556","line":13,"updated":"2016-03-25 09:55:46.000000000","message":"nit: My preference is to have a blank line here.","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"703d22ee0bf65df2195febbbc4991c40232eeae0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":11,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"import json"},{"line_number":15,"context_line":"import logging"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_9b41cf0e","line":13,"in_reply_to":"da0c15f0_359ed556","updated":"2016-03-27 02:47:26.000000000","message":"Done","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"22e383e3a7acfeb646d1f37381e653965039298b","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class OperationLogMiddleware(object):"},{"line_number":27,"context_line":"    \"\"\"This middleware output operation log."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    operation log mechanism is based on python logging."},{"line_number":30,"context_line":"    This log includes information below and a delimiter between attributes is"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_9a68aebc","line":27,"range":{"start_line":27,"start_character":7,"end_line":27,"end_character":30},"updated":"2016-03-25 09:55:46.000000000","message":"Middleware to output ...","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"703d22ee0bf65df2195febbbc4991c40232eeae0","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class OperationLogMiddleware(object):"},{"line_number":27,"context_line":"    \"\"\"This middleware output operation log."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    operation log mechanism is based on python logging."},{"line_number":30,"context_line":"    This log includes information below and a delimiter between attributes is"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_5b5e17ea","line":27,"range":{"start_line":27,"start_character":7,"end_line":27,"end_character":30},"in_reply_to":"da0c15f0_9a68aebc","updated":"2016-03-27 02:47:26.000000000","message":"Done","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"22e383e3a7acfeb646d1f37381e653965039298b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class OperationLogMiddleware(object):"},{"line_number":27,"context_line":"    \"\"\"This middleware output operation log."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    operation log mechanism is based on python logging."},{"line_number":30,"context_line":"    This log includes information below and a delimiter between attributes is"},{"line_number":31,"context_line":"    a single space."},{"line_number":32,"context_line":"      \u003cproject name\u003e"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_7a3cba2f","line":29,"range":{"start_line":29,"start_character":3,"end_line":29,"end_character":27},"updated":"2016-03-25 09:55:46.000000000","message":"-\u003e The operation logging mechanism","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"703d22ee0bf65df2195febbbc4991c40232eeae0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class OperationLogMiddleware(object):"},{"line_number":27,"context_line":"    \"\"\"This middleware output operation log."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    operation log mechanism is based on python logging."},{"line_number":30,"context_line":"    This log includes information below and a delimiter between attributes is"},{"line_number":31,"context_line":"    a single space."},{"line_number":32,"context_line":"      \u003cproject name\u003e"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_fb73ab4b","line":29,"range":{"start_line":29,"start_character":3,"end_line":29,"end_character":27},"in_reply_to":"da0c15f0_7a3cba2f","updated":"2016-03-27 02:47:26.000000000","message":"Done","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"22e383e3a7acfeb646d1f37381e653965039298b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        if not getattr(settings, \"OPERATION_LOG_ENABLED\", False):"},{"line_number":56,"context_line":"            raise MiddlewareNotUsed"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        self.MASK_FIELDS \u003d getattr("},{"line_number":59,"context_line":"            settings, \"OPERATION_LOG_MASK_FIELDS\", [\u0027password\u0027])"},{"line_number":60,"context_line":"        self.TARGET_METHODS \u003d getattr("},{"line_number":61,"context_line":"            settings, \"OPERATION_LOG_TARGET_METHODS\", [\u0027POST\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_fa4e0a95","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":24},"updated":"2016-03-25 09:55:46.000000000","message":"We usually use lower case variable names.\n\nself.mask_fields","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"703d22ee0bf65df2195febbbc4991c40232eeae0","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        if not getattr(settings, \"OPERATION_LOG_ENABLED\", False):"},{"line_number":56,"context_line":"            raise MiddlewareNotUsed"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        self.MASK_FIELDS \u003d getattr("},{"line_number":59,"context_line":"            settings, \"OPERATION_LOG_MASK_FIELDS\", [\u0027password\u0027])"},{"line_number":60,"context_line":"        self.TARGET_METHODS \u003d getattr("},{"line_number":61,"context_line":"            settings, \"OPERATION_LOG_TARGET_METHODS\", [\u0027POST\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_3bbb63c6","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":24},"in_reply_to":"da0c15f0_fa4e0a95","updated":"2016-03-27 02:47:26.000000000","message":"Done. other uppercase variables are also addressed.","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"22e383e3a7acfeb646d1f37381e653965039298b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        self._logger \u003d logging.getLogger(\u0027horizon.operation_log\u0027)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def process_response(self, request, response):"},{"line_number":66,"context_line":"        \"\"\"Logging user operation.\"\"\""},{"line_number":67,"context_line":"        log_format \u003d self._get_log_format(request)"},{"line_number":68,"context_line":"        if log_format is None:"},{"line_number":69,"context_line":"            return response"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_3a408256","line":66,"range":{"start_line":66,"start_character":11,"end_line":66,"end_character":19},"updated":"2016-03-25 09:55:46.000000000","message":"Logging -\u003e Log","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"703d22ee0bf65df2195febbbc4991c40232eeae0","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        self._logger \u003d logging.getLogger(\u0027horizon.operation_log\u0027)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def process_response(self, request, response):"},{"line_number":66,"context_line":"        \"\"\"Logging user operation.\"\"\""},{"line_number":67,"context_line":"        log_format \u003d self._get_log_format(request)"},{"line_number":68,"context_line":"        if log_format is None:"},{"line_number":69,"context_line":"            return response"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_bbce5358","line":66,"range":{"start_line":66,"start_character":11,"end_line":66,"end_character":19},"in_reply_to":"da0c15f0_3a408256","updated":"2016-03-27 02:47:26.000000000","message":"Done","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"22e383e3a7acfeb646d1f37381e653965039298b","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    def process_response(self, request, response):"},{"line_number":66,"context_line":"        \"\"\"Logging user operation.\"\"\""},{"line_number":67,"context_line":"        log_format \u003d self._get_log_format(request)"},{"line_number":68,"context_line":"        if log_format is None:"},{"line_number":69,"context_line":"            return response"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        params \u003d self._get_parameters_from_request(request)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_da586659","line":68,"range":{"start_line":68,"start_character":7,"end_line":68,"end_character":30},"updated":"2016-03-25 09:55:46.000000000","message":"I think \"if not log_format\" works.","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"703d22ee0bf65df2195febbbc4991c40232eeae0","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    def process_response(self, request, response):"},{"line_number":66,"context_line":"        \"\"\"Logging user operation.\"\"\""},{"line_number":67,"context_line":"        log_format \u003d self._get_log_format(request)"},{"line_number":68,"context_line":"        if log_format is None:"},{"line_number":69,"context_line":"            return response"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        params \u003d self._get_parameters_from_request(request)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_1b213ffc","line":68,"range":{"start_line":68,"start_character":7,"end_line":68,"end_character":30},"in_reply_to":"da0c15f0_da586659","updated":"2016-03-27 02:47:26.000000000","message":"you are right. Done","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"22e383e3a7acfeb646d1f37381e653965039298b","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        if messages:"},{"line_number":76,"context_line":"            result_message \u003d \u0027, \u0027.join(\u0027%s: %s\u0027 % (message.tags, message)"},{"line_number":77,"context_line":"                                       for message in messages)"},{"line_number":78,"context_line":"        elif \u0027action\u0027 in request.POST:"},{"line_number":79,"context_line":"            result_message \u003d request.POST[\u0027action\u0027]"},{"line_number":80,"context_line":"        params[\u0027message\u0027] \u003d result_message"},{"line_number":81,"context_line":"        params[\u0027http_status\u0027] \u003d response.status_code"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_3aa40256","line":78,"range":{"start_line":78,"start_character":25,"end_line":78,"end_character":38},"updated":"2016-03-25 09:55:46.000000000","message":"Does it work if someone sets OPERATION_LOG_TARGET_METHODS to [\u0027POST\u0027, \u0027PUT\u0027, \u0027DELETE\u0027, \u0027GET\u0027] for example?\n\nOPERATION_LOG_TARGET_METHODS is configurable, so you need to consider all methods.","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"703d22ee0bf65df2195febbbc4991c40232eeae0","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        if messages:"},{"line_number":76,"context_line":"            result_message \u003d \u0027, \u0027.join(\u0027%s: %s\u0027 % (message.tags, message)"},{"line_number":77,"context_line":"                                       for message in messages)"},{"line_number":78,"context_line":"        elif \u0027action\u0027 in request.POST:"},{"line_number":79,"context_line":"            result_message \u003d request.POST[\u0027action\u0027]"},{"line_number":80,"context_line":"        params[\u0027message\u0027] \u003d result_message"},{"line_number":81,"context_line":"        params[\u0027http_status\u0027] \u003d response.status_code"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_89f865e7","line":78,"range":{"start_line":78,"start_character":25,"end_line":78,"end_character":38},"in_reply_to":"da0c15f0_3aa40256","updated":"2016-03-27 02:47:26.000000000","message":"Good point ! At the moment, I don\u0027t suppose OPERATION_LOG_TARGET_METHODS is set any value except for \u0027POST\u0027 or \u0027GET\u0027. Thus, I\u0027ll address that if someone set a  \u0027PUT\u0027 or \u0027DELETE\u0027, the value will be ignored.\nAnd I think Horizon don\u0027t expect a method such as \u0027PUT\u0027, \u0027DELETE\u0027 yet. Is it wrong ? In django, to address methods like \u0027PUT\u0027 or \u0027DELETE\u0027, it needs some care. For example, using the library like django-method-override.","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"22e383e3a7acfeb646d1f37381e653965039298b","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        return response"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def process_exception(self, request, exception):"},{"line_number":88,"context_line":"        \"\"\"Logging error info when exception occured.\"\"\""},{"line_number":89,"context_line":"        log_format \u003d self._get_log_format(request)"},{"line_number":90,"context_line":"        if log_format is None:"},{"line_number":91,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_5a3bb6eb","line":88,"range":{"start_line":88,"start_character":11,"end_line":88,"end_character":17},"updated":"2016-03-25 09:55:46.000000000","message":"Logging -\u003e Log","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"703d22ee0bf65df2195febbbc4991c40232eeae0","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        return response"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def process_exception(self, request, exception):"},{"line_number":88,"context_line":"        \"\"\"Logging error info when exception occured.\"\"\""},{"line_number":89,"context_line":"        log_format \u003d self._get_log_format(request)"},{"line_number":90,"context_line":"        if log_format is None:"},{"line_number":91,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_69d07154","line":88,"range":{"start_line":88,"start_character":11,"end_line":88,"end_character":17},"in_reply_to":"da0c15f0_5a3bb6eb","updated":"2016-03-27 02:47:26.000000000","message":"Done","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"22e383e3a7acfeb646d1f37381e653965039298b","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            for rule in self.STATIC_RULE:"},{"line_number":110,"context_line":"                if rule in request_url:"},{"line_number":111,"context_line":"                    return"},{"line_number":112,"context_line":"        return (\"[%(project_name)s] [%(project_id)s]\""},{"line_number":113,"context_line":"                \" [%(user_name)s] [%(user_id)s]\""},{"line_number":114,"context_line":"                \" [%(request_scheme)s] [%(referer_url)s] [%(request_url)s]\""},{"line_number":115,"context_line":"                \" [%(message)s] [%(method)s] [%(http_status)s] [%(param)s]\")"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def _get_parameters_from_request(self, request, exception\u003dFalse):"},{"line_number":118,"context_line":"        \"\"\"Get parameters to log in OPERATION_LOG.\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_15d3d139","line":115,"range":{"start_line":112,"start_character":15,"end_line":115,"end_character":75},"updated":"2016-03-25 09:55:46.000000000","message":"I don\u0027t like the hardcoded format.\nCould you make it configurable and document which parameters can be used in the format?","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"703d22ee0bf65df2195febbbc4991c40232eeae0","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            for rule in self.STATIC_RULE:"},{"line_number":110,"context_line":"                if rule in request_url:"},{"line_number":111,"context_line":"                    return"},{"line_number":112,"context_line":"        return (\"[%(project_name)s] [%(project_id)s]\""},{"line_number":113,"context_line":"                \" [%(user_name)s] [%(user_id)s]\""},{"line_number":114,"context_line":"                \" [%(request_scheme)s] [%(referer_url)s] [%(request_url)s]\""},{"line_number":115,"context_line":"                \" [%(message)s] [%(method)s] [%(http_status)s] [%(param)s]\")"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def _get_parameters_from_request(self, request, exception\u003dFalse):"},{"line_number":118,"context_line":"        \"\"\"Get parameters to log in OPERATION_LOG.\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_de4aecab","line":115,"range":{"start_line":112,"start_character":15,"end_line":115,"end_character":75},"in_reply_to":"da0c15f0_15d3d139","updated":"2016-03-27 02:47:26.000000000","message":"I changed the format string as configurable value.\nAdministrator can change it in local_settings.py","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"22e383e3a7acfeb646d1f37381e653965039298b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            \u0027project_name\u0027: getattr(user, \u0027project_name\u0027, None),"},{"line_number":128,"context_line":"            \u0027project_id\u0027: getattr(user, \u0027project_id\u0027, None),"},{"line_number":129,"context_line":"            \u0027user_name\u0027: getattr(user, \u0027username\u0027, None),"},{"line_number":130,"context_line":"            \u0027user_id\u0027: request.session.get(\u0027user_id\u0027, None),"},{"line_number":131,"context_line":"            \u0027request_scheme\u0027: request.scheme,"},{"line_number":132,"context_line":"            \u0027referer_url\u0027: referer_url,"},{"line_number":133,"context_line":"            \u0027request_url\u0027: urlparse.unquote(request.path),"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_b5ee65ea","line":130,"updated":"2016-03-25 09:55:46.000000000","message":"Isn\u0027t it better to include \"domain\"?","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"703d22ee0bf65df2195febbbc4991c40232eeae0","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            \u0027project_name\u0027: getattr(user, \u0027project_name\u0027, None),"},{"line_number":128,"context_line":"            \u0027project_id\u0027: getattr(user, \u0027project_id\u0027, None),"},{"line_number":129,"context_line":"            \u0027user_name\u0027: getattr(user, \u0027username\u0027, None),"},{"line_number":130,"context_line":"            \u0027user_id\u0027: request.session.get(\u0027user_id\u0027, None),"},{"line_number":131,"context_line":"            \u0027request_scheme\u0027: request.scheme,"},{"line_number":132,"context_line":"            \u0027referer_url\u0027: referer_url,"},{"line_number":133,"context_line":"            \u0027request_url\u0027: urlparse.unquote(request.path),"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_096a9580","line":130,"in_reply_to":"da0c15f0_b5ee65ea","updated":"2016-03-27 02:47:26.000000000","message":"I think so too, I added a \u0027domain_name\u0027 and \u0027domain_id\u0027.","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"22e383e3a7acfeb646d1f37381e653965039298b","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            \u0027referer_url\u0027: referer_url,"},{"line_number":133,"context_line":"            \u0027request_url\u0027: urlparse.unquote(request.path),"},{"line_number":134,"context_line":"            \u0027method\u0027: request.method if not exception else None,"},{"line_number":135,"context_line":"            \u0027param\u0027: self._get_post_param(request),"},{"line_number":136,"context_line":"        }"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def _get_post_param(self, request):"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_daaa2619","line":135,"range":{"start_line":135,"start_character":21,"end_line":135,"end_character":41},"updated":"2016-03-25 09:55:46.000000000","message":"Is the method name appropriate?\n\nOPERATION_LOG_TARGET_METHODS is configurable. This means users set this to other methods. I don\u0027t think it makes sense to use _get_post_param for other methods.","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"703d22ee0bf65df2195febbbc4991c40232eeae0","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            \u0027referer_url\u0027: referer_url,"},{"line_number":133,"context_line":"            \u0027request_url\u0027: urlparse.unquote(request.path),"},{"line_number":134,"context_line":"            \u0027method\u0027: request.method if not exception else None,"},{"line_number":135,"context_line":"            \u0027param\u0027: self._get_post_param(request),"},{"line_number":136,"context_line":"        }"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def _get_post_param(self, request):"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_c91d3d11","line":135,"range":{"start_line":135,"start_character":21,"end_line":135,"end_character":41},"in_reply_to":"da0c15f0_daaa2619","updated":"2016-03-27 02:47:26.000000000","message":"As you say, this is not only \u0027POST\u0027 data, so I changed this name \u0027get_request_param\u0027.","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"22e383e3a7acfeb646d1f37381e653965039298b","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            params \u003d request.POST.copy()"},{"line_number":143,"context_line":"            if not params:"},{"line_number":144,"context_line":"                params \u003d json.loads(request.body)"},{"line_number":145,"context_line":"        except Exception:"},{"line_number":146,"context_line":"            pass"},{"line_number":147,"context_line":"        for key, value in params.items():"},{"line_number":148,"context_line":"            # replace a value to a masked characters"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_35f895e5","line":145,"range":{"start_line":145,"start_character":15,"end_line":145,"end_character":24},"updated":"2016-03-25 09:55:46.000000000","message":"It is better to catch more specific exceptions.","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"703d22ee0bf65df2195febbbc4991c40232eeae0","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            params \u003d request.POST.copy()"},{"line_number":143,"context_line":"            if not params:"},{"line_number":144,"context_line":"                params \u003d json.loads(request.body)"},{"line_number":145,"context_line":"        except Exception:"},{"line_number":146,"context_line":"            pass"},{"line_number":147,"context_line":"        for key, value in params.items():"},{"line_number":148,"context_line":"            # replace a value to a masked characters"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_49bf6dd0","line":145,"range":{"start_line":145,"start_character":15,"end_line":145,"end_character":24},"in_reply_to":"da0c15f0_35f895e5","updated":"2016-03-27 02:47:26.000000000","message":"Done","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"22e383e3a7acfeb646d1f37381e653965039298b","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                params \u003d json.loads(request.body)"},{"line_number":145,"context_line":"        except Exception:"},{"line_number":146,"context_line":"            pass"},{"line_number":147,"context_line":"        for key, value in params.items():"},{"line_number":148,"context_line":"            # replace a value to a masked characters"},{"line_number":149,"context_line":"            for key in self.MASK_FIELDS:"},{"line_number":150,"context_line":"                params[key] \u003d \u0027*\u0027 * 8"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_f5d45d48","line":147,"range":{"start_line":147,"start_character":15,"end_line":147,"end_character":22},"updated":"2016-03-25 09:55:46.000000000","message":"\"value\" is unused.","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"703d22ee0bf65df2195febbbc4991c40232eeae0","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                params \u003d json.loads(request.body)"},{"line_number":145,"context_line":"        except Exception:"},{"line_number":146,"context_line":"            pass"},{"line_number":147,"context_line":"        for key, value in params.items():"},{"line_number":148,"context_line":"            # replace a value to a masked characters"},{"line_number":149,"context_line":"            for key in self.MASK_FIELDS:"},{"line_number":150,"context_line":"                params[key] \u003d \u0027*\u0027 * 8"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_89b505cf","line":147,"range":{"start_line":147,"start_character":15,"end_line":147,"end_character":22},"in_reply_to":"da0c15f0_f5d45d48","updated":"2016-03-27 02:47:26.000000000","message":"Done","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"22e383e3a7acfeb646d1f37381e653965039298b","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                params[key] \u003d \u0027*\u0027 * 8"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # when a file uploaded (E.g create image)"},{"line_number":153,"context_line":"        if len(list(request.FILES.values())) \u003e 0:"},{"line_number":154,"context_line":"            filenames \u003d \u0027, \u0027.join("},{"line_number":155,"context_line":"                [up_file.name for up_file in request.FILES.values()])"},{"line_number":156,"context_line":"            params[\u0027file_name\u0027] \u003d filenames"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_3546d523","line":153,"range":{"start_line":153,"start_character":7,"end_line":153,"end_character":49},"updated":"2016-03-25 09:55:46.000000000","message":"Doesn\u0027t the following work?\n\n  if request.FILES.values():\n\nWhy is list() needed?","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"703d22ee0bf65df2195febbbc4991c40232eeae0","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                params[key] \u003d \u0027*\u0027 * 8"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # when a file uploaded (E.g create image)"},{"line_number":153,"context_line":"        if len(list(request.FILES.values())) \u003e 0:"},{"line_number":154,"context_line":"            filenames \u003d \u0027, \u0027.join("},{"line_number":155,"context_line":"                [up_file.name for up_file in request.FILES.values()])"},{"line_number":156,"context_line":"            params[\u0027file_name\u0027] \u003d filenames"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_9efeb436","line":153,"range":{"start_line":153,"start_character":7,"end_line":153,"end_character":49},"in_reply_to":"da0c15f0_3546d523","updated":"2016-03-27 02:47:26.000000000","message":"I have tried this previously, an error would occur because return value type was not \u0027list\u0027 but \u0027generator\u0027. But I re-confirmed this code today and return value type was \u0027list\u0027. In addition, In fact, django reference also says this return value type is \u0027list\u0027, so it is unnecessary and I removed it.","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"19936b8768662fa6029290b5a49667c137202f3c","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                params[key] \u003d \u0027*\u0027 * 8"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # when a file uploaded (E.g create image)"},{"line_number":153,"context_line":"        if len(list(request.FILES.values())) \u003e 0:"},{"line_number":154,"context_line":"            filenames \u003d \u0027, \u0027.join("},{"line_number":155,"context_line":"                [up_file.name for up_file in request.FILES.values()])"},{"line_number":156,"context_line":"            params[\u0027file_name\u0027] \u003d filenames"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_39d4e21e","line":153,"range":{"start_line":153,"start_character":7,"end_line":153,"end_character":49},"in_reply_to":"da0c15f0_9efeb436","updated":"2016-03-27 04:15:36.000000000","message":"In previous comment, I had forgotten the condition when I had tested previously.\nIn the case of using python3, this value type is \u0027generator\u0027 ,so when checking the length, we have to cast to \u0027list\u0027.","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"22e383e3a7acfeb646d1f37381e653965039298b","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        # when a file uploaded (E.g create image)"},{"line_number":153,"context_line":"        if len(list(request.FILES.values())) \u003e 0:"},{"line_number":154,"context_line":"            filenames \u003d \u0027, \u0027.join("},{"line_number":155,"context_line":"                [up_file.name for up_file in request.FILES.values()])"},{"line_number":156,"context_line":"            params[\u0027file_name\u0027] \u003d filenames"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        return json.dumps(params, ensure_ascii\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_b552e5db","line":155,"range":{"start_line":155,"start_character":45,"end_line":155,"end_character":67},"updated":"2016-03-25 09:55:46.000000000","message":"We call values() twice. Can you assign it to a value?","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"703d22ee0bf65df2195febbbc4991c40232eeae0","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        # when a file uploaded (E.g create image)"},{"line_number":153,"context_line":"        if len(list(request.FILES.values())) \u003e 0:"},{"line_number":154,"context_line":"            filenames \u003d \u0027, \u0027.join("},{"line_number":155,"context_line":"                [up_file.name for up_file in request.FILES.values()])"},{"line_number":156,"context_line":"            params[\u0027file_name\u0027] \u003d filenames"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        return json.dumps(params, ensure_ascii\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_49c12de4","line":155,"range":{"start_line":155,"start_character":45,"end_line":155,"end_character":67},"in_reply_to":"da0c15f0_b552e5db","updated":"2016-03-27 02:47:26.000000000","message":"Done","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"}],"horizon/test/tests/middleware.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"22e383e3a7acfeb646d1f37381e653965039298b","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from django.http import HttpResponseRedirect  # noqa"},{"line_number":21,"context_line":"from django.utils import timezone"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from django.test.utils import override_settings"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from horizon import exceptions"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_35b9b5ea","line":22,"updated":"2016-03-25 09:55:46.000000000","message":"A blank line is unnecessary.","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"703d22ee0bf65df2195febbbc4991c40232eeae0","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from django.http import HttpResponseRedirect  # noqa"},{"line_number":21,"context_line":"from django.utils import timezone"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from django.test.utils import override_settings"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from horizon import exceptions"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_c9ad3d33","line":22,"in_reply_to":"da0c15f0_35b9b5ea","updated":"2016-03-27 02:47:26.000000000","message":"Done","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"408d8fbf7105eb7fa5c96ab5ace9b72657544ee2","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from horizon import exceptions"},{"line_number":26,"context_line":"from horizon import middleware"},{"line_number":27,"context_line":"from horizon.middlewares import operation_log as ol_middleware"},{"line_number":28,"context_line":"from horizon.test import helpers as test"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"1a122d0e_45905695","line":27,"range":{"start_line":27,"start_character":49,"end_line":27,"end_character":51},"updated":"2016-04-20 13:17:37.000000000","message":"\"ol\" is not easy to understand :(","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"700bb0862facba06816678221c8297f171ee71af","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from horizon import exceptions"},{"line_number":26,"context_line":"from horizon import middleware"},{"line_number":27,"context_line":"from horizon.middlewares import operation_log as ol_middleware"},{"line_number":28,"context_line":"from horizon.test import helpers as test"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"1a122d0e_78235905","line":27,"range":{"start_line":27,"start_character":49,"end_line":27,"end_character":51},"in_reply_to":"1a122d0e_45905695","updated":"2016-05-02 01:50:44.000000000","message":"Done","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"77b438df30e04b225450466fb3a4a495450eb134","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from django.http import HttpResponseRedirect  # noqa"},{"line_number":21,"context_line":"from django.test.utils import override_settings"},{"line_number":22,"context_line":"from django.utils import timezone"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from horizon import exceptions"},{"line_number":26,"context_line":"from horizon import middleware"}],"source_content_type":"text/x-python","patch_set":20,"id":"bab6814e_9798aa79","line":23,"updated":"2016-05-23 13:02:21.000000000","message":"L.23 is unnecessary.","commit_id":"c67d557544551f5bdc88d29e641e4429fe7eca3e"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"08cce71d5e1bab8c562c45e339b21cd39fe44bec","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from django.http import HttpResponseRedirect  # noqa"},{"line_number":21,"context_line":"from django.test.utils import override_settings"},{"line_number":22,"context_line":"from django.utils import timezone"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from horizon import exceptions"},{"line_number":26,"context_line":"from horizon import middleware"}],"source_content_type":"text/x-python","patch_set":20,"id":"bab6814e_66672feb","line":23,"in_reply_to":"bab6814e_9798aa79","updated":"2016-05-24 02:01:07.000000000","message":"Done","commit_id":"c67d557544551f5bdc88d29e641e4429fe7eca3e"}],"openstack_dashboard/local/local_settings.py.example":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"22e383e3a7acfeb646d1f37381e653965039298b","unresolved":false,"context_lines":[{"line_number":466,"context_line":"        },"},{"line_number":467,"context_line":"        \u0027operation\u0027: {"},{"line_number":468,"context_line":"            \u0027level\u0027: \u0027INFO\u0027,"},{"line_number":469,"context_line":"            # If you use this, you could enable settings below."},{"line_number":470,"context_line":"            # \u0027class\u0027: \u0027logging.FileHandler\u0027,"},{"line_number":471,"context_line":"            # \u0027filename\u0027: \u0027/opt/stack/logs/horizon_operation.log\u0027,"},{"line_number":472,"context_line":"            \u0027class\u0027: \u0027logging.StreamHandler\u0027,"},{"line_number":473,"context_line":"            \u0027formatter\u0027: \u0027operation\u0027,"},{"line_number":474,"context_line":"        },"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"da0c15f0_3a036275","line":471,"range":{"start_line":469,"start_character":11,"end_line":471,"end_character":66},"updated":"2016-03-25 09:55:46.000000000","message":"I cannot understand what this comment means.....","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"703d22ee0bf65df2195febbbc4991c40232eeae0","unresolved":false,"context_lines":[{"line_number":466,"context_line":"        },"},{"line_number":467,"context_line":"        \u0027operation\u0027: {"},{"line_number":468,"context_line":"            \u0027level\u0027: \u0027INFO\u0027,"},{"line_number":469,"context_line":"            # If you use this, you could enable settings below."},{"line_number":470,"context_line":"            # \u0027class\u0027: \u0027logging.FileHandler\u0027,"},{"line_number":471,"context_line":"            # \u0027filename\u0027: \u0027/opt/stack/logs/horizon_operation.log\u0027,"},{"line_number":472,"context_line":"            \u0027class\u0027: \u0027logging.StreamHandler\u0027,"},{"line_number":473,"context_line":"            \u0027formatter\u0027: \u0027operation\u0027,"},{"line_number":474,"context_line":"        },"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"da0c15f0_ca6feb90","line":471,"range":{"start_line":469,"start_character":11,"end_line":471,"end_character":66},"in_reply_to":"da0c15f0_3a036275","updated":"2016-03-27 02:47:26.000000000","message":"I\u0027m sorry for may ugly English..\nMy intend is that when someone use this feature, he/she needs to configure this setting. At least, in the case of outputting as a file. Is the proper place to write these explanation?","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"22e383e3a7acfeb646d1f37381e653965039298b","unresolved":false,"context_lines":[{"line_number":738,"context_line":"# For more information see:"},{"line_number":739,"context_line":"# http://tinyurl.com/anticlickjack"},{"line_number":740,"context_line":"#DISALLOW_IFRAME_EMBED \u003d True"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"# Settings for OperationLogMiddleware"},{"line_number":743,"context_line":"# OPERATION_LOG_ENABLED is flag to use the function to log an operation on"},{"line_number":744,"context_line":"# Horizon."}],"source_content_type":"application/octet-stream","patch_set":10,"id":"da0c15f0_550c2994","line":741,"updated":"2016-03-25 09:55:46.000000000","message":"The new settings should be documented in the document too.","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"703d22ee0bf65df2195febbbc4991c40232eeae0","unresolved":false,"context_lines":[{"line_number":738,"context_line":"# For more information see:"},{"line_number":739,"context_line":"# http://tinyurl.com/anticlickjack"},{"line_number":740,"context_line":"#DISALLOW_IFRAME_EMBED \u003d True"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"# Settings for OperationLogMiddleware"},{"line_number":743,"context_line":"# OPERATION_LOG_ENABLED is flag to use the function to log an operation on"},{"line_number":744,"context_line":"# Horizon."}],"source_content_type":"application/octet-stream","patch_set":10,"id":"da0c15f0_8a14d3f5","line":741,"in_reply_to":"da0c15f0_550c2994","updated":"2016-03-27 02:47:26.000000000","message":"Done","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"408d8fbf7105eb7fa5c96ab5ace9b72657544ee2","unresolved":false,"context_lines":[{"line_number":452,"context_line":"    \u0027formatters\u0027: {"},{"line_number":453,"context_line":"        \u0027operation\u0027: {"},{"line_number":454,"context_line":"            # message format is defiened by OPERATION_LOG_FORMAT"},{"line_number":455,"context_line":"            \u0027format\u0027: \u0027%(asctime)s %(message)s\u0027"},{"line_number":456,"context_line":"        },"},{"line_number":457,"context_line":"    },"},{"line_number":458,"context_line":"    \u0027handlers\u0027: {"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"1a122d0e_e549a232","line":455,"updated":"2016-04-20 13:17:37.000000000","message":"The message format is defined in OPERATION_LOG_FORMAT, so why do we need \u0027format\u0027 here? What does it do?","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f580a3ddecc6285a959c1da98d8b5bbb81b87b4f","unresolved":false,"context_lines":[{"line_number":452,"context_line":"    \u0027formatters\u0027: {"},{"line_number":453,"context_line":"        \u0027operation\u0027: {"},{"line_number":454,"context_line":"            # message format is defiened by OPERATION_LOG_FORMAT"},{"line_number":455,"context_line":"            \u0027format\u0027: \u0027%(asctime)s %(message)s\u0027"},{"line_number":456,"context_line":"        },"},{"line_number":457,"context_line":"    },"},{"line_number":458,"context_line":"    \u0027handlers\u0027: {"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"1a122d0e_6214d6e8","line":455,"in_reply_to":"1a122d0e_38d281d1","updated":"2016-05-04 03:17:42.000000000","message":"If so, the comment is confusing.\n\n  The format of \"%(message)s\" is defined by OPERATION_LOG_FORMAT\n\nbecause it is not clear whether the message format means the format here or the format of %(messages)s.","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"24a2fc83201d020e73dff3be32294ea1a285c97b","unresolved":false,"context_lines":[{"line_number":452,"context_line":"    \u0027formatters\u0027: {"},{"line_number":453,"context_line":"        \u0027operation\u0027: {"},{"line_number":454,"context_line":"            # message format is defiened by OPERATION_LOG_FORMAT"},{"line_number":455,"context_line":"            \u0027format\u0027: \u0027%(asctime)s %(message)s\u0027"},{"line_number":456,"context_line":"        },"},{"line_number":457,"context_line":"    },"},{"line_number":458,"context_line":"    \u0027handlers\u0027: {"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"dab17558_06d7d123","line":455,"in_reply_to":"1a122d0e_6214d6e8","updated":"2016-05-10 04:48:09.000000000","message":"As you say, just \"message\" make users to confuse.\nI\u0027ll address it.","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"700bb0862facba06816678221c8297f171ee71af","unresolved":false,"context_lines":[{"line_number":452,"context_line":"    \u0027formatters\u0027: {"},{"line_number":453,"context_line":"        \u0027operation\u0027: {"},{"line_number":454,"context_line":"            # message format is defiened by OPERATION_LOG_FORMAT"},{"line_number":455,"context_line":"            \u0027format\u0027: \u0027%(asctime)s %(message)s\u0027"},{"line_number":456,"context_line":"        },"},{"line_number":457,"context_line":"    },"},{"line_number":458,"context_line":"    \u0027handlers\u0027: {"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"1a122d0e_38d281d1","line":455,"in_reply_to":"1a122d0e_e549a232","updated":"2016-05-02 01:50:44.000000000","message":"This format is a conclusive format.\nContents of OPERATION_LOG_FORMAT will replace with %(message)s.","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a14f3187df27b11316e1d66fd61e5fc1123ad53e","unresolved":false,"context_lines":[{"line_number":468,"context_line":"    \u0027disable_existing_loggers\u0027: False,"},{"line_number":469,"context_line":"    \u0027formatters\u0027: {"},{"line_number":470,"context_line":"        \u0027operation\u0027: {"},{"line_number":471,"context_line":"            # message format is defiened by OPERATION_LOG_FORMAT"},{"line_number":472,"context_line":"            \u0027format\u0027: \u0027%(asctime)s %(message)s\u0027"},{"line_number":473,"context_line":"        },"},{"line_number":474,"context_line":"    },"}],"source_content_type":"application/octet-stream","patch_set":19,"id":"1a122d0e_e2362650","line":471,"updated":"2016-05-04 03:19:31.000000000","message":"See my reply comment on patch set 17.","commit_id":"f6b19aa848afa5f5ebf3aaab3fccbd221a9750be"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"185aa0f8258dd6f12ba0a8cb086db75741b05478","unresolved":false,"context_lines":[{"line_number":468,"context_line":"    \u0027disable_existing_loggers\u0027: False,"},{"line_number":469,"context_line":"    \u0027formatters\u0027: {"},{"line_number":470,"context_line":"        \u0027operation\u0027: {"},{"line_number":471,"context_line":"            # message format is defiened by OPERATION_LOG_FORMAT"},{"line_number":472,"context_line":"            \u0027format\u0027: \u0027%(asctime)s %(message)s\u0027"},{"line_number":473,"context_line":"        },"},{"line_number":474,"context_line":"    },"}],"source_content_type":"application/octet-stream","patch_set":19,"id":"dab17558_61104702","line":471,"in_reply_to":"1a122d0e_e2362650","updated":"2016-05-10 04:50:01.000000000","message":"Done","commit_id":"f6b19aa848afa5f5ebf3aaab3fccbd221a9750be"}],"releasenotes/notes/operation-history-log-64354f66614cb1dd.yaml":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"22e383e3a7acfeb646d1f37381e653965039298b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    this feature is enable."},{"line_number":8,"context_line":"    And before you use this feature you need to set the logging handler"},{"line_number":9,"context_line":"    like class, filename, formatter for your environment in local_settings.py."},{"line_number":10,"context_line":"  - Furthermore, this feature only log \u0027POST\u0027 in default setting."},{"line_number":11,"context_line":"    (It is in order to avoid to increase log file size.)"},{"line_number":12,"context_line":"    If you would like to log \u0027GET\u0027 request, you can configure"},{"line_number":13,"context_line":"    ``OPERATION_LOG_METHOD_TARGETS \u003d [\u0027POST\u0027, \u0027GET\u0027]``."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"da0c15f0_7a3e7ab9","line":10,"updated":"2016-03-25 09:55:46.000000000","message":"You should use only one item.\nSee http://docs-draft.openstack.org/35/272935/10/check/gate-horizon-releasenotes/8d6d88b//releasenotes/build/html/unreleased.html#new-features","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"703d22ee0bf65df2195febbbc4991c40232eeae0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    this feature is enable."},{"line_number":8,"context_line":"    And before you use this feature you need to set the logging handler"},{"line_number":9,"context_line":"    like class, filename, formatter for your environment in local_settings.py."},{"line_number":10,"context_line":"  - Furthermore, this feature only log \u0027POST\u0027 in default setting."},{"line_number":11,"context_line":"    (It is in order to avoid to increase log file size.)"},{"line_number":12,"context_line":"    If you would like to log \u0027GET\u0027 request, you can configure"},{"line_number":13,"context_line":"    ``OPERATION_LOG_METHOD_TARGETS \u003d [\u0027POST\u0027, \u0027GET\u0027]``."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"da0c15f0_7ede4040","line":10,"in_reply_to":"da0c15f0_7a3e7ab9","updated":"2016-03-27 02:47:26.000000000","message":"Done. I moved these explanations into devref.","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"22e383e3a7acfeb646d1f37381e653965039298b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    In addition, if you would like to mask some data like password,"},{"line_number":15,"context_line":"    you can configure ``OPERATION_LOG_MASK_TARGETS \u003d [\u0027password\u0027]``."},{"line_number":16,"context_line":"    this value is the key of post data and masked data is logged"},{"line_number":17,"context_line":"    as \u0027********\u0027."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"da0c15f0_ba48125d","line":17,"updated":"2016-03-25 09:55:46.000000000","message":"This kind of detail should be wrote in our devref doc.","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"703d22ee0bf65df2195febbbc4991c40232eeae0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    In addition, if you would like to mask some data like password,"},{"line_number":15,"context_line":"    you can configure ``OPERATION_LOG_MASK_TARGETS \u003d [\u0027password\u0027]``."},{"line_number":16,"context_line":"    this value is the key of post data and masked data is logged"},{"line_number":17,"context_line":"    as \u0027********\u0027."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"da0c15f0_fe1b7019","line":17,"in_reply_to":"da0c15f0_ba48125d","updated":"2016-03-27 02:47:26.000000000","message":"Done","commit_id":"51a6e3a68c2c4e442dea9119df90e595d78a7524"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"408d8fbf7105eb7fa5c96ab5ace9b72657544ee2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`blueprint operation-history-log \u003chttps://blueprints.launchpad.net/horizon/+spec/operation-history-log\u003e`_]"},{"line_number":5,"context_line":"    Added the feature to log operation history of users to Horizon."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1a122d0e_85070e81","line":5,"range":{"start_line":5,"start_character":56,"end_line":5,"end_character":66},"updated":"2016-04-20 13:17:37.000000000","message":"\"to Horizon\" is unnecessary because it is a horizon release note.","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"700bb0862facba06816678221c8297f171ee71af","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`blueprint operation-history-log \u003chttps://blueprints.launchpad.net/horizon/+spec/operation-history-log\u003e`_]"},{"line_number":5,"context_line":"    Added the feature to log operation history of users to Horizon."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1a122d0e_78d879ef","line":5,"range":{"start_line":5,"start_character":56,"end_line":5,"end_character":66},"in_reply_to":"1a122d0e_85070e81","updated":"2016-05-02 01:50:44.000000000","message":"Done","commit_id":"51a6261d2a7e3269ef73f46c9068528b52716222"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"77b438df30e04b225450466fb3a4a495450eb134","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`blueprint operation-history-log \u003chttps://blueprints.launchpad.net/horizon/+spec/operation-history-log\u003e`_]"},{"line_number":5,"context_line":"    Added the feature to log operation history of users."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"bab6814e_b7f68e5a","line":5,"range":{"start_line":5,"start_character":10,"end_line":5,"end_character":13},"updated":"2016-05-23 13:02:21.000000000","message":"the -\u003e a","commit_id":"c67d557544551f5bdc88d29e641e4429fe7eca3e"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"08cce71d5e1bab8c562c45e339b21cd39fe44bec","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`blueprint operation-history-log \u003chttps://blueprints.launchpad.net/horizon/+spec/operation-history-log\u003e`_]"},{"line_number":5,"context_line":"    Added the feature to log operation history of users."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"bab6814e_865e9310","line":5,"range":{"start_line":5,"start_character":10,"end_line":5,"end_character":13},"in_reply_to":"bab6814e_b7f68e5a","updated":"2016-05-24 02:01:07.000000000","message":"Done","commit_id":"c67d557544551f5bdc88d29e641e4429fe7eca3e"}]}
