)]}'
{"tools/gate/integration/post_test_hook.sh":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"cca5e32899a74182f3aa28a93c8312de6cc1590e","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"set -x"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"set +e"},{"line_number":8,"context_line":"cd /opt/stack/new/horizon"},{"line_number":9,"context_line":"sudo -H -u stack tox -e py27integration"},{"line_number":10,"context_line":"retval\u003d$?"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3a57f1b5_1c66c9ed","line":7,"updated":"2016-02-10 09:52:25.000000000","message":"Not sure which thing you\u0027re trying to achieve here. This script already doesn\u0027t immediately exit on error in integration tests, what\u0027s the point of setting set +e / set -e?","commit_id":"2349ea5374c8f51e4eba3a046ecb4c933a5b97ae"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"f5c582d16defc1f230a8dd0f918696cd51dc6b18","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"set -x"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"set +e"},{"line_number":8,"context_line":"cd /opt/stack/new/horizon"},{"line_number":9,"context_line":"sudo -H -u stack tox -e py27integration"},{"line_number":10,"context_line":"retval\u003d$?"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3a57f1b5_2f97b791","line":7,"in_reply_to":"3a57f1b5_14e3eea4","updated":"2016-02-10 15:21:15.000000000","message":"Actually lines 13-15 are needed because if screenshots are not located inside jenkins workspace, it won\u0027t be able to collect artifacts from VM before it\u0027s destroyed. We spent quite a significant time several months ago investigating this behavior ;).","commit_id":"2349ea5374c8f51e4eba3a046ecb4c933a5b97ae"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"456388b210929e6732e921147fe65a1b3167a468","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"set -x"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"set +e"},{"line_number":8,"context_line":"cd /opt/stack/new/horizon"},{"line_number":9,"context_line":"sudo -H -u stack tox -e py27integration"},{"line_number":10,"context_line":"retval\u003d$?"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3a57f1b5_14e3eea4","line":7,"in_reply_to":"3a57f1b5_1c66c9ed","updated":"2016-02-10 15:16:28.000000000","message":"Looking at the logs, I believe it is exiting on error, but since this copy is not really needed anyway in the horizon case, it does not effect anything.  My next patch was to remove the copy statement to clean this up a bit more.","commit_id":"2349ea5374c8f51e4eba3a046ecb4c933a5b97ae"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"39d1aa4cbf2d4869029cb2b36673f42579a5f1c2","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"set -x"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"set +e"},{"line_number":8,"context_line":"cd /opt/stack/new/horizon"},{"line_number":9,"context_line":"sudo -H -u stack tox -e py27integration"},{"line_number":10,"context_line":"retval\u003d$?"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3a57f1b5_472d2545","line":7,"in_reply_to":"3a57f1b5_2f97b791","updated":"2016-02-10 21:42:01.000000000","message":"Humm, looking at current log failures: http://logs.openstack.org/23/262323/5/check/gate-horizon-dsvm-integration/ee3c976/console.html  you will see that lines 13-15 are not executed, but yet the screenshot is still available.  \n\nThe issue I saw with this same scenario with the sahara-dashboard was that in that case the screen shots were captured into the .tox dir, therefore the copy step was needed to pull them up to the /opt/new level so the cleanup step could find them (like it does with the logs).\n\nIf you want, I can remove the +e -e and just leave the -x for tracing, and we can continue to look at the screenshots later.","commit_id":"2349ea5374c8f51e4eba3a046ecb4c933a5b97ae"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"bbc7d322a4adf31e7a53d5ce9cd01378d2f627b5","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"set -x"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"set +e"},{"line_number":8,"context_line":"cd /opt/stack/new/horizon"},{"line_number":9,"context_line":"sudo -H -u stack tox -e py27integration"},{"line_number":10,"context_line":"retval\u003d$?"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1af94dfe_6e7848c5","line":7,"updated":"2016-03-16 17:11:39.000000000","message":"Still don\u0027t understand why do we need it here.","commit_id":"568c83c0e69fab9d803d3f16cd519fe683623689"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"985186162d227bb2a7f61232e9794de5c8123737","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"set -x"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"set +e"},{"line_number":8,"context_line":"cd /opt/stack/new/horizon"},{"line_number":9,"context_line":"sudo -H -u stack tox -e py27integration"},{"line_number":10,"context_line":"retval\u003d$?"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1af94dfe_1befc91e","line":7,"in_reply_to":"1af94dfe_6e7848c5","updated":"2016-03-18 16:45:34.000000000","message":"I thought is was need as in other jobs I was seeing that when the tox cmd failed, the script was exited and the cp screenshots step was skipped.  I\u0027ll remove for now until I can re confirm that, and post another patch if needed.","commit_id":"568c83c0e69fab9d803d3f16cd519fe683623689"}]}
