)]}'
{"openstack_dashboard/test/integration_tests/pages/project/compute/imagespage.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"920b423eef78059aa878f52d1e71399799eccc38","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        \"volume_id\", \"volume_snapshot_id\", \"image_id\", \"volume_size\","},{"line_number":38,"context_line":"        \"vol_delete_on_instance_delete\"),"},{"line_number":39,"context_line":"        (\"keypair\", \"groups\"),"},{"line_number":40,"context_line":"        (\"script_source\", \"script_upload\", \"script_data\"),"},{"line_number":41,"context_line":"        (\"disk_config\", \"config_drive\")"},{"line_number":42,"context_line":"    )"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"3a57f1b5_02801fbf","line":40,"updated":"2016-02-12 11:32:06.000000000","message":"Please note that tabs\u0027 field mappings are bound in order of appearance, so this mappings are going to be bound to Networks tab. You might want to take a look at https://review.openstack.org/#/c/276075/7/openstack_dashboard/test/integration_tests/pages/project/compute/instancespage.py (though I haven\u0027t reviewed it yet).","commit_id":"ba7ca50293dc110fa10105e162b95c0cb305e7a6"},{"author":{"_account_id":19333,"name":"Alexandra Allakhverdieva","email":"aallakhverdieva@mirantis.com","username":"AlexandraAllakhverdieva"},"change_message_id":"86ebc2268c9f6aa6aeb42524f2b4e7bb88bd48b8","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        \"volume_id\", \"volume_snapshot_id\", \"image_id\", \"volume_size\","},{"line_number":38,"context_line":"        \"vol_delete_on_instance_delete\"),"},{"line_number":39,"context_line":"        (\"keypair\", \"groups\"),"},{"line_number":40,"context_line":"        (\"script_source\", \"script_upload\", \"script_data\"),"},{"line_number":41,"context_line":"        (\"disk_config\", \"config_drive\")"},{"line_number":42,"context_line":"    )"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"3a57f1b5_69c6969b","line":40,"in_reply_to":"3a57f1b5_02801fbf","updated":"2016-02-12 12:52:23.000000000","message":"Ok, thanks, I\u0027ll keep that in mind","commit_id":"ba7ca50293dc110fa10105e162b95c0cb305e7a6"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"920b423eef78059aa878f52d1e71399799eccc38","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        return forms.BaseFormRegion(self.driver, self.conf)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @tables.bind_row_action(\u0027create_volume_from_image\u0027)"},{"line_number":56,"context_line":"    def create_volume_from_image(self, create_volume, row):"},{"line_number":57,"context_line":"        create_volume.click()"},{"line_number":58,"context_line":"        return forms.FormRegion("},{"line_number":59,"context_line":"            self.driver, self.conf,"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a57f1b5_e2c86324","line":56,"updated":"2016-02-12 11:32:06.000000000","message":"(optional) Wouldn\u0027t it be easier to just name it `create_volume`?","commit_id":"ba7ca50293dc110fa10105e162b95c0cb305e7a6"},{"author":{"_account_id":19333,"name":"Alexandra Allakhverdieva","email":"aallakhverdieva@mirantis.com","username":"AlexandraAllakhverdieva"},"change_message_id":"86ebc2268c9f6aa6aeb42524f2b4e7bb88bd48b8","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        return forms.BaseFormRegion(self.driver, self.conf)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @tables.bind_row_action(\u0027create_volume_from_image\u0027)"},{"line_number":56,"context_line":"    def create_volume_from_image(self, create_volume, row):"},{"line_number":57,"context_line":"        create_volume.click()"},{"line_number":58,"context_line":"        return forms.FormRegion("},{"line_number":59,"context_line":"            self.driver, self.conf,"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a57f1b5_893992d9","line":56,"in_reply_to":"3a57f1b5_e2c86324","updated":"2016-02-12 12:52:23.000000000","message":"Done","commit_id":"ba7ca50293dc110fa10105e162b95c0cb305e7a6"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"920b423eef78059aa878f52d1e71399799eccc38","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            field_mappings\u003dself.CREATE_VOLUME_FROM_IMAGE_FORM_FIELDS)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @tables.bind_row_action(\u0027launch_image\u0027, primary\u003dTrue)"},{"line_number":63,"context_line":"    def launch_instance_from_image(self, launch_instance, row):"},{"line_number":64,"context_line":"        launch_instance.click()"},{"line_number":65,"context_line":"        return forms.TabbedFormRegion("},{"line_number":66,"context_line":"            self.driver, self.conf,"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a57f1b5_62dd53df","line":63,"updated":"2016-02-12 11:32:06.000000000","message":"(optional) ditto, launch_instance","commit_id":"ba7ca50293dc110fa10105e162b95c0cb305e7a6"},{"author":{"_account_id":19333,"name":"Alexandra Allakhverdieva","email":"aallakhverdieva@mirantis.com","username":"AlexandraAllakhverdieva"},"change_message_id":"86ebc2268c9f6aa6aeb42524f2b4e7bb88bd48b8","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            field_mappings\u003dself.CREATE_VOLUME_FROM_IMAGE_FORM_FIELDS)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @tables.bind_row_action(\u0027launch_image\u0027, primary\u003dTrue)"},{"line_number":63,"context_line":"    def launch_instance_from_image(self, launch_instance, row):"},{"line_number":64,"context_line":"        launch_instance.click()"},{"line_number":65,"context_line":"        return forms.TabbedFormRegion("},{"line_number":66,"context_line":"            self.driver, self.conf,"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a57f1b5_2932def2","line":63,"in_reply_to":"3a57f1b5_62dd53df","updated":"2016-02-12 12:52:23.000000000","message":"Done","commit_id":"ba7ca50293dc110fa10105e162b95c0cb305e7a6"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"920b423eef78059aa878f52d1e71399799eccc38","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            self.conf.launch_instances.available_zone"},{"line_number":161,"context_line":"        launch_instance.name.text \u003d instance_name"},{"line_number":162,"context_line":"        if flavor is None:"},{"line_number":163,"context_line":"            flavor \u003d \u0027m1.tiny\u0027"},{"line_number":164,"context_line":"        launch_instance.flavor.text \u003d flavor"},{"line_number":165,"context_line":"        launch_instance.count.value \u003d instance_count"},{"line_number":166,"context_line":"        launch_instance.submit()"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a57f1b5_95a207fb","line":163,"updated":"2016-02-12 11:32:06.000000000","message":"I think default flavor is ready to be moved to horizon.conf.","commit_id":"ba7ca50293dc110fa10105e162b95c0cb305e7a6"},{"author":{"_account_id":19333,"name":"Alexandra Allakhverdieva","email":"aallakhverdieva@mirantis.com","username":"AlexandraAllakhverdieva"},"change_message_id":"86ebc2268c9f6aa6aeb42524f2b4e7bb88bd48b8","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            self.conf.launch_instances.available_zone"},{"line_number":161,"context_line":"        launch_instance.name.text \u003d instance_name"},{"line_number":162,"context_line":"        if flavor is None:"},{"line_number":163,"context_line":"            flavor \u003d \u0027m1.tiny\u0027"},{"line_number":164,"context_line":"        launch_instance.flavor.text \u003d flavor"},{"line_number":165,"context_line":"        launch_instance.count.value \u003d instance_count"},{"line_number":166,"context_line":"        launch_instance.submit()"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a57f1b5_e94e066e","line":163,"in_reply_to":"3a57f1b5_95a207fb","updated":"2016-02-12 12:52:23.000000000","message":"Done","commit_id":"ba7ca50293dc110fa10105e162b95c0cb305e7a6"}],"openstack_dashboard/test/integration_tests/tests/test_images.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"920b423eef78059aa878f52d1e71399799eccc38","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            images_page.find_message_and_dismiss(messages.INFO))"},{"line_number":122,"context_line":"        self.assertFalse("},{"line_number":123,"context_line":"            images_page.find_message_and_dismiss(messages.ERROR))"},{"line_number":124,"context_line":"        volumes_page \u003d self.home_pg.go_to_compute_volumes_volumespage()"},{"line_number":125,"context_line":"        self.assertTrue(volumes_page.is_volume_present(target_volume))"},{"line_number":126,"context_line":"        self.assertTrue(volumes_page.is_volume_status(target_volume,"},{"line_number":127,"context_line":"                                                      \u0027Available\u0027))"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a57f1b5_d5eabf0e","line":124,"updated":"2016-02-12 11:32:06.000000000","message":"It seems we are being automatically redirected to volumes page as soon as volume is created from image. Could you return a reference to volumes page from create_volume_from_image() to capture this workflow in tests? If redirect breaks, test will catch that.","commit_id":"ba7ca50293dc110fa10105e162b95c0cb305e7a6"},{"author":{"_account_id":19333,"name":"Alexandra Allakhverdieva","email":"aallakhverdieva@mirantis.com","username":"AlexandraAllakhverdieva"},"change_message_id":"86ebc2268c9f6aa6aeb42524f2b4e7bb88bd48b8","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            images_page.find_message_and_dismiss(messages.INFO))"},{"line_number":122,"context_line":"        self.assertFalse("},{"line_number":123,"context_line":"            images_page.find_message_and_dismiss(messages.ERROR))"},{"line_number":124,"context_line":"        volumes_page \u003d self.home_pg.go_to_compute_volumes_volumespage()"},{"line_number":125,"context_line":"        self.assertTrue(volumes_page.is_volume_present(target_volume))"},{"line_number":126,"context_line":"        self.assertTrue(volumes_page.is_volume_status(target_volume,"},{"line_number":127,"context_line":"                                                      \u0027Available\u0027))"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a57f1b5_e975a697","line":124,"in_reply_to":"3a57f1b5_d5eabf0e","updated":"2016-02-12 12:52:23.000000000","message":"Done","commit_id":"ba7ca50293dc110fa10105e162b95c0cb305e7a6"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"920b423eef78059aa878f52d1e71399799eccc38","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        images_page.launch_instance_from_image(source_image, target_instance)"},{"line_number":147,"context_line":"        self.assertTrue(images_page.find_message_and_dismiss(messages.SUCCESS))"},{"line_number":148,"context_line":"        self.assertFalse(images_page.find_message_and_dismiss(messages.ERROR))"},{"line_number":149,"context_line":"        instances_page \u003d self.home_pg.go_to_compute_instancespage()"},{"line_number":150,"context_line":"        self.assertTrue(instances_page.is_instance_active(target_instance))"},{"line_number":151,"context_line":"        actual_image_name \u003d instances_page.get_image_name(target_instance)"},{"line_number":152,"context_line":"        self.assertEqual(source_image, actual_image_name)"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a57f1b5_a2da6b49","line":149,"updated":"2016-02-12 11:32:06.000000000","message":"It seems we are being automatically redirected to instance page as soon as instance is launched from image. Could you return a reference to instance page from launch_instance_from_image() to capture this workflow in tests? If redirect breaks, test will catch that.","commit_id":"ba7ca50293dc110fa10105e162b95c0cb305e7a6"},{"author":{"_account_id":19333,"name":"Alexandra Allakhverdieva","email":"aallakhverdieva@mirantis.com","username":"AlexandraAllakhverdieva"},"change_message_id":"86ebc2268c9f6aa6aeb42524f2b4e7bb88bd48b8","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        images_page.launch_instance_from_image(source_image, target_instance)"},{"line_number":147,"context_line":"        self.assertTrue(images_page.find_message_and_dismiss(messages.SUCCESS))"},{"line_number":148,"context_line":"        self.assertFalse(images_page.find_message_and_dismiss(messages.ERROR))"},{"line_number":149,"context_line":"        instances_page \u003d self.home_pg.go_to_compute_instancespage()"},{"line_number":150,"context_line":"        self.assertTrue(instances_page.is_instance_active(target_instance))"},{"line_number":151,"context_line":"        actual_image_name \u003d instances_page.get_image_name(target_instance)"},{"line_number":152,"context_line":"        self.assertEqual(source_image, actual_image_name)"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a57f1b5_097b628d","line":149,"in_reply_to":"3a57f1b5_a2da6b49","updated":"2016-02-12 12:52:23.000000000","message":"Done","commit_id":"ba7ca50293dc110fa10105e162b95c0cb305e7a6"}]}
