)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"5050a01dd16a3aae81085a12961e58693ae78a71","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When listing all cinder volumes the user may not have"},{"line_number":10,"context_line":"permissions to see the volume transfers."},{"line_number":11,"context_line":"This patch makes it so the call to transfer_list"},{"line_number":12,"context_line":"is protected against Forbiden errir so the user can still"},{"line_number":13,"context_line":"see the volume list."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I575ffebcd5084165e72f6e100ed43b4d3f358e98"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dae33548_f09dae5a","line":12,"range":{"start_line":12,"start_character":30,"end_line":12,"end_character":35},"updated":"2016-02-14 07:39:09.000000000","message":"s/errir/error","commit_id":"3bb1a24ac432ecbe7fff2d20d97608b6cd32eed9"}],"openstack_dashboard/api/cinder.py":[{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"0d6d670a3ffb62f3994631d3064351d7cc3ab10d","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        transfers \u003d {t.volume_id: t"},{"line_number":221,"context_line":"                     for t in transfer_list(request, search_opts\u003dsearch_opts)}"},{"line_number":222,"context_line":"    except cinder_exception.Forbidden:"},{"line_number":223,"context_line":"        transfers \u003d {}"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    if VERSIONS.active \u003e 1 and paginate:"},{"line_number":226,"context_line":"        page_size \u003d utils.get_page_size(request)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_011e4fba","line":223,"range":{"start_line":223,"start_character":20,"end_line":223,"end_character":22},"updated":"2016-02-10 15:47:35.000000000","message":"Why we don\u0027t logging forbidden exception here and below? It could be useful for user to get message with this error, isn\u0027it?","commit_id":"c6565becb73cf1ac32db9b1eeeb2fa36b9d5e06a"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"25b7c8ffea45ae4186265480fbbbdbbbea34aa7e","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        transfers \u003d {t.volume_id: t"},{"line_number":221,"context_line":"                     for t in transfer_list(request, search_opts\u003dsearch_opts)}"},{"line_number":222,"context_line":"    except cinder_exception.Forbidden:"},{"line_number":223,"context_line":"        transfers \u003d {}"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    if VERSIONS.active \u003e 1 and paginate:"},{"line_number":226,"context_line":"        page_size \u003d utils.get_page_size(request)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_45042449","line":223,"in_reply_to":"3a57f1b5_011e4fba","updated":"2016-02-11 10:11:05.000000000","message":"Good point Paul.","commit_id":"c6565becb73cf1ac32db9b1eeeb2fa36b9d5e06a"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"e54baeee9ccc171bf67eae1d22a863335af4b7ad","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        return volumes, has_more_data, has_prev_data"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    # build a dictionary of volume_id -\u003e transfer"},{"line_number":219,"context_line":"    try:"},{"line_number":220,"context_line":"        transfers \u003d {t.volume_id: t"},{"line_number":221,"context_line":"                     for t in transfer_list(request, search_opts\u003dsearch_opts)}"},{"line_number":222,"context_line":"    except cinder_exception.Forbidden as error:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a57f1b5_fc1a31c5","line":219,"updated":"2016-02-12 17:41:34.000000000","message":"why not handle the forbidden error in transfer_list and have it return an empty list?","commit_id":"e3f8190680a088b17099654ccf2027f0961bafcb"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"34e5b4498807e2b16b084a4005341aaa221b81a7","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        return volumes, has_more_data, has_prev_data"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    # build a dictionary of volume_id -\u003e transfer"},{"line_number":219,"context_line":"    try:"},{"line_number":220,"context_line":"        transfers \u003d {t.volume_id: t"},{"line_number":221,"context_line":"                     for t in transfer_list(request, search_opts\u003dsearch_opts)}"},{"line_number":222,"context_line":"    except cinder_exception.Forbidden as error:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a57f1b5_6240da07","line":219,"in_reply_to":"3a57f1b5_fc1a31c5","updated":"2016-02-12 18:12:28.000000000","message":"good point, it makes more sense to do it in there.","commit_id":"e3f8190680a088b17099654ccf2027f0961bafcb"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"5050a01dd16a3aae81085a12961e58693ae78a71","unresolved":false,"context_lines":[{"line_number":687,"context_line":"            detailed\u003ddetailed, search_opts\u003dsearch_opts)]"},{"line_number":688,"context_line":"    except cinder_exception.Forbidden as error:"},{"line_number":689,"context_line":"        LOG.error(error)"},{"line_number":690,"context_line":"        return []"},{"line_number":691,"context_line":""},{"line_number":692,"context_line":""},{"line_number":693,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_d0b50ad1","line":690,"range":{"start_line":690,"start_character":8,"end_line":690,"end_character":14},"updated":"2016-02-14 07:39:09.000000000","message":"Seems here only 2 lines are needed, otherwise you cannot pass the jenkins.","commit_id":"3bb1a24ac432ecbe7fff2d20d97608b6cd32eed9"},{"author":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"change_message_id":"4adef36b37526d1b43db8a6fdc141910913b1cb3","unresolved":false,"context_lines":[{"line_number":687,"context_line":"            detailed\u003ddetailed, search_opts\u003dsearch_opts)]"},{"line_number":688,"context_line":"    except cinder_exception.Forbidden as error:"},{"line_number":689,"context_line":"        LOG.error(error)"},{"line_number":690,"context_line":"        return []"},{"line_number":691,"context_line":""},{"line_number":692,"context_line":""},{"line_number":693,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_d0306a0a","line":690,"range":{"start_line":690,"start_character":8,"end_line":690,"end_character":14},"in_reply_to":"dae33548_d0b50ad1","updated":"2016-02-14 08:04:30.000000000","message":"+1","commit_id":"3bb1a24ac432ecbe7fff2d20d97608b6cd32eed9"}]}
