)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"6e2f9d6804e594dc53286d00bb72aa8c58fa696c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Right now we are showing the \"open console\" link on the"},{"line_number":10,"context_line":"network topology screen for instances on each instance,"},{"line_number":11,"context_line":"even if they are on a status theat we know its not"},{"line_number":12,"context_line":"gonna allow the console to connect."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch makes it so the \"open console\" link will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a57f1b5_55587dfa","line":11,"range":{"start_line":11,"start_character":29,"end_line":11,"end_character":34},"updated":"2016-02-10 16:34:06.000000000","message":"typo: \"theat\" --\u003e \"that\"","commit_id":"99a8a94a7669515e9fcf96877957197c499abf43"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"c525ea08a3b9a7a34191727b9adad487883358e6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Right now we are showing the \"open console\" link on the"},{"line_number":10,"context_line":"network topology screen for instances on each instance,"},{"line_number":11,"context_line":"even if they are on a status theat we know its not"},{"line_number":12,"context_line":"gonna allow the console to connect."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch makes it so the \"open console\" link will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a57f1b5_70f827e6","line":11,"in_reply_to":"3a57f1b5_55587dfa","updated":"2016-02-10 16:45:23.000000000","message":"Done","commit_id":"99a8a94a7669515e9fcf96877957197c499abf43"},{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"6e2f9d6804e594dc53286d00bb72aa8c58fa696c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Right now we are showing the \"open console\" link on the"},{"line_number":10,"context_line":"network topology screen for instances on each instance,"},{"line_number":11,"context_line":"even if they are on a status theat we know its not"},{"line_number":12,"context_line":"gonna allow the console to connect."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch makes it so the \"open console\" link will"},{"line_number":15,"context_line":"only appear if the instance object has console data."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a57f1b5_f50089ac","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":5},"updated":"2016-02-10 16:34:06.000000000","message":"grammar: \"gonna\" --\u003e \"going to\"","commit_id":"99a8a94a7669515e9fcf96877957197c499abf43"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"c525ea08a3b9a7a34191727b9adad487883358e6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Right now we are showing the \"open console\" link on the"},{"line_number":10,"context_line":"network topology screen for instances on each instance,"},{"line_number":11,"context_line":"even if they are on a status theat we know its not"},{"line_number":12,"context_line":"gonna allow the console to connect."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch makes it so the \"open console\" link will"},{"line_number":15,"context_line":"only appear if the instance object has console data."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a57f1b5_b0d53f44","line":12,"in_reply_to":"3a57f1b5_f50089ac","updated":"2016-02-10 16:45:23.000000000","message":"Done","commit_id":"99a8a94a7669515e9fcf96877957197c499abf43"}],"openstack_dashboard/dashboards/project/network_topology/templates/network_topology/client_side/_balloon_container.html":[{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"6e2f9d6804e594dc53286d00bb72aa8c58fa696c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    \u003cdiv class\u003d\"footerInner\"\u003e"},{"line_number":16,"context_line":"      \u003cdiv class\u003d\"cell link\"\u003e"},{"line_number":17,"context_line":"        \u003ca href\u003d\"[[url]]\"\u003e» [[view_details_label]]\u003c/a\u003e"},{"line_number":18,"context_line":"          {% comment %}The console link will only appear if the console item is defined"},{"line_number":19,"context_line":"          on the javascript side while rendering the template.{% endcomment %}"},{"line_number":20,"context_line":"            [[#console]]"},{"line_number":21,"context_line":"            \u003ca href\u003d\"[[url]][[console]]\" class\u003d\"vnc_window\"\u003e» [[open_console_label]]\u003c/a\u003e"},{"line_number":22,"context_line":"            [[/console]]"},{"line_number":23,"context_line":"      \u003c/div\u003e"},{"line_number":24,"context_line":"      [[#type]]"},{"line_number":25,"context_line":"      \u003cdiv class\u003d\"cell delete\"\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"3a57f1b5_f5b6493c","line":22,"range":{"start_line":18,"start_character":10,"end_line":22,"end_character":24},"updated":"2016-02-10 16:34:06.000000000","message":"None of these lines need to be indented under the \u003ca\u003e tag.","commit_id":"99a8a94a7669515e9fcf96877957197c499abf43"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"c525ea08a3b9a7a34191727b9adad487883358e6","unresolved":false,"context_lines":[{"line_number":19,"context_line":"          on the javascript side while rendering the template.{% endcomment %}"},{"line_number":20,"context_line":"            [[#console]]"},{"line_number":21,"context_line":"            \u003ca href\u003d\"[[url]][[console]]\" class\u003d\"vnc_window\"\u003e» [[open_console_label]]\u003c/a\u003e"},{"line_number":22,"context_line":"            [[/console]]"},{"line_number":23,"context_line":"      \u003c/div\u003e"},{"line_number":24,"context_line":"      [[#type]]"},{"line_number":25,"context_line":"      \u003cdiv class\u003d\"cell delete\"\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"3a57f1b5_3094ef89","line":22,"in_reply_to":"3a57f1b5_f5b6493c","updated":"2016-02-10 16:45:23.000000000","message":"Lucas, I just respected the indentation that was already there. I think it works visually to differentiate the different levels of the template.","commit_id":"99a8a94a7669515e9fcf96877957197c499abf43"}],"openstack_dashboard/dashboards/project/network_topology/views.py":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"2d1e592f8ba57b3f54b8073d3ea00227817db747","unresolved":false,"context_lines":[{"line_number":81,"context_line":"console_invalid_status \u003d ["},{"line_number":82,"context_line":"    \u0027shutoff\u0027, \u0027suspended\u0027, \u0027resize\u0027, \u0027verify_resize\u0027,"},{"line_number":83,"context_line":"    \u0027revert_resize\u0027, \u0027migrating\u0027, \u0027build\u0027, \u0027shelved\u0027,"},{"line_number":84,"context_line":"    \u0027shelved_offloaded\u0027, \u0027build\u0027]"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class TranslationHelper(object):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1af94dfe_36598eff","line":84,"updated":"2016-03-16 11:43:59.000000000","message":"If you\u0027re doing an \"in\" operation on this then it should be a set rather than a list so we don\u0027t scan the list for each test.","commit_id":"897b6c9bd54863ba9f8a1165834b79e07efa5c8c"},{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"3c5f5511a88bf1bac139aab614c03a7ade0a84a8","unresolved":false,"context_lines":[{"line_number":81,"context_line":"console_invalid_status \u003d ["},{"line_number":82,"context_line":"    \u0027shutoff\u0027, \u0027suspended\u0027, \u0027resize\u0027, \u0027verify_resize\u0027,"},{"line_number":83,"context_line":"    \u0027revert_resize\u0027, \u0027migrating\u0027, \u0027build\u0027, \u0027shelved\u0027,"},{"line_number":84,"context_line":"    \u0027shelved_offloaded\u0027, \u0027build\u0027]"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class TranslationHelper(object):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_51dc7a45","line":84,"in_reply_to":"1af94dfe_36598eff","updated":"2016-03-24 14:42:42.000000000","message":"Richard makes a good point here, using a set instead of a list would be the more sensible option for faster membership checking.\n\nAlso, why are there 2 \u0027build\u0027 statuses in the list?","commit_id":"897b6c9bd54863ba9f8a1165834b79e07efa5c8c"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"de948cfbd5fb603f2196e3de9612ec910b7f6f85","unresolved":false,"context_lines":[{"line_number":81,"context_line":"console_invalid_status \u003d ["},{"line_number":82,"context_line":"    \u0027shutoff\u0027, \u0027suspended\u0027, \u0027resize\u0027, \u0027verify_resize\u0027,"},{"line_number":83,"context_line":"    \u0027revert_resize\u0027, \u0027migrating\u0027, \u0027build\u0027, \u0027shelved\u0027,"},{"line_number":84,"context_line":"    \u0027shelved_offloaded\u0027, \u0027build\u0027]"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class TranslationHelper(object):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_6b7617d8","line":84,"in_reply_to":"fa0719c6_51dc7a45","updated":"2016-03-31 14:12:54.000000000","message":"Good catch both of you. Changing it to set and removing the extra \"build\"","commit_id":"897b6c9bd54863ba9f8a1165834b79e07efa5c8c"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"00712cd752f5243aabd498d07789f26a30bfab88","unresolved":false,"context_lines":[{"line_number":81,"context_line":"console_invalid_status \u003d ("},{"line_number":82,"context_line":"    \u0027shutoff\u0027, \u0027suspended\u0027, \u0027resize\u0027, \u0027verify_resize\u0027,"},{"line_number":83,"context_line":"    \u0027revert_resize\u0027, \u0027migrating\u0027, \u0027build\u0027, \u0027shelved\u0027,"},{"line_number":84,"context_line":"    \u0027shelved_offloaded\u0027)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class TranslationHelper(object):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_61895c26","line":84,"updated":"2016-04-06 03:53:53.000000000","message":"This isn\u0027t a set, it\u0027s a tuple ;-)\n\n{\u0027sets\u0027, \u0027use\u0027, \u0027curly\u0027, \u0027brackets\u0027}","commit_id":"8d8ef3c2fbac44f03e791d56c0bf782db27d9ab3"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"e30be770a8b0aae75a76ffe222818a6a91763b42","unresolved":false,"context_lines":[{"line_number":81,"context_line":"console_invalid_status \u003d ("},{"line_number":82,"context_line":"    \u0027shutoff\u0027, \u0027suspended\u0027, \u0027resize\u0027, \u0027verify_resize\u0027,"},{"line_number":83,"context_line":"    \u0027revert_resize\u0027, \u0027migrating\u0027, \u0027build\u0027, \u0027shelved\u0027,"},{"line_number":84,"context_line":"    \u0027shelved_offloaded\u0027)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class TranslationHelper(object):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_1f69fd25","line":84,"in_reply_to":"9a061dce_61895c26","updated":"2016-04-13 10:51:30.000000000","message":"Done","commit_id":"8d8ef3c2fbac44f03e791d56c0bf782db27d9ab3"}]}