)]}'
{"horizon/forms/views.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"f26e02876901728dedfce2ff93142c3b0f538b35","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def get_context_data(self, **kwargs):"},{"line_number":147,"context_line":"        context \u003d super(ModalFormView, self).get_context_data(**kwargs)"},{"line_number":148,"context_line":"        context \u003d self._populate_context(context)"},{"line_number":149,"context_line":"        return context"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def get_cancel_url(self):"}],"source_content_type":"text/x-python","patch_set":24,"id":"9a061dce_671943d7","line":148,"updated":"2016-04-06 17:11:03.000000000","message":"Nice approach to circumvent UT failures ;).","commit_id":"c2d78b849d86bbacc74a80a62a044a5c8a18e084"}],"horizon/test/settings.py":[{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"91714952724d45a23ed8b1c1508278b0543f0b63","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    \u0027horizon.test\u0027,"},{"line_number":61,"context_line":"    \u0027horizon.test.test_dashboards.cats\u0027,"},{"line_number":62,"context_line":"    \u0027horizon.test.test_dashboards.dogs\u0027,"},{"line_number":63,"context_line":"    \u0027openstack_auth\u0027"},{"line_number":64,"context_line":")"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"MIDDLEWARE_CLASSES \u003d ("}],"source_content_type":"text/x-python","patch_set":20,"id":"fa0719c6_7f78002c","line":63,"updated":"2016-03-22 09:23:56.000000000","message":"I\u0027m just curious, but why we didn\u0027t used it before?","commit_id":"69d47fb70929cedd3f8af339cc4aa93986e2ffd7"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"def882b2a1c9ba195d5cd6aefe71b2b9b01d0539","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    \u0027horizon.test\u0027,"},{"line_number":61,"context_line":"    \u0027horizon.test.test_dashboards.cats\u0027,"},{"line_number":62,"context_line":"    \u0027horizon.test.test_dashboards.dogs\u0027,"},{"line_number":63,"context_line":"    \u0027openstack_auth\u0027"},{"line_number":64,"context_line":")"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"MIDDLEWARE_CLASSES \u003d ("}],"source_content_type":"text/x-python","patch_set":20,"id":"fa0719c6_0186b0b8","line":63,"in_reply_to":"fa0719c6_7f78002c","updated":"2016-03-22 15:31:50.000000000","message":"Paul: https://docs.djangoproject.com/es/1.9/releases/1.9/#features-removed-in-1-9\n\n All models need to be defined inside an installed application or declare an  explicit app_label. \n Furthermore, it isn’t possible to import them before their application is loaded. \n In particular, it isn’t possible to import models inside the root package of an application.\n\n\nSeems that we use to do this, and because it was not enforced it worked, so we could use the User model from django_openstack_auth without declaring the app.\n\nThis is no longer true on Django \u003e\u003d1.9","commit_id":"69d47fb70929cedd3f8af339cc4aa93986e2ffd7"}],"openstack_dashboard/dashboards/admin/volumes/tests.py":[{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"def882b2a1c9ba195d5cd6aefe71b2b9b01d0539","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from django.core.urlresolvers import reverse"},{"line_number":19,"context_line":"from django import http"},{"line_number":20,"context_line":"from django.test.utils import override_settings"},{"line_number":21,"context_line":"from django.utils.http import urlunquote  # noqa"},{"line_number":22,"context_line":"from mox3.mox import IsA  # noqa"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from openstack_dashboard import api"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa0719c6_814e4094","line":21,"updated":"2016-03-22 15:31:50.000000000","message":"Should not, because its used below so it should pass any pep8 checks.\nAn removing it and testing it locally confirms that its not needed, good catch!","commit_id":"69d47fb70929cedd3f8af339cc4aa93986e2ffd7"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"5d703a4640a7d627439dfe368eaa592be6d9bc79","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from django.core.urlresolvers import reverse"},{"line_number":19,"context_line":"from django import http"},{"line_number":20,"context_line":"from django.test.utils import override_settings"},{"line_number":21,"context_line":"from django.utils.http import urlunquote  # noqa"},{"line_number":22,"context_line":"from mox3.mox import IsA  # noqa"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from openstack_dashboard import api"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa0719c6_4a69edbd","line":21,"range":{"start_line":21,"start_character":42,"end_line":21,"end_character":48},"updated":"2016-03-22 13:00:45.000000000","message":"does here need \u0027# noqa\u0027 to escape pep8 check?","commit_id":"69d47fb70929cedd3f8af339cc4aa93986e2ffd7"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"8af41400464f3af60dfa2488ac70551331d235ae","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from django.core.urlresolvers import reverse"},{"line_number":19,"context_line":"from django import http"},{"line_number":20,"context_line":"from django.test.utils import override_settings"},{"line_number":21,"context_line":"from django.utils.http import urlunquote  # noqa"},{"line_number":22,"context_line":"from mox3.mox import IsA  # noqa"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from openstack_dashboard import api"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa0719c6_12928057","line":21,"in_reply_to":"fa0719c6_814e4094","updated":"2016-03-22 16:03:58.000000000","message":"Done. Although I don\u0027t understand why pep8 doesn\u0027t complain.","commit_id":"69d47fb70929cedd3f8af339cc4aa93986e2ffd7"}],"openstack_dashboard/dashboards/project/stacks/forms.py":[{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"eb5bbd8dbf86c6e51289d6d9fb9746a457fad98a","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    if django.VERSION \u003e\u003d (1, 9):"},{"line_number":130,"context_line":"        # Note(Itxaka): On django\u003e\u003d1.9 Charfield has an strip option that"},{"line_number":131,"context_line":"        # we need to set to False as to not hit"},{"line_number":132,"context_line":"        # https://bugs.launchpad.net/python-heatclient/+bug/1546166"},{"line_number":133,"context_line":"        environment_data.strip \u003d False"},{"line_number":134,"context_line":"        template_data.strip \u003d False"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_9f93c15a","line":132,"updated":"2016-03-01 09:03:17.000000000","message":"Patch for this just landed, we may need to revise this. https://review.openstack.org/#/c/280785/","commit_id":"497b344c7241a27aeba16b3916387b8d17398b39"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"eb5bbd8dbf86c6e51289d6d9fb9746a457fad98a","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    if django.VERSION \u003e\u003d (1, 9):"},{"line_number":264,"context_line":"        # Note(Itxaka): On django\u003e\u003d1.9 Charfield has an strip option that"},{"line_number":265,"context_line":"        # we need to set to False as to not hit"},{"line_number":266,"context_line":"        # https://bugs.launchpad.net/python-heatclient/+bug/1546166"},{"line_number":267,"context_line":"        environment_data.strip \u003d False"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    parameters \u003d forms.CharField("}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_ff9e4d61","line":266,"updated":"2016-03-01 09:03:17.000000000","message":"Patch for this just landed, we may need to revise this. https://review.openstack.org/#/c/280785/","commit_id":"497b344c7241a27aeba16b3916387b8d17398b39"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"383cdfe7b1843999e16cc8cd1b304c16d73ade16","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    if django.VERSION \u003e\u003d (1, 9):"},{"line_number":130,"context_line":"        # Note(Itxaka): On django\u003e\u003d1.9 Charfield has an strip option that"},{"line_number":131,"context_line":"        # we need to set to False as to not hit"},{"line_number":132,"context_line":"        # https://bugs.launchpad.net/python-heatclient/+bug/1546166"},{"line_number":133,"context_line":"        environment_data.strip \u003d False"},{"line_number":134,"context_line":"        template_data.strip \u003d False"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"ba0121b8_2ee7b8e5","line":132,"updated":"2016-03-28 20:05:05.000000000","message":"The fix for this bug has been released, so can this check now be removed?","commit_id":"b917ff3ac005dba60b643a0ff268ef375299aa0a"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"383cdfe7b1843999e16cc8cd1b304c16d73ade16","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    if django.VERSION \u003e\u003d (1, 9):"},{"line_number":264,"context_line":"        # Note(Itxaka): On django\u003e\u003d1.9 Charfield has an strip option that"},{"line_number":265,"context_line":"        # we need to set to False as to not hit"},{"line_number":266,"context_line":"        # https://bugs.launchpad.net/python-heatclient/+bug/1546166"},{"line_number":267,"context_line":"        environment_data.strip \u003d False"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    parameters \u003d forms.CharField("}],"source_content_type":"text/x-python","patch_set":23,"id":"ba0121b8_0eec74c6","line":266,"updated":"2016-03-28 20:05:05.000000000","message":"Same question as above.","commit_id":"b917ff3ac005dba60b643a0ff268ef375299aa0a"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"5fd7e48ae54da028607958d4fe5404f36355c15a","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    if django.VERSION \u003e\u003d (1, 9):"},{"line_number":130,"context_line":"        # Note(Itxaka): On django\u003e\u003d1.9 Charfield has an strip option that"},{"line_number":131,"context_line":"        # we need to set to False as to not hit"},{"line_number":132,"context_line":"        # https://bugs.launchpad.net/python-heatclient/+bug/1546166"},{"line_number":133,"context_line":"        environment_data.strip \u003d False"},{"line_number":134,"context_line":"        template_data.strip \u003d False"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"ba0121b8_8a134d5c","line":132,"updated":"2016-03-28 21:02:53.000000000","message":"(nit) As Rob and I discussed on IRC, this check is still needed. Should the bug link be removed from this comment? Having it here to me implies we need this check because of the bug, so the comment is confusing when reading the code.","commit_id":"c2d78b849d86bbacc74a80a62a044a5c8a18e084"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"7170406c8d571d528e1dbed839ee4146ddd0b7d5","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    if django.VERSION \u003e\u003d (1, 9):"},{"line_number":130,"context_line":"        # Note(Itxaka): On django\u003e\u003d1.9 Charfield has an strip option that"},{"line_number":131,"context_line":"        # we need to set to False as to not hit"},{"line_number":132,"context_line":"        # https://bugs.launchpad.net/python-heatclient/+bug/1546166"},{"line_number":133,"context_line":"        environment_data.strip \u003d False"},{"line_number":134,"context_line":"        template_data.strip \u003d False"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"ba0121b8_b34688bd","line":132,"in_reply_to":"ba0121b8_8a134d5c","updated":"2016-03-28 22:52:14.000000000","message":"I\u0027m biased on the \"wanting to do less work\" side, but I\u0027d rather leave this in because:\n- We need the Django 1.9 fix in Horizon\n- I don\u0027t have the time to chase up heatclient bugs\n- This leaves a paper trail explanation for this code, which could be fixed. If we removed it, its just magic code.","commit_id":"c2d78b849d86bbacc74a80a62a044a5c8a18e084"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"28bd9b1c186d372fbc605ccc2238740730d4a997","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    if django.VERSION \u003e\u003d (1, 9):"},{"line_number":130,"context_line":"        # Note(Itxaka): On django\u003e\u003d1.9 Charfield has an strip option that"},{"line_number":131,"context_line":"        # we need to set to False as to not hit"},{"line_number":132,"context_line":"        # https://bugs.launchpad.net/python-heatclient/+bug/1546166"},{"line_number":133,"context_line":"        environment_data.strip \u003d False"},{"line_number":134,"context_line":"        template_data.strip \u003d False"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"ba0121b8_f4e7433e","line":132,"in_reply_to":"ba0121b8_b34688bd","updated":"2016-03-29 03:32:37.000000000","message":"Makes sense. Thanks for the response, Rob. All looks good to me.","commit_id":"c2d78b849d86bbacc74a80a62a044a5c8a18e084"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"5fd7e48ae54da028607958d4fe5404f36355c15a","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    if django.VERSION \u003e\u003d (1, 9):"},{"line_number":264,"context_line":"        # Note(Itxaka): On django\u003e\u003d1.9 Charfield has an strip option that"},{"line_number":265,"context_line":"        # we need to set to False as to not hit"},{"line_number":266,"context_line":"        # https://bugs.launchpad.net/python-heatclient/+bug/1546166"},{"line_number":267,"context_line":"        environment_data.strip \u003d False"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    parameters \u003d forms.CharField("}],"source_content_type":"text/x-python","patch_set":24,"id":"ba0121b8_ea2ac97d","line":266,"updated":"2016-03-28 21:02:53.000000000","message":"(nit) Same comment as above.","commit_id":"c2d78b849d86bbacc74a80a62a044a5c8a18e084"}],"openstack_dashboard/settings.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"d7029b73f8196d199883914ff824f3ff8ced24da","unresolved":false,"context_lines":[{"line_number":406,"context_line":"# below may be omitted, though it should not be harmful"},{"line_number":407,"context_line":"#"},{"line_number":408,"context_line":"# from openstack_auth import utils as auth_utils"},{"line_number":409,"context_line":"# auth_utils.patch_middleware_get_user()"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"CSRF_COOKIE_AGE \u003d None"}],"source_content_type":"text/x-python","patch_set":21,"id":"9a061dce_47e4ffaa","line":409,"updated":"2016-04-06 17:11:21.000000000","message":"I wonder what problem did this solve before? Are we going to encounter a regression of some kind?","commit_id":"891a14744a2b88cb86f5387a35e3b71897a8e92c"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"c05e31d27b31176bf08b593d1a4bd6e30837937a","unresolved":false,"context_lines":[{"line_number":406,"context_line":"# below may be omitted, though it should not be harmful"},{"line_number":407,"context_line":"#"},{"line_number":408,"context_line":"# from openstack_auth import utils as auth_utils"},{"line_number":409,"context_line":"# auth_utils.patch_middleware_get_user()"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"CSRF_COOKIE_AGE \u003d None"}],"source_content_type":"text/x-python","patch_set":21,"id":"9a061dce_12ed02b7","line":409,"in_reply_to":"9a061dce_47e4ffaa","updated":"2016-04-07 09:19:33.000000000","message":"I actually meant to delete this. Apparently its no longer an issue.","commit_id":"891a14744a2b88cb86f5387a35e3b71897a8e92c"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"383cdfe7b1843999e16cc8cd1b304c16d73ade16","unresolved":false,"context_lines":[{"line_number":405,"context_line":"# appearing to be logged out.  In typical production deployments this section"},{"line_number":406,"context_line":"# below may be omitted, though it should not be harmful"},{"line_number":407,"context_line":"#"},{"line_number":408,"context_line":"# from openstack_auth import utils as auth_utils"},{"line_number":409,"context_line":"# auth_utils.patch_middleware_get_user()"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"CSRF_COOKIE_AGE \u003d None"}],"source_content_type":"text/x-python","patch_set":23,"id":"ba0121b8_6e6d3032","line":408,"updated":"2016-03-28 20:05:05.000000000","message":"Looks like this is now unnecessary code, so suggest removing this whole block.","commit_id":"b917ff3ac005dba60b643a0ff268ef375299aa0a"}],"openstack_dashboard/test/helpers.py":[{"author":{"_account_id":20772,"name":"Sergei Chipiga","email":"schipiga@mirantis.com","username":"schipiga"},"change_message_id":"a6f11c9e28bc803e3ecdab786e0a75c46779346e","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        processing the view which is redirected to."},{"line_number":234,"context_line":"        \"\"\""},{"line_number":235,"context_line":"        if django.VERSION \u003e\u003d (1, 9):"},{"line_number":236,"context_line":"            loc \u003d six.text_type(response._headers.get(\u0027location\u0027, None)[1])"},{"line_number":237,"context_line":"            loc \u003d http.urlunquote(loc)"},{"line_number":238,"context_line":"            expected_url \u003d http.urlunquote(expected_url)"},{"line_number":239,"context_line":"            self.assertEqual(loc, expected_url)"}],"source_content_type":"text/x-python","patch_set":19,"id":"fa0719c6_ea547355","line":236,"updated":"2016-03-21 14:39:21.000000000","message":"I\u0027m a bit worry about\n\n  response._headers.get(\u0027location\u0027, None)[1]\n\nIf get returns None, we will have exception, isn\u0027t it? None[1] -\u003e TypeError","commit_id":"5b66ba9dc1309eb478fabb8fee9333ea1adc8da8"}]}
