)]}'
{"horizon/static/framework/widgets/action-list/actions-delete-selected.template.html":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"420144215a99cd69c2d9b5f58346c47795b88403","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003caction action-classes\u003d\"\u0027btn btn-danger\u0027\""},{"line_number":2,"context_line":"        disabled\u003d\"tCtrl.numSelected \u003d\u003d\u003d 0\""},{"line_number":3,"context_line":"        item\u003d\"tCtrl.selected\"\u003e"},{"line_number":4,"context_line":"  \u003cspan class\u003d\"fa fa-remove\"\u003e\u003c/span\u003e"},{"line_number":5,"context_line":"  $text$"}],"source_content_type":"text/html","patch_set":2,"id":"dae33548_313841a0","line":2,"updated":"2016-02-17 01:09:21.000000000","message":"can we bind to tctrl.selected.length","commit_id":"889acd14f4649c616c668fded84d500d59360ceb"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"2581d09071c6a1cdf0ee97d2501c9575b946de8d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003caction action-classes\u003d\"\u0027btn btn-danger\u0027\""},{"line_number":2,"context_line":"        disabled\u003d\"tCtrl.numSelected \u003d\u003d\u003d 0\""},{"line_number":3,"context_line":"        item\u003d\"tCtrl.selected\"\u003e"},{"line_number":4,"context_line":"  \u003cspan class\u003d\"fa fa-remove\"\u003e\u003c/span\u003e"},{"line_number":5,"context_line":"  $text$"}],"source_content_type":"text/html","patch_set":2,"id":"dae33548_efcd1b32","line":2,"in_reply_to":"dae33548_24df2a0e","updated":"2016-02-17 19:36:24.000000000","message":"I lied... apparently i\u0027m already push/pop via filter and map. This bit was forgotten, I\u0027ll update it to use length.","commit_id":"889acd14f4649c616c668fded84d500d59360ceb"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"01ed775c5c1946393cbe0ff4f7a4fa6ee693a66b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003caction action-classes\u003d\"\u0027btn btn-danger\u0027\""},{"line_number":2,"context_line":"        disabled\u003d\"tCtrl.numSelected \u003d\u003d\u003d 0\""},{"line_number":3,"context_line":"        item\u003d\"tCtrl.selected\"\u003e"},{"line_number":4,"context_line":"  \u003cspan class\u003d\"fa fa-remove\"\u003e\u003c/span\u003e"},{"line_number":5,"context_line":"  $text$"}],"source_content_type":"text/html","patch_set":2,"id":"dae33548_24df2a0e","line":2,"in_reply_to":"dae33548_313841a0","updated":"2016-02-17 19:32:41.000000000","message":"I actually looked into this. The problem is that selected is a map and not an array. You\u0027d have to do something like Object.keys(tCtrl.selected).length but now you\u0027re no longer watching but evaluating a function, it will only trigger once.\n\nThe other solution is to make selected an array, but that would require you to do a search and push/pop each time the user check/uncheck. That is a lot more processing than incrementing a counter. Having a counter is the lesser of the two evil.","commit_id":"889acd14f4649c616c668fded84d500d59360ceb"}],"horizon/static/framework/widgets/table/table.controller.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"420144215a99cd69c2d9b5f58346c47795b88403","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    ctrl.isSelected \u003d isSelected;"},{"line_number":34,"context_line":"    ctrl.toggleSelect \u003d toggleSelect;"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    clearSelected();"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    ////////////////////"},{"line_number":39,"context_line":""}],"source_content_type":"text/javascript","patch_set":2,"id":"dae33548_f13539da","line":36,"updated":"2016-02-17 01:09:21.000000000","message":"Why does this show back up again.  It was changed in:  https://review.openstack.org/#/c/279383/2/horizon/static/framework/widgets/table/table.controller.js","commit_id":"889acd14f4649c616c668fded84d500d59360ceb"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"01ed775c5c1946393cbe0ff4f7a4fa6ee693a66b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    ctrl.isSelected \u003d isSelected;"},{"line_number":34,"context_line":"    ctrl.toggleSelect \u003d toggleSelect;"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    clearSelected();"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    ////////////////////"},{"line_number":39,"context_line":""}],"source_content_type":"text/javascript","patch_set":2,"id":"dae33548_af6793b5","line":36,"in_reply_to":"dae33548_f13539da","updated":"2016-02-17 19:32:41.000000000","message":"rebasing error, will fix.","commit_id":"889acd14f4649c616c668fded84d500d59360ceb"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"420144215a99cd69c2d9b5f58346c47795b88403","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      return angular.isDefined(rowState) \u0026\u0026 rowState.checked;"},{"line_number":53,"context_line":"    }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    function clearSelected() {"},{"line_number":56,"context_line":"      ctrl.selected \u003d [];"},{"line_number":57,"context_line":"      ctrl.selections \u003d {};"},{"line_number":58,"context_line":"      ctrl.numSelected \u003d 0;"}],"source_content_type":"text/javascript","patch_set":2,"id":"dae33548_b1de116b","line":55,"updated":"2016-02-17 01:09:21.000000000","message":"maybe this should be initializeSelected (since it is also called at initialization (line 36 above).","commit_id":"889acd14f4649c616c668fded84d500d59360ceb"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"01ed775c5c1946393cbe0ff4f7a4fa6ee693a66b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      return angular.isDefined(rowState) \u0026\u0026 rowState.checked;"},{"line_number":53,"context_line":"    }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    function clearSelected() {"},{"line_number":56,"context_line":"      ctrl.selected \u003d [];"},{"line_number":57,"context_line":"      ctrl.selections \u003d {};"},{"line_number":58,"context_line":"      ctrl.numSelected \u003d 0;"}],"source_content_type":"text/javascript","patch_set":2,"id":"dae33548_af9af36b","line":55,"in_reply_to":"dae33548_b1de116b","updated":"2016-02-17 19:32:41.000000000","message":"This method is use for both initializing and clearing. I don\u0027t want to change it now since its chained. The function is private so renaming it later will not be an issue.","commit_id":"889acd14f4649c616c668fded84d500d59360ceb"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"420144215a99cd69c2d9b5f58346c47795b88403","unresolved":false,"context_lines":[{"line_number":75,"context_line":"      ctrl.selected \u003d getSelected(ctrl.selections);"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"      if (checkedState) {"},{"line_number":78,"context_line":"        ctrl.numSelected++;"},{"line_number":79,"context_line":"      }"},{"line_number":80,"context_line":"      else {"},{"line_number":81,"context_line":"        ctrl.numSelected--;"}],"source_content_type":"text/javascript","patch_set":2,"id":"dae33548_b1b0d144","line":78,"updated":"2016-02-17 01:09:21.000000000","message":"can this go away and just bind to ctrl.selected.length?","commit_id":"889acd14f4649c616c668fded84d500d59360ceb"}]}
