)]}'
{"openstack_dashboard/dashboards/project/volumes/volumes/views.py":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"86e8caf3a46e55d18343868f21143a0357ac3ce5","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        try:"},{"line_number":67,"context_line":"            volume_id \u003d self.kwargs[\u0027volume_id\u0027]"},{"line_number":68,"context_line":"            volume \u003d cinder.volume_get(self.request, volume_id)"},{"line_number":69,"context_line":"            snapshots \u003d cinder.volume_snapshot_list(self.request)"},{"line_number":70,"context_line":"            if snapshots:"},{"line_number":71,"context_line":"                # extract out the volume ids"},{"line_number":72,"context_line":"                volume_ids \u003d set([(s.volume_id) for s in snapshots])"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_10587689","line":69,"updated":"2016-02-17 14:26:55.000000000","message":"volume_snapshot_list(request, search_opts\u003d{\u0027volume_id\u0027:volume.id})\nreturns the list of snapshots from that volume\n\nyou could save the loop later then.","commit_id":"233b7e695b8a9582ad2d03ae959a1947b6c23857"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"6072f090843ab33bfc0c8275b485ec4cc1c712e0","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        try:"},{"line_number":67,"context_line":"            volume_id \u003d self.kwargs[\u0027volume_id\u0027]"},{"line_number":68,"context_line":"            volume \u003d cinder.volume_get(self.request, volume_id)"},{"line_number":69,"context_line":"            snapshots \u003d cinder.volume_snapshot_list(self.request)"},{"line_number":70,"context_line":"            if snapshots:"},{"line_number":71,"context_line":"                # extract out the volume ids"},{"line_number":72,"context_line":"                volume_ids \u003d set([(s.volume_id) for s in snapshots])"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_538b28c3","line":69,"in_reply_to":"dae33548_10587689","updated":"2016-02-17 14:52:20.000000000","message":"Done","commit_id":"233b7e695b8a9582ad2d03ae959a1947b6c23857"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"3a86b2733ff19c76fbba0349175d1f45b5c06372","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        try:"},{"line_number":67,"context_line":"            volume_id \u003d self.kwargs[\u0027volume_id\u0027]"},{"line_number":68,"context_line":"            volume \u003d cinder.volume_get(self.request, volume_id)"},{"line_number":69,"context_line":"            snapshots \u003d cinder.volume_snapshot_list("},{"line_number":70,"context_line":"                self.request, search_opts\u003d{\u0027volume_id\u0027: volume.id})"},{"line_number":71,"context_line":"            if snapshots:"},{"line_number":72,"context_line":"                setattr(volume, \u0027has_snapshot\u0027, True)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_b4bdd104","line":69,"updated":"2016-02-19 07:12:52.000000000","message":"In this case, if volume_snapshot_list occur any exception, Detail page itself will not be displayed, even volume_get works well.\nIt seems like using try-except is more reasonable. What do you think ?","commit_id":"49a1a6356d8239d5f463c4e09564171dcccaa662"}]}
