)]}'
{"openstack_dashboard/api/keystone.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"67bb475a454aff4122a3e16cd7d4bc69d90350ee","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    keystoneclient(request, admin\u003dTrue).tenants.delete(tenant_id)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"def tenant_list(request, marker\u003dNone, admin\u003dFalse):"},{"line_number":143,"context_line":"    page_size \u003d getattr(settings, \u0027API_RESULT_PAGE_SIZE\u0027, 20)"},{"line_number":144,"context_line":"    limit \u003d page_size + 1"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FkX0%3D","line":142,"updated":"2013-05-03 16:11:30.000000000","message":"going to need a way to get a paginated list or non-paginated list  This method is used by calls that won\u0027t want a truncated list.","commit_id":"cd1c20da17cb53ecbc291c830608754027227121"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"afa7e3885d84a55ca226f1bf7b60d09bbb4cad95","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            tenants.pop(-1)"},{"line_number":207,"context_line":"            has_more_data \u003d True"},{"line_number":208,"context_line":"    else:"},{"line_number":209,"context_line":"        tenants \u003d manager.list(domain\u003ddomain, user\u003duser)"},{"line_number":210,"context_line":"    return (tenants, has_more_data)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAOn%2F%2FZ7g%3D","line":209,"updated":"2013-05-10 17:27:42.000000000","message":"Unfortunately, which the merge of v3 support, this is now not paginating for v3 calls.  The mechanism changed for v3 from the marker and limit mechanism to a per_page and link one.  This change will require updates to how pagination is handled in the tables so that it can handle both types of pagination.\n\nI think this needs to be addressed to consider this resolved.\n\nThe v2 pagination looks solid now.","commit_id":"2f4840cd82c28807fdc0d9faa3413d6107b78bdd"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"45009b0f547983fbf41ff3ede65ef1f6dae8c57b","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            tenants.pop(-1)"},{"line_number":207,"context_line":"            has_more_data \u003d True"},{"line_number":208,"context_line":"    else:"},{"line_number":209,"context_line":"        tenants \u003d manager.list(domain\u003ddomain, user\u003duser)"},{"line_number":210,"context_line":"    return (tenants, has_more_data)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAOn%2F%2FT2I%3D","line":209,"in_reply_to":"AAAAOn%2F%2FZ7g%3D","updated":"2013-05-15 02:05:09.000000000","message":"I have registered a bp \"v3-pagination-support\" to support v3 pagination in the tables.","commit_id":"2f4840cd82c28807fdc0d9faa3413d6107b78bdd"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"c3e039dacb2ab93844ce5730bd2f309b3c19455e","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            tenants.pop(-1)"},{"line_number":207,"context_line":"            has_more_data \u003d True"},{"line_number":208,"context_line":"    else:"},{"line_number":209,"context_line":"        tenants \u003d manager.list(domain\u003ddomain, user\u003duser)"},{"line_number":210,"context_line":"    return (tenants, has_more_data)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAPH%2F%2F350%3D","line":209,"in_reply_to":"AAAAOn%2F%2FZ7g%3D","updated":"2013-05-21 08:50:26.000000000","message":"v3 doesn\u0027t really support pagination yet. so this patch just support v2.","commit_id":"2f4840cd82c28807fdc0d9faa3413d6107b78bdd"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"ea7a280c5acf06bdaf69b4c3266fd86d96413974","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            tenants.pop(-1)"},{"line_number":207,"context_line":"            has_more_data \u003d True"},{"line_number":208,"context_line":"    else:"},{"line_number":209,"context_line":"        tenants \u003d manager.list(domain\u003ddomain, user\u003duser)"},{"line_number":210,"context_line":"    return (tenants, has_more_data)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAPH%2F%2FqbM%3D","line":209,"in_reply_to":"AAAAPH%2F%2F350%3D","updated":"2013-05-28 10:37:47.000000000","message":"so, when switching from v2 to v3 we will see a regression, because pagination is broken then, right?","commit_id":"2f4840cd82c28807fdc0d9faa3413d6107b78bdd"}],"openstack_dashboard/dashboards/admin/projects/views.py":[{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"7a20c0836e48616947faa61791865d105142d0cb","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        try:"},{"line_number":79,"context_line":"            tenants, self._more \u003d api.keystone.tenant_list("},{"line_number":80,"context_line":"                                            self.request,"},{"line_number":81,"context_line":"                                            True,"},{"line_number":82,"context_line":"                                            marker)"},{"line_number":83,"context_line":"        except:"},{"line_number":84,"context_line":"            self._more \u003d False"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAPX%2F%2F9kw%3D","line":81,"updated":"2013-06-05 03:36:16.000000000","message":"Can you make these keyword args so it\u0027s clear what is going on here?","commit_id":"0e2ef89d0765e315957633084c414b57560133fb"}],"openstack_dashboard/test/api_tests/keystone_tests.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"4b55e261de447e52a18dcb29ce87b897e2b40b14","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        ret_val, has_more \u003d api.keystone.tenant_list(self.request,"},{"line_number":130,"context_line":"                                                     paginate\u003dTrue,"},{"line_number":131,"context_line":"                                                     admin\u003dTrue)"},{"line_number":132,"context_line":"        self.assertItemsEqual(ret_val, tenants)"},{"line_number":133,"context_line":"        self.assertEquals(page_size, len(ret_val))"},{"line_number":134,"context_line":"        self.assertTrue(has_more)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAOn%2F%2Fh28%3D","line":132,"updated":"2013-05-06 18:50:03.000000000","message":"This is may get the correct result, but the logic is wrong.  If the number of projects in the test data is increased to more than one, this assert will not be correct.  Either make the tenants from above a list of a single item (the first project) or assert the item in ret_val is equal to the first item in tenants.","commit_id":"18d66f5df6b0d8d938736fe2f93097352f680c2f"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"754b5f2cf63182430b446adf42fac6631a0cc849","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        ret_val, has_more \u003d api.keystone.tenant_list(self.request,"},{"line_number":130,"context_line":"                                                     paginate\u003dTrue,"},{"line_number":131,"context_line":"                                                     admin\u003dTrue)"},{"line_number":132,"context_line":"        self.assertItemsEqual(ret_val, tenants)"},{"line_number":133,"context_line":"        self.assertEquals(page_size, len(ret_val))"},{"line_number":134,"context_line":"        self.assertTrue(has_more)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAOn%2F%2FhR4%3D","line":132,"in_reply_to":"AAAAOn%2F%2Fh28%3D","updated":"2013-05-07 01:42:08.000000000","message":"Done","commit_id":"18d66f5df6b0d8d938736fe2f93097352f680c2f"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"9993cda342fa393106229ada09add9b2996c08ed","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        ret_val, has_more \u003d api.keystone.tenant_list(self.request,"},{"line_number":130,"context_line":"                                                     paginate\u003dTrue,"},{"line_number":131,"context_line":"                                                     admin\u003dTrue)"},{"line_number":132,"context_line":"        self.assertItemsEqual(ret_val, tenants)"},{"line_number":133,"context_line":"        self.assertEquals(page_size, len(ret_val))"},{"line_number":134,"context_line":"        self.assertTrue(has_more)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAOn%2F%2FhNA%3D","line":132,"in_reply_to":"AAAAOn%2F%2Fh28%3D","updated":"2013-05-07 02:16:59.000000000","message":"I will use assertIsInstance to check every item in ret_val, the old logic assert ret_val equal to tenants is bad.","commit_id":"18d66f5df6b0d8d938736fe2f93097352f680c2f"}]}
