)]}'
{"openstack_dashboard/api/nova.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"e34f421bc4370939ae400f65b2924d4bf400bdef","unresolved":false,"context_lines":[{"line_number":342,"context_line":"    return novaclient(request).keypairs.list()"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"def server_create(request, name, image, flavor, key_name, admin_pass,"},{"line_number":346,"context_line":"                  user_data, security_groups, block_device_mapping, "},{"line_number":347,"context_line":"                  nics\u003dNone, instance_count\u003d1):"},{"line_number":348,"context_line":"    return Server(novaclient(request).servers.create("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fh1k%3D","line":345,"updated":"2013-05-06 19:02:06.000000000","message":"Rather than inserting new parameter in the middle, I prefer to add it at the end. This will reduce the risk of breaking something that is already using this method.","commit_id":"63619617032e61fcaf99a73626dc8e3b768d7b34"}],"openstack_dashboard/dashboards/project/instances/workflows/create_instance.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"e34f421bc4370939ae400f65b2924d4bf400bdef","unresolved":false,"context_lines":[{"line_number":343,"context_line":"                                                   \"authentication.\"),"},{"line_number":344,"context_line":"                                       add_item_link\u003dKEYPAIR_IMPORT_URL)"},{"line_number":345,"context_line":"    admin_pass \u003d forms.RegexField(label\u003d_(\"Admin Pass\"),"},{"line_number":346,"context_line":"                                  widget\u003dforms.PasswordInput(render_value\u003dFalse),"},{"line_number":347,"context_line":"                                  regex\u003dvalidators.password_validator(),"},{"line_number":348,"context_line":"                                  error_messages\u003d{\u0027invalid\u0027: validators.password_validator_msg()})"},{"line_number":349,"context_line":"    groups \u003d forms.MultipleChoiceField(label\u003d_(\"Security Groups\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fh18%3D","line":346,"updated":"2013-05-06 19:02:06.000000000","message":"pep8 error: line too long","commit_id":"63619617032e61fcaf99a73626dc8e3b768d7b34"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"e34f421bc4370939ae400f65b2924d4bf400bdef","unresolved":false,"context_lines":[{"line_number":345,"context_line":"    admin_pass \u003d forms.RegexField(label\u003d_(\"Admin Pass\"),"},{"line_number":346,"context_line":"                                  widget\u003dforms.PasswordInput(render_value\u003dFalse),"},{"line_number":347,"context_line":"                                  regex\u003dvalidators.password_validator(),"},{"line_number":348,"context_line":"                                  error_messages\u003d{\u0027invalid\u0027: validators.password_validator_msg()})"},{"line_number":349,"context_line":"    groups \u003d forms.MultipleChoiceField(label\u003d_(\"Security Groups\"),"},{"line_number":350,"context_line":"                                       required\u003dTrue,"},{"line_number":351,"context_line":"                                       initial\u003d[\"default\"],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fh14%3D","line":348,"updated":"2013-05-06 19:02:06.000000000","message":"pep8 error: line too long","commit_id":"63619617032e61fcaf99a73626dc8e3b768d7b34"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"e34f421bc4370939ae400f65b2924d4bf400bdef","unresolved":false,"context_lines":[{"line_number":387,"context_line":"    def clean(self):"},{"line_number":388,"context_line":"        cleaned_data \u003d super(SetAccessControlsAction, self).clean()"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"        admin_pass \u003d cleaned_data.get(\u0027admin_pass\u0027, None)"},{"line_number":391,"context_line":"        if admin_pass is None:"},{"line_number":392,"context_line":"            msg \u003d _(\u0027The Admin Pass is invalid.\u0027)"},{"line_number":393,"context_line":"            raise forms.ValidationError(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fh10%3D","line":390,"updated":"2013-05-06 19:02:06.000000000","message":"Instead of having this, you could just set the required flag in the field definition.","commit_id":"63619617032e61fcaf99a73626dc8e3b768d7b34"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"0988510718922fe498fd224be10e26fc950ce0f8","unresolved":false,"context_lines":[{"line_number":387,"context_line":"    def clean(self):"},{"line_number":388,"context_line":"        cleaned_data \u003d super(SetAccessControlsAction, self).clean()"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"        admin_pass \u003d cleaned_data.get(\u0027admin_pass\u0027, None)"},{"line_number":391,"context_line":"        if admin_pass is None:"},{"line_number":392,"context_line":"            msg \u003d _(\u0027The Admin Pass is invalid.\u0027)"},{"line_number":393,"context_line":"            raise forms.ValidationError(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FfZo%3D","line":390,"in_reply_to":"AAAAOn%2F%2Fh10%3D","updated":"2013-05-08 08:03:02.000000000","message":"It should be valid to not set the password. We don\u0027t want this to be required since that would mean entering it every time even when a user doesn\u0027t care. So an empty string should pass validation and send admin_pass\u003dNone to Nova.\n\nIf possible the UI should also make it clear that this is optional.","commit_id":"63619617032e61fcaf99a73626dc8e3b768d7b34"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"922521e153e327195d83e4db6da472bf50e13891","unresolved":false,"context_lines":[{"line_number":497,"context_line":"            return message % {\"count\": _(\"%s instances\") % count,"},{"line_number":498,"context_line":"                              \"name\": name}"},{"line_number":499,"context_line":"        else:"},{"line_number":500,"context_line":"            return message % {\"count\": _(\"instance\"), \"name\": name}"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    def handle(self, request, context):"},{"line_number":503,"context_line":"        custom_script \u003d context.get(\u0027customization_script\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOn%2F%2FcQI%3D","line":500,"updated":"2013-05-09 15:37:52.000000000","message":"I think we need to add sensitive_variables decorator here for the admin_pass to prevent it from being logged.","commit_id":"1d30b96ee9795bffe03b92622e1b84338e5379ee"}]}
