)]}'
{"openstack_dashboard/static/app/core/images/images.module.js":[{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"3f9c757414de37f7270adb6420f3acbb2a24038e","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    $provide.constant(\u0027horizon.app.core.images.detailsRoute\u0027, projectDetailsRoute);"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    $routeProvider"},{"line_number":135,"context_line":"      .when(\u0027/\u0027 + projectTableRoute, {"},{"line_number":136,"context_line":"        templateUrl: tableUrl + \u0027images-table.html\u0027"},{"line_number":137,"context_line":"      })"},{"line_number":138,"context_line":"      .when(\u0027/\u0027 + projectDetailsRoute + \u0027:imageId\u0027, {"}],"source_content_type":"text/javascript","patch_set":4,"id":"9aed3d3a_43b348e9","line":135,"updated":"2016-02-29 19:14:13.000000000","message":"When we did the similar thing in lbaas the leading \"/\" was just part of the route. \n\nhttps://github.com/openstack/neutron-lbaas-dashboard/blob/master/neutron_lbaas_dashboard/static/dashboard/project/lbaasv2/lbaasv2.module.js#L56\n\nvery subjectively, that looks cleaner to me. Is there a reason keeping the leading \"/\" out of the route constant is helpful?","commit_id":"d63ca41da83e432494a05542a01e69f851293c20"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"4ddebb91ff59e8e9f09d4f080abebbb74de5ebe0","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    $provide.constant(\u0027horizon.app.core.images.detailsRoute\u0027, projectDetailsRoute);"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    $routeProvider"},{"line_number":135,"context_line":"      .when(\u0027/\u0027 + projectTableRoute, {"},{"line_number":136,"context_line":"        templateUrl: tableUrl + \u0027images-table.html\u0027"},{"line_number":137,"context_line":"      })"},{"line_number":138,"context_line":"      .when(\u0027/\u0027 + projectDetailsRoute + \u0027:imageId\u0027, {"}],"source_content_type":"text/javascript","patch_set":4,"id":"9aed3d3a_460fd687","line":135,"in_reply_to":"9aed3d3a_43b348e9","updated":"2016-02-29 19:32:59.000000000","message":"It\u0027s not our choice as to whether we specify a leading slash.  This is the path provided by the routeProvider, which in our testing always provides a path with a leading slash.","commit_id":"d63ca41da83e432494a05542a01e69f851293c20"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"00b096b083f7ec8a156c42ed3aab05eab3c070f0","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    $provide.constant(\u0027horizon.app.core.images.detailsRoute\u0027, projectDetailsRoute);"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    $routeProvider"},{"line_number":135,"context_line":"      .when(\u0027/\u0027 + projectTableRoute, {"},{"line_number":136,"context_line":"        templateUrl: tableUrl + \u0027images-table.html\u0027"},{"line_number":137,"context_line":"      })"},{"line_number":138,"context_line":"      .when(\u0027/\u0027 + projectDetailsRoute + \u0027:imageId\u0027, {"}],"source_content_type":"text/javascript","patch_set":4,"id":"9aed3d3a_916f562a","line":135,"in_reply_to":"9aed3d3a_460fd687","updated":"2016-02-29 19:51:19.000000000","message":"I know the slash is needed, but wasn\u0027t clear before on why you didn\u0027t just define it directly in your var statement above. I understand from our chat this makes your reuse cleaner. I\u0027m good with that answer!","commit_id":"d63ca41da83e432494a05542a01e69f851293c20"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"2ce07310bd9f9635a5c1794ad387d84ff86d1633","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    $provide.constant(\u0027horizon.app.core.images.detailsRoute\u0027, projectDetailsRoute);"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    $routeProvider"},{"line_number":135,"context_line":"      .when(\u0027/\u0027 + projectTableRoute, {"},{"line_number":136,"context_line":"        templateUrl: tableUrl + \u0027images-table.html\u0027"},{"line_number":137,"context_line":"      })"},{"line_number":138,"context_line":"      .when(\u0027/\u0027 + projectDetailsRoute + \u0027:imageId\u0027, {"}],"source_content_type":"text/javascript","patch_set":4,"id":"9aed3d3a_9fed98b9","line":135,"in_reply_to":"9aed3d3a_916f562a","updated":"2016-02-29 22:19:47.000000000","message":"how does this make the reuse cleaner? I dont understand. would be nice if you can explain it to me, but its not a blocker.","commit_id":"d63ca41da83e432494a05542a01e69f851293c20"}]}
