)]}'
{"openstack_dashboard/api/base.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"7fe31faf4420ab84884c7986058e5d1c1673a811","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"# TODO: Use API discovery to determine the version, for now read the settings"},{"line_number":152,"context_line":"IDENTITY_VERSION \u003d getattr(settings, \u0027OPENSTACK_API_VERSIONS\u0027, {}).\\"},{"line_number":153,"context_line":"    get(\u0027identity\u0027, 2.0)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"# Mapping of V2 Catalog Endpoint_type to V3 Catalog Interfaces"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FdvM%3D","line":153,"updated":"2013-05-08 20:53:49.000000000","message":"Should use IdentityAPIVersionManager now that it\u0027s merged","commit_id":"d349f30d14d56ac6db380c7285de6e70a1b4a5b0"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"139ca2ad9ad9b7e5c256e1f5fd5f0b233f2025dc","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"# TODO: Use API discovery to determine the version, for now read the settings"},{"line_number":152,"context_line":"IDENTITY_VERSION \u003d getattr(settings, \u0027OPENSTACK_API_VERSIONS\u0027, {}).\\"},{"line_number":153,"context_line":"    get(\u0027identity\u0027, 2.0)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"# Mapping of V2 Catalog Endpoint_type to V3 Catalog Interfaces"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FdLo%3D","line":153,"in_reply_to":"AAAAOn%2F%2FdRc%3D","updated":"2013-05-09 01:21:11.000000000","message":"You\u0027re right about that.  I mistyped, I meant APIVersionManager. Passing in \u0027identity\u0027.","commit_id":"d349f30d14d56ac6db380c7285de6e70a1b4a5b0"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"b8553289f48ca91f07cc60f5bcf175a89a6e4ae1","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"# TODO: Use API discovery to determine the version, for now read the settings"},{"line_number":152,"context_line":"IDENTITY_VERSION \u003d getattr(settings, \u0027OPENSTACK_API_VERSIONS\u0027, {}).\\"},{"line_number":153,"context_line":"    get(\u0027identity\u0027, 2.0)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"# Mapping of V2 Catalog Endpoint_type to V3 Catalog Interfaces"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FdRc%3D","line":153,"in_reply_to":"AAAAOn%2F%2FdvM%3D","updated":"2013-05-08 23:57:30.000000000","message":"Reading it from IdentityAPIVersionManager  will cause a circular import.","commit_id":"d349f30d14d56ac6db380c7285de6e70a1b4a5b0"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"61a5c70d0037394b39886a635b664b4bb3f80d42","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"# TODO: Use API discovery to determine the version, for now read the settings"},{"line_number":184,"context_line":"IDENTITY_VERSION \u003d getattr(settings, APIVersionManager.SETTINGS_KEY, {}).\\"},{"line_number":185,"context_line":"    get(\u0027identity\u0027, 2.0)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"# Mapping of V2 Catalog Endpoint_type to V3 Catalog Interfaces"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fa8Q%3D","line":185,"updated":"2013-05-10 03:11:43.000000000","message":"I think David was right the first time. I don\u0027t see any complication in using APIVersionManager here now, even if we have plans to change where the object comes from later.","commit_id":"f7df9759297066dd6493df28958fb35833a39abb"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"a7c4f1ec69b2b83f32984cd0829d7b738d483abc","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"# TODO: Use API discovery to determine the version, for now read the settings"},{"line_number":184,"context_line":"IDENTITY_VERSION \u003d getattr(settings, APIVersionManager.SETTINGS_KEY, {}).\\"},{"line_number":185,"context_line":"    get(\u0027identity\u0027, 2.0)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"# Mapping of V2 Catalog Endpoint_type to V3 Catalog Interfaces"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fa0I%3D","line":185,"in_reply_to":"AAAAOn%2F%2Fa1M%3D","updated":"2013-05-10 05:58:54.000000000","message":"I see your point. I had a play with this. The following works when used inside url_for():\n\nfrom keystone import VERSIONS as KEYSTONE_VERSIONS\n\nversion \u003d KEYSTONE_VERSIONS.active\n\nThe issue is openstack_auth is still returning v2 endpoints. I changed preferred_version\u003d2 but then a test broke. Maybe this should wait until V3 support is done in openstack_auth, unless you feel like fixing the keystone test to support v2 and v3 somehow...","commit_id":"f7df9759297066dd6493df28958fb35833a39abb"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"5e66b99f14ef1824d1d6086806ce5095969cfafb","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"# TODO: Use API discovery to determine the version, for now read the settings"},{"line_number":184,"context_line":"IDENTITY_VERSION \u003d getattr(settings, APIVersionManager.SETTINGS_KEY, {}).\\"},{"line_number":185,"context_line":"    get(\u0027identity\u0027, 2.0)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"# Mapping of V2 Catalog Endpoint_type to V3 Catalog Interfaces"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fa1M%3D","line":185,"in_reply_to":"AAAAOn%2F%2Fa2s%3D","updated":"2013-05-10 04:37:56.000000000","message":"I am open to suggestion if there is a simpler way to do this.","commit_id":"f7df9759297066dd6493df28958fb35833a39abb"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"96c7c12f4b70afc15464e853b93ca7831e689ed3","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"# TODO: Use API discovery to determine the version, for now read the settings"},{"line_number":184,"context_line":"IDENTITY_VERSION \u003d getattr(settings, APIVersionManager.SETTINGS_KEY, {}).\\"},{"line_number":185,"context_line":"    get(\u0027identity\u0027, 2.0)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"# Mapping of V2 Catalog Endpoint_type to V3 Catalog Interfaces"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fa2s%3D","line":185,"in_reply_to":"AAAAOn%2F%2Fa8Q%3D","updated":"2013-05-10 04:09:45.000000000","message":"I did tried using APIVersionManager, but it involve more lines of code and I didn\u0027t get the expected output.\n\n\nTo be able to utilize APIVersionManager, I need to initialize it first using the load_supported method: https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/keystone.py#L63\n\nAnd the output is not accurate, it checks for the existence of the client class in keystone-client. However the keystone server may still be running only V2 but it could be using a newer version of keystoneclient.","commit_id":"f7df9759297066dd6493df28958fb35833a39abb"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"61a5c70d0037394b39886a635b664b4bb3f80d42","unresolved":false,"context_lines":[{"line_number":196,"context_line":"def url_for(request, service_type, admin\u003dFalse, endpoint_type\u003dNone):"},{"line_number":197,"context_line":"    endpoint_type \u003d endpoint_type or getattr(settings,"},{"line_number":198,"context_line":"                                             \u0027OPENSTACK_ENDPOINT_TYPE\u0027,"},{"line_number":199,"context_line":"                                             \u0027publicURL\u0027)"},{"line_number":200,"context_line":"    catalog \u003d request.user.service_catalog"},{"line_number":201,"context_line":"    service \u003d get_service_from_catalog(catalog, service_type)"},{"line_number":202,"context_line":"    if service:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FbDA%3D","line":199,"updated":"2013-05-10 03:11:43.000000000","message":"If you check for admin\u003d\u003dTrue and set the endpoint_type to adminURL here, you won\u0027t need a lot of the branching below.","commit_id":"f7df9759297066dd6493df28958fb35833a39abb"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"96c7c12f4b70afc15464e853b93ca7831e689ed3","unresolved":false,"context_lines":[{"line_number":196,"context_line":"def url_for(request, service_type, admin\u003dFalse, endpoint_type\u003dNone):"},{"line_number":197,"context_line":"    endpoint_type \u003d endpoint_type or getattr(settings,"},{"line_number":198,"context_line":"                                             \u0027OPENSTACK_ENDPOINT_TYPE\u0027,"},{"line_number":199,"context_line":"                                             \u0027publicURL\u0027)"},{"line_number":200,"context_line":"    catalog \u003d request.user.service_catalog"},{"line_number":201,"context_line":"    service \u003d get_service_from_catalog(catalog, service_type)"},{"line_number":202,"context_line":"    if service:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fa2c%3D","line":199,"in_reply_to":"AAAAOn%2F%2FbDA%3D","updated":"2013-05-10 04:09:45.000000000","message":"Thanks for the suggestion. Agree, there is a way to simplify the code. I\u0027ll apply in the next patch.","commit_id":"f7df9759297066dd6493df28958fb35833a39abb"}],"openstack_dashboard/local/local_settings.py.example":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"7fe31faf4420ab84884c7986058e5d1c1673a811","unresolved":false,"context_lines":[{"line_number":34,"context_line":"# OPENSTACK_API_VERSIONS \u003d {"},{"line_number":35,"context_line":"#     \"identity\": 3"},{"line_number":36,"context_line":"# }"},{"line_number":37,"context_line":"\t"},{"line_number":38,"context_line":"# Set this to True if running on multi-domain model. When this is enabled, it"},{"line_number":39,"context_line":"# will require user to enter the Domain name in addition to username for login."},{"line_number":40,"context_line":"# OPENSTACK_KEYSTONE_MULTIDOMAIN_SUPPORT \u003d False"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAOn%2F%2Fdwg%3D","line":37,"updated":"2013-05-08 20:53:49.000000000","message":"remove","commit_id":"d349f30d14d56ac6db380c7285de6e70a1b4a5b0"}]}
